)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"d0162083506fe818363c74227d99e1fbfde1fe92","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-27 05:33:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add API tests for router and DHCP port status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add API tests that ensure DHCP ports and router interface ports"},{"line_number":10,"context_line":"become active."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_62422540","line":7,"updated":"2016-07-28 23:08:39.000000000","message":"This test is supposed to pass against any Neutron backend. We know the reference implementation updates the port status to ACTIVE, do we know if other backends do this? It might be a nasty surprise to suddenly have a failing test for some. I don\u0027t think any of the 3rd party CI run the tests in the Neutron tree so we can\u0027t use those as a source of info.","commit_id":"d8952e2a6964f9d768ad19d07dca32d82468ad59"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"f7cd1897534df987cde0179e288779e86c7f5d14","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-27 05:33:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add API tests for router and DHCP port status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add API tests that ensure DHCP ports and router interface ports"},{"line_number":10,"context_line":"become active."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_0eb71287","line":7,"updated":"2016-07-29 02:00:57.000000000","message":"Well actually the reason these snuck by is because Nova doesn\u0027t care about the router or dhcp port status.\n\nI think it\u0027s reasonable to impose that ports should be ACTIVE so we have a consistent user experience across backends. Most I know of that do things synchronously on port create just set the status to ACTIVE immediately, so this would not impact them.","commit_id":"d8952e2a6964f9d768ad19d07dca32d82468ad59"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"b18e2eee40648f050a30d15edd868dd55843bb50","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Kevin Benton \u003ckevin@benton.pub\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-27 05:33:02 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add API tests for router and DHCP port status"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add API tests that ensure DHCP ports and router interface ports"},{"line_number":10,"context_line":"become active."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bacf61ea_828c7980","line":7,"in_reply_to":"bacf61ea_62422540","updated":"2016-07-28 23:11:32.000000000","message":"Come to think of it we notify Nova when the status changes, so unless backends out there rely on turning off the Nova option that blocks until it gets the notification from Neutron, it\u0027s a pretty good signal that backends do pay attention to the status field.","commit_id":"d8952e2a6964f9d768ad19d07dca32d82468ad59"}],"neutron/tests/tempest/api/admin/test_dhcp_agent_scheduler.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"4ab1391bd3508e04162ba01a14be03cc37b7df02","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        def dhcp_port_active():"},{"line_number":38,"context_line":"            for p in self.client.list_ports("},{"line_number":39,"context_line":"                    network_id\u003dself.network[\u0027id\u0027])[\u0027ports\u0027]:"},{"line_number":40,"context_line":"                if (p[\u0027device_owner\u0027] \u003d\u003d \u0027network:dhcp\u0027 and"},{"line_number":41,"context_line":"                        p[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027):"},{"line_number":42,"context_line":"                    return True"},{"line_number":43,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_e5d60dc2","line":40,"updated":"2016-07-25 17:59:20.000000000","message":"use label here","commit_id":"eb32dd579806c9777104712ec92650dbd7625630"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"2477f8ed36f45cc7623f8694acb04add6744b985","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        def dhcp_port_active():"},{"line_number":38,"context_line":"            for p in self.client.list_ports("},{"line_number":39,"context_line":"                    network_id\u003dself.network[\u0027id\u0027])[\u0027ports\u0027]:"},{"line_number":40,"context_line":"                if (p[\u0027device_owner\u0027] \u003d\u003d \u0027network:dhcp\u0027 and"},{"line_number":41,"context_line":"                        p[\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027):"},{"line_number":42,"context_line":"                    return True"},{"line_number":43,"context_line":"            return False"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_756398b1","line":40,"in_reply_to":"dada55a8_e5d60dc2","updated":"2016-07-27 05:31:56.000000000","message":"Done","commit_id":"eb32dd579806c9777104712ec92650dbd7625630"}],"neutron/tests/tempest/api/test_routers.py":[{"author":{"_account_id":22800,"name":"Joseph Pasque","email":"jp606j@att.com","username":"jp606j"},"change_message_id":"41b23a3d8fbac1aa2a0d2c295715556b875580d1","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        router \u003d self._create_router(data_utils.rand_name(\u0027router-\u0027), True)"},{"line_number":163,"context_line":"        intf \u003d self.create_router_interface(router[\u0027id\u0027], subnet[\u0027id\u0027])"},{"line_number":164,"context_line":"        status_active \u003d lambda: self.client.show_port("},{"line_number":165,"context_line":"            intf[\u0027port_id\u0027])[\u0027port\u0027][\u0027status\u0027] \u003d\u003d \u0027ACTIVE\u0027"},{"line_number":166,"context_line":"        utils.wait_until_true(status_active)"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    @test.idempotent_id(\u0027c86ac3a8-50bd-4b00-a6b8-62af84a0765c\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_fdbba173","line":165,"range":{"start_line":165,"start_character":0,"end_line":165,"end_character":58},"updated":"2016-07-27 19:31:57.000000000","message":"Does this need a label as well?","commit_id":"d8952e2a6964f9d768ad19d07dca32d82468ad59"}]}