)]}'
{"neutron/tests/unit/nicira/test_agent_scheduler.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"72836018f36943f6d8dca5e857e68abcf3c75153","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        test_config[\u0027config_files\u0027] \u003d [NVP_INI_CONFIG_PATH]"},{"line_number":34,"context_line":"        test_config[\u0027plugin_name_v2\u0027] \u003d PLUGIN_NAME"},{"line_number":35,"context_line":"        test_config[\u0027config_files\u0027] \u003d [NVP_INI_CONFIG_PATH]"},{"line_number":36,"context_line":"        super(NVPAgentSchedulerTestCase, self).setUp()"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2F3OE%3D","line":34,"updated":"2013-07-10 07:41:03.000000000","message":"Updating config is not enough: need to override OvsAgentSchedulerTestCase.plugin_str. Otherwise the test is running against ovs plugin (including l3 agent scheduler tests). Also I believe that OvsAgentSchedulerTestCase should be divided into two test cases - for dhcp and l3 scheduling.","commit_id":"2a9c547842c135fcfca21f4a41e6a7fc69102867"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9140ac5a9203525796a6e531d6f2164af0783fd0","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def setUp(self):"},{"line_number":33,"context_line":"        test_config[\u0027config_files\u0027] \u003d [NVP_INI_CONFIG_PATH]"},{"line_number":34,"context_line":"        test_config[\u0027plugin_name_v2\u0027] \u003d PLUGIN_NAME"},{"line_number":35,"context_line":"        test_config[\u0027config_files\u0027] \u003d [NVP_INI_CONFIG_PATH]"},{"line_number":36,"context_line":"        super(NVPAgentSchedulerTestCase, self).setUp()"},{"line_number":37,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAP3%2F%2F2Bw%3D","line":34,"in_reply_to":"AAAAP3%2F%2F3OE%3D","updated":"2013-07-10 14:45:39.000000000","message":"Thanks for the heads-up, I\u0027ll look into that.","commit_id":"2a9c547842c135fcfca21f4a41e6a7fc69102867"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"e48f43adbc4aea80bd4f96cd575a8691ebcb851f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                                   \u0027etc/nvp.ini.full.test\u0027)"},{"line_number":28,"context_line":"NVP_STUBS_PATH \u003d os.path.join(os.path.dirname(__file__), \u0027etc\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"PLUGIN_NAME \u003d \u0027%s.NeutronPlugin.NvpPluginV2\u0027 % nvp_plugin.__name__"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class NVPDhcpAgentNotifierTestCase(test_base.OvsDhcpAgentNotifierTestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAQn%2F%2F7Bo%3D","line":30,"updated":"2013-07-19 03:19:41.000000000","message":"Not something to hold up the reivew, byt why not just import the symbol?\n\nimport neutron.plugins.nicira.NeutronPlugin as nvp_plugin\n\nv2 \u003d nvp_plugin.NvpPluginV2\n\n\u0027%s.%s\u0027 % (v2.__module__, v2.__name__)","commit_id":"a1e483d049a104a8475febc828107c4b323f6def"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"a3c04c45d50e528b9d80ae08aab0193f07fb0c9f","unresolved":false,"context_lines":[{"line_number":27,"context_line":"                                   \u0027etc/nvp.ini.full.test\u0027)"},{"line_number":28,"context_line":"NVP_STUBS_PATH \u003d os.path.join(os.path.dirname(__file__), \u0027etc\u0027)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"PLUGIN_NAME \u003d \u0027%s.NeutronPlugin.NvpPluginV2\u0027 % nvp_plugin.__name__"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"class NVPDhcpAgentNotifierTestCase(test_base.OvsDhcpAgentNotifierTestCase):"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAQn%2F%2F65w%3D","line":30,"in_reply_to":"AAAAQn%2F%2F7Bo%3D","updated":"2013-07-19 05:54:23.000000000","message":"I will clean this up...I think this is sprinkled in a few nicira\u0027s related places.","commit_id":"a1e483d049a104a8475febc828107c4b323f6def"}],"neutron/tests/unit/openvswitch/test_agent_scheduler.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"77805b4928e30fee759166525cda9eb0c930f7a1","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                admin_context\u003dFalse)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class OvsDhcpAgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"},{"line_number":531,"context_line":"                                   test_agent_ext_plugin.AgentDBTestMixIn,"},{"line_number":532,"context_line":"                                   AgentSchedulerTestMixIn,"},{"line_number":533,"context_line":"                                   test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2Fyq0%3D","line":530,"updated":"2013-07-11 12:00:19.000000000","message":"Could you please clarify why you moved dhcp sheduler tests to dhcp notifier test case? Consider 4 test cases: scheduler and notifier for both dhcp and l3.","commit_id":"5cda7b90111767ca02ba87ab55efe7f1e1920d79"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7309bef7ebb5dcff522b961c86a3a4c9f73be160","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                admin_context\u003dFalse)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class OvsDhcpAgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"},{"line_number":531,"context_line":"                                   test_agent_ext_plugin.AgentDBTestMixIn,"},{"line_number":532,"context_line":"                                   AgentSchedulerTestMixIn,"},{"line_number":533,"context_line":"                                   test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2FvHI%3D","line":530,"in_reply_to":"AAAAP3%2F%2Fxt4%3D","updated":"2013-07-12 06:22:04.000000000","message":"Yeah, my concern is about naming mostly, scheduler tests should be under scheduler test case while notification tests under notifier test case","commit_id":"5cda7b90111767ca02ba87ab55efe7f1e1920d79"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"8a1e89ea70369c19a557a9f8ec6021fd886a6be1","unresolved":false,"context_lines":[{"line_number":527,"context_line":"                admin_context\u003dFalse)"},{"line_number":528,"context_line":""},{"line_number":529,"context_line":""},{"line_number":530,"context_line":"class OvsDhcpAgentNotifierTestCase(test_l3_plugin.L3NatTestCaseMixin,"},{"line_number":531,"context_line":"                                   test_agent_ext_plugin.AgentDBTestMixIn,"},{"line_number":532,"context_line":"                                   AgentSchedulerTestMixIn,"},{"line_number":533,"context_line":"                                   test_plugin.NeutronDbPluginV2TestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2Fxt4%3D","line":530,"in_reply_to":"AAAAP3%2F%2Fyq0%3D","updated":"2013-07-11 16:18:54.000000000","message":"To be honest I am not sure the old split made sense, the two test cases derive from the same set of classes, so from a functional standpoint tests in one class or the other makes no difference. I think it\u0027s a matter of naming...but we can review that if you think it may spark confusion.","commit_id":"5cda7b90111767ca02ba87ab55efe7f1e1920d79"}],"quantum/plugins/nicira/QuantumPlugin.py":[{"author":{"_account_id":261,"name":"Salvatore Orlando","email":"salv.orlando@gmail.com","username":"salvatore-orlando"},"change_message_id":"0c08347dd641b34e7638fa4e3163f6145c4be657","unresolved":false,"context_lines":[{"line_number":2146,"context_line":"    # the agent extension was not one monolitic block."},{"line_number":2147,"context_line":"    # NOTE(armando-migliaccio): NotImplementationError\u0027s do not"},{"line_number":2148,"context_line":"    # currently translate in 501 http errors, which is confusing"},{"line_number":2149,"context_line":"    # for the client."},{"line_number":2150,"context_line":"    def add_router_to_l3_agent(self, context, id, router_id):"},{"line_number":2151,"context_line":"        raise NotImplementedError(_(\"NVP does not support L3 \""},{"line_number":2152,"context_line":"                                  \"Agent Scheduling, because \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FiLo%3D","line":2149,"updated":"2013-06-28 10:57:50.000000000","message":"I think it was a design decision to mask all unknown exceptions as 500.\nKnown exceptions are added to the FAULT_MAP.\nIt should work for 5xx as well, but I\u0027ve never tried it.","commit_id":"8d03aca0ac0cba68fadf9267fd7ee3690b7ae7a1"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ae9496c9860e683ed9141037486da96fa8809a08","unresolved":false,"context_lines":[{"line_number":2146,"context_line":"    # the agent extension was not one monolitic block."},{"line_number":2147,"context_line":"    # NOTE(armando-migliaccio): NotImplementationError\u0027s do not"},{"line_number":2148,"context_line":"    # currently translate in 501 http errors, which is confusing"},{"line_number":2149,"context_line":"    # for the client."},{"line_number":2150,"context_line":"    def add_router_to_l3_agent(self, context, id, router_id):"},{"line_number":2151,"context_line":"        raise NotImplementedError(_(\"NVP does not support L3 \""},{"line_number":2152,"context_line":"                                  \"Agent Scheduling, because \""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FhjE%3D","line":2149,"in_reply_to":"AAAAPn%2F%2FiLo%3D","updated":"2013-06-28 15:06:16.000000000","message":"Well...I think it was the wrong design decision! I\u0027ll have a look into the FAULT_MAP and act accordingly. The drawback of changing this is that\u0027s going to break bw compatibility on the API response codes so I don\u0027t know if people would feel strongly about this.","commit_id":"8d03aca0ac0cba68fadf9267fd7ee3690b7ae7a1"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"change_message_id":"30c258e819112fd89bacff2bcd82be5046f3eb46","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        return super(NvpPluginV2, self).delete_qos_queue(context, id)"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"    # NOTE(armando-migliaccio): this should not be necessary if"},{"line_number":2146,"context_line":"    # the agent extension was not one monolitic block."},{"line_number":2147,"context_line":"    def add_router_to_l3_agent(self, context, id, router_id):"},{"line_number":2148,"context_line":"        raise NotImplementedError(_(\"NVP does not support L3 \""},{"line_number":2149,"context_line":"                                  \"Agent Scheduling, because \""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2Fbwo%3D","line":2146,"updated":"2013-07-02 01:36:57.000000000","message":"agent extension or agent scheduler extension?","commit_id":"843dc8a73254e60b6ce8abedbdda68257f1935b9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d5857f5f067399900f17456cc10d699499d3ec55","unresolved":false,"context_lines":[{"line_number":2143,"context_line":"        return super(NvpPluginV2, self).delete_qos_queue(context, id)"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"    # NOTE(armando-migliaccio): this should not be necessary if"},{"line_number":2146,"context_line":"    # the agent extension was not one monolitic block."},{"line_number":2147,"context_line":"    def add_router_to_l3_agent(self, context, id, router_id):"},{"line_number":2148,"context_line":"        raise NotImplementedError(_(\"NVP does not support L3 \""},{"line_number":2149,"context_line":"                                  \"Agent Scheduling, because \""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAPn%2F%2FYhE%3D","line":2146,"in_reply_to":"AAAAPn%2F%2Fbwo%3D","updated":"2013-07-02 22:30:17.000000000","message":"scheduler...sorry I forgot that","commit_id":"843dc8a73254e60b6ce8abedbdda68257f1935b9"}]}