)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"ed39a1bacd7dab178c0f1af22ff9e499cc248113","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_143fd9b4","line":7,"updated":"2016-07-26 16:30:33.000000000","message":"so long as we\u0027re nit-picking, this is no longer up to date  with the content of the patch.","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c445b7ca8feb35eb1e78a0f67b161adb7762de76","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_f242150e","line":7,"in_reply_to":"dada55a8_143fd9b4","updated":"2016-07-26 17:07:30.000000000","message":"you mean, we still use them, but just not for oslo.config core_plugin option?","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c06a0f84f173109b9783dd1ecf01a963d6d15537","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_bd3653b2","line":7,"in_reply_to":"dada55a8_6ff457f0","updated":"2016-07-27 15:43:10.000000000","message":"nicely shaved!","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"dbfed3d171b59e27e3d126d9136936fdd70c1f0a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_ef5b2720","line":7,"in_reply_to":"dada55a8_8dc1dce6","updated":"2016-07-27 10:38:46.000000000","message":"But not only *unit* tests.","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f1c1312502b54f3d00dfbe77437b2d6a13445c99","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_8dc1dce6","line":7,"in_reply_to":"dada55a8_ac52f432","updated":"2016-07-27 08:30:06.000000000","message":"Not sure I follow. The patch touches tests/ directory only.","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"26dbfb43616dad3b78c255e4de38c0cffd61300a","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_6ff457f0","line":7,"in_reply_to":"dada55a8_ef5b2720","updated":"2016-07-27 10:40:02.000000000","message":"Oh well. Sec, let me shave the yak.","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"9575c0c9c620e853701622430d80693dd18a7b1d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ihar Hrachyshka \u003cihrachys@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-26 13:46:29 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"tests: stop using ml2 plugin full import paths in unit tests"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Stevedore documentation suggest that full import paths are not supposed"},{"line_number":10,"context_line":"to be user visible. Since unit tests emulate users when configuring"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dada55a8_ac52f432","line":7,"in_reply_to":"dada55a8_f242150e","updated":"2016-07-26 22:14:02.000000000","message":"Maybe Armando means that it\u0027s not only in unit tests?","commit_id":"6c3d16b1c47ee6bfaaf0d40311cbb4ec408b3cd8"}],"neutron/tests/functional/test_server.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"764eba40b2f7bebf9d6551fcbe0ba5f337a7fd64","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def setUp(self):"},{"line_number":225,"context_line":"        super(TestRPCServer, self).setUp()"},{"line_number":226,"context_line":"        self.setup_coreplugin(\u0027ml2\u0027)"},{"line_number":227,"context_line":"        self._plugin_patcher \u003d mock.patch(TARGET_PLUGIN, autospec\u003dTrue)"},{"line_number":228,"context_line":"        self.plugin \u003d self._plugin_patcher.start()"},{"line_number":229,"context_line":"        self.plugin.return_value.rpc_workers_supported \u003d True"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_6f0d778e","line":227,"range":{"start_line":227,"start_character":42,"end_line":227,"end_character":55},"updated":"2016-07-27 10:51:25.000000000","message":"Suggestion: We could completely avoid using full paths by calling\n\n plugin_cls \u003d utils.load_class_by_alias_or_classname(\u0027ml2\u0027)","commit_id":"2a23527a9a55fe8634c9255ca7ab969918de511a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"f4f92e8d16ebbb9467ffbf0f0acf19aa54b75d1a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def setUp(self):"},{"line_number":225,"context_line":"        super(TestRPCServer, self).setUp()"},{"line_number":226,"context_line":"        self.setup_coreplugin(\u0027ml2\u0027)"},{"line_number":227,"context_line":"        self._plugin_patcher \u003d mock.patch(TARGET_PLUGIN, autospec\u003dTrue)"},{"line_number":228,"context_line":"        self.plugin \u003d self._plugin_patcher.start()"},{"line_number":229,"context_line":"        self.plugin.return_value.rpc_workers_supported \u003d True"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_528adc1b","line":227,"range":{"start_line":227,"start_character":42,"end_line":227,"end_character":55},"in_reply_to":"dada55a8_524f7c6a","updated":"2016-07-27 11:06:27.000000000","message":"Fair enough","commit_id":"2a23527a9a55fe8634c9255ca7ab969918de511a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2f9e5644f96faad3a3417ef8b74230a89154f255","unresolved":false,"context_lines":[{"line_number":224,"context_line":"    def setUp(self):"},{"line_number":225,"context_line":"        super(TestRPCServer, self).setUp()"},{"line_number":226,"context_line":"        self.setup_coreplugin(\u0027ml2\u0027)"},{"line_number":227,"context_line":"        self._plugin_patcher \u003d mock.patch(TARGET_PLUGIN, autospec\u003dTrue)"},{"line_number":228,"context_line":"        self.plugin \u003d self._plugin_patcher.start()"},{"line_number":229,"context_line":"        self.plugin.return_value.rpc_workers_supported \u003d True"},{"line_number":230,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"dada55a8_524f7c6a","line":227,"range":{"start_line":227,"start_character":42,"end_line":227,"end_character":55},"in_reply_to":"dada55a8_6f0d778e","updated":"2016-07-27 10:57:37.000000000","message":"Yeah. But the goal is not to switch all occurrences of using the full path, but where we use it for core_plugin config option.","commit_id":"2a23527a9a55fe8634c9255ca7ab969918de511a"}],"neutron/tests/unit/extensions/test_quotasv2.py":[{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"e6682b5b0f74e703a2c29a776e3bb9a90f837b63","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DEFAULT_QUOTAS_ACTION \u003d \u0027default\u0027"},{"line_number":39,"context_line":"TARGET_PLUGIN \u003d \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_get_path \u003d test_base._get_path"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_9d0e7c30","line":39,"updated":"2016-07-25 22:55:53.000000000","message":"This is now used only in a single place to mock it, we can maybe remove the variable and in-line it.","commit_id":"a55ce3787c9760d2e5e364f9cdb5a978b0f4adbb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"05592696bf21e36edcaf579bbbb0af87f7939dd3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"DEFAULT_QUOTAS_ACTION \u003d \u0027default\u0027"},{"line_number":39,"context_line":"TARGET_PLUGIN \u003d \u0027neutron.plugins.ml2.plugin.Ml2Plugin\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"_get_path \u003d test_base._get_path"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_3cb7773b","line":39,"in_reply_to":"dada55a8_9d0e7c30","updated":"2016-07-26 11:39:39.000000000","message":"I am not sure it will help readability since I will need to wrap. I hope it\u0027s ok to leave it as is. Tell me if not.","commit_id":"a55ce3787c9760d2e5e364f9cdb5a978b0f4adbb"}]}