)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dfbec33c46986306b972c087a3ad722f3ce7eaea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass timeout in milliseconds to timer_wait"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS Python library expects milliseconds to be passed to"},{"line_number":10,"context_line":"timer_wait and we were passing the value in seconds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae4b682c0774e749eb48cde67cd9748d7dfe053c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_00406fa4","line":10,"updated":"2016-07-25 18:14:12.000000000","message":"this ought to have some side effects, no bug report?","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7896e39a09d77de1449729770beced9680c41790","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass timeout in milliseconds to timer_wait"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS Python library expects milliseconds to be passed to"},{"line_number":10,"context_line":"timer_wait and we were passing the value in seconds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae4b682c0774e749eb48cde67cd9748d7dfe053c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_60f16b6a","line":10,"in_reply_to":"dada55a8_00406fa4","updated":"2016-07-25 18:18:33.000000000","message":"The only real downside is that we wake up more often in a poll() call than we need to. It probably has some performance side-effect, but doesn\u0027t really cause any noticeable behavior change.\n\nIf you still want me to open a bug on it I can, but I just happened to notice it when writing a different patch. I doubt anyone would notice it otherwise.","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e46a118885ebd342906a24e5dd3f7ed914b0ec36","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Pass timeout in milliseconds to timer_wait"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The OVS Python library expects milliseconds to be passed to"},{"line_number":10,"context_line":"timer_wait and we were passing the value in seconds."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Iae4b682c0774e749eb48cde67cd9748d7dfe053c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_e020bbb2","line":10,"in_reply_to":"dada55a8_60f16b6a","updated":"2016-07-25 18:21:34.000000000","message":"might be worth adding this on the commit message for reviewer\u0027s sake.","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"}],"neutron/agent/ovsdb/native/connection.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"dfbec33c46986306b972c087a3ad722f3ce7eaea","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":107,"context_line":"            #TODO(jlibosva): Remove next line once losing connection to ovsdb"},{"line_number":108,"context_line":"            #                is solved."},{"line_number":109,"context_line":"            self.poller.timer_wait(self.timeout * 1000)"},{"line_number":110,"context_line":"            self.poller.block()"},{"line_number":111,"context_line":"            self.idl.run()"},{"line_number":112,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_e021dbfd","line":109,"updated":"2016-07-25 18:14:12.000000000","message":"I see the same in neutron/agent/ovsdb/native/idlutils.py, wouldn\u0027t be safer to store self.timeout directly in milliseconds? It might prevent this from happening again. Thoughts?","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e46a118885ebd342906a24e5dd3f7ed914b0ec36","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":107,"context_line":"            #TODO(jlibosva): Remove next line once losing connection to ovsdb"},{"line_number":108,"context_line":"            #                is solved."},{"line_number":109,"context_line":"            self.poller.timer_wait(self.timeout * 1000)"},{"line_number":110,"context_line":"            self.poller.block()"},{"line_number":111,"context_line":"            self.idl.run()"},{"line_number":112,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_e0071b1b","line":109,"in_reply_to":"dada55a8_60bfab60","updated":"2016-07-25 18:21:34.000000000","message":"Ok, this feels rather error prone though.","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c6e55a7603f0a9e37920e295dc5726f98e0917d8","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":107,"context_line":"            #TODO(jlibosva): Remove next line once losing connection to ovsdb"},{"line_number":108,"context_line":"            #                is solved."},{"line_number":109,"context_line":"            self.poller.timer_wait(self.timeout * 1000)"},{"line_number":110,"context_line":"            self.poller.block()"},{"line_number":111,"context_line":"            self.idl.run()"},{"line_number":112,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_fb950e40","line":109,"in_reply_to":"dada55a8_9be052fc","updated":"2016-07-25 18:36:14.000000000","message":"Though if you\u0027d like to see the property added, it should probably go in a separate patch.","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"0901fe7c6ff901fd101361abc3dbd0b60eb249ab","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":107,"context_line":"            #TODO(jlibosva): Remove next line once losing connection to ovsdb"},{"line_number":108,"context_line":"            #                is solved."},{"line_number":109,"context_line":"            self.poller.timer_wait(self.timeout * 1000)"},{"line_number":110,"context_line":"            self.poller.block()"},{"line_number":111,"context_line":"            self.idl.run()"},{"line_number":112,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_9be052fc","line":109,"in_reply_to":"dada55a8_e0071b1b","updated":"2016-07-25 18:34:04.000000000","message":"I could add a timeout_ms property to make it a little cleaner/hide the calculation. We need both values, so there is always going to be the chance that someone screws it up.","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7896e39a09d77de1449729770beced9680c41790","unresolved":false,"context_lines":[{"line_number":106,"context_line":"            self.poller.fd_wait(self.txns.alert_fileno, poller.POLLIN)"},{"line_number":107,"context_line":"            #TODO(jlibosva): Remove next line once losing connection to ovsdb"},{"line_number":108,"context_line":"            #                is solved."},{"line_number":109,"context_line":"            self.poller.timer_wait(self.timeout * 1000)"},{"line_number":110,"context_line":"            self.poller.block()"},{"line_number":111,"context_line":"            self.idl.run()"},{"line_number":112,"context_line":"            txn \u003d self.txns.get_nowait()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dada55a8_60bfab60","line":109,"in_reply_to":"dada55a8_e021dbfd","updated":"2016-07-25 18:18:33.000000000","message":"There are other places where we end up having to pass the value in seconds as well as when calculating the timeout expiration via time.time() - start_time, etc. I figure default to doing what we have been.","commit_id":"439021152f3eb798366af02f281835acdb7b1df9"}]}