)]}'
{"neutron/conf/services/extdns_designate_driver.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b849fe2481ac0d11e2be852a36f8501d2633be3b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \u0027admin@\u003cdns_domain\u003e\u0027)),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"DESIGNATE_GROUP \u003d \u0027designate\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_1bad1d88","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":29},"updated":"2016-08-01 16:44:29.000000000","message":"this is being used once  in this file. using a variable might not be a good idea","commit_id":"88b69c8b69f96cf015d56ff947c246188128d50c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5f4bfa6110b93f99a70105cd850cf25baca6e0a4","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \u0027admin@\u003cdns_domain\u003e\u0027)),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"DESIGNATE_GROUP \u003d \u0027designate\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_efd8b981","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":15},"updated":"2016-08-03 23:51:50.000000000","message":"being used once, how about using group name directly","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8f7f9b40bdd5449fab6d63a7b528bee030fe84da","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \u0027admin@\u003cdns_domain\u003e\u0027)),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"DESIGNATE_GROUP \u003d \u0027designate\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_59319d59","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":15},"in_reply_to":"bacf61ea_19bf25ab","updated":"2016-08-04 18:56:17.000000000","message":"Done","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a9aae83838fbd0c692d8f54447463d9e67e85e80","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \u0027admin@\u003cdns_domain\u003e\u0027)),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"DESIGNATE_GROUP \u003d \u0027designate\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_19bf25ab","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":15},"in_reply_to":"bacf61ea_efd8b981","updated":"2016-08-04 18:53:18.000000000","message":"+1","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8f7f9b40bdd5449fab6d63a7b528bee030fe84da","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                      \u0027admin@\u003cdns_domain\u003e\u0027)),"},{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"DESIGNATE_GROUP \u003d \u0027designate\u0027"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_a2550fc3","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":15},"in_reply_to":"bacf61ea_efd8b981","updated":"2016-08-04 18:56:17.000000000","message":"Done","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"bea8c705a7f162e25d1cfd6619d5c941577cc799","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"},{"line_number":64,"context_line":"    cfg.register_opts(designate_opts, \u0027designate\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_e0798a30","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":50},"updated":"2016-08-05 13:50:27.000000000","message":"what\u0027s the value of such one-liners?","commit_id":"d1edc07800c47069c48b6771cc711f9a0ae8fab1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"59def5c5a46f485b51293e64aef7db87f9645d02","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"},{"line_number":64,"context_line":"    cfg.register_opts(designate_opts, \u0027designate\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_c6a9fe91","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":50},"in_reply_to":"bacf61ea_a3b79c83","updated":"2016-08-05 14:22:48.000000000","message":"cfg.register_opts() is a registration function and it\u0027s centralized in one location ;)","commit_id":"d1edc07800c47069c48b6771cc711f9a0ae8fab1"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"08c84bf6c0c3ff0bd02576758658194c40a8fe65","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"},{"line_number":64,"context_line":"    cfg.register_opts(designate_opts, \u0027designate\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_000ad325","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":50},"in_reply_to":"bacf61ea_b49a3060","updated":"2016-08-05 17:04:42.000000000","message":"ok, thanks for clarification","commit_id":"d1edc07800c47069c48b6771cc711f9a0ae8fab1"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"c0b5989f45cc6ed15ebea6c7f2b12460a2fd471c","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"},{"line_number":64,"context_line":"    cfg.register_opts(designate_opts, \u0027designate\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_b49a3060","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":50},"in_reply_to":"bacf61ea_c6a9fe91","updated":"2016-08-05 14:58:17.000000000","message":"IIRC the first patch that moved the config options to a central place had a request to have these helper functions.  The benefit of this function is that the module calling this does not have to import olso_config.  It\u0027s a minor benefit, but I do kind of like it and it was requested in the beginning, so this has just been added to each for consistency.","commit_id":"d1edc07800c47069c48b6771cc711f9a0ae8fab1"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"3494703ff76b0945bd4b6a6f20516c63de68378b","unresolved":false,"context_lines":[{"line_number":60,"context_line":"]"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def register_designate_opts(cfg\u003dcfg.CONF):"},{"line_number":64,"context_line":"    cfg.register_opts(designate_opts, \u0027designate\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"bacf61ea_a3b79c83","line":64,"range":{"start_line":63,"start_character":0,"end_line":64,"end_character":50},"in_reply_to":"bacf61ea_e0798a30","updated":"2016-08-05 14:14:15.000000000","message":"This is done so that the config opts and their registration function is centralized at one location and is not scattered everywhere through the code base.","commit_id":"d1edc07800c47069c48b6771cc711f9a0ae8fab1"}],"neutron/conf/services/qos_not_driver_manager.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"19b1649a6fa58493eca21419966d1eca933f843d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bacf61ea_86a41408","updated":"2016-08-01 16:25:35.000000000","message":"i don\u0027t like the name of this module, its kind of confusing.  Can it just be qos_driver_manager.py?","commit_id":"88b69c8b69f96cf015d56ff947c246188128d50c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5f4bfa6110b93f99a70105cd850cf25baca6e0a4","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_0fcf0d80","line":1,"updated":"2016-08-03 23:51:50.000000000","message":"can you rename this file to qos_driver_manager.py ?","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8f7f9b40bdd5449fab6d63a7b528bee030fe84da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_c2700375","line":1,"in_reply_to":"bacf61ea_0fcf0d80","updated":"2016-08-04 18:56:17.000000000","message":"Done","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a9aae83838fbd0c692d8f54447463d9e67e85e80","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_d9cf4d54","line":1,"in_reply_to":"bacf61ea_0fcf0d80","updated":"2016-08-04 18:53:18.000000000","message":"i made this suggestion in PS 4 :)","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8f7f9b40bdd5449fab6d63a7b528bee030fe84da","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":2,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":3,"context_line":"#    a copy of the License at"},{"line_number":4,"context_line":"#"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_9937954c","line":1,"in_reply_to":"bacf61ea_d9cf4d54","updated":"2016-08-04 18:56:17.000000000","message":"Fixed now. I somehow missed it :(","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"}],"neutron/services/provider_configuration.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"9ad4edfd81cce83b599ddfda1fd29db1ad324acd","unresolved":false,"context_lines":[{"line_number":38,"context_line":"#]"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"#cfg.CONF.register_opts(serviceprovider_opts, \u0027service_providers\u0027)"},{"line_number":41,"context_line":"prov_config.register_service_provider_opts()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class NeutronModule(object):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d0be77fe","line":41,"updated":"2016-07-28 00:22:42.000000000","message":"This change is affecting neutron-lbaas project[1] and maybe it needs to be handle with debtcollector.\n\n[1] http://logs.openstack.org/44/347044/2/check/gate-tempest-dsvm-neutron-dvr/e455d2d/logs/devstacklog.txt.gz#_2016-07-27_19_51_34_203","commit_id":"88eee769b918f7e0a45663d53fdd72fd327587f0"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b849fe2481ac0d11e2be852a36f8501d2633be3b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"SERVICE_PROVIDERS \u003d \u0027neutron.service_providers\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"serviceprovider_opts \u003d debtcollector.moves.moved_property("},{"line_number":35,"context_line":"     prov_config.serviceprovider_opts, \u0027service_provider_opts\u0027, __name__)"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"prov_config.register_service_provider_opts()"},{"line_number":38,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c1b2764b","line":35,"range":{"start_line":34,"start_character":0,"end_line":35,"end_character":73},"updated":"2016-08-01 16:44:29.000000000","message":"@debtcollector.moves.moved_property(prov_config.serviceprovider_opts)","commit_id":"88b69c8b69f96cf015d56ff947c246188128d50c"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"5f4bfa6110b93f99a70105cd850cf25baca6e0a4","unresolved":false,"context_lines":[{"line_number":34,"context_line":"debtcollector.deprecate("},{"line_number":35,"context_line":"    \u0027Moved serviceprovider_opts to %s\u0027 % prov_config.__name__,"},{"line_number":36,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":37,"context_line":"serviceprovider_opts \u003d prov_config.serviceprovider_opts"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"prov_config.register_service_provider_opts()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_2fff71ab","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":55},"updated":"2016-08-03 23:51:50.000000000","message":"i might be missing something, but why is this line required?","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a9aae83838fbd0c692d8f54447463d9e67e85e80","unresolved":false,"context_lines":[{"line_number":34,"context_line":"debtcollector.deprecate("},{"line_number":35,"context_line":"    \u0027Moved serviceprovider_opts to %s\u0027 % prov_config.__name__,"},{"line_number":36,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":37,"context_line":"serviceprovider_opts \u003d prov_config.serviceprovider_opts"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"prov_config.register_service_provider_opts()"},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_999b1566","line":37,"range":{"start_line":37,"start_character":0,"end_line":37,"end_character":55},"in_reply_to":"bacf61ea_2fff71ab","updated":"2016-08-04 18:53:18.000000000","message":"because the *aas repos still import this directly and expect that option to be here.  So we need to keep this around while the juggling is going on.","commit_id":"cb26fbe479101a0b11ef9ceed81a513cf3aab304"}]}
