)]}'
{"neutron/api/rpc/callbacks/resources.py":[{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"aec48b6bc5f6d9942efbde7dff759d202339eb72","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.objects.qos import policy"},{"line_number":14,"context_line":"from neutron_fwaas.objects import address_group"},{"line_number":15,"context_line":"from neutron_fwaas.objects import firewall_group"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# This logic below could potentially be generalized as a future work,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_3288b7e7","line":15,"updated":"2016-08-19 16:41:30.000000000","message":"You absolutely can not have neutron code importing things from neutron_fwaas.  The relevant objects would need to be duplicated.","commit_id":"f6a110753c2dbd2d6342a6807644b284f6872577"},{"author":{"_account_id":11241,"name":"Padmanabhan Krish","email":"kprad1@yahoo.com","username":"padkrish"},"change_message_id":"fceea1867c77548dcce9872433231cb3fcfd16ba","unresolved":false,"context_lines":[{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.objects.qos import policy"},{"line_number":14,"context_line":"from neutron_fwaas.objects import address_group"},{"line_number":15,"context_line":"from neutron_fwaas.objects import firewall_group"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# This logic below could potentially be generalized as a future work,"}],"source_content_type":"text/x-python","patch_set":2,"id":"1ac06dbe_3b9bb019","line":15,"in_reply_to":"1ac06dbe_3288b7e7","updated":"2016-08-23 23:07:13.000000000","message":"This is the neutron \u003c-\u003e neutron_fwaas dependency we discussed at length earlier. Are you talking about duplicating the complete FwAAS versioned object that we (are) will be developing? Double-committing? Ofcourse, QoS is very much neutron and so they don\u0027t need to duplicate.\nDuplicating the neutron \u0027rpc\u0027 infra logic also doesn\u0027t make sense. \nA better way to do is for the resources like FWaaS/QoS to register with neutron so we don\u0027t have this imports. Are there any effort in neutron lib along these lines?\nWe can discuss more in IRC.","commit_id":"f6a110753c2dbd2d6342a6807644b284f6872577"}]}