)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"e88cec584d9a702c0fb74d9b2269de7cf97f41c1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to be in neutron/conf/agent so that all the config options"},{"line_number":11,"context_line":"reside in a centralized location. This simplifies the"},{"line_number":12,"context_line":"process of looking up the config opts and provides an easy"},{"line_number":13,"context_line":"way to import."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib1e0e63dec2985c417412d1ecc68e2a74ef87182"},{"line_number":16,"context_line":"Partial-Bug: #1563069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"ff346bd7_4d4cd8c6","line":13,"updated":"2017-07-24 23:29:49.000000000","message":"I haven\u0027t watched this too closely, so allow me the question: does this potentially have a NeutronLibImpact?\n\n[1] https://wiki.openstack.org/wiki/Network/Meetings#Neutron-lib.2C_planned_refactoring_and_other_impacts","commit_id":"50174fb376fcba7d8c467e30643e2e76799819e8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"a1a81ecff89286c7573cbbe1af9e8da319b601a3","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to be in neutron/conf/agent so that all the config options"},{"line_number":11,"context_line":"reside in a centralized location. This simplifies the"},{"line_number":12,"context_line":"process of looking up the config opts and provides an easy"},{"line_number":13,"context_line":"way to import."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: Ib1e0e63dec2985c417412d1ecc68e2a74ef87182"},{"line_number":16,"context_line":"Partial-Bug: #1563069"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":50,"id":"ff346bd7_ad2464c7","line":13,"updated":"2017-07-24 23:35:02.000000000","message":"Possibly. It\u0027s a good idea to add it in case someone has another out of tree agent referencing these configs.","commit_id":"50174fb376fcba7d8c467e30643e2e76799819e8"}],"neutron/agent/common/ip_lib.py":[{"author":{"_account_id":10558,"name":"Dustin Lundquist","email":"dustin@null-ptr.net","username":"dlundquist"},"change_message_id":"03223f8c976869a5b32201267341686127e99fa1","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    from neutron.agent.linux import ip_lib"},{"line_number":22,"context_line":"    from neutron.conf.agent import linux as ip_lib_conf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"OPTS \u003d ip_lib_conf.IP_LIB_OPTS"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"IPWrapper \u003d ip_lib.IPWrapper"},{"line_number":27,"context_line":"IPDevice \u003d ip_lib.IPDevice"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_9c7f3914","line":24,"updated":"2016-08-01 21:06:02.000000000","message":"How will this work in the case os.name \u003d\u003d \u0027nt\u0027?","commit_id":"b86d15b7542cf7caaba19d6fed175fd66fde23a4"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"b4663c2382d4d645a40b0316e787ca894bbed5cc","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    from neutron.agent.linux import ip_lib"},{"line_number":22,"context_line":"    from neutron.conf.agent import linux as ip_lib_conf"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"OPTS \u003d ip_lib_conf.IP_LIB_OPTS"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"IPWrapper \u003d ip_lib.IPWrapper"},{"line_number":27,"context_line":"IPDevice \u003d ip_lib.IPDevice"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_9af7008c","line":24,"in_reply_to":"bacf61ea_9c7f3914","updated":"2016-08-02 19:18:50.000000000","message":"Yes it won\u0027t work. Have fixed it","commit_id":"b86d15b7542cf7caaba19d6fed175fd66fde23a4"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e7a1705ac154c0257e9bdccd6049731bc636473a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":20,"context_line":"    from neutron.agent.windows import ip_lib"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib.OPTS"}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_5b388cef","line":18,"updated":"2016-10-13 13:37:00.000000000","message":"nit: extra whitespace","commit_id":"aba06612bfffba17fdc297f4bacd3c14f07b2d2e"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3d6d7134762cd52b466081fdcd5aab9db1f3fc5a","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":20,"context_line":"    from neutron.agent.windows import ip_lib"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib.OPTS"}],"source_content_type":"text/x-python","patch_set":27,"id":"da6895a0_4a5c7fed","line":18,"in_reply_to":"fa6399be_5b388cef","updated":"2016-10-24 02:54:53.000000000","message":"Done","commit_id":"aba06612bfffba17fdc297f4bacd3c14f07b2d2e"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":20,"context_line":"    from neutron.agent.windows import ip_lib"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib.OPTS"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_0bc6df47","line":18,"updated":"2016-10-25 19:33:14.000000000","message":"unnecessary blank line","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":20,"context_line":"    from neutron.agent.windows import ip_lib"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib.OPTS"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_f833a660","line":18,"in_reply_to":"da6895a0_0bc6df47","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":20,"context_line":"    from neutron.agent.windows import ip_lib"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib.OPTS"},{"line_number":22,"context_line":"else:"},{"line_number":23,"context_line":"    from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"    from neutron.conf.agent import linux as ip_lib_conf"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_8be90f83","line":21,"updated":"2016-10-25 19:33:14.000000000","message":"I think you should also move the OPTS variable in the neutron.agent.windows.ip_lib module as well just to keep it consistent.  change the current IP_LIB_OPTS in neutron.conf.agent.linux to IP_LIB_OPTS_LINUX and this one to IP_LIB_OPTS_WINDOWS.  I know its an emtpy list right now but its good to just keep it consistent and if that list ever needs to be populated, its done in the right place.","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":20,"context_line":"    from neutron.agent.windows import ip_lib"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib.OPTS"},{"line_number":22,"context_line":"else:"},{"line_number":23,"context_line":"    from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"    from neutron.conf.agent import linux as ip_lib_conf"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_18393a42","line":21,"in_reply_to":"da6895a0_8be90f83","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.conf.agent import linux as ip_lib_conf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":21,"context_line":"    OPTS \u003d ip_lib_conf.IP_LIB_OPTS_WINDOWS"},{"line_number":22,"context_line":"else:"},{"line_number":23,"context_line":"    from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"    OPTS \u003d ip_lib_conf.IP_LIB_OPTS_LINUX"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IPWrapper \u003d ip_lib.IPWrapper"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_6d3565da","line":24,"range":{"start_line":17,"start_character":0,"end_line":24,"end_character":40},"updated":"2017-03-24 14:37:09.000000000","message":"I think, this piece is incorrectly refactored.\nYou should create neutron.conf.agent.linux with IP_LIB for linux and corresponding change for neutron.conf.agent.windows with IP_LIB for windows. Then you could import it, similar to this, how it was done previously.","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    OPTS \u003d ip_lib_conf.IP_LIB_OPTS_LINUX"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IPWrapper \u003d ip_lib.IPWrapper"},{"line_number":28,"context_line":"IPDevice \u003d ip_lib.IPDevice"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_12bdd8b6","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":26},"updated":"2017-03-24 14:37:09.000000000","message":"This will work only for linux. You\u0027ll get import error, because we\u0027re missing import for Windows env of `ip_lib`","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    OPTS \u003d ip_lib_conf.IP_LIB_OPTS_LINUX"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IPWrapper \u003d ip_lib.IPWrapper"},{"line_number":28,"context_line":"IPDevice \u003d ip_lib.IPDevice"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_26b88c74","line":28,"range":{"start_line":27,"start_character":0,"end_line":28,"end_character":26},"in_reply_to":"ffe62b97_12bdd8b6","updated":"2017-03-24 20:58:09.000000000","message":"yes, will change in the next patch set. thank you for identifying.","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"95d2f6118ec13856f559c269168e793e2ebdf6c5","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"    OPTS \u003d ip_lib_conf.IP_LIB_OPTS_LINUX"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IPWrapper \u003d ip_lib.IPWrapper"},{"line_number":28,"context_line":"IPDevice \u003d ip_lib.IPDevice"}],"source_content_type":"text/x-python","patch_set":42,"id":"ffe62b97_54256cc1","line":28,"range":{"start_line":26,"start_character":0,"end_line":28,"end_character":26},"updated":"2017-03-25 18:21:50.000000000","message":"This piece is still missing","commit_id":"846b02b2ecac5f3b943227054cf2d2d120163931"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f95350699e96fd104af22fea5917720b03535d79","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.conf.agent import linux as ip_lib_conf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":21,"context_line":"    from neutron.agent.windows import ip_lib"}],"source_content_type":"text/x-python","patch_set":43,"id":"dfeb2761_c2b05246","line":18,"updated":"2017-04-04 18:33:54.000000000","message":"\u0027linux\u0027 in the \"common\" part of this file doesn\u0027t look right.","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d9d724d37b5d41459fbb6587fe8dbd5bb116969d","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.conf.agent import linux as ip_lib_conf"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":21,"context_line":"    from neutron.agent.windows import ip_lib"}],"source_content_type":"text/x-python","patch_set":43,"id":"bff0334d_56b6c9db","line":18,"in_reply_to":"dfeb2761_c2b05246","updated":"2017-04-05 19:05:13.000000000","message":"Done","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2fb6aa006671e77904efc2c2056de0a3774ccf17","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.conf.agent import linux as linux_conf"},{"line_number":19,"context_line":"from neutron.conf.agent import windows as windows_conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"}],"source_content_type":"text/x-python","patch_set":49,"id":"3f1d235d_ed62623e","line":18,"updated":"2017-07-02 08:09:09.000000000","message":"should this and the line below be part of the conditional imports below?","commit_id":"4fb0aceda21a2fc563bdd21b200a29a95c4c748b"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c87c9667338489200bdb24ecf0a7de581ea30276","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import os"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.conf.agent import linux as linux_conf"},{"line_number":19,"context_line":"from neutron.conf.agent import windows as windows_conf"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"if os.name \u003d\u003d \u0027nt\u0027:"}],"source_content_type":"text/x-python","patch_set":49,"id":"3f1d235d_5dc14fe4","line":18,"in_reply_to":"3f1d235d_ed62623e","updated":"2017-07-07 13:51:07.000000000","message":"Yes, it looks like it can, let me respin","commit_id":"4fb0aceda21a2fc563bdd21b200a29a95c4c748b"}],"neutron/agent/dhcp_agent.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":36,"context_line":"    conf.register_opts(metadata_config.DRIVER_OPTS)"},{"line_number":37,"context_line":"    conf.register_opts(metadata_config.SHARED_OPTS)"},{"line_number":38,"context_line":"    linux.register_interface_opts(cfg.CONF)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9c022308","line":38,"updated":"2016-07-28 21:03:11.000000000","message":"In linux.py the register method (def register_interface_opts(cfg\u003dcfg.CONF):) has the default value for cfg as cfg.CONF. So using  cfg.CONF in linux.register_interface_opts is redundant it can be replaced with linux.register_interface_opts().","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":36,"context_line":"    conf.register_opts(metadata_config.DRIVER_OPTS)"},{"line_number":37,"context_line":"    conf.register_opts(metadata_config.SHARED_OPTS)"},{"line_number":38,"context_line":"    linux.register_interface_opts(cfg.CONF)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def main():"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b4a437a6","line":38,"in_reply_to":"bacf61ea_9c022308","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"}],"neutron/agent/l3_agent.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    linux_conf.register_interface_opts(cfg.CONF)"},{"line_number":40,"context_line":"    linux_conf.register_external_process_opts(cfg.CONF)"},{"line_number":41,"context_line":"    linux_conf.register_pddriver_opts(cfg.CONF)"},{"line_number":42,"context_line":"    linux_conf.register_ra_opts(cfg.CONF)"},{"line_number":43,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3c3b37d3","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":41},"updated":"2016-07-28 21:03:11.000000000","message":"line (39-42): ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    linux_conf.register_interface_opts(cfg.CONF)"},{"line_number":40,"context_line":"    linux_conf.register_external_process_opts(cfg.CONF)"},{"line_number":41,"context_line":"    linux_conf.register_pddriver_opts(cfg.CONF)"},{"line_number":42,"context_line":"    linux_conf.register_ra_opts(cfg.CONF)"},{"line_number":43,"context_line":"    config.register_availability_zone_opts_helper(conf)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_34b7a7d9","line":42,"range":{"start_line":42,"start_character":0,"end_line":42,"end_character":41},"in_reply_to":"bacf61ea_3c3b37d3","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"}],"neutron/agent/linux/external_process.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"external_process.register_external_process_opts(cfg.CONF)"},{"line_number":37,"context_line":"agent_cfg.register_process_monitor_opts(cfg.CONF)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_ba5b3985","line":36,"range":{"start_line":36,"start_character":48,"end_line":36,"end_character":56},"updated":"2016-08-05 15:47:42.000000000","message":"this is not necessary as default value is set to cfg.CONF","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"external_process.register_external_process_opts(cfg.CONF)"},{"line_number":37,"context_line":"agent_cfg.register_process_monitor_opts(cfg.CONF)"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_bbbe9862","line":36,"range":{"start_line":36,"start_character":48,"end_line":36,"end_character":56},"in_reply_to":"bacf61ea_ba5b3985","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to %s\u0027 % external_process.__name__,"},{"line_number":42,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":43,"context_line":"OPTS \u003d external_process.EXTERNAL_PROCESS_OPTS"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_8b84afd4","line":43,"updated":"2016-10-25 19:33:14.000000000","message":"I don\u0027t think we need this, unless there\u0027s some external repo that is importing this option.  Even if that is the case, they shouldn\u0027t be.  So i don\u0027t think this is needed, no deprecation period needed, just move it.","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to %s\u0027 % external_process.__name__,"},{"line_number":42,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":43,"context_line":"OPTS \u003d external_process.EXTERNAL_PROCESS_OPTS"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_18105aa8","line":43,"in_reply_to":"da6895a0_8b84afd4","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":29,"context_line":"from neutron.agent.linux import utils"},{"line_number":30,"context_line":"from neutron.conf.agent import common as agent_cfg"},{"line_number":31,"context_line":"from neutron.conf.agent import linux as external_process"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_4ded01ee","line":31,"range":{"start_line":31,"start_character":40,"end_line":31,"end_character":56},"updated":"2017-03-24 14:37:09.000000000","message":"Could you change this to linux_conf for consistency across other places? It would simplify further understanding and development.","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":29,"context_line":"from neutron.agent.linux import utils"},{"line_number":30,"context_line":"from neutron.conf.agent import common as agent_cfg"},{"line_number":31,"context_line":"from neutron.conf.agent import linux as external_process"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_00efb084","line":31,"range":{"start_line":31,"start_character":40,"end_line":31,"end_character":56},"in_reply_to":"ffe62b97_4ded01ee","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to %s\u0027 % external_process.__name__,"},{"line_number":42,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_121958d6","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":19},"updated":"2017-03-24 14:37:09.000000000","message":"You need to update versions","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to %s\u0027 % external_process.__name__,"},{"line_number":42,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_409a5814","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":19},"in_reply_to":"ffe62b97_121958d6","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/agent/linux/interface.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":35,"context_line":"debtcollector.deprecate("},{"line_number":36,"context_line":"    \u0027Moved OPTS to %s\u0027 % interface.__name__,"},{"line_number":37,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":38,"context_line":"OPTS \u003d interface.OPTS"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_cb6ea72e","line":38,"updated":"2016-10-25 19:33:14.000000000","message":"same comment","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":35,"context_line":"debtcollector.deprecate("},{"line_number":36,"context_line":"    \u0027Moved OPTS to %s\u0027 % interface.__name__,"},{"line_number":37,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":38,"context_line":"OPTS \u003d interface.OPTS"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_b8776e07","line":38,"in_reply_to":"da6895a0_cb6ea72e","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"debtcollector.deprecate("},{"line_number":37,"context_line":"    \u0027Moved OPTS to %s\u0027 % linux_conf.__name__,"},{"line_number":38,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _get_veth(name1, name2, namespace2):"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_521ec0ba","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":19},"updated":"2017-03-24 14:37:09.000000000","message":"Please update versions","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"debtcollector.deprecate("},{"line_number":37,"context_line":"    \u0027Moved OPTS to %s\u0027 % linux_conf.__name__,"},{"line_number":38,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def _get_veth(name1, name2, namespace2):"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_007210e6","line":38,"range":{"start_line":38,"start_character":13,"end_line":38,"end_character":19},"in_reply_to":"ffe62b97_521ec0ba","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"OPTS \u003d ["},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027ip_lib_force_root\u0027,"},{"line_number":37,"context_line":"                default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d_(\u0027Force ip_lib calls to use the root helper\u0027)),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOOPBACK_DEVNAME \u003d \u0027lo\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_75eef222","side":"PARENT","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":1},"updated":"2016-08-05 15:47:42.000000000","message":"it seems that OPTS is not being registered in this file","commit_id":"26bbc783d2077665dfca9910ec3eaac49b10ffc2"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"OPTS \u003d ["},{"line_number":36,"context_line":"    cfg.BoolOpt(\u0027ip_lib_force_root\u0027,"},{"line_number":37,"context_line":"                default\u003dFalse,"},{"line_number":38,"context_line":"                help\u003d_(\u0027Force ip_lib calls to use the root helper\u0027)),"},{"line_number":39,"context_line":"]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"LOOPBACK_DEVNAME \u003d \u0027lo\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_db6eecfe","side":"PARENT","line":39,"range":{"start_line":35,"start_character":0,"end_line":39,"end_character":1},"in_reply_to":"bacf61ea_75eef222","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"26bbc783d2077665dfca9910ec3eaac49b10ffc2"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e90c5ea3ecd6f689af11c9e2417da10d7bee53e","unresolved":false,"context_lines":[{"line_number":34,"context_line":"from neutron.privileged.agent.linux import ip_lib as privileged"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"IP_NONLOCAL_BIND \u003d \u0027net.ipv4.ip_nonlocal_bind\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"LOOPBACK_DEVNAME \u003d \u0027lo\u0027"}],"source_content_type":"text/x-python","patch_set":47,"id":"ff0f0b1f_719c850d","line":37,"updated":"2017-05-23 19:23:46.000000000","message":"No debtcollector warning like other files?","commit_id":"13e371771ba777a2586d6bb7cea2c7c05ccbfd76"},{"author":{"_account_id":6854,"name":"YAMAMOTO Takashi","email":"yamamoto@midokura.com","username":"yamamoto"},"change_message_id":"8a4843f234f83c1c58d4fd33789119cc4f8e2578","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to OS-specific files\u0027,"},{"line_number":42,"context_line":"    version\u003d\"pike\", removal_version\u003d\"queens\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"IP_NONLOCAL_BIND \u003d \u0027net.ipv4.ip_nonlocal_bind\u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"df140735_1b5d3246","line":42,"updated":"2017-06-06 09:32:57.000000000","message":"does this mean to warn when this module is imported?\nit\u0027s too verbose i guess.\ni suspect either debtcollector.moves or removals is more appropriate.","commit_id":"d0ffde080e0f04751d93073dc316b41f2aa128f6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e5a626d4b09cadec4ed87082cc66dd0bcc4cef3d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to OS-specific files\u0027,"},{"line_number":42,"context_line":"    version\u003d\"pike\", removal_version\u003d\"queens\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"IP_NONLOCAL_BIND \u003d \u0027net.ipv4.ip_nonlocal_bind\u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"3f1d235d_544c539d","line":42,"in_reply_to":"7f231b9d_39d0ebc9","updated":"2017-06-30 15:00:48.000000000","message":"I\u0027m just going to remove this from here and other files since I don\u0027t see what it gets us, out-of-tree users that were referencing OPTS are still going to be broken.","commit_id":"d0ffde080e0f04751d93073dc316b41f2aa128f6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2105a1e95f92e30edf4bf00fd877605d295a762e","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to OS-specific files\u0027,"},{"line_number":42,"context_line":"    version\u003d\"pike\", removal_version\u003d\"queens\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"IP_NONLOCAL_BIND \u003d \u0027net.ipv4.ip_nonlocal_bind\u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"7f231b9d_39d0ebc9","line":42,"in_reply_to":"df140735_1b5d3246","updated":"2017-06-09 16:00:54.000000000","message":"I guess it could, although I don\u0027t see it in the logs, I had to import warnings and set it to always warn to see anything locally.\n\nThat said, this is done in other files too, and I don\u0027t see the point in it exactly since if you\u0027re expecting OPTS to be here your code is going to be broken.\n\nThoughts?","commit_id":"d0ffde080e0f04751d93073dc316b41f2aa128f6"}],"neutron/agent/linux/pd.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"debtcollector.deprecate("},{"line_number":37,"context_line":"    \u0027Moved OPTS to %s\u0027 % pd.__name__,"},{"line_number":38,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":39,"context_line":"OPTS \u003d pd.PD_OPTS"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class PrefixDelegation(object):"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_0bfedf36","line":39,"updated":"2016-10-25 19:33:14.000000000","message":"same comment","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":36,"context_line":"debtcollector.deprecate("},{"line_number":37,"context_line":"    \u0027Moved OPTS to %s\u0027 % pd.__name__,"},{"line_number":38,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":39,"context_line":"OPTS \u003d pd.PD_OPTS"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class PrefixDelegation(object):"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_7876b607","line":39,"in_reply_to":"da6895a0_0bfedf36","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"debtcollector.deprecate("},{"line_number":39,"context_line":"    \u0027Moved OPTS to %s\u0027 % linux_conf.__name__,"},{"line_number":40,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class PrefixDelegation(object):"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_d28770d7","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":19},"updated":"2017-03-24 14:37:09.000000000","message":"Version is outdated. We should change that to Pike","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"debtcollector.deprecate("},{"line_number":39,"context_line":"    \u0027Moved OPTS to %s\u0027 % linux_conf.__name__,"},{"line_number":40,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"class PrefixDelegation(object):"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_80562029","line":40,"range":{"start_line":40,"start_character":13,"end_line":40,"end_character":19},"in_reply_to":"ffe62b97_d28770d7","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/agent/linux/pd_driver.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pd_driver.register_pddriver_opts(cfg.CONF)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7c4c8f70","line":23,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pd_driver.register_pddriver_opts(cfg.CONF)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_54b4dbcf","line":23,"in_reply_to":"bacf61ea_7c4c8f70","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pd_driver.register_pddriver_opts(cfg.CONF)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_15985677","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":27},"updated":"2016-08-05 15:47:42.000000000","message":"this import can be removed if changes are made in L23","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pd_driver.register_pddriver_opts(cfg.CONF)"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_7b80a08b","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":27},"in_reply_to":"bacf61ea_15985677","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pd_driver.register_pddriver_opts(cfg.CONF)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_15d17623","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":41},"updated":"2016-08-05 15:47:42.000000000","message":"not needed","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":21,"context_line":"from oslo_config import cfg"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"pd_driver.register_pddriver_opts(cfg.CONF)"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_5b7b1cbe","line":23,"range":{"start_line":23,"start_character":33,"end_line":23,"end_character":41},"in_reply_to":"bacf61ea_15d17623","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"pd_driver.register_pddriver_opts()"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_adcfed7d","line":20,"range":{"start_line":20,"start_character":40,"end_line":20,"end_character":49},"updated":"2017-03-24 14:37:09.000000000","message":"Could you change that to linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import six"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.conf.agent import linux as pd_driver"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"pd_driver.register_pddriver_opts()"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_7b47514d","line":20,"range":{"start_line":20,"start_character":40,"end_line":20,"end_character":49},"in_reply_to":"ffe62b97_adcfed7d","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/agent/linux/ra.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"debtcollector.deprecate("},{"line_number":39,"context_line":"    \u0027Moved OPTS to %s\u0027 % ra.__name__,"},{"line_number":40,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":41,"context_line":"OPTS \u003d ra.RA_OPTS"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONFIG_TEMPLATE \u003d jinja2.Template(\"\"\"interface {{ interface_name }}"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_cb8a27bf","line":41,"updated":"2016-10-25 19:33:14.000000000","message":"ditto","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"debtcollector.deprecate("},{"line_number":39,"context_line":"    \u0027Moved OPTS to %s\u0027 % ra.__name__,"},{"line_number":40,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":41,"context_line":"OPTS \u003d ra.RA_OPTS"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"CONFIG_TEMPLATE \u003d jinja2.Template(\"\"\"interface {{ interface_name }}"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_d8634240","line":41,"in_reply_to":"da6895a0_cb8a27bf","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.agent.linux import utils"},{"line_number":28,"context_line":"from neutron.common import constants as n_const"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from neutron.conf.agent import linux as ra"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RADVD_SERVICE_NAME \u003d \u0027radvd\u0027"},{"line_number":33,"context_line":"RADVD_SERVICE_CMD \u003d \u0027radvd\u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_ad948d45","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":42},"updated":"2017-03-24 14:37:09.000000000","message":"Is it possible to change that to linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.agent.linux import utils"},{"line_number":28,"context_line":"from neutron.common import constants as n_const"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from neutron.conf.agent import linux as ra"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RADVD_SERVICE_NAME \u003d \u0027radvd\u0027"},{"line_number":33,"context_line":"RADVD_SERVICE_CMD \u003d \u0027radvd\u0027"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_1ba5e504","line":30,"range":{"start_line":30,"start_character":40,"end_line":30,"end_character":42},"in_reply_to":"ffe62b97_ad948d45","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to %s\u0027 % ra.__name__,"},{"line_number":42,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"CONFIG_TEMPLATE \u003d jinja2.Template(\"\"\"interface {{ interface_name }}"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_9269e826","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":19},"updated":"2017-03-24 14:37:09.000000000","message":"Outdated version","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"debtcollector.deprecate("},{"line_number":41,"context_line":"    \u0027Moved OPTS to %s\u0027 % ra.__name__,"},{"line_number":42,"context_line":"    version\u003d\"newton\", removal_version\u003d\"ocata\")"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"CONFIG_TEMPLATE \u003d jinja2.Template(\"\"\"interface {{ interface_name }}"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_fba921df","line":42,"range":{"start_line":42,"start_character":13,"end_line":42,"end_character":19},"in_reply_to":"ffe62b97_9269e826","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e90c5ea3ecd6f689af11c9e2417da10d7bee53e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from neutron.agent.linux import external_process"},{"line_number":27,"context_line":"from neutron.agent.linux import utils"},{"line_number":28,"context_line":"from neutron.common import constants as n_const"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from neutron.conf.agent import linux as linux_conf"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"RADVD_SERVICE_NAME \u003d \u0027radvd\u0027"}],"source_content_type":"text/x-python","patch_set":47,"id":"ff0f0b1f_b1f1fd6d","line":29,"updated":"2017-05-23 19:23:46.000000000","message":"extra blank line","commit_id":"13e371771ba777a2586d6bb7cea2c7c05ccbfd76"}],"neutron/agent/ovsdb/api.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \u0027native\u0027: \u0027neutron.agent.ovsdb.impl_idl.OvsdbIdl\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ovsdb_api.register_ovsdb_api_opts(cfg.CONF)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bc74479c","line":30,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    \u0027native\u0027: \u0027neutron.agent.ovsdb.impl_idl.OvsdbIdl\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"ovsdb_api.register_ovsdb_api_opts(cfg.CONF)"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_14e1c3d0","line":30,"in_reply_to":"bacf61ea_bc74479c","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron._i18n import _"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"interface_map \u003d {"},{"line_number":26,"context_line":"    \u0027vsctl\u0027: \u0027neutron.agent.ovsdb.impl_vsctl.OvsdbVsctl\u0027,"},{"line_number":27,"context_line":"    \u0027native\u0027: \u0027neutron.agent.ovsdb.impl_idl.OvsdbIdl\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027ovsdb_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_4b645721","side":"PARENT","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":1},"updated":"2016-10-25 19:33:14.000000000","message":"is this still needed here since it got moved to neutron.conf.agent.ovsdb_api?  There should only be one instance of this.  Seems like it should reside in the conf module so you don\u0027t have to import this module.","commit_id":"2b9d9e3b9e9e9133b90013114d73356742844ef7"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron._i18n import _"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"interface_map \u003d {"},{"line_number":26,"context_line":"    \u0027vsctl\u0027: \u0027neutron.agent.ovsdb.impl_vsctl.OvsdbVsctl\u0027,"},{"line_number":27,"context_line":"    \u0027native\u0027: \u0027neutron.agent.ovsdb.impl_idl.OvsdbIdl\u0027,"},{"line_number":28,"context_line":"}"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"OPTS \u003d ["},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027ovsdb_interface\u0027,"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_984aaaab","side":"PARENT","line":28,"range":{"start_line":25,"start_character":0,"end_line":28,"end_character":1},"in_reply_to":"da6895a0_4b645721","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"2b9d9e3b9e9e9133b90013114d73356742844ef7"}],"neutron/cmd/netns_cleanup.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    conf.register_cli_opts(cli_opts)"},{"line_number":73,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":74,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":75,"context_line":"    linux.register_interface_opts(cfg.CONF)"},{"line_number":76,"context_line":"    return conf"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9c77c39e","line":75,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    conf.register_cli_opts(cli_opts)"},{"line_number":73,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":74,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":75,"context_line":"    linux.register_interface_opts(cfg.CONF)"},{"line_number":76,"context_line":"    return conf"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_54eb3bb0","line":75,"in_reply_to":"bacf61ea_9c77c39e","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    cmd.register_cmd_opts(cmd.netns_opts, conf)"},{"line_number":65,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":66,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":67,"context_line":"    interface.register_interface_opts(interface.OPTS, conf)"},{"line_number":68,"context_line":"    return conf"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_cb26a7cd","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":58},"updated":"2016-10-25 19:33:14.000000000","message":"unnecessary since its the same as the default","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    cmd.register_cmd_opts(cmd.netns_opts, conf)"},{"line_number":65,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":66,"context_line":"    dhcp_config.register_agent_dhcp_opts(conf)"},{"line_number":67,"context_line":"    interface.register_interface_opts(interface.OPTS, conf)"},{"line_number":68,"context_line":"    return conf"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_b8c5ae0b","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":58},"in_reply_to":"da6895a0_cb26a7cd","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"}],"neutron/cmd/ovs_cleanup.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    conf.register_cli_opts(opts)"},{"line_number":47,"context_line":"    l3_config.register_l3_agent_config_opts(l3_config.OPTS, conf)"},{"line_number":48,"context_line":"    conf.register_opts(l3_config.OPTS)"},{"line_number":49,"context_line":"    linux.register_interface_opts(cfg.CONF)"},{"line_number":50,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":51,"context_line":"    return conf"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5c5eeb12","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":43},"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    conf.register_cli_opts(opts)"},{"line_number":47,"context_line":"    l3_config.register_l3_agent_config_opts(l3_config.OPTS, conf)"},{"line_number":48,"context_line":"    conf.register_opts(l3_config.OPTS)"},{"line_number":49,"context_line":"    linux.register_interface_opts(cfg.CONF)"},{"line_number":50,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":51,"context_line":"    return conf"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_94cdb35f","line":49,"range":{"start_line":49,"start_character":0,"end_line":49,"end_character":43},"in_reply_to":"bacf61ea_5c5eeb12","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    conf \u003d cfg.CONF"},{"line_number":39,"context_line":"    cmd.register_cmd_opts(cmd.ovs_opts, conf)"},{"line_number":40,"context_line":"    l3_config.register_l3_agent_config_opts(l3_config.OPTS, conf)"},{"line_number":41,"context_line":"    interface.register_interface_opts(interface.OPTS, conf)"},{"line_number":42,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":43,"context_line":"    return conf"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_eb21abb5","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":58},"updated":"2016-10-25 19:33:14.000000000","message":"unnecessary, same as default","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    conf \u003d cfg.CONF"},{"line_number":39,"context_line":"    cmd.register_cmd_opts(cmd.ovs_opts, conf)"},{"line_number":40,"context_line":"    l3_config.register_l3_agent_config_opts(l3_config.OPTS, conf)"},{"line_number":41,"context_line":"    interface.register_interface_opts(interface.OPTS, conf)"},{"line_number":42,"context_line":"    agent_config.register_interface_driver_opts_helper(conf)"},{"line_number":43,"context_line":"    return conf"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_f8cf2627","line":41,"range":{"start_line":41,"start_character":52,"end_line":41,"end_character":58},"in_reply_to":"da6895a0_eb21abb5","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"}],"neutron/conf/agent/linux.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"OPTS \u003d ["},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027ovs_integration_bridge\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_cb278710","line":52,"updated":"2016-10-25 19:33:14.000000000","message":"I think it\u0027d be better to name this INTERFACE_OPTS to be more readable","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"OPTS \u003d ["},{"line_number":53,"context_line":"    cfg.StrOpt(\u0027ovs_integration_bridge\u0027,"},{"line_number":54,"context_line":"               default\u003d\u0027br-int\u0027,"},{"line_number":55,"context_line":"               help\u003d_(\u0027Name of Open vSwitch bridge to use\u0027)),"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_98e1ca9d","line":52,"in_reply_to":"da6895a0_cb278710","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                       \u0027Support kernels with limited namespace support \u0027"},{"line_number":60,"context_line":"                       \u0027(e.g. RHEL 6.5) so long as ovs_use_veth is set to \u0027"},{"line_number":61,"context_line":"                       \u0027True.\u0027)),"},{"line_number":62,"context_line":"    cfg.IntOpt(\u0027network_device_mtu\u0027,"},{"line_number":63,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":64,"context_line":"               help\u003d_(\u0027MTU setting for device. This option will be removed in \u0027"},{"line_number":65,"context_line":"                      \u0027Newton. Please use the system-wide segment_mtu setting \u0027"},{"line_number":66,"context_line":"                      \u0027which the agents will take into account when wiring \u0027"},{"line_number":67,"context_line":"                      \u0027VIFs.\u0027)),"},{"line_number":68,"context_line":"]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_ab5ed373","line":67,"range":{"start_line":62,"start_character":4,"end_line":67,"end_character":32},"updated":"2016-10-25 19:33:14.000000000","message":"This was removed in newton.  Just remove it here.","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":59,"context_line":"                       \u0027Support kernels with limited namespace support \u0027"},{"line_number":60,"context_line":"                       \u0027(e.g. RHEL 6.5) so long as ovs_use_veth is set to \u0027"},{"line_number":61,"context_line":"                       \u0027True.\u0027)),"},{"line_number":62,"context_line":"    cfg.IntOpt(\u0027network_device_mtu\u0027,"},{"line_number":63,"context_line":"               deprecated_for_removal\u003dTrue,"},{"line_number":64,"context_line":"               help\u003d_(\u0027MTU setting for device. This option will be removed in \u0027"},{"line_number":65,"context_line":"                      \u0027Newton. Please use the system-wide segment_mtu setting \u0027"},{"line_number":66,"context_line":"                      \u0027which the agents will take into account when wiring \u0027"},{"line_number":67,"context_line":"                      \u0027VIFs.\u0027)),"},{"line_number":68,"context_line":"]"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_b8ecce93","line":67,"range":{"start_line":62,"start_character":4,"end_line":67,"end_character":32},"in_reply_to":"da6895a0_ab5ed373","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    cfg.register_opts(PD_DRIVER_OPTS)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def register_interface_opts(opts, cfg\u003dcfg.CONF):"},{"line_number":101,"context_line":"    cfg.register_opts(opts)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_6b991b1f","line":100,"range":{"start_line":100,"start_character":28,"end_line":100,"end_character":32},"updated":"2016-10-25 19:33:14.000000000","message":"why is this taking in opts and the rest are not? it doesn\u0027t make sense to take in opts.","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    cfg.register_opts(PD_DRIVER_OPTS)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"def register_interface_opts(opts, cfg\u003dcfg.CONF):"},{"line_number":101,"context_line":"    cfg.register_opts(opts)"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_f8e646af","line":100,"range":{"start_line":100,"start_character":28,"end_line":100,"end_character":32},"in_reply_to":"da6895a0_6b991b1f","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f95350699e96fd104af22fea5917720b03535d79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"dfeb2761_c2de126c","line":1,"updated":"2017-04-04 18:33:54.000000000","message":"2017 ?","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d9d724d37b5d41459fbb6587fe8dbd5bb116969d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2012 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":43,"id":"bff0334d_16c84153","line":1,"in_reply_to":"dfeb2761_c2de126c","updated":"2017-04-05 19:05:13.000000000","message":"Done","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f95350699e96fd104af22fea5917720b03535d79","unresolved":false,"context_lines":[{"line_number":24,"context_line":"]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IP_LIB_OPTS_WINDOWS \u003d []"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"EXTERNAL_PROCESS_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":43,"id":"dfeb2761_026e3ac8","line":27,"updated":"2017-04-04 18:33:54.000000000","message":"I realize this is empty, but it\u0027s never used below like the LINUX variant is.\n\nThis actually raises the question that everything in here save for the LINUX option belong in a common.py file, not in linux.py since they can be used for windows as well.","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d9d724d37b5d41459fbb6587fe8dbd5bb116969d","unresolved":false,"context_lines":[{"line_number":24,"context_line":"]"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"IP_LIB_OPTS_WINDOWS \u003d []"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"EXTERNAL_PROCESS_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":43,"id":"bff0334d_b605157d","line":27,"in_reply_to":"dfeb2761_026e3ac8","updated":"2017-04-05 19:05:13.000000000","message":"Done","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"}],"neutron/conf/agent/ovsdb_api.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f95350699e96fd104af22fea5917720b03535d79","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":43,"id":"dfeb2761_42d44248","line":1,"updated":"2017-04-04 18:33:54.000000000","message":"2017 ?","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"d9d724d37b5d41459fbb6587fe8dbd5bb116969d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2014 OpenStack Foundation"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":43,"id":"bff0334d_55211c4d","line":1,"in_reply_to":"dfeb2761_42d44248","updated":"2017-04-05 19:05:13.000000000","message":"Done","commit_id":"663f3ccba565c49964b464573962a4ae4753a2a8"}],"neutron/debug/shell.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                _(\"You must provide a config file for bridge -\""},{"line_number":73,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":74,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":75,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":76,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":77,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dc7f7b64","line":75,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                _(\"You must provide a config file for bridge -\""},{"line_number":73,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":74,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":75,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":76,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":77,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_74ff5f67","line":75,"in_reply_to":"bacf61ea_dc7f7b64","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                _(\"You must provide a config file for bridge -\""},{"line_number":73,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":74,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":75,"context_line":"        interface.register_interface_opts(interface.INTERFACE_OPTS, cfg.CONF)"},{"line_number":76,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":77,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_f5230203","line":75,"range":{"start_line":75,"start_character":68,"end_line":75,"end_character":76},"updated":"2016-08-05 15:47:42.000000000","message":"not needed","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                _(\"You must provide a config file for bridge -\""},{"line_number":73,"context_line":"                  \" either --config-file or env[NEUTRON_TEST_CONFIG_FILE]\"))"},{"line_number":74,"context_line":"        client \u003d self.client_manager.neutron"},{"line_number":75,"context_line":"        interface.register_interface_opts(interface.INTERFACE_OPTS, cfg.CONF)"},{"line_number":76,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":77,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":78,"context_line":"        cfg.CONF([\u0027--config-file\u0027, self.options.config_file])"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_1b5c044a","line":75,"range":{"start_line":75,"start_character":68,"end_line":75,"end_character":76},"in_reply_to":"bacf61ea_f5230203","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron._i18n import _LW"},{"line_number":23,"context_line":"from neutron.agent.common import config"},{"line_number":24,"context_line":"from neutron.agent.common import utils"},{"line_number":25,"context_line":"from neutron.conf.agent import linux as interface"},{"line_number":26,"context_line":"from neutron.debug import debug_agent"},{"line_number":27,"context_line":"from neutronclient.common import exceptions as exc"},{"line_number":28,"context_line":"from neutronclient import shell"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_6e03e90d","line":25,"range":{"start_line":25,"start_character":40,"end_line":25,"end_character":49},"updated":"2016-10-25 19:33:14.000000000","message":"one of my comments suggested changing the OPTS variable to INTERFACE_OPTS, which would make this alias odd (interface.INTERFACE_OPTS), so maybe change it to linux_conf with that change.  Same comment for all the other modules with this alias.","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron._i18n import _LW"},{"line_number":23,"context_line":"from neutron.agent.common import config"},{"line_number":24,"context_line":"from neutron.agent.common import utils"},{"line_number":25,"context_line":"from neutron.conf.agent import linux as interface"},{"line_number":26,"context_line":"from neutron.debug import debug_agent"},{"line_number":27,"context_line":"from neutronclient.common import exceptions as exc"},{"line_number":28,"context_line":"from neutronclient import shell"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_78fb1648","line":25,"range":{"start_line":25,"start_character":40,"end_line":25,"end_character":49},"in_reply_to":"da6895a0_6e03e90d","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"}],"neutron/services/metering/drivers/iptables/iptables_driver.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":36,"context_line":"LABEL \u003d \u0027-l-\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":39,"context_line":"interface.register_interface_opts(interface.INTERFACE_OPTS, cfg.CONF)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesManagerTransaction(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_d5819ec4","line":39,"range":{"start_line":39,"start_character":59,"end_line":39,"end_character":68},"updated":"2016-08-05 15:47:42.000000000","message":"not needed","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":36,"context_line":"LABEL \u003d \u0027-l-\u0027"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":39,"context_line":"interface.register_interface_opts(interface.INTERFACE_OPTS, cfg.CONF)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class IptablesManagerTransaction(object):"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_fb3930f3","line":39,"range":{"start_line":39,"start_character":59,"end_line":39,"end_character":68},"in_reply_to":"bacf61ea_d5819ec4","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"}],"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e9d0d1562fb5929a4a366e0a0d97e53f15fdf2ee","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        # machines as the port should be treated by OVS agent and not by"},{"line_number":747,"context_line":"        # external party"},{"line_number":748,"context_line":"        interface_config \u003d cfg.ConfigOpts()"},{"line_number":749,"context_line":"        interface_conf.register_interface_opts("},{"line_number":750,"context_line":"                      interface_config)"},{"line_number":751,"context_line":"        ovs_interface \u003d interface.OVSInterfaceDriver(interface_config)"},{"line_number":752,"context_line":"        ovs_interface.plug_new("},{"line_number":753,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_3e124db5","line":750,"range":{"start_line":749,"start_character":1,"end_line":750,"end_character":39},"updated":"2016-12-01 17:31:51.000000000","message":"nit : can be in the same line","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"c3fdd31079d1ec93efe7e2690c29a1fa02fa1cb6","unresolved":false,"context_lines":[{"line_number":746,"context_line":"        # machines as the port should be treated by OVS agent and not by"},{"line_number":747,"context_line":"        # external party"},{"line_number":748,"context_line":"        interface_config \u003d cfg.ConfigOpts()"},{"line_number":749,"context_line":"        interface_conf.register_interface_opts("},{"line_number":750,"context_line":"                      interface_config)"},{"line_number":751,"context_line":"        ovs_interface \u003d interface.OVSInterfaceDriver(interface_config)"},{"line_number":752,"context_line":"        ovs_interface.plug_new("},{"line_number":753,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_1c28b932","line":750,"range":{"start_line":749,"start_character":1,"end_line":750,"end_character":39},"in_reply_to":"3a71b18c_3e124db5","updated":"2016-12-12 05:41:00.000000000","message":"Done","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from neutron.agent.linux import utils"},{"line_number":42,"context_line":"from neutron.common import utils as common_utils"},{"line_number":43,"context_line":"from neutron.conf.agent import common as config"},{"line_number":44,"context_line":"from neutron.conf.agent import linux as interface_conf"},{"line_number":45,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":46,"context_line":"from neutron.plugins.ml2.drivers.linuxbridge.agent import \\"},{"line_number":47,"context_line":"    linuxbridge_neutron_agent as linuxbridge_agent"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_0de259d6","line":44,"range":{"start_line":44,"start_character":40,"end_line":44,"end_character":54},"updated":"2017-03-24 14:37:09.000000000","message":"Can it be change to linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":41,"context_line":"from neutron.agent.linux import utils"},{"line_number":42,"context_line":"from neutron.common import utils as common_utils"},{"line_number":43,"context_line":"from neutron.conf.agent import common as config"},{"line_number":44,"context_line":"from neutron.conf.agent import linux as interface_conf"},{"line_number":45,"context_line":"from neutron.db import db_base_plugin_common"},{"line_number":46,"context_line":"from neutron.plugins.ml2.drivers.linuxbridge.agent import \\"},{"line_number":47,"context_line":"    linuxbridge_neutron_agent as linuxbridge_agent"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_5b37edb1","line":44,"range":{"start_line":44,"start_character":40,"end_line":44,"end_character":54},"in_reply_to":"ffe62b97_0de259d6","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        # TODO(jlibosva): Don\u0027t use interface driver for fullstack fake"},{"line_number":765,"context_line":"        # machines as the port should be treated by OVS agent and not by"},{"line_number":766,"context_line":"        # external party"},{"line_number":767,"context_line":"        interface_config \u003d cfg.ConfigOpts()"},{"line_number":768,"context_line":"        interface_conf.register_interface_opts(interface_config)"},{"line_number":769,"context_line":"        ovs_interface \u003d interface.OVSInterfaceDriver(interface_config)"},{"line_number":770,"context_line":"        ovs_interface.plug_new("},{"line_number":771,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_8d69c926","line":768,"range":{"start_line":767,"start_character":0,"end_line":768,"end_character":64},"updated":"2017-03-24 14:37:09.000000000","message":"Excuse my ignorance, but this code seems to be doing something different, if we compare it to previous version.\nIf I understand this correctly, you can replace entire thing with\n\n interface_conf.register_interface_opts()\n\nbecause cfg.ConfigOpts() is empty, and you\u0027ve already registered this interface. Please correct me, if I\u0027m wrong.\n\nEDIT:\nOK, I believe I know, why it\u0027s done like that. Because we need to create local config version for tests. Is that correct?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":764,"context_line":"        # TODO(jlibosva): Don\u0027t use interface driver for fullstack fake"},{"line_number":765,"context_line":"        # machines as the port should be treated by OVS agent and not by"},{"line_number":766,"context_line":"        # external party"},{"line_number":767,"context_line":"        interface_config \u003d cfg.ConfigOpts()"},{"line_number":768,"context_line":"        interface_conf.register_interface_opts(interface_config)"},{"line_number":769,"context_line":"        ovs_interface \u003d interface.OVSInterfaceDriver(interface_config)"},{"line_number":770,"context_line":"        ovs_interface.plug_new("},{"line_number":771,"context_line":"            None,"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_1b84c50b","line":768,"range":{"start_line":767,"start_character":0,"end_line":768,"end_character":64},"in_reply_to":"ffe62b97_8d69c926","updated":"2017-03-24 20:58:09.000000000","message":"yes.","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/functional/agent/l2/base.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _get_config_opts(self):"},{"line_number":72,"context_line":"        config \u003d cfg.ConfigOpts()"},{"line_number":73,"context_line":"        config.register_opts(common_config.core_opts)"},{"line_number":74,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":75,"context_line":"        config.register_opts(ovs_config.ovs_opts, \"OVS\")"},{"line_number":76,"context_line":"        config.register_opts(ovs_config.agent_opts, \"AGENT\")"},{"line_number":77,"context_line":"        agent_config.register_interface_driver_opts_helper(config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_bcd0c754","line":74,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _get_config_opts(self):"},{"line_number":72,"context_line":"        config \u003d cfg.ConfigOpts()"},{"line_number":73,"context_line":"        config.register_opts(common_config.core_opts)"},{"line_number":74,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":75,"context_line":"        config.register_opts(ovs_config.ovs_opts, \"OVS\")"},{"line_number":76,"context_line":"        config.register_opts(ovs_config.agent_opts, \"AGENT\")"},{"line_number":77,"context_line":"        agent_config.register_interface_driver_opts_helper(config)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_54021b70","line":74,"in_reply_to":"bacf61ea_bcd0c754","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e9d0d1562fb5929a4a366e0a0d97e53f15fdf2ee","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _get_config_opts(self):"},{"line_number":72,"context_line":"        config \u003d cfg.ConfigOpts()"},{"line_number":73,"context_line":"        config.register_opts(common_config.core_opts)"},{"line_number":74,"context_line":"        interface_config.register_interface_opts("},{"line_number":75,"context_line":"                        config)"},{"line_number":76,"context_line":"        config.register_opts(ovs_config.ovs_opts, \"OVS\")"},{"line_number":77,"context_line":"        config.register_opts(ovs_config.agent_opts, \"AGENT\")"},{"line_number":78,"context_line":"        agent_config.register_interface_driver_opts_helper(config)"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_9e11a1af","line":75,"range":{"start_line":74,"start_character":1,"end_line":75,"end_character":31},"updated":"2016-12-01 17:31:51.000000000","message":"ditto","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"c3fdd31079d1ec93efe7e2690c29a1fa02fa1cb6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def _get_config_opts(self):"},{"line_number":72,"context_line":"        config \u003d cfg.ConfigOpts()"},{"line_number":73,"context_line":"        config.register_opts(common_config.core_opts)"},{"line_number":74,"context_line":"        interface_config.register_interface_opts("},{"line_number":75,"context_line":"                        config)"},{"line_number":76,"context_line":"        config.register_opts(ovs_config.ovs_opts, \"OVS\")"},{"line_number":77,"context_line":"        config.register_opts(ovs_config.agent_opts, \"AGENT\")"},{"line_number":78,"context_line":"        agent_config.register_interface_driver_opts_helper(config)"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_3c21f54d","line":75,"range":{"start_line":74,"start_character":1,"end_line":75,"end_character":31},"in_reply_to":"3a71b18c_9e11a1af","updated":"2016-12-12 05:41:00.000000000","message":"Done","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.agent.linux import polling"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.conf.agent import common as agent_config"},{"line_number":32,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":33,"context_line":"from neutron.conf import common as common_config"},{"line_number":34,"context_line":"from neutron.conf.plugins.ml2.drivers import ovs_conf"},{"line_number":35,"context_line":"from neutron.plugins.common import constants as p_const"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_ed5bb584","line":32,"range":{"start_line":32,"start_character":40,"end_line":32,"end_character":56},"updated":"2017-03-24 14:37:09.000000000","message":"Can we use linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.agent.linux import polling"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.conf.agent import common as agent_config"},{"line_number":32,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":33,"context_line":"from neutron.conf import common as common_config"},{"line_number":34,"context_line":"from neutron.conf.plugins.ml2.drivers import ovs_conf"},{"line_number":35,"context_line":"from neutron.plugins.common import constants as p_const"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_7ba99179","line":32,"range":{"start_line":32,"start_character":40,"end_line":32,"end_character":56},"in_reply_to":"ffe62b97_ed5bb584","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/functional/agent/l3/framework.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                          get_temp_file_path(\u0027metadata_proxy\u0027))"},{"line_number":86,"context_line":"        conf.set_override(\u0027ha_confs_path\u0027,"},{"line_number":87,"context_line":"                          get_temp_file_path(\u0027ha_confs\u0027))"},{"line_number":88,"context_line":"        conf.set_override(\u0027external_pids\u0027,"},{"line_number":89,"context_line":"                          get_temp_file_path(\u0027$state_path/external/pids\u0027))"},{"line_number":90,"context_line":"        conf.set_override(\u0027host\u0027, host)"},{"line_number":91,"context_line":"        conf.set_override(\u0027agent_mode\u0027, agent_mode)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_552e4ea5","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":74},"updated":"2016-08-05 15:47:42.000000000","message":"i might be missing something, why is this change required ?","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":85,"context_line":"                          get_temp_file_path(\u0027metadata_proxy\u0027))"},{"line_number":86,"context_line":"        conf.set_override(\u0027ha_confs_path\u0027,"},{"line_number":87,"context_line":"                          get_temp_file_path(\u0027ha_confs\u0027))"},{"line_number":88,"context_line":"        conf.set_override(\u0027external_pids\u0027,"},{"line_number":89,"context_line":"                          get_temp_file_path(\u0027$state_path/external/pids\u0027))"},{"line_number":90,"context_line":"        conf.set_override(\u0027host\u0027, host)"},{"line_number":91,"context_line":"        conf.set_override(\u0027agent_mode\u0027, agent_mode)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_fb10105b","line":89,"range":{"start_line":88,"start_character":8,"end_line":89,"end_character":74},"in_reply_to":"bacf61ea_552e4ea5","updated":"2016-08-05 17:25:02.000000000","message":"no I was trying something. It\u0027s not needed. Removed.","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"e7a1705ac154c0257e9bdccd6049731bc636473a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.common import l3_test_common"},{"line_number":37,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":38,"context_line":"from neutron.tests.functional import base"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"_uuid \u003d uuidutils.generate_uuid"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"fa6399be_b6153d41","line":39,"updated":"2016-10-13 13:37:00.000000000","message":"nit: missing whitespace","commit_id":"aba06612bfffba17fdc297f4bacd3c14f07b2d2e"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"3d6d7134762cd52b466081fdcd5aab9db1f3fc5a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.common import l3_test_common"},{"line_number":37,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":38,"context_line":"from neutron.tests.functional import base"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"_uuid \u003d uuidutils.generate_uuid"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"da6895a0_6a730381","line":39,"in_reply_to":"fa6399be_b6153d41","updated":"2016-10-24 02:54:53.000000000","message":"Done","commit_id":"aba06612bfffba17fdc297f4bacd3c14f07b2d2e"}],"neutron/tests/functional/agent/linux/test_dhcp.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(TestDhcp, self).setUp()"},{"line_number":33,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":34,"context_line":"        conf.register_opts(config.INTERFACE_DRIVER_OPTS)"},{"line_number":35,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":36,"context_line":"        conf.register_opts(common_conf.core_opts)"},{"line_number":37,"context_line":"        conf.register_opts(dhcp_conf.DHCP_AGENT_OPTS)"},{"line_number":38,"context_line":"        conf.set_override(\u0027interface_driver\u0027, \u0027openvswitch\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1cc0f37b","line":35,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":32,"context_line":"        super(TestDhcp, self).setUp()"},{"line_number":33,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":34,"context_line":"        conf.register_opts(config.INTERFACE_DRIVER_OPTS)"},{"line_number":35,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":36,"context_line":"        conf.register_opts(common_conf.core_opts)"},{"line_number":37,"context_line":"        conf.register_opts(dhcp_conf.DHCP_AGENT_OPTS)"},{"line_number":38,"context_line":"        conf.set_override(\u0027interface_driver\u0027, \u0027openvswitch\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b4f9d782","line":35,"in_reply_to":"bacf61ea_1cc0f37b","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"2e90c5ea3ecd6f689af11c9e2417da10d7bee53e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(TestDhcp, self).setUp()"},{"line_number":32,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":33,"context_line":"        conf.register_opts(config.INTERFACE_DRIVER_OPTS)"},{"line_number":34,"context_line":"        config.register_interface_opts(conf)"},{"line_number":35,"context_line":"        conf.register_opts(common_conf.core_opts)"},{"line_number":36,"context_line":"        conf.register_opts(dhcp_conf.DHCP_AGENT_OPTS)"}],"source_content_type":"text/x-python","patch_set":47,"id":"ff0f0b1f_346b9bb7","line":33,"updated":"2017-05-23 19:23:46.000000000","message":"config.register_interface_driver_opts_helper(conf) ?\n\nSimilar with others below\n\nNit since it\u0027s doing the same thing.","commit_id":"13e371771ba777a2586d6bb7cea2c7c05ccbfd76"}],"neutron/tests/functional/agent/linux/test_interface.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(OVSInterfaceDriverTestCase, self).setUp()"},{"line_number":32,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":33,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":34,"context_line":"        self.interface \u003d interface.OVSInterfaceDriver(conf)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_plug_checks_if_bridge_exists(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dc449b1c","line":33,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(OVSInterfaceDriverTestCase, self).setUp()"},{"line_number":32,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":33,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":34,"context_line":"        self.interface \u003d interface.OVSInterfaceDriver(conf)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_plug_checks_if_bridge_exists(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d4ee0bb3","line":33,"in_reply_to":"bacf61ea_dc449b1c","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e9d0d1562fb5929a4a366e0a0d97e53f15fdf2ee","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(OVSInterfaceDriverTestCase, self).setUp()"},{"line_number":31,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"        interface_config.register_interface_opts("},{"line_number":33,"context_line":"                        conf)"},{"line_number":34,"context_line":"        self.interface \u003d interface.OVSInterfaceDriver(conf)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_plug_checks_if_bridge_exists(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_fe77f5ff","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":29},"updated":"2016-12-01 17:31:51.000000000","message":"ditto","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"c3fdd31079d1ec93efe7e2690c29a1fa02fa1cb6","unresolved":false,"context_lines":[{"line_number":29,"context_line":"    def setUp(self):"},{"line_number":30,"context_line":"        super(OVSInterfaceDriverTestCase, self).setUp()"},{"line_number":31,"context_line":"        conf \u003d cfg.ConfigOpts()"},{"line_number":32,"context_line":"        interface_config.register_interface_opts("},{"line_number":33,"context_line":"                        conf)"},{"line_number":34,"context_line":"        self.interface \u003d interface.OVSInterfaceDriver(conf)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def test_plug_checks_if_bridge_exists(self):"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_5c1eb10c","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":29},"in_reply_to":"3a71b18c_fe77f5ff","updated":"2016-12-12 05:41:00.000000000","message":"Done","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"from neutron.common import exceptions"},{"line_number":25,"context_line":"from neutron.common import utils"},{"line_number":26,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":27,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":28,"context_line":"from neutron.tests.functional.agent.linux import base as linux_base"},{"line_number":29,"context_line":"from neutron.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_0df5b957","line":26,"range":{"start_line":26,"start_character":40,"end_line":26,"end_character":56},"updated":"2017-03-24 14:37:09.000000000","message":"linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":24,"context_line":"from neutron.common import exceptions"},{"line_number":25,"context_line":"from neutron.common import utils"},{"line_number":26,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":27,"context_line":"from neutron.tests.common import net_helpers"},{"line_number":28,"context_line":"from neutron.tests.functional.agent.linux import base as linux_base"},{"line_number":29,"context_line":"from neutron.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_7bd751ef","line":26,"range":{"start_line":26,"start_character":40,"end_line":26,"end_character":56},"in_reply_to":"ffe62b97_0df5b957","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/functional/agent/linux/test_ip_lib.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        cfg.CONF.set_override("},{"line_number":47,"context_line":"            \u0027interface_driver\u0027,"},{"line_number":48,"context_line":"            \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027)"},{"line_number":49,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":50,"context_line":"        self.driver \u003d importutils.import_object(cfg.CONF.interface_driver,"},{"line_number":51,"context_line":"                                                cfg.CONF)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dc5bfbf4","line":49,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        cfg.CONF.set_override("},{"line_number":47,"context_line":"            \u0027interface_driver\u0027,"},{"line_number":48,"context_line":"            \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027)"},{"line_number":49,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":50,"context_line":"        self.driver \u003d importutils.import_object(cfg.CONF.interface_driver,"},{"line_number":51,"context_line":"                                                cfg.CONF)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_342cc701","line":49,"in_reply_to":"bacf61ea_dc5bfbf4","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        cfg.CONF.set_override("},{"line_number":47,"context_line":"            \u0027interface_driver\u0027,"},{"line_number":48,"context_line":"            \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027)"},{"line_number":49,"context_line":"        interface.register_interface_opts(interface.OPTS, cfg.CONF)"},{"line_number":50,"context_line":"        self.driver \u003d importutils.import_object(cfg.CONF.interface_driver,"},{"line_number":51,"context_line":"                                                cfg.CONF)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_ae2421af","line":49,"range":{"start_line":49,"start_character":56,"end_line":49,"end_character":66},"updated":"2016-10-25 19:33:14.000000000","message":"unnecessary, this is the default","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        cfg.CONF.set_override("},{"line_number":47,"context_line":"            \u0027interface_driver\u0027,"},{"line_number":48,"context_line":"            \u0027neutron.agent.linux.interface.OVSInterfaceDriver\u0027)"},{"line_number":49,"context_line":"        interface.register_interface_opts(interface.OPTS, cfg.CONF)"},{"line_number":50,"context_line":"        self.driver \u003d importutils.import_object(cfg.CONF.interface_driver,"},{"line_number":51,"context_line":"                                                cfg.CONF)"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_3888bec6","line":49,"range":{"start_line":49,"start_character":56,"end_line":49,"end_character":66},"in_reply_to":"da6895a0_ae2421af","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"}],"neutron/tests/unit/agent/common/test_utils.py":[{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.agent.common import utils"},{"line_number":19,"context_line":"from neutron.agent.linux import interface"},{"line_number":20,"context_line":"from neutron.conf.agent import common as config"},{"line_number":21,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_0d9a5913","line":21,"range":{"start_line":21,"start_character":40,"end_line":21,"end_character":56},"updated":"2017-03-24 14:37:09.000000000","message":"linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from neutron.agent.common import utils"},{"line_number":19,"context_line":"from neutron.agent.linux import interface"},{"line_number":20,"context_line":"from neutron.conf.agent import common as config"},{"line_number":21,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":22,"context_line":"from neutron.tests import base"},{"line_number":23,"context_line":"from neutron.tests.unit import testlib_api"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_7bf07191","line":21,"range":{"start_line":21,"start_character":40,"end_line":21,"end_character":56},"in_reply_to":"ffe62b97_0d9a5913","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/unit/agent/dhcp/test_agent.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                        cfg.CONF.register_opts(dhcp_config.DHCP_AGENT_OPTS)"},{"line_number":264,"context_line":"                        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":265,"context_line":"                        config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":266,"context_line":"                        linux.register_interface_opts(cfg.CONF)"},{"line_number":267,"context_line":"                        common_config.init(sys.argv[1:])"},{"line_number":268,"context_line":"                        agent_mgr \u003d dhcp_agent.DhcpAgentWithStateReport("},{"line_number":269,"context_line":"                            \u0027testhost\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1ce3d306","line":266,"updated":"2016-07-28 21:03:11.000000000","message":"ditto","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":263,"context_line":"                        cfg.CONF.register_opts(dhcp_config.DHCP_AGENT_OPTS)"},{"line_number":264,"context_line":"                        config.register_interface_driver_opts_helper(cfg.CONF)"},{"line_number":265,"context_line":"                        config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":266,"context_line":"                        linux.register_interface_opts(cfg.CONF)"},{"line_number":267,"context_line":"                        common_config.init(sys.argv[1:])"},{"line_number":268,"context_line":"                        agent_mgr \u003d dhcp_agent.DhcpAgentWithStateReport("},{"line_number":269,"context_line":"                            \u0027testhost\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_74363f53","line":266,"in_reply_to":"bacf61ea_1ce3d306","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"b3a78862099b9e61de3c9f0507156101cfcdb998","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                        config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":266,"context_line":"                        interface_config.register_interface_opts("},{"line_number":267,"context_line":"                                        interface_config.INTERFACE_OPTS,"},{"line_number":268,"context_line":"                                        cfg.CONF)"},{"line_number":269,"context_line":"                        common_config.init(sys.argv[1:])"},{"line_number":270,"context_line":"                        agent_mgr \u003d dhcp_agent.DhcpAgentWithStateReport("},{"line_number":271,"context_line":"                            \u0027testhost\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_15de96dc","line":268,"range":{"start_line":268,"start_character":40,"end_line":268,"end_character":48},"updated":"2016-08-05 15:47:42.000000000","message":"not needed","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"0c7469a139e3fae916cee5d30ed151097d6a5824","unresolved":false,"context_lines":[{"line_number":265,"context_line":"                        config.register_agent_state_opts_helper(cfg.CONF)"},{"line_number":266,"context_line":"                        interface_config.register_interface_opts("},{"line_number":267,"context_line":"                                        interface_config.INTERFACE_OPTS,"},{"line_number":268,"context_line":"                                        cfg.CONF)"},{"line_number":269,"context_line":"                        common_config.init(sys.argv[1:])"},{"line_number":270,"context_line":"                        agent_mgr \u003d dhcp_agent.DhcpAgentWithStateReport("},{"line_number":271,"context_line":"                            \u0027testhost\u0027)"}],"source_content_type":"text/x-python","patch_set":12,"id":"bacf61ea_db138c63","line":268,"range":{"start_line":268,"start_character":40,"end_line":268,"end_character":48},"in_reply_to":"bacf61ea_15de96dc","updated":"2016-08-05 17:25:02.000000000","message":"Done","commit_id":"6983b92bceb42b1bdb41367a1bde6fc6add5512a"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.common import utils"},{"line_number":37,"context_line":"from neutron.conf.agent import common as config"},{"line_number":38,"context_line":"from neutron.conf.agent import dhcp as dhcp_config"},{"line_number":39,"context_line":"from neutron.conf.agent import linux"},{"line_number":40,"context_line":"from neutron.tests import base"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_6d80c58c","line":39,"updated":"2017-03-24 14:37:09.000000000","message":"Could you add as linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.common import utils"},{"line_number":37,"context_line":"from neutron.conf.agent import common as config"},{"line_number":38,"context_line":"from neutron.conf.agent import dhcp as dhcp_config"},{"line_number":39,"context_line":"from neutron.conf.agent import linux"},{"line_number":40,"context_line":"from neutron.tests import base"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_3b7e69e4","line":39,"in_reply_to":"ffe62b97_6d80c58c","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":51,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":52,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":53,"context_line":"from neutron.conf.agent import linux"},{"line_number":54,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":55,"context_line":"from neutron.conf import common as base_config"},{"line_number":56,"context_line":"from neutron.extensions import portbindings"},{"line_number":57,"context_line":"from neutron.plugins.common import constants as p_const"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_0e36ede5","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":56},"updated":"2016-10-25 19:33:14.000000000","message":"this is confusing, you shouldn\u0027t import the same module 2 times","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":51,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":52,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":53,"context_line":"from neutron.conf.agent import linux"},{"line_number":54,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":55,"context_line":"from neutron.conf import common as base_config"},{"line_number":56,"context_line":"from neutron.extensions import portbindings"},{"line_number":57,"context_line":"from neutron.plugins.common import constants as p_const"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_988f0acc","line":54,"range":{"start_line":53,"start_character":0,"end_line":54,"end_character":56},"in_reply_to":"da6895a0_0e36ede5","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from neutron.conf.agent import common as agent_config"},{"line_number":51,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":52,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":53,"context_line":"from neutron.conf.agent import linux"},{"line_number":54,"context_line":"from neutron.conf import common as base_config"},{"line_number":55,"context_line":"from neutron.extensions import portbindings"},{"line_number":56,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_4d7d01b0","line":53,"updated":"2017-03-24 14:37:09.000000000","message":"ditto","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"from neutron.conf.agent import common as agent_config"},{"line_number":51,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":52,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":53,"context_line":"from neutron.conf.agent import linux"},{"line_number":54,"context_line":"from neutron.conf import common as base_config"},{"line_number":55,"context_line":"from neutron.extensions import portbindings"},{"line_number":56,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_1bd165ce","line":53,"in_reply_to":"ffe62b97_4d7d01b0","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/unit/agent/l3/test_dvr_local_router.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        agent_config.register_interface_driver_opts_helper(self.conf)"},{"line_number":56,"context_line":"        agent_config.register_process_monitor_opts(self.conf)"},{"line_number":57,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":58,"context_line":"        linux.register_external_process_opts(cfg.CONF)"},{"line_number":59,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027,"},{"line_number":60,"context_line":"                               \u0027neutron.agent.linux.interface.NullDriver\u0027)"},{"line_number":61,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9c8b431e","line":58,"updated":"2016-07-28 21:03:11.000000000","message":"line(57-58) cfg.CONF --\u003e self.conf","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        agent_config.register_interface_driver_opts_helper(self.conf)"},{"line_number":56,"context_line":"        agent_config.register_process_monitor_opts(self.conf)"},{"line_number":57,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":58,"context_line":"        linux.register_external_process_opts(cfg.CONF)"},{"line_number":59,"context_line":"        self.conf.set_override(\u0027interface_driver\u0027,"},{"line_number":60,"context_line":"                               \u0027neutron.agent.linux.interface.NullDriver\u0027)"},{"line_number":61,"context_line":"        self.conf.set_override(\u0027send_arp_for_ha\u0027, 1)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_943bf337","line":58,"in_reply_to":"bacf61ea_9c8b431e","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.common import utils as common_utils"},{"line_number":31,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":32,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":33,"context_line":"from neutron.conf.agent import linux"},{"line_number":34,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":35,"context_line":"from neutron.conf import common as base_config"},{"line_number":36,"context_line":"from neutron.extensions import portbindings"},{"line_number":37,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_2e31f1ec","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"updated":"2016-10-25 19:33:14.000000000","message":"same","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.common import utils as common_utils"},{"line_number":31,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":32,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":33,"context_line":"from neutron.conf.agent import linux"},{"line_number":34,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":35,"context_line":"from neutron.conf import common as base_config"},{"line_number":36,"context_line":"from neutron.extensions import portbindings"},{"line_number":37,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_b8ba0e70","line":34,"range":{"start_line":33,"start_character":0,"end_line":34,"end_character":56},"in_reply_to":"da6895a0_2e31f1ec","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.conf.agent import common as agent_config"},{"line_number":31,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":32,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":33,"context_line":"from neutron.conf.agent import linux"},{"line_number":34,"context_line":"from neutron.conf import common as base_config"},{"line_number":35,"context_line":"from neutron.extensions import portbindings"},{"line_number":36,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_ad5fed3f","line":33,"updated":"2017-03-24 14:37:09.000000000","message":"ditto","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"from neutron.conf.agent import common as agent_config"},{"line_number":31,"context_line":"from neutron.conf.agent.l3 import config as l3_config"},{"line_number":32,"context_line":"from neutron.conf.agent.l3 import ha as ha_conf"},{"line_number":33,"context_line":"from neutron.conf.agent import linux"},{"line_number":34,"context_line":"from neutron.conf import common as base_config"},{"line_number":35,"context_line":"from neutron.extensions import portbindings"},{"line_number":36,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_4604b015","line":33,"in_reply_to":"ffe62b97_ad5fed3f","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/unit/agent/linux/test_dhcp.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        self.conf.register_opts(base_config.core_opts)"},{"line_number":831,"context_line":"        self.conf.register_opts(dhcp_config.DHCP_OPTS)"},{"line_number":832,"context_line":"        self.conf.register_opts(dhcp_config.DNSMASQ_OPTS)"},{"line_number":833,"context_line":"        linux.register_external_process_opts(cfg.CONF)"},{"line_number":834,"context_line":"        config.register_interface_driver_opts_helper(self.conf)"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9cb983ce","line":833,"range":{"start_line":833,"start_character":45,"end_line":833,"end_character":53},"updated":"2016-07-28 21:03:11.000000000","message":"replace cfg.CONF --\u003e self.conf","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":830,"context_line":"        self.conf.register_opts(base_config.core_opts)"},{"line_number":831,"context_line":"        self.conf.register_opts(dhcp_config.DHCP_OPTS)"},{"line_number":832,"context_line":"        self.conf.register_opts(dhcp_config.DNSMASQ_OPTS)"},{"line_number":833,"context_line":"        linux.register_external_process_opts(cfg.CONF)"},{"line_number":834,"context_line":"        config.register_interface_driver_opts_helper(self.conf)"},{"line_number":835,"context_line":""},{"line_number":836,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d4456bb3","line":833,"range":{"start_line":833,"start_character":45,"end_line":833,"end_character":53},"in_reply_to":"bacf61ea_9cb983ce","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.common import constants as n_const"},{"line_number":28,"context_line":"from neutron.conf.agent import common as config"},{"line_number":29,"context_line":"from neutron.conf.agent import dhcp as dhcp_config"},{"line_number":30,"context_line":"from neutron.conf.agent import linux"},{"line_number":31,"context_line":"from neutron.conf import common as base_config"},{"line_number":32,"context_line":"from neutron.extensions import extra_dhcp_opt as edo_ext"},{"line_number":33,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_8d5c294c","line":30,"updated":"2017-03-24 14:37:09.000000000","message":"ditto","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from neutron.common import constants as n_const"},{"line_number":28,"context_line":"from neutron.conf.agent import common as config"},{"line_number":29,"context_line":"from neutron.conf.agent import dhcp as dhcp_config"},{"line_number":30,"context_line":"from neutron.conf.agent import linux"},{"line_number":31,"context_line":"from neutron.conf import common as base_config"},{"line_number":32,"context_line":"from neutron.extensions import extra_dhcp_opt as edo_ext"},{"line_number":33,"context_line":"from neutron.tests import base"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_462dd093","line":30,"in_reply_to":"ffe62b97_8d5c294c","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/unit/agent/linux/test_interface.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"e9d0d1562fb5929a4a366e0a0d97e53f15fdf2ee","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def setUp(self):"},{"line_number":78,"context_line":"        super(TestBase, self).setUp()"},{"line_number":79,"context_line":"        self.conf \u003d config.setup_conf()"},{"line_number":80,"context_line":"        interface_config.register_interface_opts("},{"line_number":81,"context_line":"                        self.conf)"},{"line_number":82,"context_line":"        self.ip_dev_p \u003d mock.patch.object(ip_lib, \u0027IPDevice\u0027)"},{"line_number":83,"context_line":"        self.ip_dev \u003d self.ip_dev_p.start()"},{"line_number":84,"context_line":"        self.ip_p \u003d mock.patch.object(ip_lib, \u0027IPWrapper\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_7ed125cd","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":34},"updated":"2016-12-01 17:31:51.000000000","message":"ditto","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"c3fdd31079d1ec93efe7e2690c29a1fa02fa1cb6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"    def setUp(self):"},{"line_number":78,"context_line":"        super(TestBase, self).setUp()"},{"line_number":79,"context_line":"        self.conf \u003d config.setup_conf()"},{"line_number":80,"context_line":"        interface_config.register_interface_opts("},{"line_number":81,"context_line":"                        self.conf)"},{"line_number":82,"context_line":"        self.ip_dev_p \u003d mock.patch.object(ip_lib, \u0027IPDevice\u0027)"},{"line_number":83,"context_line":"        self.ip_dev \u003d self.ip_dev_p.start()"},{"line_number":84,"context_line":"        self.ip_p \u003d mock.patch.object(ip_lib, \u0027IPWrapper\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"3a71b18c_dcd80156","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":34},"in_reply_to":"3a71b18c_7ed125cd","updated":"2016-12-12 05:41:00.000000000","message":"Done","commit_id":"4d7e0c46f8ef79b62da00973905ba2feef6b4a8b"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":22,"context_line":"from neutron.agent.linux import utils"},{"line_number":23,"context_line":"from neutron.conf.agent import common as config"},{"line_number":24,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_6dab251d","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":56},"updated":"2017-03-24 14:37:09.000000000","message":"linux_conf","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.agent.linux import ip_lib"},{"line_number":22,"context_line":"from neutron.agent.linux import utils"},{"line_number":23,"context_line":"from neutron.conf.agent import common as config"},{"line_number":24,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":25,"context_line":"from neutron.tests import base"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_8647584c","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":56},"in_reply_to":"ffe62b97_6dab251d","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}],"neutron/tests/unit/debug/test_commands.py":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ad5805fb4e302c2d616fcdf7c8d6b3f7d9be738c","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class TestDebugCommands(base.BaseTestCase):"},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestDebugCommands, self).setUp()"},{"line_number":39,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":40,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":41,"context_line":"        common_config.init([])"},{"line_number":42,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5ceeebb4","line":39,"updated":"2016-07-28 21:03:11.000000000","message":"ditto as line34 in dhcp_agent.py","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f49d143c40c2f9543259728c6aadcab2f9884d93","unresolved":false,"context_lines":[{"line_number":36,"context_line":"class TestDebugCommands(base.BaseTestCase):"},{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestDebugCommands, self).setUp()"},{"line_number":39,"context_line":"        linux.register_interface_opts(cfg.CONF)"},{"line_number":40,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":41,"context_line":"        common_config.init([])"},{"line_number":42,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_740d9f8f","line":39,"in_reply_to":"bacf61ea_5ceeebb4","updated":"2016-07-29 14:35:45.000000000","message":"Done","commit_id":"de2c6056b8724199434d7c5491d70e67c1542411"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"230e9821b2d83b0e6c5a116e60d8b0b56233fee1","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestDebugCommands, self).setUp()"},{"line_number":39,"context_line":"        interface_config.register_interface_opts("},{"line_number":40,"context_line":"                        interface_config.OPTS,"},{"line_number":41,"context_line":"                        cfg.CONF)"},{"line_number":42,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":43,"context_line":"        common_config.init([])"},{"line_number":44,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":29,"id":"da6895a0_ce42353e","line":41,"range":{"start_line":40,"start_character":45,"end_line":41,"end_character":32},"updated":"2016-10-25 19:33:14.000000000","message":"unnecessary, same as default","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6930e83cdb30e5c33ac11daded878aaadcb4cbae","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    def setUp(self):"},{"line_number":38,"context_line":"        super(TestDebugCommands, self).setUp()"},{"line_number":39,"context_line":"        interface_config.register_interface_opts("},{"line_number":40,"context_line":"                        interface_config.OPTS,"},{"line_number":41,"context_line":"                        cfg.CONF)"},{"line_number":42,"context_line":"        cfg.CONF.register_opts(config.EXT_NET_BRIDGE_OPTS)"},{"line_number":43,"context_line":"        common_config.init([])"},{"line_number":44,"context_line":"        config.register_interface_driver_opts_helper(cfg.CONF)"}],"source_content_type":"text/x-python","patch_set":29,"id":"ba5da102_18ba1a6f","line":41,"range":{"start_line":40,"start_character":45,"end_line":41,"end_character":32},"in_reply_to":"da6895a0_ce42353e","updated":"2016-11-04 12:00:18.000000000","message":"Done","commit_id":"0fd0508c36ec006661760228b2f1d48879f71918"},{"author":{"_account_id":14611,"name":"dasm","display_name":"dasm","email":"dsmigiel@redhat.com","username":"dasm"},"change_message_id":"9d010adf8eeea9b816b4567dc42ade0ff73b283a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.agent.linux import interface"},{"line_number":22,"context_line":"from neutron.common import config as common_config"},{"line_number":23,"context_line":"from neutron.conf.agent import common as config"},{"line_number":24,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":25,"context_line":"from neutron.debug import commands"},{"line_number":26,"context_line":"from neutron.debug import debug_agent"},{"line_number":27,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_6d59e558","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":56},"updated":"2017-03-24 14:37:09.000000000","message":"linux_conf?","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"7df9dac747c0d50015ec315037f1c3b86a35f36a","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.agent.linux import interface"},{"line_number":22,"context_line":"from neutron.common import config as common_config"},{"line_number":23,"context_line":"from neutron.conf.agent import common as config"},{"line_number":24,"context_line":"from neutron.conf.agent import linux as interface_config"},{"line_number":25,"context_line":"from neutron.debug import commands"},{"line_number":26,"context_line":"from neutron.debug import debug_agent"},{"line_number":27,"context_line":"from neutron.extensions import portbindings"}],"source_content_type":"text/x-python","patch_set":41,"id":"ffe62b97_c6ab20d4","line":24,"range":{"start_line":24,"start_character":40,"end_line":24,"end_character":56},"in_reply_to":"ffe62b97_6d59e558","updated":"2017-03-24 20:58:09.000000000","message":"Done","commit_id":"5091139ab265f52303b9778abff59afb868e8efe"}]}
