)]}'
{"quantum/agent/linux/ovs_lib.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"36ddba70ad76372f2050ce7ba5f2166ef26a09be","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from quantum.agent.linux import ip_lib"},{"line_number":24,"context_line":"from quantum.agent.linux import utils"},{"line_number":25,"context_line":"from quantum.openstack.common import jsonutils, log as logging"},{"line_number":26,"context_line":"from quantum.plugins.openvswitch.common import constants"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FivU%3D","line":26,"updated":"2013-06-28 05:39:04.000000000","message":"use a new line per each import, the use of commas is discourage in OpenStack code guidelines","commit_id":"0be2c6e96fae36037c18b710c2577551a0a56d6f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0ccaa994d9098685d9e0713db41f51859143d8bc","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        args \u003d [\u0027--format\u003djson\u0027, \u0027--\u0027, \u0027--columns\u003dname,external_ids\u0027,"},{"line_number":259,"context_line":"                \u0027list\u0027, \u0027Interface\u0027]"},{"line_number":260,"context_line":"        result \u003d self.run_vsctl(args)"},{"line_number":261,"context_line":"        if not result:"},{"line_number":262,"context_line":"            result \u003d \u0027{\"data\":[]}\u0027"},{"line_number":263,"context_line":"        for row in jsonutils.loads(result)[\u0027data\u0027]:"},{"line_number":264,"context_line":"            name \u003d row[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FhEQ%3D","line":261,"updated":"2013-06-28 17:37:54.000000000","message":"sorry if I miss the point, but wouldn\u0027t be the same if you did:\n\nif not result:\n    for row in jsonutils.loads(result)[\u0027data\u0027]:","commit_id":"8950b8c8dbae69903b57ec00342b05f2d83ea8de"},{"author":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"change_message_id":"769ac06527c1d2eb17580c0b89705294871dba6d","unresolved":false,"context_lines":[{"line_number":258,"context_line":"        args \u003d [\u0027--format\u003djson\u0027, \u0027--\u0027, \u0027--columns\u003dname,external_ids\u0027,"},{"line_number":259,"context_line":"                \u0027list\u0027, \u0027Interface\u0027]"},{"line_number":260,"context_line":"        result \u003d self.run_vsctl(args)"},{"line_number":261,"context_line":"        if not result:"},{"line_number":262,"context_line":"            result \u003d \u0027{\"data\":[]}\u0027"},{"line_number":263,"context_line":"        for row in jsonutils.loads(result)[\u0027data\u0027]:"},{"line_number":264,"context_line":"            name \u003d row[0]"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FhDA%3D","line":261,"in_reply_to":"AAAAPn%2F%2FhEQ%3D","updated":"2013-06-28 17:40:57.000000000","message":"you\u0027re right, i\u0027ll make this more clear","commit_id":"8950b8c8dbae69903b57ec00342b05f2d83ea8de"}],"quantum/tests/unit/openvswitch/test_ovs_lib.py":[{"author":{"_account_id":704,"name":"Edgar Magana","email":"emagana@gmail.com","username":"emagana"},"change_message_id":"36ddba70ad76372f2050ce7ba5f2166ef26a09be","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from quantum.agent.linux import ovs_lib, utils"},{"line_number":23,"context_line":"from quantum.openstack.common import jsonutils, uuidutils"},{"line_number":24,"context_line":"from quantum.tests import base"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class OVS_Lib_Test(base.BaseTestCase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Fiuo%3D","line":24,"updated":"2013-06-28 05:39:04.000000000","message":"same as before\nyou could fix line 22 as well, reviews are not perfect  ;-)","commit_id":"0be2c6e96fae36037c18b710c2577551a0a56d6f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0ccaa994d9098685d9e0713db41f51859143d8bc","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        self._test_get_vif_port_set(False)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def test_get_vif_port_set_xen(self):"},{"line_number":330,"context_line":"        self._test_get_vif_port_set(True)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_clear_db_attribute(self):"},{"line_number":333,"context_line":"        pname \u003d \"tap77\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FhEI%3D","line":330,"updated":"2013-06-28 17:37:54.000000000","message":"I\u0027d add a test to verify the case where the command fail, but that\u0027s a bonus.","commit_id":"8950b8c8dbae69903b57ec00342b05f2d83ea8de"},{"author":{"_account_id":7500,"name":"Peter Feiner","email":"peter@gridcentric.ca","username":"peter"},"change_message_id":"769ac06527c1d2eb17580c0b89705294871dba6d","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        self._test_get_vif_port_set(False)"},{"line_number":328,"context_line":""},{"line_number":329,"context_line":"    def test_get_vif_port_set_xen(self):"},{"line_number":330,"context_line":"        self._test_get_vif_port_set(True)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def test_clear_db_attribute(self):"},{"line_number":333,"context_line":"        pname \u003d \"tap77\""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FhC8%3D","line":330,"in_reply_to":"AAAAPn%2F%2FhEI%3D","updated":"2013-06-28 17:40:57.000000000","message":"sure, that\u0027s easy to add","commit_id":"8950b8c8dbae69903b57ec00342b05f2d83ea8de"}]}