)]}'
{"neutron/objects/trunk.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3cc33a8fc9c69ecee2999d7aaabf948815e0cd3f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    sub_port.trunk_id \u003d self.id"},{"line_number":117,"context_line":"                    sub_port.create()"},{"line_number":118,"context_line":"                    self.sub_ports.append(sub_port)"},{"line_number":119,"context_line":"                self.obj_reset_changes([\u0027sub_ports\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # TODO(ivc): add support for \u0027sub_ports\u0027 in \u0027Trunk.update\u0027 for"},{"line_number":122,"context_line":"    # consistency with \u0027Trunk.create\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ed073a7f","line":119,"updated":"2016-07-28 16:57:51.000000000","message":"is this required only if sub_ports is non empty? If so, might move the if sub_ports ahead of 119 as the for loop will be skipped regardless, see 105.","commit_id":"2d2689f3fa2093fab5576e2b24d0641888922e12"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"028efce9c62d97c767c8b1da096704b53a56b340","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    sub_port.trunk_id \u003d self.id"},{"line_number":117,"context_line":"                    sub_port.create()"},{"line_number":118,"context_line":"                    self.sub_ports.append(sub_port)"},{"line_number":119,"context_line":"                self.obj_reset_changes([\u0027sub_ports\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # TODO(ivc): add support for \u0027sub_ports\u0027 in \u0027Trunk.update\u0027 for"},{"line_number":122,"context_line":"    # consistency with \u0027Trunk.create\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ebe602b3","line":119,"in_reply_to":"bacf61ea_0b08b690","updated":"2016-07-28 17:30:52.000000000","message":"it\u0027s not better...the diff looks smaller but that\u0027s all. Mostly I was asking if the reset_changes was only required with non-empty sub-ports","commit_id":"2d2689f3fa2093fab5576e2b24d0641888922e12"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"092155e79ace3e77b41c930b4af2b60b3d1b8db8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    sub_port.trunk_id \u003d self.id"},{"line_number":117,"context_line":"                    sub_port.create()"},{"line_number":118,"context_line":"                    self.sub_ports.append(sub_port)"},{"line_number":119,"context_line":"                self.obj_reset_changes([\u0027sub_ports\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # TODO(ivc): add support for \u0027sub_ports\u0027 in \u0027Trunk.update\u0027 for"},{"line_number":122,"context_line":"    # consistency with \u0027Trunk.create\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6b6e9202","line":119,"in_reply_to":"bacf61ea_6ba05244","updated":"2016-07-28 17:33:08.000000000","message":"ack","commit_id":"2d2689f3fa2093fab5576e2b24d0641888922e12"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd21f53233fbc33d245e6664555605c5c0fbc37f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    sub_port.trunk_id \u003d self.id"},{"line_number":117,"context_line":"                    sub_port.create()"},{"line_number":118,"context_line":"                    self.sub_ports.append(sub_port)"},{"line_number":119,"context_line":"                self.obj_reset_changes([\u0027sub_ports\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # TODO(ivc): add support for \u0027sub_ports\u0027 in \u0027Trunk.update\u0027 for"},{"line_number":122,"context_line":"    # consistency with \u0027Trunk.create\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6bb7b286","line":119,"in_reply_to":"bacf61ea_6ba05244","updated":"2016-07-28 17:32:36.000000000","message":"https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L296","commit_id":"2d2689f3fa2093fab5576e2b24d0641888922e12"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d60af4a2a4c9f6a63761ebd4746bb06c619cc73f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    sub_port.trunk_id \u003d self.id"},{"line_number":117,"context_line":"                    sub_port.create()"},{"line_number":118,"context_line":"                    self.sub_ports.append(sub_port)"},{"line_number":119,"context_line":"                self.obj_reset_changes([\u0027sub_ports\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # TODO(ivc): add support for \u0027sub_ports\u0027 in \u0027Trunk.update\u0027 for"},{"line_number":122,"context_line":"    # consistency with \u0027Trunk.create\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_6ba05244","line":119,"in_reply_to":"bacf61ea_ebe602b3","updated":"2016-07-28 17:32:04.000000000","message":"if it\u0027s empty, the super() class already reset the field, so no need to reset it once more.","commit_id":"2d2689f3fa2093fab5576e2b24d0641888922e12"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7b868dabab31a7614c268e3c68a92901617a8296","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                    sub_port.trunk_id \u003d self.id"},{"line_number":117,"context_line":"                    sub_port.create()"},{"line_number":118,"context_line":"                    self.sub_ports.append(sub_port)"},{"line_number":119,"context_line":"                self.obj_reset_changes([\u0027sub_ports\u0027])"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    # TODO(ivc): add support for \u0027sub_ports\u0027 in \u0027Trunk.update\u0027 for"},{"line_number":122,"context_line":"    # consistency with \u0027Trunk.create\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0b08b690","line":119,"in_reply_to":"bacf61ea_ed073a7f","updated":"2016-07-28 17:27:26.000000000","message":"Not sure how it\u0027s particularly better. One layer less for the loop?","commit_id":"2d2689f3fa2093fab5576e2b24d0641888922e12"}]}