)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74b4aae8b6decd7236298a957e487507c5143adb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Miguel Angel Ajo \u003cmangelajo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-28 18:12:27 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce bulk_push to rpc callback mechanism"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are usage patterns which would benefit from having"},{"line_number":10,"context_line":"the capability to send a list of resources in bulk instead"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_6b84d2d3","line":7,"updated":"2016-07-28 17:29:00.000000000","message":"minor suggestions inline, but this looks doable, thanks for jumping on this so quickly!","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the capability to send a list of resources in bulk instead"},{"line_number":11,"context_line":"of using individual fanout messages."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"From now on, the rpc callback subscriber receive a list of"},{"line_number":14,"context_line":"resources (single or multiple), and the pushers must always"},{"line_number":15,"context_line":"push a list."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_1eed6425","line":13,"updated":"2016-07-29 13:59:56.000000000","message":"receives","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"the capability to send a list of resources in bulk instead"},{"line_number":11,"context_line":"of using individual fanout messages."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"From now on, the rpc callback subscriber receive a list of"},{"line_number":14,"context_line":"resources (single or multiple), and the pushers must always"},{"line_number":15,"context_line":"push a list."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_d98c8681","line":13,"in_reply_to":"bacf61ea_1eed6425","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a7f7f50018fc1aea235179b70fc79c75dc1dfdf7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"push a list."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Backwards compatibility for QoSPolicy consumers in mitaka"},{"line_number":18,"context_line":"is providen by calling push with \"resource\" parameter for"},{"line_number":19,"context_line":"single item lists during one release cycle. That will be"},{"line_number":20,"context_line":"dropped when Otaka opens."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_a5ac0b36","line":18,"range":{"start_line":18,"start_character":3,"end_line":18,"end_character":11},"updated":"2016-07-29 13:18:35.000000000","message":"provided","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"push a list."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Backwards compatibility for QoSPolicy consumers in mitaka"},{"line_number":18,"context_line":"is providen by calling push with \"resource\" parameter for"},{"line_number":19,"context_line":"single item lists during one release cycle. That will be"},{"line_number":20,"context_line":"dropped when Otaka opens."},{"line_number":21,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_f9918a9a","line":18,"range":{"start_line":18,"start_character":3,"end_line":18,"end_character":11},"in_reply_to":"bacf61ea_a5ac0b36","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Backwards compatibility for QoSPolicy consumers in mitaka"},{"line_number":18,"context_line":"is providen by calling push with \"resource\" parameter for"},{"line_number":19,"context_line":"single item lists during one release cycle. That will be"},{"line_number":20,"context_line":"dropped when Otaka opens."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1117925360a29ecbd1902fa527b2f24f94ce81ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_9e92f49d","line":20,"updated":"2016-07-29 13:59:56.000000000","message":"ocata","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Backwards compatibility for QoSPolicy consumers in mitaka"},{"line_number":18,"context_line":"is providen by calling push with \"resource\" parameter for"},{"line_number":19,"context_line":"single item lists during one release cycle. That will be"},{"line_number":20,"context_line":"dropped when Otaka opens."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1117925360a29ecbd1902fa527b2f24f94ce81ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_99920e9e","line":20,"in_reply_to":"bacf61ea_9e92f49d","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":19,"context_line":"single item lists during one release cycle. That will be"},{"line_number":20,"context_line":"dropped when Otaka opens."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1117925360a29ecbd1902fa527b2f24f94ce81ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_7ecbc0a5","line":22,"updated":"2016-07-29 13:59:56.000000000","message":"do we need to track it for a bp? vlan-aware that is?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":19,"context_line":"single item lists during one release cycle. That will be"},{"line_number":20,"context_line":"dropped when Otaka opens."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Change-Id: I1117925360a29ecbd1902fa527b2f24f94ce81ec"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bacf61ea_39ea0210","line":22,"in_reply_to":"bacf61ea_7ecbc0a5","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"b604f35543ddfe83fa72fcae06d801ad17d35a1f","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Author:     Miguel Angel Ajo \u003cmangelajo@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-07-28 18:12:27 +0200"},{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-01 14:22:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce bulk push to rpc callback mechanism"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bacf61ea_dfc7e361","line":5,"updated":"2016-08-01 21:27:29.000000000","message":"I don\u0027t like commits 4 seconds before the next minute. Makes them feel rushed. :)","commit_id":"7f617e6a210243caba9b2637efac726a21a2d3a5"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"62c13b17ca844b8e6854750023f3a39a2e6464f7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"Author:     Miguel Angel Ajo \u003cmangelajo@redhat.com\u003e"},{"line_number":3,"context_line":"AuthorDate: 2016-07-28 18:12:27 +0200"},{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-01 14:22:56 -0700"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Introduce bulk push to rpc callback mechanism"},{"line_number":8,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"bacf61ea_d717b8a0","line":5,"in_reply_to":"bacf61ea_dfc7e361","updated":"2016-08-02 08:14:39.000000000","message":"lol XD","commit_id":"7f617e6a210243caba9b2637efac726a21a2d3a5"}],"doc/source/devref/rpc_callbacks.rst":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f366b6d65de6195849e55a915b0d4fc5dd45a1e","unresolved":false,"context_lines":[{"line_number":238,"context_line":"The callback function will receive the following arguments:"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* resource_type: the type of resource which is receiving the update."},{"line_number":241,"context_line":"* resource_list: list of resources which have been pushed by server"},{"line_number":242,"context_line":"* event_type: will be one of CREATED, UPDATED, or DELETED, see"},{"line_number":243,"context_line":"  neutron.api.rpc.callbacks.events for details."},{"line_number":244,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"bacf61ea_727008dd","line":241,"updated":"2016-07-29 17:29:04.000000000","message":"let\u0027s elaborate on the semantic of how the push happens consumer side, but we can do that in a follow up.","commit_id":"f272ec419f26e30972547ce826b448b70587aa33"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* resource_type: the type of resource which is receiving the update."},{"line_number":241,"context_line":"* resource_list: list of resources which have been pushed by server,"},{"line_number":242,"context_line":"                 in the special case where on server side an heterogeneous"},{"line_number":243,"context_line":"                 list of different resource_types were pushed, the callbacks"},{"line_number":244,"context_line":"                 will be batched, and called once for every type on the original"},{"line_number":245,"context_line":"                 single server-side push."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_08a5ca45","line":242,"range":{"start_line":242,"start_character":58,"end_line":242,"end_character":62},"updated":"2016-08-01 20:14:52.000000000","message":"a h","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"* resource_type: the type of resource which is receiving the update."},{"line_number":241,"context_line":"* resource_list: list of resources which have been pushed by server,"},{"line_number":242,"context_line":"                 in the special case where on server side an heterogeneous"},{"line_number":243,"context_line":"                 list of different resource_types were pushed, the callbacks"},{"line_number":244,"context_line":"                 will be batched, and called once for every type on the original"},{"line_number":245,"context_line":"                 single server-side push."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_3ce9edb7","line":242,"range":{"start_line":242,"start_character":58,"end_line":242,"end_character":62},"in_reply_to":"bacf61ea_08a5ca45","updated":"2016-08-01 21:15:26.000000000","message":"Done","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":240,"context_line":"* resource_type: the type of resource which is receiving the update."},{"line_number":241,"context_line":"* resource_list: list of resources which have been pushed by server,"},{"line_number":242,"context_line":"                 in the special case where on server side an heterogeneous"},{"line_number":243,"context_line":"                 list of different resource_types were pushed, the callbacks"},{"line_number":244,"context_line":"                 will be batched, and called once for every type on the original"},{"line_number":245,"context_line":"                 single server-side push."},{"line_number":246,"context_line":"* event_type: will be one of CREATED, UPDATED, or DELETED, see"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_886ffafa","line":243,"range":{"start_line":243,"start_character":50,"end_line":243,"end_character":54},"updated":"2016-08-01 20:14:52.000000000","message":"was","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":240,"context_line":"* resource_type: the type of resource which is receiving the update."},{"line_number":241,"context_line":"* resource_list: list of resources which have been pushed by server,"},{"line_number":242,"context_line":"                 in the special case where on server side an heterogeneous"},{"line_number":243,"context_line":"                 list of different resource_types were pushed, the callbacks"},{"line_number":244,"context_line":"                 will be batched, and called once for every type on the original"},{"line_number":245,"context_line":"                 single server-side push."},{"line_number":246,"context_line":"* event_type: will be one of CREATED, UPDATED, or DELETED, see"}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_fce2b5d3","line":243,"range":{"start_line":243,"start_character":50,"end_line":243,"end_character":54},"in_reply_to":"bacf61ea_886ffafa","updated":"2016-08-01 21:15:26.000000000","message":"Done","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                 in the special case where on server side an heterogeneous"},{"line_number":243,"context_line":"                 list of different resource_types were pushed, the callbacks"},{"line_number":244,"context_line":"                 will be batched, and called once for every type on the original"},{"line_number":245,"context_line":"                 single server-side push."},{"line_number":246,"context_line":"* event_type: will be one of CREATED, UPDATED, or DELETED, see"},{"line_number":247,"context_line":"  neutron.api.rpc.callbacks.events for details."},{"line_number":248,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_c87572cb","line":245,"updated":"2016-08-01 20:14:52.000000000","message":"I admit this explanation is not very clear. I don\u0027t even think that we should elaborate on the matter twice, I suggest we leave this line intact, and change the wording below, see my suggestion.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                 in the special case where on server side an heterogeneous"},{"line_number":243,"context_line":"                 list of different resource_types were pushed, the callbacks"},{"line_number":244,"context_line":"                 will be batched, and called once for every type on the original"},{"line_number":245,"context_line":"                 single server-side push."},{"line_number":246,"context_line":"* event_type: will be one of CREATED, UPDATED, or DELETED, see"},{"line_number":247,"context_line":"  neutron.api.rpc.callbacks.events for details."},{"line_number":248,"context_line":""}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_1ce069cc","line":245,"in_reply_to":"bacf61ea_c87572cb","updated":"2016-08-01 21:15:26.000000000","message":"Done","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":270,"context_line":"an extension, anything that updates, creates, or destroys the resources and that"},{"line_number":271,"context_line":"is of any interest to subscribed agents."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Always a list of resources is pushed, in the special case where resources in the"},{"line_number":274,"context_line":"list are of different types, those will be batched and sent individually because"},{"line_number":275,"context_line":"each type of resource travels through a different RPC topic, and receivers"},{"line_number":276,"context_line":"can expect a different set of versions."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_83599b37","line":273,"updated":"2016-08-01 20:14:52.000000000","message":"ditto. Let\u0027s go with something like:\n\n\u0027In common case, when resources in the list belong to the same resource type, a single push RPC message is sent; if the list contains multiple resource types, resources of each type are grouped and sent separately, one push RPC message per distinct type. On the receiver side, resources in a list always belong to the same type. Note: there is no guarantee in terms of order in which separate resource lists will be delivered to consumers.\u0027","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":270,"context_line":"an extension, anything that updates, creates, or destroys the resources and that"},{"line_number":271,"context_line":"is of any interest to subscribed agents."},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"Always a list of resources is pushed, in the special case where resources in the"},{"line_number":274,"context_line":"list are of different types, those will be batched and sent individually because"},{"line_number":275,"context_line":"each type of resource travels through a different RPC topic, and receivers"},{"line_number":276,"context_line":"can expect a different set of versions."}],"source_content_type":"text/x-rst","patch_set":7,"id":"bacf61ea_9cd459ec","line":273,"in_reply_to":"bacf61ea_83599b37","updated":"2016-08-01 21:15:26.000000000","message":"I added my touch ;)","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"}],"neutron/api/rpc/callbacks/consumer/registry.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def push(resource_type, resource_list, event_type):"},{"line_number":31,"context_line":"    \"\"\"Push resource events into all registered callbacks for the type."},{"line_number":32,"context_line":"    This method will be called by the RPC consumer endpoint on the agent,"},{"line_number":33,"context_line":"    and lists of heterogeneous resource pushed by server will arrive"},{"line_number":34,"context_line":"    as separate events (one per type)to this push."},{"line_number":35,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_a37bff79","line":32,"updated":"2016-08-01 20:14:52.000000000","message":"it\u0027s not a method, it\u0027s a function.\n\nI also don\u0027t think we should mention implementation details here. In theory, this same registry could be used to deliver updates without relying on existing RPC consumer endpoint. Let\u0027s keep them decoupled.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"def push(resource_type, resource_list, event_type):"},{"line_number":31,"context_line":"    \"\"\"Push resource events into all registered callbacks for the type."},{"line_number":32,"context_line":"    This method will be called by the RPC consumer endpoint on the agent,"},{"line_number":33,"context_line":"    and lists of heterogeneous resource pushed by server will arrive"},{"line_number":34,"context_line":"    as separate events (one per type)to this push."},{"line_number":35,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_7c6b651e","line":32,"in_reply_to":"bacf61ea_a37bff79","updated":"2016-08-01 21:15:26.000000000","message":"I agree, the implementation here hasn\u0027t changed.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Push resource events into all registered callbacks for the type."},{"line_number":32,"context_line":"    This method will be called by the RPC consumer endpoint on the agent,"},{"line_number":33,"context_line":"    and lists of heterogeneous resource pushed by server will arrive"},{"line_number":34,"context_line":"    as separate events (one per type)to this push."},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    callbacks \u003d _get_manager().get_callbacks(resource_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_43884371","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":37},"updated":"2016-08-01 20:14:52.000000000","message":"you missed a space after (","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    \"\"\"Push resource events into all registered callbacks for the type."},{"line_number":32,"context_line":"    This method will be called by the RPC consumer endpoint on the agent,"},{"line_number":33,"context_line":"    and lists of heterogeneous resource pushed by server will arrive"},{"line_number":34,"context_line":"    as separate events (one per type)to this push."},{"line_number":35,"context_line":"    \"\"\""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    callbacks \u003d _get_manager().get_callbacks(resource_type)"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_7cd9a5f2","line":34,"range":{"start_line":34,"start_character":35,"end_line":34,"end_character":37},"in_reply_to":"bacf61ea_43884371","updated":"2016-08-01 21:15:26.000000000","message":"ack","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"}],"neutron/api/rpc/handlers/resources_rpc.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74b4aae8b6decd7236298a957e487507c5143adb","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        _validate_resource_type(resource_type)"},{"line_number":210,"context_line":"        if not all(map(lambda r: (resources.get_resource_type(r) \u003d\u003d"},{"line_number":211,"context_line":"                                  resource_type), resource_list)):"},{"line_number":212,"context_line":"            raise ValueError()"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        versions \u003d version_manager.get_resource_versions(resource_type)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_abcb6a52","line":212,"updated":"2016-07-28 17:29:00.000000000","message":"I\u0027d raise something more expressive of ValueError but I agree that the list should be of homogeneous elements.","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f603ff60438be4d3d2cb17a1fb6503233e852f11","unresolved":false,"context_lines":[{"line_number":209,"context_line":"        _validate_resource_type(resource_type)"},{"line_number":210,"context_line":"        if not all(map(lambda r: (resources.get_resource_type(r) \u003d\u003d"},{"line_number":211,"context_line":"                                  resource_type), resource_list)):"},{"line_number":212,"context_line":"            raise ValueError()"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        versions \u003d version_manager.get_resource_versions(resource_type)"},{"line_number":215,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a1cb66a4","line":212,"in_reply_to":"bacf61ea_abcb6a52","updated":"2016-07-29 10:41:19.000000000","message":"Agreed, I was a bit on a run, and I thought ValueError was a reasonable one to start with.\n\nI will switch it to something more meaningful.","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"147814b28c88b0f9204fccf912eec02f4da2fa62","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            dehydrated_resources \u003d []"},{"line_number":218,"context_line":"            cctxt \u003d self._prepare_object_fanout_context("},{"line_number":219,"context_line":"                resource_list[0], version)"},{"line_number":220,"context_line":"            for resource in resource_list:"},{"line_number":221,"context_line":"                dehydrated_resources.append("},{"line_number":222,"context_line":"                    resource.obj_to_primitive(target_version\u003dversion))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            cctxt.cast(context, \u0027bulk_push\u0027,"},{"line_number":225,"context_line":"                       resource_list\u003ddehydrated_resources,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a4e9b482","line":222,"range":{"start_line":220,"start_character":12,"end_line":222,"end_character":70},"updated":"2016-07-29 11:13:39.000000000","message":"dehydrated_resources \u003d [resource.obj_to_primitive(target_version\u003dversion)\n                        for resource in resource_list]","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d5b12589317e341585cbed7481a2bec50489265f","unresolved":false,"context_lines":[{"line_number":217,"context_line":"            dehydrated_resources \u003d []"},{"line_number":218,"context_line":"            cctxt \u003d self._prepare_object_fanout_context("},{"line_number":219,"context_line":"                resource_list[0], version)"},{"line_number":220,"context_line":"            for resource in resource_list:"},{"line_number":221,"context_line":"                dehydrated_resources.append("},{"line_number":222,"context_line":"                    resource.obj_to_primitive(target_version\u003dversion))"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            cctxt.cast(context, \u0027bulk_push\u0027,"},{"line_number":225,"context_line":"                       resource_list\u003ddehydrated_resources,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a53b6b37","line":222,"range":{"start_line":220,"start_character":12,"end_line":222,"end_character":70},"in_reply_to":"bacf61ea_a4e9b482","updated":"2016-07-29 13:08:38.000000000","message":"That\u0027s nicer, let me respin last patch again :)","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"74b4aae8b6decd7236298a957e487507c5143adb","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            cctxt.cast(context, \u0027bulk_push\u0027,"},{"line_number":225,"context_line":"                       resource_list\u003ddehydrated_resources,"},{"line_number":226,"context_line":"                       event_type\u003devent_type)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class ResourcesPushRpcCallback(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4b10eea8","line":226,"updated":"2016-07-28 17:29:00.000000000","message":"might want to refactor push so that some code between the bulk and non bulk version can be shared (like checking versions, preparing the context etc).","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f603ff60438be4d3d2cb17a1fb6503233e852f11","unresolved":false,"context_lines":[{"line_number":223,"context_line":""},{"line_number":224,"context_line":"            cctxt.cast(context, \u0027bulk_push\u0027,"},{"line_number":225,"context_line":"                       resource_list\u003ddehydrated_resources,"},{"line_number":226,"context_line":"                       event_type\u003devent_type)"},{"line_number":227,"context_line":""},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"class ResourcesPushRpcCallback(object):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_216e5695","line":226,"in_reply_to":"bacf61ea_4b10eea8","updated":"2016-07-29 10:41:19.000000000","message":"Ack, makes sense, there\u0027s lots of duplication here.","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":13770,"name":"Adolfo Duarte","email":"adduarte@redhat.com","username":"adolfoduarte"},"change_message_id":"1989f68fe25200426fdd3bbfa6fd6ef265af49cd","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     resource))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        resource_type \u003d resources.get_resource_type(resources[0])"},{"line_number":258,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b88bac1d","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":68},"updated":"2016-07-29 00:33:02.000000000","message":"What will happen if this \"push\" goes to callbacks which expect only one resource object, not a list? \nsee https://review.openstack.org/#/c/347662/7/neutron/services/trunk/rpc/agent.py@46","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b3e3ccd442c486f75566a11e915d87d44145781f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     resource))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        resource_type \u003d resources.get_resource_type(resources[0])"},{"line_number":258,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_bb48bf88","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":68},"in_reply_to":"bacf61ea_15dd5ae0","updated":"2016-07-29 05:56:40.000000000","message":"I think it should be possible to support plurals. I am gonna respin [1] to try this out.\n\nhttps://review.openstack.org/#/c/347662/","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"6bf46f2f3a32bf1e701a2a67ae424b1882e3467b","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     resource))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        resource_type \u003d resources.get_resource_type(resources[0])"},{"line_number":258,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_15dd5ae0","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":68},"in_reply_to":"bacf61ea_183c78e1","updated":"2016-07-29 04:25:49.000000000","message":"I don\u0027t see this as much of an issue. It could be left up to the user of the registry to ensure resource_type is unique. For example, in the case of subports bulk_push() could be used with a resource_type of SUBPORTS, where push() would be used in conjunction with a resource_type of SUBPORT.","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d992fd0e1469e19297c52492a927e373800e889e","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     resource))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        resource_type \u003d resources.get_resource_type(resources[0])"},{"line_number":258,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_be9891c1","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":68},"in_reply_to":"bacf61ea_81e10201","updated":"2016-07-29 15:49:11.000000000","message":"If that\u0027s an option, then it\u0027s worth considering!","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7cf0af0fa0f98f6fd978ac427982e6eae71242f1","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     resource))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        resource_type \u003d resources.get_resource_type(resources[0])"},{"line_number":258,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_183c78e1","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":68},"in_reply_to":"bacf61ea_b88bac1d","updated":"2016-07-29 00:46:27.000000000","message":"the callback won\u0027t be happy :)","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f603ff60438be4d3d2cb17a1fb6503233e852f11","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                     resource))"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"        resource_type \u003d resources.get_resource_type(resources[0])"},{"line_number":258,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_81e10201","line":258,"range":{"start_line":258,"start_character":8,"end_line":258,"end_character":68},"in_reply_to":"bacf61ea_bb48bf88","updated":"2016-07-29 10:41:19.000000000","message":"Yeah, the plurals is a sensible solution.\n\nBut after some thinking, given that the only consumers of those subscriptions/callbacks are the QoS extensions in-tree we\u0027re still in time to move this back to different semantics, where the callback receiver is always going to receive a list (size 1, or size N).\n\nSo our life is much simpler, no need to declare plurals, no need for the subscribers to handle two cases (subscription to singles or plurals).\n\nLet me respin, and let\u0027s see how it looks.","commit_id":"d07efa6b1e2ac2dc358f853a725c85a13a80e32a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        raise InvalidResourceTypeClass(resource_type\u003dresource_type)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def _validate_resource_list_homogeneity(resource_list, resource_type):"},{"line_number":54,"context_line":"    if not all(map(lambda r: (resources.get_resource_type(r) \u003d\u003d"},{"line_number":55,"context_line":"                              resource_type), resource_list)):"},{"line_number":56,"context_line":"        raise ValueError()  # TODO(mangelajo): more expressive exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_dea90c7d","line":53,"updated":"2016-07-29 13:59:56.000000000","message":"this behaviour is not covered by tests. though I doubt that\u0027s what we should validate for, see comments on batching per resource type below.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        raise InvalidResourceTypeClass(resource_type\u003dresource_type)"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"def _validate_resource_list_homogeneity(resource_list, resource_type):"},{"line_number":54,"context_line":"    if not all(map(lambda r: (resources.get_resource_type(r) \u003d\u003d"},{"line_number":55,"context_line":"                              resource_type), resource_list)):"},{"line_number":56,"context_line":"        raise ValueError()  # TODO(mangelajo): more expressive exception"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_99fe8e36","line":53,"in_reply_to":"bacf61ea_dea90c7d","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"8d5b89f8c8e960c74875913936f37db6d892e92c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"def _validate_resource_list_homogeneity(resource_list, resource_type):"},{"line_number":54,"context_line":"    if not all(map(lambda r: (resources.get_resource_type(r) \u003d\u003d"},{"line_number":55,"context_line":"                              resource_type), resource_list)):"},{"line_number":56,"context_line":"        raise ValueError()  # TODO(mangelajo): more expressive exception"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def resource_type_versioned_topic(resource_type, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_25993b20","line":56,"updated":"2016-07-29 13:13:30.000000000","message":"aouch handling this leftover.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":53,"context_line":"def _validate_resource_list_homogeneity(resource_list, resource_type):"},{"line_number":54,"context_line":"    if not all(map(lambda r: (resources.get_resource_type(r) \u003d\u003d"},{"line_number":55,"context_line":"                              resource_type), resource_list)):"},{"line_number":56,"context_line":"        raise ValueError()  # TODO(mangelajo): more expressive exception"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"def resource_type_versioned_topic(resource_type, version\u003dNone):"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4114189f","line":56,"in_reply_to":"bacf61ea_25993b20","updated":"2016-07-29 16:15:57.000000000","message":"Gone","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"},{"line_number":187,"context_line":"        target \u003d oslo_messaging.Target("},{"line_number":188,"context_line":"            version\u003d\u00271.0\u0027,"},{"line_number":189,"context_line":"            namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":190,"context_line":"        self.client \u003d n_rpc.get_client(target)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_08c6ce47","line":188,"updated":"2016-07-29 13:24:22.000000000","message":"shouldn\u0027t you bump the version for new messages?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"},{"line_number":187,"context_line":"        target \u003d oslo_messaging.Target("},{"line_number":188,"context_line":"            version\u003d\u00271.0\u0027,"},{"line_number":189,"context_line":"            namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":190,"context_line":"        self.client \u003d n_rpc.get_client(target)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_4106d886","line":188,"in_reply_to":"bacf61ea_08c6ce47","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def __init__(self):"},{"line_number":187,"context_line":"        target \u003d oslo_messaging.Target("},{"line_number":188,"context_line":"            version\u003d\u00271.0\u0027,"},{"line_number":189,"context_line":"            namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":190,"context_line":"        self.client \u003d n_rpc.get_client(target)"},{"line_number":191,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9492d39d","line":188,"in_reply_to":"bacf61ea_08c6ce47","updated":"2016-07-29 16:15:57.000000000","message":"Yeah, you\u0027re right, agents may support 1.1, and server may cast 1.0 or 1.1 depending on the payload.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        resource_type \u003d resources.get_resource_type(resource_list[0])"},{"line_number":202,"context_line":"        _validate_resource_type(resource_type)"},{"line_number":203,"context_line":"        _validate_resource_list_homogeneity(resource_list, resource_type)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        for version in version_manager.get_resource_versions(resource_type):"},{"line_number":206,"context_line":"            cctxt \u003d self._prepare_object_fanout_context("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_685caaed","line":203,"updated":"2016-07-29 13:24:22.000000000","message":"couldn\u0027t we instead classify pushed objects by type and send a batch of lists?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        resource_type \u003d resources.get_resource_type(resource_list[0])"},{"line_number":202,"context_line":"        _validate_resource_type(resource_type)"},{"line_number":203,"context_line":"        _validate_resource_list_homogeneity(resource_list, resource_type)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        for version in version_manager.get_resource_versions(resource_type):"},{"line_number":206,"context_line":"            cctxt \u003d self._prepare_object_fanout_context("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_343847a0","line":203,"in_reply_to":"bacf61ea_685caaed","updated":"2016-07-29 16:15:57.000000000","message":"As per discussed on irc, such thing would enable us to pile objects in a list, and then notify them all at once. Which seems developer friendly, and it\u0027s probably the same amount of lines than the homogeneity validation, so... why not.\n\nDone.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":200,"context_line":""},{"line_number":201,"context_line":"        resource_type \u003d resources.get_resource_type(resource_list[0])"},{"line_number":202,"context_line":"        _validate_resource_type(resource_type)"},{"line_number":203,"context_line":"        _validate_resource_list_homogeneity(resource_list, resource_type)"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        for version in version_manager.get_resource_versions(resource_type):"},{"line_number":206,"context_line":"            cctxt \u003d self._prepare_object_fanout_context("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_81fc5073","line":203,"in_reply_to":"bacf61ea_685caaed","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                for resource in resource_list]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if len(dehydrated_resources) \u003d\u003d 1:"},{"line_number":213,"context_line":"                #TODO(mangelajo): remove in Otaka, backwards compatibility"},{"line_number":214,"context_line":"                #                 for agents expecting a single element as"},{"line_number":215,"context_line":"                #                 a single element instead of a list, this"},{"line_number":216,"context_line":"                #                 is only relevant to the QoSPolicy topic queue"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_88de3e3d","line":213,"updated":"2016-07-29 13:24:22.000000000","message":"Ocata","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b2516dc771164a76de2935ded1e6d07fd3eeb0c6","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                for resource in resource_list]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if len(dehydrated_resources) \u003d\u003d 1:"},{"line_number":213,"context_line":"                #TODO(mangelajo): remove in Otaka, backwards compatibility"},{"line_number":214,"context_line":"                #                 for agents expecting a single element as"},{"line_number":215,"context_line":"                #                 a single element instead of a list, this"},{"line_number":216,"context_line":"                #                 is only relevant to the QoSPolicy topic queue"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3ed5c11b","line":213,"in_reply_to":"bacf61ea_585a4d2b","updated":"2016-07-29 15:53:45.000000000","message":"It\u0027s all over the place. It\u0027s must be a feature, not a bug.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                for resource in resource_list]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if len(dehydrated_resources) \u003d\u003d 1:"},{"line_number":213,"context_line":"                #TODO(mangelajo): remove in Otaka, backwards compatibility"},{"line_number":214,"context_line":"                #                 for agents expecting a single element as"},{"line_number":215,"context_line":"                #                 a single element instead of a list, this"},{"line_number":216,"context_line":"                #                 is only relevant to the QoSPolicy topic queue"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a1f7d489","line":213,"in_reply_to":"bacf61ea_88de3e3d","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"0fa353228227d48ffc7942961a5e0b3bb7552c0e","unresolved":false,"context_lines":[{"line_number":210,"context_line":"                for resource in resource_list]"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"            if len(dehydrated_resources) \u003d\u003d 1:"},{"line_number":213,"context_line":"                #TODO(mangelajo): remove in Otaka, backwards compatibility"},{"line_number":214,"context_line":"                #                 for agents expecting a single element as"},{"line_number":215,"context_line":"                #                 a single element instead of a list, this"},{"line_number":216,"context_line":"                #                 is only relevant to the QoSPolicy topic queue"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_585a4d2b","line":213,"in_reply_to":"bacf61ea_88de3e3d","updated":"2016-07-29 15:17:34.000000000","message":"Miguel: you of everybody I would have expected not make this spelling mistake!!","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                #TODO(mangelajo): remove in Otaka, backwards compatibility"},{"line_number":214,"context_line":"                #                 for agents expecting a single element as"},{"line_number":215,"context_line":"                #                 a single element instead of a list, this"},{"line_number":216,"context_line":"                #                 is only relevant to the QoSPolicy topic queue"},{"line_number":217,"context_line":"                cctxt.cast(context, \u0027push\u0027,"},{"line_number":218,"context_line":"                           resource\u003ddehydrated_resources[0],"},{"line_number":219,"context_line":"                           event_type\u003devent_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a8ca226c","line":216,"updated":"2016-07-29 13:24:22.000000000","message":"no it\u0027s not, assuming we consider the mechanism generic. Yes, in tree it was only qos policy.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                #TODO(mangelajo): remove in Otaka, backwards compatibility"},{"line_number":214,"context_line":"                #                 for agents expecting a single element as"},{"line_number":215,"context_line":"                #                 a single element instead of a list, this"},{"line_number":216,"context_line":"                #                 is only relevant to the QoSPolicy topic queue"},{"line_number":217,"context_line":"                cctxt.cast(context, \u0027push\u0027,"},{"line_number":218,"context_line":"                           resource\u003ddehydrated_resources[0],"},{"line_number":219,"context_line":"                           event_type\u003devent_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_94e3f304","line":216,"in_reply_to":"bacf61ea_a8ca226c","updated":"2016-07-29 16:15:57.000000000","message":"Well, but it\u0027s QoSPolicy only, since we filter the push mechanism  (_validate_resource_type) to avoid any other object being pushed, and the list of valid resources contain only QoSPolicy yet.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                           resource\u003ddehydrated_resources[0],"},{"line_number":219,"context_line":"                           event_type\u003devent_type)"},{"line_number":220,"context_line":"            else:"},{"line_number":221,"context_line":"                cctxt.cast(context, \u0027push\u0027,"},{"line_number":222,"context_line":"                           resource_list\u003ddehydrated_resources,"},{"line_number":223,"context_line":"                           event_type\u003devent_type)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a847c21b","line":221,"updated":"2016-07-29 13:24:22.000000000","message":"so what will happen when an older agent will attempt to make sense of the payload? Will it crash?\n\nI suspect that the proper thing to do would be to expose it with a new RPC method, not hijacking the existing one.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                           resource\u003ddehydrated_resources[0],"},{"line_number":219,"context_line":"                           event_type\u003devent_type)"},{"line_number":220,"context_line":"            else:"},{"line_number":221,"context_line":"                cctxt.cast(context, \u0027push\u0027,"},{"line_number":222,"context_line":"                           resource_list\u003ddehydrated_resources,"},{"line_number":223,"context_line":"                           event_type\u003devent_type)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_54afbb93","line":221,"in_reply_to":"bacf61ea_9bacc636","updated":"2016-07-29 16:15:57.000000000","message":"Correct.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"603100915977a06490eacf0e736f6a5bdbe6c3dc","unresolved":false,"context_lines":[{"line_number":218,"context_line":"                           resource\u003ddehydrated_resources[0],"},{"line_number":219,"context_line":"                           event_type\u003devent_type)"},{"line_number":220,"context_line":"            else:"},{"line_number":221,"context_line":"                cctxt.cast(context, \u0027push\u0027,"},{"line_number":222,"context_line":"                           resource_list\u003ddehydrated_resources,"},{"line_number":223,"context_line":"                           event_type\u003devent_type)"},{"line_number":224,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_9bacc636","line":221,"in_reply_to":"bacf61ea_a847c21b","updated":"2016-07-29 13:46:06.000000000","message":"OK, there is an implicit assumption here that no old resources (qos policy) will be pushed with resource_list until Ocata. Then it will work.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    caller side in ResourcesPushRpcApi."},{"line_number":232,"context_line":"    \"\"\""},{"line_number":233,"context_line":"    # History"},{"line_number":234,"context_line":"    #   1.0 Initial version"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":237,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_68eb0ab1","line":234,"updated":"2016-07-29 13:24:22.000000000","message":"bump the version?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":231,"context_line":"    caller side in ResourcesPushRpcApi."},{"line_number":232,"context_line":"    \"\"\""},{"line_number":233,"context_line":"    # History"},{"line_number":234,"context_line":"    #   1.0 Initial version"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":237,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_d49bab70","line":234,"in_reply_to":"bacf61ea_68eb0ab1","updated":"2016-07-29 16:15:57.000000000","message":"Correct.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a7f7f50018fc1aea235179b70fc79c75dc1dfdf7","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":237,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def push(self, context, **kwargs):"},{"line_number":240,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":241,"context_line":"        #                  compatibility during Newton, remove in Otaka"},{"line_number":242,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_48d1e656","line":239,"range":{"start_line":239,"start_character":4,"end_line":239,"end_character":38},"updated":"2016-07-29 13:18:35.000000000","message":"How about mitaka calls that don\u0027t use keyword parameters? Like push(my_context, my_resource, SOME_EVENT)?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":237,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def push(self, context, **kwargs):"},{"line_number":240,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":241,"context_line":"        #                  compatibility during Newton, remove in Otaka"},{"line_number":242,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_34904743","line":239,"range":{"start_line":239,"start_character":4,"end_line":239,"end_character":38},"in_reply_to":"bacf61ea_3b32fa10","updated":"2016-07-29 16:15:57.000000000","message":"Correct.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"352dffa183ff660d8085f47dcd73601ea4a40ee3","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":237,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def push(self, context, **kwargs):"},{"line_number":240,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":241,"context_line":"        #                  compatibility during Newton, remove in Otaka"},{"line_number":242,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_e8f89a4b","line":239,"range":{"start_line":239,"start_character":4,"end_line":239,"end_character":38},"in_reply_to":"bacf61ea_48d1e656","updated":"2016-07-29 13:26:15.000000000","message":"They will be broken, printing random tracebacks in logs and not handling those list messages.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"603100915977a06490eacf0e736f6a5bdbe6c3dc","unresolved":false,"context_lines":[{"line_number":236,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":237,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def push(self, context, **kwargs):"},{"line_number":240,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":241,"context_line":"        #                  compatibility during Newton, remove in Otaka"},{"line_number":242,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3b32fa10","line":239,"range":{"start_line":239,"start_character":4,"end_line":239,"end_character":38},"in_reply_to":"bacf61ea_e8f89a4b","updated":"2016-07-29 13:46:06.000000000","message":"OK, there is an assumption qos policies are sent with the old signature for N.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b77197d68c67a2d085f202ddc69e4b9f72711e5c","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def push(self, context, **kwargs):"},{"line_number":240,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":241,"context_line":"        #                  compatibility during Newton, remove in Otaka"},{"line_number":242,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"},{"line_number":243,"context_line":"                         kwargs[\u0027resource_list\u0027])"},{"line_number":244,"context_line":"        event_type \u003d kwargs[\u0027event_type\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_a81ce213","line":241,"updated":"2016-07-29 13:24:22.000000000","message":"Ocata","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":238,"context_line":""},{"line_number":239,"context_line":"    def push(self, context, **kwargs):"},{"line_number":240,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":241,"context_line":"        #                  compatibility during Newton, remove in Otaka"},{"line_number":242,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"},{"line_number":243,"context_line":"                         kwargs[\u0027resource_list\u0027])"},{"line_number":244,"context_line":"        event_type \u003d kwargs[\u0027event_type\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_14938350","line":241,"in_reply_to":"bacf61ea_a81ce213","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a7f7f50018fc1aea235179b70fc79c75dc1dfdf7","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                         kwargs[\u0027resource_list\u0027])"},{"line_number":244,"context_line":"        event_type \u003d kwargs[\u0027event_type\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        resource_objs \u003d []"},{"line_number":247,"context_line":"        for resource in resource_list:"},{"line_number":248,"context_line":"            resource_objs.append("},{"line_number":249,"context_line":"                obj_base.NeutronObject.clean_obj_from_primitive("},{"line_number":250,"context_line":"                     resource))"},{"line_number":251,"context_line":"        resource_type \u003d resources.get_resource_type(resource_objs[0])"},{"line_number":252,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_e85eda10","line":250,"range":{"start_line":246,"start_character":0,"end_line":250,"end_character":31},"updated":"2016-07-29 13:18:35.000000000","message":"resource_objs \u003d [obj_base.NeutronObject.clean_obj_from_primitive(resource) for resource in resource_list]","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"                         kwargs[\u0027resource_list\u0027])"},{"line_number":244,"context_line":"        event_type \u003d kwargs[\u0027event_type\u0027]"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        resource_objs \u003d []"},{"line_number":247,"context_line":"        for resource in resource_list:"},{"line_number":248,"context_line":"            resource_objs.append("},{"line_number":249,"context_line":"                obj_base.NeutronObject.clean_obj_from_primitive("},{"line_number":250,"context_line":"                     resource))"},{"line_number":251,"context_line":"        resource_type \u003d resources.get_resource_type(resource_objs[0])"},{"line_number":252,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_144ee395","line":250,"range":{"start_line":246,"start_character":0,"end_line":250,"end_character":31},"in_reply_to":"bacf61ea_e85eda10","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                obj_base.NeutronObject.clean_obj_from_primitive("},{"line_number":250,"context_line":"                     resource))"},{"line_number":251,"context_line":"        resource_type \u003d resources.get_resource_type(resource_objs[0])"},{"line_number":252,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3e05c879","line":252,"updated":"2016-07-29 13:59:56.000000000","message":"aren\u0027t you supposed to update neutron/api/rpc/callbacks/consumer/registry.py ? as well as all in tree subscribers? Specifically _handle_notification in qos extension?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                obj_base.NeutronObject.clean_obj_from_primitive("},{"line_number":250,"context_line":"                     resource))"},{"line_number":251,"context_line":"        resource_type \u003d resources.get_resource_type(resource_objs[0])"},{"line_number":252,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_f4f34f9c","line":252,"in_reply_to":"bacf61ea_3e05c879","updated":"2016-07-29 16:15:57.000000000","message":"hmm for _handle_notification, yes, apparently I was just happy with docs!. The registry doesn\u0027t care about what you pass through (that\u0027s covered by the tests).\n\nDone.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    caller side in ResourcesPushRpcApi."},{"line_number":244,"context_line":"    \"\"\""},{"line_number":245,"context_line":"    # History"},{"line_number":246,"context_line":"    #   1.0 Initial version"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":249,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0c3377f7","line":246,"updated":"2016-07-29 16:38:21.000000000","message":"you should describe the 1.1 version here.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    caller side in ResourcesPushRpcApi."},{"line_number":244,"context_line":"    \"\"\""},{"line_number":245,"context_line":"    # History"},{"line_number":246,"context_line":"    #   1.0 Initial version"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":249,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c76f7829","line":246,"in_reply_to":"bacf61ea_0c3377f7","updated":"2016-07-29 17:07:38.000000000","message":"Done","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    # History"},{"line_number":246,"context_line":"    #   1.0 Initial version"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":249,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def push(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_2c547bfd","line":248,"updated":"2016-07-29 16:38:21.000000000","message":"bump the version to indicate to the server you can handle 1.1","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":245,"context_line":"    # History"},{"line_number":246,"context_line":"    #   1.0 Initial version"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.0\u0027,"},{"line_number":249,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    def push(self, context, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_e7727c10","line":248,"in_reply_to":"bacf61ea_2c547bfd","updated":"2016-07-29 17:07:38.000000000","message":"Done","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            for resource in resource_list]"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        resource_type \u003d resources.get_resource_type(resource_objs[0])"},{"line_number":263,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_ec5d4316","line":263,"updated":"2016-07-29 16:38:21.000000000","message":"you still should update registry push signature to indicate it\u0027s a list, even though it kinda works.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            for resource in resource_list]"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        resource_type \u003d resources.get_resource_type(resource_objs[0])"},{"line_number":263,"context_line":"        cons_registry.push(resource_type, resource_objs, event_type)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_720c883b","line":263,"in_reply_to":"bacf61ea_ec5d4316","updated":"2016-07-29 17:07:38.000000000","message":"Done","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f366b6d65de6195849e55a915b0d4fc5dd45a1e","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @log_helpers.log_method_call"},{"line_number":204,"context_line":"    def push(self, context, resource_list, event_type):"},{"line_number":205,"context_line":"        \"\"\"Push an event and list of resources to agents, batched per type.\"\"\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        resources_by_type \u003d self._classify_resources_by_type(resource_list)"},{"line_number":208,"context_line":"        for resource_type, type_resources in resources_by_type.items():"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_321fb06d","line":205,"updated":"2016-07-29 17:29:04.000000000","message":"ah ah!","commit_id":"f272ec419f26e30972547ce826b448b70587aa33"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f366b6d65de6195849e55a915b0d4fc5dd45a1e","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    target \u003d oslo_messaging.Target(version\u003d\u00271.1\u0027,"},{"line_number":250,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def push(self, context, **kwargs):"},{"line_number":253,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":254,"context_line":"        #                  compatibility during Newton, remove in Ocata"},{"line_number":255,"context_line":"        resource_list \u003d ([kwargs[\u0027resource\u0027]] if \u0027resource\u0027 in kwargs else"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_6d5aed2b","line":252,"updated":"2016-07-29 17:29:04.000000000","message":"A docstring that explains that this push emits always homogenous lists would be nice.","commit_id":"f272ec419f26e30972547ce826b448b70587aa33"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def push(self, context, **kwargs):"},{"line_number":258,"context_line":"        \"\"\"Push receiver, will always receive one single type of resource."},{"line_number":259,"context_line":"        The server side splits lists of different resource types into separate"},{"line_number":260,"context_line":"        push events, so this method will always receive one single type of"},{"line_number":261,"context_line":"        resource."}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_e34e9739","line":258,"range":{"start_line":258,"start_character":46,"end_line":258,"end_character":73},"updated":"2016-08-01 20:14:52.000000000","message":"resources of the same type","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                                   namespace\u003dconstants.RPC_NAMESPACE_RESOURCES)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def push(self, context, **kwargs):"},{"line_number":258,"context_line":"        \"\"\"Push receiver, will always receive one single type of resource."},{"line_number":259,"context_line":"        The server side splits lists of different resource types into separate"},{"line_number":260,"context_line":"        push events, so this method will always receive one single type of"},{"line_number":261,"context_line":"        resource."}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_5ce781ab","line":258,"range":{"start_line":258,"start_character":46,"end_line":258,"end_character":73},"in_reply_to":"bacf61ea_e34e9739","updated":"2016-08-01 21:15:26.000000000","message":"Done","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def push(self, context, **kwargs):"},{"line_number":258,"context_line":"        \"\"\"Push receiver, will always receive one single type of resource."},{"line_number":259,"context_line":"        The server side splits lists of different resource types into separate"},{"line_number":260,"context_line":"        push events, so this method will always receive one single type of"},{"line_number":261,"context_line":"        resource."},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":264,"context_line":"        #                  compatibility during Newton, remove in Ocata"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_03500bd3","line":261,"range":{"start_line":259,"start_character":8,"end_line":261,"end_character":17},"updated":"2016-08-01 20:14:52.000000000","message":"this sentence does not belong to the receiver side, and it duplicates the server side docstring. I suggest to remove it.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def push(self, context, **kwargs):"},{"line_number":258,"context_line":"        \"\"\"Push receiver, will always receive one single type of resource."},{"line_number":259,"context_line":"        The server side splits lists of different resource types into separate"},{"line_number":260,"context_line":"        push events, so this method will always receive one single type of"},{"line_number":261,"context_line":"        resource."},{"line_number":262,"context_line":"        \"\"\""},{"line_number":263,"context_line":"        # TODO(mangelajo): accept single \u0027resource\u0027 parameter for backwards"},{"line_number":264,"context_line":"        #                  compatibility during Newton, remove in Ocata"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_5c9e6107","line":261,"range":{"start_line":259,"start_character":8,"end_line":261,"end_character":17},"in_reply_to":"bacf61ea_03500bd3","updated":"2016-08-01 21:15:26.000000000","message":"Agreed.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"}],"neutron/tests/unit/api/rpc/handlers/test_resources_rpc.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            with mock.patch.object(version_manager, \u0027get_resource_versions\u0027,"},{"line_number":213,"context_line":"                    return_value\u003dset([FakeResource.VERSION])):"},{"line_number":214,"context_line":"                self.rpc.push("},{"line_number":215,"context_line":"                    self.context, [self.resource_obj, self.resource_obj],"},{"line_number":216,"context_line":"                    \u0027TYPE\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        self.cctxt_mock.cast.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_de162cf0","line":215,"updated":"2016-07-29 13:59:56.000000000","message":"can we be more realistic here, pushing different objects?","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            with mock.patch.object(version_manager, \u0027get_resource_versions\u0027,"},{"line_number":213,"context_line":"                    return_value\u003dset([FakeResource.VERSION])):"},{"line_number":214,"context_line":"                self.rpc.push("},{"line_number":215,"context_line":"                    self.context, [self.resource_obj, self.resource_obj],"},{"line_number":216,"context_line":"                    \u0027TYPE\u0027)"},{"line_number":217,"context_line":""},{"line_number":218,"context_line":"        self.cctxt_mock.cast.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_8a362ee5","line":215,"in_reply_to":"bacf61ea_de162cf0","updated":"2016-07-29 16:15:57.000000000","message":"Done, added another test. (I needed to handle get_resource_cls with a side_effect to handle two types of objects)","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            event_type\u003d\u0027TYPE\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_push_backwardscompat(self):"},{"line_number":225,"context_line":"        #TODO(mangelajo) remove in Otaka, since the \u0027resource\u0027 parameter"},{"line_number":226,"context_line":"        #                is just for backwards compatibility with Mitaka"},{"line_number":227,"context_line":"        #                agents."},{"line_number":228,"context_line":"        with mock.patch.object(resources_rpc.resources, \u0027get_resource_cls\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_3ed4a81e","line":225,"updated":"2016-07-29 13:59:56.000000000","message":"ocata","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":222,"context_line":"            event_type\u003d\u0027TYPE\u0027)"},{"line_number":223,"context_line":""},{"line_number":224,"context_line":"    def test_push_backwardscompat(self):"},{"line_number":225,"context_line":"        #TODO(mangelajo) remove in Otaka, since the \u0027resource\u0027 parameter"},{"line_number":226,"context_line":"        #                is just for backwards compatibility with Mitaka"},{"line_number":227,"context_line":"        #                agents."},{"line_number":228,"context_line":"        with mock.patch.object(resources_rpc.resources, \u0027get_resource_cls\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_2a4e226f","line":225,"in_reply_to":"bacf61ea_3ed4a81e","updated":"2016-07-29 16:15:57.000000000","message":"I must fix my brain entry...","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":255,"context_line":"    def test_push(self, reg_push_mock):"},{"line_number":256,"context_line":"        self.obj_registry.register(FakeResource)"},{"line_number":257,"context_line":"        self.callbacks.push(self.context, resource_list\u003d[self.resource_prim,"},{"line_number":258,"context_line":"                                                         self.resource_prim],"},{"line_number":259,"context_line":"                            event_type\u003d\u0027TYPE\u0027)"},{"line_number":260,"context_line":"        reg_push_mock.assert_called_once_with(self.resource_obj.obj_name(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7eb580ec","line":257,"updated":"2016-07-29 13:59:56.000000000","message":"ditto","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":255,"context_line":"    def test_push(self, reg_push_mock):"},{"line_number":256,"context_line":"        self.obj_registry.register(FakeResource)"},{"line_number":257,"context_line":"        self.callbacks.push(self.context, resource_list\u003d[self.resource_prim,"},{"line_number":258,"context_line":"                                                         self.resource_prim],"},{"line_number":259,"context_line":"                            event_type\u003d\u0027TYPE\u0027)"},{"line_number":260,"context_line":"        reg_push_mock.assert_called_once_with(self.resource_obj.obj_name(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_ea636ada","line":257,"in_reply_to":"bacf61ea_7eb580ec","updated":"2016-07-29 16:15:57.000000000","message":"In the agent side they will always be broken up in different resource types, since they come in different queues. This is testing the agent side.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                               self.resource_obj], \u0027TYPE\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":265,"context_line":"    def test_push_backwardscompat(self, reg_push_mock):"},{"line_number":266,"context_line":"        #TODO(mangelajo) remove in Otaka, since the \u0027resource\u0027 parameter"},{"line_number":267,"context_line":"        #                is just for backwards compatibility with Mitaka"},{"line_number":268,"context_line":"        #                agents."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_be7d381e","line":265,"range":{"start_line":265,"start_character":18,"end_line":265,"end_character":33},"updated":"2016-07-29 13:59:56.000000000","message":"maybe add mitaka to the name","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                                               self.resource_obj], \u0027TYPE\u0027)"},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":265,"context_line":"    def test_push_backwardscompat(self, reg_push_mock):"},{"line_number":266,"context_line":"        #TODO(mangelajo) remove in Otaka, since the \u0027resource\u0027 parameter"},{"line_number":267,"context_line":"        #                is just for backwards compatibility with Mitaka"},{"line_number":268,"context_line":"        #                agents."}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_0aed1e25","line":265,"range":{"start_line":265,"start_character":18,"end_line":265,"end_character":33},"in_reply_to":"bacf61ea_be7d381e","updated":"2016-07-29 16:15:57.000000000","message":"Done.","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"387fd7d757d86cccdce244101da48fd6fa184c44","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":265,"context_line":"    def test_push_backwardscompat(self, reg_push_mock):"},{"line_number":266,"context_line":"        #TODO(mangelajo) remove in Otaka, since the \u0027resource\u0027 parameter"},{"line_number":267,"context_line":"        #                is just for backwards compatibility with Mitaka"},{"line_number":268,"context_line":"        #                agents."},{"line_number":269,"context_line":"        self.obj_registry.register(FakeResource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_5eafdc93","line":266,"updated":"2016-07-29 13:59:56.000000000","message":"ocata","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"44d41202e14e5c361327f2a9cee77b1ae38b3d2a","unresolved":false,"context_lines":[{"line_number":263,"context_line":""},{"line_number":264,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":265,"context_line":"    def test_push_backwardscompat(self, reg_push_mock):"},{"line_number":266,"context_line":"        #TODO(mangelajo) remove in Otaka, since the \u0027resource\u0027 parameter"},{"line_number":267,"context_line":"        #                is just for backwards compatibility with Mitaka"},{"line_number":268,"context_line":"        #                agents."},{"line_number":269,"context_line":"        self.obj_registry.register(FakeResource)"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_caff86a8","line":266,"in_reply_to":"bacf61ea_5eafdc93","updated":"2016-07-29 16:15:57.000000000","message":"Done","commit_id":"ada29a4fa2a854f2401b4015e82f19c22aa10c51"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class FakerResource(BaseFakeResource):"},{"line_number":56,"context_line":"    # Version 1.0: Initial version"},{"line_number":57,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4cebaf13","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":11},"updated":"2016-07-29 16:38:21.000000000","message":"what does Faker mean?","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class FakerResource(BaseFakeResource):"},{"line_number":56,"context_line":"    # Version 1.0: Initial version"},{"line_number":57,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_524fc46a","line":55,"range":{"start_line":55,"start_character":6,"end_line":55,"end_character":11},"in_reply_to":"bacf61ea_4cebaf13","updated":"2016-07-29 17:07:38.000000000","message":"more fake :), sounds weird anyway :]","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _create_test_resource(context\u003dNone, resource_cls\u003dFakeResource):"},{"line_number":66,"context_line":"    resource_dict \u003d _create_test_dict()"},{"line_number":67,"context_line":"    resource \u003d resource_cls(context, **resource_dict)"},{"line_number":68,"context_line":"    resource.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_cce95fe8","line":65,"updated":"2016-07-29 16:38:21.000000000","message":"I prefer we keep it in the original place, near _create_test_dict. You could move the latter below too. Just so helper functions stay close.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"859ba2ecd0577388388838c1c58d7753f955ce4d","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _create_test_resource(context\u003dNone, resource_cls\u003dFakeResource):"},{"line_number":66,"context_line":"    resource_dict \u003d _create_test_dict()"},{"line_number":67,"context_line":"    resource \u003d resource_cls(context, **resource_dict)"},{"line_number":68,"context_line":"    resource.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_52d5041a","line":65,"in_reply_to":"bacf61ea_124a6c55","updated":"2016-07-29 17:09:34.000000000","message":"You can move models before helpers.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"66174754fb62bd0a9117b895ea013df29072426e","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _create_test_resource(context\u003dNone, resource_cls\u003dFakeResource):"},{"line_number":66,"context_line":"    resource_dict \u003d _create_test_dict()"},{"line_number":67,"context_line":"    resource \u003d resource_cls(context, **resource_dict)"},{"line_number":68,"context_line":"    resource.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d266db4f","line":65,"in_reply_to":"bacf61ea_52d5041a","updated":"2016-08-01 10:49:36.000000000","message":"You can use None as default and set FakeResource later. I assume we won\u0027t need to pass None to this function.\n\n resource_cls \u003d resource_cls or FakeResource","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _create_test_resource(context\u003dNone, resource_cls\u003dFakeResource):"},{"line_number":66,"context_line":"    resource_dict \u003d _create_test_dict()"},{"line_number":67,"context_line":"    resource \u003d resource_cls(context, **resource_dict)"},{"line_number":68,"context_line":"    resource.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_124a6c55","line":65,"in_reply_to":"bacf61ea_cce95fe8","updated":"2016-07-29 17:07:38.000000000","message":"I depend on FakerResource for the default arg, but I can change that.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"dd8cbc77944a0a09d82afce48d6e75f373885389","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    }"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"def _create_test_resource(context\u003dNone, resource_cls\u003dFakeResource):"},{"line_number":66,"context_line":"    resource_dict \u003d _create_test_dict()"},{"line_number":67,"context_line":"    resource \u003d resource_cls(context, **resource_dict)"},{"line_number":68,"context_line":"    resource.obj_reset_changes()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c398d06c","line":65,"in_reply_to":"bacf61ea_d266db4f","updated":"2016-08-01 11:24:33.000000000","message":"Yes, that\u0027s what you\u0027ll see on next ps :)","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        self.resource_obj2 \u003d _create_test_resource(self.context,"},{"line_number":215,"context_line":"                                                   FakerResource)"},{"line_number":216,"context_line":"        mock.patch.object(version_manager, \u0027get_resource_versions\u0027,"},{"line_number":217,"context_line":"                         return_value\u003dset([FakeResource.VERSION])).start()"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test__prepare_object_fanout_context(self):"},{"line_number":220,"context_line":"        expected_topic \u003d topics.RESOURCE_TOPIC_PATTERN % {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_4c2d6ffd","line":217,"range":{"start_line":217,"start_character":42,"end_line":217,"end_character":64},"updated":"2016-07-29 16:38:21.000000000","message":"even for Faker? I know those are identical, but you should still distinguish to have the test logic semantically correct.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":214,"context_line":"        self.resource_obj2 \u003d _create_test_resource(self.context,"},{"line_number":215,"context_line":"                                                   FakerResource)"},{"line_number":216,"context_line":"        mock.patch.object(version_manager, \u0027get_resource_versions\u0027,"},{"line_number":217,"context_line":"                         return_value\u003dset([FakeResource.VERSION])).start()"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    def test__prepare_object_fanout_context(self):"},{"line_number":220,"context_line":"        expected_topic \u003d topics.RESOURCE_TOPIC_PATTERN % {"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_12bd4c02","line":217,"range":{"start_line":217,"start_character":42,"end_line":217,"end_character":64},"in_reply_to":"bacf61ea_4c2d6ffd","updated":"2016-07-29 17:07:38.000000000","message":"moved to a common constant.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            fanout\u003dTrue, topic\u003dexpected_topic, version\u003d\u00271.0\u0027)"},{"line_number":229,"context_line":"        self.assertEqual(self.cctxt_mock, observed)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_push(self):"},{"line_number":232,"context_line":"        self.rpc.push("},{"line_number":233,"context_line":"            self.context, [self.resource_obj, self.resource_obj],"},{"line_number":234,"context_line":"            TEST_EVENT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0c9257f6","line":231,"updated":"2016-07-29 16:38:21.000000000","message":"I guess the method could be renamed into test_push_same_resource_type to be more explicit about the intent.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f3b43d8467b46442085e8b02e95cce56e6a3dbda","unresolved":false,"context_lines":[{"line_number":228,"context_line":"            fanout\u003dTrue, topic\u003dexpected_topic, version\u003d\u00271.0\u0027)"},{"line_number":229,"context_line":"        self.assertEqual(self.cctxt_mock, observed)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_push(self):"},{"line_number":232,"context_line":"        self.rpc.push("},{"line_number":233,"context_line":"            self.context, [self.resource_obj, self.resource_obj],"},{"line_number":234,"context_line":"            TEST_EVENT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_725be8f6","line":231,"in_reply_to":"bacf61ea_0c9257f6","updated":"2016-07-29 17:07:38.000000000","message":"This and next comments will be handled on next respin, I need to run.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_push(self):"},{"line_number":232,"context_line":"        self.rpc.push("},{"line_number":233,"context_line":"            self.context, [self.resource_obj, self.resource_obj],"},{"line_number":234,"context_line":"            TEST_EVENT)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.cctxt_mock.cast.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_8c9da70c","line":233,"updated":"2016-07-29 16:38:21.000000000","message":"so, what\u0027s the use case to push identical objects on the wire? This should probably use different resources of the same type.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d503c96e4f262ae398d0e2f3134a08796273b33a","unresolved":false,"context_lines":[{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def test_push(self):"},{"line_number":232,"context_line":"        self.rpc.push("},{"line_number":233,"context_line":"            self.context, [self.resource_obj, self.resource_obj],"},{"line_number":234,"context_line":"            TEST_EVENT)"},{"line_number":235,"context_line":""},{"line_number":236,"context_line":"        self.cctxt_mock.cast.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_c96d91cd","line":233,"in_reply_to":"bacf61ea_8c9da70c","updated":"2016-08-01 11:57:29.000000000","message":"Done","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_push_mixed(self):"},{"line_number":243,"context_line":"        self.rpc.push("},{"line_number":244,"context_line":"            self.context, [self.resource_obj, self.resource_obj2,"},{"line_number":245,"context_line":"                           self.resource_obj, self.resource_obj2,"},{"line_number":246,"context_line":"                           self.resource_obj2],"},{"line_number":247,"context_line":"            event_type\u003dTEST_EVENT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0ca9b724","line":244,"updated":"2016-07-29 16:38:21.000000000","message":"same question as above, why sending idenitical objects? that\u0027s ok to have it as a test, but we should also have one for a more realistic case, where you send different objects in a batch.","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d503c96e4f262ae398d0e2f3134a08796273b33a","unresolved":false,"context_lines":[{"line_number":241,"context_line":""},{"line_number":242,"context_line":"    def test_push_mixed(self):"},{"line_number":243,"context_line":"        self.rpc.push("},{"line_number":244,"context_line":"            self.context, [self.resource_obj, self.resource_obj2,"},{"line_number":245,"context_line":"                           self.resource_obj, self.resource_obj2,"},{"line_number":246,"context_line":"                           self.resource_obj2],"},{"line_number":247,"context_line":"            event_type\u003dTEST_EVENT)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_096cc9cc","line":244,"in_reply_to":"bacf61ea_0ca9b724","updated":"2016-08-01 11:57:29.000000000","message":"Done","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1e3f98fb9eb9f2e4e7d0188938fa789aa63c3f10","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":285,"context_line":"    def test_push(self, reg_push_mock):"},{"line_number":286,"context_line":"        self.obj_registry.register(FakeResource)"},{"line_number":287,"context_line":"        self.callbacks.push(self.context, resource_list\u003d[self.resource_prim,"},{"line_number":288,"context_line":"                                                         self.resource_prim],"},{"line_number":289,"context_line":"                            event_type\u003dTEST_EVENT)"},{"line_number":290,"context_line":"        reg_push_mock.assert_called_once_with(self.resource_obj.obj_name(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_0c57f726","line":287,"updated":"2016-07-29 16:38:21.000000000","message":"ditto on identical objects","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d503c96e4f262ae398d0e2f3134a08796273b33a","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    @mock.patch.object(resources_rpc.cons_registry, \u0027push\u0027)"},{"line_number":285,"context_line":"    def test_push(self, reg_push_mock):"},{"line_number":286,"context_line":"        self.obj_registry.register(FakeResource)"},{"line_number":287,"context_line":"        self.callbacks.push(self.context, resource_list\u003d[self.resource_prim,"},{"line_number":288,"context_line":"                                                         self.resource_prim],"},{"line_number":289,"context_line":"                            event_type\u003dTEST_EVENT)"},{"line_number":290,"context_line":"        reg_push_mock.assert_called_once_with(self.resource_obj.obj_name(),"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_69a105f8","line":287,"in_reply_to":"bacf61ea_0c57f726","updated":"2016-08-01 11:57:29.000000000","message":"Done","commit_id":"1047d0c04e6ac0eebed267c2ac495da7ae18007d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2a692517337923e0ff0ef05b784d6457822eae62","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.resource_objs \u003d [_create_test_resource(self.context)"},{"line_number":87,"context_line":"                              for _ in range(2)]"},{"line_number":88,"context_line":"        self.resource_objs2 \u003d [_create_test_resource(self.context,"},{"line_number":89,"context_line":"                                                   FakerResource)"},{"line_number":90,"context_line":"                               for _ in range(2)]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_c31ef30a","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":64},"updated":"2016-08-01 20:14:52.000000000","message":"I suggest this name is changed to something more clear. As it\u0027s now, it could be interpreted as if the class \u0027fakes something\u0027, since it\u0027s a \u0027faker\u0027 (noun). In this regard, even a bare FakeResource2 would be less misleading.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"2c88507279f5549cae2164173395045b79018625","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        self.resource_objs \u003d [_create_test_resource(self.context)"},{"line_number":87,"context_line":"                              for _ in range(2)]"},{"line_number":88,"context_line":"        self.resource_objs2 \u003d [_create_test_resource(self.context,"},{"line_number":89,"context_line":"                                                   FakerResource)"},{"line_number":90,"context_line":"                               for _ in range(2)]"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":7,"id":"bacf61ea_bc295d9d","line":89,"range":{"start_line":89,"start_character":51,"end_line":89,"end_character":64},"in_reply_to":"bacf61ea_c31ef30a","updated":"2016-08-01 21:15:26.000000000","message":"I\u0027ll change it to FakeResource2, as FakeResource and original FakerResource  have the same objective.","commit_id":"14d6d399fcb1a4305d5a22e1e473653d91826e73"}]}
