)]}'
{"neutron/agent/agent_extensions_manager.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"bc2dae4665a7a4b471b937ff106e3f06649401d4","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"#def register_opts(conf):"},{"line_number":30,"context_line":"#    conf.register_opts(AGENT_EXT_MANAGER_OPTS, \u0027agent\u0027)"},{"line_number":31,"context_line":"agent_extensions_manager.register_agent_ext_manager_opts()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_68ec462a","line":30,"updated":"2016-08-01 19:47:29.000000000","message":"shoudln\u0027t keep this commented, just remove it.","commit_id":"7f6fbaeeb695384e7bfdb094c9797a925f950a2d"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"ac5ccf90307922764fbfb897fc58f5479591d925","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"#def register_opts(conf):"},{"line_number":30,"context_line":"#    conf.register_opts(AGENT_EXT_MANAGER_OPTS, \u0027agent\u0027)"},{"line_number":31,"context_line":"agent_extensions_manager.register_agent_ext_manager_opts()"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0844aab4","line":30,"in_reply_to":"bacf61ea_68ec462a","updated":"2016-08-01 19:56:18.000000000","message":"Done","commit_id":"7f6fbaeeb695384e7bfdb094c9797a925f950a2d"},{"author":{"_account_id":13995,"name":"Nate Johnston","email":"nate.johnston@redhat.com","username":"natejohnston"},"change_message_id":"ca0e4630f35e71441a9106fbb2573de78998a9c0","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import stevedore"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _LI"},{"line_number":17,"context_line":"from neutron.conf.agent import agent_extensions_manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a8ec9b2_8caab383","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":55},"updated":"2016-09-16 17:46:04.000000000","message":"Since you\u0027re in a file named \"agent_extensions_manager\" you might want to add an \"as\" clause to give this a different name.  Otherwise I think people might find it confusing.\n\n    from neutron.conf.agent import agent_extensions_manager as agent_ext_mgr_config","commit_id":"4f68cd33f3dfca263d352dc1599991680fc0c5e9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4faf7366ca73d7d8bd03a59cabe5b062b19d0d3e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import stevedore"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _LI"},{"line_number":17,"context_line":"from neutron.conf.agent import agent_extensions_manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_51b7ed38","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":55},"in_reply_to":"5a8bc5a2_e3ed948c","updated":"2016-09-22 23:44:14.000000000","message":"Done","commit_id":"4f68cd33f3dfca263d352dc1599991680fc0c5e9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4faf7366ca73d7d8bd03a59cabe5b062b19d0d3e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import stevedore"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _LI"},{"line_number":17,"context_line":"from neutron.conf.agent import agent_extensions_manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_31ba6124","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":55},"in_reply_to":"7a8ec9b2_8caab383","updated":"2016-09-22 23:44:14.000000000","message":"Done","commit_id":"4f68cd33f3dfca263d352dc1599991680fc0c5e9"},{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a6ee6ad84de742b644b5a7b4482bb457d07fcb8a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import stevedore"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from neutron._i18n import _LI"},{"line_number":17,"context_line":"from neutron.conf.agent import agent_extensions_manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_e3ed948c","line":17,"range":{"start_line":17,"start_character":31,"end_line":17,"end_character":55},"in_reply_to":"7a8ec9b2_8caab383","updated":"2016-09-22 20:31:53.000000000","message":"I agree.  I think its important enough to do another PS to limit confusion in the code.","commit_id":"4f68cd33f3dfca263d352dc1599991680fc0c5e9"}],"neutron/agent/l2/l2_agent_extensions_manager.py":[{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"29e380ac55ac1dd5e0c38c3b00d295e03565b306","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def register_opts(conf):"},{"line_number":26,"context_line":"    agent_ext_mgr_config.register_agent_ext_manager_opts(conf)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class L2AgentExtensionsManager(agent_ext_manager.AgentExtensionsManager):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0872ea10","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":61},"updated":"2016-08-01 19:59:38.000000000","message":"The register function already has default cfg\u003dcfg.CONF right?","commit_id":"7f4eafb7852f7081eae000cbc8b13c59fd664829"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6581c474f6b45ba47c8ff6697c59aae77a6d4583","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"def register_opts(conf):"},{"line_number":26,"context_line":"    agent_ext_mgr_config.register_agent_ext_manager_opts(conf)"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class L2AgentExtensionsManager(agent_ext_manager.AgentExtensionsManager):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7fc23786","line":26,"range":{"start_line":26,"start_character":57,"end_line":26,"end_character":61},"in_reply_to":"bacf61ea_0872ea10","updated":"2016-08-01 22:02:56.000000000","message":"Need to keep this as it is as conf is passed through register_opts(conf) from other files that is using l2_agent_extensions_manager.py\nOne example is in file \"plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py:\" line: 397","commit_id":"7f4eafb7852f7081eae000cbc8b13c59fd664829"}],"neutron/agent/l3/l3_agent_extensions_manager.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"a6ee6ad84de742b644b5a7b4482bb457d07fcb8a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _LE"},{"line_number":19,"context_line":"from neutron.agent import agent_extensions_manager as agent_ext_manager"},{"line_number":20,"context_line":"from neutron.conf.agent import agent_extensions_manager as agent_ext_mgr_conf"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_235cdc4a","line":20,"updated":"2016-09-22 20:31:53.000000000","message":"nit: can you keep this name consistent with the previous file in this patch? agent_ext_mgr_config?","commit_id":"4f68cd33f3dfca263d352dc1599991680fc0c5e9"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"4faf7366ca73d7d8bd03a59cabe5b062b19d0d3e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _LE"},{"line_number":19,"context_line":"from neutron.agent import agent_extensions_manager as agent_ext_manager"},{"line_number":20,"context_line":"from neutron.conf.agent import agent_extensions_manager as agent_ext_mgr_conf"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"5a8bc5a2_31e8a110","line":20,"in_reply_to":"5a8bc5a2_235cdc4a","updated":"2016-09-22 23:44:14.000000000","message":"Done","commit_id":"4f68cd33f3dfca263d352dc1599991680fc0c5e9"}],"neutron/opts.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"df3e2134cb9a3ac0ae29249f8ba6b23b99ef2bb6","unresolved":false,"context_lines":[{"line_number":290,"context_line":"         neutron.plugins.ml2.drivers.mech_sriov.agent.common.config."},{"line_number":291,"context_line":"         sriov_nic_opts),"},{"line_number":292,"context_line":"        (\u0027agent\u0027,"},{"line_number":293,"context_line":"         neutron.conf.agent.agent_extensions_manager.AGENT_EXT_MANAGER_OPTS)"},{"line_number":294,"context_line":"    ]"},{"line_number":295,"context_line":""},{"line_number":296,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_7e1712ee","line":293,"updated":"2016-08-05 06:13:56.000000000","message":"interesting that the fdb population option isn\u0027t in this file at all.","commit_id":"f18e340c641cae88d00bb3daca0b23fd69c06e04"},{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"4583f110dabf298f3a192979a46c57d9060a824a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import neutron.agent.agent_extensions_manager"},{"line_number":21,"context_line":"import neutron.agent.common.config"},{"line_number":22,"context_line":"import neutron.agent.l3.config"},{"line_number":23,"context_line":"import neutron.agent.l3.ha"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_86aff27b","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":45},"updated":"2016-09-16 16:53:13.000000000","message":"unused import, please remove it","commit_id":"531a833a3c69e03bae5d4f0c1d0856fcea293a0a"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"9d76c4fbda2cda988f0878462e58b4138fb77650","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from keystoneauth1 import loading as ks_loading"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import neutron.agent.agent_extensions_manager"},{"line_number":21,"context_line":"import neutron.agent.common.config"},{"line_number":22,"context_line":"import neutron.agent.l3.config"},{"line_number":23,"context_line":"import neutron.agent.l3.ha"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a8ec9b2_ac284f34","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":45},"in_reply_to":"7a8ec9b2_86aff27b","updated":"2016-09-16 17:35:54.000000000","message":"Done","commit_id":"531a833a3c69e03bae5d4f0c1d0856fcea293a0a"}],"neutron/tests/unit/agent/test_agent_extensions_manager.py":[{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"29e380ac55ac1dd5e0c38c3b00d295e03565b306","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        mock.patch(\u0027neutron.agent.l2.extensions.qos.QosAgentExtension\u0027,"},{"line_number":26,"context_line":"                   autospec\u003dTrue).start()"},{"line_number":27,"context_line":"        conf \u003d cfg.CONF"},{"line_number":28,"context_line":"        ext_manager_config.register_agent_ext_manager_opts(conf)"},{"line_number":29,"context_line":"        cfg.CONF.set_override(\u0027extensions\u0027, [\u0027qos\u0027], \u0027agent\u0027)"},{"line_number":30,"context_line":"        namespace \u003d \u0027neutron.agent.l2.extensions\u0027"},{"line_number":31,"context_line":"        self.manager \u003d ext_manager.AgentExtensionsManager(conf, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_08494ab7","line":28,"range":{"start_line":28,"start_character":59,"end_line":28,"end_character":63},"updated":"2016-08-01 19:59:38.000000000","message":"ditto","commit_id":"7f4eafb7852f7081eae000cbc8b13c59fd664829"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"6581c474f6b45ba47c8ff6697c59aae77a6d4583","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        mock.patch(\u0027neutron.agent.l2.extensions.qos.QosAgentExtension\u0027,"},{"line_number":26,"context_line":"                   autospec\u003dTrue).start()"},{"line_number":27,"context_line":"        conf \u003d cfg.CONF"},{"line_number":28,"context_line":"        ext_manager_config.register_agent_ext_manager_opts(conf)"},{"line_number":29,"context_line":"        cfg.CONF.set_override(\u0027extensions\u0027, [\u0027qos\u0027], \u0027agent\u0027)"},{"line_number":30,"context_line":"        namespace \u003d \u0027neutron.agent.l2.extensions\u0027"},{"line_number":31,"context_line":"        self.manager \u003d ext_manager.AgentExtensionsManager(conf, namespace)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3f28bf32","line":28,"range":{"start_line":28,"start_character":59,"end_line":28,"end_character":63},"in_reply_to":"bacf61ea_08494ab7","updated":"2016-08-01 22:02:56.000000000","message":"Done","commit_id":"7f4eafb7852f7081eae000cbc8b13c59fd664829"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"0f74925e180cc6a657b63cca7ad744dda614917e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"        ext_manager_config.register_agent_ext_manager_opts()"},{"line_number":29,"context_line":"        cfg.CONF.set_override(\u0027extensions\u0027, [\u0027qos\u0027], \u0027agent\u0027)"},{"line_number":30,"context_line":"        namespace \u003d \u0027neutron.agent.l2.extensions\u0027"},{"line_number":31,"context_line":"        self.manager \u003d ext_manager.AgentExtensionsManager(conf, namespace)"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _get_extension(self):"},{"line_number":34,"context_line":"        return self.manager.extensions[0].obj"}],"source_content_type":"text/x-python","patch_set":8,"id":"1a95cdbc_d96c249f","line":31,"range":{"start_line":31,"start_character":58,"end_line":31,"end_character":62},"updated":"2016-10-04 22:00:16.000000000","message":"This can be replaced with cfg.CONF now, it saves the code from doing the assignment operation on line 27.","commit_id":"7b6ebb47537333ecbabcf353b6b1e9038b1e96e6"}]}