)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8d18d7d2c40fea5ca404de3c06652e07e6a48df7","unresolved":false,"context_lines":[{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Adding two tests:"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"* A test that for non-cli ovs-ofctl interface verifies that stopping the"},{"line_number":17,"context_line":"  ovs-neutron-agent does not disrupt network traffic. Stopping the agent"},{"line_number":18,"context_line":"  means also stopping the OVS bridge controller, hence OVS can decide to"},{"line_number":19,"context_line":"  take over management of OpenFlow rules, clearing them up, and this way"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_870b7dd5","line":16,"range":{"start_line":16,"start_character":18,"end_line":16,"end_character":35},"updated":"2016-08-01 13:24:34.000000000","message":"Opinion: I think \u0027native\u0027 describes it better.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8758a035a05da3f0ff0d8ee949359d3c8604ee0c","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Co-Authored-By: Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":15,"context_line":"Closes-Bug: 1607787"},{"line_number":16,"context_line":"Change-Id: I1dffe0a248664d2a675fd1ca58530c233e335d2d"},{"line_number":17,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_891cf06b","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":13},"updated":"2016-08-12 11:35:51.000000000","message":"What\u0027s the impact?","commit_id":"9429c2da01fa29cedcb2a65a26c1c29d0a713670"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"c760ddd155c5bbc4144da625cb9813ca69c9f636","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Co-Authored-By: Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":15,"context_line":"Closes-Bug: 1607787"},{"line_number":16,"context_line":"Change-Id: I1dffe0a248664d2a675fd1ca58530c233e335d2d"},{"line_number":17,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_bfe002ce","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":13},"in_reply_to":"9ad45d7e_29ab44d8","updated":"2016-08-12 12:20:42.000000000","message":"Is it gonna open a launchpad bug once this merges?","commit_id":"9429c2da01fa29cedcb2a65a26c1c29d0a713670"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f195a05c2401184ccccdbe3afa3c8238166f2f49","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Co-Authored-By: Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":15,"context_line":"Closes-Bug: 1607787"},{"line_number":16,"context_line":"Change-Id: I1dffe0a248664d2a675fd1ca58530c233e335d2d"},{"line_number":17,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_29ab44d8","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":13},"in_reply_to":"9ad45d7e_891cf06b","updated":"2016-08-12 11:37:45.000000000","message":"Yeah, actually, there is probably no \u0027impact\u0027, it\u0027s just a bug that can be triggered during upgrade, but there is nothing to inform users about.","commit_id":"9429c2da01fa29cedcb2a65a26c1c29d0a713670"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"105056d2051cd7222f796ce5c38eeaf3e120b644","unresolved":false,"context_lines":[{"line_number":14,"context_line":"Co-Authored-By: Jakub Libosvar \u003clibosvar@redhat.com\u003e"},{"line_number":15,"context_line":"Closes-Bug: 1607787"},{"line_number":16,"context_line":"Change-Id: I1dffe0a248664d2a675fd1ca58530c233e335d2d"},{"line_number":17,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"9ad45d7e_1f0b0e7f","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":13},"in_reply_to":"9ad45d7e_bfe002ce","updated":"2016-08-12 12:22:44.000000000","message":"As per https://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references no, but yeah, let\u0027s remove it.","commit_id":"9429c2da01fa29cedcb2a65a26c1c29d0a713670"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"effee4ad671953428bbae454db634c16f695554e","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1105,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1106,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1107,"context_line":"            br.create(secure_mode\u003dTrue)"},{"line_number":1108,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1109,"context_line":"            if cfg.CONF.AGENT.drop_flows_on_start:"},{"line_number":1110,"context_line":"                br.delete_flows()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_48c84955","line":1107,"updated":"2016-08-02 09:11:18.000000000","message":"i think that this has upgrade impact as it changes the behaviour of the switch. you should add a UpgradeImpact flag to the commit message and maybe a release note here.","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1cc03c0e962ea81a00ae507348c9ec7a5e3e11a","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1105,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1106,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1107,"context_line":"            br.create(secure_mode\u003dTrue)"},{"line_number":1108,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1109,"context_line":"            if cfg.CONF.AGENT.drop_flows_on_start:"},{"line_number":1110,"context_line":"                br.delete_flows()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_63b3ae98","line":1107,"in_reply_to":"bacf61ea_48c84955","updated":"2016-08-02 11:22:59.000000000","message":"Can you add an example?\n\nThe upgrade is a good point, maybe we shouldn\u0027t pass secure_mode\u003dTrue but call br.set_secure_mode() instead, to make sure existing phys bridges are fixed.","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"cafb641a4aee7bdbae7c44bd33b505e5eac063e5","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1105,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1106,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1107,"context_line":"            br.create(secure_mode\u003dTrue)"},{"line_number":1108,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1109,"context_line":"            if cfg.CONF.AGENT.drop_flows_on_start:"},{"line_number":1110,"context_line":"                br.delete_flows()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_f0d9e284","line":1107,"in_reply_to":"bacf61ea_48c84955","updated":"2016-08-03 09:17:03.000000000","message":"Done","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"cafb641a4aee7bdbae7c44bd33b505e5eac063e5","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1105,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1106,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1107,"context_line":"            br.create(secure_mode\u003dTrue)"},{"line_number":1108,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1109,"context_line":"            if cfg.CONF.AGENT.drop_flows_on_start:"},{"line_number":1110,"context_line":"                br.delete_flows()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_d0c93eae","line":1107,"in_reply_to":"bacf61ea_63b3ae98","updated":"2016-08-03 09:17:03.000000000","message":"Done","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"8881365485a5746189c50cad50630e1883c8f4b5","unresolved":false,"context_lines":[{"line_number":1104,"context_line":"            br \u003d self.br_phys_cls(bridge)"},{"line_number":1105,"context_line":"            # The bridge already exists, so create won\u0027t recreate it, but will"},{"line_number":1106,"context_line":"            # handle things like changing the datapath_type"},{"line_number":1107,"context_line":"            br.create(secure_mode\u003dTrue)"},{"line_number":1108,"context_line":"            br.setup_controllers(self.conf)"},{"line_number":1109,"context_line":"            if cfg.CONF.AGENT.drop_flows_on_start:"},{"line_number":1110,"context_line":"                br.delete_flows()"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_5fce08b5","line":1107,"in_reply_to":"bacf61ea_63b3ae98","updated":"2016-08-03 05:44:10.000000000","message":"Jakub,\n\n looking at OVSBridge.create, create() updates secure mode.  So this should be fine.","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"}],"neutron/tests/common/net_helpers.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"8881365485a5746189c50cad50630e1883c8f4b5","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"@contextlib.contextmanager"},{"line_number":120,"context_line":"def async_ping(namespace, ips, timeout\u003d1, count\u003d1):"},{"line_number":121,"context_line":"    with futures.ThreadPoolExecutor(max_workers\u003dlen(ips)) as executor:"},{"line_number":122,"context_line":"        fs \u003d [executor.submit(assert_ping, namespace, ip, count\u003dcount,"},{"line_number":123,"context_line":"                              timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_84f5d7cc","line":120,"range":{"start_line":120,"start_character":48,"end_line":120,"end_character":49},"updated":"2016-08-03 05:44:10.000000000","message":"this must be 10 to preserve the current API.","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"cafb641a4aee7bdbae7c44bd33b505e5eac063e5","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"@contextlib.contextmanager"},{"line_number":120,"context_line":"def async_ping(namespace, ips, timeout\u003d1, count\u003d1):"},{"line_number":121,"context_line":"    with futures.ThreadPoolExecutor(max_workers\u003dlen(ips)) as executor:"},{"line_number":122,"context_line":"        fs \u003d [executor.submit(assert_ping, namespace, ip, count\u003dcount,"},{"line_number":123,"context_line":"                              timeout\u003dtimeout)"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_90818650","line":120,"range":{"start_line":120,"start_character":48,"end_line":120,"end_character":49},"in_reply_to":"bacf61ea_84f5d7cc","updated":"2016-08-03 09:17:03.000000000","message":"Done","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"}],"neutron/tests/fullstack/resources/environment.py":[{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"8881365485a5746189c50cad50630e1883c8f4b5","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    def l2_agent(self):"},{"line_number":266,"context_line":"        if self.host_desc.l2_agent_type \u003d\u003d constants.AGENT_TYPE_LINUXBRIDGE:"},{"line_number":267,"context_line":"            return self.linuxbridge_agent"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            return self.ovs_agent"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_44b47fd0","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":13},"updated":"2016-08-03 05:44:10.000000000","message":"\"elif self.host_desc.l2_agent_type \u003d\u003d constants.AGENT_TYPE_OVS:\" would be better. (see _setUp()).","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"cafb641a4aee7bdbae7c44bd33b505e5eac063e5","unresolved":false,"context_lines":[{"line_number":265,"context_line":"    def l2_agent(self):"},{"line_number":266,"context_line":"        if self.host_desc.l2_agent_type \u003d\u003d constants.AGENT_TYPE_LINUXBRIDGE:"},{"line_number":267,"context_line":"            return self.linuxbridge_agent"},{"line_number":268,"context_line":"        else:"},{"line_number":269,"context_line":"            return self.ovs_agent"},{"line_number":270,"context_line":""},{"line_number":271,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_10963694","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":13},"in_reply_to":"bacf61ea_44b47fd0","updated":"2016-08-03 09:17:03.000000000","message":"Done","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"}],"neutron/tests/fullstack/resources/process.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cc9f07a82e89336f4cfb4627378894ee931a304","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            return"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.process.stop(block\u003dTrue, kill_signal\u003dself.kill_signal)"},{"line_number":80,"context_line":"        self.ignore_double_stop \u003d ignore_subsequent_stop"},{"line_number":81,"context_line":"        LOG.debug(\"Process stopped: %s\", self.process_name)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def restart(self, executor\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e6708274","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":56},"updated":"2016-08-01 11:51:48.000000000","message":"This looks like a side effect for me.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d73c474d8fe3171de86c82e7c40892c477c691ad","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            return"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.process.stop(block\u003dTrue, kill_signal\u003dself.kill_signal)"},{"line_number":80,"context_line":"        self.ignore_double_stop \u003d ignore_subsequent_stop"},{"line_number":81,"context_line":"        LOG.debug(\"Process stopped: %s\", self.process_name)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def restart(self, executor\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e77b5979","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":56},"in_reply_to":"bacf61ea_09fde9b3","updated":"2016-08-01 13:22:48.000000000","message":"I think it makes sense to have this interface ignore_double_stop in the class to avoid failures. I just don\u0027t think we should set it here in stop() method with every call. It makes more sense to me to set the flag explicitly from the test instead of passing it as an argument.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"2ef0b78d40259515af6c5770529bbab7aa21ba46","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            return"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        self.process.stop(block\u003dTrue, kill_signal\u003dself.kill_signal)"},{"line_number":80,"context_line":"        self.ignore_double_stop \u003d ignore_subsequent_stop"},{"line_number":81,"context_line":"        LOG.debug(\"Process stopped: %s\", self.process_name)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def restart(self, executor\u003dNone):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_09fde9b3","line":80,"range":{"start_line":80,"start_character":8,"end_line":80,"end_character":56},"in_reply_to":"bacf61ea_e6708274","updated":"2016-08-01 13:14:07.000000000","message":"Actually it is not - when the test stops, it attempts to cleanup processes (cf. line 50). If this stop upon exit fails, the whole test is marked as failed. This flag prevents test failure upon test cleanup.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cc9f07a82e89336f4cfb4627378894ee931a304","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if executor is None:"},{"line_number":91,"context_line":"            _restart()"},{"line_number":92,"context_line":"            return None"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            return executor.submit(_restart)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_26673ab8","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":23},"updated":"2016-08-01 11:51:48.000000000","message":"Nit: None is implicit. Also this line seems not needed.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"2ef0b78d40259515af6c5770529bbab7aa21ba46","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        if executor is None:"},{"line_number":91,"context_line":"            _restart()"},{"line_number":92,"context_line":"            return None"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            return executor.submit(_restart)"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0924c95b","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":23},"in_reply_to":"bacf61ea_26673ab8","updated":"2016-08-01 13:14:07.000000000","message":"Done","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cc9f07a82e89336f4cfb4627378894ee931a304","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            config_filenames\u003dconfig_filenames,"},{"line_number":203,"context_line":"            kill_signal\u003dsignal.SIGTERM))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def restart(self, executor\u003dNone):"},{"line_number":206,"context_line":"        return self.process_fixture.restart(executor\u003dexecutor)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def start(self):"},{"line_number":209,"context_line":"        return self.process_fixture.start()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def stop(self, ignore_subsequent_stop\u003dFalse):"},{"line_number":212,"context_line":"        return self.process_fixture.stop("},{"line_number":213,"context_line":"                ignore_subsequent_stop\u003dignore_subsequent_stop)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class LinuxBridgeAgentFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_66c01251","line":213,"range":{"start_line":205,"start_character":0,"end_line":213,"end_character":62},"updated":"2016-08-01 11:51:48.000000000","message":"All those three methods appear in all agents services. It would make sense to create a super-class for that - for inspiration: https://review.openstack.org/#/c/312401/8/neutron/tests/fullstack/resources/process.py@109","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"2ef0b78d40259515af6c5770529bbab7aa21ba46","unresolved":false,"context_lines":[{"line_number":202,"context_line":"            config_filenames\u003dconfig_filenames,"},{"line_number":203,"context_line":"            kill_signal\u003dsignal.SIGTERM))"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"    def restart(self, executor\u003dNone):"},{"line_number":206,"context_line":"        return self.process_fixture.restart(executor\u003dexecutor)"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def start(self):"},{"line_number":209,"context_line":"        return self.process_fixture.start()"},{"line_number":210,"context_line":""},{"line_number":211,"context_line":"    def stop(self, ignore_subsequent_stop\u003dFalse):"},{"line_number":212,"context_line":"        return self.process_fixture.stop("},{"line_number":213,"context_line":"                ignore_subsequent_stop\u003dignore_subsequent_stop)"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"class LinuxBridgeAgentFixture(fixtures.Fixture):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c9af517b","line":213,"range":{"start_line":205,"start_character":0,"end_line":213,"end_character":62},"in_reply_to":"bacf61ea_66c01251","updated":"2016-08-01 13:14:07.000000000","message":"Absolutely. The parent class was named the same to ease future merging.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"8af7cb79d7d837cd9a9380edfd654605660d6271","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            cmd, run_as_root\u003drun_as_root, namespace\u003dself.namespace"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":"        self.process.start(block\u003dTrue)"},{"line_number":70,"context_line":"        LOG.debug(\"Process started: %s\", self.process_name)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def stop(self, kill_signal\u003dNone):"},{"line_number":73,"context_line":"        if self.ignore_double_stop and not self.process.is_active():"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_e7f7638a","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":59},"updated":"2016-08-03 11:50:45.000000000","message":"All these debug messages that are added in this file seem like unrelated changes...","commit_id":"43bd57446236f4feed063730f72ee46d1a3cda9f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"90b638cadde68ce7e6b2336917c1632e7344f41d","unresolved":false,"context_lines":[{"line_number":67,"context_line":"            cmd, run_as_root\u003drun_as_root, namespace\u003dself.namespace"},{"line_number":68,"context_line":"        )"},{"line_number":69,"context_line":"        self.process.start(block\u003dTrue)"},{"line_number":70,"context_line":"        LOG.debug(\"Process started: %s\", self.process_name)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def stop(self, kill_signal\u003dNone):"},{"line_number":73,"context_line":"        if self.ignore_double_stop and not self.process.is_active():"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_d02e5441","line":70,"range":{"start_line":70,"start_character":8,"end_line":70,"end_character":59},"in_reply_to":"bacf61ea_e7f7638a","updated":"2016-08-03 12:24:31.000000000","message":"They are related - we\u0027re now restarting services as part of the test, so we need to know when what started etc.","commit_id":"43bd57446236f4feed063730f72ee46d1a3cda9f"}],"neutron/tests/fullstack/test_connectivity.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cc9f07a82e89336f4cfb4627378894ee931a304","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self.assert_all_vms_can_be_mutually_pinged(vms)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return vms"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"OVS_INTERFACE_SCENARIOS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_661812d4","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":18},"updated":"2016-08-01 11:51:48.000000000","message":"Pedantic nit: Semantically it\u0027s weird that test_connectivity returns list of vms. Maybe we should introduce a better granularity of actions, like create_network_with_subnet(), create_vms(network_id, number_of_vms), test_connectivity(list_of_vms)","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"2ef0b78d40259515af6c5770529bbab7aa21ba46","unresolved":false,"context_lines":[{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        self.assert_all_vms_can_be_mutually_pinged(vms)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return vms"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"OVS_INTERFACE_SCENARIOS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_55c48e3e","line":95,"range":{"start_line":95,"start_character":8,"end_line":95,"end_character":18},"in_reply_to":"bacf61ea_661812d4","updated":"2016-08-01 13:14:07.000000000","message":"Done","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cc9f07a82e89336f4cfb4627378894ee931a304","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        return vms"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"OVS_INTERFACE_SCENARIOS \u003d ["},{"line_number":99,"context_line":"    (\u0027openflow-cli_ovsdb-cli\u0027, {\u0027of_interface\u0027: \u0027ovs-ofctl\u0027,"},{"line_number":100,"context_line":"                                \u0027ovsdb_interface\u0027: \u0027vsctl\u0027}),"},{"line_number":101,"context_line":"    (\u0027openflow-native_ovsdb-cli\u0027, {\u0027of_interface\u0027: \u0027native\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_a6b20ae3","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":23},"updated":"2016-08-01 11:51:48.000000000","message":"Nit: Let\u0027s move this to the top of this file to the rest of constants.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"2ef0b78d40259515af6c5770529bbab7aa21ba46","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        return vms"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"OVS_INTERFACE_SCENARIOS \u003d ["},{"line_number":99,"context_line":"    (\u0027openflow-cli_ovsdb-cli\u0027, {\u0027of_interface\u0027: \u0027ovs-ofctl\u0027,"},{"line_number":100,"context_line":"                                \u0027ovsdb_interface\u0027: \u0027vsctl\u0027}),"},{"line_number":101,"context_line":"    (\u0027openflow-native_ovsdb-cli\u0027, {\u0027of_interface\u0027: \u0027native\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e93df52b","line":98,"range":{"start_line":98,"start_character":0,"end_line":98,"end_character":23},"in_reply_to":"bacf61ea_a6b20ae3","updated":"2016-08-01 13:14:07.000000000","message":"Done","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6cc9f07a82e89336f4cfb4627378894ee931a304","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        LOG.debug(\"Stopping agents (hence also OVS bridge controllers)\")"},{"line_number":155,"context_line":"        for agent in agents:"},{"line_number":156,"context_line":"            agent.stop(ignore_subsequent_stop\u003dTrue)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Ping to make sure that 3 x 5 seconds is overcame even under a high"},{"line_number":159,"context_line":"        # load. The time was chosen to match three times inactivity_probe time,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_669bf218","line":156,"range":{"start_line":156,"start_character":18,"end_line":156,"end_character":22},"updated":"2016-08-01 11:51:48.000000000","message":"How about that approach that blocked traffic between ryu app and ovs? There could be cleanups when shutting down agent - so we still don\u0027t simulate the scenario where for any reason connectivity is broken between ovs and ryu.","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"2ef0b78d40259515af6c5770529bbab7aa21ba46","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        LOG.debug(\"Stopping agents (hence also OVS bridge controllers)\")"},{"line_number":155,"context_line":"        for agent in agents:"},{"line_number":156,"context_line":"            agent.stop(ignore_subsequent_stop\u003dTrue)"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"        # Ping to make sure that 3 x 5 seconds is overcame even under a high"},{"line_number":159,"context_line":"        # load. The time was chosen to match three times inactivity_probe time,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f45ca84c","line":156,"range":{"start_line":156,"start_character":18,"end_line":156,"end_character":22},"in_reply_to":"bacf61ea_669bf218","updated":"2016-08-01 13:14:07.000000000","message":"There will be two more cases added to this one, one killing the neutron agent via SIGKILL, and one using iptables (simulating inaccessibility due to high load).","commit_id":"2a2195393f436ba615df8e1648ded712fa6403a5"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1cc03c0e962ea81a00ae507348c9ec7a5e3e11a","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        network \u003d self.safe_client.create_network(tenant_uuid, **net_args)"},{"line_number":91,"context_line":"        self.safe_client.create_subnet("},{"line_number":92,"context_line":"                tenant_uuid, network[\u0027id\u0027], \u002720.0.0.0/24\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        return network"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_9700a003","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":16},"updated":"2016-08-02 11:22:59.000000000","message":"Nit: Previous indent was correct","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"cafb641a4aee7bdbae7c44bd33b505e5eac063e5","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":"        network \u003d self.safe_client.create_network(tenant_uuid, **net_args)"},{"line_number":91,"context_line":"        self.safe_client.create_subnet("},{"line_number":92,"context_line":"                tenant_uuid, network[\u0027id\u0027], \u002720.0.0.0/24\u0027)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        return network"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_9036a6b2","line":92,"range":{"start_line":92,"start_character":12,"end_line":92,"end_character":16},"in_reply_to":"bacf61ea_9700a003","updated":"2016-08-03 09:17:03.000000000","message":"Done","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"a1cc03c0e962ea81a00ae507348c9ec7a5e3e11a","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            mgr.apply()"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"            mgr.ipv4[\u0027filter\u0027].remove_rule(\u0027INPUT\u0027, ipv4_rule)"},{"line_number":210,"context_line":"            self.addCleanup(mgr.apply)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self._test_controller_timeout_does_not_break_connectivity("},{"line_number":213,"context_line":"            stop_method\u003dstop_method"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_04af557d","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":38},"updated":"2016-08-02 11:22:59.000000000","message":"I think we should add a callback, that also calls the \"remove_rule()\". Otherwise it can cause unexpected behavior.","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":19797,"name":"Hynek Mlnarik","email":"hmlnarik@redhat.com","username":"hmlnarik"},"change_message_id":"cafb641a4aee7bdbae7c44bd33b505e5eac063e5","unresolved":false,"context_lines":[{"line_number":207,"context_line":"            mgr.apply()"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"            mgr.ipv4[\u0027filter\u0027].remove_rule(\u0027INPUT\u0027, ipv4_rule)"},{"line_number":210,"context_line":"            self.addCleanup(mgr.apply)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self._test_controller_timeout_does_not_break_connectivity("},{"line_number":213,"context_line":"            stop_method\u003dstop_method"}],"source_content_type":"text/x-python","patch_set":4,"id":"bacf61ea_b0e12a01","line":210,"range":{"start_line":210,"start_character":12,"end_line":210,"end_character":38},"in_reply_to":"bacf61ea_04af557d","updated":"2016-08-03 09:17:03.000000000","message":"This test will be removed and will be placed back once the ovs-neutron-agent would be started in host namespace, as currently there are issues with iptables_manager conflicting updates in the main network namespace from parallel running tests.","commit_id":"105dfc6d73e797191b17455702757ad1439f0a7e"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"8af7cb79d7d837cd9a9380edfd654605660d6271","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_477d8fe6","line":1,"updated":"2016-08-03 11:50:45.000000000","message":"When a file contains 5 different test-related classes, it must be time to split it into a test library with multiple files instead :)","commit_id":"43bd57446236f4feed063730f72ee46d1a3cda9f"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"90b638cadde68ce7e6b2336917c1632e7344f41d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2015 Red Hat, Inc."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":5,"id":"bacf61ea_70a3289f","line":1,"in_reply_to":"bacf61ea_477d8fe6","updated":"2016-08-03 12:24:31.000000000","message":"Why? This is not Java :-P I think added tests aim on testing basic connectivity. But maybe you\u0027re right that those tests can be added to a file dedicated to ovs agent. But I don\u0027t insist.","commit_id":"43bd57446236f4feed063730f72ee46d1a3cda9f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9184a1555cd4720fc5720fea9509a9116de56b33","unresolved":false,"context_lines":[{"line_number":140,"context_line":"    num_hosts \u003d 2"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    l2_agent_type \u003d constants.AGENT_TYPE_OVS"},{"line_number":143,"context_line":"    network_scenarios \u003d ["},{"line_number":144,"context_line":"        (\u0027VXLAN\u0027, {\u0027network_type\u0027: \u0027vxlan\u0027,"},{"line_number":145,"context_line":"                   \u0027l2_pop\u0027: False}),"},{"line_number":146,"context_line":"        (\u0027GRE and l2pop\u0027, {\u0027network_type\u0027: \u0027gre\u0027,"},{"line_number":147,"context_line":"                           \u0027l2_pop\u0027: True}),"},{"line_number":148,"context_line":"        (\u0027VLANs\u0027, {\u0027network_type\u0027: \u0027vlan\u0027,"},{"line_number":149,"context_line":"                   \u0027l2_pop\u0027: False})]"},{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    # Do not test for CLI ofctl interface as controller is irrelevant for CLI"},{"line_number":152,"context_line":"    scenarios \u003d testscenarios.multiply_scenarios("}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e644bb1c","line":149,"range":{"start_line":143,"start_character":4,"end_line":149,"end_character":37},"updated":"2016-08-12 11:28:39.000000000","message":"Seems like the dict is the same as in lines 123-129. Probably we could define it just one to make sure we always fully cover all listed permutations with all connectivity tests.","commit_id":"43bd57446236f4feed063730f72ee46d1a3cda9f"}]}
