)]}'
{"neutron/db/flavors_db.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4d34a070ee61c5443f3a08562df5bf2c53df249b","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":"from neutron.db import common_db_mixin"},{"line_number":23,"context_line":"from neutron.db.models import flavors as flv_models"},{"line_number":24,"context_line":"from neutron.db import servicetype_db as sdb"},{"line_number":25,"context_line":"from neutron.extensions import flavors as ext_flavors"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5cbf88cf","line":23,"range":{"start_line":23,"start_character":41,"end_line":23,"end_character":51},"updated":"2016-08-05 22:56:08.000000000","message":"flavor_models would be more meaningful than flv_models.\nshortcut for obvious things like net for network can be used.\nchange this if you get to respin","commit_id":"8286d77e5b0281687e32aacd9c2294d57c3fe516"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8fe3d15896265a68584e6eb37ad3469e02a4480f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron.common import _deprecate"},{"line_number":22,"context_line":"from neutron.db import common_db_mixin"},{"line_number":23,"context_line":"from neutron.db.models import flavors as flv_models"},{"line_number":24,"context_line":"from neutron.db import servicetype_db as sdb"},{"line_number":25,"context_line":"from neutron.extensions import flavors as ext_flavors"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_e7ae3097","line":23,"range":{"start_line":23,"start_character":41,"end_line":23,"end_character":51},"in_reply_to":"bacf61ea_5cbf88cf","updated":"2016-08-09 14:46:50.000000000","message":"+1","commit_id":"8286d77e5b0281687e32aacd9c2294d57c3fe516"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4d34a070ee61c5443f3a08562df5bf2c53df249b","unresolved":false,"context_lines":[{"line_number":263,"context_line":"               \u0027provider\u0027: providers[0].get(\u0027name\u0027)}"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        return [self._fields(res, fields)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":268,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":269,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), flv_models)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_dc925856","line":266,"updated":"2016-08-05 22:56:08.000000000","message":"2 line spaces before a global","commit_id":"8286d77e5b0281687e32aacd9c2294d57c3fe516"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"8fe3d15896265a68584e6eb37ad3469e02a4480f","unresolved":false,"context_lines":[{"line_number":263,"context_line":"               \u0027provider\u0027: providers[0].get(\u0027name\u0027)}"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"        return [self._fields(res, fields)]"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":268,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":269,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), flv_models)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_67a9a07b","line":266,"in_reply_to":"bacf61ea_dc925856","updated":"2016-08-09 14:46:50.000000000","message":"+1","commit_id":"8286d77e5b0281687e32aacd9c2294d57c3fe516"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3f0c28f7d860adb6081841f14ee85a4457bbb1c","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def create_flavor(self, context, flavor):"},{"line_number":95,"context_line":"        fl \u003d flavor[\u0027flavor\u0027]"},{"line_number":96,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":97,"context_line":"            fl_db \u003d flavor_models.Flavor(id\u003duuidutils.generate_uuid(),"},{"line_number":98,"context_line":"                                      name\u003dfl[\u0027name\u0027],"},{"line_number":99,"context_line":"                                      description\u003dfl[\u0027description\u0027],"},{"line_number":100,"context_line":"                                      service_type\u003dfl[\u0027service_type\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_39d33c3a","line":97,"updated":"2016-08-26 12:56:34.000000000","message":"indentation broken","commit_id":"79d553e194ae8638d042d92c63834cd05417762e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3f0c28f7d860adb6081841f14ee85a4457bbb1c","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                      service_profile_id, flavor_id):"},{"line_number":152,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":153,"context_line":"            binding \u003d (context.session.query("},{"line_number":154,"context_line":"                       flavor_models.FlavorServiceProfileBinding)."},{"line_number":155,"context_line":"                       filter_by(service_profile_id\u003dservice_profile_id,"},{"line_number":156,"context_line":"                       flavor_id\u003dflavor_id).first())"},{"line_number":157,"context_line":"            if not binding:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_59bf20d0","line":154,"updated":"2016-08-26 12:56:34.000000000","message":"should be indented","commit_id":"79d553e194ae8638d042d92c63834cd05417762e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3f0c28f7d860adb6081841f14ee85a4457bbb1c","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                   service_profile_id, flavor_id, fields\u003dNone):"},{"line_number":164,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":165,"context_line":"            binding \u003d (context.session.query("},{"line_number":166,"context_line":"                       flavor_models.FlavorServiceProfileBinding)."},{"line_number":167,"context_line":"                       filter_by(service_profile_id\u003dservice_profile_id,"},{"line_number":168,"context_line":"                       flavor_id\u003dflavor_id).first())"},{"line_number":169,"context_line":"            if not binding:"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_b9ce6c81","line":166,"updated":"2016-08-26 12:56:34.000000000","message":"to indent","commit_id":"79d553e194ae8638d042d92c63834cd05417762e"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e3f0c28f7d860adb6081841f14ee85a4457bbb1c","unresolved":false,"context_lines":[{"line_number":183,"context_line":"                raise ext_flavors.ServiceProfileEmpty()"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":186,"context_line":"            sp_db \u003d flavor_models.ServiceProfile(id\u003duuidutils.generate_uuid(),"},{"line_number":187,"context_line":"                                              description\u003dsp[\u0027description\u0027],"},{"line_number":188,"context_line":"                                              driver\u003dsp[\u0027driver\u0027],"},{"line_number":189,"context_line":"                                              enabled\u003dsp[\u0027enabled\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa7ab95a_79ab048a","line":186,"updated":"2016-08-26 12:56:34.000000000","message":"broken indentation","commit_id":"79d553e194ae8638d042d92c63834cd05417762e"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"231cb06a8de5775d92c0f242a37b8e04b2786264","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class Flavor(model_base.BASEV2, model_base.HasId):"},{"line_number":31,"context_line":"    name \u003d sa.Column(sa.String(attr.NAME_MAX_LEN))"},{"line_number":32,"context_line":"    description \u003d sa.Column(sa.String(attr.LONG_DESCRIPTION_MAX_LEN))"},{"line_number":33,"context_line":"    enabled \u003d sa.Column(sa.Boolean, nullable\u003dFalse, default\u003dTrue,"},{"line_number":34,"context_line":"                        server_default\u003dsa.sql.true())"},{"line_number":35,"context_line":"    # Make it True for multi-type flavors"},{"line_number":36,"context_line":"    service_type \u003d sa.Column(sa.String(36), nullable\u003dTrue)"},{"line_number":37,"context_line":"    service_profiles \u003d orm.relationship(\"FlavorServiceProfileBinding\","},{"line_number":38,"context_line":"        cascade\u003d\"all, delete-orphan\")"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"class ServiceProfile(model_base.BASEV2, model_base.HasId):"},{"line_number":42,"context_line":"    description \u003d sa.Column(sa.String(attr.LONG_DESCRIPTION_MAX_LEN))"},{"line_number":43,"context_line":"    driver \u003d sa.Column(sa.String(1024), nullable\u003dFalse)"},{"line_number":44,"context_line":"    enabled \u003d sa.Column(sa.Boolean, nullable\u003dFalse, default\u003dTrue,"},{"line_number":45,"context_line":"                        server_default\u003dsa.sql.true())"},{"line_number":46,"context_line":"    metainfo \u003d sa.Column(sa.String(4096))"},{"line_number":47,"context_line":"    flavors \u003d orm.relationship(\"FlavorServiceProfileBinding\")"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"class FlavorServiceProfileBinding(model_base.BASEV2):"},{"line_number":51,"context_line":"    flavor_id \u003d sa.Column(sa.String(36),"},{"line_number":52,"context_line":"                          sa.ForeignKey(\"flavors.id\","},{"line_number":53,"context_line":"                                        ondelete\u003d\"CASCADE\"),"},{"line_number":54,"context_line":"                          nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":55,"context_line":"    flavor \u003d orm.relationship(Flavor)"},{"line_number":56,"context_line":"    service_profile_id \u003d sa.Column(sa.String(36),"},{"line_number":57,"context_line":"                                   sa.ForeignKey(\"serviceprofiles.id\","},{"line_number":58,"context_line":"                                                 ondelete\u003d\"CASCADE\"),"},{"line_number":59,"context_line":"                                   nullable\u003dFalse, primary_key\u003dTrue)"},{"line_number":60,"context_line":"    service_profile \u003d orm.relationship(ServiceProfile)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"class FlavorsDbMixin(common_db_mixin.CommonDbMixin):"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_ad39cd43","side":"PARENT","line":60,"range":{"start_line":29,"start_character":0,"end_line":60,"end_character":54},"updated":"2016-08-31 12:49:55.000000000","message":"This conflicts with https://review.openstack.org/306685 but I guess you know that.","commit_id":"017230bcef8c5fea159f2af6e8f80b273334c824"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"231cb06a8de5775d92c0f242a37b8e04b2786264","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":274,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":275,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), flavor_models)"},{"line_number":276,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_ed3bd536","line":275,"updated":"2016-08-31 12:49:55.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"8d9675ca6f9ad7ef3e581147e63f62aa5a8dbbfc"}],"neutron/db/models/flavor.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"5ac82961600f312deec947c083347cd5ce0a02d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_71439813","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2016-08-18 05:49:52.000000000","message":"This line is unnecessary.","commit_id":"24065bb2c974efdd86a44c4c0e3ab55f78a896e6"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d9fa28d224acc30c45f4f9532598ea554dcc41df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# All Rights Reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_9b3d78c6","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":22},"updated":"2016-08-18 13:05:43.000000000","message":";)","commit_id":"7f51ed7e7c216791812dee2918a4e55b3e50272a"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"6e4489d940f112bdf609e82d1df1703226f9e99a","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from sqlalchemy import orm"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.api.v2 import attributes as attr"},{"line_number":18,"context_line":"from neutron.db import model_base"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a8bc5a2_6a9a4716","line":18,"range":{"start_line":18,"start_character":23,"end_line":18,"end_character":33},"updated":"2016-09-22 15:28:33.000000000","message":"that should be neutron-lib one","commit_id":"528b55b0ea9c874779ef912ce3afcbe6a3cdbe1a"}],"neutron/db/models/tag.py":[{"author":{"_account_id":6951,"name":"Brandon Logan","email":"brandon.logan@rackspace.com","username":"brandon-logan"},"change_message_id":"27acca41c929d8dbd929c451ca11521c306d6a2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3a98d1f4_fecb3d51","updated":"2016-09-29 20:26:22.000000000","message":"looks like you\u0027ve got a rebase issue :) welcome to the chaos that is review dependency chains.","commit_id":"31dd335dce38b17e1bd3b47cc5f9a3f57e64363a"}]}
