)]}'
{"neutron/services/trunk/drivers/base.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3bea936b7578180637c31d4999ba8b7b88f9ab07","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        registry.subscribe(self.register,"},{"line_number":44,"context_line":"                           trunk_consts.TRUNK_PLUGIN,"},{"line_number":45,"context_line":"                           events.AFTER_INIT)"},{"line_number":46,"context_line":"        # Set up the server-side RPC backend if the driver is loaded"},{"line_number":47,"context_line":"        # and it is agent based."},{"line_number":48,"context_line":"        if self.is_loaded and self.agent_type:"},{"line_number":49,"context_line":"            registry.subscribe(backend.setup_rpc,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_11f7e78b","line":46,"updated":"2016-07-31 16:04:05.000000000","message":"why did you move it here? I must be missing something.","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"}],"neutron/services/trunk/drivers/linuxbridge/driver.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3bea936b7578180637c31d4999ba8b7b88f9ab07","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        return NAME in cfg.CONF.ml2.mechanism_drivers"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def register(self, *args, **kwargs):"},{"line_number":44,"context_line":"        registry.subscribe(rpc_server.trunk_created, trunk_consts.TRUNK,"},{"line_number":45,"context_line":"                           events.AFTER_CREATE)"},{"line_number":46,"context_line":"        registry.subscribe(rpc_server.trunk_updated, trunk_consts.TRUNK,"},{"line_number":47,"context_line":"                           events.AFTER_UPDATE)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d1854fcf","line":44,"updated":"2016-07-31 16:04:05.000000000","message":"these are stub methods, they should not be turned into callback handlers, otherwise we\u0027re mixing two mechanisms together that are meant to be decoupled. The separation is beneficial in that one change to one technology is not meant to affect the other and vice-versa. Why didn\u0027t you use server.setup_rpc? Linuxbridge being an agent-based driver should be able to reuse the common rpc logic, there\u0027s some stuff still missing in 347662, I was going to add it in the right place, see comments over there.","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"9be9eb766ad799b4e2c06760d80cfbe44bfe1f0e","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"def register():"},{"line_number":58,"context_line":"    # NOTE(kevinbenton): the thing that is keeping this from being"},{"line_number":59,"context_line":"    # immediately garbage collected is that it registers callbacks"},{"line_number":60,"context_line":"    LinuxBridgeDriver(NAME, SUPPORTED_INTERFACES, SUPPORTED_SEGMENTATION_TYPES,"},{"line_number":61,"context_line":"                      constants.AGENT_TYPE_LINUXBRIDGE,"},{"line_number":62,"context_line":"                      can_trunk_bound_port\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b1641b22","line":59,"updated":"2016-07-31 16:20:29.000000000","message":"well, the reference to this object is held by the trunk plugin in self._drivers.","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"}],"neutron/services/trunk/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3bea936b7578180637c31d4999ba8b7b88f9ab07","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        registry.subscribe(rules.enforce_port_deletion_rules,"},{"line_number":72,"context_line":"                           resources.PORT, events.BEFORE_DELETE)"},{"line_number":73,"context_line":"        registry.notify(constants.TRUNK_PLUGIN, events.AFTER_INIT, self,"},{"line_number":74,"context_line":"                        exceptions_fatal\u003dTrue)"},{"line_number":75,"context_line":"        for driver in self._drivers:"},{"line_number":76,"context_line":"            LOG.debug(\u0027Trunk plugin loaded with driver %s\u0027, driver.name)"},{"line_number":77,"context_line":"        self.check_compatibility()"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_717583f8","line":74,"updated":"2016-07-31 16:04:05.000000000","message":"?","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"}],"neutron/services/trunk/rpc/agent.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3bea936b7578180637c31d4999ba8b7b88f9ab07","unresolved":false,"context_lines":[{"line_number":100,"context_line":"    def update_subport_bindings(self, context, subports):"},{"line_number":101,"context_line":"        \"\"\"Update subport bindings to match parent port host binding.\"\"\""},{"line_number":102,"context_line":"        (self.rpc_client.prepare()."},{"line_number":103,"context_line":"         call(context, \u0027update_subport_bindings\u0027, subports\u003dsubports))"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5172ff11","line":103,"updated":"2016-07-31 16:04:05.000000000","message":"is there anything that needs to be returned? If so do \u0027return call\u0027","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"}],"neutron/services/trunk/rpc/server.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3bea936b7578180637c31d4999ba8b7b88f9ab07","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    ports \u003d trunk_objects.Trunk.get_objects(context, port_id\u003dport_id)"},{"line_number":58,"context_line":"    if ports:"},{"line_number":59,"context_line":"        return ports[0]"},{"line_number":60,"context_line":"    trunk_port \u003d trunk_objects.Trunk.get_object(context, id\u003dport_id)"},{"line_number":61,"context_line":"    return trunk_port"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f157b357","line":60,"updated":"2016-07-31 16:04:05.000000000","message":"actually coming to think of it, line 60/61 should be removed altogether.","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3bea936b7578180637c31d4999ba8b7b88f9ab07","unresolved":false,"context_lines":[{"line_number":114,"context_line":"# to subscribe themselves to some or all of these"},{"line_number":115,"context_line":"# events."},{"line_number":116,"context_line":"# NOTE(kevinbenton): these are all constructing new"},{"line_number":117,"context_line":"# rpc connections each go. need to stash pushrpcapi"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"def trunk_created(resource, event, trigger, payload):"},{"line_number":120,"context_line":"    \"\"\"Tell the agent about a trunk being created.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d15c2f7f","line":117,"updated":"2016-07-31 16:04:05.000000000","message":"Keep these clean and cohesive to being stub methods only. Don\u0027t turn them into callback handlers.","commit_id":"6c4afbc085f64ecedaac2bcbfbc6d24809889b2b"}],"neutron/tests/unit/services/trunk/drivers/linuxbridge/test_driver.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3d758cfbfdf3a5bb74cdb3cf3ecf3bef4cc22485","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"class LinuxBridgeDriverTestCase(base.BaseTestCase):"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    def test_driver_is_loaded(self):"},{"line_number":23,"context_line":"        inst \u003d driver.LinuxBridgeDriver.create()"},{"line_number":24,"context_line":"        cfg.CONF.set_override(\u0027mechanism_drivers\u0027,"},{"line_number":25,"context_line":"                              [\u0027a\u0027, \u0027b\u0027, \u0027linuxbridge\u0027], group\u003d\u0027ml2\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_3e92cbf6","line":22,"updated":"2016-08-10 16:06:01.000000000","message":"I would have personally broken this down in two, but meh.","commit_id":"ce1c16f527973a077390e39a80bd8c19a3866dca"}]}
