)]}'
{"quantum/plugins/bigswitch/plugin.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"503be835fbce517ca41579aa48609beeaa6f4228","unresolved":false,"context_lines":[{"line_number":348,"context_line":"        server_ssl \u003d cfg.CONF.RESTPROXY.server_ssl"},{"line_number":349,"context_line":"        sync_data \u003d cfg.CONF.RESTPROXY.sync_data"},{"line_number":350,"context_line":"        quantum_id \u003d cfg.CONF.RESTPROXY.quantum_id"},{"line_number":351,"context_line":"        self.add_meta_server_route \u003d cfg.CONF.RESTPROXY.add_meta_server_route"},{"line_number":352,"context_line":"        timeout \u003d cfg.CONF.RESTPROXY.server_timeout"},{"line_number":353,"context_line":"        if server_timeout is not None:"},{"line_number":354,"context_line":"            timeout \u003d server_timeout"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgX0%3D","line":351,"updated":"2013-06-28 22:00:29.000000000","message":"you might as well put this assignment in the else branch, even though I think that allowing users to call the plugin directly is not a good idea.","commit_id":"33b93fd2318c51238f0c1c002c1a9247a6afb1d4"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"8f3f8bd13f14fb6f55f99c541312685738f4d57e","unresolved":false,"context_lines":[{"line_number":332,"context_line":"                         routerrule_db.RouterRule_db_mixin):"},{"line_number":333,"context_line":""},{"line_number":334,"context_line":"    supported_extension_aliases \u003d [\"router\", \"binding\", \"router_rules\"]"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"    def __init__(self, server_timeout\u003dNone):"},{"line_number":337,"context_line":"        LOG.info(_(\u0027QuantumRestProxy: Starting plugin. Version\u003d%s\u0027),"},{"line_number":338,"context_line":"                 version_string_with_vcs())"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2Ff%2B8%3D","line":335,"updated":"2013-06-29 05:43:07.000000000","message":"Seems better to do: \n\ndef __init__(sefl, timeout\u003dcfg.CONF.RESTPROXY.server_timeout):\n\nthen remove 353-354\n\nStill not clear why you can\u0027t just set cfg.CONF.RESTPROXY.server_timeout or have that default value be good enough.","commit_id":"bc4c382f115c50fae1e00a64ec12869a29e34460"}]}