)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":10,"context_line":"provide the host_id in port creation/updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic0d714a3977810c6b1144c1e25488f75cc95d0f0"},{"line_number":13,"context_line":"Fixes: bug #1195903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPn%2F%2Ff%2FQ%3D","line":13,"updated":"2013-06-29 05:37:39.000000000","message":"nit Should be above 12.","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e4dee176a05d1be479a9c36ddeac8ff3f7f20dea","unresolved":false,"context_lines":[{"line_number":10,"context_line":"provide the host_id in port creation/updates."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ic0d714a3977810c6b1144c1e25488f75cc95d0f0"},{"line_number":13,"context_line":"Fixes: bug #1195903"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAPn%2F%2Ff0Q%3D","line":13,"in_reply_to":"AAAAPn%2F%2Ff%2FQ%3D","updated":"2013-06-29 07:26:09.000000000","message":"Done","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"}],"quantum/plugins/bigswitch/db/porttracker_db.py":[{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"change_message_id":"0f578b7fee5fbe35cdcf62e74a1c5f95de3b5e59","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if host_id \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id attribute in request from nova.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgZE%3D","line":42,"updated":"2013-06-28 21:51:43.000000000","message":"This is probably more correct:\n\n\nif not attributes.is_attr_set(host_id)","commit_id":"71a3137e21e16d438d3395e92b01a1bfd9dfd9c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if host_id \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id attribute in request from nova.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgYw%3D","line":42,"updated":"2013-06-28 21:55:04.000000000","message":"the module attributes provides a method to check whether an attribute is set or not and it abstracts how the test is made, it\u0027s worth using it, in case the API layer were to change.","commit_id":"71a3137e21e16d438d3395e92b01a1bfd9dfd9c8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e4dee176a05d1be479a9c36ddeac8ff3f7f20dea","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if host_id \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id attribute in request from nova.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgUc%3D","line":42,"in_reply_to":"AAAAPn%2F%2FgYw%3D","updated":"2013-06-28 22:23:57.000000000","message":"Thanks, I wasn\u0027t aware of that.","commit_id":"71a3137e21e16d438d3395e92b01a1bfd9dfd9c8"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if host_id \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id attribute in request from nova.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"},{"line_number":46,"context_line":"        LOG.warning(_(\"Received an empty port ID for host \u0027%s\u0027\"), host_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgYo%3D","line":43,"updated":"2013-06-28 21:55:04.000000000","message":"small nit: the request may come from anywhere...really...not just nova","commit_id":"71a3137e21e16d438d3395e92b01a1bfd9dfd9c8"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e4dee176a05d1be479a9c36ddeac8ff3f7f20dea","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if host_id \u003d\u003d attributes.ATTR_NOT_SPECIFIED:"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id attribute in request from nova.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"},{"line_number":46,"context_line":"        LOG.warning(_(\"Received an empty port ID for host \u0027%s\u0027\"), host_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAPn%2F%2FgUY%3D","line":43,"in_reply_to":"AAAAPn%2F%2FgYo%3D","updated":"2013-06-28 22:23:57.000000000","message":"Done","commit_id":"71a3137e21e16d438d3395e92b01a1bfd9dfd9c8"},{"author":{"_account_id":2874,"name":"yong sheng gong","email":"gong.yongsheng@99cloud.net","username":"gongysh"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if not attributes.is_attr_set(host_id):"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id in port request to track port location.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"},{"line_number":46,"context_line":"        LOG.warning(_(\"Received an empty port ID for host \u0027%s\u0027\"), host_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2FgHY%3D","line":43,"updated":"2013-06-29 00:54:05.000000000","message":"why not warning?","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e4dee176a05d1be479a9c36ddeac8ff3f7f20dea","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if not attributes.is_attr_set(host_id):"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id in port request to track port location.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"},{"line_number":46,"context_line":"        LOG.warning(_(\"Received an empty port ID for host \u0027%s\u0027\"), host_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ff0g%3D","line":43,"in_reply_to":"AAAAPn%2F%2Ff%2FI%3D","updated":"2013-06-29 07:26:09.000000000","message":"Done","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def put_port_hostid(context, port_id, host_id):"},{"line_number":42,"context_line":"    if not attributes.is_attr_set(host_id):"},{"line_number":43,"context_line":"        LOG.debug(_(\"No host_id in port request to track port location.\"))"},{"line_number":44,"context_line":"        return"},{"line_number":45,"context_line":"    if port_id \u003d\u003d \u0027\u0027:"},{"line_number":46,"context_line":"        LOG.warning(_(\"Received an empty port ID for host \u0027%s\u0027\"), host_id)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ff%2FI%3D","line":43,"in_reply_to":"AAAAPn%2F%2FgHY%3D","updated":"2013-06-29 05:37:39.000000000","message":"i agree should be warning.","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"}],"quantum/tests/unit/bigswitch/test_restproxy_plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def setUp(self):"},{"line_number":117,"context_line":"        super(TestNoHostIDVIFOverride,"},{"line_number":118,"context_line":"              self).setUp()"},{"line_number":119,"context_line":"        cfg.CONF.set_override(\u0027vif_type\u0027, \u0027ovs\u0027, \u0027NOVA\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_port_vif_details(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ff%2FM%3D","line":118,"updated":"2013-06-29 05:37:39.000000000","message":"nit: this doens\u0027t need to be line wrapped","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"e4dee176a05d1be479a9c36ddeac8ff3f7f20dea","unresolved":false,"context_lines":[{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def setUp(self):"},{"line_number":117,"context_line":"        super(TestNoHostIDVIFOverride,"},{"line_number":118,"context_line":"              self).setUp()"},{"line_number":119,"context_line":"        cfg.CONF.set_override(\u0027vif_type\u0027, \u0027ovs\u0027, \u0027NOVA\u0027)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def test_port_vif_details(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAPn%2F%2Ff0U%3D","line":118,"in_reply_to":"AAAAPn%2F%2Ff%2FM%3D","updated":"2013-06-29 07:26:09.000000000","message":"Done","commit_id":"01c17d12ce07dc13bb5da1c59e3a3fd208d409f9"}]}