)]}'
{"neutron/agent/linux/ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31987df3acd5b767a98bd0f4676b5a916eb8bf06","unresolved":false,"context_lines":[{"line_number":778,"context_line":""},{"line_number":779,"context_line":"        return retval"},{"line_number":780,"context_line":""},{"line_number":781,"context_line":"    def flush(self, ip_version, table_id):"},{"line_number":782,"context_line":"        \"\"\"Flush iproute entries"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"        Given the table id it would remove all the routes related to"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4c923d4d","line":781,"updated":"2016-08-01 17:17:15.000000000","message":"nit: s/table_id/table","commit_id":"a81472b69142b33408b584af46d93a2499625eb3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31987df3acd5b767a98bd0f4676b5a916eb8bf06","unresolved":false,"context_lines":[{"line_number":786,"context_line":""},{"line_number":787,"context_line":"        :param ip_version: Either 4 or 6 for IPv4 or IPv6 respectively"},{"line_number":788,"context_line":"        :param table_id: Iproute table to flush"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027table\u0027, table_id))"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def add_route(self, cidr, via\u003dNone, table\u003dNone, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cca62dad","line":789,"updated":"2016-08-01 17:17:15.000000000","message":"Not sure we actually need any comment this is pretty self-explanatory.","commit_id":"a81472b69142b33408b584af46d93a2499625eb3"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31987df3acd5b767a98bd0f4676b5a916eb8bf06","unresolved":false,"context_lines":[{"line_number":787,"context_line":"        :param ip_version: Either 4 or 6 for IPv4 or IPv6 respectively"},{"line_number":788,"context_line":"        :param table_id: Iproute table to flush"},{"line_number":789,"context_line":"        \"\"\""},{"line_number":790,"context_line":"        self._as_root([ip_version], (\u0027flush\u0027, \u0027table\u0027, table_id))"},{"line_number":791,"context_line":""},{"line_number":792,"context_line":"    def add_route(self, cidr, via\u003dNone, table\u003dNone, **kwargs):"},{"line_number":793,"context_line":"        ip_version \u003d get_ip_version(cidr)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4c34fdfa","line":790,"updated":"2016-08-01 17:17:15.000000000","message":"Are there any places where self._table are used?  I couldn\u0027t find any, but we should just make this like all the other methods here:\n\nargs \u003d [\u0027flush\u0027]\nargs +\u003d self._table_args(table)\nself._as_root([ip_version], tuple(args))\n\nOf course that assumes we use table\u003dNone on L781.  And if we do that might as well add kwargs to future-proof this.","commit_id":"a81472b69142b33408b584af46d93a2499625eb3"}],"neutron/tests/unit/agent/linux/test_ip_lib.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"31987df3acd5b767a98bd0f4676b5a916eb8bf06","unresolved":false,"context_lines":[{"line_number":976,"context_line":""},{"line_number":977,"context_line":"    def test_route_flush(self):"},{"line_number":978,"context_line":"        self.route_cmd.flush(4, self.table)"},{"line_number":979,"context_line":"        self._assert_sudo([4], (\u0027flush\u0027, \u0027table\u0027, self.table))"},{"line_number":980,"context_line":""},{"line_number":981,"context_line":"    def test_add_route_no_via(self):"},{"line_number":982,"context_line":"        self.route_cmd.add_route(self.cidr, table\u003dself.table)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4c299d89","line":979,"updated":"2016-08-01 17:17:15.000000000","message":"s/4/self.ip_version here and L978 since both versions are tested in this file - see TestIPv6IpRouteCommand class.","commit_id":"a81472b69142b33408b584af46d93a2499625eb3"}]}