)]}'
{"neutron/agent/metadata/agent.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a97180b90d4e228f2e72119c44f78f4b86b86ad5","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            \u0027topic\u0027: \u0027N/A\u0027,"},{"line_number":243,"context_line":"            \u0027configurations\u0027: {"},{"line_number":244,"context_line":"                \u0027metadata_proxy_socket\u0027: cfg.CONF.metadata_proxy_socket,"},{"line_number":245,"context_line":"                \u0027nova_metadata_ip\u0027: cfg.CONF.nova_metadata_host,"},{"line_number":246,"context_line":"                \u0027nova_metadata_port\u0027: cfg.CONF.nova_metadata_port,"},{"line_number":247,"context_line":"                \u0027log_agent_heartbeats\u0027: cfg.CONF.AGENT.log_agent_heartbeats,"},{"line_number":248,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_bd865314","line":245,"updated":"2016-08-02 13:47:08.000000000","message":"So why didn\u0027t this value change?  I didn\u0027t see anything on the server that used this value.","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":21930,"name":"Steve Kipp","email":"sk167v@att.com","username":"SKipp"},"change_message_id":"d1b6600f12f71bf3e102e81fa993dd8f4fbe74bc","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            \u0027topic\u0027: \u0027N/A\u0027,"},{"line_number":243,"context_line":"            \u0027configurations\u0027: {"},{"line_number":244,"context_line":"                \u0027metadata_proxy_socket\u0027: cfg.CONF.metadata_proxy_socket,"},{"line_number":245,"context_line":"                \u0027nova_metadata_ip\u0027: cfg.CONF.nova_metadata_host,"},{"line_number":246,"context_line":"                \u0027nova_metadata_port\u0027: cfg.CONF.nova_metadata_port,"},{"line_number":247,"context_line":"                \u0027log_agent_heartbeats\u0027: cfg.CONF.AGENT.log_agent_heartbeats,"},{"line_number":248,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5440c935","line":245,"in_reply_to":"bacf61ea_2381a1fc","updated":"2016-08-02 15:42:59.000000000","message":"I\u0027ll be updating this for consistency","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":21930,"name":"Steve Kipp","email":"sk167v@att.com","username":"SKipp"},"change_message_id":"44afdb31db97581aad23b30cf58cadbb833d1250","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            \u0027topic\u0027: \u0027N/A\u0027,"},{"line_number":243,"context_line":"            \u0027configurations\u0027: {"},{"line_number":244,"context_line":"                \u0027metadata_proxy_socket\u0027: cfg.CONF.metadata_proxy_socket,"},{"line_number":245,"context_line":"                \u0027nova_metadata_ip\u0027: cfg.CONF.nova_metadata_host,"},{"line_number":246,"context_line":"                \u0027nova_metadata_port\u0027: cfg.CONF.nova_metadata_port,"},{"line_number":247,"context_line":"                \u0027log_agent_heartbeats\u0027: cfg.CONF.AGENT.log_agent_heartbeats,"},{"line_number":248,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_dd15074a","line":245,"in_reply_to":"bacf61ea_bd865314","updated":"2016-08-02 14:52:03.000000000","message":"the value of \u0027nova_metadata_ip\u0027 or switching the name of \u0027nova_metadata_ip\u0027?","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d9b359a900dfc4d2d01658578121a7833901cca1","unresolved":false,"context_lines":[{"line_number":242,"context_line":"            \u0027topic\u0027: \u0027N/A\u0027,"},{"line_number":243,"context_line":"            \u0027configurations\u0027: {"},{"line_number":244,"context_line":"                \u0027metadata_proxy_socket\u0027: cfg.CONF.metadata_proxy_socket,"},{"line_number":245,"context_line":"                \u0027nova_metadata_ip\u0027: cfg.CONF.nova_metadata_host,"},{"line_number":246,"context_line":"                \u0027nova_metadata_port\u0027: cfg.CONF.nova_metadata_port,"},{"line_number":247,"context_line":"                \u0027log_agent_heartbeats\u0027: cfg.CONF.AGENT.log_agent_heartbeats,"},{"line_number":248,"context_line":"            },"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2381a1fc","line":245,"in_reply_to":"bacf61ea_dd15074a","updated":"2016-08-02 14:59:13.000000000","message":"The key name on the left.","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"}],"neutron/agent/metadata/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a97180b90d4e228f2e72119c44f78f4b86b86ad5","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                help\u003d_(\"IP address or hostname used by Nova \""},{"line_number":59,"context_line":"\t\t       \"metadata server. Note: When using \""},{"line_number":60,"context_line":"\t\t       \"a TLS encrypted session this must \""},{"line_number":61,"context_line":"\t\t       \"be a hostname.\")),"},{"line_number":62,"context_line":"     cfg.PortOpt(\u0027nova_metadata_port\u0027,"},{"line_number":63,"context_line":"                 default\u003d8775,"},{"line_number":64,"context_line":"                 help\u003d_(\"TCP Port used by Nova metadata server.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_fd6c4bd2","line":61,"updated":"2016-08-02 13:47:08.000000000","message":"Eww, tabs :)","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"d9b359a900dfc4d2d01658578121a7833901cca1","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                help\u003d_(\"IP address or hostname used by Nova \""},{"line_number":59,"context_line":"\t\t       \"metadata server. Note: When using \""},{"line_number":60,"context_line":"\t\t       \"a TLS encrypted session this must \""},{"line_number":61,"context_line":"\t\t       \"be a hostname.\")),"},{"line_number":62,"context_line":"     cfg.PortOpt(\u0027nova_metadata_port\u0027,"},{"line_number":63,"context_line":"                 default\u003d8775,"},{"line_number":64,"context_line":"                 help\u003d_(\"TCP Port used by Nova metadata server.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e302e971","line":61,"in_reply_to":"bacf61ea_ddb9877b","updated":"2016-08-02 14:59:13.000000000","message":"Python is always 4 spaces indentation, but string alignment sometimes changes that like here.","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":21930,"name":"Steve Kipp","email":"sk167v@att.com","username":"SKipp"},"change_message_id":"d1b6600f12f71bf3e102e81fa993dd8f4fbe74bc","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                help\u003d_(\"IP address or hostname used by Nova \""},{"line_number":59,"context_line":"\t\t       \"metadata server. Note: When using \""},{"line_number":60,"context_line":"\t\t       \"a TLS encrypted session this must \""},{"line_number":61,"context_line":"\t\t       \"be a hostname.\")),"},{"line_number":62,"context_line":"     cfg.PortOpt(\u0027nova_metadata_port\u0027,"},{"line_number":63,"context_line":"                 default\u003d8775,"},{"line_number":64,"context_line":"                 help\u003d_(\"TCP Port used by Nova metadata server.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_149e5107","line":61,"in_reply_to":"bacf61ea_e302e971","updated":"2016-08-02 15:42:59.000000000","message":"Thanks!","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":21930,"name":"Steve Kipp","email":"sk167v@att.com","username":"SKipp"},"change_message_id":"44afdb31db97581aad23b30cf58cadbb833d1250","unresolved":false,"context_lines":[{"line_number":58,"context_line":"                help\u003d_(\"IP address or hostname used by Nova \""},{"line_number":59,"context_line":"\t\t       \"metadata server. Note: When using \""},{"line_number":60,"context_line":"\t\t       \"a TLS encrypted session this must \""},{"line_number":61,"context_line":"\t\t       \"be a hostname.\")),"},{"line_number":62,"context_line":"     cfg.PortOpt(\u0027nova_metadata_port\u0027,"},{"line_number":63,"context_line":"                 default\u003d8775,"},{"line_number":64,"context_line":"                 help\u003d_(\"TCP Port used by Nova metadata server.\")),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ddb9877b","line":61,"in_reply_to":"bacf61ea_fd6c4bd2","updated":"2016-08-02 14:52:03.000000000","message":"Looks like I forgot to switch my vim out of tabs, haha. Couldn\u0027t find any documentation on the matter,  are the tabs set to 4 spaces? METADATA_PROXY_HANDLER_OPTS is 5, but everything else is 4. If its 4 I\u0027ll update all of this to match.","commit_id":"51838f4b254d3b553c7f8256a2b1c022e91dc6f9"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"72d1ec03eb582875848a155a1347a09d5f28cbc4","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"METADATA_PROXY_HANDLER_OPTS \u003d ["},{"line_number":53,"context_line":"     cfg.StrOpt(\u0027auth_ca_cert\u0027,"},{"line_number":54,"context_line":"                help\u003d_(\"Certificate Authority public key (CA cert) \""},{"line_number":55,"context_line":"                       \"file for ssl\")),"},{"line_number":56,"context_line":"     cfg.StrOpt(\u0027nova_metadata_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8797ee38","side":"PARENT","line":53,"updated":"2016-08-05 21:57:20.000000000","message":"You shouldn\u0027t change any other indentation in this patch","commit_id":"ee42af101157426539162012a5527e1e607e033c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c4dbd6a8559dcf0a631ab294408a084f35e6eeef","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"METADATA_PROXY_HANDLER_OPTS \u003d ["},{"line_number":53,"context_line":"     cfg.StrOpt(\u0027auth_ca_cert\u0027,"},{"line_number":54,"context_line":"                help\u003d_(\"Certificate Authority public key (CA cert) \""},{"line_number":55,"context_line":"                       \"file for ssl\")),"},{"line_number":56,"context_line":"     cfg.StrOpt(\u0027nova_metadata_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_8ba2d1ac","side":"PARENT","line":53,"in_reply_to":"9ad45d7e_8f913e9c","updated":"2016-08-09 18:46:56.000000000","message":"Basically, you should only change what you need for your patch, making changes in surrounding code that isn\u0027t relevant for your patch is discouraged.\n\nSo L56-61 changes (in your patch) is what to do, making the indentation match what\u0027s around it (and be correct). Running the pep8 tests (tox -e pep8 HEAD~1) will catch bad indentation in your new code.\n\nThe reason it didn\u0027t catch the 5-spaces indent in the existing code is it was all the same.  Feel free to start another change if you want to fix that as it\u0027s more a trivial fix and doesn\u0027t change code operation.","commit_id":"ee42af101157426539162012a5527e1e607e033c"},{"author":{"_account_id":21930,"name":"Steve Kipp","email":"sk167v@att.com","username":"SKipp"},"change_message_id":"c14bac3b20827c7f30894702464a069ec7d9afba","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"METADATA_PROXY_HANDLER_OPTS \u003d ["},{"line_number":53,"context_line":"     cfg.StrOpt(\u0027auth_ca_cert\u0027,"},{"line_number":54,"context_line":"                help\u003d_(\"Certificate Authority public key (CA cert) \""},{"line_number":55,"context_line":"                       \"file for ssl\")),"},{"line_number":56,"context_line":"     cfg.StrOpt(\u0027nova_metadata_ip\u0027, default\u003d\u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_8f913e9c","side":"PARENT","line":53,"in_reply_to":"bacf61ea_8797ee38","updated":"2016-08-09 18:15:13.000000000","message":"should I revert the indentation changes? I apologize I\u0027m still learning the ropes.","commit_id":"ee42af101157426539162012a5527e1e607e033c"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"72d1ec03eb582875848a155a1347a09d5f28cbc4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"               help\u003d_(\"IP address or hostname used by Nova \""},{"line_number":59,"context_line":"               \"metadata server. Note: When using \""},{"line_number":60,"context_line":"               \"a TLS encrypted session this must \""},{"line_number":61,"context_line":"               \"be a hostname.\")),"},{"line_number":62,"context_line":"    cfg.PortOpt(\u0027nova_metadata_port\u0027,"},{"line_number":63,"context_line":"               default\u003d8775,"},{"line_number":64,"context_line":"               help\u003d_(\"TCP Port used by Nova metadata server.\")),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_07ac9e8a","line":61,"updated":"2016-08-05 21:57:20.000000000","message":"This indentation is wrong, needs to line-up like the others.","commit_id":"4735388185343f1eaad48ad7af80ab3b2c251de3"}]}