)]}'
{"neutron/conf/agent/securitygroups_rpc.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"acccce965e22e460a39421ded380a05be1cd9d32","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"security_group_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_22fabf43","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":27},"updated":"2016-08-04 15:16:06.000000000","message":"Please refer to imports in below file https://github.com/openstack/neutron/blob/master/neutron/manager.py\nAbove two imports should be separated by an empty line","commit_id":"69d894ae68f7be3ff3ef32b04cc9972a0b4f7352"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"a93a719741e86621f49300ecf10204148d690317","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron._i18n import _"},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"security_group_opts \u003d ["}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0f4e893a","line":19,"range":{"start_line":18,"start_character":0,"end_line":19,"end_character":27},"in_reply_to":"bacf61ea_22fabf43","updated":"2016-08-05 15:11:20.000000000","message":"Done","commit_id":"69d894ae68f7be3ff3ef32b04cc9972a0b4f7352"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"66a534d5399d8da7458a3cdcda71cb6adda100e8","unresolved":false,"context_lines":[{"line_number":22,"context_line":"security_group_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt("},{"line_number":24,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":25,"context_line":"        help\u003d_(\u0027Driver for security groups firewall in the L2 agent\u0027)),"},{"line_number":26,"context_line":"    cfg.BoolOpt("},{"line_number":27,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":28,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d9603fa7","line":25,"updated":"2016-08-03 13:07:11.000000000","message":"can we have an security group directory with agents?","commit_id":"69d894ae68f7be3ff3ef32b04cc9972a0b4f7352"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ca6736b7728f64b1c09196987acc6ee0dd85638e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"security_group_opts \u003d ["},{"line_number":23,"context_line":"    cfg.StrOpt("},{"line_number":24,"context_line":"        \u0027firewall_driver\u0027,"},{"line_number":25,"context_line":"        help\u003d_(\u0027Driver for security groups firewall in the L2 agent\u0027)),"},{"line_number":26,"context_line":"    cfg.BoolOpt("},{"line_number":27,"context_line":"        \u0027enable_security_group\u0027,"},{"line_number":28,"context_line":"        default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_86cc9b62","line":25,"in_reply_to":"bacf61ea_d9603fa7","updated":"2016-08-03 15:51:27.000000000","message":"ignore this dumb comment","commit_id":"69d894ae68f7be3ff3ef32b04cc9972a0b4f7352"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"66a534d5399d8da7458a3cdcda71cb6adda100e8","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            \u0027in the server. It should be false when using no security \u0027"},{"line_number":32,"context_line":"            \u0027groups or using the nova security group API.\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_ipset\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Use ipset to speed-up the iptables based security groups. \u0027"},{"line_number":37,"context_line":"               \u0027Enabling ipset support requires that ipset is installed on L2 \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d9d2ff5a","line":34,"updated":"2016-08-03 13:07:11.000000000","message":"this is a plugin specific implementation variable. i do not think that it should be with all of the common options","commit_id":"69d894ae68f7be3ff3ef32b04cc9972a0b4f7352"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ca6736b7728f64b1c09196987acc6ee0dd85638e","unresolved":false,"context_lines":[{"line_number":31,"context_line":"            \u0027in the server. It should be false when using no security \u0027"},{"line_number":32,"context_line":"            \u0027groups or using the nova security group API.\u0027)),"},{"line_number":33,"context_line":"    cfg.BoolOpt("},{"line_number":34,"context_line":"        \u0027enable_ipset\u0027,"},{"line_number":35,"context_line":"        default\u003dTrue,"},{"line_number":36,"context_line":"        help\u003d_(\u0027Use ipset to speed-up the iptables based security groups. \u0027"},{"line_number":37,"context_line":"               \u0027Enabling ipset support requires that ipset is installed on L2 \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_e6dbd719","line":34,"in_reply_to":"bacf61ea_d9d2ff5a","updated":"2016-08-03 15:51:27.000000000","message":"ditto","commit_id":"69d894ae68f7be3ff3ef32b04cc9972a0b4f7352"}],"neutron/tests/functional/agent/test_firewall.py":[{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6b03076dced973f667a49011fda8399569ae745d","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.agent.linux import iptables_firewall"},{"line_number":32,"context_line":"from neutron.agent.linux import openvswitch_firewall"},{"line_number":33,"context_line":"from neutron.cmd.sanity import checks"},{"line_number":34,"context_line":"from neutron.conf.agent import securitygroups_rpc as sg_cfg"},{"line_number":35,"context_line":"from neutron.tests.common import conn_testers"},{"line_number":36,"context_line":"from neutron.tests.functional.agent.linux import base as linux_base"},{"line_number":37,"context_line":"from neutron.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_18c7e364","line":34,"updated":"2016-08-05 19:50:02.000000000","message":"same here sc_cfg to security_config","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"85ab0c71854c0200565d022555d3ba64d1163ca2","unresolved":false,"context_lines":[{"line_number":31,"context_line":"from neutron.agent.linux import iptables_firewall"},{"line_number":32,"context_line":"from neutron.agent.linux import openvswitch_firewall"},{"line_number":33,"context_line":"from neutron.cmd.sanity import checks"},{"line_number":34,"context_line":"from neutron.conf.agent import securitygroups_rpc as sg_cfg"},{"line_number":35,"context_line":"from neutron.tests.common import conn_testers"},{"line_number":36,"context_line":"from neutron.tests.functional.agent.linux import base as linux_base"},{"line_number":37,"context_line":"from neutron.tests.functional import base"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9b3f4d86","line":34,"in_reply_to":"bacf61ea_18c7e364","updated":"2016-08-05 20:10:46.000000000","message":"Done","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6b03076dced973f667a49011fda8399569ae745d","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    vlan_range \u003d set(range(VLAN_COUNT))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        sg_cfg.register_securitygroups_opts()"},{"line_number":98,"context_line":"        super(BaseFirewallTestCase, self).setUp()"},{"line_number":99,"context_line":"        self.tester, self.firewall \u003d getattr(self, self.initialize)()"},{"line_number":100,"context_line":"        if self.firewall_name \u003d\u003d \"openvswitch\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f8c12f4f","line":97,"updated":"2016-08-05 19:50:02.000000000","message":"same","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"85ab0c71854c0200565d022555d3ba64d1163ca2","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    vlan_range \u003d set(range(VLAN_COUNT))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def setUp(self):"},{"line_number":97,"context_line":"        sg_cfg.register_securitygroups_opts()"},{"line_number":98,"context_line":"        super(BaseFirewallTestCase, self).setUp()"},{"line_number":99,"context_line":"        self.tester, self.firewall \u003d getattr(self, self.initialize)()"},{"line_number":100,"context_line":"        if self.firewall_name \u003d\u003d \"openvswitch\":"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3b0aa1d2","line":97,"in_reply_to":"bacf61ea_f8c12f4f","updated":"2016-08-05 20:10:46.000000000","message":"Done","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"}],"neutron/tests/unit/agent/linux/test_iptables_firewall.py":[{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6b03076dced973f667a49011fda8399569ae745d","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.linux import iptables_firewall"},{"line_number":29,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.conf.agent import securitygroups_rpc as sg_cfg"},{"line_number":32,"context_line":"from neutron.tests import base"},{"line_number":33,"context_line":"from neutron.tests.unit.api.v2 import test_base"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_189ec362","line":31,"updated":"2016-08-05 19:50:02.000000000","message":"same sc_cfg to security_config","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"85ab0c71854c0200565d022555d3ba64d1163ca2","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from neutron.agent.linux import iptables_firewall"},{"line_number":29,"context_line":"from neutron.common import exceptions as n_exc"},{"line_number":30,"context_line":"from neutron.common import utils"},{"line_number":31,"context_line":"from neutron.conf.agent import securitygroups_rpc as sg_cfg"},{"line_number":32,"context_line":"from neutron.tests import base"},{"line_number":33,"context_line":"from neutron.tests.unit.api.v2 import test_base"},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5b2e7543","line":31,"in_reply_to":"bacf61ea_189ec362","updated":"2016-08-05 20:10:46.000000000","message":"Done","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"},{"author":{"_account_id":19611,"name":"Brian Stajkowski","email":"brian.stajkowski@rackspace.com","username":"ski"},"change_message_id":"6b03076dced973f667a49011fda8399569ae745d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        super(BaseIptablesFirewallTestCase, self).setUp()"},{"line_number":73,"context_line":"        cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":74,"context_line":"        sg_cfg.register_securitygroups_opts()"},{"line_number":75,"context_line":"        cfg.CONF.set_override(\u0027comment_iptables_rules\u0027, False, \u0027AGENT\u0027)"},{"line_number":76,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":77,"context_line":"            \u0027neutron.agent.linux.utils.execute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_f8980f77","line":74,"updated":"2016-08-05 19:50:02.000000000","message":"same","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"85ab0c71854c0200565d022555d3ba64d1163ca2","unresolved":false,"context_lines":[{"line_number":71,"context_line":"    def setUp(self):"},{"line_number":72,"context_line":"        super(BaseIptablesFirewallTestCase, self).setUp()"},{"line_number":73,"context_line":"        cfg.CONF.register_opts(a_cfg.ROOT_HELPER_OPTS, \u0027AGENT\u0027)"},{"line_number":74,"context_line":"        sg_cfg.register_securitygroups_opts()"},{"line_number":75,"context_line":"        cfg.CONF.set_override(\u0027comment_iptables_rules\u0027, False, \u0027AGENT\u0027)"},{"line_number":76,"context_line":"        self.utils_exec_p \u003d mock.patch("},{"line_number":77,"context_line":"            \u0027neutron.agent.linux.utils.execute\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9b246d60","line":74,"in_reply_to":"bacf61ea_f8980f77","updated":"2016-08-05 20:10:46.000000000","message":"Done","commit_id":"d8a6af01ed12e4ce23ab864083360ac64c19f502"}]}
