)]}'
{"neutron/services/trunk/constants.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a0989bc854cbc1c4112aee7a743a635b65c356d4","unresolved":false,"context_lines":[{"line_number":23,"context_line":"# indicates whether a trunk can be managed. If a trunk has admin_state_up"},{"line_number":24,"context_line":"# equal to false, the trunk plugin will reject any user request to manage"},{"line_number":25,"context_line":"# the trunk resources (i.e. adding/removing sub-ports)."},{"line_number":26,"context_line":"ACTIVE_STATUS \u003d \u0027ACTIVE\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# The server has acknowledged the user request: a user has asked to either"},{"line_number":29,"context_line":"# create a trunk or add/remove resources to a trunk, and the plugin has"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ebe9dbb8","line":26,"updated":"2016-08-03 17:45:12.000000000","message":"+1 this makes sense to me.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a0989bc854cbc1c4112aee7a743a635b65c356d4","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# created/updated the logical resource. The request has been passed along"},{"line_number":31,"context_line":"# to a backend, and the physical resources associated to the trunk are"},{"line_number":32,"context_line":"# in the process of being provisioned."},{"line_number":33,"context_line":"PENDING_STATUS \u003d \u0027PENDING\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# A driver/backend has acknowledged the server request: once the server"},{"line_number":36,"context_line":"# notifies the driver/backend, a trunk is in BUILD state while the"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0b9f0f04","line":33,"updated":"2016-08-03 17:45:12.000000000","message":"+1 makes sense to me.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a0989bc854cbc1c4112aee7a743a635b65c356d4","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# A driver/backend has acknowledged the server request: once the server"},{"line_number":36,"context_line":"# notifies the driver/backend, a trunk is in BUILD state while the"},{"line_number":37,"context_line":"# backend provisions the trunk resources."},{"line_number":38,"context_line":"BUID_STATUS \u003d \u0027BUILD\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Should any temporary system failure occurs during the provisioning process,"},{"line_number":41,"context_line":"# a trunk is in DEGRADED state. This means that the trunk was only"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_8bfc9f3f","line":38,"updated":"2016-08-03 17:45:12.000000000","message":"+1 makes sense to me.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"10a3c363dc4dad365c2c02ce31257de869dffa0f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# backend provisions the trunk resources."},{"line_number":38,"context_line":"BUID_STATUS \u003d \u0027BUILD\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Should any temporary system failure occurs during the provisioning process,"},{"line_number":41,"context_line":"# a trunk is in DEGRADED state. This means that the trunk was only"},{"line_number":42,"context_line":"# partially provisioned, and only a subset of the subports were added"},{"line_number":43,"context_line":"# successfully to the trunk. The operation of removing/adding the faulty"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4221e1fb","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":44},"updated":"2016-08-03 21:26:49.000000000","message":"occur","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eade5ed357ba541bc69f403f13c2025ac13f7c22","unresolved":false,"context_lines":[{"line_number":37,"context_line":"# backend provisions the trunk resources."},{"line_number":38,"context_line":"BUID_STATUS \u003d \u0027BUILD\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Should any temporary system failure occurs during the provisioning process,"},{"line_number":41,"context_line":"# a trunk is in DEGRADED state. This means that the trunk was only"},{"line_number":42,"context_line":"# partially provisioned, and only a subset of the subports were added"},{"line_number":43,"context_line":"# successfully to the trunk. The operation of removing/adding the faulty"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ec6d679a","line":40,"range":{"start_line":40,"start_character":38,"end_line":40,"end_character":44},"in_reply_to":"bacf61ea_4221e1fb","updated":"2016-08-03 23:07:07.000000000","message":"Done","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a0989bc854cbc1c4112aee7a743a635b65c356d4","unresolved":false,"context_lines":[{"line_number":42,"context_line":"# partially provisioned, and only a subset of the subports were added"},{"line_number":43,"context_line":"# successfully to the trunk. The operation of removing/adding the faulty"},{"line_number":44,"context_line":"# subports may be attempted as a recovery measure."},{"line_number":45,"context_line":"DEGRADED_STATUS \u003d \u0027DEGRADED\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0b354f45","line":45,"updated":"2016-08-03 17:45:12.000000000","message":"+1 this makes sense to me.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"10a3c363dc4dad365c2c02ce31257de869dffa0f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# subports may be attempted as a recovery measure."},{"line_number":45,"context_line":"DEGRADED_STATUS \u003d \u0027DEGRADED\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"},{"line_number":49,"context_line":"# instance, a subport belonging to a network might not not be compatible with"},{"line_number":50,"context_line":"# the current trunk configuration, or the binding process leads to a persistent"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_c2c95127","line":47,"range":{"start_line":47,"start_character":72,"end_line":47,"end_character":73},"updated":"2016-08-03 21:26:49.000000000","message":"add a comma here","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eade5ed357ba541bc69f403f13c2025ac13f7c22","unresolved":false,"context_lines":[{"line_number":44,"context_line":"# subports may be attempted as a recovery measure."},{"line_number":45,"context_line":"DEGRADED_STATUS \u003d \u0027DEGRADED\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"},{"line_number":49,"context_line":"# instance, a subport belonging to a network might not not be compatible with"},{"line_number":50,"context_line":"# the current trunk configuration, or the binding process leads to a persistent"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2c681f87","line":47,"range":{"start_line":47,"start_character":72,"end_line":47,"end_character":73},"in_reply_to":"bacf61ea_c2c95127","updated":"2016-08-03 23:07:07.000000000","message":"Done","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"10a3c363dc4dad365c2c02ce31257de869dffa0f","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"},{"line_number":49,"context_line":"# instance, a subport belonging to a network might not not be compatible with"},{"line_number":50,"context_line":"# the current trunk configuration, or the binding process leads to a persistent"},{"line_number":51,"context_line":"# failure. Removing the \u0027offending\u0027 resource may be attempted as a recovery"},{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_02eb6979","line":49,"range":{"start_line":49,"start_character":51,"end_line":49,"end_character":55},"updated":"2016-08-03 21:26:49.000000000","message":"extra \u0027not\u0027","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eade5ed357ba541bc69f403f13c2025ac13f7c22","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"},{"line_number":49,"context_line":"# instance, a subport belonging to a network might not not be compatible with"},{"line_number":50,"context_line":"# the current trunk configuration, or the binding process leads to a persistent"},{"line_number":51,"context_line":"# failure. Removing the \u0027offending\u0027 resource may be attempted as a recovery"},{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_cc0fc3df","line":49,"range":{"start_line":49,"start_character":51,"end_line":49,"end_character":55},"in_reply_to":"bacf61ea_02eb6979","updated":"2016-08-03 23:07:07.000000000","message":"Done","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a0989bc854cbc1c4112aee7a743a635b65c356d4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"# failure. Removing the \u0027offending\u0027 resource may be attempted as a recovery"},{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"},{"line_number":53,"context_line":"# condition."},{"line_number":54,"context_line":"ERROR_STATUS \u003d \u0027ERROR\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# String literals for identifying trunk resources"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_2bf3f3a0","line":54,"updated":"2016-08-03 17:45:12.000000000","message":"+1 this makes sense to me.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"a0989bc854cbc1c4112aee7a743a635b65c356d4","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"},{"line_number":53,"context_line":"# condition."},{"line_number":54,"context_line":"ERROR_STATUS \u003d \u0027ERROR\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# String literals for identifying trunk resources"},{"line_number":58,"context_line":"PARENT_PORT \u003d \u0027parent_port\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_967682a1","line":55,"updated":"2016-08-03 17:45:12.000000000","message":"I\u0027m thinking there may be 1 more state to add. That would be something along the lines of \"UPDATING\". We would transition to this state when the trunk is either ACTIVE or DEGRADED, and we are in the middle of processing subport add/removal. In these situations, the trunk is not being built so BUILD might not be appropriate. I\u0027m thinking there is a state where we are processing an update to an existing trunk that needs to be reflected.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"10a3c363dc4dad365c2c02ce31257de869dffa0f","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"},{"line_number":53,"context_line":"# condition."},{"line_number":54,"context_line":"ERROR_STATUS \u003d \u0027ERROR\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# String literals for identifying trunk resources"},{"line_number":58,"context_line":"PARENT_PORT \u003d \u0027parent_port\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d8b940ee","line":55,"in_reply_to":"bacf61ea_967682a1","updated":"2016-08-03 21:26:49.000000000","message":"I think BUILD is sufficient because it still signifies that trunk resources are currently being provisioned.\n\nA trunk that was created with 10 subports but has only provisioned 9 so far should be in the same \"state\" as a trunk that was created with 9 subports but is currently processing the addition of a 10th subport.\n\nTo the end user, both of those cases look the same, right?","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"343e24d7cd9d9a26381a081068a9e3086a3dd435","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"},{"line_number":53,"context_line":"# condition."},{"line_number":54,"context_line":"ERROR_STATUS \u003d \u0027ERROR\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# String literals for identifying trunk resources"},{"line_number":58,"context_line":"PARENT_PORT \u003d \u0027parent_port\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_4c0473bf","line":55,"in_reply_to":"bacf61ea_967682a1","updated":"2016-08-03 23:07:36.000000000","message":"Let\u0027s see if we do end up needing one more, for now I think these are the most basic ones.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"eade5ed357ba541bc69f403f13c2025ac13f7c22","unresolved":false,"context_lines":[{"line_number":52,"context_line":"# measure, but readding it to the trunk should lead to the same error"},{"line_number":53,"context_line":"# condition."},{"line_number":54,"context_line":"ERROR_STATUS \u003d \u0027ERROR\u0027"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# String literals for identifying trunk resources"},{"line_number":58,"context_line":"PARENT_PORT \u003d \u0027parent_port\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0cfa7bbd","line":55,"in_reply_to":"bacf61ea_d8b940ee","updated":"2016-08-03 23:07:07.000000000","message":"Yes, I think so.","commit_id":"109e0d29a3af85c1e74b0a78c5621431d7d5d3ba"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"d4e3074a2e3e3f0873ce686d0e35b4651f1be274","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# in the process of being provisioned."},{"line_number":33,"context_line":"PENDING_STATUS \u003d \u0027PENDING\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# A driver/backend has acknowledged the server request: once the server"},{"line_number":36,"context_line":"# notifies the driver/backend, a trunk is in BUILD state while the"},{"line_number":37,"context_line":"# backend provisions the trunk resources."},{"line_number":38,"context_line":"BUILD_STATUS \u003d \u0027BUILD\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Should any temporary system failure occur during the provisioning process,"},{"line_number":41,"context_line":"# a trunk is in DEGRADED state. This means that the trunk was only"},{"line_number":42,"context_line":"# partially provisioned, and only a subset of the subports were added"},{"line_number":43,"context_line":"# successfully to the trunk. The operation of removing/adding the faulty"},{"line_number":44,"context_line":"# subports may be attempted as a recovery measure."},{"line_number":45,"context_line":"DEGRADED_STATUS \u003d \u0027DEGRADED\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict, and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_8c8660d9","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":28},"updated":"2016-08-04 05:42:11.000000000","message":"nit: These statuses are not used in this patch and not defined in spec. And also we\u0027re not sure they are used in future. I think that it\u0027s better to add them with backend implementation. If we need them to not forget, I would put just TODO comment.","commit_id":"dee5544446df0e4a6f54dce8597a1e37263d2c1c"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"b71b25b08c3ec9144c0a9a1157a6c5da57d9d27c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# in the process of being provisioned."},{"line_number":33,"context_line":"PENDING_STATUS \u003d \u0027PENDING\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# A driver/backend has acknowledged the server request: once the server"},{"line_number":36,"context_line":"# notifies the driver/backend, a trunk is in BUILD state while the"},{"line_number":37,"context_line":"# backend provisions the trunk resources."},{"line_number":38,"context_line":"BUILD_STATUS \u003d \u0027BUILD\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Should any temporary system failure occur during the provisioning process,"},{"line_number":41,"context_line":"# a trunk is in DEGRADED state. This means that the trunk was only"},{"line_number":42,"context_line":"# partially provisioned, and only a subset of the subports were added"},{"line_number":43,"context_line":"# successfully to the trunk. The operation of removing/adding the faulty"},{"line_number":44,"context_line":"# subports may be attempted as a recovery measure."},{"line_number":45,"context_line":"DEGRADED_STATUS \u003d \u0027DEGRADED\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict, and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_38f20ad3","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":28},"in_reply_to":"bacf61ea_822bc7ea","updated":"2016-08-04 07:22:21.000000000","message":"Fair enough.","commit_id":"dee5544446df0e4a6f54dce8597a1e37263d2c1c"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"413a397a41ba21511c45431e0880e7aa76f9f4ab","unresolved":false,"context_lines":[{"line_number":32,"context_line":"# in the process of being provisioned."},{"line_number":33,"context_line":"PENDING_STATUS \u003d \u0027PENDING\u0027"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"# A driver/backend has acknowledged the server request: once the server"},{"line_number":36,"context_line":"# notifies the driver/backend, a trunk is in BUILD state while the"},{"line_number":37,"context_line":"# backend provisions the trunk resources."},{"line_number":38,"context_line":"BUILD_STATUS \u003d \u0027BUILD\u0027"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# Should any temporary system failure occur during the provisioning process,"},{"line_number":41,"context_line":"# a trunk is in DEGRADED state. This means that the trunk was only"},{"line_number":42,"context_line":"# partially provisioned, and only a subset of the subports were added"},{"line_number":43,"context_line":"# successfully to the trunk. The operation of removing/adding the faulty"},{"line_number":44,"context_line":"# subports may be attempted as a recovery measure."},{"line_number":45,"context_line":"DEGRADED_STATUS \u003d \u0027DEGRADED\u0027"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# Due to unforeseen circumstances, the user request has led to a conflict, and"},{"line_number":48,"context_line":"# the trunk cannot be provisioned correctly for a subset of subports. For"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_822bc7ea","line":45,"range":{"start_line":35,"start_character":0,"end_line":45,"end_character":28},"in_reply_to":"bacf61ea_8c8660d9","updated":"2016-08-04 06:42:43.000000000","message":"The only reason why I didn\u0027t use these is because to add them I need another patch and I wanted to avoid a rebase. Having them here for documentation purposes helps understand it all though.","commit_id":"dee5544446df0e4a6f54dce8597a1e37263d2c1c"}]}
