)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"f8a53c95b0153bcab9efa7e83d612ad53a79e404","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add metering OVO support."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I149f85c844be5700fd2fc015bf70a5015343195f"},{"line_number":12,"context_line":"artially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3ac371cc_89cf967e","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":8},"updated":"2016-08-16 05:01:50.000000000","message":"nit: Partially","commit_id":"6a17ea8ed1abb0690600d6187872361a4d6dfa56"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"502afa61b1fb345b9ba15280fbd09ceaa9e043f1","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Add metering OVO support."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I149f85c844be5700fd2fc015bf70a5015343195f"},{"line_number":12,"context_line":"Depends-On: I6df6b9d90c6a7281edc39cfafd9ea33e9a7a0b34"},{"line_number":13,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3ac371cc_bb482dcd","line":12,"updated":"2016-08-18 14:45:04.000000000","message":"Depends-On label is used for adding cross project dependencies, but in this case it\u0027s not required\n\n[1] http://docs.openstack.org/infra/manual/developers.html#cross-repository-dependencies","commit_id":"4a6eb8b465afa30a7c7644b6887a530df1a17bd1"}],"neutron/objects/common_types.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"502afa61b1fb345b9ba15280fbd09ceaa9e043f1","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    AUTO_TYPE \u003d IPNetwork()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"class DirectironEnumField(obj_fields.BaseEnumField):"},{"line_number":189,"context_line":"    \"\"\"MeteringLabelRule custom field."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    This custom field is an enum filed  which only allow to be"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_3b59dd8e","line":188,"range":{"start_line":188,"start_character":6,"end_line":188,"end_character":25},"updated":"2016-08-18 14:45:04.000000000","message":"s/DirectironEnumField/DirectionEnumField/","commit_id":"4a6eb8b465afa30a7c7644b6887a530df1a17bd1"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"502afa61b1fb345b9ba15280fbd09ceaa9e043f1","unresolved":false,"context_lines":[{"line_number":188,"context_line":"class DirectironEnumField(obj_fields.BaseEnumField):"},{"line_number":189,"context_line":"    \"\"\"MeteringLabelRule custom field."},{"line_number":190,"context_line":""},{"line_number":191,"context_line":"    This custom field is an enum filed  which only allow to be"},{"line_number":192,"context_line":"     \u0027ingress\u0027 or \u0027egress\u0027"},{"line_number":193,"context_line":"     \"\"\""},{"line_number":194,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d[constants.EGRESS_DIRECTION,"},{"line_number":195,"context_line":"                                              constants.INGRESS_DIRECTION])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_c60a70d1","line":192,"range":{"start_line":191,"start_character":4,"end_line":192,"end_character":26},"updated":"2016-08-18 14:45:04.000000000","message":"This enum field only allows to \u0027ingress\u0027 or \u0027egress\u0027 values","commit_id":"4a6eb8b465afa30a7c7644b6887a530df1a17bd1"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"502afa61b1fb345b9ba15280fbd09ceaa9e043f1","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    This custom field is an enum filed  which only allow to be"},{"line_number":192,"context_line":"     \u0027ingress\u0027 or \u0027egress\u0027"},{"line_number":193,"context_line":"     \"\"\""},{"line_number":194,"context_line":"    AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003d[constants.EGRESS_DIRECTION,"},{"line_number":195,"context_line":"                                              constants.INGRESS_DIRECTION])"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_2608a427","line":195,"range":{"start_line":194,"start_character":4,"end_line":195,"end_character":75},"updated":"2016-08-18 14:45:04.000000000","message":"AUTO_TYPE \u003d obj_fields.Enum(valid_values\u003dconstants.VALID_DIRECTIONS)","commit_id":"4a6eb8b465afa30a7c7644b6887a530df1a17bd1"}],"neutron/objects/metering.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a12882edcc64228a3312760814350bf2caad67e8","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":36,"context_line":"    }"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    foreign_keys \u003d {\u0027metering_label_id\u0027: \u0027id\u0027}"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"@obj_base.VersionedObjectRegistry.register"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_39740dfc","line":38,"range":{"start_line":38,"start_character":5,"end_line":38,"end_character":46},"updated":"2016-08-03 07:56:31.000000000","message":"Move up.","commit_id":"7a9d3f7adc9bb4c6a06b90ecda39316d21c6941a"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"a12882edcc64228a3312760814350bf2caad67e8","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    db_model \u003d metering_models.MeteringLabel"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    foreign_keys \u003d {\u0027metering_label_id\u0027: \u0027id\u0027}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    fields \u003d {"},{"line_number":51,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_997899fa","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":46},"updated":"2016-08-03 07:56:31.000000000","message":"Remove this.","commit_id":"7a9d3f7adc9bb4c6a06b90ecda39316d21c6941a"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7582a64153aafdfa422c692bbd8daeaa648a8e60","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    fields \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027direction\u0027: common_types.DirectironEnumField(),"},{"line_number":35,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027metering_label_id\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_108916cb","line":34,"range":{"start_line":34,"start_character":53,"end_line":34,"end_character":55},"updated":"2016-08-03 09:32:06.000000000","message":"add nullable\u003dTrue","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"dc6c5386e72b360ab6822d9c3731df139890a4a8","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    fields \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027direction\u0027: common_types.DirectironEnumField(),"},{"line_number":35,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027metering_label_id\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_407d52b0","line":34,"range":{"start_line":34,"start_character":53,"end_line":34,"end_character":55},"in_reply_to":"bacf61ea_108916cb","updated":"2016-08-04 02:07:49.000000000","message":"Done","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7582a64153aafdfa422c692bbd8daeaa648a8e60","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    fields \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027direction\u0027: common_types.DirectironEnumField(),"},{"line_number":35,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027metering_label_id\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":38,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d09e5e06","line":35,"range":{"start_line":35,"start_character":50,"end_line":35,"end_character":52},"updated":"2016-08-03 09:32:06.000000000","message":"add nullable\u003dTrue","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"dc6c5386e72b360ab6822d9c3731df139890a4a8","unresolved":false,"context_lines":[{"line_number":32,"context_line":"    fields \u003d {"},{"line_number":33,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027direction\u0027: common_types.DirectironEnumField(),"},{"line_number":35,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027metering_label_id\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":38,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_60821696","line":35,"range":{"start_line":35,"start_character":50,"end_line":35,"end_character":52},"in_reply_to":"bacf61ea_d09e5e06","updated":"2016-08-04 02:07:49.000000000","message":"Done","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7582a64153aafdfa422c692bbd8daeaa648a8e60","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027direction\u0027: common_types.DirectironEnumField(),"},{"line_number":35,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027metering_label_id\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_70f21271","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":66},"updated":"2016-08-03 09:32:06.000000000","message":"in OVO nullable\u003dFalse is by default. We should in OVO add nullable\u003dTrue only. It is the opposite than in SQLAlchemy.","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"dc6c5386e72b360ab6822d9c3731df139890a4a8","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":34,"context_line":"        \u0027direction\u0027: common_types.DirectironEnumField(),"},{"line_number":35,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027metering_label_id\u0027: obj_fields.StringField(nullable\u003dFalse),"},{"line_number":37,"context_line":"        \u0027excluded\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_00735ae8","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":66},"in_reply_to":"bacf61ea_70f21271","updated":"2016-08-04 02:07:49.000000000","message":"Done","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7582a64153aafdfa422c692bbd8daeaa648a8e60","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    db_model \u003d metering_models.MeteringLabel"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    fields \u003d {"},{"line_number":49,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":50,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":51,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027MeteringLabelRule\u0027,"},{"line_number":52,"context_line":"                                               nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_cb0eb3e4","line":49,"updated":"2016-08-03 09:32:06.000000000","message":"MeteringLabelRule should have also tenant_id field due to [1]. Please add:\n\n\u0027project_id\u0027: obj_fields.StringField(nullable\u003dTrue),\n\n[1] https://github.com/openstack/neutron/blob/9.0.0.0b2/neutron/db/metering/metering_db.py#L41","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"3a93704cbae5080ab57846f548650294cbc83dc0","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    db_model \u003d metering_models.MeteringLabel"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    fields \u003d {"},{"line_number":49,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":50,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":51,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027MeteringLabelRule\u0027,"},{"line_number":52,"context_line":"                                               nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_211e5663","line":49,"in_reply_to":"bacf61ea_20781ec4","updated":"2016-08-04 08:56:04.000000000","message":"Now it is already merged, the tenant_id renamed into project_id.","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"dc6c5386e72b360ab6822d9c3731df139890a4a8","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    db_model \u003d metering_models.MeteringLabel"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    fields \u003d {"},{"line_number":49,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":50,"context_line":"        \u0027name\u0027: obj_fields.StringField(),"},{"line_number":51,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027MeteringLabelRule\u0027,"},{"line_number":52,"context_line":"                                               nullable\u003dTrue),"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_20781ec4","line":49,"in_reply_to":"bacf61ea_cb0eb3e4","updated":"2016-08-04 02:07:49.000000000","message":"oh, yes, but would that be tenant_id ? do we want hacking here?","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7582a64153aafdfa422c692bbd8daeaa648a8e60","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027MeteringLabelRule\u0027,"},{"line_number":52,"context_line":"                                               nullable\u003dTrue),"},{"line_number":53,"context_line":"        # TODO(eliqiao): Need to first add Router objects"},{"line_number":54,"context_line":"        \u0027routers\u0027: obj_fields.ListOfObjectsField(\u0027Router\u0027, nullable\u003dTrue),"},{"line_number":55,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":56,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_ebabb7d4","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":17},"updated":"2016-08-03 09:32:06.000000000","message":"I guess it is valid to have the routers field here. It is used in [1].\nIf you have the relationship in SQLAlchemy model, you have to define the field in synthetic_fields list:\n\nsynthetic_fields \u003d  [\u0027routers\u0027]\n\nSynthetic fields should be loaded from relationship in NeutronDbObject base class.\n\n[1] https://github.com/openstack/neutron/blob/9.0.0.0b2/neutron/db/metering/metering_db.py#L218","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"3a93704cbae5080ab57846f548650294cbc83dc0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027MeteringLabelRule\u0027,"},{"line_number":52,"context_line":"                                               nullable\u003dTrue),"},{"line_number":53,"context_line":"        # TODO(eliqiao): Need to first add Router objects"},{"line_number":54,"context_line":"        \u0027routers\u0027: obj_fields.ListOfObjectsField(\u0027Router\u0027, nullable\u003dTrue),"},{"line_number":55,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":56,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_e73f2e23","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":17},"in_reply_to":"bacf61ea_7bf1276a","updated":"2016-08-04 08:56:04.000000000","message":"Yes, we need Router object first to get this working. \nFrom code, it seems that it is used in listing so we need multiple instances of routers.\n\nsynthetic fields generally should have foreign keys defined, like here [1], but we are using the side-loaded relationships in SQL query [2] so it will load the routers from relationship [3]\n\n[1] https://github.com/openstack/neutron/blob/9.0.0.0b2/neutron/objects/subnet.py#L32\n[2] https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L465\n[3] https://github.com/openstack/neutron/blob/9.0.0.0b2/neutron/db/metering/metering_db.py#L46","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"dc6c5386e72b360ab6822d9c3731df139890a4a8","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        \u0027rules\u0027: obj_fields.ListOfObjectsField(\u0027MeteringLabelRule\u0027,"},{"line_number":52,"context_line":"                                               nullable\u003dTrue),"},{"line_number":53,"context_line":"        # TODO(eliqiao): Need to first add Router objects"},{"line_number":54,"context_line":"        \u0027routers\u0027: obj_fields.ListOfObjectsField(\u0027Router\u0027, nullable\u003dTrue),"},{"line_number":55,"context_line":"        \u0027shared\u0027: obj_fields.BooleanField(default\u003dFalse),"},{"line_number":56,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_7bf1276a","line":54,"range":{"start_line":54,"start_character":8,"end_line":54,"end_character":17},"in_reply_to":"bacf61ea_ebabb7d4","updated":"2016-08-04 02:07:49.000000000","message":"yeah, that\u0027s great, neutrondbobject did lots of works, but seems that I doubt that if we can just usesynthetic_fields \u003d  [\u0027routers\u0027], reasons are:\n\n1. we don\u0027t have router object yet\n2. won\u0027t that should be router instead of routers?\n\nhmm... I think I need to read the method of base class on how to load relation OVO objects. :(","commit_id":"0e7a56a6356921893a22acc6c04c1495b150ad48"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b399a7b48f4772f824162a8c996bafc14f674515","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db.models import metering_models"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":"from neutron.objects import common_types"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_c7fdca3c","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":44},"updated":"2016-08-04 08:55:56.000000000","message":"this is called neturon.db.models import metering","commit_id":"7caacdcc3b1699464aa733441e6dc4eaed69e279"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b399a7b48f4772f824162a8c996bafc14f674515","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    db_model \u003d metering_models.MeteringLabel"},{"line_number":47,"context_line":"    synthetic_fields \u003d [\u0027rules\u0027, \u0027routers\u0027]"},{"line_number":48,"context_line":"    fields_need_translation \u003d {\u0027project_id\u0027: \u0027tenant_id\u0027}"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    fields \u003d {"},{"line_number":51,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"bacf61ea_074522b2","line":48,"range":{"start_line":48,"start_character":4,"end_line":48,"end_character":57},"updated":"2016-08-04 08:55:56.000000000","message":"This can be removed since tenant_id into project_id renaming is already merged,","commit_id":"7caacdcc3b1699464aa733441e6dc4eaed69e279"}],"neutron/tests/tools.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"502afa61b1fb345b9ba15280fbd09ceaa9e043f1","unresolved":false,"context_lines":[{"line_number":301,"context_line":"    return random.choice(n_const.IPV6_MODES)"},{"line_number":302,"context_line":""},{"line_number":303,"context_line":""},{"line_number":304,"context_line":"def get_random_direction():"},{"line_number":305,"context_line":"    return random.choice([n_const.EGRESS_DIRECTION,"},{"line_number":306,"context_line":"                          n_const.INGRESS_DIRECTION])"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"import_modules_recursively \u003d moves.moved_function("}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_868d18d5","line":306,"range":{"start_line":304,"start_character":0,"end_line":306,"end_character":53},"updated":"2016-08-18 14:45:04.000000000","message":"Given that \"get_random_flow_direction\" function already do this, this new function is not required.","commit_id":"4a6eb8b465afa30a7c7644b6887a530df1a17bd1"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"502afa61b1fb345b9ba15280fbd09ceaa9e043f1","unresolved":false,"context_lines":[{"line_number":324,"context_line":"    common_types.EtherTypeEnumField: tools.get_random_ether_type,"},{"line_number":325,"context_line":"    common_types.IpProtocolEnumField: tools.get_random_ip_protocol,"},{"line_number":326,"context_line":"    common_types.PortRangeField: tools.get_random_port,"},{"line_number":327,"context_line":"    common_types.DirectironEnumField: tools.get_random_direction,"},{"line_number":328,"context_line":"}"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_867b58bd","line":327,"updated":"2016-08-18 14:45:04.000000000","message":"ditto: https://review.openstack.org/#/c/350387/6/neutron/tests/tools.py@304","commit_id":"4a6eb8b465afa30a7c7644b6887a530df1a17bd1"}],"neutron/tests/unit/objects/test_metering.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b076cda5122db4e8f3d00daf00f40dd0ee85ebab","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class MeteringLabelRuleDbObjectTestCase(obj_test_base._BaseObjectTestCase,"},{"line_number":26,"context_line":"                            testlib_api.SqlTestCase):"},{"line_number":27,"context_line":"    _test_class \u003d metering.MeteringLabelRule"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_3aece88e","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":28},"updated":"2016-10-12 14:17:16.000000000","message":"Wrong indentation","commit_id":"a647b682b1e669ee14c5e40563569ca92b6917bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b076cda5122db4e8f3d00daf00f40dd0ee85ebab","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MeteringLabelDbObjectTestCase(obj_test_base._BaseObjectTestCase,"},{"line_number":36,"context_line":"                            testlib_api.SqlTestCase):"},{"line_number":37,"context_line":"    _test_class \u003d metering.MeteringLabel"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_baf8f84a","line":36,"range":{"start_line":36,"start_character":0,"end_line":36,"end_character":28},"updated":"2016-10-12 14:17:16.000000000","message":"Wrong indentation","commit_id":"a647b682b1e669ee14c5e40563569ca92b6917bc"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"332365f2783565219e73d5c7e4196f2d202162c0","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MeteringLabelDbObjectTestCase(obj_test_base._BaseObjectTestCase,"},{"line_number":36,"context_line":"                            testlib_api.SqlTestCase):"},{"line_number":37,"context_line":"    _test_class \u003d metering.MeteringLabel"}],"source_content_type":"text/x-python","patch_set":7,"id":"1a95cdbc_93fc4740","line":37,"updated":"2016-10-04 17:24:35.000000000","message":"I think we need to do setup() for creating router(s) and MeteringRule(s) for this ?","commit_id":"a647b682b1e669ee14c5e40563569ca92b6917bc"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b076cda5122db4e8f3d00daf00f40dd0ee85ebab","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class MeteringLabelDbObjectTestCase(obj_test_base._BaseObjectTestCase,"},{"line_number":36,"context_line":"                            testlib_api.SqlTestCase):"},{"line_number":37,"context_line":"    _test_class \u003d metering.MeteringLabel"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa6399be_ad19a07b","line":37,"in_reply_to":"1a95cdbc_93fc4740","updated":"2016-10-12 14:17:16.000000000","message":"Yes, but this method needs to be placed in MeteringLabelRuleDbObjectTestCase class.  I\u0027m wondering why the UTs didn\u0027t reflect this.  BTW, Good catch.","commit_id":"a647b682b1e669ee14c5e40563569ca92b6917bc"}]}
