)]}'
{"neutron/common/exceptions.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"eb2f3d521b10d5cf9fcf2cdffd2ac040545c42c8","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class TenantIdProjectIdFilterConflict(e.BadRequest):"},{"line_number":339,"context_line":"    message \u003d _(\"Bot tenant_id and project_id passed as filters.\")"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"# Neutron-lib migration shim. This will wrap any exceptions that are moved"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_bf5c5dee","line":339,"range":{"start_line":339,"start_character":17,"end_line":339,"end_character":19},"updated":"2016-08-03 08:29:14.000000000","message":"Both","commit_id":"fe04d0bd4855d93052750196dcfd12899a3f54eb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c1a558275f065b41db40dd0ae2539ecc504170f","unresolved":false,"context_lines":[{"line_number":336,"context_line":""},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"class TenantIdProjectIdFilterConflict(e.BadRequest):"},{"line_number":339,"context_line":"    message \u003d _(\"Bot tenant_id and project_id passed as filters.\")"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"# Neutron-lib migration shim. This will wrap any exceptions that are moved"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_0aaf29e4","line":339,"range":{"start_line":339,"start_character":17,"end_line":339,"end_character":19},"in_reply_to":"bacf61ea_bf5c5dee","updated":"2016-08-03 08:42:57.000000000","message":"Done","commit_id":"fe04d0bd4855d93052750196dcfd12899a3f54eb"}],"neutron/objects/utils.py":[{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"eb2f3d521b10d5cf9fcf2cdffd2ac040545c42c8","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"},{"line_number":22,"context_line":"            raise exceptions.TenantIdProjectIdFilterConflict()"},{"line_number":23,"context_line":"        result[\u0027project_id\u0027] \u003d result.pop(\u0027tenant_id\u0027)"},{"line_number":24,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_1fcac94f","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":54},"updated":"2016-08-03 08:29:14.000000000","message":"This is hard to read.\n\nHow about:\n    if \u0027tenant_id\u0027 in result:\n        result[\u0027project_id\u0027] \u003d result.pop(\u0027tenant_id\u0027)\n\n        if \u0027project_id\u0027 in result:\n            raise exceptions.TenantIdProjectIdFilterConflict()\n\n    return result","commit_id":"fe04d0bd4855d93052750196dcfd12899a3f54eb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c6f9d151f25580413f6d892d5adb9dd27ad7cccd","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"},{"line_number":22,"context_line":"            raise exceptions.TenantIdProjectIdFilterConflict()"},{"line_number":23,"context_line":"        result[\u0027project_id\u0027] \u003d result.pop(\u0027tenant_id\u0027)"},{"line_number":24,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ff8535ad","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":54},"in_reply_to":"bacf61ea_1fcac94f","updated":"2016-08-03 08:35:24.000000000","message":"That\u0027s wrong: we can\u0027t determine if project_id was passed with tenant_id once you pop it out.","commit_id":"fe04d0bd4855d93052750196dcfd12899a3f54eb"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5c1a558275f065b41db40dd0ae2539ecc504170f","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"},{"line_number":22,"context_line":"            raise exceptions.TenantIdProjectIdFilterConflict()"},{"line_number":23,"context_line":"        result[\u0027project_id\u0027] \u003d result.pop(\u0027tenant_id\u0027)"},{"line_number":24,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_eaabb5d4","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":54},"in_reply_to":"bacf61ea_9f17d953","updated":"2016-08-03 08:42:57.000000000","message":"Done","commit_id":"fe04d0bd4855d93052750196dcfd12899a3f54eb"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"59942d710a86754b863121cb11f815fa5705d4f5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"},{"line_number":22,"context_line":"            raise exceptions.TenantIdProjectIdFilterConflict()"},{"line_number":23,"context_line":"        result[\u0027project_id\u0027] \u003d result.pop(\u0027tenant_id\u0027)"},{"line_number":24,"context_line":"    return result"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_9f17d953","line":23,"range":{"start_line":20,"start_character":0,"end_line":23,"end_character":54},"in_reply_to":"bacf61ea_ff8535ad","updated":"2016-08-03 08:39:03.000000000","message":"oh, stupid me.\nThen please add a new space line after raise.","commit_id":"fe04d0bd4855d93052750196dcfd12899a3f54eb"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"54e27d2ffc7fcad6c2b016d242a3e1b9549ae19e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron.common import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_6a7d05e7","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":19},"updated":"2016-08-03 08:54:14.000000000","message":"We would also need a place to remove the unknown to object filters. Would it be possible to remove the filters in this function also? In such case, we should pass the db class as well, to validate the unknown filters.","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c621fc635067aeb29e7c986b6c9aaf5dbf53e6c2","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron.common import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_701692a8","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"bacf61ea_10dd9670","updated":"2016-08-03 09:19:49.000000000","message":"We may hack it quick for your subnet patch, but I prefer to keep it closer to subnet then. I plan to tackle filtering on API layer this cycle, so hopefully whatever the hack you will come up, it won\u0027t go live in final N.","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"531ba6789b2be58ec7b1d4564f2dfdba48f54c98","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron.common import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_10dd9670","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"bacf61ea_25005eaa","updated":"2016-08-03 09:14:56.000000000","message":"The long term solution is to have it done in API layer, but until the proper fix, do we want to remove it in DB layer? We have discussed it on last Upgrades meeting on 1.08","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"589c9abe27784d8920d78b73ed0d24ee073eda51","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron.common import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_25005eaa","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"bacf61ea_6a7d05e7","updated":"2016-08-03 09:02:34.000000000","message":"I think that kind of filtering belongs to the API layer itself. Plugins should not deal with unknown attributes.","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"2dc6be52f3be1de85fb5e295cb153596be707cda","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from neutron.common import exceptions"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"def convert_filters(**kwargs):"},{"line_number":19,"context_line":"    result \u003d copy.deepcopy(kwargs)"},{"line_number":20,"context_line":"    if \u0027tenant_id\u0027 in result:"},{"line_number":21,"context_line":"        if \u0027project_id\u0027 in result:"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_abd53fba","line":18,"range":{"start_line":18,"start_character":4,"end_line":18,"end_character":19},"in_reply_to":"bacf61ea_701692a8","updated":"2016-08-03 09:38:26.000000000","message":"From test perspective I\u0027m OK with it, the subnet patch is passing the gate. Like you said, I can add some hack close to the subnet, not to break user that will be deploying from master. Thanks.","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"}],"neutron/tests/unit/objects/test_utils.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"ff6923e2ca3b79599969b5e4e7b9a35a1629ffb3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def test_convert_filters_no_tenant_id(self):"},{"line_number":21,"context_line":"        kwargs \u003d {"},{"line_number":22,"context_line":"            \u0027filter%d\u0027 % i: \u0027value%d\u0027 % i"},{"line_number":23,"context_line":"            for i in range(0, 10)"},{"line_number":24,"context_line":"        }"},{"line_number":25,"context_line":"        self.assertEqual(kwargs, utils.convert_filters(**kwargs))"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_26d32f3a","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":30},"updated":"2016-08-03 15:48:14.000000000","message":"I see you like being explicit :)","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f4c9e421ad86cf315ac54d8f66beb2404002cb51","unresolved":false,"context_lines":[{"line_number":20,"context_line":"    def test_convert_filters_no_tenant_id(self):"},{"line_number":21,"context_line":"        kwargs \u003d {"},{"line_number":22,"context_line":"            \u0027filter%d\u0027 % i: \u0027value%d\u0027 % i"},{"line_number":23,"context_line":"            for i in range(0, 10)"},{"line_number":24,"context_line":"        }"},{"line_number":25,"context_line":"        self.assertEqual(kwargs, utils.convert_filters(**kwargs))"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_0698ab1a","line":23,"range":{"start_line":23,"start_character":27,"end_line":23,"end_character":30},"in_reply_to":"bacf61ea_26d32f3a","updated":"2016-08-03 15:51:02.000000000","message":"Oh boy. I will skip respinning that one.","commit_id":"f13ed8c506c2fcac8b403b8c5c71680cda550e5c"}]}
