)]}'
{"neutron/db/db_base_plugin_v2.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f1d03465ec2f9ec236590a40c696bb7ba1052823","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise exc.SubnetInUse(subnet_id\u003dsubnet_id, reason\u003de)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _update_subnetpool_dict(model, new_pool):"},{"line_number":87,"context_line":"    updated \u003d {}"},{"line_number":88,"context_line":"    new_prefixes \u003d new_pool.get(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"},{"line_number":89,"context_line":"    orig_prefixes \u003d [str(x.cidr) for x in model[\u0027prefixes\u0027]]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_87b827e7","line":86,"range":{"start_line":86,"start_character":28,"end_line":86,"end_character":33},"updated":"2016-08-03 11:59:22.000000000","message":"It is not model, it is db_obj. Model sounds like only the definition, i.e. models_v2.Subnetpool. But here we have the DB object fetched.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b78b03a6eae347f7d96c6e226ea06708f14d1bf1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        raise exc.SubnetInUse(subnet_id\u003dsubnet_id, reason\u003de)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"def _update_subnetpool_dict(model, new_pool):"},{"line_number":87,"context_line":"    updated \u003d {}"},{"line_number":88,"context_line":"    new_prefixes \u003d new_pool.get(\u0027prefixes\u0027, constants.ATTR_NOT_SPECIFIED)"},{"line_number":89,"context_line":"    orig_prefixes \u003d [str(x.cidr) for x in model[\u0027prefixes\u0027]]"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_3a7fc667","line":86,"range":{"start_line":86,"start_character":28,"end_line":86,"end_character":33},"in_reply_to":"bacf61ea_87b827e7","updated":"2016-08-03 14:47:43.000000000","message":"I was actually restoring the original code here. Now that it\u0027s gone, I guess I need to clean it up.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"f1d03465ec2f9ec236590a40c696bb7ba1052823","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        updated[\u0027prefixes\u0027] \u003d orig_prefixes"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    for key in [\u0027id\u0027, \u0027name\u0027, \u0027ip_version\u0027, \u0027min_prefixlen\u0027,"},{"line_number":103,"context_line":"                \u0027max_prefixlen\u0027, \u0027default_prefixlen\u0027, \u0027is_default\u0027,"},{"line_number":104,"context_line":"                \u0027shared\u0027, \u0027default_quota\u0027, \u0027address_scope_id\u0027,"},{"line_number":105,"context_line":"                \u0027standard_attr\u0027, \u0027description\u0027]:"},{"line_number":106,"context_line":"        _write_key(key, updated, model, new_pool)"},{"line_number":107,"context_line":"    return updated"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_27db3b1d","line":105,"range":{"start_line":102,"start_character":15,"end_line":105,"end_character":47},"updated":"2016-08-03 11:59:22.000000000","message":"this is some kind of non-synthetic fields? maybe we can generate it somehow?","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b78b03a6eae347f7d96c6e226ea06708f14d1bf1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"    else:"},{"line_number":100,"context_line":"        updated[\u0027prefixes\u0027] \u003d orig_prefixes"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    for key in [\u0027id\u0027, \u0027name\u0027, \u0027ip_version\u0027, \u0027min_prefixlen\u0027,"},{"line_number":103,"context_line":"                \u0027max_prefixlen\u0027, \u0027default_prefixlen\u0027, \u0027is_default\u0027,"},{"line_number":104,"context_line":"                \u0027shared\u0027, \u0027default_quota\u0027, \u0027address_scope_id\u0027,"},{"line_number":105,"context_line":"                \u0027standard_attr\u0027, \u0027description\u0027]:"},{"line_number":106,"context_line":"        _write_key(key, updated, model, new_pool)"},{"line_number":107,"context_line":"    return updated"},{"line_number":108,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1a880222","line":105,"range":{"start_line":102,"start_character":15,"end_line":105,"end_character":47},"in_reply_to":"bacf61ea_27db3b1d","updated":"2016-08-03 14:47:43.000000000","message":"I took the function body from the time before we adopted subnetpool object in the code. Those keys belong to db model. We could probably try to extract them from the model, but then, the next time we add a new attribute to the model, it will automatically show up on API, which may be unexpected.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"32f65754448a01a5357cd5812d675d03ab29e8d3","unresolved":false,"context_lines":[{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1039,"context_line":"            orig_sp \u003d self._get_subnetpool(context, id\u003did)"},{"line_number":1040,"context_line":"            updated \u003d _update_subnetpool_dict(orig_sp.db_obj, new_sp)"},{"line_number":1041,"context_line":"            reader \u003d subnet_alloc.SubnetPoolReader(updated)"},{"line_number":1042,"context_line":"            if reader.is_default and not orig_sp.is_default:"},{"line_number":1043,"context_line":"                self._check_default_subnetpool_exists(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_c2e32d04","line":1040,"range":{"start_line":1040,"start_character":46,"end_line":1040,"end_character":60},"updated":"2016-08-03 12:07:32.000000000","message":"does it make any sense to pass the db_obj instead of subnetpool ovo?","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b78b03a6eae347f7d96c6e226ea06708f14d1bf1","unresolved":false,"context_lines":[{"line_number":1037,"context_line":""},{"line_number":1038,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1039,"context_line":"            orig_sp \u003d self._get_subnetpool(context, id\u003did)"},{"line_number":1040,"context_line":"            updated \u003d _update_subnetpool_dict(orig_sp.db_obj, new_sp)"},{"line_number":1041,"context_line":"            reader \u003d subnet_alloc.SubnetPoolReader(updated)"},{"line_number":1042,"context_line":"            if reader.is_default and not orig_sp.is_default:"},{"line_number":1043,"context_line":"                self._check_default_subnetpool_exists(context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_9ad192fe","line":1040,"range":{"start_line":1040,"start_character":46,"end_line":1040,"end_character":60},"in_reply_to":"bacf61ea_c2e32d04","updated":"2016-08-03 14:47:43.000000000","message":"Actually, maybe it\u0027s ok to pass it here. I need to check.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b78b03a6eae347f7d96c6e226ea06708f14d1bf1","unresolved":false,"context_lines":[{"line_number":1071,"context_line":""},{"line_number":1072,"context_line":"    def get_subnetpool(self, context, id, fields\u003dNone):"},{"line_number":1073,"context_line":"        subnetpool \u003d self._get_subnetpool(context, id)"},{"line_number":1074,"context_line":"        return self._make_subnetpool_dict(subnetpool, fields)"},{"line_number":1075,"context_line":""},{"line_number":1076,"context_line":"    def get_subnetpools(self, context, filters\u003dNone, fields\u003dNone,"},{"line_number":1077,"context_line":"                        sorts\u003dNone, limit\u003dNone, marker\u003dNone,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5ab0badd","line":1074,"updated":"2016-08-03 14:47:43.000000000","message":"pass db_obj?","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b78b03a6eae347f7d96c6e226ea06708f14d1bf1","unresolved":false,"context_lines":[{"line_number":1081,"context_line":"        subnetpools \u003d subnetpool_obj.SubnetPool.get_objects("},{"line_number":1082,"context_line":"            context, _pager\u003dpager, **filters)"},{"line_number":1083,"context_line":"        return ["},{"line_number":1084,"context_line":"            self._make_subnetpool_dict(pool, fields)"},{"line_number":1085,"context_line":"            for pool in subnetpools"},{"line_number":1086,"context_line":"        ]"},{"line_number":1087,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1ab642dc","line":1084,"updated":"2016-08-03 14:47:43.000000000","message":"Should I pass db_obj here too?","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"}],"neutron/objects/subnetpool.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"93a6b0d9ede694e5edf4220458d06e6056e96846","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027prefixes\u0027: common_types.ListOfIPNetworksField(nullable\u003dTrue)"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    fields_no_update \u003d [\u0027id\u0027, \u0027project_id\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_6281a14d","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":29},"updated":"2016-08-03 12:02:29.000000000","message":"\u0027id\u0027 is already handled by primary_keys.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b78b03a6eae347f7d96c6e226ea06708f14d1bf1","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        \u0027prefixes\u0027: common_types.ListOfIPNetworksField(nullable\u003dTrue)"},{"line_number":47,"context_line":"    }"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    fields_no_update \u003d [\u0027id\u0027, \u0027project_id\u0027]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_5afefa6b","line":49,"range":{"start_line":49,"start_character":24,"end_line":49,"end_character":29},"in_reply_to":"bacf61ea_6281a14d","updated":"2016-08-03 14:47:43.000000000","message":"Right. But it\u0027s not the goal of the patch to change that.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"933f1a3a8124383beb551624a41a2eabb583b346","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    fields_need_translation \u003d {"},{"line_number":54,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027,"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def modify_fields_from_db(cls, db_obj):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d83ace33","line":55,"range":{"start_line":53,"start_character":4,"end_line":55,"end_character":5},"updated":"2016-08-04 07:29:33.000000000","message":"When project_id is already merged, it is not needed.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"413f242e7a2498fc0c8a60bf2101ae09f3921751","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    fields_need_translation \u003d {"},{"line_number":54,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027,"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def modify_fields_from_db(cls, db_obj):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_d272a67b","line":55,"range":{"start_line":53,"start_character":4,"end_line":55,"end_character":5},"in_reply_to":"bacf61ea_1e1baf1c","updated":"2016-08-04 09:04:22.000000000","message":"I hope that project_id renaming will not be reverted?","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"52ff566d07e72062ac15a5684acf0a3ac9616745","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    fields_need_translation \u003d {"},{"line_number":54,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027,"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def modify_fields_from_db(cls, db_obj):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_b277323a","line":55,"range":{"start_line":53,"start_character":4,"end_line":55,"end_character":5},"in_reply_to":"bacf61ea_d272a67b","updated":"2016-08-04 09:09:07.000000000","message":"Then I guess (I hope) our tests will break.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"20047b5d5394dc76d33b3aac352c73175ce685a1","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    synthetic_fields \u003d [\u0027prefixes\u0027]"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    fields_need_translation \u003d {"},{"line_number":54,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027,"},{"line_number":55,"context_line":"    }"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    @classmethod"},{"line_number":58,"context_line":"    def modify_fields_from_db(cls, db_obj):"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_1e1baf1c","line":55,"range":{"start_line":53,"start_character":4,"end_line":55,"end_character":5},"in_reply_to":"bacf61ea_d83ace33","updated":"2016-08-04 07:38:52.000000000","message":"Yeah, I should now remove it.","commit_id":"f3e8785ce218c6f2a54ad75ec2a083b7911f678d"}]}
