)]}'
{"neutron/extensions/qos.py":[{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"1258fd26762fd1e2465ee69006233f98e229fdec","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                           **{\u0027max_kbps\u0027: {"},{"line_number":78,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":79,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":81,"context_line":"                                      common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":82,"context_line":"                              \u0027max_burst_kbps\u0027: {"},{"line_number":83,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_8c8ab919","line":80,"range":{"start_line":80,"start_character":62,"end_line":80,"end_character":63},"updated":"2016-08-10 14:33:01.000000000","message":"Does this range include 0 as a valid value?","commit_id":"4bdfcfc77be46b82e48068de0e846eb6c2172b8b"},{"author":{"_account_id":18051,"name":"David Shaughnessy","email":"david.shaughnessy@intel.com","username":"davidsha"},"change_message_id":"396d993c18f21ed226f51f0d1a336a9df7c42530","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                           **{\u0027max_kbps\u0027: {"},{"line_number":78,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":79,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":81,"context_line":"                                      common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":82,"context_line":"                              \u0027max_burst_kbps\u0027: {"},{"line_number":83,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_e0b78d82","line":80,"range":{"start_line":80,"start_character":62,"end_line":80,"end_character":63},"in_reply_to":"9ad45d7e_6efc7972","updated":"2016-08-12 08:09:05.000000000","message":"This is what I mean, for example if the max_burst_kbps is set to 0 will that make it through the check?","commit_id":"4bdfcfc77be46b82e48068de0e846eb6c2172b8b"},{"author":{"_account_id":20076,"name":"QunyingRan","email":"ran.qunying@zte.com.cn","username":"QunyingRan"},"change_message_id":"de7f5811abe8f818c973c842e311b2bf0729d123","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                           **{\u0027max_kbps\u0027: {"},{"line_number":78,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"},{"line_number":79,"context_line":"                                  \u0027is_visible\u0027: True, \u0027default\u0027: None,"},{"line_number":80,"context_line":"                                  \u0027validate\u0027: {\u0027type:range\u0027: [0,"},{"line_number":81,"context_line":"                                      common_constants.DB_INTEGER_MAX_VALUE]}},"},{"line_number":82,"context_line":"                              \u0027max_burst_kbps\u0027: {"},{"line_number":83,"context_line":"                                  \u0027allow_post\u0027: True, \u0027allow_put\u0027: True,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9ad45d7e_6efc7972","line":80,"range":{"start_line":80,"start_character":62,"end_line":80,"end_character":63},"in_reply_to":"9ad45d7e_8c8ab919","updated":"2016-08-11 05:27:23.000000000","message":"the default value is 0 in ovs","commit_id":"4bdfcfc77be46b82e48068de0e846eb6c2172b8b"}],"neutron/services/qos/qos_plugin.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"fdc1ecc64ee5d3bd9734a9259291025da1a4fd47","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                rule \u003d rule_obj(context, qos_policy_id\u003dpolicy_id, **rule_data)"},{"line_number":176,"context_line":"                rule.create()"},{"line_number":177,"context_line":"                policy.reload_rules()"},{"line_number":178,"context_line":"        except db_exc.DBDataError:"},{"line_number":179,"context_line":"            raise n_exc.ValueIsInvalidInDatabase(data\u003drule_data)"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"        self.notification_driver_manager.update_policy(context, policy)"},{"line_number":182,"context_line":"        return rule"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_692cbe4a","line":179,"range":{"start_line":178,"start_character":0,"end_line":179,"end_character":64},"updated":"2016-08-04 04:48:50.000000000","message":"Use validator instead of exception if you really want to check the value greater than 2147483648kbps.","commit_id":"fba481ea40cff9f0bc5237d50c0a08da09871313"}]}
