)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"49614fcc61290a0cf39bb0a2079cef0b4f4ce20b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-04 17:14:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add agent-side driver scaffolding for trunk functionality"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The agent code is enhanced to allow the trunk agent-side counterpart"},{"line_number":10,"context_line":"to be activated seamlessly by means or local registry notifications."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_67ef97e9","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":57},"updated":"2016-08-04 20:44:05.000000000","message":"Newbie question: what is trunk functionality?","commit_id":"b104001a6fd29fccd6f49b54130591e79aa9280e"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"6bbea3abe0fd1fc2bb3602d96d1818ca75207485","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-04 17:14:08 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add agent-side driver scaffolding for trunk functionality"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The agent code is enhanced to allow the trunk agent-side counterpart"},{"line_number":10,"context_line":"to be activated seamlessly by means or local registry notifications."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_eaf06eff","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":57},"in_reply_to":"bacf61ea_67ef97e9","updated":"2016-08-04 21:03:27.000000000","message":"you can link on the blueprint link and find out.","commit_id":"b104001a6fd29fccd6f49b54130591e79aa9280e"},{"author":{"_account_id":22220,"name":"Anindita Das","email":"anindita.das@utexas.edu","username":"anudas"},"change_message_id":"49614fcc61290a0cf39bb0a2079cef0b4f4ce20b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add agent-side driver scaffolding for trunk functionality"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The agent code is enhanced to allow the trunk agent-side counterpart"},{"line_number":10,"context_line":"to be activated seamlessly by means or local registry notifications."},{"line_number":11,"context_line":"Some integration with the server side is provided by loading the"},{"line_number":12,"context_line":"RPC agent-side skeleton. Basic unit testing provides some coverage."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_110b792b","line":10,"range":{"start_line":10,"start_character":36,"end_line":10,"end_character":38},"updated":"2016-08-04 20:44:05.000000000","message":"nit: of","commit_id":"b104001a6fd29fccd6f49b54130591e79aa9280e"}],"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":10980,"name":"Doug Wiegley","email":"dougwig@parkside.io","username":"dougw"},"change_message_id":"9d8d4f9a33e274b2e3987174cd9f73e8d7fce5fb","unresolved":false,"context_lines":[{"line_number":59,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent \\"},{"line_number":60,"context_line":"    import ovs_agent_extension_api as ovs_ext_api"},{"line_number":61,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent \\"},{"line_number":62,"context_line":"     import ovs_capabilities"},{"line_number":63,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent \\"},{"line_number":64,"context_line":"    import ovs_dvr_neutron_agent"},{"line_number":65,"context_line":"from neutron.plugins.ml2.drivers.openvswitch.agent import vlanmanager"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_476de9ca","line":62,"updated":"2016-08-18 12:09:26.000000000","message":"FIVE SPACES?  THE HORROR!","commit_id":"95d6dbd54355fb089ddccb792dac8a214308bc95"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"c1bca4e6c348d3e33565603b31121cb17dde7756","unresolved":false,"context_lines":[{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":"    try:"},{"line_number":2162,"context_line":"        agent \u003d OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":2163,"context_line":"        capabilities.notify_init_event(n_const.AGENT_TYPE_OVS, agent)"},{"line_number":2164,"context_line":"    except (RuntimeError, ValueError) as e:"},{"line_number":2165,"context_line":"        LOG.error(_LE(\"%s Agent terminated!\"), e)"},{"line_number":2166,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_2fb8e229","line":2163,"updated":"2016-08-17 06:32:38.000000000","message":"why is this in this try catch? can the init event throw the exceptions below? I am not sure?","commit_id":"95d6dbd54355fb089ddccb792dac8a214308bc95"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"cbfbf106b964637aa39ef602a1f54261fcc0f6de","unresolved":false,"context_lines":[{"line_number":2160,"context_line":""},{"line_number":2161,"context_line":"    try:"},{"line_number":2162,"context_line":"        agent \u003d OVSNeutronAgent(bridge_classes, cfg.CONF)"},{"line_number":2163,"context_line":"        capabilities.notify_init_event(n_const.AGENT_TYPE_OVS, agent)"},{"line_number":2164,"context_line":"    except (RuntimeError, ValueError) as e:"},{"line_number":2165,"context_line":"        LOG.error(_LE(\"%s Agent terminated!\"), e)"},{"line_number":2166,"context_line":"        sys.exit(1)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_cf766ed6","line":2163,"in_reply_to":"3ac371cc_2fb8e229","updated":"2016-08-17 06:57:34.000000000","message":"it doesn\u0027t need to be but it\u0027s here because it needs agent and if we move it out the try-except we\u0027d need to initialize agent.","commit_id":"95d6dbd54355fb089ddccb792dac8a214308bc95"}]}
