)]}'
{"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"0ccc3721921d04325a288cc65c50aa2ca31747d3","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                self.remove_external_gateway_ip(device,"},{"line_number":675,"context_line":"                                                common_utils.ip_to_cidr("},{"line_number":676,"context_line":"                                                    ip_addr[\u0027ip_address\u0027],"},{"line_number":677,"context_line":"                                                    prefixlen))"},{"line_number":678,"context_line":"        self.driver.unplug(interface_name,"},{"line_number":679,"context_line":"                           bridge\u003dself.agent_conf.external_network_bridge,"},{"line_number":680,"context_line":"                           namespace\u003dself.ns_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_07f01ec8","line":677,"updated":"2016-08-05 21:53:48.000000000","message":"I don\u0027t think not removing the IP is a good solution.  What about:\n\n1 - not passing prefixlen to ip_to_cidr()?  It doesn\u0027t need it but the /32 IP returned might throw a different error\n\n2 - have secondary fixed_ips inherit the same prefixlen of the primary","commit_id":"d5d3dec22f3acba85ae96a192e9c080ab4decb61"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"b17009598f62a5e71de4769fe1bd153eed2ac145","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                self.remove_external_gateway_ip(device,"},{"line_number":675,"context_line":"                                                common_utils.ip_to_cidr("},{"line_number":676,"context_line":"                                                    ip_addr[\u0027ip_address\u0027],"},{"line_number":677,"context_line":"                                                    prefixlen))"},{"line_number":678,"context_line":"        self.driver.unplug(interface_name,"},{"line_number":679,"context_line":"                           bridge\u003dself.agent_conf.external_network_bridge,"},{"line_number":680,"context_line":"                           namespace\u003dself.ns_name,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_376bb4f2","line":677,"in_reply_to":"bacf61ea_07f01ec8","updated":"2016-08-08 02:11:15.000000000","message":"OK, in the router namespace, the HA/legacy router gateway secondary IPs are now not set to the qg-device, which is handled here: bug #1609647. And the secondary IPs are always set to \u0027/32\u0027, so we cannot inherit the same prefixlen of the primary.\nSo here are some solutions:\n1. get and check the gateway IPs prefixlen, for primary use \u0027prefixlen\u0027 of the first item of fixed_port list supplied; for secondary IPs use `/32` instead.\n2. revert the patch: https://review.openstack.org/#/c/217564/ of bug #1488730","commit_id":"d5d3dec22f3acba85ae96a192e9c080ab4decb61"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"5e1bde56f49e66312073ab7827bfe1d5640f8f92","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                  ex_gw_port, interface_name)"},{"line_number":670,"context_line":"        device \u003d ip_lib.IPDevice(interface_name, namespace\u003dself.ns_name)"},{"line_number":671,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":672,"context_line":"            prefixlen \u003d ip_addr.get(\u0027prefixlen\u0027, 32)"},{"line_number":673,"context_line":"            self.remove_external_gateway_ip(device,"},{"line_number":674,"context_line":"                                            common_utils.ip_to_cidr("},{"line_number":675,"context_line":"                                                ip_addr[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_713b3fec","line":672,"updated":"2016-08-09 02:04:40.000000000","message":"32 is assuming this is IPv4, might be IPv6, None might be better as ip_to_cidr() will then add it.","commit_id":"45eb0649382319c898a2073145f5f35ff45cd1e3"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"55242708f59a6ae84d717983894fcfb306fba500","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                  ex_gw_port, interface_name)"},{"line_number":670,"context_line":"        device \u003d ip_lib.IPDevice(interface_name, namespace\u003dself.ns_name)"},{"line_number":671,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":672,"context_line":"            prefixlen \u003d ip_addr.get(\u0027prefixlen\u0027, 32)"},{"line_number":673,"context_line":"            self.remove_external_gateway_ip(device,"},{"line_number":674,"context_line":"                                            common_utils.ip_to_cidr("},{"line_number":675,"context_line":"                                                ip_addr[\u0027ip_address\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_357532f9","line":672,"in_reply_to":"9ad45d7e_713b3fec","updated":"2016-08-09 04:50:06.000000000","message":"Done","commit_id":"45eb0649382319c898a2073145f5f35ff45cd1e3"}]}
