)]}'
{"neutron/agent/l3/router_info.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"369f7bcf88c1b8a41a9effad98d584d7d79993e2","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                # mark the status as not changed. we can\u0027t remove it because"},{"line_number":329,"context_line":"                # that\u0027s how the caller determines that it was removed"},{"line_number":330,"context_line":"                fip_statuses[fip[\u0027id\u0027]] \u003d FLOATINGIP_STATUS_NOCHANGE"},{"line_number":331,"context_line":"        gw_cidrs \u003d self._get_gw_ips_cidr()"},{"line_number":332,"context_line":"        fips_to_remove \u003d ("},{"line_number":333,"context_line":"            ip_cidr for ip_cidr in existing_cidrs - new_cidrs - gw_cidrs"},{"line_number":334,"context_line":"            if common_utils.is_cidr_host(ip_cidr))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_c043c911","line":331,"updated":"2016-08-04 22:07:59.000000000","message":"Should move this to L305 with the others","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ecd6052aa7c00a2da1a48228f51351e10fe1623d","unresolved":false,"context_lines":[{"line_number":328,"context_line":"                # mark the status as not changed. we can\u0027t remove it because"},{"line_number":329,"context_line":"                # that\u0027s how the caller determines that it was removed"},{"line_number":330,"context_line":"                fip_statuses[fip[\u0027id\u0027]] \u003d FLOATINGIP_STATUS_NOCHANGE"},{"line_number":331,"context_line":"        gw_cidrs \u003d self._get_gw_ips_cidr()"},{"line_number":332,"context_line":"        fips_to_remove \u003d ("},{"line_number":333,"context_line":"            ip_cidr for ip_cidr in existing_cidrs - new_cidrs - gw_cidrs"},{"line_number":334,"context_line":"            if common_utils.is_cidr_host(ip_cidr))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_76a743bd","line":331,"in_reply_to":"bacf61ea_c043c911","updated":"2016-08-04 23:39:33.000000000","message":"Done","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"369f7bcf88c1b8a41a9effad98d584d7d79993e2","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def _get_gw_ips_cidr(self):"},{"line_number":343,"context_line":"        gw_cidrs \u003d set()"},{"line_number":344,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":345,"context_line":"        if not ex_gw_port:"},{"line_number":346,"context_line":"            return gw_cidrs"},{"line_number":347,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":348,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_40b99914","line":345,"updated":"2016-08-04 22:07:59.000000000","message":"nit: I would change this to \u0027if ex_gw_port:\u0027 and indent below, that way just a single return on L351","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a4cbf85c6c1fd435f8bcfba894ab95d1cdff590e","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def _get_gw_ips_cidr(self):"},{"line_number":343,"context_line":"        gw_cidrs \u003d set()"},{"line_number":344,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":345,"context_line":"        if not ex_gw_port:"},{"line_number":346,"context_line":"            return gw_cidrs"},{"line_number":347,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":348,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_d43708ae","line":345,"in_reply_to":"bacf61ea_167ec718","updated":"2016-08-05 00:15:15.000000000","message":"Just indent the for() loop, not the \u0027return gw_cidrs\u0027, that way it returns a set.","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ecd6052aa7c00a2da1a48228f51351e10fe1623d","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def _get_gw_ips_cidr(self):"},{"line_number":343,"context_line":"        gw_cidrs \u003d set()"},{"line_number":344,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":345,"context_line":"        if not ex_gw_port:"},{"line_number":346,"context_line":"            return gw_cidrs"},{"line_number":347,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":348,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_167ec718","line":345,"in_reply_to":"bacf61ea_40b99914","updated":"2016-08-04 23:39:33.000000000","message":"`existing_cidrs` and `new_cidrs` are all type of `set`, could a `set` type \u0027-\u0027 a `None` type ? It will return a None when no ex_gw_port as you suggested?","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"823c6d759e5807d4051237552de4c7a9e78a87b1","unresolved":false,"context_lines":[{"line_number":342,"context_line":"    def _get_gw_ips_cidr(self):"},{"line_number":343,"context_line":"        gw_cidrs \u003d set()"},{"line_number":344,"context_line":"        ex_gw_port \u003d self.get_ex_gw_port()"},{"line_number":345,"context_line":"        if not ex_gw_port:"},{"line_number":346,"context_line":"            return gw_cidrs"},{"line_number":347,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":348,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_3af76dd4","line":345,"in_reply_to":"bacf61ea_d43708ae","updated":"2016-08-05 01:37:20.000000000","message":"Done","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"369f7bcf88c1b8a41a9effad98d584d7d79993e2","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            return gw_cidrs"},{"line_number":347,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":348,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"},{"line_number":349,"context_line":"            if netaddr.IPAddress(ex_gw_ip).version \u003d\u003d 4:"},{"line_number":350,"context_line":"                gw_cidrs.add(common_utils.ip_to_cidr(ex_gw_ip))"},{"line_number":351,"context_line":"        return gw_cidrs"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_a0833555","line":349,"updated":"2016-08-04 22:07:59.000000000","message":"s/4/l3_constants.IP_VERSION_4","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"ecd6052aa7c00a2da1a48228f51351e10fe1623d","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            return gw_cidrs"},{"line_number":347,"context_line":"        for ip_addr in ex_gw_port[\u0027fixed_ips\u0027]:"},{"line_number":348,"context_line":"            ex_gw_ip \u003d ip_addr[\u0027ip_address\u0027]"},{"line_number":349,"context_line":"            if netaddr.IPAddress(ex_gw_ip).version \u003d\u003d 4:"},{"line_number":350,"context_line":"                gw_cidrs.add(common_utils.ip_to_cidr(ex_gw_ip))"},{"line_number":351,"context_line":"        return gw_cidrs"},{"line_number":352,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_9690f744","line":349,"in_reply_to":"bacf61ea_a0833555","updated":"2016-08-04 23:39:33.000000000","message":"Done","commit_id":"8f8f689b5b0eb9df4605f41daccf7da02c953d33"}]}
