)]}'
{"neutron/objects/common_types.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"023631500a5a4782826095977e3c3b287e22a59f","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        super(IpProtocolEnum, self).__init__("},{"line_number":140,"context_line":"            valid_values\u003dlist("},{"line_number":141,"context_line":"                itertools.chain("},{"line_number":142,"context_line":"                    n_const.IP_PROTOCOL_MAP.keys(),"},{"line_number":143,"context_line":"                    [str(v) for v in n_const.IP_PROTOCOL_MAP.values()]"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_695edc13","line":142,"updated":"2016-08-12 11:37:20.000000000","message":"hmm, now that I see this, shouldn\u0027t we be explicitly creating the list here?.\n\nWhat if the neutron_lib constant lib changes, the enumerator changes, and we get incompatible objects because we may have needed to bump a version.","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"49947b1233c84b1ddb116fe124f56fb9b1f4f3b1","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        super(IpProtocolEnum, self).__init__("},{"line_number":140,"context_line":"            valid_values\u003dlist("},{"line_number":141,"context_line":"                itertools.chain("},{"line_number":142,"context_line":"                    n_const.IP_PROTOCOL_MAP.keys(),"},{"line_number":143,"context_line":"                    [str(v) for v in n_const.IP_PROTOCOL_MAP.values()]"},{"line_number":144,"context_line":"                )"},{"line_number":145,"context_line":"            ),"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_49dcb874","line":142,"in_reply_to":"9ad45d7e_695edc13","updated":"2016-08-12 11:39:17.000000000","message":"Hm. In that case, unit tests will be broken in neutron, because we validate object hashes there. I guess it\u0027s a valid think to ask to follow up with. Not in this patch, but I hear you.","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"}],"neutron/objects/securitygroup.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d99848d164765a7eda523c8fbcd84b423f356008","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        ),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_need_translation \u003d {"},{"line_number":41,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_647655d8","line":42,"range":{"start_line":40,"start_character":4,"end_line":42,"end_character":5},"updated":"2016-08-11 08:47:55.000000000","message":"do we still need this translation?","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03894a24bb8e5081a2b01fc57e2843c4b41887b3","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        ),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_need_translation \u003d {"},{"line_number":41,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_e5a19a95","line":42,"range":{"start_line":40,"start_character":4,"end_line":42,"end_character":5},"in_reply_to":"9ad45d7e_647655d8","updated":"2016-08-11 10:54:59.000000000","message":"Nope. Victor, why do you add it here?..","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a71015801b24638ccefb7b015bd66ebadcad71b5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        ),"},{"line_number":38,"context_line":"    }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_need_translation \u003d {"},{"line_number":41,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":42,"context_line":"    }"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_5215bde2","line":42,"range":{"start_line":40,"start_character":4,"end_line":42,"end_character":5},"in_reply_to":"9ad45d7e_e5a19a95","updated":"2016-08-11 13:56:00.000000000","message":"Sorry, I found few things in the other patch that were missing in this one","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03894a24bb8e5081a2b01fc57e2843c4b41887b3","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(),"},{"line_number":84,"context_line":"    }"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    fields_need_translation \u003d {"},{"line_number":87,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":88,"context_line":"    }"},{"line_number":89,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_45c4e63e","line":86,"updated":"2016-08-11 10:54:59.000000000","message":"remove","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"03894a24bb8e5081a2b01fc57e2843c4b41887b3","unresolved":false,"context_lines":[{"line_number":112,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue),"},{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    fields_need_translation \u003d {"},{"line_number":116,"context_line":"        \u0027project_id\u0027: \u0027tenant_id\u0027"},{"line_number":117,"context_line":"    }"},{"line_number":118,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_25a8d276","line":115,"updated":"2016-08-11 10:54:59.000000000","message":"not needed.","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"0aca9272234800b7d263810466302b9aa3ca0347","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    synthetic_fields \u003d [\u0027is_default\u0027, \u0027rules\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    extra_filter_names \u003d {\u0027is_default\u0027}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_6500f866","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":44},"updated":"2016-08-11 15:25:00.000000000","message":"What about \u0027source_rules\u0027? shouldn\u0027t be also a synthetic field?","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"69baeae306466c56fbc47c39791ee004af348ca5","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    synthetic_fields \u003d [\u0027is_default\u0027, \u0027rules\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    extra_filter_names \u003d {\u0027is_default\u0027}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_8976b004","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":44},"in_reply_to":"9ad45d7e_50ef6b1d","updated":"2016-08-12 12:02:03.000000000","message":"we can add it later if necessary.\n\nMay be we can add a TODO/NOTE here ?","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e2d5a3131c72f4d98b0eca623ae3566b0e83a1b5","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    synthetic_fields \u003d [\u0027is_default\u0027, \u0027rules\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    extra_filter_names \u003d {\u0027is_default\u0027}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_ff9c3a5f","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":44},"in_reply_to":"9ad45d7e_64c9e35a","updated":"2016-08-12 12:25:08.000000000","message":"Well, at least a note to make sure if anybody looks at it , sees it in the database, but the object doesn\u0027t have it could be beneficial.\n\nBut I won\u0027t nitpick on this..","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1376a10d626cb8f3d600a401f998cd6d22dbc6b6","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    synthetic_fields \u003d [\u0027is_default\u0027, \u0027rules\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    extra_filter_names \u003d {\u0027is_default\u0027}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_50ef6b1d","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":44},"in_reply_to":"9ad45d7e_6500f866","updated":"2016-08-11 16:41:52.000000000","message":"I don\u0027t see where it\u0027s used right now, so I prefer not to expose it at all until there is a clear use case.","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"aa5dab263c5df6c7b77302e7d9b1b63b6d9b1ceb","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    synthetic_fields \u003d [\u0027is_default\u0027, \u0027rules\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    extra_filter_names \u003d {\u0027is_default\u0027}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_64c9e35a","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":44},"in_reply_to":"9ad45d7e_8976b004","updated":"2016-08-12 12:04:45.000000000","message":"Why would we have a TODO here? I am not sure there is a need so far.","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9139cfc1cc35e9d43fa8502f7103b6363401760c","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    fields_no_update \u003d [\u0027project_id\u0027, \u0027is_default\u0027]"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    synthetic_fields \u003d [\u0027is_default\u0027, \u0027rules\u0027]"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    extra_filter_names \u003d {\u0027is_default\u0027}"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_c2e4faad","line":42,"range":{"start_line":42,"start_character":39,"end_line":42,"end_character":44},"in_reply_to":"9ad45d7e_ff9c3a5f","updated":"2016-08-12 14:09:27.000000000","message":"Done","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"69baeae306466c56fbc47c39791ee004af348ca5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \u0027protocol\u0027: common_types.IpProtocolEnumField(nullable\u003dTrue),"},{"line_number":102,"context_line":"        \u0027port_range_min\u0027: common_types.PortRangeField(nullable\u003dTrue),"},{"line_number":103,"context_line":"        \u0027port_range_max\u0027: common_types.PortRangeField(nullable\u003dTrue),"},{"line_number":104,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue),"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    foreign_keys \u003d {\u0027security_group_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_0413c70e","line":104,"updated":"2016-08-12 12:02:03.000000000","message":"don\u0027t we want to expose revision_number from the standard attributes?\n\nhttps://github.com/openstack/neutron/blob/master/neutron/db/model_base.py#L165\n\nI think that\u0027s needed by kevin\u0027s patch.","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"210fbc433cefd700ba19e2b05b605ad454a99069","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \u0027protocol\u0027: common_types.IpProtocolEnumField(nullable\u003dTrue),"},{"line_number":102,"context_line":"        \u0027port_range_min\u0027: common_types.PortRangeField(nullable\u003dTrue),"},{"line_number":103,"context_line":"        \u0027port_range_max\u0027: common_types.PortRangeField(nullable\u003dTrue),"},{"line_number":104,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue),"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    foreign_keys \u003d {\u0027security_group_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_e48dd32b","line":104,"in_reply_to":"9ad45d7e_0413c70e","updated":"2016-08-12 12:03:59.000000000","message":"It\u0027s already part of any object that uses a model that has standard attributes:\n\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/extensions/standardattributes.py\nhttps://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L247","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"84573ede7eb33e1b03ff2da171c58b8eca79c231","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        \u0027protocol\u0027: common_types.IpProtocolEnumField(nullable\u003dTrue),"},{"line_number":102,"context_line":"        \u0027port_range_min\u0027: common_types.PortRangeField(nullable\u003dTrue),"},{"line_number":103,"context_line":"        \u0027port_range_max\u0027: common_types.PortRangeField(nullable\u003dTrue),"},{"line_number":104,"context_line":"        \u0027remote_ip_prefix\u0027: obj_fields.IPNetworkField(nullable\u003dTrue),"},{"line_number":105,"context_line":"    }"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    foreign_keys \u003d {\u0027security_group_id\u0027: \u0027id\u0027}"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_e41033ae","line":104,"in_reply_to":"9ad45d7e_e48dd32b","updated":"2016-08-12 12:06:28.000000000","message":"Ohh, true, I didn\u0027t remember that, makes perfect sense to have in base class.","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"}],"neutron/tests/unit/objects/test_common_types.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e2d5a3131c72f4d98b0eca623ae3566b0e83a1b5","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                str("},{"line_number":206,"context_line":"                    random.choice("},{"line_number":207,"context_line":"                        list("},{"line_number":208,"context_line":"                            set(range(constants.PORT_RANGE_MAX + 1)) -"},{"line_number":209,"context_line":"                            set(const.IP_PROTOCOL_MAP.values())"},{"line_number":210,"context_line":"                        )"},{"line_number":211,"context_line":"                    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_5f6c6636","line":208,"updated":"2016-08-12 12:25:08.000000000","message":"I believe it\u0027s mixed here.\n\nPORT_RANGES are for TCP/UDP port fields.\nWhile this IpProtocol is about the IP protocol number (TCP, UDP, IGMP, ICMP, STCP, etc..)\nI\u0027d avoid L202-L217\n\nHave a look here:\n\nhttps://github.com/openstack/neutron-lib/blob/master/neutron_lib/constants.py#L125","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"9139cfc1cc35e9d43fa8502f7103b6363401760c","unresolved":false,"context_lines":[{"line_number":205,"context_line":"                str("},{"line_number":206,"context_line":"                    random.choice("},{"line_number":207,"context_line":"                        list("},{"line_number":208,"context_line":"                            set(range(constants.PORT_RANGE_MAX + 1)) -"},{"line_number":209,"context_line":"                            set(const.IP_PROTOCOL_MAP.values())"},{"line_number":210,"context_line":"                        )"},{"line_number":211,"context_line":"                    )"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_02173255","line":208,"in_reply_to":"9ad45d7e_5f6c6636","updated":"2016-08-12 14:09:27.000000000","message":"Done","commit_id":"cd6a6f2fb88ddfccc6e756bd245f3d1846204ff2"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"3c7c96494a461e0e89e72e754a20d75780154323","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                [str(v) for v in const.IP_PROTOCOL_MAP.values()]"},{"line_number":197,"context_line":"            )"},{"line_number":198,"context_line":"        ]"},{"line_number":199,"context_line":"        self.coerce_bad_values \u003d [\u0027test\u0027, \u0027Udp\u0027, 256]"},{"line_number":200,"context_line":"        try:"},{"line_number":201,"context_line":"            # pick a random protocol number that is not in the map of supported"},{"line_number":202,"context_line":"            # protocols"}],"source_content_type":"text/x-python","patch_set":6,"id":"9ad45d7e_22497f8f","line":199,"range":{"start_line":199,"start_character":49,"end_line":199,"end_character":52},"updated":"2016-08-12 20:27:25.000000000","message":"nit: I\u0027d be better to use a constant or at least a variable to this","commit_id":"cb64ad10adc6eb59145f9848d8d8cb89d0da0f67"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"d632c6b6441489b5b4338583ae5311fe54be9570","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        except IndexError:"},{"line_number":214,"context_line":"            # stay paranoid and guard against the impossible future when all"},{"line_number":215,"context_line":"            # protocols are in the map"},{"line_number":216,"context_line":"            pass"},{"line_number":217,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values"},{"line_number":218,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ac969e8_013a9936","line":216,"updated":"2016-08-13 05:08:43.000000000","message":"wouldn\u0027t be better to fail in that case?","commit_id":"cb64ad10adc6eb59145f9848d8d8cb89d0da0f67"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"18632db18a2f28c607e7e357dc01dff04ac60b22","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        except IndexError:"},{"line_number":214,"context_line":"            # stay paranoid and guard against the impossible future when all"},{"line_number":215,"context_line":"            # protocols are in the map"},{"line_number":216,"context_line":"            pass"},{"line_number":217,"context_line":"        self.to_primitive_values \u003d self.coerce_good_values"},{"line_number":218,"context_line":"        self.from_primitive_values \u003d self.coerce_good_values"},{"line_number":219,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7ac969e8_5741f338","line":216,"in_reply_to":"7ac969e8_013a9936","updated":"2016-08-13 07:29:36.000000000","message":"That would mean a gate failure due to a change in neutron-lib, not sure.","commit_id":"cb64ad10adc6eb59145f9848d8d8cb89d0da0f67"}],"neutron/tests/unit/objects/test_securitygroup.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a78e8f7897fac766731bf584e248eb4712c6427b","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _test_class \u003d securitygroup.SecurityGroup"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(SecurityGroupDbObjTestCase, self).setUp()"},{"line_number":32,"context_line":"        for db_obj in self.db_objs:"},{"line_number":33,"context_line":"            for rule in db_obj[\u0027rules\u0027]:"},{"line_number":34,"context_line":"                # we either make it null, or create remote groups for each rule"},{"line_number":35,"context_line":"                # generated; we picked the former here"},{"line_number":36,"context_line":"                rule[\u0027remote_group_id\u0027] \u003d None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_is_default_True(self):"},{"line_number":39,"context_line":"        fields \u003d self.obj_fields[0].copy()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_722e37a6","line":36,"range":{"start_line":30,"start_character":0,"end_line":36,"end_character":46},"updated":"2016-08-10 16:27:21.000000000","message":"The way that I solved this optional but foreign constraint was with this:\n\nhttps://review.openstack.org/#/c/284738/51/neutron/tests/unit/objects/test_base.py@394","commit_id":"ebe344f61044c8eb4f3f3ce35a16dd460700b9b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1ed3841ed3f0f35eeabe1d39bef35a7fdab4bf10","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _test_class \u003d securitygroup.SecurityGroup"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(SecurityGroupDbObjTestCase, self).setUp()"},{"line_number":32,"context_line":"        for db_obj in self.db_objs:"},{"line_number":33,"context_line":"            for rule in db_obj[\u0027rules\u0027]:"},{"line_number":34,"context_line":"                # we either make it null, or create remote groups for each rule"},{"line_number":35,"context_line":"                # generated; we picked the former here"},{"line_number":36,"context_line":"                rule[\u0027remote_group_id\u0027] \u003d None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_is_default_True(self):"},{"line_number":39,"context_line":"        fields \u003d self.obj_fields[0].copy()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6e2c6799","line":36,"range":{"start_line":30,"start_character":0,"end_line":36,"end_character":46},"in_reply_to":"9ad45d7e_25ed72b7","updated":"2016-08-11 11:40:09.000000000","message":"Actually, it\u0027s not that easy, it requires more refactoring in the base test class. I will just add a todo here for that.","commit_id":"ebe344f61044c8eb4f3f3ce35a16dd460700b9b6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c089cef1b24f8666f3f5dc43d4ae4716119782ce","unresolved":false,"context_lines":[{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _test_class \u003d securitygroup.SecurityGroup"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        super(SecurityGroupDbObjTestCase, self).setUp()"},{"line_number":32,"context_line":"        for db_obj in self.db_objs:"},{"line_number":33,"context_line":"            for rule in db_obj[\u0027rules\u0027]:"},{"line_number":34,"context_line":"                # we either make it null, or create remote groups for each rule"},{"line_number":35,"context_line":"                # generated; we picked the former here"},{"line_number":36,"context_line":"                rule[\u0027remote_group_id\u0027] \u003d None"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    def test_is_default_True(self):"},{"line_number":39,"context_line":"        fields \u003d self.obj_fields[0].copy()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_25ed72b7","line":36,"range":{"start_line":30,"start_character":0,"end_line":36,"end_character":46},"in_reply_to":"9ad45d7e_722e37a6","updated":"2016-08-11 11:07:04.000000000","message":"Smart. Let me adopt it here.","commit_id":"ebe344f61044c8eb4f3f3ce35a16dd460700b9b6"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a78e8f7897fac766731bf584e248eb4712c6427b","unresolved":false,"context_lines":[{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    def test_is_default_False(self):"},{"line_number":58,"context_line":"        fields \u003d self.obj_fields[0].copy()"},{"line_number":59,"context_line":"        fields[\u0027is_default\u0027] \u003d False"},{"line_number":60,"context_line":"        sg_obj \u003d self._make_object(fields)"},{"line_number":61,"context_line":"        sg_obj.create()"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_92ce4b2c","line":59,"updated":"2016-08-10 16:27:21.000000000","message":"This line is not necessary or it has to be after object creation like\n\n        sg_obj \u003d self._make_object(fields)\n        sg_obj.is_default \u003d False\n        sg_obj.create()","commit_id":"ebe344f61044c8eb4f3f3ce35a16dd460700b9b6"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d99848d164765a7eda523c8fbcd84b423f356008","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.assertEqual(sg_obj, listed_obj)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":92,"context_line":"        # TODO(electrocucaracha) SecurityGroup is using SecurityGroupRule"},{"line_number":93,"context_line":"        # object to reload rules, which costs extra SQL query each time"},{"line_number":94,"context_line":"        # _load_is_default are called in get_object(s). SecurityGroup has"},{"line_number":95,"context_line":"        # defined relationship for SecurityGroupRules, so it should be possible"},{"line_number":96,"context_line":"        # to reuse side loaded values fo this. To be reworked in follow-up"},{"line_number":97,"context_line":"        # patch."},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_277f3f67","line":97,"range":{"start_line":92,"start_character":8,"end_line":97,"end_character":15},"updated":"2016-08-11 08:47:55.000000000","message":"Any more details why this test is not passing?","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f899f9c8655f6be0498cb803348d27421a031709","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.assertEqual(sg_obj, listed_obj)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":92,"context_line":"        # TODO(electrocucaracha) SecurityGroup is using SecurityGroupRule"},{"line_number":93,"context_line":"        # object to reload rules, which costs extra SQL query each time"},{"line_number":94,"context_line":"        # _load_is_default are called in get_object(s). SecurityGroup has"},{"line_number":95,"context_line":"        # defined relationship for SecurityGroupRules, so it should be possible"},{"line_number":96,"context_line":"        # to reuse side loaded values fo this. To be reworked in follow-up"},{"line_number":97,"context_line":"        # patch."},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_5f883371","line":97,"range":{"start_line":92,"start_character":8,"end_line":97,"end_character":15},"in_reply_to":"9ad45d7e_072ddbfd","updated":"2016-08-11 10:08:12.000000000","message":"I believe it\u0027s not fair to skip it, instead we should eagerly load the other model.","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"631ee286d23da8f321a48435d41bf122c9e21eb8","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        self.assertEqual(sg_obj, listed_obj)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":92,"context_line":"        # TODO(electrocucaracha) SecurityGroup is using SecurityGroupRule"},{"line_number":93,"context_line":"        # object to reload rules, which costs extra SQL query each time"},{"line_number":94,"context_line":"        # _load_is_default are called in get_object(s). SecurityGroup has"},{"line_number":95,"context_line":"        # defined relationship for SecurityGroupRules, so it should be possible"},{"line_number":96,"context_line":"        # to reuse side loaded values fo this. To be reworked in follow-up"},{"line_number":97,"context_line":"        # patch."},{"line_number":98,"context_line":"        pass"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_072ddbfd","line":97,"range":{"start_line":92,"start_character":8,"end_line":97,"end_character":15},"in_reply_to":"9ad45d7e_277f3f67","updated":"2016-08-11 08:55:34.000000000","message":"Ok, I see now, SecurityGroup does have the relationship but it is not lazy joined, so there has to be extra query to load the default_security_group.","commit_id":"fc75daac9f1bebd83bea5583975191ca3dc94198"}]}
