)]}'
{"neutron/db/l3_hamode_db.py":[{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"081a58872407fc092dee88c295f007cdf3a74b17","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":534,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"            if requested_ha_state:"},{"line_number":537,"context_line":"                # This will throw HANotEnoughAvailableAgents if there aren\u0027t"},{"line_number":538,"context_line":"                # enough l3 agents to handle this router."},{"line_number":539,"context_line":"                self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_5d56495c","line":536,"range":{"start_line":536,"start_character":12,"end_line":536,"end_character":34},"updated":"2016-08-08 03:56:45.000000000","message":"Is this line necessary? According to bug description if we migrate a non-HA router to HA, we had already done the job in Line 528.","commit_id":"a167a3e20a755d599284ea10ebac5a8f1925e7ea"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"773139f92f223d1de8ef3a14de0b47da488767ac","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":534,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"            if requested_ha_state:"},{"line_number":537,"context_line":"                # This will throw HANotEnoughAvailableAgents if there aren\u0027t"},{"line_number":538,"context_line":"                # enough l3 agents to handle this router."},{"line_number":539,"context_line":"                self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_f9aa2a18","line":536,"updated":"2016-08-04 11:45:48.000000000","message":"what if the request is for changing HA router to DVR+HA router?","commit_id":"a167a3e20a755d599284ea10ebac5a8f1925e7ea"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"48a57e9b0a247c08fa5a0cd1b11ae211bde60ad5","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":534,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"            if requested_ha_state:"},{"line_number":537,"context_line":"                # This will throw HANotEnoughAvailableAgents if there aren\u0027t"},{"line_number":538,"context_line":"                # enough l3 agents to handle this router."},{"line_number":539,"context_line":"                self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_827cc221","line":536,"range":{"start_line":536,"start_character":12,"end_line":536,"end_character":34},"in_reply_to":"9ad45d7e_dc3b3f9b","updated":"2016-08-08 14:24:28.000000000","message":"Thanks, this makes reasonable, we should not restrict user turn off HA when there are not enough agents.","commit_id":"a167a3e20a755d599284ea10ebac5a8f1925e7ea"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"23225b8632a0438f2a3a8b609487b7acffb83b9d","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":534,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"            if requested_ha_state:"},{"line_number":537,"context_line":"                # This will throw HANotEnoughAvailableAgents if there aren\u0027t"},{"line_number":538,"context_line":"                # enough l3 agents to handle this router."},{"line_number":539,"context_line":"                self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_b47c3721","line":536,"in_reply_to":"bacf61ea_54297b36","updated":"2016-08-04 11:58:52.000000000","message":"Thanks, I missed line 511","commit_id":"a167a3e20a755d599284ea10ebac5a8f1925e7ea"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"e1cca4c7c27bf58270bea9162c4a8e91fabf3419","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":534,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"            if requested_ha_state:"},{"line_number":537,"context_line":"                # This will throw HANotEnoughAvailableAgents if there aren\u0027t"},{"line_number":538,"context_line":"                # enough l3 agents to handle this router."},{"line_number":539,"context_line":"                self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_dc3b3f9b","line":536,"range":{"start_line":536,"start_character":12,"end_line":536,"end_character":34},"in_reply_to":"bacf61ea_5d56495c","updated":"2016-08-08 13:47:55.000000000","message":"Line 528 doesn\u0027t check how many agents are active (only that \u0027ha\u0027 is specified and is different from what is currently in the DB record). Also, removing this will invoke this code on the HA-to-non-HA path (i.e. disabling HA), which is definitely not something we want (why restrict the user if there aren\u0027t enough agents if he wants to turn HA *off*?","commit_id":"a167a3e20a755d599284ea10ebac5a8f1925e7ea"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"9543160030c85f0f8fe98f1efddaf2d58d223ab6","unresolved":false,"context_lines":[{"line_number":533,"context_line":"                        \u0027set router admin_state_up to False prior to upgrade.\u0027)"},{"line_number":534,"context_line":"                raise n_exc.BadRequest(resource\u003d\u0027router\u0027, msg\u003dmsg)"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":"            if requested_ha_state:"},{"line_number":537,"context_line":"                # This will throw HANotEnoughAvailableAgents if there aren\u0027t"},{"line_number":538,"context_line":"                # enough l3 agents to handle this router."},{"line_number":539,"context_line":"                self.get_number_of_agents_for_scheduling(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_54297b36","line":536,"in_reply_to":"bacf61ea_f9aa2a18","updated":"2016-08-04 11:55:42.000000000","message":"Updating an HA router (or even a legacy router) to DVR+HA is not allowed (the 4 \u0027if\u0027 blocks starting at lines 504 disallow it).","commit_id":"a167a3e20a755d599284ea10ebac5a8f1925e7ea"}]}