)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"541e43e966566b8ccc108cbff2381091612baa14","unresolved":false,"context_lines":[{"line_number":30,"context_line":"attributes from the model itself if the field is not present on the"},{"line_number":31,"context_line":"object."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Since there is no relationship in the database for the segmentation"},{"line_number":34,"context_line":"info, the object loading currently does not scale too well. For now,"},{"line_number":35,"context_line":"it\u0027s fine because we are going to use this object to propagate updates"},{"line_number":36,"context_line":"to agents, so no LIST operations with huge number of ports are expected"},{"line_number":37,"context_line":"to be executed yet. In the future, we should revisit how we load segment"},{"line_number":38,"context_line":"info into ports: we will either need to add relationships, making all"},{"line_number":39,"context_line":"port fetches slightly slower; or we will need to have a custom handler"},{"line_number":40,"context_line":"to load this info, that would be triggered on demand (similar to how"},{"line_number":41,"context_line":"QosPolicy objects currently load rules)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":44,"context_line":"Partially-Implements: blueprint push-notifications"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"5a8bc5a2_c9b76ef3","line":41,"range":{"start_line":33,"start_character":0,"end_line":41,"end_character":39},"updated":"2016-09-26 10:43:18.000000000","message":"Since relationship is added for PortBindingLevel, this paragraph is no longer true and accurate.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"484e55033376107ff9de19d256ae34711c45133b","unresolved":false,"context_lines":[{"line_number":30,"context_line":"attributes from the model itself if the field is not present on the"},{"line_number":31,"context_line":"object."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Since there is no relationship in the database for the segmentation"},{"line_number":34,"context_line":"info, the object loading currently does not scale too well. For now,"},{"line_number":35,"context_line":"it\u0027s fine because we are going to use this object to propagate updates"},{"line_number":36,"context_line":"to agents, so no LIST operations with huge number of ports are expected"},{"line_number":37,"context_line":"to be executed yet. In the future, we should revisit how we load segment"},{"line_number":38,"context_line":"info into ports: we will either need to add relationships, making all"},{"line_number":39,"context_line":"port fetches slightly slower; or we will need to have a custom handler"},{"line_number":40,"context_line":"to load this info, that would be triggered on demand (similar to how"},{"line_number":41,"context_line":"QosPolicy objects currently load rules)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":44,"context_line":"Partially-Implements: blueprint push-notifications"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"5a8bc5a2_e8a4ed4b","line":41,"range":{"start_line":33,"start_character":0,"end_line":41,"end_character":39},"in_reply_to":"5a8bc5a2_c4ef471c","updated":"2016-09-27 06:30:24.000000000","message":"Ok, sorry, I have missed the PortBindingLevel to NetworkSegment lacking relationship. I thought after adding PortBindingLevel to Port relationship is resolving the issue.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7d3c2e219d3a7101ef5144da27456d34b0f546f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"attributes from the model itself if the field is not present on the"},{"line_number":31,"context_line":"object."},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"Since there is no relationship in the database for the segmentation"},{"line_number":34,"context_line":"info, the object loading currently does not scale too well. For now,"},{"line_number":35,"context_line":"it\u0027s fine because we are going to use this object to propagate updates"},{"line_number":36,"context_line":"to agents, so no LIST operations with huge number of ports are expected"},{"line_number":37,"context_line":"to be executed yet. In the future, we should revisit how we load segment"},{"line_number":38,"context_line":"info into ports: we will either need to add relationships, making all"},{"line_number":39,"context_line":"port fetches slightly slower; or we will need to have a custom handler"},{"line_number":40,"context_line":"to load this info, that would be triggered on demand (similar to how"},{"line_number":41,"context_line":"QosPolicy objects currently load rules)."},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"Partially-Implements: blueprint adopt-oslo-versioned-objects-for-db"},{"line_number":44,"context_line":"Partially-Implements: blueprint push-notifications"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"5a8bc5a2_c4ef471c","line":41,"range":{"start_line":33,"start_character":0,"end_line":41,"end_character":39},"in_reply_to":"5a8bc5a2_c9b76ef3","updated":"2016-09-26 14:39:30.000000000","message":"No. This test fails because segment info is loaded by get_objects call because level resource does not have a relationship pointing to segment.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"}],"neutron/db/models/allowed_address_pair.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4aabecb9f6eab63d6719b25dfbe4e170a82c8a3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ad45d7e_ca26ad67","updated":"2016-08-09 06:57:42.000000000","message":"duplicated work in https://review.openstack.org/#/c/351793/4/neutron/db/models/allowed_address_pair.py","commit_id":"8fc951e56d54631bf5291bdd6707ebfbf385d77a"}],"neutron/db/models_v2.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1b7ffe0c9966f1e77a6a568a815e1f28f140435f","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                 fixed_ips\u003dNone, **kwargs):"},{"line_number":149,"context_line":"        super(Port, self).__init__(**kwargs)"},{"line_number":150,"context_line":"        self.id \u003d id"},{"line_number":151,"context_line":"        self.project_id \u003d project_id or tenant_id"},{"line_number":152,"context_line":"        self.name \u003d name"},{"line_number":153,"context_line":"        self.network_id \u003d network_id"},{"line_number":154,"context_line":"        self.mac_address \u003d mac_address"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_26623cae","line":151,"range":{"start_line":151,"start_character":26,"end_line":151,"end_character":49},"updated":"2016-08-12 17:25:12.000000000","message":"IMHO, this should be handle by another patch that deals with keystone-v3 effort[1]\n\n[1] https://blueprints.launchpad.net/neutron/+spec/keystone-v3","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3214fe560ed7fb4f4a0ec794a81220d3e6fa9b5e","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                 fixed_ips\u003dNone, **kwargs):"},{"line_number":149,"context_line":"        super(Port, self).__init__(**kwargs)"},{"line_number":150,"context_line":"        self.id \u003d id"},{"line_number":151,"context_line":"        self.project_id \u003d project_id or tenant_id"},{"line_number":152,"context_line":"        self.name \u003d name"},{"line_number":153,"context_line":"        self.network_id \u003d network_id"},{"line_number":154,"context_line":"        self.mac_address \u003d mac_address"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_85c0357e","line":151,"range":{"start_line":151,"start_character":26,"end_line":151,"end_character":49},"in_reply_to":"9ad45d7e_264ebc96","updated":"2016-08-12 20:36:34.000000000","message":"We can\u0027t land objects without tests passing!","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bc9f266b9162af83c206ab3bfdc3994037f7d3a7","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                 fixed_ips\u003dNone, **kwargs):"},{"line_number":149,"context_line":"        super(Port, self).__init__(**kwargs)"},{"line_number":150,"context_line":"        self.id \u003d id"},{"line_number":151,"context_line":"        self.project_id \u003d project_id or tenant_id"},{"line_number":152,"context_line":"        self.name \u003d name"},{"line_number":153,"context_line":"        self.network_id \u003d network_id"},{"line_number":154,"context_line":"        self.mac_address \u003d mac_address"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_c63ec028","line":151,"range":{"start_line":151,"start_character":26,"end_line":151,"end_character":49},"in_reply_to":"9ad45d7e_26623cae","updated":"2016-08-12 17:29:15.000000000","message":"Without it, I had tests failing, because model would not accept project_id as a keyword.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a6d0cc2e5a4103e3f73ab3bef9db10fdacc9eef8","unresolved":false,"context_lines":[{"line_number":148,"context_line":"                 fixed_ips\u003dNone, **kwargs):"},{"line_number":149,"context_line":"        super(Port, self).__init__(**kwargs)"},{"line_number":150,"context_line":"        self.id \u003d id"},{"line_number":151,"context_line":"        self.project_id \u003d project_id or tenant_id"},{"line_number":152,"context_line":"        self.name \u003d name"},{"line_number":153,"context_line":"        self.network_id \u003d network_id"},{"line_number":154,"context_line":"        self.mac_address \u003d mac_address"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_264ebc96","line":151,"range":{"start_line":151,"start_character":26,"end_line":151,"end_character":49},"in_reply_to":"9ad45d7e_c63ec028","updated":"2016-08-12 17:54:29.000000000","message":"I still feel, to land it faster it make more sense to have it in separate patch.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c84b9c4e6161c47ca2467ac198c52add4e05044b","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                 fixed_ips\u003dNone, **kwargs):"},{"line_number":117,"context_line":"        super(Port, self).__init__(**kwargs)"},{"line_number":118,"context_line":"        self.id \u003d id"},{"line_number":119,"context_line":"        self.project_id \u003d project_id or tenant_id"},{"line_number":120,"context_line":"        self.name \u003d name"},{"line_number":121,"context_line":"        self.network_id \u003d network_id"},{"line_number":122,"context_line":"        self.mac_address \u003d mac_address"}],"source_content_type":"text/x-python","patch_set":33,"id":"5a8bc5a2_0037114d","line":119,"range":{"start_line":119,"start_character":26,"end_line":119,"end_character":49},"updated":"2016-09-27 15:48:36.000000000","message":"This is probably overly defensive, but what if both tenant_id and project_id are given, but perhaps different (caller error)?","commit_id":"0b74da7a7b93c38ec741cf8f41a8128650ffa876"}],"neutron/objects/base.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c991cf7be0e1f3a9dba9fb8de24fd0cc655cb980","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                if not isinstance(synth_db_objs, list):"},{"line_number":477,"context_line":"                    synth_db_objs \u003d [synth_db_objs]"},{"line_number":478,"context_line":"                synth_objs \u003d [objclass._load_object(self.obj_context,"},{"line_number":479,"context_line":"                                objclass.modify_fields_from_db(obj))"},{"line_number":480,"context_line":"                              for obj in synth_db_objs]"},{"line_number":481,"context_line":"            else:"},{"line_number":482,"context_line":"                synth_objs \u003d objclass.get_objects("}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_07873713","side":"PARENT","line":479,"updated":"2016-08-12 16:50:52.000000000","message":"that one wasted some of my time: there is no need to convert because _load_object calls to modify_fields_from_db itself. Doing it twice fails for vif_details field in ports.","commit_id":"7c0f189309789ebcbd5c20c5a86835576ffb5db3"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a41857ee3d0b178a8615b61a823a64b505b14b5c","unresolved":false,"context_lines":[{"line_number":476,"context_line":"                if not isinstance(synth_db_objs, list):"},{"line_number":477,"context_line":"                    synth_db_objs \u003d [synth_db_objs]"},{"line_number":478,"context_line":"                synth_objs \u003d [objclass._load_object(self.obj_context,"},{"line_number":479,"context_line":"                                objclass.modify_fields_from_db(obj))"},{"line_number":480,"context_line":"                              for obj in synth_db_objs]"},{"line_number":481,"context_line":"            else:"},{"line_number":482,"context_line":"                synth_objs \u003d objclass.get_objects("}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_7e9331fb","side":"PARENT","line":479,"in_reply_to":"9ad45d7e_07873713","updated":"2016-08-14 09:00:34.000000000","message":"good catch!","commit_id":"7c0f189309789ebcbd5c20c5a86835576ffb5db3"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            else:"},{"line_number":490,"context_line":"                synth_objs \u003d objclass.get_objects("},{"line_number":491,"context_line":"                    self.obj_context, **{"},{"line_number":492,"context_line":"                        k: getattr(self, v) if v in self else db_obj.get(v)"},{"line_number":493,"context_line":"                        for k, v in foreign_keys.items()})"},{"line_number":494,"context_line":"            if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":495,"context_line":"                setattr(self, field, synth_objs[0] if synth_objs else None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_6ebb51c5","line":492,"range":{"start_line":492,"start_character":61,"end_line":492,"end_character":75},"updated":"2016-08-20 10:59:25.000000000","message":"Why you are trying to load smth from db_obj? what if db_obj is None?\nIn my understanding this else is going to be executed when db_obj is None or there is no synthetic field in db_obj.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":489,"context_line":"            else:"},{"line_number":490,"context_line":"                synth_objs \u003d objclass.get_objects("},{"line_number":491,"context_line":"                    self.obj_context, **{"},{"line_number":492,"context_line":"                        k: getattr(self, v) if v in self else db_obj.get(v)"},{"line_number":493,"context_line":"                        for k, v in foreign_keys.items()})"},{"line_number":494,"context_line":"            if isinstance(self.fields[field], obj_fields.ObjectField):"},{"line_number":495,"context_line":"                setattr(self, field, synth_objs[0] if synth_objs else None)"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_9b543122","line":492,"range":{"start_line":492,"start_character":61,"end_line":492,"end_character":75},"in_reply_to":"1ac06dbe_6ebb51c5","updated":"2016-08-24 16:37:19.000000000","message":"If we get here, we need to extract the foreign key. If a field with that name is not defined on the object, then we try to extract the key from the model. If both fail, then we fail too.\n\nThis is needed so that I can use foreign keys that are not part of the object but are only on the model.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"}],"neutron/objects/common_types.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1b7ffe0c9966f1e77a6a568a815e1f28f140435f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if not isinstance(value, six.string_types):"},{"line_number":72,"context_line":"            msg \u003d _(\"Field value %s is not a string\") % value"},{"line_number":73,"context_line":"            raise ValueError(msg)"},{"line_number":74,"context_line":"        if len(value) \u003e 255:"},{"line_number":75,"context_line":"            msg \u003d _(\"Domain name %s is too long\") % value"},{"line_number":76,"context_line":"            raise ValueError(msg)"},{"line_number":77,"context_line":"        return super(DomainName, self).coerce(obj, attr, value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_635ee677","line":74,"range":{"start_line":74,"start_character":24,"end_line":74,"end_character":27},"updated":"2016-08-12 17:25:12.000000000","message":"shouldn\u0027t be better to use a constant here[1]?\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/api/v2/attributes.py#L36","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0137c8cf64e1e568d9f24a02c27eb1bcf22717b3","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if not isinstance(value, six.string_types):"},{"line_number":72,"context_line":"            msg \u003d _(\"Field value %s is not a string\") % value"},{"line_number":73,"context_line":"            raise ValueError(msg)"},{"line_number":74,"context_line":"        if len(value) \u003e 255:"},{"line_number":75,"context_line":"            msg \u003d _(\"Domain name %s is too long\") % value"},{"line_number":76,"context_line":"            raise ValueError(msg)"},{"line_number":77,"context_line":"        return super(DomainName, self).coerce(obj, attr, value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_10881ae7","line":74,"range":{"start_line":74,"start_character":24,"end_line":74,"end_character":27},"in_reply_to":"9ad45d7e_06e578a7","updated":"2016-08-15 08:37:41.000000000","message":"I found a constant in tree that reflects the semantics.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"2b49bf31202af2c9ece06486236fe3e4ac0b4fee","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        if not isinstance(value, six.string_types):"},{"line_number":72,"context_line":"            msg \u003d _(\"Field value %s is not a string\") % value"},{"line_number":73,"context_line":"            raise ValueError(msg)"},{"line_number":74,"context_line":"        if len(value) \u003e 255:"},{"line_number":75,"context_line":"            msg \u003d _(\"Domain name %s is too long\") % value"},{"line_number":76,"context_line":"            raise ValueError(msg)"},{"line_number":77,"context_line":"        return super(DomainName, self).coerce(obj, attr, value)"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_06e578a7","line":74,"range":{"start_line":74,"start_character":24,"end_line":74,"end_character":27},"in_reply_to":"9ad45d7e_635ee677","updated":"2016-08-12 17:30:37.000000000","message":"Semantically, it\u0027s not exactly the same thing: the constant you referred to is for resource names in database, while here I need a max length of a valid domain name. That happen to be the same, but it\u0027s not good to reuse that constant. We could probably have another constant, but meh.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c44344aad2a1dee1baa70cece5476f65e2a95f7e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron._i18n import _"},{"line_number":23,"context_line":"from neutron.common import constants"},{"line_number":24,"context_line":"from neutron.extensions import dns as dns_ext"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class NeutronRangeConstrainedIntegerInvalidLimit(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":39,"id":"3a98d1f4_31b781d9","line":24,"updated":"2016-09-30 09:36:53.000000000","message":"one kitten dies every time we import extension code in a common place :P ;-)\n\nI wonder how many have I killed :-(","commit_id":"dcd78423aa9e3fda5234c22fc14b06064e65e689"}],"neutron/objects/db/api.py":[{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(ihrachys): consider moving the exception to a common place"},{"line_number":21,"context_line":"class TooManyResults(n_exc.NeutronException):"},{"line_number":22,"context_line":"    message \u003d _(\u0027Too many results for %(args)s.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_8b6df506","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":20},"updated":"2016-08-15 12:57:52.000000000","message":"TooManyResults imply \"whoah! I got 1024 results!!\", not \"I got 2 results!\"\n\nCan we rename to \"ExpectedSingleResult\" or at least clarify the error message? While we are at it, the error message could use a %d of \"how many results were found\".","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(ihrachys): consider moving the exception to a common place"},{"line_number":21,"context_line":"class TooManyResults(n_exc.NeutronException):"},{"line_number":22,"context_line":"    message \u003d _(\u0027Too many results for %(args)s.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_a5957541","line":21,"range":{"start_line":21,"start_character":6,"end_line":21,"end_character":20},"in_reply_to":"3ac371cc_8b6df506","updated":"2016-08-15 17:21:38.000000000","message":"Done","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def _safe_get_objects(context, model,"},{"line_number":71,"context_line":"                      expect_single\u003dTrue, ignore_missing\u003dFalse,"},{"line_number":72,"context_line":"                      **kwargs):"},{"line_number":73,"context_line":"    db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_0ebf53fc","line":71,"range":{"start_line":71,"start_character":42,"end_line":71,"end_character":57},"updated":"2016-08-15 12:57:52.000000000","message":"\u0027ignore_nonexisting\u0027?","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"def _safe_get_objects(context, model,"},{"line_number":71,"context_line":"                      expect_single\u003dTrue, ignore_missing\u003dFalse,"},{"line_number":72,"context_line":"                      **kwargs):"},{"line_number":73,"context_line":"    db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_c5aa3170","line":71,"range":{"start_line":71,"start_character":42,"end_line":71,"end_character":57},"in_reply_to":"3ac371cc_0ebf53fc","updated":"2016-08-15 17:21:38.000000000","message":"We used ignore_missing in other place of the code before for a similar goal. I won\u0027t update that.","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    return db_objs"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def update_object(context, model, values, **kwargs):"},{"line_number":85,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":86,"context_line":"        db_objs \u003d _safe_get_objects(context, model, **kwargs)"},{"line_number":87,"context_line":"        db_obj \u003d db_objs[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_ee1757eb","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":17},"updated":"2016-08-15 12:57:52.000000000","message":"An careless dev could easily pass \u0027expect_single\u0027 or \u0027ignore_missing\u0027 here and change what this function does entirely, so I suggest you add these parameters here (and to delete_objects, and to delete_object).","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    return db_objs"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"def update_object(context, model, values, **kwargs):"},{"line_number":85,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":86,"context_line":"        db_objs \u003d _safe_get_objects(context, model, **kwargs)"},{"line_number":87,"context_line":"        db_obj \u003d db_objs[0]"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_2e9ddd65","line":84,"range":{"start_line":84,"start_character":4,"end_line":84,"end_character":17},"in_reply_to":"3ac371cc_ee1757eb","updated":"2016-08-15 17:21:38.000000000","message":"You mean explicitly pass them into _safe_get_objects? I don\u0027t think it\u0027s worth it. Since when do we guard against careless developers?","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":103,"context_line":"def delete_object(context, model, ignore_missing\u003dFalse, **kwargs):"},{"line_number":104,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":105,"context_line":"        db_objs \u003d _safe_get_objects("},{"line_number":106,"context_line":"            context, model, ignore_missing\u003dignore_missing, **kwargs)"},{"line_number":107,"context_line":"        context.session.delete(db_objs[0])"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_0e5633d2","line":106,"updated":"2016-08-15 12:57:52.000000000","message":"Can \u0027expect_single\u0027 be explicit here?","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":103,"context_line":"def delete_object(context, model, ignore_missing\u003dFalse, **kwargs):"},{"line_number":104,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":105,"context_line":"        db_objs \u003d _safe_get_objects("},{"line_number":106,"context_line":"            context, model, ignore_missing\u003dignore_missing, **kwargs)"},{"line_number":107,"context_line":"        context.session.delete(db_objs[0])"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_cee7e9e2","line":106,"in_reply_to":"3ac371cc_0e5633d2","updated":"2016-08-15 17:21:38.000000000","message":"Why? The default is good enough. I don\u0027t see how it\u0027s better to pass it. The helper function is well isolated in this module. When people mess with behaviour for the helper, it\u0027s reasonable to expect they will be careful.","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d3a748a47e1711cf19e73fb34a41a9d22b912b58","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(ihrachys): consider moving the exception to a common place"},{"line_number":21,"context_line":"class ExpectedSingleResult(n_exc.NeutronException):"},{"line_number":22,"context_line":"    message \u003d _(\u0027Expected a single result for %(args)s, %(num)d fetched.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Common database operation implementations"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_d37fbe64","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":74},"updated":"2016-08-18 18:36:43.000000000","message":"This can be done two ways, either append these exception definitions to neutron/common/exceptions.py or have a common dir in objects like objects/common/exceptions.py which we can have to define all of them, I am fine either way but prefer latter one because we may not want to load unwanted exception everywhere we use. if you are convinced with my comment @line82 then this is actually not needed atm","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0b16b3c130f34c67cce94b9b15f65760cc4bf27","unresolved":false,"context_lines":[{"line_number":17,"context_line":"from neutron import manager"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# TODO(ihrachys): consider moving the exception to a common place"},{"line_number":21,"context_line":"class ExpectedSingleResult(n_exc.NeutronException):"},{"line_number":22,"context_line":"    message \u003d _(\u0027Expected a single result for %(args)s, %(num)d fetched.\u0027)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Common database operation implementations"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_6c554a1c","line":22,"range":{"start_line":20,"start_character":0,"end_line":22,"end_character":74},"in_reply_to":"3ac371cc_d37fbe64","updated":"2016-08-19 12:26:43.000000000","message":"Will move to a new module.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d3a748a47e1711cf19e73fb34a41a9d22b912b58","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                      **kwargs):"},{"line_number":73,"context_line":"    db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not db_objs and not ignore_missing:"},{"line_number":76,"context_line":"        key \u003d \", \".join([\u0027%s\u003d%s\u0027 % (key, value) for (key, value)"},{"line_number":77,"context_line":"                         in kwargs.items()])"},{"line_number":78,"context_line":"        raise n_exc.ObjectNotFound(id\u003d\"%s(%s)\" % (model.__name__, key))"},{"line_number":79,"context_line":"    if expect_single:"},{"line_number":80,"context_line":"        num \u003d len(db_objs)"},{"line_number":81,"context_line":"        if num \u003e 1:"},{"line_number":82,"context_line":"            raise ExpectedSingleResult({\u0027args\u0027: kwargs, \u0027num\u0027: num})"},{"line_number":83,"context_line":"    return db_objs"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_f3391af4","line":82,"range":{"start_line":75,"start_character":4,"end_line":82,"end_character":68},"updated":"2016-08-18 18:36:43.000000000","message":"I don\u0027t think we should write extra code to do stuff which can be achieved with libraries, it make things complicated, plus confusing some times, by adding indirections, it can be easily achieved by using sqlalchemy\u0027s one() which will handle both the if\u0027s in this function pretty well.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3dcc7b8aaf22db45964f4a1633141c9f231d1f92","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                      **kwargs):"},{"line_number":73,"context_line":"    db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not db_objs and not ignore_missing:"},{"line_number":76,"context_line":"        key \u003d \", \".join([\u0027%s\u003d%s\u0027 % (key, value) for (key, value)"},{"line_number":77,"context_line":"                         in kwargs.items()])"},{"line_number":78,"context_line":"        raise n_exc.ObjectNotFound(id\u003d\"%s(%s)\" % (model.__name__, key))"},{"line_number":79,"context_line":"    if expect_single:"},{"line_number":80,"context_line":"        num \u003d len(db_objs)"},{"line_number":81,"context_line":"        if num \u003e 1:"},{"line_number":82,"context_line":"            raise ExpectedSingleResult({\u0027args\u0027: kwargs, \u0027num\u0027: num})"},{"line_number":83,"context_line":"    return db_objs"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_020c5f93","line":82,"range":{"start_line":75,"start_character":4,"end_line":82,"end_character":68},"in_reply_to":"1ac06dbe_4c5e8e46","updated":"2016-08-19 12:45:42.000000000","message":"In the end, I don\u0027t really need most of this stuff, so I just reverted it to the original.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0b16b3c130f34c67cce94b9b15f65760cc4bf27","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                      **kwargs):"},{"line_number":73,"context_line":"    db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    if not db_objs and not ignore_missing:"},{"line_number":76,"context_line":"        key \u003d \", \".join([\u0027%s\u003d%s\u0027 % (key, value) for (key, value)"},{"line_number":77,"context_line":"                         in kwargs.items()])"},{"line_number":78,"context_line":"        raise n_exc.ObjectNotFound(id\u003d\"%s(%s)\" % (model.__name__, key))"},{"line_number":79,"context_line":"    if expect_single:"},{"line_number":80,"context_line":"        num \u003d len(db_objs)"},{"line_number":81,"context_line":"        if num \u003e 1:"},{"line_number":82,"context_line":"            raise ExpectedSingleResult({\u0027args\u0027: kwargs, \u0027num\u0027: num})"},{"line_number":83,"context_line":"    return db_objs"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_4c5e8e46","line":82,"range":{"start_line":75,"start_character":4,"end_line":82,"end_character":68},"in_reply_to":"3ac371cc_f3391af4","updated":"2016-08-19 12:26:43.000000000","message":"Agreed we should reuse some SQLAlchemy stuff here. Not agreeing that we don\u0027t need conversion for exceptions: the point of those function is, among other things, that they will return object specific exception and not SQLAlchemy exceptions where needed.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0b397b6a31c30c3c52ebcc816d30028629d4962e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        except exc.NoResultFound:"},{"line_number":73,"context_line":"            key \u003d \", \".join([\u0027%s\u003d%s\u0027 % (key, value) for (key, value)"},{"line_number":74,"context_line":"                             in kwargs.items()])"},{"line_number":75,"context_line":"            raise n_exc.ObjectNotFound(id\u003d\"%s(%s)\" % (model.__name__, key))"},{"line_number":76,"context_line":"    except exc.MultipleResultsFound:"},{"line_number":77,"context_line":"        raise obj_exc.ExpectedSingleResult(args\u003dkwargs)"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"1ac06dbe_c2cfe7b1","line":75,"updated":"2016-08-19 12:40:58.000000000","message":"Actually, those changes are out of scope completely. I will drop those.","commit_id":"a20483f42b6bdac5d5529cac24ee9c447ad20dd3"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0fdcf206d32d6367f0518f8e2b369d8cbd7c5b09","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        context.session.delete(db_obj)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# TODO(ihrachys): expose through objects API"},{"line_number":89,"context_line":"def delete_objects(context, model, **kwargs):"},{"line_number":90,"context_line":"    \u0027\u0027\u0027Delete matching objects, if any."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    This function does not raise exceptions if nothing matches."},{"line_number":93,"context_line":"    \u0027\u0027\u0027"},{"line_number":94,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":95,"context_line":"        db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":96,"context_line":"        for db_obj in db_objs:"},{"line_number":97,"context_line":"            context.session.delete(db_obj)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_69dcf846","line":97,"range":{"start_line":88,"start_character":0,"end_line":97,"end_character":42},"updated":"2016-08-24 22:52:19.000000000","message":"I would expect at least a single unit test for this added api, in object/test_base.py, that can be a follow up patch too.","commit_id":"2dabf992c096885b197be6225b4926525d6e7d4c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4c0ecc9c0e77d11b68a49477eb76743d6dbaf7a1","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        context.session.delete(db_obj)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"# TODO(ihrachys): expose through objects API"},{"line_number":89,"context_line":"def delete_objects(context, model, **kwargs):"},{"line_number":90,"context_line":"    \u0027\u0027\u0027Delete matching objects, if any."},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    This function does not raise exceptions if nothing matches."},{"line_number":93,"context_line":"    \u0027\u0027\u0027"},{"line_number":94,"context_line":"    with context.session.begin(subtransactions\u003dTrue):"},{"line_number":95,"context_line":"        db_objs \u003d get_objects(context, model, **kwargs)"},{"line_number":96,"context_line":"        for db_obj in db_objs:"},{"line_number":97,"context_line":"            context.session.delete(db_obj)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_207158a9","line":97,"range":{"start_line":88,"start_character":0,"end_line":97,"end_character":42},"in_reply_to":"1ac06dbe_69dcf846","updated":"2016-08-25 09:15:20.000000000","message":"Lemme add a todo for functional coverage for the whole model, plus some basic crud scenario for sqlite backend for those functions.","commit_id":"2dabf992c096885b197be6225b4926525d6e7d4c"},{"author":{"_account_id":5367,"name":"boden","email":"bodenvmw@gmail.com","username":"boden"},"change_message_id":"c84b9c4e6161c47ca2467ac198c52add4e05044b","unresolved":false,"context_lines":[{"line_number":89,"context_line":""},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"# TODO(ihrachys): expose through objects API"},{"line_number":92,"context_line":"def delete_objects(context, model, **kwargs):"},{"line_number":93,"context_line":"    \u0027\u0027\u0027Delete matching objects, if any."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    This function does not raise exceptions if nothing matches."}],"source_content_type":"text/x-python","patch_set":33,"id":"5a8bc5a2_20616d05","line":92,"range":{"start_line":92,"start_character":4,"end_line":92,"end_character":18},"updated":"2016-09-27 15:48:36.000000000","message":"Based on your TODO does that mean its going away (moving)? If so maybe this should be private?","commit_id":"0b74da7a7b93c38ec741cf8f41a8128650ffa876"}],"neutron/objects/extensions/port_security.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d1c2e86ae6cead61d03bac8c00668891c0a16e92","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    foreign_keys \u003d {"},{"line_number":27,"context_line":"        \u0027Port\u0027: {\u0027id\u0027: \u0027id\u0027},"},{"line_number":28,"context_line":"        \u0027Network\u0027: {\u0027id\u0027: \u0027id\u0027},"},{"line_number":29,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_4ce383d9","line":28,"range":{"start_line":28,"start_character":7,"end_line":28,"end_character":32},"updated":"2016-09-02 00:07:54.000000000","message":"I have a question here we just have one id in fields and two foreign keys, so mean id in fields can be network or port id ? but what differentiates them,?","commit_id":"75e33c94ca0c3547fad0aa2f7815b5d747e33210"}],"neutron/objects/ports.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"70855487e1f48b53d7bbe6bc7428cae3f06ac005","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields \u003d {"},{"line_number":34,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":35,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        # TODO(ihrachys) to convert to a proper structure"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_71c5835a","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":14},"updated":"2016-08-05 07:01:15.000000000","message":"In port RPC structure, this is called host_id.","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5aee580c8e99e57df71e5271e73746a8854dd764","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields \u003d {"},{"line_number":34,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":35,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        # TODO(ihrachys) to convert to a proper structure"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_efaceea0","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":14},"in_reply_to":"bacf61ea_71c5835a","updated":"2016-08-05 08:18:30.000000000","message":"Good for them. We won\u0027t map the object directly to those (obsolete) messages, we will change the payload.","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"810658a892c5c9e2f24cd63c0d32d7b681aa9e4d","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    fields \u003d {"},{"line_number":34,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":35,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        # TODO(ihrachys) to convert to a proper structure"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_5922c102","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":14},"in_reply_to":"bacf61ea_efaceea0","updated":"2016-08-12 13:24:17.000000000","message":"I agree with ihar :), we should stick to whatever is in DB in this case.","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"338233e138b15992e1b8dcd476dc0f08dc4849a5","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        # TODO(ihrachys) to convert to a proper structure"},{"line_number":39,"context_line":"        \u0027vif_details\u0027: obj_fields.StringField(),"},{"line_number":40,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_316f9d2c","line":38,"updated":"2016-08-04 20:06:19.000000000","message":"Should be handled before we merge.","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"810658a892c5c9e2f24cd63c0d32d7b681aa9e4d","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":36,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":37,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":38,"context_line":"        # TODO(ihrachys) to convert to a proper structure"},{"line_number":39,"context_line":"        \u0027vif_details\u0027: obj_fields.StringField(),"},{"line_number":40,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":41,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f95e1578","line":38,"in_reply_to":"bacf61ea_316f9d2c","updated":"2016-08-12 13:24:17.000000000","message":"Enums I guess ?","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"810658a892c5c9e2f24cd63c0d32d7b681aa9e4d","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    # TODO(rossella_s): get rid of it once we switch the db model to using"},{"line_number":67,"context_line":"    # custom types."},{"line_number":68,"context_line":"    @classmethod"},{"line_number":69,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":70,"context_line":"        result \u003d super(IPAllocation, cls).modify_fields_to_db(fields)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_994a79ab","line":67,"updated":"2016-08-12 13:24:17.000000000","message":"I need to ask: what\u0027s that about custom types?","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"70855487e1f48b53d7bbe6bc7428cae3f06ac005","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \u0027fixed_ips\u0027: obj_fields.ListOfObjectsField("},{"line_number":110,"context_line":"            \u0027IPAllocation\u0027, nullable\u003dTrue"},{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    synthetic_fields \u003d [\u0027allowed_address_pairs\u0027, \u0027fixed_ips\u0027, \u0027binding\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_117527ca","line":112,"updated":"2016-08-05 07:01:15.000000000","message":"More fields to be considered (extensions):\n- port_security_enabled\n- dns_name (dns, PortDNS model)\n- extra_dhcp_opts\n- dns_assignment\n- security_groups\n- qos_policy_binding\n- distributed_port_binding?\n- trunk_port\n- sub_port","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5aee580c8e99e57df71e5271e73746a8854dd764","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \u0027fixed_ips\u0027: obj_fields.ListOfObjectsField("},{"line_number":110,"context_line":"            \u0027IPAllocation\u0027, nullable\u003dTrue"},{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    synthetic_fields \u003d [\u0027allowed_address_pairs\u0027, \u0027fixed_ips\u0027, \u0027binding\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_ead21cd0","line":112,"in_reply_to":"bacf61ea_117527ca","updated":"2016-08-05 08:18:30.000000000","message":"Will add TODO and will handle it in next PSes.","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"810658a892c5c9e2f24cd63c0d32d7b681aa9e4d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        \u0027fixed_ips\u0027: obj_fields.ListOfObjectsField("},{"line_number":110,"context_line":"            \u0027IPAllocation\u0027, nullable\u003dTrue"},{"line_number":111,"context_line":"        ),"},{"line_number":112,"context_line":"    }"},{"line_number":113,"context_line":""},{"line_number":114,"context_line":"    synthetic_fields \u003d [\u0027allowed_address_pairs\u0027, \u0027fixed_ips\u0027, \u0027binding\u0027]"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f993b5fe","line":112,"in_reply_to":"bacf61ea_ead21cd0","updated":"2016-08-12 13:24:17.000000000","message":"How\u0027s that handled (extension installed vs not installed? ) ?","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4aabecb9f6eab63d6719b25dfbe4e170a82c8a3e","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        \u0027security\u0027"},{"line_number":129,"context_line":"    ]"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    fields_need_translation \u003d {"},{"line_number":132,"context_line":"        \u0027binding\u0027: \u0027port_binding\u0027,"},{"line_number":133,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":134,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_ca822d00","line":131,"range":{"start_line":131,"start_character":4,"end_line":131,"end_character":27},"updated":"2016-08-09 06:57:42.000000000","message":"probably project_id: tenant_id as well, need to check if tenant_id  is still used anywhere.","commit_id":"8fc951e56d54631bf5291bdd6707ebfbf385d77a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"301864ec64ef84fcc57443095bbb7ce78ddac379","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027router_id\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_930e0d8a","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":30},"updated":"2016-08-11 20:49:28.000000000","message":"primary_keys \u003d [\u0027port_id\u0027, \u0027host\u0027] according to model definition in https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/models.py#L81-L95","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"def1447b34ec2b9aed8a16b54d63de2fcb50d71e","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        \u0027router_id\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":73,"context_line":"    }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_56f8da49","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":30},"in_reply_to":"9ad45d7e_930e0d8a","updated":"2016-08-12 10:05:40.000000000","message":"Nice catch!","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"301864ec64ef84fcc57443095bbb7ce78ddac379","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":139,"context_line":"class Port(base.NeutronDbObject):"},{"line_number":140,"context_line":"    # Version 1.0: Initial version"},{"line_number":141,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    db_model \u003d models_v2.Port"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":147,"context_line":"        \u0027project_id\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":148,"context_line":"        \u0027name\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":149,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":150,"context_line":"        \u0027mac_address\u0027: common_types.MACAddressField(),"},{"line_number":151,"context_line":"        \u0027admin_state_up\u0027: obj_fields.BooleanField(),"},{"line_number":152,"context_line":"        \u0027device_id\u0027: obj_fields.StringField(),"},{"line_number":153,"context_line":"        \u0027device_owner\u0027: obj_fields.StringField(),"},{"line_number":154,"context_line":"        \u0027status\u0027: obj_fields.StringField(),"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        \u0027allowed_address_pairs\u0027: obj_fields.ListOfObjectsField("},{"line_number":157,"context_line":"            \u0027AllowedAddressPair\u0027, nullable\u003dTrue"},{"line_number":158,"context_line":"        ),"},{"line_number":159,"context_line":"        \u0027binding\u0027: obj_fields.ObjectField("},{"line_number":160,"context_line":"            \u0027PortBinding\u0027, nullable\u003dTrue"},{"line_number":161,"context_line":"        ),"},{"line_number":162,"context_line":"        \u0027dhcp_options\u0027: obj_fields.ListOfObjectsField("},{"line_number":163,"context_line":"            \u0027ExtraDhcpOpt\u0027, nullable\u003dTrue"},{"line_number":164,"context_line":"        ),"},{"line_number":165,"context_line":"        \u0027distributed_binding\u0027: obj_fields.ObjectField("},{"line_number":166,"context_line":"            \u0027DistributedPortBinding\u0027, nullable\u003dTrue"},{"line_number":167,"context_line":"        ),"},{"line_number":168,"context_line":"        \u0027dns\u0027: obj_fields.ObjectField(\u0027PortDNS\u0027, nullable\u003dTrue),"},{"line_number":169,"context_line":"        \u0027fixed_ips\u0027: obj_fields.ListOfObjectsField("},{"line_number":170,"context_line":"            \u0027IPAllocation\u0027, nullable\u003dTrue"},{"line_number":171,"context_line":"        ),"},{"line_number":172,"context_line":"        # TODO(ihrachys): consider converting to boolean"},{"line_number":173,"context_line":"        \u0027security\u0027: obj_fields.ObjectField("},{"line_number":174,"context_line":"            \u0027PortSecurity\u0027, nullable\u003dTrue"},{"line_number":175,"context_line":"        ),"},{"line_number":176,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":177,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # TODO(ihrachys): consider adding a \u0027dns_assignment\u0027 fully synthetic"},{"line_number":180,"context_line":"        # field in later object iterations"},{"line_number":181,"context_line":"    }"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    synthetic_fields \u003d ["},{"line_number":184,"context_line":"        \u0027allowed_address_pairs\u0027,"},{"line_number":185,"context_line":"        \u0027binding\u0027,"},{"line_number":186,"context_line":"        \u0027dhcp_options\u0027,"},{"line_number":187,"context_line":"        \u0027distributed_binding\u0027,"},{"line_number":188,"context_line":"        \u0027dns\u0027,"},{"line_number":189,"context_line":"        \u0027fixed_ips\u0027,"},{"line_number":190,"context_line":"        \u0027qos_policy_id\u0027,"},{"line_number":191,"context_line":"        \u0027security\u0027,"},{"line_number":192,"context_line":"        \u0027security_group_id\u0027,"},{"line_number":193,"context_line":"    ]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    fields_need_translation \u003d {"},{"line_number":196,"context_line":"        \u0027binding\u0027: \u0027port_binding\u0027,"},{"line_number":197,"context_line":"        \u0027dhcp_options\u0027: \u0027dhcp_opts\u0027,"},{"line_number":198,"context_line":"        \u0027distributed_binding\u0027: \u0027distributed_port_binding\u0027,"},{"line_number":199,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def create(self):"},{"line_number":203,"context_line":"        fields \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_0efe74ad","line":200,"range":{"start_line":140,"start_character":2,"end_line":200,"end_character":5},"updated":"2016-08-11 20:49:28.000000000","message":"missing primary key and foreignkey here? atleast id must be mentioned as primary key ? or does it know by default ?","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"def1447b34ec2b9aed8a16b54d63de2fcb50d71e","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"@obj_base.VersionedObjectRegistry.register"},{"line_number":139,"context_line":"class Port(base.NeutronDbObject):"},{"line_number":140,"context_line":"    # Version 1.0: Initial version"},{"line_number":141,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"    db_model \u003d models_v2.Port"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":"    fields \u003d {"},{"line_number":146,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"},{"line_number":147,"context_line":"        \u0027project_id\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":148,"context_line":"        \u0027name\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":149,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":150,"context_line":"        \u0027mac_address\u0027: common_types.MACAddressField(),"},{"line_number":151,"context_line":"        \u0027admin_state_up\u0027: obj_fields.BooleanField(),"},{"line_number":152,"context_line":"        \u0027device_id\u0027: obj_fields.StringField(),"},{"line_number":153,"context_line":"        \u0027device_owner\u0027: obj_fields.StringField(),"},{"line_number":154,"context_line":"        \u0027status\u0027: obj_fields.StringField(),"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        \u0027allowed_address_pairs\u0027: obj_fields.ListOfObjectsField("},{"line_number":157,"context_line":"            \u0027AllowedAddressPair\u0027, nullable\u003dTrue"},{"line_number":158,"context_line":"        ),"},{"line_number":159,"context_line":"        \u0027binding\u0027: obj_fields.ObjectField("},{"line_number":160,"context_line":"            \u0027PortBinding\u0027, nullable\u003dTrue"},{"line_number":161,"context_line":"        ),"},{"line_number":162,"context_line":"        \u0027dhcp_options\u0027: obj_fields.ListOfObjectsField("},{"line_number":163,"context_line":"            \u0027ExtraDhcpOpt\u0027, nullable\u003dTrue"},{"line_number":164,"context_line":"        ),"},{"line_number":165,"context_line":"        \u0027distributed_binding\u0027: obj_fields.ObjectField("},{"line_number":166,"context_line":"            \u0027DistributedPortBinding\u0027, nullable\u003dTrue"},{"line_number":167,"context_line":"        ),"},{"line_number":168,"context_line":"        \u0027dns\u0027: obj_fields.ObjectField(\u0027PortDNS\u0027, nullable\u003dTrue),"},{"line_number":169,"context_line":"        \u0027fixed_ips\u0027: obj_fields.ListOfObjectsField("},{"line_number":170,"context_line":"            \u0027IPAllocation\u0027, nullable\u003dTrue"},{"line_number":171,"context_line":"        ),"},{"line_number":172,"context_line":"        # TODO(ihrachys): consider converting to boolean"},{"line_number":173,"context_line":"        \u0027security\u0027: obj_fields.ObjectField("},{"line_number":174,"context_line":"            \u0027PortSecurity\u0027, nullable\u003dTrue"},{"line_number":175,"context_line":"        ),"},{"line_number":176,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":177,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # TODO(ihrachys): consider adding a \u0027dns_assignment\u0027 fully synthetic"},{"line_number":180,"context_line":"        # field in later object iterations"},{"line_number":181,"context_line":"    }"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"    synthetic_fields \u003d ["},{"line_number":184,"context_line":"        \u0027allowed_address_pairs\u0027,"},{"line_number":185,"context_line":"        \u0027binding\u0027,"},{"line_number":186,"context_line":"        \u0027dhcp_options\u0027,"},{"line_number":187,"context_line":"        \u0027distributed_binding\u0027,"},{"line_number":188,"context_line":"        \u0027dns\u0027,"},{"line_number":189,"context_line":"        \u0027fixed_ips\u0027,"},{"line_number":190,"context_line":"        \u0027qos_policy_id\u0027,"},{"line_number":191,"context_line":"        \u0027security\u0027,"},{"line_number":192,"context_line":"        \u0027security_group_id\u0027,"},{"line_number":193,"context_line":"    ]"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"    fields_need_translation \u003d {"},{"line_number":196,"context_line":"        \u0027binding\u0027: \u0027port_binding\u0027,"},{"line_number":197,"context_line":"        \u0027dhcp_options\u0027: \u0027dhcp_opts\u0027,"},{"line_number":198,"context_line":"        \u0027distributed_binding\u0027: \u0027distributed_port_binding\u0027,"},{"line_number":199,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":200,"context_line":"    }"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def create(self):"},{"line_number":203,"context_line":"        fields \u003d self.obj_get_changes()"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_76807e8c","line":200,"range":{"start_line":140,"start_character":2,"end_line":200,"end_character":5},"in_reply_to":"9ad45d7e_0efe74ad","updated":"2016-08-12 10:05:40.000000000","message":"foreignkeys would be used to link the port object to some other object thru a relationship. I don\u0027t think it applies to the object because port is the 1st order resource.\n\nAs for primary keys, the base class already defines \u0027id\u0027 as the default primary key: https://github.com/openstack/neutron/blob/master/neutron/objects/base.py#L260","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"301864ec64ef84fcc57443095bbb7ce78ddac379","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"},{"line_number":226,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":227,"context_line":"            obj_db_api.delete_objects("},{"line_number":228,"context_line":"                self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":229,"context_line":"                ignore_missing\u003dTrue,"},{"line_number":230,"context_line":"                port_id\u003dself.id,"},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":"            if qos_policy_id:"},{"line_number":233,"context_line":"                obj_db_api.create_object("},{"line_number":234,"context_line":"                    self.obj_context, qos_models.QosPortPolicyBinding,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_0ebf94aa","line":231,"range":{"start_line":227,"start_character":11,"end_line":231,"end_character":13},"updated":"2016-08-11 20:49:28.000000000","message":"should\u0027nt there be a check if port is already attached to a policy ? calling delete when port isn\u0027t attached to any policy does not sounds good","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"def1447b34ec2b9aed8a16b54d63de2fcb50d71e","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"},{"line_number":226,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":227,"context_line":"            obj_db_api.delete_objects("},{"line_number":228,"context_line":"                self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":229,"context_line":"                ignore_missing\u003dTrue,"},{"line_number":230,"context_line":"                port_id\u003dself.id,"},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":"            if qos_policy_id:"},{"line_number":233,"context_line":"                obj_db_api.create_object("},{"line_number":234,"context_line":"                    self.obj_context, qos_models.QosPortPolicyBinding,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_56545a20","line":231,"range":{"start_line":227,"start_character":11,"end_line":231,"end_character":13},"in_reply_to":"9ad45d7e_0ebf94aa","updated":"2016-08-12 10:05:40.000000000","message":"What\u0027s the actual deal with cleaning up any existing attachments before attaching it to a new group?","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"02c070ad96881db23d8434a80318c9c148eedd4a","unresolved":false,"context_lines":[{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"},{"line_number":226,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":227,"context_line":"            obj_db_api.delete_objects("},{"line_number":228,"context_line":"                self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":229,"context_line":"                ignore_missing\u003dTrue,"},{"line_number":230,"context_line":"                port_id\u003dself.id,"},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":"            if qos_policy_id:"},{"line_number":233,"context_line":"                obj_db_api.create_object("},{"line_number":234,"context_line":"                    self.obj_context, qos_models.QosPortPolicyBinding,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_ccf0a4cc","line":231,"range":{"start_line":227,"start_character":11,"end_line":231,"end_character":13},"in_reply_to":"9ad45d7e_56545a20","updated":"2016-08-12 16:32:24.000000000","message":"anyway it would cost a db transaction either to check or delete it, so may delete is fine (assuming only one policy can be attached to port).","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"301864ec64ef84fcc57443095bbb7ce78ddac379","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                port_id\u003dself.id,"},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":"            if qos_policy_id:"},{"line_number":233,"context_line":"                obj_db_api.create_object("},{"line_number":234,"context_line":"                    self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":235,"context_line":"                    {\u0027port_id\u0027: self.id, \u0027policy_id\u0027: qos_policy_id}"},{"line_number":236,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_4e698cf8","line":233,"range":{"start_line":233,"start_character":16,"end_line":233,"end_character":41},"updated":"2016-08-11 20:49:28.000000000","message":"I see QoSPortPolicyBinding does not have object implementation at the moment. and its okay to use direct object.db.api, consider adding a note or todo if there is plan to implement QoSPortPolicyBinding and using that instead of direct api.","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"def1447b34ec2b9aed8a16b54d63de2fcb50d71e","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                port_id\u003dself.id,"},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":"            if qos_policy_id:"},{"line_number":233,"context_line":"                obj_db_api.create_object("},{"line_number":234,"context_line":"                    self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":235,"context_line":"                    {\u0027port_id\u0027: self.id, \u0027policy_id\u0027: qos_policy_id}"},{"line_number":236,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_f6390ef4","line":233,"range":{"start_line":233,"start_character":16,"end_line":233,"end_character":41},"in_reply_to":"9ad45d7e_4e698cf8","updated":"2016-08-12 10:05:40.000000000","message":"Lines 223-225 capture just that.","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"02c070ad96881db23d8434a80318c9c148eedd4a","unresolved":false,"context_lines":[{"line_number":230,"context_line":"                port_id\u003dself.id,"},{"line_number":231,"context_line":"            )"},{"line_number":232,"context_line":"            if qos_policy_id:"},{"line_number":233,"context_line":"                obj_db_api.create_object("},{"line_number":234,"context_line":"                    self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":235,"context_line":"                    {\u0027port_id\u0027: self.id, \u0027policy_id\u0027: qos_policy_id}"},{"line_number":236,"context_line":"                )"}],"source_content_type":"text/x-python","patch_set":9,"id":"9ad45d7e_0cb91ced","line":233,"range":{"start_line":233,"start_character":16,"end_line":233,"end_character":41},"in_reply_to":"9ad45d7e_f6390ef4","updated":"2016-08-12 16:32:24.000000000","message":"ok thanks !","commit_id":"631b70707228a18c57b19eda545870754b50692c"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":63,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":64,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":65,"context_line":"        # TODO(ihrachys) to convert to a proper structure"},{"line_number":66,"context_line":"        \u0027vif_details\u0027: obj_fields.StringField(),"},{"line_number":67,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":68,"context_line":"        # NOTE(ihrachys): Fields below are specific to this type of binding. In"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_7c95f386","line":65,"updated":"2016-08-12 13:34:49.000000000","message":"finally left to a later patch?, or do you still want to address it in this one?","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd3eb3e746473b5ffecb68b29f4b023a5846cd56","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":63,"context_line":"        \u0027profile\u0027: obj_fields.StringField(),"},{"line_number":64,"context_line":"        \u0027vif_type\u0027: obj_fields.StringField(),"},{"line_number":65,"context_line":"        # TODO(ihrachys) to convert to a proper structure"},{"line_number":66,"context_line":"        \u0027vif_details\u0027: obj_fields.StringField(),"},{"line_number":67,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":68,"context_line":"        # NOTE(ihrachys): Fields below are specific to this type of binding. In"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_8d687389","line":65,"in_reply_to":"9ad45d7e_7c95f386","updated":"2016-08-12 14:18:06.000000000","message":"No, I want to handle it here.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # TODO(rossella_s): get rid of it once we switch the db model to using"},{"line_number":99,"context_line":"    # custom types."},{"line_number":100,"context_line":"    @classmethod"},{"line_number":101,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":102,"context_line":"        result \u003d super(IPAllocation, cls).modify_fields_to_db(fields)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_dcd33f5e","line":99,"updated":"2016-08-12 13:34:49.000000000","message":"question replay: what\u0027s this about custom types?","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"27c69653f946e2cc2c90d6b0fd0413ba76835b4a","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # TODO(rossella_s): get rid of it once we switch the db model to using"},{"line_number":99,"context_line":"    # custom types."},{"line_number":100,"context_line":"    @classmethod"},{"line_number":101,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":102,"context_line":"        result \u003d super(IPAllocation, cls).modify_fields_to_db(fields)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_b1ff89a9","line":99,"in_reply_to":"9ad45d7e_6d1fff09","updated":"2016-08-12 16:23:46.000000000","message":"Understood, thank you :)","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd3eb3e746473b5ffecb68b29f4b023a5846cd56","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"    # TODO(rossella_s): get rid of it once we switch the db model to using"},{"line_number":99,"context_line":"    # custom types."},{"line_number":100,"context_line":"    @classmethod"},{"line_number":101,"context_line":"    def modify_fields_to_db(cls, fields):"},{"line_number":102,"context_line":"        result \u003d super(IPAllocation, cls).modify_fields_to_db(fields)"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_6d1fff09","line":99,"in_reply_to":"9ad45d7e_dcd33f5e","updated":"2016-08-12 14:18:06.000000000","message":"objects use netaddr.* types for fields, but we store strings in database. Until we switch our models to custom types like in neutron/db/sqlalchemytypes.py, we will need to keep it here.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        \u0027allowed_address_pairs\u0027: obj_fields.ListOfObjectsField("},{"line_number":157,"context_line":"            \u0027AllowedAddressPair\u0027, nullable\u003dTrue"},{"line_number":158,"context_line":"        ),"},{"line_number":159,"context_line":"        \u0027binding\u0027: obj_fields.ObjectField("},{"line_number":160,"context_line":"            \u0027PortBinding\u0027, nullable\u003dTrue"},{"line_number":161,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_3c59bb8f","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":10},"updated":"2016-08-12 13:34:49.000000000","message":"nitpick: can you close this on L157 by the end?, makes it easier to read.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd3eb3e746473b5ffecb68b29f4b023a5846cd56","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        \u0027allowed_address_pairs\u0027: obj_fields.ListOfObjectsField("},{"line_number":157,"context_line":"            \u0027AllowedAddressPair\u0027, nullable\u003dTrue"},{"line_number":158,"context_line":"        ),"},{"line_number":159,"context_line":"        \u0027binding\u0027: obj_fields.ObjectField("},{"line_number":160,"context_line":"            \u0027PortBinding\u0027, nullable\u003dTrue"},{"line_number":161,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_4de31b06","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":10},"in_reply_to":"9ad45d7e_3c59bb8f","updated":"2016-08-12 14:18:06.000000000","message":"I respectfully disagree. Hanging braces give visual clue as to where the current field ends.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"27c69653f946e2cc2c90d6b0fd0413ba76835b4a","unresolved":false,"context_lines":[{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        \u0027allowed_address_pairs\u0027: obj_fields.ListOfObjectsField("},{"line_number":157,"context_line":"            \u0027AllowedAddressPair\u0027, nullable\u003dTrue"},{"line_number":158,"context_line":"        ),"},{"line_number":159,"context_line":"        \u0027binding\u0027: obj_fields.ObjectField("},{"line_number":160,"context_line":"            \u0027PortBinding\u0027, nullable\u003dTrue"},{"line_number":161,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_11a015a5","line":158,"range":{"start_line":158,"start_character":8,"end_line":158,"end_character":10},"in_reply_to":"9ad45d7e_4de31b06","updated":"2016-08-12 16:23:46.000000000","message":"But confuses you on finding the next field. But this is something completely subjective :).\n\nSo let\u0027s agree to disagree :)","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":158,"context_line":"        ),"},{"line_number":159,"context_line":"        \u0027binding\u0027: obj_fields.ObjectField("},{"line_number":160,"context_line":"            \u0027PortBinding\u0027, nullable\u003dTrue"},{"line_number":161,"context_line":"        ),"},{"line_number":162,"context_line":"        \u0027dhcp_options\u0027: obj_fields.ListOfObjectsField("},{"line_number":163,"context_line":"            \u0027ExtraDhcpOpt\u0027, nullable\u003dTrue"},{"line_number":164,"context_line":"        ),"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_bce48bac","line":161,"updated":"2016-08-12 13:34:49.000000000","message":"ditto","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \u0027PortSecurity\u0027, nullable\u003dTrue"},{"line_number":175,"context_line":"        ),"},{"line_number":176,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":177,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # TODO(ihrachys): consider adding a \u0027dns_assignment\u0027 fully synthetic"},{"line_number":180,"context_line":"        # field in later object iterations"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_dc985f1e","line":177,"updated":"2016-08-12 13:34:49.000000000","message":"What makes me doubt of this (but I\u0027m not sure there\u0027s a better option) is that we\u0027re including fields here which can or cannot be, based on extensions.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4f6ba47e698963d83d597a8c704782a1453df2e8","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \u0027PortSecurity\u0027, nullable\u003dTrue"},{"line_number":175,"context_line":"        ),"},{"line_number":176,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":177,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # TODO(ihrachys): consider adding a \u0027dns_assignment\u0027 fully synthetic"},{"line_number":180,"context_line":"        # field in later object iterations"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_ec2e48f9","line":177,"in_reply_to":"9ad45d7e_91da45e8","updated":"2016-08-12 16:35:07.000000000","message":"We are not going to provide random extensions for objects. Instead, interested parties should work with core team to add missing extensions for their needs. We will leave access to db_obj on the object for now: https://review.openstack.org/#/c/348279/\n\nOverall, this seems to be in line with other consolidation efforts like moving api definition into neutron-lib and forbidding 3parties to extend api without going thru review process for common api definition.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd3eb3e746473b5ffecb68b29f4b023a5846cd56","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \u0027PortSecurity\u0027, nullable\u003dTrue"},{"line_number":175,"context_line":"        ),"},{"line_number":176,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":177,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # TODO(ihrachys): consider adding a \u0027dns_assignment\u0027 fully synthetic"},{"line_number":180,"context_line":"        # field in later object iterations"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_ed8daf2b","line":177,"in_reply_to":"9ad45d7e_dc985f1e","updated":"2016-08-12 14:18:06.000000000","message":"If those are null in db, we will have those None in objects (hence nullable\u003dTrue here). I don\u0027t think we should hide those fields in any case. We should converge on making objects supporting all extensions, not mess with object fields based on current configuration. For users of the object, it\u0027s always possible to check if a field is None before using it.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"27c69653f946e2cc2c90d6b0fd0413ba76835b4a","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            \u0027PortSecurity\u0027, nullable\u003dTrue"},{"line_number":175,"context_line":"        ),"},{"line_number":176,"context_line":"        \u0027security_group_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":177,"context_line":"        \u0027qos_policy_id\u0027: obj_fields.UUIDField(nullable\u003dTrue, default\u003dNone),"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"        # TODO(ihrachys): consider adding a \u0027dns_assignment\u0027 fully synthetic"},{"line_number":180,"context_line":"        # field in later object iterations"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_91da45e8","line":177,"in_reply_to":"9ad45d7e_ed8daf2b","updated":"2016-08-12 16:23:46.000000000","message":"Yes, I understand it works, but, I mean this completely breaks decoupling of extensions vs neutron/objects/* ... anyway, given that for example qos objects also live in neutron/objects/qos/ it may be ok.\n\nI think that we may need to find a way to have external extensions extending our core objects, or may be that\u0027s something we don\u0027t want.\n\nI can\u0027t think of anything beyond having a key/pair synthetic field where extensions add stuff... which, sometimes can be objects that the extensions must be aware of at both sides, and provide the righteous obj_make_compatible stuff.., prfffff","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":220,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":223,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_5c3bcf38","line":222,"updated":"2016-08-12 13:34:49.000000000","message":"Isn\u0027t that redundant with:\n\nhttps://github.com/openstack/neutron/blob/23db089f36a59fd3dcae7585e6ea72f352db1bad/neutron/objects/qos/policy.py#L164\n\n?","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"27c69653f946e2cc2c90d6b0fd0413ba76835b4a","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":220,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":223,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_718511ac","line":222,"in_reply_to":"9ad45d7e_2d0b477f","updated":"2016-08-12 16:23:46.000000000","message":"The binding is just a N:N binding table, IMHO that\u0027s something that must be completely abstracted to objects, and an implementation detail.\n\nIf we want to clean previous attachments, may be we need to add that functionality on the other side (QosPolicy).","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd3eb3e746473b5ffecb68b29f4b023a5846cd56","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":220,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":223,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_2d0b477f","line":222,"in_reply_to":"9ad45d7e_5c3bcf38","updated":"2016-08-12 14:18:06.000000000","message":"The function on the qos policy does not clean up previous attachments. The proper way to converge will be introducing a separate object for the binding, and reuse it from both places.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4f6ba47e698963d83d597a8c704782a1453df2e8","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":220,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":223,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":224,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":225,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_aca9f07d","line":222,"in_reply_to":"9ad45d7e_718511ac","updated":"2016-08-12 16:35:07.000000000","message":"I will anyway need to revisit it to handle TODO in the next line.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e9d28d2408d53538a2013c186fea6b679fe41f40","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            self.qos_policy_id \u003d qos_policy_id"},{"line_number":238,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def attach_security_group(self, sg_id):"},{"line_number":241,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":242,"context_line":"            obj_db_api.delete_objects("},{"line_number":243,"context_line":"                self.obj_context, sg_models.SecurityGroupPortBinding,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_3cfd3b6f","line":240,"updated":"2016-08-12 13:34:49.000000000","message":"I\u0027d do the same and add attach_port to SecurityGroup object.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"bd3eb3e746473b5ffecb68b29f4b023a5846cd56","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            self.qos_policy_id \u003d qos_policy_id"},{"line_number":238,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    def attach_security_group(self, sg_id):"},{"line_number":241,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":242,"context_line":"            obj_db_api.delete_objects("},{"line_number":243,"context_line":"                self.obj_context, sg_models.SecurityGroupPortBinding,"}],"source_content_type":"text/x-python","patch_set":11,"id":"9ad45d7e_0d5e4376","line":240,"in_reply_to":"9ad45d7e_3cfd3b6f","updated":"2016-08-12 14:18:06.000000000","message":"I am not going to expose ports on secgroup object. We may add such a function later if needed in db code, but for now I don\u0027t see a reason.","commit_id":"3b4d560378dc186074573e946c94d6541e5a58d2"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1b7ffe0c9966f1e77a6a568a815e1f28f140435f","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.plugins.ml2 import models as ml2_models"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class PortBindingBase(base.NeutronDbObject):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_a692ac9d","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"updated":"2016-08-12 17:25:12.000000000","message":"I saw that bindings were solved in QoS policy differently[1].  I\u0027m just wondering if we can use a similar approach here.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/qos/policy.py#L63-L64","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"74984fdfd31a43d24310923115ca50d3c49d44b2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron.plugins.ml2 import models as ml2_models"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class PortBindingBase(base.NeutronDbObject):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_c6afe029","line":32,"range":{"start_line":32,"start_character":6,"end_line":32,"end_character":21},"in_reply_to":"9ad45d7e_a692ac9d","updated":"2016-08-12 17:31:34.000000000","message":"Those are quite different. port bindings are not just a link table, it actually has payload (profile, vif_type, vif_details, ...).","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a41857ee3d0b178a8615b61a823a64b505b14b5c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class PortBindingBase(base.NeutronDbObject):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def filter_to_json_str(value):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_7e585157","line":34,"updated":"2016-08-14 09:00:34.000000000","message":"this should at least have \u0027host\u0027 as field, otherwise what kind of portbinding is?Or it\u0027s here just to share common code between the other binding classes? I think adding \u0027host\u0027 wouldn\u0027t hurt and it would mirror model PortBindingPort in portbindings_db","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0137c8cf64e1e568d9f24a02c27eb1bcf22717b3","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"class PortBindingBase(base.NeutronDbObject):"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def filter_to_json_str(value):"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_90908aee","line":34,"in_reply_to":"3ac371cc_7e585157","updated":"2016-08-15 08:37:41.000000000","message":"Not sure I follow the comment: host attribute is not a foreign key. It\u0027s not pointing to anywhere, it\u0027s a mere string that contains hostname for the node that bound the port. The \u0027foreign_keys\u0027 objects attribute is to pull in ObjectField-based fields from db models.\n\nSpeaking of semantics, I think an empty host just means the port is unbound.\n\nAnd if you mean that host field should be unique, then I am not sure either: it seems like the db model for non-distributed port does not enforce it.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"a41857ee3d0b178a8615b61a823a64b505b14b5c","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    db_model \u003d models_v2.IPAllocation"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    fields \u003d {"},{"line_number":108,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":109,"context_line":"        \u0027subnet_id\u0027: obj_fields.UUIDField(),"},{"line_number":110,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":111,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_9e354df9","line":108,"updated":"2016-08-14 09:00:34.000000000","message":"can be nullable","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0137c8cf64e1e568d9f24a02c27eb1bcf22717b3","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    db_model \u003d models_v2.IPAllocation"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    fields \u003d {"},{"line_number":108,"context_line":"        \u0027port_id\u0027: obj_fields.UUIDField(),"},{"line_number":109,"context_line":"        \u0027subnet_id\u0027: obj_fields.UUIDField(),"},{"line_number":110,"context_line":"        \u0027network_id\u0027: obj_fields.UUIDField(),"},{"line_number":111,"context_line":"        \u0027ip_address\u0027: obj_fields.IPAddressField(),"}],"source_content_type":"text/x-python","patch_set":12,"id":"3ac371cc_2b57ab03","line":108,"in_reply_to":"3ac371cc_9e354df9","updated":"2016-08-15 08:37:41.000000000","message":"Good catch.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def filter_to_json_str(value):"},{"line_number":38,"context_line":"        if isinstance(value, list):"},{"line_number":39,"context_line":"            return [jsonutils.dumps(val) for val in value]"},{"line_number":40,"context_line":"        return jsonutils.dumps(value)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_8b57b501","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":35},"updated":"2016-08-15 12:57:52.000000000","message":"Not really needed, but shouldn\u0027t this be \u0027PortBindingBase.filter_to_json_str\u0027 instead (i.e. a recursive function)? just in case this is re-used for something else later on that can use the recursiveness?\n\nAlso, while thinking about this, this might benefit from being in the base class.","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def filter_to_json_str(value):"},{"line_number":38,"context_line":"        if isinstance(value, list):"},{"line_number":39,"context_line":"            return [jsonutils.dumps(val) for val in value]"},{"line_number":40,"context_line":"        return jsonutils.dumps(value)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_2ef03d90","line":39,"range":{"start_line":39,"start_character":20,"end_line":39,"end_character":35},"in_reply_to":"3ac371cc_8b57b501","updated":"2016-08-15 17:21:38.000000000","message":"We explicitly handle a single layer, because api filters don\u0027t support embedded layering.","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":221,"context_line":"    }"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def create(self):"},{"line_number":224,"context_line":"        fields \u003d self.obj_get_changes()"},{"line_number":225,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":226,"context_line":"            sg_id \u003d self.security_group_id"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_2b17a1a4","line":223,"range":{"start_line":223,"start_character":8,"end_line":223,"end_character":14},"updated":"2016-08-15 12:57:52.000000000","message":"This could surely use most of \u0027update\u0027 to avoid code duplication, no?","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":220,"context_line":"        \u0027security\u0027: \u0027port_security\u0027,"},{"line_number":221,"context_line":"    }"},{"line_number":222,"context_line":""},{"line_number":223,"context_line":"    def create(self):"},{"line_number":224,"context_line":"        fields \u003d self.obj_get_changes()"},{"line_number":225,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":226,"context_line":"            sg_id \u003d self.security_group_id"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_ce0c0997","line":223,"range":{"start_line":223,"start_character":8,"end_line":223,"end_character":14},"in_reply_to":"3ac371cc_2b17a1a4","updated":"2016-08-15 17:21:38.000000000","message":"Meh. Maybe when it becomes more than just two calls.","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"3dc26c0a478532af536f39395216916fbf86825d","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":241,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":244,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":245,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":246,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_8bd175d0","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":25},"updated":"2016-08-15 12:57:52.000000000","message":"super-super-OCD-nit: since above, security_group_id appear before qos_policy_id, the actual functions should be defined in the same order...\n\n/me will go back to the corner and cry in the dark now :\u003c","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"97fb3d7a518d15b64bc2eb90aa57ce5f1340a7bc","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":241,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":244,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":245,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":246,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_ee510564","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":25},"in_reply_to":"3ac371cc_8bd175d0","updated":"2016-08-15 17:21:38.000000000","message":"C\u0027mon...","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":12444,"name":"John Schwarz","email":"jschwarz@redhat.com","username":"jschwarz"},"change_message_id":"59fd4227eaadff373de64331b7750685fc063286","unresolved":false,"context_lines":[{"line_number":240,"context_line":"            if \u0027qos_policy_id\u0027 in fields:"},{"line_number":241,"context_line":"                self.attach_qos_policy(self.qos_policy_id)"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    def attach_qos_policy(self, qos_policy_id):"},{"line_number":244,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":245,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":246,"context_line":"        # and policy objects"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_e673b3e5","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":25},"in_reply_to":"3ac371cc_ee510564","updated":"2016-08-16 16:06:41.000000000","message":"I did say \"super-super-OCD-nit\" ;-)","commit_id":"7aaee6e8800f570cbfda54b9f93fde6ce4ad3785"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"822292d58801e32f328de49f0505ff4beee64335","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def filter_to_json_str(value):"},{"line_number":38,"context_line":"        if isinstance(value, list):"},{"line_number":39,"context_line":"            return [jsonutils.dumps(val) for val in value]"},{"line_number":40,"context_line":"        return jsonutils.dumps(value)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def modify_fields_to_db(cls, fields):"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_0c4dd099","line":40,"range":{"start_line":36,"start_character":4,"end_line":40,"end_character":37},"updated":"2016-08-18 13:55:25.000000000","message":"maybe move it to base class?","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0b16b3c130f34c67cce94b9b15f65760cc4bf27","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"    foreign_keys \u003d {\u0027port_id\u0027: \u0027id\u0027}"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @staticmethod"},{"line_number":37,"context_line":"    def filter_to_json_str(value):"},{"line_number":38,"context_line":"        if isinstance(value, list):"},{"line_number":39,"context_line":"            return [jsonutils.dumps(val) for val in value]"},{"line_number":40,"context_line":"        return jsonutils.dumps(value)"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    @classmethod"},{"line_number":43,"context_line":"    def modify_fields_to_db(cls, fields):"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_ec165a54","line":40,"range":{"start_line":36,"start_character":4,"end_line":40,"end_character":37},"in_reply_to":"3ac371cc_0c4dd099","updated":"2016-08-19 12:26:43.000000000","message":"Not now, I don\u0027t see it used anywhere else just yet.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"7220e5f00bb57069ac04b9a93a8ef59160fb0ae0","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        for db_obj in objs:"},{"line_number":342,"context_line":"            # extract security group binding"},{"line_number":343,"context_line":"            if db_obj.get(\u0027security_groups\u0027, []):"},{"line_number":344,"context_line":"                self.security_group_id \u003d ("},{"line_number":345,"context_line":"                    db_obj.security_groups[0].security_group_id"},{"line_number":346,"context_line":"                )"},{"line_number":347,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_b67dc9e9","line":344,"updated":"2016-08-19 13:39:36.000000000","message":"A port can be a member of 0-to-many security groups. This should be security_group_ids and should be a list of all of the security group IDs.","commit_id":"55b05fd10de40e1673e7d7c9199e2065862efb67"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _attach_security_groups(self, sg_ids):"},{"line_number":310,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":311,"context_line":"            obj_db_api.delete_objects("},{"line_number":312,"context_line":"                self.obj_context, sg_models.SecurityGroupPortBinding,"},{"line_number":313,"context_line":"                port_id\u003dself.id,"},{"line_number":314,"context_line":"            )"},{"line_number":315,"context_line":"        for sg_id in sg_ids:"},{"line_number":316,"context_line":"            self._attach_security_group(sg_id)"},{"line_number":317,"context_line":"        self.security_group_ids \u003d sg_ids"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_4ee655b5","line":314,"range":{"start_line":311,"start_character":12,"end_line":314,"end_character":13},"updated":"2016-08-20 10:59:25.000000000","message":"Maybe we should introduce class method in NeutronDbObject delete_objects(context, **kwargs) so we can do:\n\nSecurityGroupPortBinding.delete_objects(ctx, port_id\u003dself.id)\n\nBTW. We are missing SecurityGroupPortBinding OVO.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _attach_security_groups(self, sg_ids):"},{"line_number":310,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":311,"context_line":"            obj_db_api.delete_objects("},{"line_number":312,"context_line":"                self.obj_context, sg_models.SecurityGroupPortBinding,"},{"line_number":313,"context_line":"                port_id\u003dself.id,"},{"line_number":314,"context_line":"            )"},{"line_number":315,"context_line":"        for sg_id in sg_ids:"},{"line_number":316,"context_line":"            self._attach_security_group(sg_id)"},{"line_number":317,"context_line":"        self.security_group_ids \u003d sg_ids"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_5b2119b4","line":314,"range":{"start_line":311,"start_character":12,"end_line":314,"end_character":13},"in_reply_to":"1ac06dbe_4ee655b5","updated":"2016-08-24 16:37:19.000000000","message":"Lemme add todos for both.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0fdcf206d32d6367f0518f8e2b369d8cbd7c5b09","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    synthetic_fields \u003d [\u0027segment\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    foreign_keys \u003d {"},{"line_number":137,"context_line":"        \u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027},"},{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_e4300feb","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":34},"updated":"2016-08-24 22:52:19.000000000","message":"why not just {\u0027port_id\u0027: \u0027id\u0027} ?","commit_id":"2dabf992c096885b197be6225b4926525d6e7d4c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"5a8247e6262c65c60058572a89f221e5908ef112","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    synthetic_fields \u003d [\u0027segment\u0027]"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    foreign_keys \u003d {"},{"line_number":137,"context_line":"        \u0027Port\u0027: {\u0027port_id\u0027: \u0027id\u0027},"},{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":22,"id":"1ac06dbe_9be1a801","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":34},"in_reply_to":"1ac06dbe_e4300feb","updated":"2016-08-25 05:28:00.000000000","message":"It is based on patch introducing multiple foreign keys:\nhttps://review.openstack.org/357207","commit_id":"2dabf992c096885b197be6225b4926525d6e7d4c"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"8061a2a879ab557d0789b7a0b64e4cf3de4e004a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \u0027vif_details\u0027: obj_fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_ec2f74f4","line":87,"updated":"2016-08-25 23:10:50.000000000","message":"Should there be a synthetic field for PortBindingPort here as it has a backef relationship in the model?\nhttps://review.openstack.org/#/c/355662/\nhttps://review.openstack.org/#/c/357516/","commit_id":"b9941b6dc1d8cd92fc38b716543cf39804fe0b6d"},{"author":{"_account_id":22776,"name":"Nakul Dahiwade","email":"nakul.dahiwade@intel.com","username":"nakul.dahiwade"},"change_message_id":"22a627922905db3588f39da9436daba0aea52a84","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \u0027vif_details\u0027: obj_fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_13948989","line":87,"in_reply_to":"fa7ab95a_98e7e9e3","updated":"2016-08-26 15:09:13.000000000","message":"Okay.Thanks.","commit_id":"b9941b6dc1d8cd92fc38b716543cf39804fe0b6d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c8b00686f52ceb44269840090f55915ef02ad9bb","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        \u0027vif_details\u0027: obj_fields.DictOfStringsField(nullable\u003dTrue),"},{"line_number":85,"context_line":"        \u0027vnic_type\u0027: obj_fields.StringField(),"},{"line_number":86,"context_line":"    }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    primary_keys \u003d [\u0027port_id\u0027]"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa7ab95a_98e7e9e3","line":87,"in_reply_to":"fa7ab95a_ec2f74f4","updated":"2016-08-26 11:26:10.000000000","message":"No. The model you refer to should actually go away at all since it\u0027s not used in neutron tree anywhere. I suggest you don\u0027t proceed on the path with the patches.","commit_id":"b9941b6dc1d8cd92fc38b716543cf39804fe0b6d"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ffcf975a6bc03cf549a333becd8b327985d50e29","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"},{"line_number":141,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":142,"context_line":"        if not _pager:"},{"line_number":143,"context_line":"            _pager \u003d base.Pager()"},{"line_number":144,"context_line":"        if not _pager.sorts:"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_518509ab","line":141,"updated":"2016-09-23 14:34:18.000000000","message":"it\u0027s very similar to the same method in the network object, it\u0027s worth thinking if we should extract this and make it common","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"0384f1c51755c0e03cda8cb0e5269fe49567d762","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"},{"line_number":141,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":142,"context_line":"        if not _pager:"},{"line_number":143,"context_line":"            _pager \u003d base.Pager()"},{"line_number":144,"context_line":"        if not _pager.sorts:"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_a2e198d2","line":141,"in_reply_to":"5a8bc5a2_518509ab","updated":"2016-09-23 15:20:17.000000000","message":"DNSNameServer[1] also uses a similar logic.  I noticed that validate_filters argument is not passed in this method.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/objects/subnet.py#L44","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea427f422b666fe0fb4d4fb4d0ad796f7ee727cb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"},{"line_number":141,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":142,"context_line":"        if not _pager:"},{"line_number":143,"context_line":"            _pager \u003d base.Pager()"},{"line_number":144,"context_line":"        if not _pager.sorts:"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_88eafb0d","line":141,"in_reply_to":"5a8bc5a2_518509ab","updated":"2016-09-23 15:52:36.000000000","message":"I have a TODO for that somewhere...","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea427f422b666fe0fb4d4fb4d0ad796f7ee727cb","unresolved":false,"context_lines":[{"line_number":138,"context_line":"    }"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @classmethod"},{"line_number":141,"context_line":"    def get_objects(cls, context, _pager\u003dNone, **kwargs):"},{"line_number":142,"context_line":"        if not _pager:"},{"line_number":143,"context_line":"            _pager \u003d base.Pager()"},{"line_number":144,"context_line":"        if not _pager.sorts:"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_88759b99","line":141,"in_reply_to":"5a8bc5a2_a2e198d2","updated":"2016-09-23 15:52:36.000000000","message":"Oh right Victor. Will add.","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ffcf975a6bc03cf549a333becd8b327985d50e29","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":310,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":311,"context_line":"        # and policy objects"},{"line_number":312,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":313,"context_line":"            obj_db_api.delete_objects("},{"line_number":314,"context_line":"                self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":315,"context_line":"                port_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_f1445575","line":312,"updated":"2016-09-23 14:34:18.000000000","message":"same comment as for the network object...this method is supposed to be called inside a transaction, so no need for this line","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea427f422b666fe0fb4d4fb4d0ad796f7ee727cb","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":310,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":311,"context_line":"        # and policy objects"},{"line_number":312,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":313,"context_line":"            obj_db_api.delete_objects("},{"line_number":314,"context_line":"                self.obj_context, qos_models.QosPortPolicyBinding,"},{"line_number":315,"context_line":"                port_id\u003dself.id,"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_2848072d","line":312,"in_reply_to":"5a8bc5a2_f1445575","updated":"2016-09-23 15:52:36.000000000","message":"Done","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ffcf975a6bc03cf549a333becd8b327985d50e29","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _attach_security_groups(self, sg_ids):"},{"line_number":326,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":327,"context_line":"            # TODO(ihrachys): consider introducing an (internal) object for the"},{"line_number":328,"context_line":"            # binding to decouple database operations a bit more"},{"line_number":329,"context_line":"            obj_db_api.delete_objects("}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_1148e186","line":326,"updated":"2016-09-23 14:34:18.000000000","message":"ditto","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea427f422b666fe0fb4d4fb4d0ad796f7ee727cb","unresolved":false,"context_lines":[{"line_number":323,"context_line":"            self.obj_reset_changes([\u0027qos_policy_id\u0027])"},{"line_number":324,"context_line":""},{"line_number":325,"context_line":"    def _attach_security_groups(self, sg_ids):"},{"line_number":326,"context_line":"        with db_api.autonested_transaction(self.obj_context.session):"},{"line_number":327,"context_line":"            # TODO(ihrachys): consider introducing an (internal) object for the"},{"line_number":328,"context_line":"            # binding to decouple database operations a bit more"},{"line_number":329,"context_line":"            obj_db_api.delete_objects("}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_885f5be4","line":326,"in_reply_to":"5a8bc5a2_1148e186","updated":"2016-09-23 15:52:36.000000000","message":"Done","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":22774,"name":"Shashank Kumar Shankar","email":"shashank.kumar.shankar@intel.com","username":"skshankar"},"change_message_id":"1f5278b70112fea33b1db9da4bf586cb5dc9d3c8","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":127,"context_line":"        \u0027level\u0027: obj_fields.IntegerField(),"},{"line_number":128,"context_line":"        \u0027driver\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":129,"context_line":"        \u0027segment\u0027: obj_fields.ObjectField("},{"line_number":130,"context_line":"            \u0027NetworkSegment\u0027, nullable\u003dTrue"},{"line_number":131,"context_line":"        ),"},{"line_number":132,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a8bc5a2_175bcc2f","line":129,"updated":"2016-09-27 19:41:52.000000000","message":"Shouldn\u0027t this be segment_id? It is mentioned as segment_id in network_segment object [1] and in the model [2]. Errors in integration point here. \n\n[1] - https://review.openstack.org/#/c/351368/35/neutron/objects/network/network_segment.py@40\n[2] - https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/models.py#L76","commit_id":"d217b01198713dfec3ca05f6116aeabad18e56b3"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3e18f7d787e2b5b643acb301fc7a3cab3e36ea42","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":127,"context_line":"        \u0027level\u0027: obj_fields.IntegerField(),"},{"line_number":128,"context_line":"        \u0027driver\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":129,"context_line":"        \u0027segment\u0027: obj_fields.ObjectField("},{"line_number":130,"context_line":"            \u0027NetworkSegment\u0027, nullable\u003dTrue"},{"line_number":131,"context_line":"        ),"},{"line_number":132,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":35,"id":"3a98d1f4_497b768c","line":129,"in_reply_to":"5a8bc5a2_06af1b7e","updated":"2016-09-30 13:00:18.000000000","message":"I don\u0027t see a problem with the naming. Can you elaborate? You can still access the \u0027id\u0027 thru the segment object, like level_obj.segment.id.","commit_id":"d217b01198713dfec3ca05f6116aeabad18e56b3"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0750688772e886b2506c3a999d0cf913491f40aa","unresolved":false,"context_lines":[{"line_number":126,"context_line":"        \u0027host\u0027: obj_fields.StringField(),"},{"line_number":127,"context_line":"        \u0027level\u0027: obj_fields.IntegerField(),"},{"line_number":128,"context_line":"        \u0027driver\u0027: obj_fields.StringField(nullable\u003dTrue),"},{"line_number":129,"context_line":"        \u0027segment\u0027: obj_fields.ObjectField("},{"line_number":130,"context_line":"            \u0027NetworkSegment\u0027, nullable\u003dTrue"},{"line_number":131,"context_line":"        ),"},{"line_number":132,"context_line":"    }"}],"source_content_type":"text/x-python","patch_set":35,"id":"5a8bc5a2_06af1b7e","line":129,"in_reply_to":"5a8bc5a2_175bcc2f","updated":"2016-09-27 20:34:37.000000000","message":"AFAIU, it looks intentional, we can still get the id from relationship, it may be done for loading more segment data, \nlets see what authors say.","commit_id":"d217b01198713dfec3ca05f6116aeabad18e56b3"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c44344aad2a1dee1baa70cece5476f65e2a95f7e","unresolved":false,"context_lines":[{"line_number":308,"context_line":""},{"line_number":309,"context_line":"    def _attach_qos_policy(self, qos_policy_id):"},{"line_number":310,"context_line":"        # TODO(ihrachys): introduce an object for the binding to isolate"},{"line_number":311,"context_line":"        # database access in a single place, currently scattered between port"},{"line_number":312,"context_line":"        # and policy objects"},{"line_number":313,"context_line":"        obj_db_api.delete_objects("},{"line_number":314,"context_line":"            self.obj_context, qos_models.QosPortPolicyBinding, port_id\u003dself.id)"}],"source_content_type":"text/x-python","patch_set":39,"id":"3a98d1f4_aafa3abb","line":311,"updated":"2016-09-30 09:36:53.000000000","message":"IMO having it at one place shall be good: QoSPolicy calls a method on port, or we just have a QoSPolicyBinding object... that could work too. \n\nI\u0027d love to see the code which interfaces to objects having a natural interface, instead of having to worry about creating binding objects, etc... \n\nport.attach_qos_policy(qos_policy_id) seems very natural to me, and instead, creating a policy binding which is apparently dissociated from the port object and policy object, well it works, but it looks to me like I\u0027d be talking to database again, and not to objects.\n\nThis is all very subjective anyway.","commit_id":"dcd78423aa9e3fda5234c22fc14b06064e65e689"}],"neutron/plugins/ml2/models.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7d9c29c789bfc5550f992168c24815333e0fbc4e","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # Add a relationship to the Port model in order to instruct SQLAlchemy to"},{"line_number":81,"context_line":"    # eagerly load port bindings"},{"line_number":82,"context_line":"    port \u003d orm.relationship("},{"line_number":83,"context_line":"        models_v2.Port,"},{"line_number":84,"context_line":"        backref\u003dorm.backref(\"binding_levels\", lazy\u003d\u0027joined\u0027, cascade\u003d\u0027delete\u0027))"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_939cb910","line":82,"updated":"2016-09-26 10:38:54.000000000","message":"Are we sure that we want to add this relationship?","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7d3c2e219d3a7101ef5144da27456d34b0f546f","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    # Add a relationship to the Port model in order to instruct SQLAlchemy to"},{"line_number":81,"context_line":"    # eagerly load port bindings"},{"line_number":82,"context_line":"    port \u003d orm.relationship("},{"line_number":83,"context_line":"        models_v2.Port,"},{"line_number":84,"context_line":"        backref\u003dorm.backref(\"binding_levels\", lazy\u003d\u0027joined\u0027, cascade\u003d\u0027delete\u0027))"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_44c33789","line":82,"in_reply_to":"5a8bc5a2_939cb910","updated":"2016-09-26 14:39:30.000000000","message":"What\u0027s your point? What\u0027s your suggestion?","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"}],"neutron/tests/unit/objects/db/test_api.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ac7150202cb3275aeff263b5269978559cd4562","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                {\u0027name\u0027: \u0027foo%d\u0027 % i, \u0027description\u0027: \u0027bar\u0027})"},{"line_number":102,"context_line":"        # create some more objects with a different description"},{"line_number":103,"context_line":"        descriptions \u003d set()"},{"line_number":104,"context_line":"        for i in range(10, 20):"},{"line_number":105,"context_line":"            desc \u003d \u0027bar%d\u0027 % i"},{"line_number":106,"context_line":"            descriptions.add(desc)"},{"line_number":107,"context_line":"            api.create_object("}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_ea584233","line":104,"range":{"start_line":104,"start_character":23,"end_line":104,"end_character":29},"updated":"2016-08-30 21:51:23.000000000","message":"nit: it should be nice to have this defined in variables.","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8efd4904bf4733772fd2053211817cd1dfd210b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"                {\u0027name\u0027: \u0027foo%d\u0027 % i, \u0027description\u0027: \u0027bar\u0027})"},{"line_number":102,"context_line":"        # create some more objects with a different description"},{"line_number":103,"context_line":"        descriptions \u003d set()"},{"line_number":104,"context_line":"        for i in range(10, 20):"},{"line_number":105,"context_line":"            desc \u003d \u0027bar%d\u0027 % i"},{"line_number":106,"context_line":"            descriptions.add(desc)"},{"line_number":107,"context_line":"            api.create_object("}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_9b3e0028","line":104,"range":{"start_line":104,"start_character":23,"end_line":104,"end_character":29},"in_reply_to":"fa7ab95a_ea584233","updated":"2016-08-31 13:57:48.000000000","message":"What would be the name of the variable?.. It\u0027s a pure counter that just starts at where the previous counter in line 98 stopped.","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ac7150202cb3275aeff263b5269978559cd4562","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                self.ctxt, self.model,"},{"line_number":109,"context_line":"                {\u0027name\u0027: \u0027foo%d\u0027 % i, \u0027description\u0027: desc})"},{"line_number":110,"context_line":"        # make sure that all objects are in the database"},{"line_number":111,"context_line":"        self.assertEqual(20, len(api.get_objects(self.ctxt, self.model)))"},{"line_number":112,"context_line":"        # now delete just those with the \u0027bar\u0027 description"},{"line_number":113,"context_line":"        api.delete_objects(self.ctxt, self.model, description\u003d\u0027bar\u0027)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_efd214d0","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":73},"updated":"2016-08-30 21:51:23.000000000","message":"self.assertEqual(20, api.count(self.ctxt, self.model))","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8efd4904bf4733772fd2053211817cd1dfd210b","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                self.ctxt, self.model,"},{"line_number":109,"context_line":"                {\u0027name\u0027: \u0027foo%d\u0027 % i, \u0027description\u0027: desc})"},{"line_number":110,"context_line":"        # make sure that all objects are in the database"},{"line_number":111,"context_line":"        self.assertEqual(20, len(api.get_objects(self.ctxt, self.model)))"},{"line_number":112,"context_line":"        # now delete just those with the \u0027bar\u0027 description"},{"line_number":113,"context_line":"        api.delete_objects(self.ctxt, self.model, description\u003d\u0027bar\u0027)"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_9b25200c","line":111,"range":{"start_line":111,"start_character":8,"end_line":111,"end_character":73},"in_reply_to":"fa7ab95a_efd214d0","updated":"2016-08-31 13:57:48.000000000","message":"Neat.","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d1c2e86ae6cead61d03bac8c00668891c0a16e92","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def test_get_object_create_update_delete(self):"},{"line_number":71,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        new \u003d api.get_object(self.ctxt, self.model, id\u003dobj.id)"},{"line_number":74,"context_line":"        self.assertEqual(obj, new)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        obj \u003d new"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_a6ad0086","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":11},"updated":"2016-09-02 00:07:54.000000000","message":"I would strongly recommend naming it to something else more relevant (db_obj or something else except new), the reason is new is other languages which can be confusing.","commit_id":"75e33c94ca0c3547fad0aa2f7815b5d747e33210"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"aece1dc68abd29b71fa2d53d5bbfe1ef14213d26","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    def test_get_object_create_update_delete(self):"},{"line_number":71,"context_line":"        obj \u003d api.create_object(self.ctxt, self.model, {\u0027name\u0027: \u0027foo\u0027})"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"        new \u003d api.get_object(self.ctxt, self.model, id\u003dobj.id)"},{"line_number":74,"context_line":"        self.assertEqual(obj, new)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        obj \u003d new"}],"source_content_type":"text/x-python","patch_set":26,"id":"9a89bdaa_792fa7a1","line":73,"range":{"start_line":73,"start_character":8,"end_line":73,"end_character":11},"in_reply_to":"fa7ab95a_a6ad0086","updated":"2016-09-02 23:38:33.000000000","message":"new is a keyword in other languages***","commit_id":"75e33c94ca0c3547fad0aa2f7815b5d747e33210"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d1c2e86ae6cead61d03bac8c00668891c0a16e92","unresolved":false,"context_lines":[{"line_number":73,"context_line":"        new \u003d api.get_object(self.ctxt, self.model, id\u003dobj.id)"},{"line_number":74,"context_line":"        self.assertEqual(obj, new)"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        obj \u003d new"},{"line_number":77,"context_line":"        api.update_object(self.ctxt, self.model, {\u0027name\u0027: \u0027bar\u0027}, id\u003dobj.id)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        new \u003d api.get_object(self.ctxt, self.model, id\u003dobj.id)"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_e6cb8851","line":76,"range":{"start_line":76,"start_character":14,"end_line":76,"end_character":17},"updated":"2016-09-02 00:07:54.000000000","message":"same here","commit_id":"75e33c94ca0c3547fad0aa2f7815b5d747e33210"},{"author":{"_account_id":6788,"name":"Rossella Sblendido","email":"rsblendido@suse.com","username":"rossella-o"},"change_message_id":"ffcf975a6bc03cf549a333becd8b327985d50e29","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            marker_obj\u003dget_object.return_value)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class CRUDScenarioTestCase(testlib_api.SqlTestCase):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    CORE_PLUGIN \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_f9c51b8e","line":55,"updated":"2016-09-23 14:34:18.000000000","message":"does this change really belong to this patch?","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea427f422b666fe0fb4d4fb4d0ad796f7ee727cb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            marker_obj\u003dget_object.return_value)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"class CRUDScenarioTestCase(testlib_api.SqlTestCase):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    CORE_PLUGIN \u003d \u0027neutron.db.db_base_plugin_v2.NeutronDbPluginV2\u0027"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_a830979f","line":55,"in_reply_to":"5a8bc5a2_f9c51b8e","updated":"2016-09-23 15:52:36.000000000","message":"The test targets new delete_objects() function, among other things.","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"}],"neutron/tests/unit/objects/qos/test_policy.py":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1b7ffe0c9966f1e77a6a568a815e1f28f140435f","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        obj \u003d self._create_test_policy()"},{"line_number":354,"context_line":"        obj.attach_port(self._port[\u0027id\u0027])"},{"line_number":355,"context_line":"        ids \u003d self._test_class.get_bound_tenant_ids(self.context, obj[\u0027id\u0027])"},{"line_number":356,"context_line":"        self.assertEqual(ids.pop(), self._port.project_id)"},{"line_number":357,"context_line":"        self.assertEqual(len(ids), 0)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        obj.detach_port(self._port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_860e88e3","line":356,"updated":"2016-08-12 17:25:12.000000000","message":"ditto: https://review.openstack.org/#/c/351368/12/neutron/db/models_v2.py@151","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7082cc4f2bab112be1cc92b8a6d5a6477f11c0","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        obj \u003d self._create_test_policy()"},{"line_number":354,"context_line":"        obj.attach_port(self._port[\u0027id\u0027])"},{"line_number":355,"context_line":"        ids \u003d self._test_class.get_bound_tenant_ids(self.context, obj[\u0027id\u0027])"},{"line_number":356,"context_line":"        self.assertEqual(ids.pop(), self._port.project_id)"},{"line_number":357,"context_line":"        self.assertEqual(len(ids), 0)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"        obj.detach_port(self._port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_6648b488","line":356,"in_reply_to":"9ad45d7e_860e88e3","updated":"2016-08-12 17:32:25.000000000","message":"Here, self._port is an object. We should access its native field, not an alias property.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"}],"neutron/tests/unit/objects/test_base.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"70855487e1f48b53d7bbe6bc7428cae3f06ac005","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        if \u0027mac_address\u0027 not in attrs:"},{"line_number":912,"context_line":"            attrs[\u0027mac_address\u0027] \u003d next(self._mac_address_generator)"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        port \u003d ports.Port(self.context, **attrs)"},{"line_number":915,"context_line":"        port.create()"},{"line_number":916,"context_line":"        return port"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"    def _create_test_segment(self, network):"},{"line_number":919,"context_line":"        test_segment \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_31266bce","line":916,"range":{"start_line":914,"start_character":7,"end_line":916,"end_character":19},"updated":"2016-08-05 07:01:15.000000000","message":"this is what we\u0027ve been waiting for! :)","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"810658a892c5c9e2f24cd63c0d32d7b681aa9e4d","unresolved":false,"context_lines":[{"line_number":911,"context_line":"        if \u0027mac_address\u0027 not in attrs:"},{"line_number":912,"context_line":"            attrs[\u0027mac_address\u0027] \u003d next(self._mac_address_generator)"},{"line_number":913,"context_line":""},{"line_number":914,"context_line":"        port \u003d ports.Port(self.context, **attrs)"},{"line_number":915,"context_line":"        port.create()"},{"line_number":916,"context_line":"        return port"},{"line_number":917,"context_line":""},{"line_number":918,"context_line":"    def _create_test_segment(self, network):"},{"line_number":919,"context_line":"        test_segment \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_7976a5d9","line":916,"range":{"start_line":914,"start_character":7,"end_line":916,"end_character":19},"in_reply_to":"bacf61ea_31266bce","updated":"2016-08-12 13:24:17.000000000","message":"hurray! :-)","commit_id":"c29ea8870775d23b634b895896f60fd608d68458"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c991cf7be0e1f3a9dba9fb8de24fd0cc655cb980","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            self._test_class.db_model: self.db_objs,"},{"line_number":391,"context_line":"            ObjectFieldsModel: [synthetic_obj_fields]}"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"    def get_random_fields(self, obj_cls\u003dNone):"},{"line_number":394,"context_line":"        obj_cls \u003d obj_cls or self._test_class"},{"line_number":395,"context_line":"        fields \u003d {}"},{"line_number":396,"context_line":"        ip_version \u003d tools.get_random_ip_version()"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_47fdaf6d","line":393,"updated":"2016-08-12 16:50:52.000000000","message":"need that change because otherwise my scenario tests for vif_details don\u0027t work, because cls._test_class returns the attribute from the base class, not from the generated test object.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c991cf7be0e1f3a9dba9fb8de24fd0cc655cb980","unresolved":false,"context_lines":[{"line_number":504,"context_line":"                    obj_class \u003d self._get_ovo_object_class(self._test_class,"},{"line_number":505,"context_line":"                                                           field)"},{"line_number":506,"context_line":"                    filter_kwargs \u003d {"},{"line_number":507,"context_line":"                        obj_class.fields_need_translation.get(k, k): db_obj[v]"},{"line_number":508,"context_line":"                        for k, v in obj_class.foreign_keys.items()"},{"line_number":509,"context_line":"                    }"},{"line_number":510,"context_line":"                    mock_calls.append("}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_0711f7af","line":507,"updated":"2016-08-12 16:50:52.000000000","message":"we should expect db attr names, not object field names.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1b7ffe0c9966f1e77a6a568a815e1f28f140435f","unresolved":false,"context_lines":[{"line_number":962,"context_line":"            self._port_name_generator \u003d (\"test-port%d\" % i"},{"line_number":963,"context_line":"                                         for i in itertools.count(1))"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":966,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":967,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":968,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_86dcc847","line":965,"range":{"start_line":965,"start_character":18,"end_line":965,"end_character":28},"updated":"2016-08-12 17:25:12.000000000","message":"ditto: https://review.openstack.org/#/c/351368/12/neutron/db/models_v2.py@151","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ba7082cc4f2bab112be1cc92b8a6d5a6477f11c0","unresolved":false,"context_lines":[{"line_number":962,"context_line":"            self._port_name_generator \u003d (\"test-port%d\" % i"},{"line_number":963,"context_line":"                                         for i in itertools.count(1))"},{"line_number":964,"context_line":""},{"line_number":965,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":966,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":967,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":968,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_0658d855","line":965,"range":{"start_line":965,"start_character":18,"end_line":965,"end_character":28},"in_reply_to":"9ad45d7e_86dcc847","updated":"2016-08-12 17:32:25.000000000","message":"Nope.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"822292d58801e32f328de49f0505ff4beee64335","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            self._port_name_generator \u003d (\"test-port%d\" % i"},{"line_number":975,"context_line":"                                         for i in itertools.count(1))"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":978,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":979,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":980,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"3ac371cc_b2769203","line":977,"range":{"start_line":977,"start_character":32,"end_line":977,"end_character":47},"updated":"2016-08-18 13:55:25.000000000","message":"don\u0027t you need to use the uuid here?","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0b16b3c130f34c67cce94b9b15f65760cc4bf27","unresolved":false,"context_lines":[{"line_number":974,"context_line":"            self._port_name_generator \u003d (\"test-port%d\" % i"},{"line_number":975,"context_line":"                                         for i in itertools.count(1))"},{"line_number":976,"context_line":""},{"line_number":977,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":978,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":979,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":980,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1ac06dbe_ef248cb0","line":977,"range":{"start_line":977,"start_character":32,"end_line":977,"end_character":47},"in_reply_to":"3ac371cc_b2769203","updated":"2016-08-19 12:26:43.000000000","message":"doesn\u0027t really matter: neutron allows for any strings.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":370,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":371,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":372,"context_line":"    obj_fields.DictOfStringsField: lambda: {},"},{"line_number":373,"context_line":"    common_types.DomainNameField: get_random_domain_name,"},{"line_number":374,"context_line":"    common_types.DscpMarkField: get_random_dscp_mark,"},{"line_number":375,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_8e95ede5","line":372,"range":{"start_line":372,"start_character":3,"end_line":372,"end_character":45},"updated":"2016-08-20 10:59:25.000000000","message":"It would be good to have tools.get_random_dict_of_strings to return some content inside the DictOfStringField.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":369,"context_line":"    obj_fields.UUIDField: uuidutils.generate_uuid,"},{"line_number":370,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":371,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":372,"context_line":"    obj_fields.DictOfStringsField: lambda: {},"},{"line_number":373,"context_line":"    common_types.DomainNameField: get_random_domain_name,"},{"line_number":374,"context_line":"    common_types.DscpMarkField: get_random_dscp_mark,"},{"line_number":375,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_7ec3238b","line":372,"range":{"start_line":372,"start_character":3,"end_line":372,"end_character":45},"in_reply_to":"1ac06dbe_8e95ede5","updated":"2016-08-24 16:37:19.000000000","message":"Done","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    common_types.EtherTypeEnumField: tools.get_random_ether_type,"},{"line_number":386,"context_line":"    common_types.IpProtocolEnumField: tools.get_random_ip_protocol,"},{"line_number":387,"context_line":"    common_types.PortRangeField: tools.get_random_port,"},{"line_number":388,"context_line":"    common_types.ListOfUUIDsField: lambda: [],"},{"line_number":389,"context_line":"}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_aea42957","line":388,"range":{"start_line":388,"start_character":3,"end_line":388,"end_character":45},"updated":"2016-08-20 10:59:25.000000000","message":"the same line 372, add generator for uuid list.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":385,"context_line":"    common_types.EtherTypeEnumField: tools.get_random_ether_type,"},{"line_number":386,"context_line":"    common_types.IpProtocolEnumField: tools.get_random_ip_protocol,"},{"line_number":387,"context_line":"    common_types.PortRangeField: tools.get_random_port,"},{"line_number":388,"context_line":"    common_types.ListOfUUIDsField: lambda: [],"},{"line_number":389,"context_line":"}"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_5e6e2797","line":388,"range":{"start_line":388,"start_character":3,"end_line":388,"end_character":45},"in_reply_to":"1ac06dbe_aea42957","updated":"2016-08-24 16:37:19.000000000","message":"Done","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e440dce5fa39d44b45b6a6400c00695427cce822","unresolved":false,"context_lines":[{"line_number":403,"context_line":"    obj_fields.DictOfStringsField: get_random_dict_of_strings,"},{"line_number":404,"context_line":"    common_types.DomainNameField: get_random_domain_name,"},{"line_number":405,"context_line":"    common_types.DscpMarkField: get_random_dscp_mark,"},{"line_number":406,"context_line":"    common_types.FlowDirectionEnumField: get_random_direction,"},{"line_number":407,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":408,"context_line":"    common_types.IPNetworkField: tools.get_random_ip_network,"},{"line_number":409,"context_line":"    common_types.IPNetworkPrefixLenField: tools.get_random_prefixlen,"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_45c9195a","line":406,"updated":"2016-09-19 14:15:42.000000000","message":"This key is duplicated in the line number 416.","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"32c3a9d9847f00a9ea634a41e7690d0563ff491a","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"            # check that the stored database model does not have non-empty"},{"line_number":1284,"context_line":"            # relationships"},{"line_number":1285,"context_line":"            dbattr \u003d obj.fields_need_translation.get(field, field)"},{"line_number":1286,"context_line":"            self.assertFalse(getattr(obj.db_obj, dbattr, None))"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"            if isinstance(cls_.fields[field], obj_fields.ObjectField):"},{"line_number":1289,"context_line":"                objclass_fields \u003d self._get_non_synth_fields(objclass,"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_1161d339","line":1286,"range":{"start_line":1286,"start_character":12,"end_line":1286,"end_character":63},"updated":"2016-09-14 19:00:19.000000000","message":"#note Port db test cases are failing with it","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e440dce5fa39d44b45b6a6400c00695427cce822","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"            # check that the stored database model does not have non-empty"},{"line_number":1284,"context_line":"            # relationships"},{"line_number":1285,"context_line":"            dbattr \u003d obj.fields_need_translation.get(field, field)"},{"line_number":1286,"context_line":"            self.assertFalse(getattr(obj.db_obj, dbattr, None))"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"            if isinstance(cls_.fields[field], obj_fields.ObjectField):"},{"line_number":1289,"context_line":"                objclass_fields \u003d self._get_non_synth_fields(objclass,"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_250ded37","line":1286,"range":{"start_line":1286,"start_character":12,"end_line":1286,"end_character":63},"in_reply_to":"7a8ec9b2_1161d339","updated":"2016-09-19 14:15:42.000000000","message":"actually it was failing the line 1308 because the binding_levels property was not present in the db object.  I\u0027ve included it in the next PS[1]\n\n[1] https://review.openstack.org/#/c/351368/30/neutron/plugins/ml2/models.py@80","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"5f9d467b160152cf2a737347b629c029b17cdd9b","unresolved":false,"context_lines":[{"line_number":1283,"context_line":"            # check that the stored database model does not have non-empty"},{"line_number":1284,"context_line":"            # relationships"},{"line_number":1285,"context_line":"            dbattr \u003d obj.fields_need_translation.get(field, field)"},{"line_number":1286,"context_line":"            self.assertFalse(getattr(obj.db_obj, dbattr, None))"},{"line_number":1287,"context_line":""},{"line_number":1288,"context_line":"            if isinstance(cls_.fields[field], obj_fields.ObjectField):"},{"line_number":1289,"context_line":"                objclass_fields \u003d self._get_non_synth_fields(objclass,"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_5ecd6a5c","line":1286,"range":{"start_line":1286,"start_character":12,"end_line":1286,"end_character":63},"in_reply_to":"7a8ec9b2_250ded37","updated":"2016-09-19 14:57:17.000000000","message":"Yes, it was failing because of not having the relationship. I\u0027m not sure if we want to add this missing relationship, since port object is quite expensive and loading extra values should be considered as performance degradation.","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"0384f1c51755c0e03cda8cb0e5269fe49567d762","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                continue"},{"line_number":1055,"context_line":"            for db_obj in self.db_objs:"},{"line_number":1056,"context_line":"                objclass_fields \u003d self.get_random_fields(objclass)"},{"line_number":1057,"context_line":"                if isinstance(self._test_class.fields[synth_field],"},{"line_number":1058,"context_line":"                              obj_fields.ObjectField):"},{"line_number":1059,"context_line":"                    db_obj[synth_field] \u003d objclass.db_model(**objclass_fields)"},{"line_number":1060,"context_line":"                else:"},{"line_number":1061,"context_line":"                    db_obj[synth_field] \u003d ["},{"line_number":1062,"context_line":"                        objclass.db_model(**objclass_fields)"},{"line_number":1063,"context_line":"                    ]"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def _create_test_network(self):"},{"line_number":1066,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_bfa0d344","line":1063,"range":{"start_line":1057,"start_character":1,"end_line":1063,"end_character":21},"updated":"2016-09-23 15:20:17.000000000","message":"I noticed that this change is also need it for routers[1]. Given that this affects other classes I just wondering if this can be handle by other patch\n\n[1] https://review.openstack.org/#/c/307964/21/neutron/tests/unit/objects/test_base.py@1034","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"ea427f422b666fe0fb4d4fb4d0ad796f7ee727cb","unresolved":false,"context_lines":[{"line_number":1054,"context_line":"                continue"},{"line_number":1055,"context_line":"            for db_obj in self.db_objs:"},{"line_number":1056,"context_line":"                objclass_fields \u003d self.get_random_fields(objclass)"},{"line_number":1057,"context_line":"                if isinstance(self._test_class.fields[synth_field],"},{"line_number":1058,"context_line":"                              obj_fields.ObjectField):"},{"line_number":1059,"context_line":"                    db_obj[synth_field] \u003d objclass.db_model(**objclass_fields)"},{"line_number":1060,"context_line":"                else:"},{"line_number":1061,"context_line":"                    db_obj[synth_field] \u003d ["},{"line_number":1062,"context_line":"                        objclass.db_model(**objclass_fields)"},{"line_number":1063,"context_line":"                    ]"},{"line_number":1064,"context_line":""},{"line_number":1065,"context_line":"    def _create_test_network(self):"},{"line_number":1066,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_481c7312","line":1063,"range":{"start_line":1057,"start_character":1,"end_line":1063,"end_character":21},"in_reply_to":"5a8bc5a2_bfa0d344","updated":"2016-09-23 15:52:36.000000000","message":"It can, but I really want to land this asap. I prefer we respin it quick.","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"0384f1c51755c0e03cda8cb0e5269fe49567d762","unresolved":false,"context_lines":[{"line_number":1280,"context_line":"            dbattr \u003d obj.fields_need_translation.get(field, field)"},{"line_number":1281,"context_line":"            self.assertFalse(getattr(obj.db_obj, dbattr, None))"},{"line_number":1282,"context_line":""},{"line_number":1283,"context_line":"            if isinstance(cls_.fields[field], obj_fields.ObjectField):"},{"line_number":1284,"context_line":"                objclass_fields \u003d self._get_non_synth_fields(objclass,"},{"line_number":1285,"context_line":"                                                             db_obj[field])"},{"line_number":1286,"context_line":"            else:"},{"line_number":1287,"context_line":"                objclass_fields \u003d self._get_non_synth_fields(objclass,"},{"line_number":1288,"context_line":"                                                             db_obj[field][0])"},{"line_number":1289,"context_line":""},{"line_number":1290,"context_line":"            # make sure children point to the base object"},{"line_number":1291,"context_line":"            foreign_keys \u003d objclass.foreign_keys.get(obj.__class__.__name__)"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_1fad4731","line":1288,"range":{"start_line":1283,"start_character":0,"end_line":1288,"end_character":78},"updated":"2016-09-23 15:20:17.000000000","message":"ditto: line 1057\n\n[1] https://review.openstack.org/#/c/307964/21/neutron/tests/unit/objects/test_base.py@1265","commit_id":"cfb0d2a409c933698c000a2d34daa83719a91fc2"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7d9c29c789bfc5550f992168c24815333e0fbc4e","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"            self._port_name_generator \u003d (\"test-port%d\" % i"},{"line_number":1102,"context_line":"                                         for i in itertools.count(1))"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":1105,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":1106,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":1107,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_eed35002","line":1104,"range":{"start_line":1104,"start_character":31,"end_line":1104,"end_character":49},"updated":"2016-09-26 10:38:54.000000000","message":"nit: We should generate uuid here.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7d3c2e219d3a7101ef5144da27456d34b0f546f","unresolved":false,"context_lines":[{"line_number":1101,"context_line":"            self._port_name_generator \u003d (\"test-port%d\" % i"},{"line_number":1102,"context_line":"                                         for i in itertools.count(1))"},{"line_number":1103,"context_line":""},{"line_number":1104,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":1105,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":1106,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":1107,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_c43d8790","line":1104,"range":{"start_line":1104,"start_character":31,"end_line":1104,"end_character":49},"in_reply_to":"5a8bc5a2_eed35002","updated":"2016-09-26 14:39:30.000000000","message":"Done","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c44344aad2a1dee1baa70cece5476f65e2a95f7e","unresolved":false,"context_lines":[{"line_number":355,"context_line":"    return random.choice(constants.VALID_DSCP_MARKS)"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"def get_random_direction():"},{"line_number":359,"context_line":"    return random.choice(constants.VALID_DIRECTIONS)"},{"line_number":360,"context_line":""},{"line_number":361,"context_line":""}],"source_content_type":"text/x-python","patch_set":39,"id":"3a98d1f4_a742733c","side":"PARENT","line":358,"updated":"2016-09-30 09:36:53.000000000","message":"nit: this seems unrelated.","commit_id":"f703f348941fa3958af74bc2fba1796934c2cbe2"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"c44344aad2a1dee1baa70cece5476f65e2a95f7e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"    obj_fields.ObjectField: lambda: None,"},{"line_number":377,"context_line":"    obj_fields.ListOfObjectsField: lambda: [],"},{"line_number":378,"context_line":"    common_types.DscpMarkField: get_random_dscp_mark,"},{"line_number":379,"context_line":"    common_types.FlowDirectionEnumField: get_random_direction,"},{"line_number":380,"context_line":"    obj_fields.IPNetworkField: tools.get_random_ip_network,"},{"line_number":381,"context_line":"    common_types.IPNetworkField: tools.get_random_ip_network,"},{"line_number":382,"context_line":"    common_types.IPNetworkPrefixLenField: tools.get_random_prefixlen,"}],"source_content_type":"text/x-python","patch_set":39,"id":"3a98d1f4_4778cf8f","side":"PARENT","line":379,"updated":"2016-09-30 09:36:53.000000000","message":"nit: Unrelated.","commit_id":"f703f348941fa3958af74bc2fba1796934c2cbe2"}],"neutron/tests/unit/objects/test_objects.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027IPAllocationPool\u0027: \u00271.0-371016a6480ed0b4299319cb46d9215d\u0027,"},{"line_number":37,"context_line":"    \u0027NetworkPortSecurity\u0027: \u00271.0-b30802391a87945ee9c07582b4ff95e3\u0027,"},{"line_number":38,"context_line":"    \u0027NetworkSegment\u0027: \u00271.0-865567a6f70eb85cf33fb7a5575a4eab\u0027,"},{"line_number":39,"context_line":"    \u0027Port\u0027: \u00271.0-8aa1bb97d9225fed13a0fe4ad1cfc6fe\u0027,"},{"line_number":40,"context_line":"    \u0027PortBinding\u0027: \u00271.0-f5d3048bec0ac58f08a758427581dff9\u0027,"},{"line_number":41,"context_line":"    \u0027PortBindingLevel\u0027: \u00271.0-de66a4c61a083b8f34319fa9dde5b060\u0027,"},{"line_number":42,"context_line":"    \u0027PortDNS\u0027: \u00271.0-201cf6d057fde75539c3d1f2bbf05902\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_8e04cd7e","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":49},"updated":"2016-08-20 10:59:25.000000000","message":"Due to UT this should be changed.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    \u0027IPAllocationPool\u0027: \u00271.0-371016a6480ed0b4299319cb46d9215d\u0027,"},{"line_number":37,"context_line":"    \u0027NetworkPortSecurity\u0027: \u00271.0-b30802391a87945ee9c07582b4ff95e3\u0027,"},{"line_number":38,"context_line":"    \u0027NetworkSegment\u0027: \u00271.0-865567a6f70eb85cf33fb7a5575a4eab\u0027,"},{"line_number":39,"context_line":"    \u0027Port\u0027: \u00271.0-8aa1bb97d9225fed13a0fe4ad1cfc6fe\u0027,"},{"line_number":40,"context_line":"    \u0027PortBinding\u0027: \u00271.0-f5d3048bec0ac58f08a758427581dff9\u0027,"},{"line_number":41,"context_line":"    \u0027PortBindingLevel\u0027: \u00271.0-de66a4c61a083b8f34319fa9dde5b060\u0027,"},{"line_number":42,"context_line":"    \u0027PortDNS\u0027: \u00271.0-201cf6d057fde75539c3d1f2bbf05902\u0027,"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_deb977cd","line":39,"range":{"start_line":39,"start_character":17,"end_line":39,"end_character":49},"in_reply_to":"1ac06dbe_8e04cd7e","updated":"2016-08-24 16:37:19.000000000","message":"Done","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"}],"neutron/tests/unit/objects/test_ports.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4aabecb9f6eab63d6719b25dfbe4e170a82c8a3e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                ipalloc[\u0027subnet_id\u0027] \u003d self._subnet.id"},{"line_number":39,"context_line":"                ipalloc[\u0027network_id\u0027] \u003d self._network[\u0027id\u0027]"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # TODO(ihrachys): add more tests for synthetic fields"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_7ee9421a","line":41,"range":{"start_line":41,"start_character":4,"end_line":41,"end_character":57},"updated":"2016-08-09 06:57:42.000000000","message":"not just synthetic fields you need to add more base tests for other objects added in this Portbinding and IP allocation as well and I think they should be done in same patch unless there is compelling reason for not doing so.","commit_id":"8fc951e56d54631bf5291bdd6707ebfbf385d77a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"fda61c698bcde119e501577a42e445a3daafa94b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7ac969e8_ac490791","updated":"2016-08-12 22:18:04.000000000","message":"well, I don\u0027t see test for PortDns here, how do you wanna align them keep them there in https://review.openstack.org/#/c/334695/23/neutron/objects/dns.py@59. but looking at path structure, It would make more sense to have them in this file","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0137c8cf64e1e568d9f24a02c27eb1bcf22717b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3ac371cc_6bcec384","in_reply_to":"7ac969e8_974b6b59","updated":"2016-08-15 08:37:41.000000000","message":"Done","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c06d045771837b9810a00280210dca307ef88ee8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"7ac969e8_974b6b59","in_reply_to":"7ac969e8_ac490791","updated":"2016-08-13 07:31:01.000000000","message":"Yeah, it should be here. Thanks for noticing, I need to walk thru new objects list to check that I cover everything.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a6d0cc2e5a4103e3f73ab3bef9db10fdacc9eef8","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(PortBindingVifDetailsTestCase, self).setUp()"},{"line_number":66,"context_line":"        self._create_test_network()"},{"line_number":67,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields):"},{"line_number":68,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":69,"context_line":"            obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _create_port(self, **port_attrs):"},{"line_number":72,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_8c08672a","line":69,"range":{"start_line":66,"start_character":7,"end_line":69,"end_character":36},"updated":"2016-08-12 17:54:29.000000000","message":"instead of writing these lines again in file can\u0027t you inherit from BasePortBindingDbObjectTestCase calling super setup will make use of already written code.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3214fe560ed7fb4f4a0ec794a81220d3e6fa9b5e","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(PortBindingVifDetailsTestCase, self).setUp()"},{"line_number":66,"context_line":"        self._create_test_network()"},{"line_number":67,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields):"},{"line_number":68,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":69,"context_line":"            obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _create_port(self, **port_attrs):"},{"line_number":72,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_c5518dda","line":69,"range":{"start_line":66,"start_character":7,"end_line":69,"end_character":36},"in_reply_to":"9ad45d7e_8c08672a","updated":"2016-08-12 20:36:34.000000000","message":"The Base* class would also add all test cases from test_base, which is not what we want here.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c172cd4e6d8487af975b8ea4a46b47cf39701ba6","unresolved":false,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def setUp(self):"},{"line_number":65,"context_line":"        super(PortBindingVifDetailsTestCase, self).setUp()"},{"line_number":66,"context_line":"        self._create_test_network()"},{"line_number":67,"context_line":"        for obj in itertools.chain(self.db_objs, self.obj_fields):"},{"line_number":68,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":69,"context_line":"            obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def _create_port(self, **port_attrs):"},{"line_number":72,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"}],"source_content_type":"text/x-python","patch_set":12,"id":"7ac969e8_4c3173ec","line":69,"range":{"start_line":66,"start_character":7,"end_line":69,"end_character":36},"in_reply_to":"9ad45d7e_c5518dda","updated":"2016-08-12 21:48:05.000000000","message":"thanks make sense now","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a6d0cc2e5a4103e3f73ab3bef9db10fdacc9eef8","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _create_test_network(self):"},{"line_number":84,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"},{"line_number":85,"context_line":"        # implementation for networks"},{"line_number":86,"context_line":"        self._network \u003d obj_db_api.create_object(self.context,"},{"line_number":87,"context_line":"                                                 models_v2.Network,"},{"line_number":88,"context_line":"                                                 {\u0027name\u0027: \u0027test-network1\u0027})"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _make_object(self, fields):"},{"line_number":91,"context_line":"        fields \u003d obj_test_base.get_non_synthetic_fields("}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_ac3d6bbd","line":88,"range":{"start_line":86,"start_character":8,"end_line":88,"end_character":75},"updated":"2016-08-12 17:54:29.000000000","message":"this also I feel redundant can\u0027t we _create_test_network instead of adding same call here again ?","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c172cd4e6d8487af975b8ea4a46b47cf39701ba6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _create_test_network(self):"},{"line_number":84,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"},{"line_number":85,"context_line":"        # implementation for networks"},{"line_number":86,"context_line":"        self._network \u003d obj_db_api.create_object(self.context,"},{"line_number":87,"context_line":"                                                 models_v2.Network,"},{"line_number":88,"context_line":"                                                 {\u0027name\u0027: \u0027test-network1\u0027})"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _make_object(self, fields):"},{"line_number":91,"context_line":"        fields \u003d obj_test_base.get_non_synthetic_fields("}],"source_content_type":"text/x-python","patch_set":12,"id":"7ac969e8_4c1a1370","line":88,"range":{"start_line":86,"start_character":8,"end_line":88,"end_character":75},"in_reply_to":"9ad45d7e_2504e9c4","updated":"2016-08-12 21:48:05.000000000","message":"thanks for explanation","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"3214fe560ed7fb4f4a0ec794a81220d3e6fa9b5e","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    def _create_test_network(self):"},{"line_number":84,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"},{"line_number":85,"context_line":"        # implementation for networks"},{"line_number":86,"context_line":"        self._network \u003d obj_db_api.create_object(self.context,"},{"line_number":87,"context_line":"                                                 models_v2.Network,"},{"line_number":88,"context_line":"                                                 {\u0027name\u0027: \u0027test-network1\u0027})"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    def _make_object(self, fields):"},{"line_number":91,"context_line":"        fields \u003d obj_test_base.get_non_synthetic_fields("}],"source_content_type":"text/x-python","patch_set":12,"id":"9ad45d7e_2504e9c4","line":88,"range":{"start_line":86,"start_character":8,"end_line":88,"end_character":75},"in_reply_to":"9ad45d7e_ac3d6bbd","updated":"2016-08-12 20:36:34.000000000","message":"Not without significant base test class refactoring, because the method you referred to is in the class that also injects test cases, which is not what we want here.","commit_id":"2423d0129140a409a6d978b3f9215d6661366f19"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"822292d58801e32f328de49f0505ff4beee64335","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3ac371cc_126fa6fc","updated":"2016-08-18 13:55:25.000000000","message":"should this file be called test_port? since other ones are called singular? test_subnet etc.","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d3a748a47e1711cf19e73fb34a41a9d22b912b58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"3ac371cc_78fb4948","in_reply_to":"3ac371cc_126fa6fc","updated":"2016-08-18 18:36:43.000000000","message":"+1, personally I feel naming should have less priority than more meaningful stuff, but still consistency is better","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e0b16b3c130f34c67cce94b9b15f65760cc4bf27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1ac06dbe_cfe8b019","in_reply_to":"3ac371cc_78fb4948","updated":"2016-08-19 12:26:43.000000000","message":"Generally agreed, but I may need to converge with existing neutron/objects/port directory. You can have both the module and the directory with the same name. I will send a follow up later that will fix it. Till that moment, we must have our test files named as test_\u003cmodule-targeted\u003e.py","commit_id":"a7729d21910b6edac6f3b2053217dbab16be994d"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"b5b5be8e14e30d4a1f0a5907347dc2dea69f7aa1","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        port.create()"},{"line_number":84,"context_line":"        return port"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_test_network(self):"},{"line_number":87,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"},{"line_number":88,"context_line":"        # implementation for networks"},{"line_number":89,"context_line":"        self._network \u003d obj_db_api.create_object(self.context,"},{"line_number":90,"context_line":"                                                 models_v2.Network,"},{"line_number":91,"context_line":"                                                 {\u0027name\u0027: \u0027test-network1\u0027})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _make_object(self, fields):"},{"line_number":94,"context_line":"        fields \u003d obj_test_base.get_non_synthetic_fields("}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_1b09662d","line":91,"range":{"start_line":86,"start_character":6,"end_line":91,"end_character":75},"updated":"2016-08-19 13:58:31.000000000","message":"I\u0027m wondering why it is copied from test_base?","commit_id":"55b05fd10de40e1673e7d7c9199e2065862efb67"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5344f81f8b950ca62c6426ef30cb21b9188df045","unresolved":false,"context_lines":[{"line_number":83,"context_line":"        port.create()"},{"line_number":84,"context_line":"        return port"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_test_network(self):"},{"line_number":87,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"},{"line_number":88,"context_line":"        # implementation for networks"},{"line_number":89,"context_line":"        self._network \u003d obj_db_api.create_object(self.context,"},{"line_number":90,"context_line":"                                                 models_v2.Network,"},{"line_number":91,"context_line":"                                                 {\u0027name\u0027: \u0027test-network1\u0027})"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"    def _make_object(self, fields):"},{"line_number":94,"context_line":"        fields \u003d obj_test_base.get_non_synthetic_fields("}],"source_content_type":"text/x-python","patch_set":17,"id":"1ac06dbe_75b0668c","line":91,"range":{"start_line":86,"start_character":6,"end_line":91,"end_character":75},"in_reply_to":"1ac06dbe_1b09662d","updated":"2016-08-19 14:01:07.000000000","message":"This test is not inheriting from the base class that would contain it. Doing so would pull in all other test cases into here, and would waste cpu cycles. I probably should add a comment here, a TODO to refactor the tests to remove the need to copy paste.","commit_id":"55b05fd10de40e1673e7d7c9199e2065862efb67"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import testscenarios"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":"from neutron.db import securitygroups_db as sg_db"},{"line_number":19,"context_line":"from neutron.objects import base as obj_base"},{"line_number":20,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":21,"context_line":"from neutron.objects import ports"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_ae038972","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":49},"updated":"2016-08-20 10:59:25.000000000","message":"Security groups model has been moved to neutron.db.models.securitygroup","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import testscenarios"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"from neutron.db import models_v2"},{"line_number":18,"context_line":"from neutron.db import securitygroups_db as sg_db"},{"line_number":19,"context_line":"from neutron.objects import base as obj_base"},{"line_number":20,"context_line":"from neutron.objects.db import api as obj_db_api"},{"line_number":21,"context_line":"from neutron.objects import ports"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_de8b371d","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":49},"in_reply_to":"1ac06dbe_ae038972","updated":"2016-08-24 16:37:19.000000000","message":"Done","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"d6a9e3c1f790114d7cdbf52b84ac54e6b0827bbd","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        obj.create()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":232,"context_line":"        self.assertEqual(groups, obj.security_group_ids)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        sg3 \u003d self._create_test_security_group()"},{"line_number":235,"context_line":"        obj.security_group_ids \u003d [sg3.id]"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_2ef03990","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":56},"updated":"2016-08-20 10:59:25.000000000","message":"We have to introduce some sorting for SG, since UT is erroring out due to different SG order.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"88b8dd9762e6cc50a1856467ce990ee9a5ad4819","unresolved":false,"context_lines":[{"line_number":229,"context_line":"        obj.create()"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":232,"context_line":"        self.assertEqual(groups, obj.security_group_ids)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        sg3 \u003d self._create_test_security_group()"},{"line_number":235,"context_line":"        obj.security_group_ids \u003d [sg3.id]"}],"source_content_type":"text/x-python","patch_set":20,"id":"1ac06dbe_09a91be0","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":56},"in_reply_to":"1ac06dbe_2ef03990","updated":"2016-08-24 16:37:19.000000000","message":"This should probably be a set instead.","commit_id":"e6219d1e06c28d5268fa29a2b30999cd77ba6113"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ac7150202cb3275aeff263b5269978559cd4562","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class PortBindingLevelIfaceObjTestCase("},{"line_number":176,"context_line":"        obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":177,"context_line":"    _test_class \u003d ports.PortBindingLevel"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def setUp(self):"},{"line_number":180,"context_line":"        super(PortBindingLevelIfaceObjTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_6a29929a","line":177,"updated":"2016-08-30 21:51:23.000000000","message":"nit: break line for better format","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8efd4904bf4733772fd2053211817cd1dfd210b","unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"class PortBindingLevelIfaceObjTestCase("},{"line_number":176,"context_line":"        obj_test_base.BaseObjectIfaceTestCase):"},{"line_number":177,"context_line":"    _test_class \u003d ports.PortBindingLevel"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    def setUp(self):"},{"line_number":180,"context_line":"        super(PortBindingLevelIfaceObjTestCase, self).setUp()"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_5bd0f8c9","line":177,"in_reply_to":"fa7ab95a_6a29929a","updated":"2016-08-31 13:57:48.000000000","message":"Done","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"5ac7150202cb3275aeff263b5269978559cd4562","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class PortBindingLevelDbObjectTestCase("},{"line_number":190,"context_line":"        obj_test_base.BaseDbObjectTestCase):"},{"line_number":191,"context_line":"    _test_class \u003d ports.PortBindingLevel"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class PortIfaceObjTestCase(obj_test_base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_4a05ae11","line":191,"updated":"2016-08-30 21:51:23.000000000","message":"nit: break line for better format","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a8efd4904bf4733772fd2053211817cd1dfd210b","unresolved":false,"context_lines":[{"line_number":188,"context_line":""},{"line_number":189,"context_line":"class PortBindingLevelDbObjectTestCase("},{"line_number":190,"context_line":"        obj_test_base.BaseDbObjectTestCase):"},{"line_number":191,"context_line":"    _test_class \u003d ports.PortBindingLevel"},{"line_number":192,"context_line":""},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"class PortIfaceObjTestCase(obj_test_base.BaseObjectIfaceTestCase):"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa7ab95a_7bd5bcb7","line":191,"in_reply_to":"fa7ab95a_4a05ae11","updated":"2016-08-31 13:57:48.000000000","message":"Done","commit_id":"acff7165bcb0525765c433604ca2cbcfdd64cace"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d1c2e86ae6cead61d03bac8c00668891c0a16e92","unresolved":false,"context_lines":[{"line_number":77,"context_line":"            port \u003d self._create_port(network_id\u003dself._network[\u0027id\u0027])"},{"line_number":78,"context_line":"            obj[\u0027port_id\u0027] \u003d port.id"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _create_port(self, **port_attrs):"},{"line_number":81,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":82,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":83,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":84,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"},{"line_number":85,"context_line":"                 \u0027device_owner\u0027: \u0027fake_owner\u0027,"},{"line_number":86,"context_line":"                 \u0027mac_address\u0027: tools.get_random_EUI()}"},{"line_number":87,"context_line":"        attrs.update(port_attrs)"},{"line_number":88,"context_line":"        port \u003d ports.Port(self.context, **attrs)"},{"line_number":89,"context_line":"        port.create()"},{"line_number":90,"context_line":"        return port"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _create_test_network(self):"},{"line_number":93,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_c985b7cf","line":90,"range":{"start_line":80,"start_character":0,"end_line":90,"end_character":19},"updated":"2016-09-02 00:07:54.000000000","message":"I really feel we are repeating lot of code, here because similar method is in test_base, i know inheriting from that would run extra test, which we may not want, for now this is ok but a good solution would be to have baseclass without any tests for methods like create_test_network and _create_test_ports to avoid redundant code,","commit_id":"75e33c94ca0c3547fad0aa2f7815b5d747e33210"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"d1c2e86ae6cead61d03bac8c00668891c0a16e92","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        port.create()"},{"line_number":90,"context_line":"        return port"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def _create_test_network(self):"},{"line_number":93,"context_line":"        # TODO(ihrachys): replace with network.create() once we get an object"},{"line_number":94,"context_line":"        # implementation for networks"},{"line_number":95,"context_line":"        self._network \u003d obj_db_api.create_object(self.context,"},{"line_number":96,"context_line":"                                                 models_v2.Network,"},{"line_number":97,"context_line":"                                                 {\u0027name\u0027: \u0027test-network1\u0027})"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def _make_object(self, fields):"},{"line_number":100,"context_line":"        fields \u003d obj_test_base.get_non_synthetic_fields("},{"line_number":101,"context_line":"            self._test_class, fields"},{"line_number":102,"context_line":"        )"},{"line_number":103,"context_line":"        return self._test_class("},{"line_number":104,"context_line":"            self.context,"},{"line_number":105,"context_line":"            **obj_test_base.remove_timestamps_from_fields(fields))"},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def test_vif_details(self):"},{"line_number":108,"context_line":"        vif_details \u003d {\u0027item1\u0027: \u0027val1\u0027, \u0027item2\u0027: \u0027val2\u0027}"}],"source_content_type":"text/x-python","patch_set":26,"id":"fa7ab95a_89500f34","line":105,"range":{"start_line":92,"start_character":1,"end_line":105,"end_character":66},"updated":"2016-09-02 00:07:54.000000000","message":"since we\u0027are already inheriting from _BaseObjectTestCase\nif you agree on solution suggested in above command I can volunteer to move common methods like these to _BaseObjectTestCase unless there is any harm for moving those","commit_id":"75e33c94ca0c3547fad0aa2f7815b5d747e33210"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"38449eaad40e1bc3ccb97c89c284636650e64ae6","unresolved":false,"context_lines":[{"line_number":58,"context_line":"    _test_class \u003d ports.DistributedPortBinding"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# TODO(ihrachys): this test case copies some functions from the base module."},{"line_number":62,"context_line":"# This is because we currently cannot inherit from the base class that contains"},{"line_number":63,"context_line":"# those functions, because that same class provides test cases that we don\u0027t"},{"line_number":64,"context_line":"# want to execute. Ideally, we would need to copy paste, but that would require"},{"line_number":65,"context_line":"# some significant refactoring in the base test classes. Leaving it for a"},{"line_number":66,"context_line":"# follow up."},{"line_number":67,"context_line":"class PortBindingVifDetailsTestCase(testscenarios.WithScenarios,"},{"line_number":68,"context_line":"                                    obj_test_base._BaseObjectTestCase,"},{"line_number":69,"context_line":"                                    testlib_api.SqlTestCase):"}],"source_content_type":"text/x-python","patch_set":28,"id":"9a89bdaa_a2117306","line":66,"range":{"start_line":61,"start_character":0,"end_line":66,"end_character":12},"updated":"2016-09-12 18:09:26.000000000","message":"My bad I missed this comment in ps 26. reusing code as much as we can make things simple.","commit_id":"999bb088de5654370a5b4f0df8fd147b20934d35"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"32c3a9d9847f00a9ea634a41e7690d0563ff491a","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        sg3 \u003d self._create_test_security_group()"},{"line_number":247,"context_line":"        obj.security_group_ids \u003d {sg3.id}"},{"line_number":248,"context_line":"        obj.update()"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":251,"context_line":"        self.assertEqual({sg3.id}, obj.security_group_ids)"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_111393b9","line":248,"range":{"start_line":248,"start_character":8,"end_line":248,"end_character":20},"updated":"2016-09-14 19:00:19.000000000","message":"this update i guess is not happening properly, may be a bug, is consistently failing at update point in test.","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"e440dce5fa39d44b45b6a6400c00695427cce822","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        sg3 \u003d self._create_test_security_group()"},{"line_number":247,"context_line":"        obj.security_group_ids \u003d {sg3.id}"},{"line_number":248,"context_line":"        obj.update()"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":251,"context_line":"        self.assertEqual({sg3.id}, obj.security_group_ids)"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_c5ce09b7","line":248,"range":{"start_line":248,"start_character":8,"end_line":248,"end_character":20},"in_reply_to":"7a8ec9b2_111393b9","updated":"2016-09-19 14:15:42.000000000","message":"For a weird reason, the security_group_ids and qos_policy_id properties are not in sync with other properties. I\u0027ve changed to this workaround[1]\n\n[1] https://review.openstack.org/#/c/351368/30/neutron/objects/ports.py@302","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"5f9d467b160152cf2a737347b629c029b17cdd9b","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        sg3 \u003d self._create_test_security_group()"},{"line_number":247,"context_line":"        obj.security_group_ids \u003d {sg3.id}"},{"line_number":248,"context_line":"        obj.update()"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":251,"context_line":"        self.assertEqual({sg3.id}, obj.security_group_ids)"}],"source_content_type":"text/x-python","patch_set":29,"id":"7a8ec9b2_390d1838","line":248,"range":{"start_line":248,"start_character":8,"end_line":248,"end_character":20},"in_reply_to":"7a8ec9b2_c5ce09b7","updated":"2016-09-19 14:57:17.000000000","message":"It is not weird reason, it is happening because when you call obj.update(), you are storing all non-synthetic fields in DB and reloading the synthetic fields from DB. In this case, the security_group_ids and qos_policy_id are synthetic fields, also the implementation in PS29 of update() function is incorrect, we are trying to set values restored from db, instead of using the new set values. PS30 implementation [1] has the correct solution for this problem.\n\n[1] https://review.openstack.org/#/c/351368/30/neutron/objects/ports.py@302","commit_id":"e6b34ad33b0b84e55588b262eb9ed5403c67850c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7d9c29c789bfc5550f992168c24815333e0fbc4e","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            obj.port_id \u003d port.id"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_port(self, **port_attrs):"},{"line_number":87,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":88,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":89,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":90,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_8e19ecd9","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":47},"updated":"2016-09-26 10:38:54.000000000","message":"nit: we should generate uuid here.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7d3c2e219d3a7101ef5144da27456d34b0f546f","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            obj.port_id \u003d port.id"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def _create_port(self, **port_attrs):"},{"line_number":87,"context_line":"        attrs \u003d {\u0027project_id\u0027: \u0027fake_project_id\u0027,"},{"line_number":88,"context_line":"                 \u0027admin_state_up\u0027: True,"},{"line_number":89,"context_line":"                 \u0027status\u0027: \u0027ACTIVE\u0027,"},{"line_number":90,"context_line":"                 \u0027device_id\u0027: \u0027fake_device\u0027,"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_a406bbcb","line":87,"range":{"start_line":87,"start_character":32,"end_line":87,"end_character":47},"in_reply_to":"5a8bc5a2_8e19ecd9","updated":"2016-09-26 14:39:30.000000000","message":"Done","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"7d9c29c789bfc5550f992168c24815333e0fbc4e","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":317,"context_line":"        self.assertEqual(policy_obj2.id, obj.qos_policy_id)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":320,"context_line":"        self.skipTest("},{"line_number":321,"context_line":"            \u0027Port object loads segment info without relationships\u0027)"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_09415638","line":321,"range":{"start_line":319,"start_character":8,"end_line":321,"end_character":67},"updated":"2016-09-26 10:38:54.000000000","message":"After adding relationship for PortBindingLevel, we should be able to fetch the port object with one query.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f7d3c2e219d3a7101ef5144da27456d34b0f546f","unresolved":false,"context_lines":[{"line_number":316,"context_line":"        obj \u003d ports.Port.get_object(self.context, id\u003dobj.id)"},{"line_number":317,"context_line":"        self.assertEqual(policy_obj2.id, obj.qos_policy_id)"},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"    def test_get_objects_queries_constant(self):"},{"line_number":320,"context_line":"        self.skipTest("},{"line_number":321,"context_line":"            \u0027Port object loads segment info without relationships\u0027)"}],"source_content_type":"text/x-python","patch_set":32,"id":"5a8bc5a2_441fb707","line":321,"range":{"start_line":319,"start_character":8,"end_line":321,"end_character":67},"in_reply_to":"5a8bc5a2_09415638","updated":"2016-09-26 14:39:30.000000000","message":"No, as I explained in commit message comments.","commit_id":"bcaa13fd21b8d808c1479809691ee21835378878"}]}
