)]}'
{"doc/source/devref/db_models.rst":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2dc152c9830027cb6882281c03b095c524a6099f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"},{"line_number":19,"context_line":"      +++++++  Heading 3"},{"line_number":20,"context_line":"      \u0027\u0027\u0027\u0027\u0027\u0027\u0027  Heading 4"},{"line_number":21,"context_line":"      (Avoid deeper levels because they do not render well.)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Relocation of Database Models"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_d418a886","line":21,"range":{"start_line":15,"start_character":0,"end_line":21,"end_character":60},"updated":"2016-08-05 00:55:32.000000000","message":"We can probably get rid of this","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"82d54b8e2955136dc1d188abb988ed4a53d5db8f","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"      Convention for heading levels in Neutron devref:"},{"line_number":16,"context_line":"      \u003d\u003d\u003d\u003d\u003d\u003d\u003d  Heading 0 (reserved for the title in a document)"},{"line_number":17,"context_line":"      -------  Heading 1"},{"line_number":18,"context_line":"      ~~~~~~~  Heading 2"},{"line_number":19,"context_line":"      +++++++  Heading 3"},{"line_number":20,"context_line":"      \u0027\u0027\u0027\u0027\u0027\u0027\u0027  Heading 4"},{"line_number":21,"context_line":"      (Avoid deeper levels because they do not render well.)"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Relocation of Database Models"},{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_6f33b014","line":21,"range":{"start_line":15,"start_character":0,"end_line":21,"end_character":60},"in_reply_to":"bacf61ea_d418a886","updated":"2016-08-06 00:02:09.000000000","message":"Done","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2dc152c9830027cb6882281c03b095c524a6099f","unresolved":false,"context_lines":[{"line_number":24,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This devref is intended to track and notify developers that db models in"},{"line_number":27,"context_line":"neutron will be centralized and moved to new tree under neutron/db/models."},{"line_number":28,"context_line":"This was discussed in [1]. The reason for relocating db models is to solve "},{"line_number":29,"context_line":"the cyclic import issue while implementing oslo versioned objects for"},{"line_number":30,"context_line":"resources in neutron."}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_171d2262","line":27,"range":{"start_line":27,"start_character":41,"end_line":27,"end_character":44},"updated":"2016-08-05 00:55:32.000000000","message":"\"a new\" maybe?","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2dc152c9830027cb6882281c03b095c524a6099f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"This devref is intended to track and notify developers that db models in"},{"line_number":27,"context_line":"neutron will be centralized and moved to new tree under neutron/db/models."},{"line_number":28,"context_line":"This was discussed in [1]. The reason for relocating db models is to solve "},{"line_number":29,"context_line":"the cyclic import issue while implementing oslo versioned objects for"},{"line_number":30,"context_line":"resources in neutron."},{"line_number":31,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_540dd83c","line":28,"range":{"start_line":28,"start_character":74,"end_line":28,"end_character":75},"updated":"2016-08-05 00:55:32.000000000","message":"You have a white space here","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2dc152c9830027cb6882281c03b095c524a6099f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"resources in neutron."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The reason behind this relocation is mixin class and db models for some"},{"line_number":33,"context_line":"resources in neutron are in same class. In Mixin classes there are some db"},{"line_number":34,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":35,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":36,"context_line":"files will be importing models and and Mixin need to import those objects which"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_772e1e8d","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":38},"updated":"2016-08-05 00:55:32.000000000","message":"did you mean \u0027module\u0027 or \u0027file\u0027 perhaps?","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"82d54b8e2955136dc1d188abb988ed4a53d5db8f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"resources in neutron."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"The reason behind this relocation is mixin class and db models for some"},{"line_number":33,"context_line":"resources in neutron are in same class. In Mixin classes there are some db"},{"line_number":34,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":35,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":36,"context_line":"files will be importing models and and Mixin need to import those objects which"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_8f3c24e2","line":33,"range":{"start_line":33,"start_character":33,"end_line":33,"end_character":38},"in_reply_to":"bacf61ea_772e1e8d","updated":"2016-08-06 00:02:09.000000000","message":"module! thanks for pointing out","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2dc152c9830027cb6882281c03b095c524a6099f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"resources in neutron are in same class. In Mixin classes there are some db"},{"line_number":34,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":35,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":36,"context_line":"files will be importing models and and Mixin need to import those objects which"},{"line_number":37,"context_line":"will end up in cyclic import."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Structure of Model Definitions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_57695abd","line":36,"range":{"start_line":36,"start_character":31,"end_line":36,"end_character":34},"updated":"2016-08-05 00:55:32.000000000","message":"Duplicate","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"82d54b8e2955136dc1d188abb988ed4a53d5db8f","unresolved":false,"context_lines":[{"line_number":33,"context_line":"resources in neutron are in same class. In Mixin classes there are some db"},{"line_number":34,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":35,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":36,"context_line":"files will be importing models and and Mixin need to import those objects which"},{"line_number":37,"context_line":"will end up in cyclic import."},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"Structure of Model Definitions"}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_2f2ed8a4","line":36,"range":{"start_line":36,"start_character":31,"end_line":36,"end_character":34},"in_reply_to":"bacf61ea_57695abd","updated":"2016-08-06 00:02:09.000000000","message":"Done","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"2dc152c9830027cb6882281c03b095c524a6099f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"those models. All relocated models need to use deprecate method that"},{"line_number":46,"context_line":"will generate a warning and return new class for use of old class. Some"},{"line_number":47,"context_line":"examples of relocated models [3] and [4]. In future if you define new models"},{"line_number":48,"context_line":"please make sure they are seprated from mixins and are under tree"},{"line_number":49,"context_line":"neutron/db/models/"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_57b03a43","line":48,"range":{"start_line":48,"start_character":26,"end_line":48,"end_character":34},"updated":"2016-08-05 00:55:32.000000000","message":"separated","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"82d54b8e2955136dc1d188abb988ed4a53d5db8f","unresolved":false,"context_lines":[{"line_number":45,"context_line":"those models. All relocated models need to use deprecate method that"},{"line_number":46,"context_line":"will generate a warning and return new class for use of old class. Some"},{"line_number":47,"context_line":"examples of relocated models [3] and [4]. In future if you define new models"},{"line_number":48,"context_line":"please make sure they are seprated from mixins and are under tree"},{"line_number":49,"context_line":"neutron/db/models/"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"bacf61ea_0f29549b","line":48,"range":{"start_line":48,"start_character":26,"end_line":48,"end_character":34},"in_reply_to":"bacf61ea_57b03a43","updated":"2016-08-06 00:02:09.000000000","message":"Done","commit_id":"1ae1284991386b78d35aacc3ef16c128a6afe406"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"dec9485be00791845e5e103b049ad49c25abdf98","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Relocation of Database Models"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This devref is intended to track and notify developers that db models in"},{"line_number":19,"context_line":"neutron will be centralized and moved to a new tree under neutron/db/models."},{"line_number":20,"context_line":"This was discussed in [1]. The reason for relocating db models is to solve"},{"line_number":21,"context_line":"the cyclic import issue while implementing oslo versioned objects for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_51b44df1","line":18,"updated":"2016-08-08 17:33:28.000000000","message":"s/devref/documentation","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":15,"context_line":"Relocation of Database Models"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"This devref is intended to track and notify developers that db models in"},{"line_number":19,"context_line":"neutron will be centralized and moved to a new tree under neutron/db/models."},{"line_number":20,"context_line":"This was discussed in [1]. The reason for relocating db models is to solve"},{"line_number":21,"context_line":"the cyclic import issue while implementing oslo versioned objects for"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_82094b34","line":18,"in_reply_to":"9ad45d7e_51b44df1","updated":"2016-08-08 23:07:22.000000000","message":"Done","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"dec9485be00791845e5e103b049ad49c25abdf98","unresolved":false,"context_lines":[{"line_number":22,"context_line":"resources in neutron."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The reason behind this relocation is mixin class and db models for some"},{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes there are some db"},{"line_number":26,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":27,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":28,"context_line":"files will be importing models and Mixin need to import those objects which"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_51abad89","line":25,"updated":"2016-08-08 17:33:28.000000000","message":"Mixin capitalized here, but not in previous sentence. Keep consistent","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":22,"context_line":"resources in neutron."},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The reason behind this relocation is mixin class and db models for some"},{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes there are some db"},{"line_number":26,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":27,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":28,"context_line":"files will be importing models and Mixin need to import those objects which"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_e206471f","line":25,"in_reply_to":"9ad45d7e_51abad89","updated":"2016-08-08 23:07:22.000000000","message":"Done","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"dec9485be00791845e5e103b049ad49c25abdf98","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The reason behind this relocation is mixin class and db models for some"},{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes there are some db"},{"line_number":26,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":27,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":28,"context_line":"files will be importing models and Mixin need to import those objects which"},{"line_number":29,"context_line":"will end up in cyclic import."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_917c0522","line":26,"updated":"2016-08-08 17:33:28.000000000","message":"\"queries that will be replaced\"... Sentence kind of confusing. reword/break up.","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The reason behind this relocation is mixin class and db models for some"},{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes there are some db"},{"line_number":26,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":27,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":28,"context_line":"files will be importing models and Mixin need to import those objects which"},{"line_number":29,"context_line":"will end up in cyclic import."}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_c203430e","line":26,"in_reply_to":"9ad45d7e_917c0522","updated":"2016-08-08 23:07:22.000000000","message":"Done","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"dec9485be00791845e5e103b049ad49c25abdf98","unresolved":false,"context_lines":[{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes there are some db"},{"line_number":26,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":27,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":28,"context_line":"files will be importing models and Mixin need to import those objects which"},{"line_number":29,"context_line":"will end up in cyclic import."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Structure of Model Definitions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_d1767d3d","line":28,"updated":"2016-08-08 17:33:28.000000000","message":"\"Mixin\" ditto above","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes there are some db"},{"line_number":26,"context_line":"queries that have been done which will be replaced with use of versioned"},{"line_number":27,"context_line":"objects and definition of versioned object will be using db models. So object"},{"line_number":28,"context_line":"files will be importing models and Mixin need to import those objects which"},{"line_number":29,"context_line":"will end up in cyclic import."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Structure of Model Definitions"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_05044513","line":28,"in_reply_to":"9ad45d7e_d1767d3d","updated":"2016-08-08 23:07:22.000000000","message":"Done","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"dec9485be00791845e5e103b049ad49c25abdf98","unresolved":false,"context_lines":[{"line_number":29,"context_line":"will end up in cyclic import."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Structure of Model Definitions"},{"line_number":32,"context_line":"-----------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We have decided to move all models definitions to neutron/db/models/"},{"line_number":35,"context_line":"with no futher nesting after that point. The deprecation method [2] to move"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_b1ee69ea","line":32,"updated":"2016-08-08 17:33:28.000000000","message":"add \"-\" under the \u0027s\u0027 in Definitions","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":29,"context_line":"will end up in cyclic import."},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"Structure of Model Definitions"},{"line_number":32,"context_line":"-----------------------------"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"We have decided to move all models definitions to neutron/db/models/"},{"line_number":35,"context_line":"with no futher nesting after that point. The deprecation method [2] to move"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_a513b95b","line":32,"in_reply_to":"9ad45d7e_b1ee69ea","updated":"2016-08-08 23:07:22.000000000","message":"Done","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":18332,"name":"Ankur","email":"ankur.gupta@intel.com","username":"ankur-gupta-f"},"change_message_id":"dec9485be00791845e5e103b049ad49c25abdf98","unresolved":false,"context_lines":[{"line_number":40,"context_line":"please make sure they are separated from mixins and are under tree"},{"line_number":41,"context_line":"neutron/db/models/"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"References"},{"line_number":45,"context_line":"~~~~~~~~~~"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_d1db1d1a","line":43,"updated":"2016-08-08 17:33:28.000000000","message":"Potentially use bullet points to describe dir.\n\nSimilar to https://github.com/openstack/horizon/blob/master/doc/source/quickstart.rst towards the bottom under \"Structure\"","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":40,"context_line":"please make sure they are separated from mixins and are under tree"},{"line_number":41,"context_line":"neutron/db/models/"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"References"},{"line_number":45,"context_line":"~~~~~~~~~~"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_42175351","line":43,"in_reply_to":"9ad45d7e_d1db1d1a","updated":"2016-08-08 23:07:22.000000000","message":"bullet point make sense it is a long process, involving different steps, which is not in this case,","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":22524,"name":"Mohit Malik","email":"mohit.malik@intel.com","username":"mmalik4"},"change_message_id":"a75d224f46505d646dd9ff7f6836dd5138dd2881","unresolved":false,"context_lines":[{"line_number":45,"context_line":"~~~~~~~~~~"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[1]. https://www.mail-archive.com/openstack-dev@lists.openstack.org/msg88910.html"},{"line_number":48,"context_line":"[2]. https://review.openstack.org/#/c/351327/"},{"line_number":49,"context_line":"[3]. https://review.openstack.org/#/c/348562/"},{"line_number":50,"context_line":"[4]. https://review.openstack.org/#/c/348757/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_2617dca4","line":48,"updated":"2016-08-08 19:08:53.000000000","message":"This review patch has been abandoned. Should we update this with the other proposal which was mentioned by Henry in https://review.openstack.org/#/c/348562/","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3333b8dbbaadfe406c9e243da71e8995c3d4f4b1","unresolved":false,"context_lines":[{"line_number":45,"context_line":"~~~~~~~~~~"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"[1]. https://www.mail-archive.com/openstack-dev@lists.openstack.org/msg88910.html"},{"line_number":48,"context_line":"[2]. https://review.openstack.org/#/c/351327/"},{"line_number":49,"context_line":"[3]. https://review.openstack.org/#/c/348562/"},{"line_number":50,"context_line":"[4]. https://review.openstack.org/#/c/348757/"}],"source_content_type":"text/x-rst","patch_set":2,"id":"9ad45d7e_c51a2d6e","line":48,"in_reply_to":"9ad45d7e_2617dca4","updated":"2016-08-08 23:07:22.000000000","message":"thanks for pointing out I am gonna remove this","commit_id":"95591b739390485802cd4361bc71667d44a07b90"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a30a50e22c1106c5946c351bef0fff26d3065ea","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The reason behind this relocation is Mixin class and db models for some"},{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes, there are methods"},{"line_number":26,"context_line":"which provides functionality of fetching, adding, updating and deleting data"},{"line_number":27,"context_line":"via queries. These queries will be replaced with use of versioned objects and"},{"line_number":28,"context_line":"definition of versioned object will be using db models. So object files will"},{"line_number":29,"context_line":"be importing models and Mixin need to import those objects which will end up"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_072f09f7","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":14},"updated":"2016-08-09 13:43:01.000000000","message":"provide","commit_id":"2ef023b0152a102fb3afacf9598f212e5d8f590f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"61ca2676dcc3062ba025ab5ac601ec877b2814ce","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"The reason behind this relocation is Mixin class and db models for some"},{"line_number":25,"context_line":"resources in neutron are in same module. In Mixin classes, there are methods"},{"line_number":26,"context_line":"which provides functionality of fetching, adding, updating and deleting data"},{"line_number":27,"context_line":"via queries. These queries will be replaced with use of versioned objects and"},{"line_number":28,"context_line":"definition of versioned object will be using db models. So object files will"},{"line_number":29,"context_line":"be importing models and Mixin need to import those objects which will end up"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9ad45d7e_27c84d22","line":26,"range":{"start_line":26,"start_character":6,"end_line":26,"end_character":14},"in_reply_to":"9ad45d7e_072f09f7","updated":"2016-08-09 13:44:00.000000000","message":"Done","commit_id":"2ef023b0152a102fb3afacf9598f212e5d8f590f"}],"neutron/db/models/README":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"5a30a50e22c1106c5946c351bef0fff26d3065ea","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron. The expected directory structure is flat, meaning there should be no"},{"line_number":3,"context_line":"subdirectories."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9ad45d7e_a7555d51","line":3,"updated":"2016-08-09 13:43:01.000000000","message":"we should also mention that names of modules should use singular form for nouns. port.py not ports.py.","commit_id":"2ef023b0152a102fb3afacf9598f212e5d8f590f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"61ca2676dcc3062ba025ab5ac601ec877b2814ce","unresolved":false,"context_lines":[{"line_number":1,"context_line":"This directory is designed to contain all SQLAlchemy models shipped with core"},{"line_number":2,"context_line":"Neutron. The expected directory structure is flat, meaning there should be no"},{"line_number":3,"context_line":"subdirectories."}],"source_content_type":"application/octet-stream","patch_set":3,"id":"9ad45d7e_07f2696f","line":3,"in_reply_to":"9ad45d7e_a7555d51","updated":"2016-08-09 13:44:00.000000000","message":"Done","commit_id":"2ef023b0152a102fb3afacf9598f212e5d8f590f"}]}
