)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a873d5ee49997481b073db23a684f44accada917","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LIU Yulong \u003cliuyulong@le.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-10 18:13:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct floating IP updating with empty dict issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_acc60b47","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"updated":"2016-08-12 18:08:42.000000000","message":"Fix","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7cf9dbaf8ccf19ed429e7c02c7d86c0639922b8","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     LIU Yulong \u003cliuyulong@le.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-10 18:13:07 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct floating IP updating with empty dict issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ac969e8_c67377b3","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":7},"in_reply_to":"9ad45d7e_acc60b47","updated":"2016-08-13 03:35:18.000000000","message":"Done","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a873d5ee49997481b073db23a684f44accada917","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct floating IP updating with empty dict issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds a data dict check for updating floating IP"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_6c39b341","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":7},"updated":"2016-08-12 18:08:42.000000000","message":"it passed","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a873d5ee49997481b073db23a684f44accada917","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct floating IP updating with empty dict issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds a data dict check for updating floating IP"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_2c169ba7","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":9},"updated":"2016-08-12 18:08:42.000000000","message":"s/a/an","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7cf9dbaf8ccf19ed429e7c02c7d86c0639922b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct floating IP updating with empty dict issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds a data dict check for updating floating IP"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ac969e8_066e2fc9","line":9,"range":{"start_line":9,"start_character":8,"end_line":9,"end_character":9},"in_reply_to":"9ad45d7e_2c169ba7","updated":"2016-08-13 03:35:18.000000000","message":"Done","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7cf9dbaf8ccf19ed429e7c02c7d86c0639922b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Correct floating IP updating with empty dict issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds a data dict check for updating floating IP"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ac969e8_e672f3ac","line":9,"range":{"start_line":9,"start_character":3,"end_line":9,"end_character":7},"in_reply_to":"9ad45d7e_6c39b341","updated":"2016-08-13 03:35:18.000000000","message":"Done","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"a873d5ee49997481b073db23a684f44accada917","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds a data dict check for updating floating IP"},{"line_number":13,"context_line":"to avoid changing its association."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1219a183722e1a22b743cbfcd7c6981db9b1eba6"},{"line_number":16,"context_line":"Closes-Bug: #1610045"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_acd72bbe","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":33},"updated":"2016-08-12 18:08:42.000000000","message":"This patch adds a validation that avoids changing its association when it\u0027s updating floating IP.","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"e7cf9dbaf8ccf19ed429e7c02c7d86c0639922b8","unresolved":false,"context_lines":[{"line_number":9,"context_line":"If pass a empty `{}` data dict to the floating IP update API,"},{"line_number":10,"context_line":"the associated floating IP will be dissociated from its port."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This patch adds a data dict check for updating floating IP"},{"line_number":13,"context_line":"to avoid changing its association."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I1219a183722e1a22b743cbfcd7c6981db9b1eba6"},{"line_number":16,"context_line":"Closes-Bug: #1610045"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7ac969e8_466827bb","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":33},"in_reply_to":"9ad45d7e_acd72bbe","updated":"2016-08-13 03:35:18.000000000","message":"Done","commit_id":"aed4b318773c17f5b53855359f4e1e98b6cae5af"}],"neutron/db/l3_db.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e6adfad2efa6034227b8ba151e430f9d00b4c326","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1299,"context_line":"            floatingip_db \u003d self._get_floatingip(context, id)"},{"line_number":1300,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_db)"},{"line_number":1301,"context_line":"            if fip:"},{"line_number":1302,"context_line":"                fip_port_id \u003d floatingip_db[\u0027floating_port_id\u0027]"},{"line_number":1303,"context_line":"                self._update_fip_assoc(context, fip, floatingip_db,"},{"line_number":1304,"context_line":"                                       self._core_plugin.get_port("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_9591a149","line":1301,"updated":"2016-09-19 10:52:37.000000000","message":"If fip has description set, but no port_id, then this block will still enter.\n\nMaybe check if the specific relevant fields are set (port_id, fixed_ip_address, etc.)?","commit_id":"6e95788e4712d95fa710e8a6aaa005132183f5da"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2eb2a87bd5b12fa9d92ef4e9c5bcc5d50b83fa0b","unresolved":false,"context_lines":[{"line_number":1298,"context_line":"        with context.session.begin(subtransactions\u003dTrue):"},{"line_number":1299,"context_line":"            floatingip_db \u003d self._get_floatingip(context, id)"},{"line_number":1300,"context_line":"            old_floatingip \u003d self._make_floatingip_dict(floatingip_db)"},{"line_number":1301,"context_line":"            if fip:"},{"line_number":1302,"context_line":"                fip_port_id \u003d floatingip_db[\u0027floating_port_id\u0027]"},{"line_number":1303,"context_line":"                self._update_fip_assoc(context, fip, floatingip_db,"},{"line_number":1304,"context_line":"                                       self._core_plugin.get_port("}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_93d2995a","line":1301,"in_reply_to":"7a8ec9b2_9591a149","updated":"2016-09-19 11:23:09.000000000","message":"Ha, you\u0027ve mentioned that issue was fixed here:\nhttps://review.openstack.org/#/c/312849/","commit_id":"6e95788e4712d95fa710e8a6aaa005132183f5da"}],"neutron/tests/tempest/api/test_floating_ips.py":[{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"3e276abee6618218545ebe1fcd9556e64cb0877c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_blank_update_clears_association(self):"},{"line_number":46,"context_line":"        # originally the floating IP had no attributes other than its"},{"line_number":47,"context_line":"        # association, so an update with an empty body was a signal to"},{"line_number":48,"context_line":"        # clear the association. This test ensures we maintain that behavior."},{"line_number":49,"context_line":"        body \u003d self.client.create_floatingip("},{"line_number":50,"context_line":"            floating_network_id\u003dself.ext_net_id,"},{"line_number":51,"context_line":"            port_id\u003dself.ports[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_3e43656d","side":"PARENT","line":48,"updated":"2016-09-18 18:01:47.000000000","message":"Doesn\u0027t this comment mean that what you are changing exists by design?","commit_id":"2fc9c3e75fe2fb8f53cd6ca2ff27318f1a4d09a4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"2eb2a87bd5b12fa9d92ef4e9c5bcc5d50b83fa0b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_blank_update_clears_association(self):"},{"line_number":46,"context_line":"        # originally the floating IP had no attributes other than its"},{"line_number":47,"context_line":"        # association, so an update with an empty body was a signal to"},{"line_number":48,"context_line":"        # clear the association. This test ensures we maintain that behavior."},{"line_number":49,"context_line":"        body \u003d self.client.create_floatingip("},{"line_number":50,"context_line":"            floating_network_id\u003dself.ext_net_id,"},{"line_number":51,"context_line":"            port_id\u003dself.ports[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_b30a35d0","side":"PARENT","line":48,"in_reply_to":"7a8ec9b2_35cfed56","updated":"2016-09-19 11:23:09.000000000","message":"Yep, this change may hurt those who use an empty API body to dissociate the floating IP.","commit_id":"2fc9c3e75fe2fb8f53cd6ca2ff27318f1a4d09a4"},{"author":{"_account_id":9531,"name":"liuyulong","display_name":"LIU Yulong","email":"i@liuyulong.me","username":"LIU-Yulong"},"change_message_id":"1377cb13bac91fb316aa0289006efc276afc3143","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_blank_update_clears_association(self):"},{"line_number":46,"context_line":"        # originally the floating IP had no attributes other than its"},{"line_number":47,"context_line":"        # association, so an update with an empty body was a signal to"},{"line_number":48,"context_line":"        # clear the association. This test ensures we maintain that behavior."},{"line_number":49,"context_line":"        body \u003d self.client.create_floatingip("},{"line_number":50,"context_line":"            floating_network_id\u003dself.ext_net_id,"},{"line_number":51,"context_line":"            port_id\u003dself.ports[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_d1f0af69","side":"PARENT","line":48,"in_reply_to":"7a8ec9b2_3e43656d","updated":"2016-09-19 02:36:25.000000000","message":"People has some different opinions of this, an empty dict should\nchange nothing, because API does not know what you want to do.\nBut now neutron makes this implicitly clearing the floating IP\nassociation.\nWhy this test is here, is because there maybe some cloud user\nuse empty API body to do such disassociation.\nAnd this patch will abandon such behavior.","commit_id":"2fc9c3e75fe2fb8f53cd6ca2ff27318f1a4d09a4"},{"author":{"_account_id":20229,"name":"Omer Anson","email":"omer.anson@toganetworks.com","username":"oanson"},"change_message_id":"e6adfad2efa6034227b8ba151e430f9d00b4c326","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    def test_blank_update_clears_association(self):"},{"line_number":46,"context_line":"        # originally the floating IP had no attributes other than its"},{"line_number":47,"context_line":"        # association, so an update with an empty body was a signal to"},{"line_number":48,"context_line":"        # clear the association. This test ensures we maintain that behavior."},{"line_number":49,"context_line":"        body \u003d self.client.create_floatingip("},{"line_number":50,"context_line":"            floating_network_id\u003dself.ext_net_id,"},{"line_number":51,"context_line":"            port_id\u003dself.ports[0][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":5,"id":"7a8ec9b2_35cfed56","side":"PARENT","line":48,"in_reply_to":"7a8ec9b2_d1f0af69","updated":"2016-09-19 10:52:37.000000000","message":"The test exists to maintain API compatibility, but I am not involved enough to know if this is something that should remain as-is, or can change.","commit_id":"2fc9c3e75fe2fb8f53cd6ca2ff27318f1a4d09a4"}]}
