)]}'
{"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _is_mac_update_allowed(self, port):"},{"line_number":105,"context_line":"        vif_type \u003d port.get(portbindings.VIF_TYPE)"},{"line_number":106,"context_line":"        if (vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND):"},{"line_number":107,"context_line":"            base_mac \u003d cfg.CONF.base_mac.split(\u0027:\u0027)"},{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1356d8cd","line":106,"updated":"2016-08-10 19:39:07.000000000","message":"nit: fewer parens \u003d\u003d happier eyes\n\n  if vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND:\n\nYou might also consider this which would allow you to indent the rest of the method less. Less indentation \u003d\u003d happier eyes.\n\n  if if vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND:\n      return False","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _is_mac_update_allowed(self, port):"},{"line_number":105,"context_line":"        vif_type \u003d port.get(portbindings.VIF_TYPE)"},{"line_number":106,"context_line":"        if (vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND):"},{"line_number":107,"context_line":"            base_mac \u003d cfg.CONF.base_mac.split(\u0027:\u0027)"},{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_0bc32fee","line":106,"in_reply_to":"9ad45d7e_1356d8cd","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3bc58244230bcbf089465092baad7be481edbcee","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        vif_type \u003d port.get(portbindings.VIF_TYPE)"},{"line_number":106,"context_line":"        if (vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND):"},{"line_number":107,"context_line":"            base_mac \u003d cfg.CONF.base_mac.split(\u0027:\u0027)"},{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("},{"line_number":110,"context_line":"                base_mac, port.get(\u0027mac_address\u0027), re.IGNORECASE)"},{"line_number":111,"context_line":"            if not (mac_match or bool(port.get(portbindings.PROFILE, None))):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_cfa303ff","line":108,"updated":"2016-08-10 14:43:53.000000000","message":"If the 4th octet of base_mac is non-zero, then you also have to include it here as it won\u0027t be random - see the comment in the config file and code in utils.get_random_mac()\n\nSo saying that it seems like this base_mac matching code should live over in utils.py with get_random_mac()","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        vif_type \u003d port.get(portbindings.VIF_TYPE)"},{"line_number":106,"context_line":"        if (vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND):"},{"line_number":107,"context_line":"            base_mac \u003d cfg.CONF.base_mac.split(\u0027:\u0027)"},{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("},{"line_number":110,"context_line":"                base_mac, port.get(\u0027mac_address\u0027), re.IGNORECASE)"},{"line_number":111,"context_line":"            if not (mac_match or bool(port.get(portbindings.PROFILE, None))):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_8baf1f29","line":108,"in_reply_to":"9ad45d7e_cfa303ff","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"3bc58244230bcbf089465092baad7be481edbcee","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("},{"line_number":110,"context_line":"                base_mac, port.get(\u0027mac_address\u0027), re.IGNORECASE)"},{"line_number":111,"context_line":"            if not (mac_match or bool(port.get(portbindings.PROFILE, None))):"},{"line_number":112,"context_line":"                return True"},{"line_number":113,"context_line":"        return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ccdb114e","line":111,"updated":"2016-08-10 14:43:53.000000000","message":"nit: don\u0027t need the None here","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("},{"line_number":110,"context_line":"                base_mac, port.get(\u0027mac_address\u0027), re.IGNORECASE)"},{"line_number":111,"context_line":"            if not (mac_match or bool(port.get(portbindings.PROFILE, None))):"},{"line_number":112,"context_line":"                return True"},{"line_number":113,"context_line":"        return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_3e800b8b","line":111,"in_reply_to":"9ad45d7e_ccdb114e","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("},{"line_number":110,"context_line":"                base_mac, port.get(\u0027mac_address\u0027), re.IGNORECASE)"},{"line_number":111,"context_line":"            if not (mac_match or bool(port.get(portbindings.PROFILE, None))):"},{"line_number":112,"context_line":"                return True"},{"line_number":113,"context_line":"        return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d3d1e058","line":111,"in_reply_to":"9ad45d7e_ccdb114e","updated":"2016-08-10 19:39:07.000000000","message":"nit: Don\u0027t need the \"bool(...)\" either. the \"or\" already puts this in a boolean context. Fewer parens, happier eyes. Actually, these two lines could be this to be easier on the eyes:\n\n  return not (mac_match or port.get(portbindings.PROFILE)","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"            base_mac \u003d base_mac[0] + \u0027:\u0027 + base_mac[1] + \u0027:\u0027 + base_mac[2]"},{"line_number":109,"context_line":"            mac_match \u003d re.match("},{"line_number":110,"context_line":"                base_mac, port.get(\u0027mac_address\u0027), re.IGNORECASE)"},{"line_number":111,"context_line":"            if not (mac_match or bool(port.get(portbindings.PROFILE, None))):"},{"line_number":112,"context_line":"                return True"},{"line_number":113,"context_line":"        return False"},{"line_number":114,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_eba85b22","line":111,"in_reply_to":"9ad45d7e_d3d1e058","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def update_port_postcommit(self, context):"},{"line_number":116,"context_line":"        port \u003d context.current"},{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_13e538db","line":117,"updated":"2016-08-10 19:39:07.000000000","message":"nit: this is a little out of place. I\u0027d just inline it.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def update_port_postcommit(self, context):"},{"line_number":116,"context_line":"        port \u003d context.current"},{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_0b6a0fee","line":117,"in_reply_to":"9ad45d7e_13e538db","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        port \u003d context.current"},{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"},{"line_number":121,"context_line":"                new_mac \u003d ("},{"line_number":122,"context_line":"                    db_base_plugin_v2.NeutronDbPluginV2._generate_mac())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_93abe874","line":119,"updated":"2016-08-10 19:39:07.000000000","message":"nit: no parens","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        port \u003d context.current"},{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"},{"line_number":121,"context_line":"                new_mac \u003d ("},{"line_number":122,"context_line":"                    db_base_plugin_v2.NeutronDbPluginV2._generate_mac())"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6b6bcbf1","line":119,"in_reply_to":"9ad45d7e_93abe874","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"99f8598254727f90d7675e8f3561d681d215d628","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"},{"line_number":121,"context_line":"                new_mac \u003d ("},{"line_number":122,"context_line":"                    db_base_plugin_v2.NeutronDbPluginV2._generate_mac())"},{"line_number":123,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1406ac85","line":120,"range":{"start_line":120,"start_character":21,"end_line":120,"end_character":43},"updated":"2016-08-11 06:50:43.000000000","message":"Does it make sense to include the _is_mac_update_allowed(..) method as part of NeutronDbPluginV2. That way, mech_driver will have no logic/conditions related to MAC address, and ensures separation of concerns.\n\nLet MAC related decisions happen at DB plugin layer.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"},{"line_number":121,"context_line":"                new_mac \u003d ("},{"line_number":122,"context_line":"                    db_base_plugin_v2.NeutronDbPluginV2._generate_mac())"},{"line_number":123,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_33d03cf6","line":120,"updated":"2016-08-10 19:39:07.000000000","message":"nit: ditto","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"5e55712ff39f20d452800d9398c9b6838d27fa36","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"},{"line_number":121,"context_line":"                new_mac \u003d ("},{"line_number":122,"context_line":"                    db_base_plugin_v2.NeutronDbPluginV2._generate_mac())"},{"line_number":123,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_09d66ef0","line":120,"range":{"start_line":120,"start_character":21,"end_line":120,"end_character":43},"in_reply_to":"9ad45d7e_1406ac85","updated":"2016-08-11 17:40:09.000000000","message":"will include the match related function in utils.py rather than in NeutronDbPluginV2.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        port_id \u003d port[\u0027id\u0027]"},{"line_number":118,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":119,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL):"},{"line_number":120,"context_line":"            if (self._is_mac_update_allowed(port)):"},{"line_number":121,"context_line":"                new_mac \u003d ("},{"line_number":122,"context_line":"                    db_base_plugin_v2.NeutronDbPluginV2._generate_mac())"},{"line_number":123,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_4b7087dc","line":120,"in_reply_to":"9ad45d7e_33d03cf6","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7cf5481abeefa30b3a29fe03e87d099548562d0e","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if self._is_mac_update_allowed(port):"},{"line_number":115,"context_line":"                new_mac \u003d db_base.NeutronDbPluginV2._generate_mac()"},{"line_number":116,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"},{"line_number":117,"context_line":"                db_base.NeutronDbPluginV2().update_port("},{"line_number":118,"context_line":"                    context._plugin_context, port[\u0027id\u0027],"},{"line_number":119,"context_line":"                    {attributes.PORT: port})"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_975ebd43","line":117,"updated":"2016-08-19 16:51:08.000000000","message":"Is now the time to provide a public API to make DB updates more readable?","commit_id":"5e0abcb39fdc1ab0b7727cd5a686bba753ea8e2f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c7c6001ba1098d3cc75f77febe2479eb3ee1eeab","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if self._is_mac_update_allowed(port):"},{"line_number":115,"context_line":"                new_mac \u003d db_base.NeutronDbPluginV2._generate_mac()"},{"line_number":116,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"},{"line_number":117,"context_line":"                db_base.NeutronDbPluginV2().update_port("},{"line_number":118,"context_line":"                    context._plugin_context, port[\u0027id\u0027],"},{"line_number":119,"context_line":"                    {attributes.PORT: port})"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_ed512210","line":117,"updated":"2016-08-19 16:51:18.000000000","message":"Is now the time to provide a public API to make DB updates more readable?","commit_id":"5e0abcb39fdc1ab0b7727cd5a686bba753ea8e2f"},{"author":{"_account_id":15130,"name":"Sonu","email":"sonu.sudhakaran@gmail.com","username":"sonu"},"change_message_id":"7bb3ff0befca6f2ce6cf4ebe587fb4310b5aecd7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"            if self._is_mac_update_allowed(port):"},{"line_number":115,"context_line":"                new_mac \u003d db_base.NeutronDbPluginV2._generate_mac()"},{"line_number":116,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"},{"line_number":117,"context_line":"                db_base.NeutronDbPluginV2().update_port("},{"line_number":118,"context_line":"                    context._plugin_context, port[\u0027id\u0027],"},{"line_number":119,"context_line":"                    {attributes.PORT: port})"},{"line_number":120,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_5109d1dc","line":117,"in_reply_to":"1ac06dbe_975ebd43","updated":"2016-08-25 06:12:27.000000000","message":"Are you saying that we expose ability to update port\u0027s MAC address through an \"Update Port\" API.\n\nWe really intend to update the MAC address of PCI-PT ports only. since the phy. mac address on the PCI Neutron port is owned by the Host, and must be cleared on VM delete operation.","commit_id":"5e0abcb39fdc1ab0b7727cd5a686bba753ea8e2f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e75addcecabb61238665dc76477814d803150cd6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def get_mappings(self, agent):"},{"line_number":82,"context_line":"        return agent[\u0027configurations\u0027].get(\u0027device_mappings\u0027, {})"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _is_mac_update_allowed(self, port):"},{"line_number":85,"context_line":"        vif_type \u003d port.get(portbindings.VIF_TYPE)"},{"line_number":86,"context_line":"        if vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND:"},{"line_number":87,"context_line":"            mac_match \u003d utils.is_base_mac(port.get(\u0027mac_address\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_3fc3a48a","line":84,"updated":"2016-11-02 12:36:46.000000000","message":"may be a \"_should_reset_mac\" function name is more self explanatory here ?","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"5479ee16fd44f10a2ecad635f26cf53db153e81b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"    def get_mappings(self, agent):"},{"line_number":82,"context_line":"        return agent[\u0027configurations\u0027].get(\u0027device_mappings\u0027, {})"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def _is_mac_update_allowed(self, port):"},{"line_number":85,"context_line":"        vif_type \u003d port.get(portbindings.VIF_TYPE)"},{"line_number":86,"context_line":"        if vif_type \u003d\u003d portbindings.VIF_TYPE_UNBOUND:"},{"line_number":87,"context_line":"            mac_match \u003d utils.is_base_mac(port.get(\u0027mac_address\u0027))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_75dcd418","line":84,"in_reply_to":"ba5da102_3fc3a48a","updated":"2016-11-07 03:17:47.000000000","message":"Done","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e75addcecabb61238665dc76477814d803150cd6","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            return not (mac_match or port.get(portbindings.PROFILE))"},{"line_number":89,"context_line":"        return False"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def update_port_postcommit(self, context):"},{"line_number":92,"context_line":"        port \u003d context.current"},{"line_number":93,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":94,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_3fe64415","line":91,"updated":"2016-11-02 12:36:46.000000000","message":"Can you explain when you expect this to be triggered in the sequence of events?,\n\nI\u0027m not sure if this is called when a port is unbound, (which looks to me what you\u0027re expecting) I could be wrong here","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"5479ee16fd44f10a2ecad635f26cf53db153e81b","unresolved":false,"context_lines":[{"line_number":88,"context_line":"            return not (mac_match or port.get(portbindings.PROFILE))"},{"line_number":89,"context_line":"        return False"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def update_port_postcommit(self, context):"},{"line_number":92,"context_line":"        port \u003d context.current"},{"line_number":93,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE)"},{"line_number":94,"context_line":"        if vnic_type \u003d\u003d portbindings.VNIC_DIRECT_PHYSICAL:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_751134af","line":91,"in_reply_to":"ba5da102_3fe64415","updated":"2016-11-07 03:17:47.000000000","message":"The mac address of the direct-physical neutron port\nshould be flushed and should be assigned with a\nrandomly generated mac address after the\nVM associated with that port is deleted.\n\nHaving said that, every port update i.e in this case from bounded port to unbounded port (PCIPT VM deletion case), Update_port_postcommit is triggered. \nwe need to flush the mac address of the port.","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"705e7bebb762a1537922946e11c1d5956e2b45eb","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            if self._should_reset_mac(port):"},{"line_number":96,"context_line":"                new_mac \u003d db_base.NeutronDbPluginV2._generate_mac()"},{"line_number":97,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"},{"line_number":98,"context_line":"                db_base.NeutronDbPluginV2().update_port("},{"line_number":99,"context_line":"                    context._plugin_context, port[\u0027id\u0027],"},{"line_number":100,"context_line":"                    {attributes.PORT: port})"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_cbc36437","line":98,"updated":"2016-11-21 15:44:28.000000000","message":"oh, we don\u0027t want to do this. This builds a new plugin instance every time. You should get a reference to the core plugin and do the proper update through that, or else we risk other mech drivers and systems that depend on notifications getting out of sync.","commit_id":"fc79090610925a8b0a418064e92d7d3435474a66"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"80d041e1315592f9db26dde31680ed0c51c209c1","unresolved":false,"context_lines":[{"line_number":95,"context_line":"            if self._should_reset_mac(port):"},{"line_number":96,"context_line":"                new_mac \u003d db_base.NeutronDbPluginV2._generate_mac()"},{"line_number":97,"context_line":"                port[\u0027mac_address\u0027] \u003d new_mac"},{"line_number":98,"context_line":"                db_base.NeutronDbPluginV2().update_port("},{"line_number":99,"context_line":"                    context._plugin_context, port[\u0027id\u0027],"},{"line_number":100,"context_line":"                    {attributes.PORT: port})"},{"line_number":101,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"7a77a97e_8b487689","line":98,"in_reply_to":"7a77a97e_cbc36437","updated":"2016-11-22 02:55:34.000000000","message":"Done","commit_id":"fc79090610925a8b0a418064e92d7d3435474a66"}],"neutron/tests/unit/common/test_utils.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e75addcecabb61238665dc76477814d803150cd6","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"class TestIsBaseMac(base.BaseTestCase):"},{"line_number":671,"context_line":"    def test_is_base_mac(self):"},{"line_number":672,"context_line":"        test_mac1 \u003d \u0027fa:16:3e:12:34:56\u0027"},{"line_number":673,"context_line":"        test_mac2 \u003d \u002714:ab:cd:ef:gh:12\u0027"},{"line_number":674,"context_line":"        ret_val1 \u003d utils.is_base_mac(test_mac1)"},{"line_number":675,"context_line":"        ret_val2 \u003d utils.is_base_mac(test_mac2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_7ffefcae","line":672,"updated":"2016-11-02 12:36:46.000000000","message":"you may want to generate the prefix from cfg data instead of just assuming that would never change.","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"5479ee16fd44f10a2ecad635f26cf53db153e81b","unresolved":false,"context_lines":[{"line_number":669,"context_line":""},{"line_number":670,"context_line":"class TestIsBaseMac(base.BaseTestCase):"},{"line_number":671,"context_line":"    def test_is_base_mac(self):"},{"line_number":672,"context_line":"        test_mac1 \u003d \u0027fa:16:3e:12:34:56\u0027"},{"line_number":673,"context_line":"        test_mac2 \u003d \u002714:ab:cd:ef:gh:12\u0027"},{"line_number":674,"context_line":"        ret_val1 \u003d utils.is_base_mac(test_mac1)"},{"line_number":675,"context_line":"        ret_val2 \u003d utils.is_base_mac(test_mac2)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_f525440a","line":672,"in_reply_to":"ba5da102_7ffefcae","updated":"2016-11-07 03:17:47.000000000","message":"Done","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e75addcecabb61238665dc76477814d803150cd6","unresolved":false,"context_lines":[{"line_number":673,"context_line":"        test_mac2 \u003d \u002714:ab:cd:ef:gh:12\u0027"},{"line_number":674,"context_line":"        ret_val1 \u003d utils.is_base_mac(test_mac1)"},{"line_number":675,"context_line":"        ret_val2 \u003d utils.is_base_mac(test_mac2)"},{"line_number":676,"context_line":"        self.assertTrue(ret_val1)"},{"line_number":677,"context_line":"        self.assertFalse(ret_val2)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_bf0b34d5","line":676,"updated":"2016-11-02 12:36:46.000000000","message":"nit:\n\nyou can just\nself.assertTrue(utils.is_base_mac(test_mac1))\nself.assertFalse(utils.is_base_mac(test_mac2))","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"5479ee16fd44f10a2ecad635f26cf53db153e81b","unresolved":false,"context_lines":[{"line_number":673,"context_line":"        test_mac2 \u003d \u002714:ab:cd:ef:gh:12\u0027"},{"line_number":674,"context_line":"        ret_val1 \u003d utils.is_base_mac(test_mac1)"},{"line_number":675,"context_line":"        ret_val2 \u003d utils.is_base_mac(test_mac2)"},{"line_number":676,"context_line":"        self.assertTrue(ret_val1)"},{"line_number":677,"context_line":"        self.assertFalse(ret_val2)"},{"line_number":678,"context_line":""},{"line_number":679,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba5da102_15239806","line":676,"in_reply_to":"ba5da102_bf0b34d5","updated":"2016-11-07 03:17:47.000000000","message":"Done","commit_id":"3d646b1a7a141a700fc281f237f864e71e97d116"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/mech_driver/test_mech_sriov_nic_switch.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron import context"},{"line_number":22,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":23,"context_line":"from neutron.extensions import portbindings"},{"line_number":24,"context_line":"from neutron.plugins.common import constants as p_const"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1381b8c3","line":21,"range":{"start_line":21,"start_character":20,"end_line":21,"end_character":27},"updated":"2016-08-10 19:39:07.000000000","message":"Don\u0027t import this as is because now a bunch of existing occurrences of \"context\" will shadow it (e.g. L124). You might import it like this:\n\n  from neutron import context as neutron_context","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":"import testtools"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron import context"},{"line_number":22,"context_line":"from neutron.db import db_base_plugin_v2"},{"line_number":23,"context_line":"from neutron.extensions import portbindings"},{"line_number":24,"context_line":"from neutron.plugins.common import constants as p_const"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ab7943ca","line":21,"range":{"start_line":21,"start_character":20,"end_line":21,"end_character":27},"in_reply_to":"9ad45d7e_1381b8c3","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    portbindings.VIF_TYPE: self._bound_vif_type,"},{"line_number":57,"context_line":"                    \u0027mac_address\u0027: self.mac_address}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        def set_binding(self, segment_id, vif_type,"},{"line_number":60,"context_line":"                        vif_details, state):"},{"line_number":61,"context_line":"            self._bound_segment_id \u003d segment_id"},{"line_number":62,"context_line":"            self._bound_vif_type \u003d vif_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_93f00893","line":59,"updated":"2016-08-10 19:39:07.000000000","message":"Don\u0027t change whitespace gratuitously.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":56,"context_line":"                    portbindings.VIF_TYPE: self._bound_vif_type,"},{"line_number":57,"context_line":"                    \u0027mac_address\u0027: self.mac_address}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"        def set_binding(self, segment_id, vif_type,"},{"line_number":60,"context_line":"                        vif_details, state):"},{"line_number":61,"context_line":"            self._bound_segment_id \u003d segment_id"},{"line_number":62,"context_line":"            self._bound_vif_type \u003d vif_type"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_eb7fbba8","line":59,"in_reply_to":"9ad45d7e_93f00893","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                      api.SEGMENTATION_ID: 1234}]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_type_vlan(self):"},{"line_number":124,"context_line":"        context \u003d TestFakePortContext(self.AGENT_TYPE,"},{"line_number":125,"context_line":"                                  self.AGENTS,"},{"line_number":126,"context_line":"                                  self.VLAN_SEGMENTS,"},{"line_number":127,"context_line":"                                  portbindings.VNIC_DIRECT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_931e48b9","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":15},"updated":"2016-08-10 19:39:07.000000000","message":"This now shadows your new import","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":121,"context_line":"                      api.SEGMENTATION_ID: 1234}]"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_type_vlan(self):"},{"line_number":124,"context_line":"        context \u003d TestFakePortContext(self.AGENT_TYPE,"},{"line_number":125,"context_line":"                                  self.AGENTS,"},{"line_number":126,"context_line":"                                  self.VLAN_SEGMENTS,"},{"line_number":127,"context_line":"                                  portbindings.VNIC_DIRECT)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_cb7c77b7","line":124,"range":{"start_line":124,"start_character":8,"end_line":124,"end_character":15},"in_reply_to":"9ad45d7e_931e48b9","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                                      vnic_type,"},{"line_number":309,"context_line":"                                      profile,"},{"line_number":310,"context_line":"                                      mac_address)"},{"line_number":311,"context_line":"        context.set_binding(1234, vif_type, None, None)"},{"line_number":312,"context_line":"        self.driver.update_port_postcommit(context)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_33015c39","line":311,"range":{"start_line":311,"start_character":44,"end_line":311,"end_character":54},"updated":"2016-08-10 19:39:07.000000000","message":"To help readers, pass these as kwargs:\n\n  context.set_binding(1234, vif_type, vif_details\u003dNone, state\u003dNone)\n\nOtherwise, code reviewers are forced to go up to the definition to know why you\u0027re passing None twice.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":308,"context_line":"                                      vnic_type,"},{"line_number":309,"context_line":"                                      profile,"},{"line_number":310,"context_line":"                                      mac_address)"},{"line_number":311,"context_line":"        context.set_binding(1234, vif_type, None, None)"},{"line_number":312,"context_line":"        self.driver.update_port_postcommit(context)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_2b4c339d","line":311,"range":{"start_line":311,"start_character":44,"end_line":311,"end_character":54},"in_reply_to":"9ad45d7e_33015c39","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        self.driver.update_port_postcommit(context)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"},{"line_number":315,"context_line":"        with mock.patch.object(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":316,"context_line":"                        \u0027update_port\u0027) as update_port:"},{"line_number":317,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":318,"context_line":"                portbindings.VNIC_DIRECT_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d319e089","line":315,"updated":"2016-08-10 19:39:07.000000000","message":"nit: Consider patching using a decorator instead of a context manager here. You might also consider import db_base_plugin_v2 using a shorter name like \"db_base\" or something to help avoid unnatural line wrapping.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        self.driver.update_port_postcommit(context)"},{"line_number":313,"context_line":""},{"line_number":314,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"},{"line_number":315,"context_line":"        with mock.patch.object(db_base_plugin_v2.NeutronDbPluginV2,"},{"line_number":316,"context_line":"                        \u0027update_port\u0027) as update_port:"},{"line_number":317,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":318,"context_line":"                portbindings.VNIC_DIRECT_PHYSICAL,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_4b47e776","line":315,"in_reply_to":"9ad45d7e_d319e089","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"dfb47bec0a50897c0899135461733fcd6ce2b759","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                        \u0027update_port\u0027) as update_port:"},{"line_number":327,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":328,"context_line":"                portbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":329,"context_line":"                {},"},{"line_number":330,"context_line":"                \u002714:ab:bc12:34:56\u0027,"},{"line_number":331,"context_line":"                portbindings.VIF_TYPE_UNBOUND)"},{"line_number":332,"context_line":"            self.assertTrue(update_port.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_762f4288","line":329,"updated":"2016-08-10 19:39:07.000000000","message":"nit: consider passing these with kwargs for readability.","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"d3b3953f7f75b59f1876dcd0014145441aa9768f","unresolved":false,"context_lines":[{"line_number":326,"context_line":"                        \u0027update_port\u0027) as update_port:"},{"line_number":327,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":328,"context_line":"                portbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":329,"context_line":"                {},"},{"line_number":330,"context_line":"                \u002714:ab:bc12:34:56\u0027,"},{"line_number":331,"context_line":"                portbindings.VIF_TYPE_UNBOUND)"},{"line_number":332,"context_line":"            self.assertTrue(update_port.called)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_ab602302","line":329,"in_reply_to":"9ad45d7e_762f4288","updated":"2016-08-11 04:42:28.000000000","message":"Done","commit_id":"34f482b07a902bda4f4c2ea851ecc61d324e6ebe"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"c7c6001ba1098d3cc75f77febe2479eb3ee1eeab","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"},{"line_number":314,"context_line":"        with mock.patch.object(db_base.NeutronDbPluginV2,"},{"line_number":315,"context_line":"                               \u0027update_port\u0027) as update_port:"},{"line_number":316,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":317,"context_line":"                vnic_type\u003dportbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":318,"context_line":"                profile\u003d{\u0027pci_vendor_info\u0027: MELLANOX_CONNECTX3_PCI_INFO},"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_4d579602","line":315,"updated":"2016-08-19 16:51:18.000000000","message":"you do this everywhere might as well move it into setUp()","commit_id":"5e0abcb39fdc1ab0b7727cd5a686bba753ea8e2f"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7cf5481abeefa30b3a29fe03e87d099548562d0e","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"},{"line_number":314,"context_line":"        with mock.patch.object(db_base.NeutronDbPluginV2,"},{"line_number":315,"context_line":"                               \u0027update_port\u0027) as update_port:"},{"line_number":316,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":317,"context_line":"                vnic_type\u003dportbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":318,"context_line":"                profile\u003d{\u0027pci_vendor_info\u0027: MELLANOX_CONNECTX3_PCI_INFO},"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_b274a7fd","line":315,"updated":"2016-08-19 16:51:08.000000000","message":"you do this everywhere might as well move it into setUp()","commit_id":"5e0abcb39fdc1ab0b7727cd5a686bba753ea8e2f"},{"author":{"_account_id":11820,"name":"MANJUNATH PATIL","email":"mpatil@hpe.com","username":"patilmanjunath"},"change_message_id":"992911dbd2435ef3406cfd521e4019fd3f751e99","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"    def test_update_port_postcommit_during_pcipt_instance_creation(self):"},{"line_number":314,"context_line":"        with mock.patch.object(db_base.NeutronDbPluginV2,"},{"line_number":315,"context_line":"                               \u0027update_port\u0027) as update_port:"},{"line_number":316,"context_line":"            self._check_for_update_port_postcommit("},{"line_number":317,"context_line":"                vnic_type\u003dportbindings.VNIC_DIRECT_PHYSICAL,"},{"line_number":318,"context_line":"                profile\u003d{\u0027pci_vendor_info\u0027: MELLANOX_CONNECTX3_PCI_INFO},"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa7ab95a_c48d1c7d","line":315,"in_reply_to":"1ac06dbe_4d579602","updated":"2016-08-26 06:05:36.000000000","message":"Done","commit_id":"5e0abcb39fdc1ab0b7727cd5a686bba753ea8e2f"}]}
