)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d737292126b87d0ea47077a1679fa30ac6042301","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new configuration option in sanity check: vf_extended_management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This configuration parameter should be set to \u0027True\u0027 in case \u0027ip-link\u0027"},{"line_number":10,"context_line":"version installed in this server supports extended VF management parameters"},{"line_number":11,"context_line":"\u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. Both parameters set the minimum and"},{"line_number":12,"context_line":"the maximum egress rate for an interface."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_ad04137e","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":31},"updated":"2016-08-16 09:35:46.000000000","message":"This does not make much sense to me. The way sanity check tool is used, is you execute it against configuration files on the disk, and it reports any issues in runtime deps based on which features are enabled in those configs. So e.g. for sr-iov ip-link dependency, it would check whether qos service plugin is enabled, if ml2 is on, and also if sr-iov driver is enabled; if all is true, then it will check ip link support; otherwise, why would the tool fail for someone that does not need the feature of the tool because they don\u0027t use qos, or ml2, or sriov?","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"858cccc64965967415d942b0fb4d6e14673bc7e3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new configuration option in sanity check: vf_extended_management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This configuration parameter should be set to \u0027True\u0027 in case \u0027ip-link\u0027"},{"line_number":10,"context_line":"version installed in this server supports extended VF management parameters"},{"line_number":11,"context_line":"\u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. Both parameters set the minimum and"},{"line_number":12,"context_line":"the maximum egress rate for an interface."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_fbd1e530","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":31},"in_reply_to":"1ac06dbe_7a7b4abe","updated":"2016-08-24 15:50:39.000000000","message":"Ok, now I understand. There is no need for a new config parameter.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"c00d96a2322593df9ac6526facb62f9d702155d5","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new configuration option in sanity check: vf_extended_management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This configuration parameter should be set to \u0027True\u0027 in case \u0027ip-link\u0027"},{"line_number":10,"context_line":"version installed in this server supports extended VF management parameters"},{"line_number":11,"context_line":"\u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. Both parameters set the minimum and"},{"line_number":12,"context_line":"the maximum egress rate for an interface."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"1ac06dbe_7a7b4abe","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":31},"in_reply_to":"3ac371cc_65005602","updated":"2016-08-24 09:50:18.000000000","message":"You don\u0027t need to check if user is actually using min bw rules. As long as they CAN, you should warn it\u0027s not going to work. So just a check on ml2 + sriov + qos will do.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new configuration option in sanity check: vf_extended_management"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This configuration parameter should be set to \u0027True\u0027 in case \u0027ip-link\u0027"},{"line_number":10,"context_line":"version installed in this server supports extended VF management parameters"},{"line_number":11,"context_line":"\u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. Both parameters set the minimum and"},{"line_number":12,"context_line":"the maximum egress rate for an interface."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_65005602","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":31},"in_reply_to":"3ac371cc_ad04137e","updated":"2016-08-16 17:01:12.000000000","message":"I perfectly understand your point. But in this case I can look up in the configuration if SR-IOV is being used, but I can\u0027t check if the user is going to use SR-IOV with Min-bw rule.\n\nAlso I was told not to do this check during runtime (https://review.openstack.org/#/c/347302/1/neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py@234) because it was determined in this way.\n\nI\u0027m open to any solution involving:\n- A check made in sanity_check (this is the only way to do this)\n- Read from any config parameter when SR-IOV + BW-MIN rule is going to be used.\n\nPlease, help me with this problem!!","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a6a881099f0a53f28a287822bf2edbf281850c29","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This test will check if \u0027ip link\u0027 version installed in this server"},{"line_number":10,"context_line":"supports extended VF management parameter \u0027min_tx_rate\u0027. This"},{"line_number":11,"context_line":"parameter set the minimum egress rate for an interface."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This test is executed when SR-IOV back-end and QoS extension"},{"line_number":14,"context_line":"are enabled."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"fa7ab95a_c5f6e5d6","line":11,"range":{"start_line":11,"start_character":10,"end_line":11,"end_character":13},"updated":"2016-08-26 11:52:26.000000000","message":"sets","commit_id":"6a9c13a24fd2f5ed48df301f2d4f4522fac34f0a"}],"neutron/agent/linux/ip_link_support.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7773e24e43deb117e840d9416af2a302429a52a9","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    IP_LINK_CAPABILITY_STATE \u003d \"state\""},{"line_number":42,"context_line":"    IP_LINK_CAPABILITY_VLAN \u003d \"vlan\""},{"line_number":43,"context_line":"    IP_LINK_CAPABILITY_RATE \u003d \"rate\""},{"line_number":44,"context_line":"    IP_LINK_CAPABILITY_MAX_TX_RATE \u003d \"max_tx_rate\""},{"line_number":45,"context_line":"    IP_LINK_CAPABILITY_MIN_TX_RATE \u003d \"min_tx_rate\""},{"line_number":46,"context_line":"    IP_LINK_CAPABILITY_SPOOFCHK \u003d \"spoofchk\""},{"line_number":47,"context_line":"    IP_LINK_SUB_CAPABILITY_QOS \u003d \"qos\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_4d02bf0c","line":44,"updated":"2016-08-16 09:38:53.000000000","message":"btw in the patch for sriov driver, I see you still stick to \u0027rate\u0027, so why would the sanity check tool validate that other command?","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    IP_LINK_CAPABILITY_STATE \u003d \"state\""},{"line_number":42,"context_line":"    IP_LINK_CAPABILITY_VLAN \u003d \"vlan\""},{"line_number":43,"context_line":"    IP_LINK_CAPABILITY_RATE \u003d \"rate\""},{"line_number":44,"context_line":"    IP_LINK_CAPABILITY_MAX_TX_RATE \u003d \"max_tx_rate\""},{"line_number":45,"context_line":"    IP_LINK_CAPABILITY_MIN_TX_RATE \u003d \"min_tx_rate\""},{"line_number":46,"context_line":"    IP_LINK_CAPABILITY_SPOOFCHK \u003d \"spoofchk\""},{"line_number":47,"context_line":"    IP_LINK_SUB_CAPABILITY_QOS \u003d \"qos\""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_a2ffe465","line":44,"in_reply_to":"3ac371cc_4d02bf0c","updated":"2016-08-16 17:01:12.000000000","message":"Both min_tx_rate and max_tx_rate were implemented in the same patch. Because it\u0027s recommend to use \u0027max_tx_rate\u0027 instead of \u0027rate\u0027, this check can be usefull in future patches using this new parameter.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"}],"neutron/cmd/sanity/checks.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7773e24e43deb117e840d9416af2a302429a52a9","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_STATE,"},{"line_number":175,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_SPOOFCHK,"},{"line_number":176,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_RATE,"},{"line_number":177,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MAX_TX_RATE,"},{"line_number":178,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MIN_TX_RATE,"},{"line_number":179,"context_line":"    )"},{"line_number":180,"context_line":"    return _vf_management_support(required_caps)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_9850730c","line":177,"updated":"2016-08-16 09:38:53.000000000","message":"as said in previous file, not sure we should validate the new rate name at all if it\u0027s not used anywhere in the tree apart from the sanity check tool itself.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_STATE,"},{"line_number":175,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_SPOOFCHK,"},{"line_number":176,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_RATE,"},{"line_number":177,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MAX_TX_RATE,"},{"line_number":178,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MIN_TX_RATE,"},{"line_number":179,"context_line":"    )"},{"line_number":180,"context_line":"    return _vf_management_support(required_caps)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_62c84c23","line":177,"in_reply_to":"3ac371cc_9850730c","updated":"2016-08-16 17:01:12.000000000","message":"\u0027rate\u0027 parameter should be replaced in the near future by \u0027max_tx_rate\u0027, because it\u0027s the recommended parameter name. Both parameters, max_tx_rate and min_tx_rate were implemented in the same patch. This second parameter check (max_tx_rate) is for free.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15048c8b75d170cb38f3b4730e3a5b82c85ac781","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_STATE,"},{"line_number":175,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_SPOOFCHK,"},{"line_number":176,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_RATE,"},{"line_number":177,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MAX_TX_RATE,"},{"line_number":178,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MIN_TX_RATE,"},{"line_number":179,"context_line":"    )"},{"line_number":180,"context_line":"    return _vf_management_support(required_caps)"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_91be9262","line":177,"updated":"2016-08-25 12:37:15.000000000","message":"since your sriov patch does not use this new command, you should not check for it as part of the check enabled for sriov + qos setups.","commit_id":"73e91abf9fa29c930315620e4719a773d9f7451f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d80f135ac9d969bc75b8365657e97e06225b2803","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_STATE,"},{"line_number":175,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_SPOOFCHK,"},{"line_number":176,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_RATE,"},{"line_number":177,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MAX_TX_RATE,"},{"line_number":178,"context_line":"        ip_link_support.IpLinkConstants.IP_LINK_CAPABILITY_MIN_TX_RATE,"},{"line_number":179,"context_line":"    )"},{"line_number":180,"context_line":"    return _vf_management_support(required_caps)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_7a7308b2","line":177,"in_reply_to":"1ac06dbe_91be9262","updated":"2016-08-26 08:22:42.000000000","message":"Done","commit_id":"73e91abf9fa29c930315620e4719a773d9f7451f"}],"neutron/cmd/sanity_check.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d737292126b87d0ea47077a1679fa30ac6042301","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def _register_local_opts():"},{"line_number":32,"context_line":"    SANITY_CHECK_OPTS \u003d ["},{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_6d94dbe1","line":32,"updated":"2016-08-16 09:35:46.000000000","message":"I don\u0027t think there should really be such a new option. Instead, you should inspect existing options for qos, and then determine whether the check should be executed, based on what you see in config files, not on what a user passes to the tool. Ideally, users don\u0027t pass anything, they just get results of platform validation.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d737292126b87d0ea47077a1679fa30ac6042301","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":36,"context_line":"                           \"management features. If enable, \u0027ip-link\u0027 command \""},{"line_number":37,"context_line":"                           \"supports \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. \""},{"line_number":38,"context_line":"                           \"\u0027max_tx_rate\u0027 is the same parameter as \u0027rate\u0027, \""},{"line_number":39,"context_line":"                           \"but is recommended to use it instead of \u0027rate\u0027; \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_2d278313","line":36,"range":{"start_line":36,"start_character":61,"end_line":36,"end_character":68},"updated":"2016-08-16 09:35:46.000000000","message":"I think it\u0027s ip link, not ip-link.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d737292126b87d0ea47077a1679fa30ac6042301","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":36,"context_line":"                           \"management features. If enable, \u0027ip-link\u0027 command \""},{"line_number":37,"context_line":"                           \"supports \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. \""},{"line_number":38,"context_line":"                           \"\u0027max_tx_rate\u0027 is the same parameter as \u0027rate\u0027, \""},{"line_number":39,"context_line":"                           \"but is recommended to use it instead of \u0027rate\u0027; \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_4d459fb1","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":59},"updated":"2016-08-16 09:35:46.000000000","message":"enabled","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":36,"context_line":"                           \"management features. If enable, \u0027ip-link\u0027 command \""},{"line_number":37,"context_line":"                           \"supports \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. \""},{"line_number":38,"context_line":"                           \"\u0027max_tx_rate\u0027 is the same parameter as \u0027rate\u0027, \""},{"line_number":39,"context_line":"                           \"but is recommended to use it instead of \u0027rate\u0027; \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_4278b08f","line":36,"range":{"start_line":36,"start_character":61,"end_line":36,"end_character":68},"in_reply_to":"3ac371cc_2d278313","updated":"2016-08-16 17:01:12.000000000","message":"Done","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":36,"context_line":"                           \"management features. If enable, \u0027ip-link\u0027 command \""},{"line_number":37,"context_line":"                           \"supports \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. \""},{"line_number":38,"context_line":"                           \"\u0027max_tx_rate\u0027 is the same parameter as \u0027rate\u0027, \""},{"line_number":39,"context_line":"                           \"but is recommended to use it instead of \u0027rate\u0027; \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_6275ec96","line":36,"range":{"start_line":36,"start_character":52,"end_line":36,"end_character":59},"in_reply_to":"3ac371cc_4d459fb1","updated":"2016-08-16 17:01:12.000000000","message":"Done","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d737292126b87d0ea47077a1679fa30ac6042301","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":36,"context_line":"                           \"management features. If enable, \u0027ip-link\u0027 command \""},{"line_number":37,"context_line":"                           \"supports \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. \""},{"line_number":38,"context_line":"                           \"\u0027max_tx_rate\u0027 is the same parameter as \u0027rate\u0027, \""},{"line_number":39,"context_line":"                           \"but is recommended to use it instead of \u0027rate\u0027; \""},{"line_number":40,"context_line":"                           \"\u0027min_tx_rate\u0027 allows to define a guaranteed \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_ed83abca","line":37,"range":{"start_line":36,"start_character":70,"end_line":37,"end_character":68},"updated":"2016-08-16 09:35:46.000000000","message":"That\u0027s not what option indicates. It indicates that a check for the tool features will be executed, not that it\u0027s necessarily supported.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":34,"context_line":"                    default\u003dFalse,"},{"line_number":35,"context_line":"                    help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":36,"context_line":"                           \"management features. If enable, \u0027ip-link\u0027 command \""},{"line_number":37,"context_line":"                           \"supports \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027. \""},{"line_number":38,"context_line":"                           \"\u0027max_tx_rate\u0027 is the same parameter as \u0027rate\u0027, \""},{"line_number":39,"context_line":"                           \"but is recommended to use it instead of \u0027rate\u0027; \""},{"line_number":40,"context_line":"                           \"\u0027min_tx_rate\u0027 allows to define a guaranteed \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_62ea0c11","line":37,"range":{"start_line":36,"start_character":70,"end_line":37,"end_character":68},"in_reply_to":"3ac371cc_ed83abca","updated":"2016-08-16 17:01:12.000000000","message":"Done","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"}],"neutron/plugins/ml2/drivers/mech_sriov/agent/common/config.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"42dd852985f53070fd14c759548c15a1ef787918","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_743716ff","line":85,"updated":"2016-08-11 12:24:01.000000000","message":"Can you show me how/when this option is used? I couldn\u0027t find it in this patch, neither in other patches.","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"1b60137a8391087a76f7bfa1ccf2fc570b79cadc","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_e6706e42","line":85,"in_reply_to":"9ad45d7e_05765c3d","updated":"2016-08-11 16:08:01.000000000","message":"Done. I\u0027ll move to sanity_check. Thanks!","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"f3a49bde2bf4bb1f89c7b34ebf556d64b3458849","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_0de68814","line":85,"in_reply_to":"9ad45d7e_0d404833","updated":"2016-08-11 14:09:35.000000000","message":"The dict where you register the option belongs to the agent. I think you wanted to register the option for sanity check tool only: neutron/cmd/sanity_check.py:OPTS.","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2e6acbb03311ff149cbb154d089f47a7ebf8ebbe","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_c5c72494","line":85,"in_reply_to":"9ad45d7e_0de68814","updated":"2016-08-11 15:19:04.000000000","message":"Ahhh, now I undestand you!\n\nWell, actually I\u0027m storing this option in SRIOV_NIC. sanity_check doesn\u0027t have any config option; it imports all CONF groups needed for the sanity checks: https://github.com/openstack/neutron/blob/master/neutron/cmd/sanity_check.py#L31-L44\n\nThat\u0027s why I put this option in SR-IOV section.\n\nBut, of course, is very easy to move to other section if needed.","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"5c3c9598aa602edf64df6249d10a0b783ae30e7b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_0d404833","line":85,"in_reply_to":"9ad45d7e_37e11b2e","updated":"2016-08-11 14:06:04.000000000","message":"@Ihar maybe I\u0027m not undestanding your question. I\u0027m creating this new registered variable to set if the host ip-link supports min_tx_rate (and max_tx_rate). If not, QoS minimum bandwidth (egress) is not supported.\n\nI was requested to make this check during sanity checks (https://review.openstack.org/#/c/347302/1/neutron/plugins/ml2/drivers/mech_sriov/agent/pci_lib.py@234): \"We agreed not to do this kind of runtime checks in neutron, in the sanity checks\"\n\nIs there any other way to do this?\n\nThanks for your quick reviews!","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"739a2ee3295bc9c31e932dd528598ec7695c5899","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_37e11b2e","line":85,"in_reply_to":"9ad45d7e_3c6c60cd","updated":"2016-08-11 13:37:17.000000000","message":"Right. Why would we want to register it for the agent?","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7f0a7c61c89f408265ffc387b97e268d6b19d83d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_a17cadec","line":85,"in_reply_to":"9ad45d7e_6b58d456","updated":"2016-08-11 13:15:13.000000000","message":"Right. But where specifically is it used in that other patch? It\u0027s either me blind, or it\u0027s not used there?","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"e8f1278057bc02b4d4209b17aa22911eeca4e9e3","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6b58d456","line":85,"in_reply_to":"9ad45d7e_743716ff","updated":"2016-08-11 12:50:31.000000000","message":"@Ihar: this was a good suggestion made by Moshe Levi, to split QoS minimum bandwidth egress rule, SR-IOV implementation in two parts:\n- This patch, with this new option.\n- The SR-IOV implementation: https://review.openstack.org/#/c/347302/","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"bf66e710a9d63d6c5e07b8c439caae123f78fdf5","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_3c6c60cd","line":85,"in_reply_to":"9ad45d7e_a17cadec","updated":"2016-08-11 13:19:28.000000000","message":"hmm, \nI think is should be in https://github.com/openstack/neutron/blob/master/neutron/cmd/sanity/checks.py#L147-L165\nas this is just checking that you have the iproute that support min_tx_rate","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b6279877dc6f5fc0add3c96364c7f5c579fed6f0","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_05765c3d","line":85,"in_reply_to":"9ad45d7e_c5c72494","updated":"2016-08-11 15:23:32.000000000","message":"Well, this option should be a CLI option for sanity check tool, not the agent. Because there will be no mode of operation for the agent that would work without the support in ip-link.\n\nThat\u0027s why you should move it out of here.","commit_id":"5a8698795cafb9663ca107957b3a14fcd57defe6"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"d737292126b87d0ea47077a1679fa30ac6042301","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_edb60b89","line":85,"updated":"2016-08-16 09:35:46.000000000","message":"I still don\u0027t get why you need this option in the agent code, and when someone would change the default value here.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"49e96333a7d5af8c3db86bed9191255958476957","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                       \"network_device. The network_device in the mapping \""},{"line_number":83,"context_line":"                       \"should appear in the physical_device_mappings \""},{"line_number":84,"context_line":"                       \"list.\")),"},{"line_number":85,"context_line":"    cfg.BoolOpt(\u0027vf_extended_management\u0027,"},{"line_number":86,"context_line":"                default\u003dFalse,"},{"line_number":87,"context_line":"                help\u003d_(\"Check this option to enable \u0027ip-link\u0027 extended VF \""},{"line_number":88,"context_line":"                       \"management features. If enable, \u0027ip-link\u0027 command \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_dc2126b6","line":85,"in_reply_to":"3ac371cc_edb60b89","updated":"2016-08-16 17:01:12.000000000","message":"This is a mistake. I should have removed this. My bad.","commit_id":"4a664f8c9917e932f179daf5f790faaefdd5347f"}],"releasenotes/notes/add-vf-extended-management-test-434697dc32d8c4a5.yaml":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"15048c8b75d170cb38f3b4730e3a5b82c85ac781","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Added new configuration test in sanity check: vf_extended_management. This"},{"line_number":4,"context_line":"  test will check if \u0027ip link\u0027 version installed in this server supports"},{"line_number":5,"context_line":"  extended VF management parameters \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1ac06dbe_51725a12","line":2,"updated":"2016-08-25 12:37:15.000000000","message":"prelude goes into the header of release notes: http://docs.openstack.org/developer/reno/usage.html#editing-a-release-note\n\nHonestly, I don\u0027t think that such a change deserves a separate note at all.","commit_id":"73e91abf9fa29c930315620e4719a773d9f7451f"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"d80f135ac9d969bc75b8365657e97e06225b2803","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"prelude: \u003e"},{"line_number":3,"context_line":"  Added new configuration test in sanity check: vf_extended_management. This"},{"line_number":4,"context_line":"  test will check if \u0027ip link\u0027 version installed in this server supports"},{"line_number":5,"context_line":"  extended VF management parameters \u0027min_tx_rate\u0027 and \u0027max_tx_rate\u0027."}],"source_content_type":"text/x-yaml","patch_set":7,"id":"fa7ab95a_5af3a40a","line":2,"in_reply_to":"1ac06dbe_51725a12","updated":"2016-08-26 08:22:42.000000000","message":"I keep this release note because I introduced a new config variable. Of course, once this new variable is no more, I\u0027ll remove this note.","commit_id":"73e91abf9fa29c930315620e4719a773d9f7451f"}]}
