)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"b4af8f22e25ba76c04ec061d0ef427a0604842de","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to Neutron developer documentation[1], it\u0027s better to use"},{"line_number":10,"context_line":"assertTrue/False methods instead of generic assertEqual. This unit test"},{"line_number":11,"context_line":"is not checked by check_asserttruefalse"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#mocking-and-testing"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_b439c9f4","line":11,"range":{"start_line":11,"start_character":18,"end_line":11,"end_character":39},"updated":"2016-08-10 13:27:43.000000000","message":"should we improve it then?","commit_id":"df4a8b83a7ff48adf222db109caff9267a650b52"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"caa7afc152b0a7e1be79086ab479e18648deadd0","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to Neutron developer documentation[1], it\u0027s better to use"},{"line_number":10,"context_line":"assertTrue/False methods instead of generic assertEqual. The regex"},{"line_number":11,"context_line":"created for check_asserttruefalse was skipping unit tests located on"},{"line_number":12,"context_line":"test_netns_cleanup.py file.  This change includes those escenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#mocking-and-testing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_b4d6c0ee","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":32},"updated":"2016-08-11 06:52:17.000000000","message":"you can say like this \"check_asserttrue/false\"","commit_id":"c3aa84157805fd1189717934a81787d22ec618fd"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"b259535ababc6996f89d2280f63ca2610c595278","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"According to Neutron developer documentation[1], it\u0027s better to use"},{"line_number":10,"context_line":"assertTrue/False methods instead of generic assertEqual. The regex"},{"line_number":11,"context_line":"created for check_asserttruefalse was skipping unit tests located on"},{"line_number":12,"context_line":"test_netns_cleanup.py file.  This change includes those escenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#mocking-and-testing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_721d6165","line":11,"range":{"start_line":11,"start_character":12,"end_line":11,"end_character":32},"in_reply_to":"9ad45d7e_b4d6c0ee","updated":"2016-08-11 13:49:26.000000000","message":"Actually that is the name of the function[1]\n\n[1] https://review.openstack.org/#/c/351922/3/neutron/hacking/checks.py@196","commit_id":"c3aa84157805fd1189717934a81787d22ec618fd"},{"author":{"_account_id":21407,"name":"Kushal Wathore","email":"kushal.wathore@hpe.com","username":"kwathore"},"change_message_id":"caa7afc152b0a7e1be79086ab479e18648deadd0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"According to Neutron developer documentation[1], it\u0027s better to use"},{"line_number":10,"context_line":"assertTrue/False methods instead of generic assertEqual. The regex"},{"line_number":11,"context_line":"created for check_asserttruefalse was skipping unit tests located on"},{"line_number":12,"context_line":"test_netns_cleanup.py file.  This change includes those escenarios."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#mocking-and-testing"},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_b4ed20b9","line":12,"range":{"start_line":12,"start_character":56,"end_line":12,"end_character":66},"updated":"2016-08-11 06:52:17.000000000","message":"spelling mistake","commit_id":"c3aa84157805fd1189717934a81787d22ec618fd"}],"neutron/tests/unit/cmd/test_netns_cleanup.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"54278309ecbb222d48f746d1a61534d8f072785d","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        with mock.patch(\u0027neutron.agent.linux.ip_lib.IPWrapper\u0027) as ip_wrap:"},{"line_number":69,"context_line":"            ip_wrap.return_value.namespace_is_empty.return_value \u003d is_empty"},{"line_number":70,"context_line":"            self.assertEqual(util.eligible_for_deletion(conf, ns, force),"},{"line_number":71,"context_line":"                             expected)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"            expected_calls \u003d [mock.call(namespace\u003dns)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bacf61ea_37dbb450","line":70,"updated":"2016-08-08 01:28:58.000000000","message":"Please change this to \n\n self.assertEqual( expected, util.eligible.....)\n\nBecause assertEqual should be in the format ( expected_op, actual_op)\n\nThus you can also change the overall bug to handle the various assert conditions in one patch.","commit_id":"32265aa630421767c5898969828bedc3cc472fed"}]}
