)]}'
{"neutron/db/external_net_db.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"546550a0461b1070dd97d7c43b195a4953526d9d","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":280,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":281,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(),"},{"line_number":282,"context_line":"                                                    ext_net_models)"},{"line_number":283,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_d224f0c7","line":281,"updated":"2016-08-31 12:42:09.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"5fc8c5644099ea3d8954ac8df730bbee70b5c1fd"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1ee331ce52dc3ea3c57aef1d92cce12b5fd93e7b","unresolved":false,"context_lines":[{"line_number":278,"context_line":""},{"line_number":279,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":280,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":281,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(),"},{"line_number":282,"context_line":"                                                    ext_net_models)"},{"line_number":283,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_0c5b8655","line":281,"in_reply_to":"fa7ab95a_d224f0c7","updated":"2016-08-31 17:31:08.000000000","message":"Done","commit_id":"5fc8c5644099ea3d8954ac8df730bbee70b5c1fd"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"67ee88b6b92bc994332ba39da2ff8f55c3562ce5","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"_deprecate._moved_global(\u0027ExternalNetwork\u0027, new_module\u003dext_net_models)"},{"line_number":41,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d lib_constants.DEVICE_OWNER_ROUTER_GW"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class External_net_db_mixin(object):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_b4dc8d13","line":41,"updated":"2016-09-29 14:32:38.000000000","message":"Nit: move the deprecation below the constant (and separate with a blank line.","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"669fcae71c27526de8d7f9ebeee02a3274affd10","unresolved":false,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"_deprecate._moved_global(\u0027ExternalNetwork\u0027, new_module\u003dext_net_models)"},{"line_number":41,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d lib_constants.DEVICE_OWNER_ROUTER_GW"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"class External_net_db_mixin(object):"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_35c6b049","line":41,"in_reply_to":"3a98d1f4_b4dc8d13","updated":"2016-09-29 16:35:36.000000000","message":"Done","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"67ee88b6b92bc994332ba39da2ff8f55c3562ce5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            return query"},{"line_number":73,"context_line":"        if vals[0]:"},{"line_number":74,"context_line":"            return query.filter("},{"line_number":75,"context_line":"                (ext_net_models.ExternalNetwork.network_id !\u003d expr.null()))"},{"line_number":76,"context_line":"        return query.filter("},{"line_number":77,"context_line":"            (ext_net_models.ExternalNetwork.network_id \u003d\u003d expr.null()))"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_943b1138","line":75,"updated":"2016-09-29 14:32:38.000000000","message":"Nit: can remove redundant parentheses","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"669fcae71c27526de8d7f9ebeee02a3274affd10","unresolved":false,"context_lines":[{"line_number":72,"context_line":"            return query"},{"line_number":73,"context_line":"        if vals[0]:"},{"line_number":74,"context_line":"            return query.filter("},{"line_number":75,"context_line":"                (ext_net_models.ExternalNetwork.network_id !\u003d expr.null()))"},{"line_number":76,"context_line":"        return query.filter("},{"line_number":77,"context_line":"            (ext_net_models.ExternalNetwork.network_id \u003d\u003d expr.null()))"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_75c0382b","line":75,"in_reply_to":"3a98d1f4_943b1138","updated":"2016-09-29 16:35:36.000000000","message":"Done","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"67ee88b6b92bc994332ba39da2ff8f55c3562ce5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            return query.filter("},{"line_number":75,"context_line":"                (ext_net_models.ExternalNetwork.network_id !\u003d expr.null()))"},{"line_number":76,"context_line":"        return query.filter("},{"line_number":77,"context_line":"            (ext_net_models.ExternalNetwork.network_id \u003d\u003d expr.null()))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(salvatore-orlando): Perform this operation without explicitly"},{"line_number":80,"context_line":"    # referring to db_base_plugin_v2, as plugins that do not extend from it"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_340ddd90","line":77,"updated":"2016-09-29 14:32:38.000000000","message":"Nit: can remove redundant parentheses","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"669fcae71c27526de8d7f9ebeee02a3274affd10","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            return query.filter("},{"line_number":75,"context_line":"                (ext_net_models.ExternalNetwork.network_id !\u003d expr.null()))"},{"line_number":76,"context_line":"        return query.filter("},{"line_number":77,"context_line":"            (ext_net_models.ExternalNetwork.network_id \u003d\u003d expr.null()))"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    # TODO(salvatore-orlando): Perform this operation without explicitly"},{"line_number":80,"context_line":"    # referring to db_base_plugin_v2, as plugins that do not extend from it"}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_95ddc416","line":77,"in_reply_to":"3a98d1f4_340ddd90","updated":"2016-09-29 16:35:36.000000000","message":"Done","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"}],"neutron/db/migration/models/head.py":[{"author":{"_account_id":20246,"name":"Aradhana Singh","email":"aradhanamailbox@gmail.com","username":"asingh"},"change_message_id":"45d9d2d4219619d852090932601d78d546172d7e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from neutron.db import l3_hamode_db  # noqa"},{"line_number":38,"context_line":"from neutron.db.metering import metering_db  # noqa"},{"line_number":39,"context_line":"from neutron.db import model_base"},{"line_number":40,"context_line":"from neutron.db.models import external_net as ext_net_models  # noqa"},{"line_number":41,"context_line":"from neutron.db.models import l3  # noqa"},{"line_number":42,"context_line":"from neutron.db import models_v2  # noqa"},{"line_number":43,"context_line":"from neutron.db.port_security import models  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_58c19753","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":68},"updated":"2016-08-10 15:44:37.000000000","message":"Just curious, why #noqa in this file? is it possible to import in files where they are being used instead","commit_id":"97bf9d5fa3bf357eda55b215e2d146910f784697"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7db70a2065c7c11355c2ada2bdc40584cc20f703","unresolved":false,"context_lines":[{"line_number":37,"context_line":"from neutron.db import l3_hamode_db  # noqa"},{"line_number":38,"context_line":"from neutron.db.metering import metering_db  # noqa"},{"line_number":39,"context_line":"from neutron.db import model_base"},{"line_number":40,"context_line":"from neutron.db.models import external_net as ext_net_models  # noqa"},{"line_number":41,"context_line":"from neutron.db.models import l3  # noqa"},{"line_number":42,"context_line":"from neutron.db import models_v2  # noqa"},{"line_number":43,"context_line":"from neutron.db.port_security import models  # noqa"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_32d4bfea","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":68},"in_reply_to":"9ad45d7e_58c19753","updated":"2016-08-10 16:18:53.000000000","message":"It needs to be imported here and noqa will let the pep8 check ignore this not being used here.","commit_id":"97bf9d5fa3bf357eda55b215e2d146910f784697"}],"neutron/db/models/external_net.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2df5003ab9dc953c4ee1f38d0f8a066ab9502ddb","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d l3_constants.DEVICE_OWNER_ROUTER_GW"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ExternalNetwork(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_4953186d","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":60},"updated":"2016-08-12 11:51:44.000000000","message":"Unnecessary.","commit_id":"46093d6e33b3065263b47201697ca33ccc794eff"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2e26aaf628f2e6fd709579ecfe9a108efa007048","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.db import models_v2"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"DEVICE_OWNER_ROUTER_GW \u003d l3_constants.DEVICE_OWNER_ROUTER_GW"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"class ExternalNetwork(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_c7807f8e","line":25,"range":{"start_line":25,"start_character":0,"end_line":25,"end_character":60},"in_reply_to":"9ad45d7e_4953186d","updated":"2016-08-12 16:53:42.000000000","message":"removed","commit_id":"46093d6e33b3065263b47201697ca33ccc794eff"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"df20abdb128326c8c8648b61b8c3fd63b745f6c7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_470d7e3d","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"updated":"2016-08-16 09:13:35.000000000","message":"Please remove useless lines.","commit_id":"10571407ad3e7924d1018ec1482b2cb003d0bc9e"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"824276093906ed1822848fcc05a48659be64f1bb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_5c7d36e6","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"3ac371cc_470d7e3d","updated":"2016-08-16 21:27:13.000000000","message":"I know they are useless, but no harm in keeping them, sometime people -1 for not having copyrights. I would keep it unless other reviewers have issues with it.","commit_id":"10571407ad3e7924d1018ec1482b2cb003d0bc9e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"2a4fa6b98a46135cd1b6b71f4b567ec48404ce09","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_6a074518","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"3ac371cc_5c7d36e6","updated":"2016-08-17 16:21:21.000000000","message":"I am okay with this. Generally copyright holder should match the author organization. In this case, the code is copied from the other place, so it sounds reasonable to keep the original copyright. 2013 may be better from this point of view.","commit_id":"10571407ad3e7924d1018ec1482b2cb003d0bc9e"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"e72e5747d3dfd86e04cebb37cfd9ee4a51f37e94","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 OpenStack Foundation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":5,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":6,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":7,"id":"3ac371cc_bf717546","line":3,"range":{"start_line":1,"start_character":0,"end_line":3,"end_character":1},"in_reply_to":"3ac371cc_6a074518","updated":"2016-08-17 18:28:24.000000000","message":"done I replaced it with 2013","commit_id":"10571407ad3e7924d1018ec1482b2cb003d0bc9e"},{"author":{"_account_id":7249,"name":"Ann Taraday","email":"akamyshnikova@mirantis.com","username":"AKamyshnikova"},"change_message_id":"0ef72b0595b56d249ad252a7464287d6873ba75d","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from sqlalchemy import orm"},{"line_number":19,"context_line":"from sqlalchemy import sql"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib.db import model_base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.db import models_v2"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_fbd0c855","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":34},"updated":"2016-09-29 13:44:03.000000000","message":"should go to upper section.","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"669fcae71c27526de8d7f9ebeee02a3274affd10","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from sqlalchemy import orm"},{"line_number":19,"context_line":"from sqlalchemy import sql"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib.db import model_base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.db import models_v2"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_b5b9e0cd","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":34},"in_reply_to":"3a98d1f4_947311e7","updated":"2016-09-29 16:35:36.000000000","message":"Done","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"67ee88b6b92bc994332ba39da2ff8f55c3562ce5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from sqlalchemy import orm"},{"line_number":19,"context_line":"from sqlalchemy import sql"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from neutron_lib.db import model_base"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"from neutron.db import models_v2"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3a98d1f4_947311e7","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":34},"in_reply_to":"3a98d1f4_fbd0c855","updated":"2016-09-29 14:32:38.000000000","message":"+1","commit_id":"a5e31912e4692391c899aa84b32c30012a7f79ce"}]}