)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"b5089d566b6991f75a50713dde9f38fa15e2595a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If a router\u0027s admin_state_up is False, the status of the router is still"},{"line_number":10,"context_line":"set to ACTIVE. This doesn\u0027t make much sense and is not user friendly."},{"line_number":11,"context_line":"This patch proposes an additional status, DOWN, for routers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Related-Bug: #1609738"},{"line_number":14,"context_line":"Change-Id: I8784b6a499d7828d1cbcd701d91fa87477a764d8"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bacf61ea_7497ea47","line":11,"updated":"2016-08-07 23:52:43.000000000","message":"why do you say so? What is your understanding of (operational) status vs admin status?","commit_id":"c8ce39cfe80eeb2fd35c1c15eca9dac380c72faa"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"01158645770f86bdc2d5001c1265a8ed6ee72d19","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     John Schwarz \u003cjschwarz@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-08 11:11:51 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add new status DOWN for routers"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"A router may be stuck in the ALLOCATING state in some scenarios (as"},{"line_number":10,"context_line":"described in the bug report, most obvious one is \"handling"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_62f3890b","line":7,"updated":"2016-08-08 15:42:43.000000000","message":"I am concerned that more than one patch handling router status went in without proper oversight. State resources affect the API and we should not make these changes this lightly.\n\nAdmin status and status have different meanings and objectives and one should not affect the other.","commit_id":"73a42b232e41ee4df9b7a140675aed11ad272aaf"}],"neutron/db/l3_db.py":[{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"7f668cd5bd97625fc1d449f1ce6c645d2f70d7ed","unresolved":false,"context_lines":[{"line_number":280,"context_line":"            # is made"},{"line_number":281,"context_line":"            if data[\u0027admin_state_up\u0027] !\u003d router_db.admin_state_up:"},{"line_number":282,"context_line":"                return (n_const.ROUTER_STATUS_ACTIVE if data[\u0027admin_state_up\u0027]"},{"line_number":283,"context_line":"                        else n_const.ROUTER_STATUS_DOWN)"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        return router_db[\u0027status\u0027]"},{"line_number":286,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6220a99c","line":283,"updated":"2016-08-08 15:39:57.000000000","message":"This is wrong. The operational status of a router has nothing to do with the admin status. If you are required to do this to fix your bug I can argue you\u0027re doing wrong in the first place.","commit_id":"73a42b232e41ee4df9b7a140675aed11ad272aaf"}]}
