)]}'
{"neutron/plugins/ml2/drivers/openvswitch/agent/ovs_neutron_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"86f733ed71e02589c9cc64c05a3cc8e7ff7a7bf8","unresolved":false,"context_lines":[{"line_number":1645,"context_line":""},{"line_number":1646,"context_line":"        # TODO(salv-orlando): Optimize avoiding applying filters"},{"line_number":1647,"context_line":"        # unnecessarily, (eg: when there are no IP address changes)"},{"line_number":1648,"context_line":"        added_ports \u003d port_info.get(\u0027added\u0027, set())"},{"line_number":1649,"context_line":"        self._add_port_tag_info(need_binding_devices)"},{"line_number":1650,"context_line":"        if security_disabled_ports:"},{"line_number":1651,"context_line":"            added_ports -\u003d set(security_disabled_ports)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_afaef6e4","line":1648,"updated":"2016-08-19 09:29:15.000000000","message":"Can we just subtract the skipped_devices set here instead of L1643?","commit_id":"1f3b7564f0b2ae0216ff4f9b2e5e186a3cf8410d"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"04ebf38f94338e39bbb3f07483b4b92c8d539e86","unresolved":false,"context_lines":[{"line_number":1645,"context_line":""},{"line_number":1646,"context_line":"        # TODO(salv-orlando): Optimize avoiding applying filters"},{"line_number":1647,"context_line":"        # unnecessarily, (eg: when there are no IP address changes)"},{"line_number":1648,"context_line":"        added_ports \u003d port_info.get(\u0027added\u0027, set())"},{"line_number":1649,"context_line":"        self._add_port_tag_info(need_binding_devices)"},{"line_number":1650,"context_line":"        if security_disabled_ports:"},{"line_number":1651,"context_line":"            added_ports -\u003d set(security_disabled_ports)"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_7908222e","line":1648,"in_reply_to":"3ac371cc_afaef6e4","updated":"2016-08-22 02:38:56.000000000","message":"Done","commit_id":"1f3b7564f0b2ae0216ff4f9b2e5e186a3cf8410d"},{"author":{"_account_id":20378,"name":"Trevor McCasland","email":"TM2086@att.com","username":"twm2016"},"change_message_id":"ba329fd657fe1da3066dbcb7f073b67d0f061912","unresolved":false,"context_lines":[{"line_number":1504,"context_line":"            LOG.debug(\"Processing port: %s\", device)"},{"line_number":1505,"context_line":"            port \u003d vif_by_id.get(device)"},{"line_number":1506,"context_line":"            if not port:"},{"line_number":1507,"context_line":"                # The port disappeared and cannot be processed"},{"line_number":1508,"context_line":"                LOG.info(_LI(\"Port %s was not found on the integration bridge \""},{"line_number":1509,"context_line":"                             \"and will therefore not be processed\"), device)"},{"line_number":1510,"context_line":"                skipped_devices.append(device)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa7ab95a_b2f9c582","line":1507,"updated":"2016-09-01 19:58:55.000000000","message":"It\u0027s good to not setup port filters on ports that have disappeared.","commit_id":"0f983856136c3ed92f904d21cb8480f8dd668a0b"}],"neutron/tests/unit/plugins/ml2/drivers/openvswitch/agent/test_ovs_neutron_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"86f733ed71e02589c9cc64c05a3cc8e7ff7a7bf8","unresolved":false,"context_lines":[{"line_number":949,"context_line":""},{"line_number":950,"context_line":"    def _test_process_network_ports(self, port_info, skipped_devices\u003dNone):"},{"line_number":951,"context_line":"        failed_devices \u003d {\u0027added\u0027: set(), \u0027removed\u0027: set()}"},{"line_number":952,"context_line":"        skipped_devices \u003d [] if skipped_devices is None else skipped_devices"},{"line_number":953,"context_line":"        added_devices \u003d port_info.get(\u0027added\u0027, set())"},{"line_number":954,"context_line":"        with mock.patch.object(self.agent.sg_agent,"},{"line_number":955,"context_line":"                               \"setup_port_filters\") as setup_port_filters,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_cf16d2f0","line":952,"range":{"start_line":952,"start_character":26,"end_line":952,"end_character":76},"updated":"2016-08-19 09:29:15.000000000","message":"skipped_devices \u003d skipped_devices or []","commit_id":"1f3b7564f0b2ae0216ff4f9b2e5e186a3cf8410d"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"04ebf38f94338e39bbb3f07483b4b92c8d539e86","unresolved":false,"context_lines":[{"line_number":949,"context_line":""},{"line_number":950,"context_line":"    def _test_process_network_ports(self, port_info, skipped_devices\u003dNone):"},{"line_number":951,"context_line":"        failed_devices \u003d {\u0027added\u0027: set(), \u0027removed\u0027: set()}"},{"line_number":952,"context_line":"        skipped_devices \u003d [] if skipped_devices is None else skipped_devices"},{"line_number":953,"context_line":"        added_devices \u003d port_info.get(\u0027added\u0027, set())"},{"line_number":954,"context_line":"        with mock.patch.object(self.agent.sg_agent,"},{"line_number":955,"context_line":"                               \"setup_port_filters\") as setup_port_filters,\\"}],"source_content_type":"text/x-python","patch_set":3,"id":"1ac06dbe_1932ce10","line":952,"range":{"start_line":952,"start_character":26,"end_line":952,"end_character":76},"in_reply_to":"3ac371cc_cf16d2f0","updated":"2016-08-22 02:38:56.000000000","message":"Done","commit_id":"1f3b7564f0b2ae0216ff4f9b2e5e186a3cf8410d"},{"author":{"_account_id":12860,"name":"Dongcan Ye","email":"yedongcan@yeah.net","username":"yedongcan"},"change_message_id":"692ef28182f01163cac848eaad013a27af1b9b20","unresolved":false,"context_lines":[{"line_number":969,"context_line":"                failed_devices,"},{"line_number":970,"context_line":"                self.agent.process_network_ports(port_info, False))"},{"line_number":971,"context_line":"            setup_port_filters.assert_called_once_with("},{"line_number":972,"context_line":"                port_info.get(\u0027added\u0027, set()) - set(skipped_devices),"},{"line_number":973,"context_line":"                port_info.get(\u0027updated\u0027, set()))"},{"line_number":974,"context_line":"            devices_added_updated \u003d (added_devices |"},{"line_number":975,"context_line":"                                     port_info.get(\u0027updated\u0027, set()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_ff0460c7","line":972,"range":{"start_line":972,"start_character":16,"end_line":972,"end_character":45},"updated":"2016-09-05 04:31:10.000000000","message":"nit: why not use added_devices here?","commit_id":"f4426bf2aa0eba22b1738901990f7e73cd0b4b13"},{"author":{"_account_id":9200,"name":"IWAMOTO Toshihiro","email":"iwamoto@valinux.co.jp","username":"toshii"},"change_message_id":"ca418e1cae679999af7845576b1c73e191440521","unresolved":false,"context_lines":[{"line_number":969,"context_line":"                failed_devices,"},{"line_number":970,"context_line":"                self.agent.process_network_ports(port_info, False))"},{"line_number":971,"context_line":"            setup_port_filters.assert_called_once_with("},{"line_number":972,"context_line":"                port_info.get(\u0027added\u0027, set()) - set(skipped_devices),"},{"line_number":973,"context_line":"                port_info.get(\u0027updated\u0027, set()))"},{"line_number":974,"context_line":"            devices_added_updated \u003d (added_devices |"},{"line_number":975,"context_line":"                                     port_info.get(\u0027updated\u0027, set()))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9a89bdaa_8ab06fdf","line":972,"range":{"start_line":972,"start_character":16,"end_line":972,"end_character":45},"in_reply_to":"9a89bdaa_ff0460c7","updated":"2016-09-05 08:00:44.000000000","message":"The older version of process_network_ports changed port_info[\u0027added\u0027].\nWill fix.","commit_id":"f4426bf2aa0eba22b1738901990f7e73cd0b4b13"}]}