)]}'
{"neutron/agent/linux/ipset_manager.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"83597baf8821e545d413d01887a47dcae063cc3d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        del_ips \u003d self._get_deleted_set_ips(set_name, member_ips)"},{"line_number":82,"context_line":"        if not add_ips and not del_ips and self.set_name_exists(set_name):"},{"line_number":83,"context_line":"            # nothing to do because no membership changes and the ipset exists"},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":"        self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":86,"context_line":"        return add_ips, del_ips"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_782e1b44","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":18},"updated":"2016-08-10 15:30:47.000000000","message":"You should:\n\n return [], []\n\nhere.\n\nOr beter negate the condition on L82 and call set_members_mutate().","commit_id":"4e5df39bc18b5d5771d0817441af1b1f56fa1d57"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"7e6f32f53b5db2a4ade1f05ab2584c66ab3f55ae","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        del_ips \u003d self._get_deleted_set_ips(set_name, member_ips)"},{"line_number":82,"context_line":"        if not add_ips and not del_ips and self.set_name_exists(set_name):"},{"line_number":83,"context_line":"            # nothing to do because no membership changes and the ipset exists"},{"line_number":84,"context_line":"            return"},{"line_number":85,"context_line":"        self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":86,"context_line":"        return add_ips, del_ips"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_3e548bc8","line":84,"range":{"start_line":84,"start_character":12,"end_line":84,"end_character":18},"in_reply_to":"9ad45d7e_782e1b44","updated":"2016-08-10 15:57:11.000000000","message":"sure, thanks","commit_id":"4e5df39bc18b5d5771d0817441af1b1f56fa1d57"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"368e1655ae904847c1250d4b795b54ce54945213","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        set_name \u003d self.get_name(id, ethertype)"},{"line_number":80,"context_line":"        add_ips \u003d self._get_new_set_ips(set_name, member_ips)"},{"line_number":81,"context_line":"        del_ips \u003d self._get_deleted_set_ips(set_name, member_ips)"},{"line_number":82,"context_line":"        if add_ips or del_ips:"},{"line_number":83,"context_line":"            self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":84,"context_line":"        return add_ips, del_ips"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_78439242","line":82,"updated":"2016-08-11 09:35:20.000000000","message":"What about the set_name_exists?","commit_id":"4f29b0d37710224bece3c06f491be14242a4d630"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"c72d9053f4b1ccfa5c987954a62ab3ea874ea9be","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        set_name \u003d self.get_name(id, ethertype)"},{"line_number":80,"context_line":"        add_ips \u003d self._get_new_set_ips(set_name, member_ips)"},{"line_number":81,"context_line":"        del_ips \u003d self._get_deleted_set_ips(set_name, member_ips)"},{"line_number":82,"context_line":"        if add_ips or del_ips:"},{"line_number":83,"context_line":"            self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":84,"context_line":"        return add_ips, del_ips"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_df94238c","line":82,"in_reply_to":"9ad45d7e_78439242","updated":"2016-08-11 10:09:32.000000000","message":"need to further work on set_members and set_members_mutate functions. Cleanup is needed here. \n\nNeed to check why utils.synchronized is added for set_members_mutate and  destroy methods i.e I feel these functions are not called simultaneously and is called only from rpc_loop of ovs_neutron_agent.py, so no locks are needed.\n\n@shiahanzhang, any reason why utils.synchronized added?","commit_id":"4f29b0d37710224bece3c06f491be14242a4d630"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e121c9b3a0c4298ee573f3277fa3ff8bbb6741d6","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            # nothing to do because no membership changes and the ipset exists"},{"line_number":84,"context_line":"            return [], []"},{"line_number":85,"context_line":"        self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":86,"context_line":"        return add_ips, del_ips"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @utils.synchronized(\u0027ipset\u0027, external\u003dTrue)"},{"line_number":89,"context_line":"    def set_members_mutate(self, set_name, ethertype, member_ips):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_dd69e3fa","line":86,"updated":"2016-08-29 19:01:58.000000000","message":"I think you can change the code on L82 to just have a single return here:\n\nif add_ips and del_ips and not self.set_name_exists(set_name):\n    self.set_members_mutate(...)\nreturn add_ips, del_ips","commit_id":"1d4e8b9fd756a5949e3dbf4929e3a84549283a8b"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"e6ce37f1cacad0ff588dfcc7b338d7528ac521d2","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            # nothing to do because no membership changes and the ipset exists"},{"line_number":84,"context_line":"            return [], []"},{"line_number":85,"context_line":"        self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":86,"context_line":"        return add_ips, del_ips"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @utils.synchronized(\u0027ipset\u0027, external\u003dTrue)"},{"line_number":89,"context_line":"    def set_members_mutate(self, set_name, ethertype, member_ips):"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_e3536415","line":86,"in_reply_to":"fa7ab95a_dd69e3fa","updated":"2016-08-29 19:21:24.000000000","message":"Ok. I have changed it as\n\nif add_ips and del_ips or not self.set_name_exists(set_name):","commit_id":"1d4e8b9fd756a5949e3dbf4929e3a84549283a8b"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2f8ec23f439896d2bf2d22c03ea626d48fde5b9f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        del_ips \u003d self._get_deleted_set_ips(set_name, member_ips)"},{"line_number":82,"context_line":"        if add_ips or del_ips or not self.set_name_exists(set_name):"},{"line_number":83,"context_line":"            self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":84,"context_line":"        return del_ips"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @utils.synchronized(\u0027ipset\u0027, external\u003dTrue)"},{"line_number":87,"context_line":"    def set_members_mutate(self, set_name, ethertype, member_ips):"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_3eca26a2","line":84,"updated":"2016-11-22 13:54:02.000000000","message":"Can you document this on the set_members docstring?,\n\nAnd anyway, why would anyone expect that a \"set_members\" returns the deleted ips ?\n\nEven if unused, it could make some sense to return a tuple with (add_ips, del_ips).","commit_id":"3ed0a92916f6976fc8a5e76c0052396a2a0f0cb6"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b6e214d0d292af484ce24a654cad17d3e3993b6f","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        del_ips \u003d self._get_deleted_set_ips(set_name, member_ips)"},{"line_number":82,"context_line":"        if add_ips or del_ips or not self.set_name_exists(set_name):"},{"line_number":83,"context_line":"            self.set_members_mutate(set_name, ethertype, member_ips)"},{"line_number":84,"context_line":"        return del_ips"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    @utils.synchronized(\u0027ipset\u0027, external\u003dTrue)"},{"line_number":87,"context_line":"    def set_members_mutate(self, set_name, ethertype, member_ips):"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_edde8e3c","line":84,"in_reply_to":"7a77a97e_3eca26a2","updated":"2016-11-29 15:47:48.000000000","message":"sure","commit_id":"3ed0a92916f6976fc8a5e76c0052396a2a0f0cb6"}],"neutron/agent/linux/iptables_firewall.py":[{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"21e3dba4476d5c5d5bf4827b8af9b0658dc16fc7","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        LOG.debug(\"Update rules of security group (%s)\", sg_id)"},{"line_number":144,"context_line":"        self.sg_rules[sg_id] \u003d sg_rules"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def update_security_group_members(self, sg_id, sg_members):"},{"line_number":147,"context_line":"        LOG.debug(\"Update members of security group (%s)\", sg_id)"},{"line_number":148,"context_line":"        self.sg_members[sg_id] \u003d collections.defaultdict(list, sg_members)"},{"line_number":149,"context_line":"        if self.enable_ipset:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_dfc6ed66","line":146,"updated":"2016-08-11 07:15:29.000000000","message":"hi venkata anil, moving delete_conntrack_state_by_remote_ips to here make sence, so \nyou should consider combine method _update_remote_security_group_members at line #125, then self.devices_with_updated_sg_members can be removed","commit_id":"4e5df39bc18b5d5771d0817441af1b1f56fa1d57"},{"author":{"_account_id":8976,"name":"shihanzhang","email":"ayshihanzhang@gmail.com","username":"shihanzhang"},"change_message_id":"8227d29d9ffea105bf03ac7b2f0f603048927615","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        LOG.debug(\"Update rules of security group (%s)\", sg_id)"},{"line_number":144,"context_line":"        self.sg_rules[sg_id] \u003d sg_rules"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def update_security_group_members(self, sg_id, sg_members):"},{"line_number":147,"context_line":"        LOG.debug(\"Update members of security group (%s)\", sg_id)"},{"line_number":148,"context_line":"        self.sg_members[sg_id] \u003d collections.defaultdict(list, sg_members)"},{"line_number":149,"context_line":"        if self.enable_ipset:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_05df8ed9","line":146,"in_reply_to":"9ad45d7e_3f03bfb9","updated":"2016-08-11 11:00:16.000000000","message":"why do we still need self.devices_with_updated_sg_members? I think we can get devices by sg_id?","commit_id":"4e5df39bc18b5d5771d0817441af1b1f56fa1d57"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"a53db26b62c1a7ac7a104eb6becf457b36dc4fe9","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        LOG.debug(\"Update rules of security group (%s)\", sg_id)"},{"line_number":144,"context_line":"        self.sg_rules[sg_id] \u003d sg_rules"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def update_security_group_members(self, sg_id, sg_members):"},{"line_number":147,"context_line":"        LOG.debug(\"Update members of security group (%s)\", sg_id)"},{"line_number":148,"context_line":"        self.sg_members[sg_id] \u003d collections.defaultdict(list, sg_members)"},{"line_number":149,"context_line":"        if self.enable_ipset:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_3f03bfb9","line":146,"in_reply_to":"9ad45d7e_7a670fe9","updated":"2016-08-11 10:10:39.000000000","message":"@shihanzhang\nI feel we still need self.devices_with_updated_sg_members. Need to discuss with u about this in IRC","commit_id":"4e5df39bc18b5d5771d0817441af1b1f56fa1d57"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"3e989742c42e677d29eb5aa7efd41bb64bee872d","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        LOG.debug(\"Update rules of security group (%s)\", sg_id)"},{"line_number":144,"context_line":"        self.sg_rules[sg_id] \u003d sg_rules"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    def update_security_group_members(self, sg_id, sg_members):"},{"line_number":147,"context_line":"        LOG.debug(\"Update members of security group (%s)\", sg_id)"},{"line_number":148,"context_line":"        self.sg_members[sg_id] \u003d collections.defaultdict(list, sg_members)"},{"line_number":149,"context_line":"        if self.enable_ipset:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_7a670fe9","line":146,"in_reply_to":"9ad45d7e_dfc6ed66","updated":"2016-08-11 07:32:42.000000000","message":"sure, I will check","commit_id":"4e5df39bc18b5d5771d0817441af1b1f56fa1d57"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e121c9b3a0c4298ee573f3277fa3ff8bbb6741d6","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        if self.enable_ipset:"},{"line_number":150,"context_line":"            self.update_ipset_members(sg_id, sg_members)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def update_ipset_members(self, sg_id, sg_members):"},{"line_number":153,"context_line":"        devices \u003d self.devices_with_updated_sg_members.pop(sg_id, None)"},{"line_number":154,"context_line":"        for ip_version, current_ips in sg_members.items():"},{"line_number":155,"context_line":"            add_ips, del_ips \u003d self.ipset.set_members("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_fd578757","line":152,"updated":"2016-08-29 19:01:58.000000000","message":"private method?","commit_id":"1d4e8b9fd756a5949e3dbf4929e3a84549283a8b"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"e6ce37f1cacad0ff588dfcc7b338d7528ac521d2","unresolved":false,"context_lines":[{"line_number":149,"context_line":"        if self.enable_ipset:"},{"line_number":150,"context_line":"            self.update_ipset_members(sg_id, sg_members)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def update_ipset_members(self, sg_id, sg_members):"},{"line_number":153,"context_line":"        devices \u003d self.devices_with_updated_sg_members.pop(sg_id, None)"},{"line_number":154,"context_line":"        for ip_version, current_ips in sg_members.items():"},{"line_number":155,"context_line":"            add_ips, del_ips \u003d self.ipset.set_members("}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_8349b862","line":152,"in_reply_to":"fa7ab95a_fd578757","updated":"2016-08-29 19:21:24.000000000","message":"done","commit_id":"1d4e8b9fd756a5949e3dbf4929e3a84549283a8b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9949396ac7445822cbfd1937065ab5c19ed03c50","unresolved":false,"context_lines":[{"line_number":150,"context_line":"            self._update_ipset_members(sg_id, sg_members)"},{"line_number":151,"context_line":""},{"line_number":152,"context_line":"    def _update_ipset_members(self, sg_id, sg_members):"},{"line_number":153,"context_line":"        devices \u003d self.devices_with_updated_sg_members.pop(sg_id, None)"},{"line_number":154,"context_line":"        for ip_version, current_ips in sg_members.items():"},{"line_number":155,"context_line":"            add_ips, del_ips \u003d self.ipset.set_members("},{"line_number":156,"context_line":"                sg_id, ip_version, current_ips)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_cab81078","line":153,"range":{"start_line":153,"start_character":66,"end_line":153,"end_character":70},"updated":"2016-08-30 11:37:18.000000000","message":"Nit: Just in sake of having same type returned, I\u0027d suggest to return [] instead of None","commit_id":"5c89849e3a72f48393175159d6cd6dae6bf96416"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9949396ac7445822cbfd1937065ab5c19ed03c50","unresolved":false,"context_lines":[{"line_number":155,"context_line":"            add_ips, del_ips \u003d self.ipset.set_members("},{"line_number":156,"context_line":"                sg_id, ip_version, current_ips)"},{"line_number":157,"context_line":"            if devices and del_ips:"},{"line_number":158,"context_line":"                # remove prefix from del_ips"},{"line_number":159,"context_line":"                ips \u003d [str(netaddr.IPNetwork(del_ip).ip) for del_ip in del_ips]"},{"line_number":160,"context_line":"                self.ipconntrack.delete_conntrack_state_by_remote_ips("},{"line_number":161,"context_line":"                    devices, ip_version, ips)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_2afc1c3d","line":158,"range":{"start_line":158,"start_character":25,"end_line":158,"end_character":31},"updated":"2016-08-30 11:37:18.000000000","message":"cidr suffixes?","commit_id":"5c89849e3a72f48393175159d6cd6dae6bf96416"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"f9e948cda4d21aded887885f55b7b784d5774d31","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def _update_ipset_members(self, sg_id, sg_members):"},{"line_number":153,"context_line":"        devices \u003d self.devices_with_updated_sg_members.pop(sg_id, None)"},{"line_number":154,"context_line":"        for ip_version, current_ips in sg_members.items():"},{"line_number":155,"context_line":"            add_ips, del_ips \u003d self.ipset.set_members("},{"line_number":156,"context_line":"                sg_id, ip_version, current_ips)"},{"line_number":157,"context_line":"            if devices and del_ips:"},{"line_number":158,"context_line":"                # remove prefix from del_ips"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_937336e7","line":155,"updated":"2016-11-16 03:35:04.000000000","message":"add_ips is never used, do we need to return it?","commit_id":"2a65bc91103f10366f4be295a386ed177b8e9b46"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5bc82c44add38416beaf9033e766734119ce822a","unresolved":false,"context_lines":[{"line_number":152,"context_line":"    def _update_ipset_members(self, sg_id, sg_members):"},{"line_number":153,"context_line":"        devices \u003d self.devices_with_updated_sg_members.pop(sg_id, None)"},{"line_number":154,"context_line":"        for ip_version, current_ips in sg_members.items():"},{"line_number":155,"context_line":"            add_ips, del_ips \u003d self.ipset.set_members("},{"line_number":156,"context_line":"                sg_id, ip_version, current_ips)"},{"line_number":157,"context_line":"            if devices and del_ips:"},{"line_number":158,"context_line":"                # remove prefix from del_ips"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a77a97e_c6ca3c1a","line":155,"in_reply_to":"7a77a97e_937336e7","updated":"2016-11-16 10:44:13.000000000","message":"No need. thanks for the suggestion Brian. I will remove it.","commit_id":"2a65bc91103f10366f4be295a386ed177b8e9b46"}],"neutron/agent/securitygroups_rpc.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"2f8ec23f439896d2bf2d22c03ea626d48fde5b9f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            LOG.debug(\"Refreshing firewall for all filtered devices\")"},{"line_number":271,"context_line":"            self.refresh_firewall()"},{"line_number":272,"context_line":"        else:"},{"line_number":273,"context_line":"            if self.use_enhanced_rpc and updated_devices:"},{"line_number":274,"context_line":"                self.firewall.security_group_updated(\u0027sg_member\u0027, [],"},{"line_number":275,"context_line":"                                                     updated_devices)"},{"line_number":276,"context_line":"            # If a device is both in new and updated devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"7a77a97e_be6c769d","line":273,"updated":"2016-11-22 13:54:02.000000000","message":"we have to get rid for once an all of use_enhanced_rpc","commit_id":"3ed0a92916f6976fc8a5e76c0052396a2a0f0cb6"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"b6e214d0d292af484ce24a654cad17d3e3993b6f","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            LOG.debug(\"Refreshing firewall for all filtered devices\")"},{"line_number":271,"context_line":"            self.refresh_firewall()"},{"line_number":272,"context_line":"        else:"},{"line_number":273,"context_line":"            if self.use_enhanced_rpc and updated_devices:"},{"line_number":274,"context_line":"                self.firewall.security_group_updated(\u0027sg_member\u0027, [],"},{"line_number":275,"context_line":"                                                     updated_devices)"},{"line_number":276,"context_line":"            # If a device is both in new and updated devices"}],"source_content_type":"text/x-python","patch_set":9,"id":"5a74a57a_6dc27e54","line":273,"in_reply_to":"7a77a97e_be6c769d","updated":"2016-11-29 15:47:48.000000000","message":"Yes. I will try to do that in a separate patch soon.","commit_id":"3ed0a92916f6976fc8a5e76c0052396a2a0f0cb6"}]}
