)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"403e152c7eab7c5eccf32c52e8b7151374c2f509","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix KeyError in get_isolated_subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At present dhcp agents sync networks/subnets/ports by calling rpc api"},{"line_number":10,"context_line":"get_active_networks_info() when restart. It filters subnets with"},{"line_number":11,"context_line":"\"enable_dhcp\u003dTrue\", which is inconsistent with what get_network_info()"},{"line_number":12,"context_line":"does, and will cause KeyError in get_isolated_subnets() executed by dhcp"},{"line_number":13,"context_line":"agent. Besides, routes for neighbor IPv4 subnets in a network would be"},{"line_number":14,"context_line":"incomplete due to it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a8ec9b2_d64dac73","line":11,"range":{"start_line":10,"start_character":41,"end_line":11,"end_character":18},"updated":"2016-09-14 15:55:15.000000000","message":"I think returning only dhcp enabled subnets to dhcp agent is the right thing to do. Can\u0027t we handle (or better prevent) KeyError some other way? It seems a matter of a simple check item in list..","commit_id":"92a6c67c99318d925dd406bac1399747bacd284f"},{"author":{"_account_id":21249,"name":"Quan Tian","email":"qtian@vmware.com","username":"tianquan"},"change_message_id":"d61d7b4fabb8878531a800ee828794f6250a7842","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix KeyError in get_isolated_subnets"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"At present dhcp agents sync networks/subnets/ports by calling rpc api"},{"line_number":10,"context_line":"get_active_networks_info() when restart. It filters subnets with"},{"line_number":11,"context_line":"\"enable_dhcp\u003dTrue\", which is inconsistent with what get_network_info()"},{"line_number":12,"context_line":"does, and will cause KeyError in get_isolated_subnets() executed by dhcp"},{"line_number":13,"context_line":"agent. Besides, routes for neighbor IPv4 subnets in a network would be"},{"line_number":14,"context_line":"incomplete due to it."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da4df55a_0fa3339e","line":11,"range":{"start_line":10,"start_character":41,"end_line":11,"end_character":18},"in_reply_to":"7a8ec9b2_d64dac73","updated":"2016-12-27 05:57:07.000000000","message":"Returning only dhcp enabled subnets causes the \"classless-static-routes\" for neighbour subnets missing in same network. According to [1], I think it is necessary to return all subnets. \n\n[1] https://review.openstack.org/#/c/125043/","commit_id":"92a6c67c99318d925dd406bac1399747bacd284f"}]}