)]}'
{"neutron/common/_deprecate.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70e1373c391e740ece4d049cc1f73128b4d3c634","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron._i18n import _"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class _MovedGlobals(object):"},{"line_number":28,"context_line":"    \"\"\"Override a module to deprecate moved globals."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This class is used when globals (attributes of a module) need to be"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_5c091331","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":19},"updated":"2016-08-17 14:26:49.000000000","message":"Is there any reason we start the class name with underscore?","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"664cd0cabb94db5f9cd4ab7541b29f3def02a290","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron._i18n import _"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class _MovedGlobals(object):"},{"line_number":28,"context_line":"    \"\"\"Override a module to deprecate moved globals."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This class is used when globals (attributes of a module) need to be"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_7fab8c75","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":19},"in_reply_to":"3ac371cc_5c091331","updated":"2016-08-17 15:04:08.000000000","message":"To prevent sub-projects from adopting from Neutron. They should wait for it to be adopted by debtcollecor.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1404a3a8fdd014ca5b063e6b3d78fa0947d4e672","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from neutron._i18n import _"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class _MovedGlobals(object):"},{"line_number":28,"context_line":"    \"\"\"Override a module to deprecate moved globals."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    This class is used when globals (attributes of a module) need to be"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_f38e8c77","line":27,"range":{"start_line":27,"start_character":6,"end_line":27,"end_character":19},"in_reply_to":"3ac371cc_7fab8c75","updated":"2016-08-17 17:25:40.000000000","message":"Makes sense. It is always difficult to distinguish module (neutron)-inside methods from global methods (which can be used from sub projects).","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70e1373c391e740ece4d049cc1f73128b4d3c634","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # If new_module is the same as old_module then it is a rename in place."},{"line_number":73,"context_line":"    _mg__custom \u003d {}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, other_mod\u003dNone):"},{"line_number":76,"context_line":"        self._mg__my_globals \u003d {}  # Prevent infinite recursion"},{"line_number":77,"context_line":"        self._mg__other_mod \u003d other_mod"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_ff81d14e","line":75,"range":{"start_line":75,"start_character":23,"end_line":75,"end_character":32},"updated":"2016-08-17 14:26:49.000000000","message":"IMHO \u0027new_module\u0027 sounds easier to understand.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"97eaec9756fc9a98febb89b34c0c0b27c61c07f0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"    # If new_module is the same as old_module then it is a rename in place."},{"line_number":73,"context_line":"    _mg__custom \u003d {}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, other_mod\u003dNone):"},{"line_number":76,"context_line":"        self._mg__my_globals \u003d {}  # Prevent infinite recursion"},{"line_number":77,"context_line":"        self._mg__other_mod \u003d other_mod"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_c1041a16","line":75,"range":{"start_line":75,"start_character":23,"end_line":75,"end_character":32},"in_reply_to":"3ac371cc_ff81d14e","updated":"2016-08-18 14:45:18.000000000","message":"Done","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70e1373c391e740ece4d049cc1f73128b4d3c634","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    _mg__custom \u003d {}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, other_mod\u003dNone):"},{"line_number":76,"context_line":"        self._mg__my_globals \u003d {}  # Prevent infinite recursion"},{"line_number":77,"context_line":"        self._mg__other_mod \u003d other_mod"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        caller_frame \u003d inspect.stack()[1][0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_bfaab917","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":33},"updated":"2016-08-17 14:26:49.000000000","message":"It is not referred to until L.77, so is it unnecessary?","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1404a3a8fdd014ca5b063e6b3d78fa0947d4e672","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    _mg__custom \u003d {}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, other_mod\u003dNone):"},{"line_number":76,"context_line":"        self._mg__my_globals \u003d {}  # Prevent infinite recursion"},{"line_number":77,"context_line":"        self._mg__other_mod \u003d other_mod"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        caller_frame \u003d inspect.stack()[1][0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_9340f835","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":33},"in_reply_to":"3ac371cc_3fb2b494","updated":"2016-08-17 17:25:40.000000000","message":"Yeah, I meant L.86. I now understand the background.\nIt is better to make the comment on L.76 more explicit, for example, \"to avoid infinite recursion at inspect.getsourcelines below\".","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"97eaec9756fc9a98febb89b34c0c0b27c61c07f0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    _mg__custom \u003d {}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, other_mod\u003dNone):"},{"line_number":76,"context_line":"        self._mg__my_globals \u003d {}  # Prevent infinite recursion"},{"line_number":77,"context_line":"        self._mg__other_mod \u003d other_mod"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        caller_frame \u003d inspect.stack()[1][0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_e1015606","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":33},"in_reply_to":"3ac371cc_9340f835","updated":"2016-08-18 14:45:18.000000000","message":"Done","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"664cd0cabb94db5f9cd4ab7541b29f3def02a290","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    _mg__custom \u003d {}"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def __init__(self, other_mod\u003dNone):"},{"line_number":76,"context_line":"        self._mg__my_globals \u003d {}  # Prevent infinite recursion"},{"line_number":77,"context_line":"        self._mg__other_mod \u003d other_mod"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        caller_frame \u003d inspect.stack()[1][0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_3fb2b494","line":76,"range":{"start_line":76,"start_character":8,"end_line":76,"end_character":33},"in_reply_to":"3ac371cc_bfaab917","updated":"2016-08-17 15:04:08.000000000","message":"You mean L.86 I think. The problem is L82 causes __get_attr__ to be called on self which causes infinite recursion.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70e1373c391e740ece4d049cc1f73128b4d3c634","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"                old_location \u003d \u0027%s.%s\u0027 % (old_module.__name__, name)"},{"line_number":107,"context_line":"                new_location \u003d \u0027%s.%s\u0027 % (new_module.__name__, new_name)"},{"line_number":108,"context_line":"                changed \u003d \u0027renamed\u0027 if old_module \u003d\u003d new_module else \u0027moved\u0027"},{"line_number":109,"context_line":"                debtcollector.deprecate("},{"line_number":110,"context_line":"                    old_location,"},{"line_number":111,"context_line":"                    message\u003d\u0027%s to %s\u0027 % (changed, new_location),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_2aca09a2","line":108,"range":{"start_line":108,"start_character":36,"end_line":108,"end_character":63},"updated":"2016-08-17 14:26:49.000000000","message":"Is there a case where old_module and new_module are same?","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"664cd0cabb94db5f9cd4ab7541b29f3def02a290","unresolved":false,"context_lines":[{"line_number":105,"context_line":""},{"line_number":106,"context_line":"                old_location \u003d \u0027%s.%s\u0027 % (old_module.__name__, name)"},{"line_number":107,"context_line":"                new_location \u003d \u0027%s.%s\u0027 % (new_module.__name__, new_name)"},{"line_number":108,"context_line":"                changed \u003d \u0027renamed\u0027 if old_module \u003d\u003d new_module else \u0027moved\u0027"},{"line_number":109,"context_line":"                debtcollector.deprecate("},{"line_number":110,"context_line":"                    old_location,"},{"line_number":111,"context_line":"                    message\u003d\u0027%s to %s\u0027 % (changed, new_location),"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_5f533039","line":108,"range":{"start_line":108,"start_character":36,"end_line":108,"end_character":63},"in_reply_to":"3ac371cc_2aca09a2","updated":"2016-08-17 15:04:08.000000000","message":"Yes, this is the case for _moved_globals(\u0027FOO\u0027, new_name\u003d\u0027BAR\u0027) which renames a global in the old module.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70e1373c391e740ece4d049cc1f73128b4d3c634","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        self._mg__my_globals.pop(name)"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"def _moved_global(old_name, new_module\u003dNone, new_name\u003dNone):"},{"line_number":135,"context_line":"    \"\"\"Deprecate a single attribute in a module."},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    This function is used to move an attribute to a module that differs"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_9f1a5d6d","line":134,"range":{"start_line":134,"start_character":4,"end_line":134,"end_character":17},"updated":"2016-08-17 14:26:49.000000000","message":"same question: why do we need to make the method private?","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"70e1373c391e740ece4d049cc1f73128b4d3c634","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    assert new_module or new_name  # One or both must be new"},{"line_number":155,"context_line":"    if isinstance(new_module, _MovedGlobals):"},{"line_number":156,"context_line":"        # The new module has been shimmed, get the original"},{"line_number":157,"context_line":"        new_module \u003d new_module._mg__old_ref"},{"line_number":158,"context_line":"    old_module \u003d inspect.getmodule(inspect.stack()[1][0])  # caller\u0027s module"},{"line_number":159,"context_line":"    new_module \u003d new_module if new_module else old_module"},{"line_number":160,"context_line":"    new_name \u003d new_name if new_name else old_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_fd78b691","line":157,"range":{"start_line":155,"start_character":4,"end_line":157,"end_character":44},"updated":"2016-08-17 14:26:49.000000000","message":"I wonder what is the expected behavior here.\n\nIf \u0027new_module\u0027 is _MovedGlobals, it means \u0027new_module\u0027 is moved to some other module. If so, isn\u0027t it better to use **some other module** as a new module rather than \u0027new_module\u0027 passed in the argument?\n\nWhy do we get the original?","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"1404a3a8fdd014ca5b063e6b3d78fa0947d4e672","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    assert new_module or new_name  # One or both must be new"},{"line_number":155,"context_line":"    if isinstance(new_module, _MovedGlobals):"},{"line_number":156,"context_line":"        # The new module has been shimmed, get the original"},{"line_number":157,"context_line":"        new_module \u003d new_module._mg__old_ref"},{"line_number":158,"context_line":"    old_module \u003d inspect.getmodule(inspect.stack()[1][0])  # caller\u0027s module"},{"line_number":159,"context_line":"    new_module \u003d new_module if new_module else old_module"},{"line_number":160,"context_line":"    new_name \u003d new_name if new_name else old_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_5e55e7f7","line":157,"range":{"start_line":155,"start_character":4,"end_line":157,"end_character":44},"in_reply_to":"3ac371cc_02e5dfda","updated":"2016-08-17 17:25:40.000000000","message":"Thanks for clarification. It took me a bit time to understand.\n\nAssume \"foo.BAR\" is moved to \"bar.BAR\" but \"foo\" still has \"foo.FOO\".\nIf we want to depreate bar.FOO and use foo.FOO at the same time, we hit this case.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"97eaec9756fc9a98febb89b34c0c0b27c61c07f0","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    assert new_module or new_name  # One or both must be new"},{"line_number":155,"context_line":"    if isinstance(new_module, _MovedGlobals):"},{"line_number":156,"context_line":"        # The new module has been shimmed, get the original"},{"line_number":157,"context_line":"        new_module \u003d new_module._mg__old_ref"},{"line_number":158,"context_line":"    old_module \u003d inspect.getmodule(inspect.stack()[1][0])  # caller\u0027s module"},{"line_number":159,"context_line":"    new_module \u003d new_module if new_module else old_module"},{"line_number":160,"context_line":"    new_name \u003d new_name if new_name else old_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_0122b2a2","line":157,"range":{"start_line":155,"start_character":4,"end_line":157,"end_character":44},"in_reply_to":"3ac371cc_5e55e7f7","updated":"2016-08-18 14:45:18.000000000","message":"Exactly.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"664cd0cabb94db5f9cd4ab7541b29f3def02a290","unresolved":false,"context_lines":[{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    \"\"\""},{"line_number":154,"context_line":"    assert new_module or new_name  # One or both must be new"},{"line_number":155,"context_line":"    if isinstance(new_module, _MovedGlobals):"},{"line_number":156,"context_line":"        # The new module has been shimmed, get the original"},{"line_number":157,"context_line":"        new_module \u003d new_module._mg__old_ref"},{"line_number":158,"context_line":"    old_module \u003d inspect.getmodule(inspect.stack()[1][0])  # caller\u0027s module"},{"line_number":159,"context_line":"    new_module \u003d new_module if new_module else old_module"},{"line_number":160,"context_line":"    new_name \u003d new_name if new_name else old_name"}],"source_content_type":"text/x-python","patch_set":5,"id":"3ac371cc_02e5dfda","line":157,"range":{"start_line":155,"start_character":4,"end_line":157,"end_character":44},"in_reply_to":"3ac371cc_fd78b691","updated":"2016-08-17 15:04:08.000000000","message":"Not everything in a module is necessarily moved. By using old_ref here it will cover the case of an unmoved global in new_module, and issue another deprecation warning for a moved global.","commit_id":"385f2dac4e6941d573f27d58c3cd6c300a474a1f"},{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3ca100f00113086fd75f3013d958786ad38db8f8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # The new module has been shimmed, get the original"},{"line_number":160,"context_line":"        new_module \u003d new_module._mg__old_ref"},{"line_number":161,"context_line":"    old_module \u003d inspect.getmodule(inspect.stack()[1][0])  # caller\u0027s module"},{"line_number":162,"context_line":"    new_module \u003d new_module if new_module else old_module"},{"line_number":163,"context_line":"    new_name \u003d new_name if new_name else old_name"},{"line_number":164,"context_line":"    _MovedGlobals._mg__moves[(old_module, old_name)] \u003d (new_module, new_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_ca36b751","line":162,"updated":"2016-08-28 05:04:11.000000000","message":"new_module \u003d new_module or old_module\nnew_name \u003d new_name or old_name","commit_id":"f85aef78e94de14279d2482f699d3a1454f3505b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"86e23479e89126a6998a749d1ccad569491eff95","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        # The new module has been shimmed, get the original"},{"line_number":160,"context_line":"        new_module \u003d new_module._mg__old_ref"},{"line_number":161,"context_line":"    old_module \u003d inspect.getmodule(inspect.stack()[1][0])  # caller\u0027s module"},{"line_number":162,"context_line":"    new_module \u003d new_module if new_module else old_module"},{"line_number":163,"context_line":"    new_name \u003d new_name if new_name else old_name"},{"line_number":164,"context_line":"    _MovedGlobals._mg__moves[(old_module, old_name)] \u003d (new_module, new_name)"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_0a8b3fc4","line":162,"in_reply_to":"fa7ab95a_ca36b751","updated":"2016-08-28 10:36:28.000000000","message":"Done","commit_id":"f85aef78e94de14279d2482f699d3a1454f3505b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"05469e5cfa11a416f6623609972b5a8a9ee4ab76","unresolved":false,"context_lines":[{"line_number":17,"context_line":"NOTE: This module may be a candidate for adoption by debtcollector."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import debtcollector"},{"line_number":21,"context_line":"import inspect"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_6d0937dd","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":20},"updated":"2016-08-29 13:20:01.000000000","message":"nit: debtcollector is third party and others are system modules.","commit_id":"2d95d3fb5d9087818acf89d81162a07a5e38fcff"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5ae4631edc6afc854f3eef1eb95afb9c76152117","unresolved":false,"context_lines":[{"line_number":17,"context_line":"NOTE: This module may be a candidate for adoption by debtcollector."},{"line_number":18,"context_line":"\"\"\""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"import debtcollector"},{"line_number":21,"context_line":"import inspect"},{"line_number":22,"context_line":"import sys"},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_d7836954","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":20},"in_reply_to":"fa7ab95a_6d0937dd","updated":"2016-08-30 05:23:05.000000000","message":"Done","commit_id":"2d95d3fb5d9087818acf89d81162a07a5e38fcff"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"05469e5cfa11a416f6623609972b5a8a9ee4ab76","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        function, see below."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    This class must be called from the last line in a module, as follows:"},{"line_number":41,"context_line":"    ``_deprecate._MovedGlobals()``"},{"line_number":42,"context_line":"    or"},{"line_number":43,"context_line":"    ``_deprecate._MovedGlobals(default_new_module)``"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Args:"},{"line_number":46,"context_line":"        :param default_new_module: The default new location for moved globals"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_ed1c6715","line":43,"range":{"start_line":41,"start_character":4,"end_line":43,"end_character":52},"updated":"2016-08-29 13:20:01.000000000","message":"It is better that the order of L.41 and L.43 matches the order of L.33 and L.37.","commit_id":"2d95d3fb5d9087818acf89d81162a07a5e38fcff"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"5ae4631edc6afc854f3eef1eb95afb9c76152117","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        function, see below."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    This class must be called from the last line in a module, as follows:"},{"line_number":41,"context_line":"    ``_deprecate._MovedGlobals()``"},{"line_number":42,"context_line":"    or"},{"line_number":43,"context_line":"    ``_deprecate._MovedGlobals(default_new_module)``"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    Args:"},{"line_number":46,"context_line":"        :param default_new_module: The default new location for moved globals"}],"source_content_type":"text/x-python","patch_set":9,"id":"fa7ab95a_f7886d73","line":43,"range":{"start_line":41,"start_character":4,"end_line":43,"end_character":52},"in_reply_to":"fa7ab95a_ed1c6715","updated":"2016-08-30 05:23:05.000000000","message":"Done","commit_id":"2d95d3fb5d9087818acf89d81162a07a5e38fcff"}],"neutron/db/allowed_address_pairs/models.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"3ca100f00113086fd75f3013d958786ad38db8f8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.common import _deprecate"},{"line_number":14,"context_line":"from neutron.db.models import allowed_address_pair"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# The DB models have been relocated to neutron.db.models.allowed_address_pair"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_ea39bb42","line":14,"updated":"2016-08-28 05:04:11.000000000","message":"was this change necessary because of a limitation of the new approach?","commit_id":"f85aef78e94de14279d2482f699d3a1454f3505b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"86e23479e89126a6998a749d1ccad569491eff95","unresolved":false,"context_lines":[{"line_number":11,"context_line":"#    under the License."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"from neutron.common import _deprecate"},{"line_number":14,"context_line":"from neutron.db.models import allowed_address_pair"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"# The DB models have been relocated to neutron.db.models.allowed_address_pair"}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_6af92b4d","line":14,"in_reply_to":"fa7ab95a_ea39bb42","updated":"2016-08-28 10:36:28.000000000","message":"No","commit_id":"f85aef78e94de14279d2482f699d3a1454f3505b"}],"neutron/plugins/ml2/drivers/type_flat.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"57a9499eee323ee957c2d8d5be684ad567838f98","unresolved":false,"context_lines":[{"line_number":41,"context_line":"cfg.CONF.register_opts(flat_opts, \"ml2_type_flat\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"_deprecate._moved_global(\u0027FlatAllocation\u0027, new_module\u003dtype_flat_model)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FlatTypeDriver(helpers.BaseTypeDriver):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_d8661cec","line":44,"range":{"start_line":44,"start_character":43,"end_line":44,"end_character":54},"updated":"2016-08-30 13:26:53.000000000","message":"nit: \u0027new_module\u003dxxx\u0027 is used in some module and not in some modules. Both are okay but it looks a bit inconsistent, especially type_flat and type_gre use different patterns.","commit_id":"e0f2e0b0def4ce91fdcbab585ecb9a3ab84322d3"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"2d504a07d5e00e48daaf2c394ebf21d49357d545","unresolved":false,"context_lines":[{"line_number":41,"context_line":"cfg.CONF.register_opts(flat_opts, \"ml2_type_flat\")"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"_deprecate._moved_global(\u0027FlatAllocation\u0027, new_module\u003dtype_flat_model)"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"class FlatTypeDriver(helpers.BaseTypeDriver):"}],"source_content_type":"text/x-python","patch_set":10,"id":"fa7ab95a_ae44ae49","line":44,"range":{"start_line":44,"start_character":43,"end_line":44,"end_character":54},"in_reply_to":"fa7ab95a_d8661cec","updated":"2016-08-30 13:52:24.000000000","message":"I don\u0027t like that. Let me fix it.","commit_id":"e0f2e0b0def4ce91fdcbab585ecb9a3ab84322d3"}]}
