)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3f1a0268afe8e60effd6f0c97b8eb7b4b11618dc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SR-IOV: deprecate supported_pci_vendor_devs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To reduce complexity in configuring SR-IOV I want to deprecate"},{"line_number":10,"context_line":"the supported_pci_vendor_devs option. This option is doing extra"},{"line_number":11,"context_line":"validation that pci vendor id and product id provided by"},{"line_number":12,"context_line":"nova in the neutron port binding profile is matching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_64d9a883","line":9,"updated":"2016-08-09 12:02:33.000000000","message":"Nit: I would avoid using the first person in any patch commit message.  Maybe something like \"In order to reduce complexity in the SR-IOV configuration it is desired to deprecate the supported_pci_vendor_devs option\".","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"SR-IOV: deprecate supported_pci_vendor_devs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To reduce complexity in configuring SR-IOV I want to deprecate"},{"line_number":10,"context_line":"the supported_pci_vendor_devs option. This option is doing extra"},{"line_number":11,"context_line":"validation that pci vendor id and product id provided by"},{"line_number":12,"context_line":"nova in the neutron port binding profile is matching"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_6e304b9f","line":9,"in_reply_to":"9ad45d7e_64d9a883","updated":"2016-08-09 19:55:11.000000000","message":"Done","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":23061,"name":"Trinath Somanchi","username":"strinath","inactive":true},"change_message_id":"506eda7ce15184c3cd151f45c144581ef70ec918","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To reduce complexity in configuring SR-IOV I want to deprecate"},{"line_number":10,"context_line":"the supported_pci_vendor_devs option. This option is doing extra"},{"line_number":11,"context_line":"validation that pci vendor id and product id provided by"},{"line_number":12,"context_line":"nova in the neutron port binding profile is matching"},{"line_number":13,"context_line":"to the vendor id and product id  in supported_pci_vendor_devs."},{"line_number":14,"context_line":"This is redundant, because nova-scheduler is the point to do"},{"line_number":15,"context_line":"validation and select a suitable hypervisor and  The compute node is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_bedc4d13","line":12,"updated":"2016-08-09 11:31:21.000000000","message":"To be more readable and specific, \n\n.. doing extra validation that pci_vendor_id and product_id provided by...\n\n\nand below,\n\n.. to the vendor_id and product_id in..\n\n\ncan you recheck this","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To reduce complexity in configuring SR-IOV I want to deprecate"},{"line_number":10,"context_line":"the supported_pci_vendor_devs option. This option is doing extra"},{"line_number":11,"context_line":"validation that pci vendor id and product id provided by"},{"line_number":12,"context_line":"nova in the neutron port binding profile is matching"},{"line_number":13,"context_line":"to the vendor id and product id  in supported_pci_vendor_devs."},{"line_number":14,"context_line":"This is redundant, because nova-scheduler is the point to do"},{"line_number":15,"context_line":"validation and select a suitable hypervisor and  The compute node is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_ce2177a1","line":12,"in_reply_to":"9ad45d7e_bedc4d13","updated":"2016-08-09 19:55:11.000000000","message":"I am not a native speaker, do you have recommnadtion on how to rephrase this","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":23061,"name":"Trinath Somanchi","username":"strinath","inactive":true},"change_message_id":"871cb7209fafe518ebbf5f66d860c0d170f0da9c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To reduce complexity in configuring SR-IOV I want to deprecate"},{"line_number":10,"context_line":"the supported_pci_vendor_devs option. This option is doing extra"},{"line_number":11,"context_line":"validation that pci vendor id and product id provided by"},{"line_number":12,"context_line":"nova in the neutron port binding profile is matching"},{"line_number":13,"context_line":"to the vendor id and product id  in supported_pci_vendor_devs."},{"line_number":14,"context_line":"This is redundant, because nova-scheduler is the point to do"},{"line_number":15,"context_line":"validation and select a suitable hypervisor and  The compute node is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_c6d2e9ff","line":12,"in_reply_to":"9ad45d7e_ce2177a1","updated":"2016-08-10 07:22:58.000000000","message":"Nice. I mean to say that \"pci vendor id\" imply \"pci_vendor_id\" ??","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":23061,"name":"Trinath Somanchi","username":"strinath","inactive":true},"change_message_id":"506eda7ce15184c3cd151f45c144581ef70ec918","unresolved":false,"context_lines":[{"line_number":16,"context_line":"already validating this through the pci_passthrough_whitelist"},{"line_number":17,"context_line":"option in nova.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch deprecates the supported_pci_vendor_devs  in Newtown"},{"line_number":20,"context_line":"and updates the supported_pci_vendor_devs default to None."},{"line_number":21,"context_line":"In case of None value the SR-IOV mechanism driver won\u0027t do"},{"line_number":22,"context_line":"any pci vendor validation. In case this option is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_be4a8dc3","line":19,"updated":"2016-08-09 11:31:21.000000000","message":"s/Newtown/Neutron?","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":16,"context_line":"already validating this through the pci_passthrough_whitelist"},{"line_number":17,"context_line":"option in nova.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch deprecates the supported_pci_vendor_devs  in Newtown"},{"line_number":20,"context_line":"and updates the supported_pci_vendor_devs default to None."},{"line_number":21,"context_line":"In case of None value the SR-IOV mechanism driver won\u0027t do"},{"line_number":22,"context_line":"any pci vendor validation. In case this option is set"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_cb5b2986","line":19,"in_reply_to":"9ad45d7e_be4a8dc3","updated":"2016-08-09 19:55:11.000000000","message":"Sorry I meant Newton release","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3f1a0268afe8e60effd6f0c97b8eb7b4b11618dc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"and updates the supported_pci_vendor_devs default to None."},{"line_number":21,"context_line":"In case of None value the SR-IOV mechanism driver won\u0027t do"},{"line_number":22,"context_line":"any pci vendor validation. In case this option is set"},{"line_number":23,"context_line":"the SR-IOV mechanism driver will do the validaiton as it was"},{"line_number":24,"context_line":"before."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_245cd0ec","line":23,"updated":"2016-08-09 12:02:33.000000000","message":"s/validaiton/validation/","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":20,"context_line":"and updates the supported_pci_vendor_devs default to None."},{"line_number":21,"context_line":"In case of None value the SR-IOV mechanism driver won\u0027t do"},{"line_number":22,"context_line":"any pci vendor validation. In case this option is set"},{"line_number":23,"context_line":"the SR-IOV mechanism driver will do the validaiton as it was"},{"line_number":24,"context_line":"before."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_4be739b0","line":23,"in_reply_to":"9ad45d7e_245cd0ec","updated":"2016-08-09 19:55:11.000000000","message":"Done","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"66463dc1f85562e66b6abbc9f53f736abde37605","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This is redundant, because nova-scheduler is the point to do"},{"line_number":15,"context_line":"validation and select a suitable hypervisor and  The compute node is"},{"line_number":16,"context_line":"already validating this through the pci_passthrough_whitelist"},{"line_number":17,"context_line":"option in nova.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch deprecates the supported_pci_vendor_devs in Newton release"},{"line_number":20,"context_line":"and updates the supported_pci_vendor_devs default to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_9f832756","line":17,"updated":"2016-08-09 20:16:06.000000000","message":"Consider something like this:\n\nDeprecate the supported_pci_vendor_devs option in order to reduce complexity of configuring SR-IOV.  Currently, neutron validates the pci vendor and product id.  However this check is already done by the nova-scheduler when it select a suitable hypervisor.  More precisely, the compute node validate this through the pci_passthrough_whitelist\noption in nova.conf.  Therefore this check in neutron is redundant.","commit_id":"835c867fae508ae52c7d0c81ddc5a5e46520de45"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"2ff36e6f306a71554f39df58cdb5a96d08c86c3b","unresolved":false,"context_lines":[{"line_number":14,"context_line":"This is redundant, because nova-scheduler is the point to do"},{"line_number":15,"context_line":"validation and select a suitable hypervisor and  The compute node is"},{"line_number":16,"context_line":"already validating this through the pci_passthrough_whitelist"},{"line_number":17,"context_line":"option in nova.conf"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"This patch deprecates the supported_pci_vendor_devs in Newton release"},{"line_number":20,"context_line":"and updates the supported_pci_vendor_devs default to None."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9ad45d7e_2c78098f","line":17,"in_reply_to":"9ad45d7e_9f832756","updated":"2016-08-10 05:35:27.000000000","message":"Done","commit_id":"835c867fae508ae52c7d0c81ddc5a5e46520de45"},{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"c8ec8b5408763569388b7da0039c36d4f94bdb51","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SR-IOV: deprecate supported_pci_vendor_devs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deprecate the supported_pci_vendor_devs option in order to reduce"},{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9ad45d7e_119eec62","line":10,"updated":"2016-08-10 11:34:28.000000000","message":"s/of/for/","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SR-IOV: deprecate supported_pci_vendor_devs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Deprecate the supported_pci_vendor_devs option in order to reduce"},{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_13add631","line":10,"in_reply_to":"9ad45d7e_119eec62","updated":"2016-08-14 06:59:37.000000000","message":"Done","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Deprecate the supported_pci_vendor_devs option in order to reduce"},{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"},{"line_number":14,"context_line":"option in nova.conf. Therefore this check in neutron is redundant."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ac969e8_572573c0","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":29},"updated":"2016-08-13 09:17:18.000000000","message":"nit: selects","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Deprecate the supported_pci_vendor_devs option in order to reduce"},{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"},{"line_number":14,"context_line":"option in nova.conf. Therefore this check in neutron is redundant."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ac969e8_972feba0","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":14},"updated":"2016-08-13 09:17:18.000000000","message":"quick question from a lazy reviewer: since when does Nova validate it?","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Deprecate the supported_pci_vendor_devs option in order to reduce"},{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"},{"line_number":14,"context_line":"option in nova.conf. Therefore this check in neutron is redundant."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_73aa4a1b","line":12,"range":{"start_line":12,"start_character":23,"end_line":12,"end_character":29},"in_reply_to":"7ac969e8_572573c0","updated":"2016-08-14 06:59:37.000000000","message":"Done","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Deprecate the supported_pci_vendor_devs option in order to reduce"},{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"},{"line_number":14,"context_line":"option in nova.conf. Therefore this check in neutron is redundant."},{"line_number":15,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_b3620215","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":14},"in_reply_to":"7ac969e8_972feba0","updated":"2016-08-14 06:59:37.000000000","message":"since Juno - when SR-IOV introduce.","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"},{"line_number":14,"context_line":"option in nova.conf. Therefore this check in neutron is redundant."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch deprecates the supported_pci_vendor_devs in Newton release"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ac969e8_372277ba","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":25},"updated":"2016-08-13 09:17:18.000000000","message":"validates","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"complexity of configuring SR-IOV. Currently, neutron validates the pci"},{"line_number":11,"context_line":"vendor and product id. However this check is already done by the"},{"line_number":12,"context_line":"nova-scheduler when it select a suitable hypervisor. More precisely,"},{"line_number":13,"context_line":"the compute node validate this through the pci_passthrough_whitelist"},{"line_number":14,"context_line":"option in nova.conf. Therefore this check in neutron is redundant."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch deprecates the supported_pci_vendor_devs in Newton release"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3ac371cc_93670625","line":13,"range":{"start_line":13,"start_character":17,"end_line":13,"end_character":25},"in_reply_to":"7ac969e8_372277ba","updated":"2016-08-14 06:59:37.000000000","message":"Done","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"}],"neutron/plugins/ml2/drivers/mech_sriov/mech_driver/mech_driver.py":[{"author":{"_account_id":17973,"name":"Ludovic Beliveau","email":"lbeliveau@gmail.com","username":"lbeliveau"},"change_message_id":"3f1a0268afe8e60effd6f0c97b8eb7b4b11618dc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":32,"context_line":"VIF_TYPE_HOSTDEV_PHY \u003d \u0027hostdev_physical\u0027"},{"line_number":33,"context_line":"FLAT_VLAN \u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"sriov_opts \u003d ["},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027supported_pci_vendor_devs\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_44274464","line":34,"updated":"2016-08-09 12:02:33.000000000","message":"Do we want to deprecate it in the long term (future release), if so maybe add a comment to explicitly say that.","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bac7c097b756367b41d2166c15b7d047100b79b0","unresolved":false,"context_lines":[{"line_number":31,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":32,"context_line":"VIF_TYPE_HOSTDEV_PHY \u003d \u0027hostdev_physical\u0027"},{"line_number":33,"context_line":"FLAT_VLAN \u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"sriov_opts \u003d ["},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027supported_pci_vendor_devs\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_e47c78ed","line":34,"in_reply_to":"9ad45d7e_44274464","updated":"2016-08-09 12:18:31.000000000","message":"Please, add something like:\n\"This option is deprecated and will be removed in the O release\"","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":31,"context_line":"VIF_TYPE_HW_VEB \u003d \u0027hw_veb\u0027"},{"line_number":32,"context_line":"VIF_TYPE_HOSTDEV_PHY \u003d \u0027hostdev_physical\u0027"},{"line_number":33,"context_line":"FLAT_VLAN \u003d 0"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"sriov_opts \u003d ["},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027supported_pci_vendor_devs\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_ae5c03ee","line":34,"in_reply_to":"9ad45d7e_e47c78ed","updated":"2016-08-09 19:55:11.000000000","message":"Done","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bac7c097b756367b41d2166c15b7d047100b79b0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d_(\"Comma-separated list of supported PCI vendor devices, \""},{"line_number":39,"context_line":"                      \"as defined by vendor_id:product_id according to the \""},{"line_number":40,"context_line":"                      \"PCI ID Repository. Default None except all PCI vendor \""},{"line_number":41,"context_line":"                      \"devices\"),"},{"line_number":42,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_245e9076","line":40,"range":{"start_line":40,"start_character":55,"end_line":40,"end_character":61},"updated":"2016-08-09 12:18:31.000000000","message":"Should it be \"accept\"?","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d_(\"Comma-separated list of supported PCI vendor devices, \""},{"line_number":39,"context_line":"                      \"as defined by vendor_id:product_id according to the \""},{"line_number":40,"context_line":"                      \"PCI ID Repository. Default None except all PCI vendor \""},{"line_number":41,"context_line":"                      \"devices\"),"},{"line_number":42,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_0e6a6fb3","line":40,"range":{"start_line":40,"start_character":55,"end_line":40,"end_character":61},"in_reply_to":"9ad45d7e_245e9076","updated":"2016-08-09 19:55:11.000000000","message":"Done","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"bac7c097b756367b41d2166c15b7d047100b79b0","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def initialize(self):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self.pci_vendor_info \u003d cfg.CONF.ml2_sriov.supported_pci_vendor_devs"},{"line_number":97,"context_line":"            if self.pci_vendor_info is not None:"},{"line_number":98,"context_line":"                self._check_pci_vendor_config(self.pci_vendor_info)"},{"line_number":99,"context_line":"        except ValueError:"},{"line_number":100,"context_line":"            LOG.exception(_LE(\"Failed to parse supported PCI vendor devices\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_0496ecef","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":48},"updated":"2016-08-09 12:18:31.000000000","message":"I think this check is not needed, because is done in 179-180","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"b1625eee890e2c134e96abb9a97ad2a8b566a281","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    def initialize(self):"},{"line_number":95,"context_line":"        try:"},{"line_number":96,"context_line":"            self.pci_vendor_info \u003d cfg.CONF.ml2_sriov.supported_pci_vendor_devs"},{"line_number":97,"context_line":"            if self.pci_vendor_info is not None:"},{"line_number":98,"context_line":"                self._check_pci_vendor_config(self.pci_vendor_info)"},{"line_number":99,"context_line":"        except ValueError:"},{"line_number":100,"context_line":"            LOG.exception(_LE(\"Failed to parse supported PCI vendor devices\"))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2e69338c","line":97,"range":{"start_line":97,"start_character":0,"end_line":97,"end_character":48},"in_reply_to":"9ad45d7e_0496ecef","updated":"2016-08-09 19:55:11.000000000","message":"we need this so that we won\u0027t failed on the config check (_check_pci_vendor_config)  in line 209","commit_id":"b64141fea9b837df5b91e8938d4ac5a222c0385d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"sriov_opts \u003d ["},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027supported_pci_vendor_devs\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d_(\"Comma-separated list of supported PCI vendor devices, \""},{"line_number":39,"context_line":"                      \"as defined by vendor_id:product_id according to the \""},{"line_number":40,"context_line":"                      \"PCI ID Repository. Default None accept all PCI vendor \""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_3709d732","line":37,"updated":"2016-08-13 09:17:18.000000000","message":"This is the default in oslo.config, you could remove the line.","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":34,"context_line":""},{"line_number":35,"context_line":"sriov_opts \u003d ["},{"line_number":36,"context_line":"    cfg.ListOpt(\u0027supported_pci_vendor_devs\u0027,"},{"line_number":37,"context_line":"               default\u003dNone,"},{"line_number":38,"context_line":"               help\u003d_(\"Comma-separated list of supported PCI vendor devices, \""},{"line_number":39,"context_line":"                      \"as defined by vendor_id:product_id according to the \""},{"line_number":40,"context_line":"                      \"PCI ID Repository. Default None accept all PCI vendor \""}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_7381aa8f","line":37,"in_reply_to":"7ac969e8_3709d732","updated":"2016-08-14 06:59:37.000000000","message":"Done","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"                      \"devices\""},{"line_number":42,"context_line":"                      \"DEPRECATED: This option is deprecated in the Newton \""},{"line_number":43,"context_line":"                      \"release and will be removed in the Ocata release. \""},{"line_number":44,"context_line":"                      \"From Ocata the mechanism driver will accept all PCI \""},{"line_number":45,"context_line":"                      \"vendor devices.\"),"},{"line_number":46,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":47,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_b71ca778","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":33},"updated":"2016-08-13 09:17:18.000000000","message":"Starting from Ocata","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"52ad406e702fbaf1ee4dca41115648210b2fc3e3","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                      \"release and will be removed in the Ocata release. \""},{"line_number":43,"context_line":"                      \"Starting from Ocata the mechanism driver will accept \""},{"line_number":44,"context_line":"                      \"all PCI vendor devices.\"),"},{"line_number":45,"context_line":"                deprecated_for_removal\u003dTrue),"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"]"},{"line_number":48,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_2b485a2d","line":45,"updated":"2016-08-14 11:30:54.000000000","message":"can you please add a release note","commit_id":"6d86ee0392d32bfca1fbfc4658264322f37cc459"}],"neutron/tests/unit/plugins/ml2/drivers/mech_sriov/mech_driver/test_mech_sriov_nic_switch.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":193,"context_line":"        with mock.patch(\u0027neutron.plugins.ml2.drivers.mech_sriov.\u0027"},{"line_number":194,"context_line":"                        \u0027mech_driver.mech_driver.LOG\u0027) as log_mock:"},{"line_number":195,"context_line":"            self._check_for_pci_vendor_info({})"},{"line_number":196,"context_line":"            log_mock.debug.assert_called_with(\"Missing profile in port\""},{"line_number":197,"context_line":"                                              \" binding\")"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def test_profile_missing_pci_vendor_info(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_12578903","line":196,"updated":"2016-08-13 09:17:18.000000000","message":"this is irrelevant to the patch, but those tests are not ideal: it\u0027s generally not right to validate a log message, or even that a log message was triggered.","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.driver.initialize()"},{"line_number":288,"context_line":"        self.assertEqual([\u0027x:y\u0027, \u0027a:b\u0027], self.driver.pci_vendor_info)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def test_pci_vendor_config_default_entry(self):"},{"line_number":291,"context_line":"        self.driver.initialize()"},{"line_number":292,"context_line":"        self.assertEqual(None,"},{"line_number":293,"context_line":"                         self.driver.pci_vendor_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_323e05b9","line":290,"updated":"2016-08-13 09:17:18.000000000","message":"Honestly, this test case is not very useful since it\u0027s effectively validating the default value for the option. [+ that it\u0027s copied into self.pci_vendor_info)","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":287,"context_line":"        self.driver.initialize()"},{"line_number":288,"context_line":"        self.assertEqual([\u0027x:y\u0027, \u0027a:b\u0027], self.driver.pci_vendor_info)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def test_pci_vendor_config_default_entry(self):"},{"line_number":291,"context_line":"        self.driver.initialize()"},{"line_number":292,"context_line":"        self.assertEqual(None,"},{"line_number":293,"context_line":"                         self.driver.pci_vendor_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_b3496291","line":290,"in_reply_to":"7ac969e8_323e05b9","updated":"2016-08-14 06:59:37.000000000","message":"I will remove it","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def test_pci_vendor_config_default_entry(self):"},{"line_number":291,"context_line":"        self.driver.initialize()"},{"line_number":292,"context_line":"        self.assertEqual(None,"},{"line_number":293,"context_line":"                         self.driver.pci_vendor_info)"},{"line_number":294,"context_line":""},{"line_number":295,"context_line":"    def test_pci_vendor_config_wrong_entry(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_52410139","line":292,"range":{"start_line":292,"start_character":13,"end_line":292,"end_character":24},"updated":"2016-08-13 09:17:18.000000000","message":"assertIsNone","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":312,"context_line":"        self._set_config([\u0027\u0027])"},{"line_number":313,"context_line":"        self.assertRaises(cfg.Error, self.driver.initialize)"},{"line_number":314,"context_line":""},{"line_number":315,"context_line":"    def test_initialize_pci_devs_none(self):"},{"line_number":316,"context_line":"        self._set_config(pci_devs\u003dNone)"},{"line_number":317,"context_line":"        self.driver.initialize()"},{"line_number":318,"context_line":"        self.assertEqual(None, self.driver.pci_vendor_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_d27331b3","line":315,"updated":"2016-08-13 09:17:18.000000000","message":"How is it different from the test in line 290+.","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"b5eb3120d77e2dc2df27a58364abb8e2b14ba1b5","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    def test_initialize_pci_devs_none(self):"},{"line_number":316,"context_line":"        self._set_config(pci_devs\u003dNone)"},{"line_number":317,"context_line":"        self.driver.initialize()"},{"line_number":318,"context_line":"        self.assertEqual(None, self.driver.pci_vendor_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ac969e8_924b7959","line":318,"range":{"start_line":318,"start_character":13,"end_line":318,"end_character":24},"updated":"2016-08-13 09:17:18.000000000","message":"assertIsNone","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"9aec6643f0de4ca85d44994eeba26b8a5155458a","unresolved":false,"context_lines":[{"line_number":315,"context_line":"    def test_initialize_pci_devs_none(self):"},{"line_number":316,"context_line":"        self._set_config(pci_devs\u003dNone)"},{"line_number":317,"context_line":"        self.driver.initialize()"},{"line_number":318,"context_line":"        self.assertEqual(None, self.driver.pci_vendor_info)"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_d3485e8a","line":318,"range":{"start_line":318,"start_character":13,"end_line":318,"end_character":24},"in_reply_to":"7ac969e8_924b7959","updated":"2016-08-14 06:59:37.000000000","message":"Done","commit_id":"89c069a9021f023d4572be095b302ccdb32bb8bf"}],"releasenotes/notes/deprecate-supported_pci_vendor_devs-12279b70a1f1fe8e.yaml":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1e707da93caa0f11d65104109098c7920dea2690","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027supported_pci_vendor_devs\u0027 option is deprecated in Newton and will "},{"line_number":4,"context_line":"    be removed in Ocata. The validation of supported pci vendors is done in "},{"line_number":5,"context_line":"    nova-scheduler through the pci_passthrough_whitelist option when it "},{"line_number":6,"context_line":"    selects a suitable hypervisor, hence the option is considered redundant."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_faff0332","line":3,"updated":"2016-08-15 16:17:41.000000000","message":"can you please remove the white space","commit_id":"e87b4fe78a0bff71da5789677b0f1ea95074bc1c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"24c9e17bf2a5d87d506fded192858e624cfea91c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027supported_pci_vendor_devs\u0027 option is deprecated in Newton and will "},{"line_number":4,"context_line":"    be removed in Ocata. The validation of supported pci vendors is done in "},{"line_number":5,"context_line":"    nova-scheduler through the pci_passthrough_whitelist option when it "},{"line_number":6,"context_line":"    selects a suitable hypervisor, hence the option is considered redundant."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_a9d7f2eb","line":3,"in_reply_to":"3ac371cc_faff0332","updated":"2016-08-16 05:08:05.000000000","message":"Done","commit_id":"e87b4fe78a0bff71da5789677b0f1ea95074bc1c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1e707da93caa0f11d65104109098c7920dea2690","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027supported_pci_vendor_devs\u0027 option is deprecated in Newton and will "},{"line_number":4,"context_line":"    be removed in Ocata. The validation of supported pci vendors is done in "},{"line_number":5,"context_line":"    nova-scheduler through the pci_passthrough_whitelist option when it "},{"line_number":6,"context_line":"    selects a suitable hypervisor, hence the option is considered redundant."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_7a9af315","line":4,"updated":"2016-08-15 16:17:41.000000000","message":"ditto","commit_id":"e87b4fe78a0bff71da5789677b0f1ea95074bc1c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"24c9e17bf2a5d87d506fded192858e624cfea91c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027supported_pci_vendor_devs\u0027 option is deprecated in Newton and will "},{"line_number":4,"context_line":"    be removed in Ocata. The validation of supported pci vendors is done in "},{"line_number":5,"context_line":"    nova-scheduler through the pci_passthrough_whitelist option when it "},{"line_number":6,"context_line":"    selects a suitable hypervisor, hence the option is considered redundant."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_09056679","line":4,"in_reply_to":"3ac371cc_7a9af315","updated":"2016-08-16 05:08:05.000000000","message":"Done","commit_id":"e87b4fe78a0bff71da5789677b0f1ea95074bc1c"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"1e707da93caa0f11d65104109098c7920dea2690","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027supported_pci_vendor_devs\u0027 option is deprecated in Newton and will "},{"line_number":4,"context_line":"    be removed in Ocata. The validation of supported pci vendors is done in "},{"line_number":5,"context_line":"    nova-scheduler through the pci_passthrough_whitelist option when it "},{"line_number":6,"context_line":"    selects a suitable hypervisor, hence the option is considered redundant."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_1a8adfbf","line":5,"updated":"2016-08-15 16:17:41.000000000","message":"ditto","commit_id":"e87b4fe78a0bff71da5789677b0f1ea95074bc1c"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"24c9e17bf2a5d87d506fded192858e624cfea91c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"deprecations:"},{"line_number":3,"context_line":"  - The \u0027supported_pci_vendor_devs\u0027 option is deprecated in Newton and will "},{"line_number":4,"context_line":"    be removed in Ocata. The validation of supported pci vendors is done in "},{"line_number":5,"context_line":"    nova-scheduler through the pci_passthrough_whitelist option when it "},{"line_number":6,"context_line":"    selects a suitable hypervisor, hence the option is considered redundant."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3ac371cc_e9072a7f","line":5,"in_reply_to":"3ac371cc_1a8adfbf","updated":"2016-08-16 05:08:05.000000000","message":"Done","commit_id":"e87b4fe78a0bff71da5789677b0f1ea95074bc1c"}]}