)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"dbd2c942873e42a62f4cde1b3b75cb05a8bb6c54","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 00:19:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relax bound constraint for trunk parent ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch revisits the is_bound() condition for ports that"},{"line_number":10,"context_line":"are about to be used as parent in a trunk. The existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_bf6b101d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"updated":"2016-08-11 18:14:50.000000000","message":"nit: I would say this patch \"tightens\" the bound constraint rather than \"relaxes\" it, but I wouldn\u0027t hold it up over that.","commit_id":"9d287ec16c8e9dd3bdca88976f5e2007dead5edb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"50d2ca6babcee6eff68a84ff843931072bec62fb","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 00:19:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relax bound constraint for trunk parent ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch revisits the is_bound() condition for ports that"},{"line_number":10,"context_line":"are about to be used as parent in a trunk. The existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_5dadb2e7","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"9ad45d7e_3ad0c4c8","updated":"2016-08-11 22:17:14.000000000","message":"brainfart: I was thinking of patch fbd87f0a  when I replied here. \n\nBut no, it\u0027s the opposite, because the way is_bound() is used is to constrain what operations one can do.","commit_id":"9d287ec16c8e9dd3bdca88976f5e2007dead5edb"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"5b3da590a7f5ec690c8c8ed6801f937984c4fad2","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 00:19:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relax bound constraint for trunk parent ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch revisits the is_bound() condition for ports that"},{"line_number":10,"context_line":"are about to be used as parent in a trunk. The existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_7d70760b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"9ad45d7e_5dadb2e7","updated":"2016-08-11 22:28:17.000000000","message":"Oh, right:\n\nconstraining the \"is bound\" condition \u003d\u003e less trunks are considered bound \u003d\u003e more freedom for trunks \u003d\u003e relaxed.\n\nThis is confusing stuff :) . I wasn\u0027t thinking only in terms of what this patch changed.","commit_id":"9d287ec16c8e9dd3bdca88976f5e2007dead5edb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"833316687c1ac479eb2833bee7437785845130fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 00:19:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relax bound constraint for trunk parent ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch revisits the is_bound() condition for ports that"},{"line_number":10,"context_line":"are about to be used as parent in a trunk. The existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_f852b411","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"9ad45d7e_7d70760b","updated":"2016-08-11 22:34:31.000000000","message":"It\u0027s my bad, I could have phrased it differently, I was thinking from the perspective of the end user.","commit_id":"9d287ec16c8e9dd3bdca88976f5e2007dead5edb"},{"author":{"_account_id":16800,"name":"Rawlin Peters","email":"rawlin.peters@hpe.com","username":"rawlin"},"change_message_id":"6cb87492fdd36ede0c43aab8323bf00d179e75c1","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 00:19:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relax bound constraint for trunk parent ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch revisits the is_bound() condition for ports that"},{"line_number":10,"context_line":"are about to be used as parent in a trunk. The existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_3ad0c4c8","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"9ad45d7e_a729419d","updated":"2016-08-11 22:12:53.000000000","message":"Originally a port would be considered bound if it had a host_id OR its device owner started with \u0027compute\u0027.\n\nNow it\u0027s only considered bound if it has a host_id. By eliminating the OR condition, we\u0027re allowing the \"is bound\" check to succeed in fewer cases. Fewer cases \u003d\u003e more constrained. Right? If they had been ANDed originally, then I\u0027d say we\u0027re relaxing it.","commit_id":"9d287ec16c8e9dd3bdca88976f5e2007dead5edb"},{"author":{"_account_id":748,"name":"Armando Migliaccio","email":"armamig@gmail.com","username":"armando-migliaccio"},"change_message_id":"3243fe7f4e32394e34996d06eb870761af40239e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Armando Migliaccio \u003carmamig@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-08-11 00:19:59 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Relax bound constraint for trunk parent ports"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch revisits the is_bound() condition for ports that"},{"line_number":10,"context_line":"are about to be used as parent in a trunk. The existing"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"9ad45d7e_a729419d","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":5},"in_reply_to":"9ad45d7e_bf6b101d","updated":"2016-08-11 21:50:40.000000000","message":"What? We\u0027re relaxing it because we\u0027re allowing the operation to succeed in some cases rather than fail all the time.\n\n/me confused.","commit_id":"9d287ec16c8e9dd3bdca88976f5e2007dead5edb"}],"neutron/services/trunk/rules.py":[{"author":{"_account_id":4187,"name":"Ryan Tidwell","email":"rtidwell@suse.com","username":"ryan-tidwell"},"change_message_id":"07901065fba550820a48d2a3719ead019c84d504","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from neutron_lib.api import converters"},{"line_number":16,"context_line":"from neutron_lib.api import validators"},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from neutron_lib import exceptions as n_exc"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron._i18n import _"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_2c1649a7","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":44},"updated":"2016-08-10 05:57:37.000000000","message":"Can remove this line.","commit_id":"963924cc2e3baa8dbd7cc7fe9e56889829305bda"}]}