)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bac40813450924c3b729cdb2c3c98fc06d20a34","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[WIP] Add api tempest tests for segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds api tests for new segments functionality."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I413b2d0818a85cf36989fd558d3ea1bfce831f43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_a26054d0","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":57},"updated":"2016-08-10 21:14:53.000000000","message":"Tempest API tests for the segments service plug-in","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bac40813450924c3b729cdb2c3c98fc06d20a34","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[WIP] Add api tempest tests for segments"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch adds api tests for new segments functionality."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I413b2d0818a85cf36989fd558d3ea1bfce831f43"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_62981cc1","line":10,"updated":"2016-08-10 21:14:53.000000000","message":"Please add the following line:\n\nPartially-Implements: blueprint routed-networks\n\nPlease also note that I changed to Gerrit topic. We want to keep it that way","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"}],"neutron/tests/tempest/api/admin/test_segments.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bac40813450924c3b729cdb2c3c98fc06d20a34","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_segment_create(self):"},{"line_number":22,"context_line":"        net \u003d self.create_network()"},{"line_number":23,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_42123858","line":20,"updated":"2016-08-10 21:14:53.000000000","message":"Add this decorator to your test cases:\n\n@test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")\n\nThat way it won\u0027t fail because the segments extension is not enabled.\n\nWe need to enable it in the gate, though. I\u0027ll find out how","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"443779015e777c2aeeddd5762bdf07c81b0ceb5a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_segment_create(self):"},{"line_number":22,"context_line":"        net \u003d self.create_network()"},{"line_number":23,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8de0e197","line":20,"in_reply_to":"9ad45d7e_42123858","updated":"2016-08-10 21:50:50.000000000","message":"Only add this decorator after you have convinced yourself the extension is not enabled in Jenkins with the lines I suggested in my comment to L21.","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bac40813450924c3b729cdb2c3c98fc06d20a34","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_segment_create(self):"},{"line_number":22,"context_line":"        net \u003d self.create_network()"},{"line_number":23,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":24,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_c79bda16","line":21,"updated":"2016-08-10 21:14:53.000000000","message":"I think the problem is that the segments extensions is not enabled in the gate. Look at http://logs.openstack.org/15/353115/1/check/gate-neutron-dsvm-api/ac89b25/console.html#_2016-08-09_22_50_20_350214\n\nYou can confirm this by adding the following lines here:\n\nextensions \u003d self.admin_client.list_extensions()\nself.assertIn(\u0027Segment\u0027,\n              [e[\u0027name\u0027] for e in extensions[\u0027extensions\u0027]])","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"443779015e777c2aeeddd5762bdf07c81b0ceb5a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"    def test_segment_create(self):"},{"line_number":22,"context_line":"        net \u003d self.create_network()"},{"line_number":23,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":24,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2de615b0","line":21,"in_reply_to":"9ad45d7e_c79bda16","updated":"2016-08-10 21:50:50.000000000","message":"Remove these lines after you have verified the extension is not enabled in Jenkins","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bac40813450924c3b729cdb2c3c98fc06d20a34","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":24,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"},{"line_number":25,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":26,"context_line":"        segments \u003d [segment[\u0027segment\u0027][\u0027id\u0027] for s in body[\u0027segments\u0027]]"},{"line_number":27,"context_line":"        self.assertIn(segment[\u0027segment\u0027][\u0027id\u0027], segments)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_2742b668","line":26,"updated":"2016-08-10 21:14:53.000000000","message":"I think this line has to be:\n\nsegment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"8bac40813450924c3b729cdb2c3c98fc06d20a34","unresolved":false,"context_lines":[{"line_number":24,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"},{"line_number":25,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":26,"context_line":"        segments \u003d [segment[\u0027segment\u0027][\u0027id\u0027] for s in body[\u0027segments\u0027]]"},{"line_number":27,"context_line":"        self.assertIn(segment[\u0027segment\u0027][\u0027id\u0027], segments)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_8753a238","line":27,"range":{"start_line":27,"start_character":48,"end_line":27,"end_character":56},"updated":"2016-08-10 21:14:53.000000000","message":"segment_ids. It is clearer as to what the list contains","commit_id":"bad8986b8f15a52219d7245c1292bb7a7085393b"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d93d14bde237a730a7069687ad3c04fce4b3df10","unresolved":false,"context_lines":[{"line_number":21,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":24,"context_line":"    def test_segment_create(self):"},{"line_number":25,"context_line":"        net \u003d self.create_network()"},{"line_number":26,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":27,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_2ceb40b2","line":24,"updated":"2016-08-12 16:34:23.000000000","message":"Don\u0027t forget the @test.idempotent_id decorator. That is what got you in trouble with the pep8 checks :-)","commit_id":"bd72d4304f25440afa914ccaa9b48714f70bfd66"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fbc742dfab777ff6a4d55ef793d0b0937b6ade46","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":25,"context_line":"    def test_segment_create_delete(self):"},{"line_number":26,"context_line":"        net \u003d self.create_network()"},{"line_number":27,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":28,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"},{"line_number":29,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":30,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_08bd2302","line":27,"updated":"2016-08-22 20:13:22.000000000","message":"Let\u0027s implement this with network_type vlan, specifying a physical net and a segmentation_id. That is more realistic from the point of view of routed networks. The same aaplies across all the test cases.\n\nLet\u0027s also add asserts checking that these attributes are set properly for the created segments","commit_id":"9203bcdf9a6b5b769ea62e996f1a9ce774472168"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"374007bb3c42877c1ccd33635ac8a515cdf3ef5e","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":25,"context_line":"    def test_segment_create_delete(self):"},{"line_number":26,"context_line":"        net \u003d self.create_network()"},{"line_number":27,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":28,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"},{"line_number":29,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":30,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1ac06dbe_277f20e1","line":27,"in_reply_to":"1ac06dbe_08bd2302","updated":"2016-08-23 19:46:52.000000000","message":"Done","commit_id":"9203bcdf9a6b5b769ea62e996f1a9ce774472168"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"07770cbc0f23f92d67e61828b42b5d5f699311d5","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":27,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":28,"context_line":"    def test_segment_create_delete(self):"},{"line_number":29,"context_line":"        net \u003d self.create_network()"},{"line_number":30,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":31,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":32,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3f4b402d","line":29,"updated":"2016-08-25 23:32:36.000000000","message":"Please look at the way Bin is creating his routed networks here: https://review.openstack.org/#/c/347188/12/neutron/tests/tempest/scenario/test_routed_networks.py@104. That\u0027s the way to do it\n\nI strongly advice to run this in the vagrant environment and refer to \u0027physnet1\u0027","commit_id":"5af6aaa08a5383063cba651c2fe7acc6f2694cb1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"07770cbc0f23f92d67e61828b42b5d5f699311d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":32,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":33,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":34,"context_line":"        created_segment \u003d self.admin_client.show_segment("},{"line_number":35,"context_line":"                segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":36,"context_line":"        self.assertEqual(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":37,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_972c36ad","line":34,"range":{"start_line":34,"start_character":8,"end_line":34,"end_character":23},"updated":"2016-08-25 23:32:36.000000000","message":"This is confusing to the reader. Why don\u0027t we call this one \u0027retrieved_segment\u0027? You can use \u0027created_segment\u0027 for L30","commit_id":"5af6aaa08a5383063cba651c2fe7acc6f2694cb1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"07770cbc0f23f92d67e61828b42b5d5f699311d5","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":48,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":49,"context_line":"    def test_update_segment(self):"},{"line_number":50,"context_line":"        net \u003d self.create_network()"},{"line_number":51,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":52,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":53,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_3f72607d","line":50,"updated":"2016-08-25 23:32:36.000000000","message":"Please see my comment to line 29","commit_id":"5af6aaa08a5383063cba651c2fe7acc6f2694cb1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"07770cbc0f23f92d67e61828b42b5d5f699311d5","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":61,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":62,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":63,"context_line":"        net \u003d self.create_network()"},{"line_number":64,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":65,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":66,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_7f6ce89c","line":63,"updated":"2016-08-25 23:32:36.000000000","message":"Please see my comment to line 29","commit_id":"5af6aaa08a5383063cba651c2fe7acc6f2694cb1"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    SEGMENTATION_ID \u003d 2020"},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_59ad8330","line":23,"updated":"2016-09-02 23:56:32.000000000","message":"Based on my comments below, I think, we will not need this line","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"    SEGMENTATION_ID \u003d 2020"},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_2d2fe188","line":23,"in_reply_to":"9a89bdaa_59ad8330","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    SEGMENTATION_ID \u003d 2020"},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": self.SEGMENTATION_ID,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_19bbfb73","line":26,"updated":"2016-09-02 23:56:32.000000000","message":"Based on my comments to lines 27 and 30, I suggest to change this method to: https://gist.github.com/miguellavalle/91d92c2fdcaee1a0ad041fa759f3bfed","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":23,"context_line":"    SEGMENTATION_ID \u003d 2020"},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": self.SEGMENTATION_ID,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_4d50a50b","line":26,"in_reply_to":"9a89bdaa_19bbfb73","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": self.SEGMENTATION_ID,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":30,"context_line":"        return self.admin_client.create_network(shared\u003dTrue, segments\u003dsegments,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_59ff4334","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":69},"updated":"2016-09-02 23:56:32.000000000","message":"Your 3 test cases call this method to create a network. Please keep in mind that the test runner attempts to run your test cases in parallel. The fact that you are using the same segmentation id will lead to random failures in your tests cases, when one of them tries to create the network with a segmentation id that is being used by another test case. So I suggest adding a \u0027segmentation_id\u0027 argument to this method, so each test case can create its network with a different segmentation_id.","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": self.SEGMENTATION_ID,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":30,"context_line":"        return self.admin_client.create_network(shared\u003dTrue, segments\u003dsegments,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_6d53a917","line":27,"range":{"start_line":27,"start_character":49,"end_line":27,"end_character":69},"in_reply_to":"9a89bdaa_59ff4334","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": self.SEGMENTATION_ID,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":30,"context_line":"        return self.admin_client.create_network(shared\u003dTrue, segments\u003dsegments,"},{"line_number":31,"context_line":"                                                **{\"router:external\": \"False\"})"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_d964334b","line":30,"updated":"2016-09-02 23:56:32.000000000","message":"You need to clean-up. You are creating a shared network without adding it to the list of networks that will be cleaned up at the end of the test. Please look at https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L220. As you can see, create_shared_network, after creating the network, adds it to the cls.shared_networks list. At the end of the test, resource_cleanup (https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/base.py#L114) will be called and it will attempt to delete, among other things, all the networks in cls.shared_networks.","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":34,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":35,"context_line":"    def test_segment_create_delete(self):"},{"line_number":36,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":37,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":38,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":39,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_b9620f15","line":36,"updated":"2016-09-02 23:56:32.000000000","message":"net \u003d self._create_routed_network(2016)","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":33,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":34,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":35,"context_line":"    def test_segment_create_delete(self):"},{"line_number":36,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":37,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":38,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":39,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_2d46014f","line":36,"in_reply_to":"9a89bdaa_b9620f15","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":37,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":38,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":39,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":40,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":41,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":42,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_d967d323","line":39,"range":{"start_line":39,"start_character":32,"end_line":39,"end_character":52},"updated":"2016-09-02 23:56:32.000000000","message":"change to 2017","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":37,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":38,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":39,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":40,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":41,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":42,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_4d77c59f","line":39,"range":{"start_line":39,"start_character":32,"end_line":39,"end_character":52},"in_reply_to":"9a89bdaa_d967d323","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":43,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":44,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(self.SEGMENTATION_ID,"},{"line_number":46,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(self.PHYSICAL_NETWORK,"},{"line_number":48,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_5974a3ce","line":45,"range":{"start_line":45,"start_character":25,"end_line":45,"end_character":45},"updated":"2016-09-02 23:56:32.000000000","message":"2017","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":42,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":43,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":44,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":45,"context_line":"        self.assertEqual(self.SEGMENTATION_ID,"},{"line_number":46,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(self.PHYSICAL_NETWORK,"},{"line_number":48,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_6d7ac989","line":45,"range":{"start_line":45,"start_character":25,"end_line":45,"end_character":45},"in_reply_to":"9a89bdaa_5974a3ce","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":55,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":56,"context_line":"    def test_update_segment(self):"},{"line_number":57,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":58,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":59,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":60,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_b9492f91","line":57,"updated":"2016-09-02 23:56:32.000000000","message":"net \u003d self._create_routed_network(2018)","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":55,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":56,"context_line":"    def test_update_segment(self):"},{"line_number":57,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":58,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":59,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":60,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_8d6d4dce","line":57,"in_reply_to":"9a89bdaa_b9492f91","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":58,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":59,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":60,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":61,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":62,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":63,"context_line":"                name\u003d\u0027test_segment\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_19493b8c","line":60,"range":{"start_line":60,"start_character":32,"end_line":60,"end_character":52},"updated":"2016-09-02 23:56:32.000000000","message":"Change to 2019","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":58,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":59,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":60,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":61,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":62,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":63,"context_line":"                name\u003d\u0027test_segment\u0027)"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_cd6bd5b5","line":60,"range":{"start_line":60,"start_character":32,"end_line":60,"end_character":52},"in_reply_to":"9a89bdaa_19493b8c","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":68,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":69,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":70,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":71,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":72,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":73,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_395eff45","line":70,"updated":"2016-09-02 23:56:32.000000000","message":"net \u003d self._create_routed_network(2020)","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":68,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":69,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":70,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":71,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":72,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":73,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_ed66d9eb","line":70,"in_reply_to":"9a89bdaa_395eff45","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0b89abcb51c7995ee202f1dc45d426f7c692a708","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":71,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":72,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":73,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":74,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":75,"context_line":"        subnet \u003d self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":76,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_79588757","line":73,"range":{"start_line":73,"start_character":32,"end_line":73,"end_character":52},"updated":"2016-09-02 23:56:32.000000000","message":"Change to 2021","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"e84f91ea1f3f343e1e66c4c6b02dfe915daaa6dc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        net \u003d self._create_routed_network()"},{"line_number":71,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":72,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":73,"context_line":"                segmentation_id\u003dself.SEGMENTATION_ID,"},{"line_number":74,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":75,"context_line":"        subnet \u003d self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":76,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"9a89bdaa_0d621dd8","line":73,"range":{"start_line":73,"start_character":32,"end_line":73,"end_character":52},"in_reply_to":"9a89bdaa_79588757","updated":"2016-09-07 21:12:48.000000000","message":"Done","commit_id":"92cecd9328fbadd8f71c4b610a665a47a63ed31f"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"51ae95866e5b892b62015b8663b5c416b12b8ff9","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_a92517af","line":22,"updated":"2016-09-10 16:49:05.000000000","message":"I think it makes sense to add a test that asserts the L2_ADJACENCY attribute.","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"3c39d4d4fcb57063570e6d59c45b30c1ebd3c498","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_b196234a","line":22,"in_reply_to":"9a89bdaa_a92517af","updated":"2016-09-12 17:03:19.000000000","message":"@James,\n\nIt definitely makes sense to add a test case for the \u0027l2_adjacency\u0027 attribute. Please look here: http://paste.openstack.org/show/572391/. Note that originally, the network (without subnets) has l2_adjacency \u003d\u003d True, because up to that point, as far as Neutron is concerned, it is a single broadcast domain. But then when I assign a subnet to the network\u0027s segment, l2_adjacency \u003d\u003d  False, because now each segment is a separate broadcast domain","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_f225905c","line":22,"in_reply_to":"9a89bdaa_a92517af","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_122bdc31","line":22,"in_reply_to":"9a89bdaa_b196234a","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d77a47b36d28f3e9bcb9edc919c2a265c51072e0","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_c23bd7cf","line":22,"in_reply_to":"9a89bdaa_b196234a","updated":"2016-09-12 18:01:34.000000000","message":"We can even have one more test case: once the network becomes routed (because a subnet has been assigned to one of its segments) we can test that you cannot assign a subnet at the network level. Here, I try to do that to the network from the previous example:\n\n$ neutron subnet-create --ip_version 4 --name multinet-segment1-subnet-2 0c9d1c2d-ba8d-4661-8b08-b4db595ade6a 10.2.1.0/24\nAll of the subnets on network \u00270c9d1c2d-ba8d-4661-8b08-b4db595ade6a\u0027 must either all be associated with segments or all not associated with any segment.\nNeutron server returns request_ids: [\u0027req-550d27e7-d5e7-444b-ba86-544b7215b721\u0027]","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_3220d849","line":22,"in_reply_to":"9a89bdaa_c23bd7cf","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"51ae95866e5b892b62015b8663b5c416b12b8ff9","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self, segmentation_id):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": segmentation_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_a9fef702","line":24,"updated":"2016-09-10 16:49:05.000000000","message":"This test may run against a cloud that is actually using this physnet. Other tests may run in parallel and allocate VLANs. Since VLAN IDs are enforced to be unique within a physnet, the VLAN IDs that you use in the tests may already be used.\n\nYou can generate a random physnet name to get around this in each test.","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self, segmentation_id):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": segmentation_id,"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a8ec9b2_729fc05f","line":24,"in_reply_to":"9a89bdaa_a9fef702","updated":"2016-09-13 18:51:50.000000000","message":"Attempting this in my environment causes errors about unknown physical networks. Perhaps it\u0027s just my environment? I\u0027ve left the code I tried in the patchset, so you can see if perhaps I made a mistake somewhere. I also tried \u0027physnet\u0027 with a random single-digit number appended, same errors.","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"51ae95866e5b892b62015b8663b5c416b12b8ff9","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self, segmentation_id):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": segmentation_id,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_4512b163","line":26,"updated":"2016-09-10 16:49:05.000000000","message":"The network isn\u0027t actually a routed network when it is created, so it\u0027s a bit confusing. I\u0027d advise changing the name to perhaps create_provider_network.","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"    PHYSICAL_NETWORK \u003d \u0027physnet1\u0027"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"    def _create_routed_network(self, segmentation_id):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:segmentation_id\": segmentation_id,"},{"line_number":28,"context_line":"                     \"provider:physical_network\": self.PHYSICAL_NETWORK,"},{"line_number":29,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_9214ca44","line":26,"in_reply_to":"9a89bdaa_4512b163","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0a902fc3addf786394a673541bf3dbca7aafcca4","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":63,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":64,"context_line":"                segmentation_id\u003dsegment_segmentation_id,"},{"line_number":65,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":66,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_668988ca","line":65,"updated":"2016-09-09 23:41:32.000000000","message":"How about adding these two lines:\n\nsegment_name \u003d \u0027test_segment\u0027\nsegment_description \u003d \u0027test segment description\u0027\n\nThese variables can be used in the segment update call and the assertions. Please see my comments below","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":63,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":64,"context_line":"                segmentation_id\u003dsegment_segmentation_id,"},{"line_number":65,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":66,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_b211ce54","line":65,"in_reply_to":"9a89bdaa_668988ca","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0a902fc3addf786394a673541bf3dbca7aafcca4","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                segmentation_id\u003dsegment_segmentation_id,"},{"line_number":65,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":66,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027test_segment\u0027, segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_a6e550a9","line":67,"updated":"2016-09-09 23:41:32.000000000","message":"Let\u0027s also update the segments description. So this line would be:\n\nname\u003dsegment_name, description\u003dsegment_description)\n\nThis way we test the 2 attributes update-able in segments","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                segmentation_id\u003dsegment_segmentation_id,"},{"line_number":65,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":66,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027test_segment\u0027, segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_d21ad26e","line":67,"in_reply_to":"9a89bdaa_a6e550a9","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0a902fc3addf786394a673541bf3dbca7aafcca4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027test_segment\u0027, segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":72,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_06bfdc60","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":39},"updated":"2016-09-09 23:41:32.000000000","message":"s/\u0027test_segment\u0027/segment_name","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027test_segment\u0027, segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":72,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_f217d642","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":39},"in_reply_to":"9a89bdaa_06bfdc60","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0a902fc3addf786394a673541bf3dbca7aafcca4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027test_segment\u0027, segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":72,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":73,"context_line":"    def test_subnet_with_segment(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_e662f815","line":70,"updated":"2016-09-09 23:41:32.000000000","message":"Add another assertion:\n\nself.assertEqual(segment_description,\n                 segment[\u0027segment\u0027][\u0027description\u0027])","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":67,"context_line":"                name\u003d\u0027test_segment\u0027)"},{"line_number":68,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(\u0027test_segment\u0027, segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":72,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":73,"context_line":"    def test_subnet_with_segment(self):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_1227dab6","line":70,"in_reply_to":"9a89bdaa_e662f815","updated":"2016-09-13 18:51:50.000000000","message":"Done","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0a902fc3addf786394a673541bf3dbca7aafcca4","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                segmentation_id\u003dsegment_segmentation_id,"},{"line_number":101,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":102,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"},{"line_number":103,"context_line":"        segment \u003d [s for s in net[\u0027segments\u0027]"},{"line_number":104,"context_line":"                if s[\u0027provider:segmentation_id\u0027] \u003d\u003d segment_segmentation_id][0]"},{"line_number":105,"context_line":"        self.assertEqual(\u0027vlan\u0027, segment[\u0027provider:network_type\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(self.PHYSICAL_NETWORK,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_2cf3df0b","line":103,"updated":"2016-09-09 23:41:32.000000000","message":"Instead of testing only one segment, how about checking both. Look at this alternative for this test case: https://gist.github.com/miguellavalle/0670f876abed267651d99e3cf7b79ec1","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"012eab46138e13c9db76f88c316c9f52a196e52b","unresolved":false,"context_lines":[{"line_number":100,"context_line":"                segmentation_id\u003dsegment_segmentation_id,"},{"line_number":101,"context_line":"                physical_network\u003dself.PHYSICAL_NETWORK)"},{"line_number":102,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"},{"line_number":103,"context_line":"        segment \u003d [s for s in net[\u0027segments\u0027]"},{"line_number":104,"context_line":"                if s[\u0027provider:segmentation_id\u0027] \u003d\u003d segment_segmentation_id][0]"},{"line_number":105,"context_line":"        self.assertEqual(\u0027vlan\u0027, segment[\u0027provider:network_type\u0027])"},{"line_number":106,"context_line":"        self.assertEqual(self.PHYSICAL_NETWORK,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a89bdaa_a33b42d0","line":103,"in_reply_to":"9a89bdaa_2cf3df0b","updated":"2016-09-13 18:51:50.000000000","message":"Done. The original variables are still there to keep things a little more explicit as to which ID is what.","commit_id":"347520c0f5814ae3f4a2e03c5721d251296df005"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8c35bcd58f02aa4b5a43d8a1718d5f0d94e8b36","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @test.idempotent_id(\u002748532981-8d6e-45f2-958f-3256354accc2\u0027)"},{"line_number":156,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":157,"context_line":"    def test_subnet_routed_network(self):"},{"line_number":158,"context_line":"        network_segmentation_id \u003d 2030"},{"line_number":159,"context_line":"        segment_segmentation_id \u003d 2031"},{"line_number":160,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_9e2c52ad","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":34},"updated":"2016-09-13 21:47:27.000000000","message":"I would name this test case: test_associate_subnet_to_routed_network","commit_id":"d7db62862c3a284c7a3d4bb5a00691e2c72476ac"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"76e273bec336128275ab92653137c25e158333bd","unresolved":false,"context_lines":[{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    @test.idempotent_id(\u002748532981-8d6e-45f2-958f-3256354accc2\u0027)"},{"line_number":156,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":157,"context_line":"    def test_subnet_routed_network(self):"},{"line_number":158,"context_line":"        network_segmentation_id \u003d 2030"},{"line_number":159,"context_line":"        segment_segmentation_id \u003d 2031"},{"line_number":160,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_fa7c5422","line":157,"range":{"start_line":157,"start_character":8,"end_line":157,"end_character":34},"in_reply_to":"7a8ec9b2_9e2c52ad","updated":"2016-09-14 14:38:31.000000000","message":"Done","commit_id":"d7db62862c3a284c7a3d4bb5a00691e2c72476ac"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8c35bcd58f02aa4b5a43d8a1718d5f0d94e8b36","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":165,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":166,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":167,"context_line":"        # Is there a cleaner way to do this?"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            self.create_subnet(net, client\u003dself.admin_client)"},{"line_number":170,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_397358b3","line":167,"updated":"2016-09-13 21:47:27.000000000","message":"Yes! You can use self.assertRaises. Please look at this alternative implementation for this test case: https://gist.github.com/miguellavalle/591de5cafc4af5e1a1ed1609a5205b12","commit_id":"d7db62862c3a284c7a3d4bb5a00691e2c72476ac"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"76e273bec336128275ab92653137c25e158333bd","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":165,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":166,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":167,"context_line":"        # Is there a cleaner way to do this?"},{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            self.create_subnet(net, client\u003dself.admin_client)"},{"line_number":170,"context_line":"        except Exception as e:"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_7a8f6423","line":167,"in_reply_to":"7a8ec9b2_397358b3","updated":"2016-09-14 14:38:31.000000000","message":"Done. Thanks, this is much better!","commit_id":"d7db62862c3a284c7a3d4bb5a00691e2c72476ac"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d8c35bcd58f02aa4b5a43d8a1718d5f0d94e8b36","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            self.create_subnet(net, client\u003dself.admin_client)"},{"line_number":170,"context_line":"        except Exception as e:"},{"line_number":171,"context_line":"            self.assertEqual(\"All of the subnets on network \u0027\" + net[\u0027id\u0027] +"},{"line_number":172,"context_line":"                    \"\u0027 must either all be associated with segments or all \" +"},{"line_number":173,"context_line":"                    \"not associated with any segment.\", e.resp_body[\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_d94c3479","line":171,"range":{"start_line":171,"start_character":29,"end_line":171,"end_character":76},"updated":"2016-09-13 21:47:27.000000000","message":"To create this type of string it is better to use the % operator. See the alternative implementation gist for this test case","commit_id":"d7db62862c3a284c7a3d4bb5a00691e2c72476ac"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"76e273bec336128275ab92653137c25e158333bd","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        try:"},{"line_number":169,"context_line":"            self.create_subnet(net, client\u003dself.admin_client)"},{"line_number":170,"context_line":"        except Exception as e:"},{"line_number":171,"context_line":"            self.assertEqual(\"All of the subnets on network \u0027\" + net[\u0027id\u0027] +"},{"line_number":172,"context_line":"                    \"\u0027 must either all be associated with segments or all \" +"},{"line_number":173,"context_line":"                    \"not associated with any segment.\", e.resp_body[\u0027message\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_ba99ec70","line":171,"range":{"start_line":171,"start_character":29,"end_line":171,"end_character":76},"in_reply_to":"7a8ec9b2_d94c3479","updated":"2016-09-14 14:38:31.000000000","message":"Done","commit_id":"d7db62862c3a284c7a3d4bb5a00691e2c72476ac"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"37cc1d8f4f15952b46ed82e2dbb4900d30a34863","unresolved":false,"context_lines":[{"line_number":25,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def generate_physnet(self):"},{"line_number":28,"context_line":"        return \u0027physnet1\u0027"},{"line_number":29,"context_line":"        # The above is temporary until the randomly"},{"line_number":30,"context_line":"        # generated physical network below works"},{"line_number":31,"context_line":"        return \u0027\u0027.join(random.choice(string.ascii_letters) for i in range(16))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_67ab321e","line":28,"updated":"2016-09-14 20:56:56.000000000","message":"@Assaf,\n\nWe couldn\u0027t get this test script work with randomly generated physical net names. The physical net need to exist. So I think we need to create configuration parameters to let the deployer / user tailor the script to his / her environment:\n\n1) Should we add configuration parameters to tempest.conf?\n2) How do we do that?","commit_id":"0c7f1c4be774477b450b563033f533d840f7da09"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"37cc1d8f4f15952b46ed82e2dbb4900d30a34863","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertEqual(segment_segmentation_id,"},{"line_number":55,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":57,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"},{"line_number":58,"context_line":"        self.admin_client.delete_segment(created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":59,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":60,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_647890f3","line":57,"updated":"2016-09-14 20:56:56.000000000","message":"Since we are verifying segment attributes, we might as well verify them all:\n\nnetwork_id equal net[\u0027id\u0027]\nname is None (assertIsNone)\ndescription is None (assertIsNone)\nnetwork_type equal \u0027vlan\u0027","commit_id":"0c7f1c4be774477b450b563033f533d840f7da09"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"a372ddd0ce32121400333c0d47071dc1c075400f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        self.assertEqual(segment_segmentation_id,"},{"line_number":55,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":57,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"},{"line_number":58,"context_line":"        self.admin_client.delete_segment(created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":59,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":60,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"}],"source_content_type":"text/x-python","patch_set":14,"id":"5a8bc5a2_7684a4d3","line":57,"in_reply_to":"7a8ec9b2_647890f3","updated":"2016-09-23 22:27:17.000000000","message":"Done","commit_id":"0c7f1c4be774477b450b563033f533d840f7da09"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b1ce59efdb4f9c6c76b0696af405d87e66e553b8","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":180,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":183,"context_line":"    def test_ip_allocation(self):"},{"line_number":184,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":185,"context_line":"        segment_segmentation_id \u003d 2033"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_96ba106d","line":182,"updated":"2016-09-23 22:36:42.000000000","message":"I think we need a @test.idempotent_id decorator here, don\u0027t we?","commit_id":"d25646866b6e0453f06f3f2d5592e862bdc93d1d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"36e921c84872377e42f4b0cb8929c5a00ec3b802","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":180,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":183,"context_line":"    def test_ip_allocation(self):"},{"line_number":184,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":185,"context_line":"        segment_segmentation_id \u003d 2033"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_0494b340","line":182,"in_reply_to":"5a8bc5a2_13a5fba0","updated":"2016-09-26 21:52:04.000000000","message":"LOL","commit_id":"d25646866b6e0453f06f3f2d5592e862bdc93d1d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"51df38d1b8ed8265c432cca7b5c1ec38ec489f73","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":180,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":183,"context_line":"    def test_ip_allocation(self):"},{"line_number":184,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":185,"context_line":"        segment_segmentation_id \u003d 2033"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_fcf253d1","line":182,"in_reply_to":"5a8bc5a2_96ba106d","updated":"2016-09-24 00:29:02.000000000","message":"Yeah, it just failed pep8 because you don\u0027t have @test.idempotent_id(....","commit_id":"d25646866b6e0453f06f3f2d5592e862bdc93d1d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"253500027194551749dbbca93702ba59993b118b","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":180,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":183,"context_line":"    def test_ip_allocation(self):"},{"line_number":184,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":185,"context_line":"        segment_segmentation_id \u003d 2033"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_13a5fba0","line":182,"in_reply_to":"5a8bc5a2_fcf253d1","updated":"2016-09-26 13:59:35.000000000","message":"Fixed. I swear one of these days I\u0027ll remember to do that on the first patchset...","commit_id":"d25646866b6e0453f06f3f2d5592e862bdc93d1d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"51df38d1b8ed8265c432cca7b5c1ec38ec489f73","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        self.assertEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":196,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":197,"context_line":"        bound_port \u003d self.admin_client.update_port(port[\u0027id\u0027], **data)[\u0027port\u0027]"},{"line_number":198,"context_line":"        self.assertEqual(\"immediate\", bound_port[\u0027ip_allocation\u0027])"},{"line_number":199,"context_line":"        self.assertNotEmpty(bound_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_1c461fbf","line":198,"updated":"2016-09-24 00:29:02.000000000","message":"I ran the test in my routed network environment. This assertion is failing. The value it finds is \u0027deferred\u0027. Let\u0027s check with Carl if this is the expected behavior","commit_id":"d25646866b6e0453f06f3f2d5592e862bdc93d1d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"253500027194551749dbbca93702ba59993b118b","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        self.assertEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":196,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":197,"context_line":"        bound_port \u003d self.admin_client.update_port(port[\u0027id\u0027], **data)[\u0027port\u0027]"},{"line_number":198,"context_line":"        self.assertEqual(\"immediate\", bound_port[\u0027ip_allocation\u0027])"},{"line_number":199,"context_line":"        self.assertNotEmpty(bound_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":15,"id":"5a8bc5a2_cea766bb","line":198,"in_reply_to":"5a8bc5a2_1c461fbf","updated":"2016-09-26 13:59:35.000000000","message":"Interesting. I just double-checked, it runs successfully in my vagrant environment. But agreed, let\u0027s find out what it\u0027s supposed to do.","commit_id":"d25646866b6e0453f06f3f2d5592e862bdc93d1d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b8e82a313b8758edfcedfff846b0f4c6e6be950c","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":183,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":184,"context_line":"    def test_ip_allocation(self):"},{"line_number":185,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":186,"context_line":"        segment_segmentation_id \u003d 2033"},{"line_number":187,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_b2e78645","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":26},"updated":"2016-09-27 20:08:42.000000000","message":"Let\u0027s rename this test case test_ip_allocation_bind_port_on_update.","commit_id":"d8df5392834f96c15f073c3075ec79b57e17dfa5"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"aa71beb9f078759901e8c8f57c837b971829e5e2","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":183,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":184,"context_line":"    def test_ip_allocation(self):"},{"line_number":185,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":186,"context_line":"        segment_segmentation_id \u003d 2033"},{"line_number":187,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_5f3ba638","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":26},"in_reply_to":"5a8bc5a2_b2e78645","updated":"2016-09-27 21:42:44.000000000","message":"Done","commit_id":"d8df5392834f96c15f073c3075ec79b57e17dfa5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b8e82a313b8758edfcedfff846b0f4c6e6be950c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        self.assertEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":197,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":198,"context_line":"        bound_port \u003d self.admin_client.update_port(port[\u0027id\u0027], **data)[\u0027port\u0027]"},{"line_number":199,"context_line":"        self.assertEqual(\"immediate\", bound_port[\u0027ip_allocation\u0027])"},{"line_number":200,"context_line":"        self.assertNotEmpty(bound_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_72bdfe01","line":199,"range":{"start_line":199,"start_character":26,"end_line":199,"end_character":35},"updated":"2016-09-27 20:08:42.000000000","message":"This should be \"deferred\". The value of a port\u0027s ip_allocation is set when the port is created and won\u0027t change throughout the port\u0027s life","commit_id":"d8df5392834f96c15f073c3075ec79b57e17dfa5"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"aa71beb9f078759901e8c8f57c837b971829e5e2","unresolved":false,"context_lines":[{"line_number":196,"context_line":"        self.assertEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":197,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":198,"context_line":"        bound_port \u003d self.admin_client.update_port(port[\u0027id\u0027], **data)[\u0027port\u0027]"},{"line_number":199,"context_line":"        self.assertEqual(\"immediate\", bound_port[\u0027ip_allocation\u0027])"},{"line_number":200,"context_line":"        self.assertNotEmpty(bound_port[\u0027fixed_ips\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"5a8bc5a2_9f452eb5","line":199,"range":{"start_line":199,"start_character":26,"end_line":199,"end_character":35},"in_reply_to":"5a8bc5a2_72bdfe01","updated":"2016-09-27 21:42:44.000000000","message":"Done","commit_id":"d8df5392834f96c15f073c3075ec79b57e17dfa5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aad3154390a8517614fa79b6012c63dd4ea6f800","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib import exceptions"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentTest(BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_faec772b","line":22,"updated":"2016-09-28 03:19:32.000000000","message":"Please remember, we import modules, not objects:\n\nhttp://docs.openstack.org/developer/hacking/#imports","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"da3955a334171518744e9ddee38bc2ea3883d43f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"from tempest.lib import exceptions"},{"line_number":20,"context_line":"from tempest import test"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentTest(BaseAdminNetworkTest):"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a98d1f4_3e5765cf","line":22,"in_reply_to":"5a8bc5a2_faec772b","updated":"2016-09-29 20:21:29.000000000","message":"Done","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aad3154390a8517614fa79b6012c63dd4ea6f800","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def generate_physnet(self):"},{"line_number":28,"context_line":"        return \u0027physnet1\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_3af7bff6","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":38},"updated":"2016-09-28 03:19:32.000000000","message":"Please adjust this per comment to L22","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"da3955a334171518744e9ddee38bc2ea3883d43f","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from neutron.tests.tempest.api.base import BaseAdminNetworkTest"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentTest(BaseAdminNetworkTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def generate_physnet(self):"},{"line_number":28,"context_line":"        return \u0027physnet1\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"3a98d1f4_7e5f2de5","line":25,"range":{"start_line":25,"start_character":18,"end_line":25,"end_character":38},"in_reply_to":"5a8bc5a2_3af7bff6","updated":"2016-09-29 20:21:29.000000000","message":"Done","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aad3154390a8517614fa79b6012c63dd4ea6f800","unresolved":false,"context_lines":[{"line_number":179,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":180,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":183,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":184,"context_line":"    def test_ip_allocation_on_create(self):"},{"line_number":185,"context_line":"        network_segmentation_id \u003d 2032"}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_5adc8b74","line":182,"updated":"2016-09-28 03:19:32.000000000","message":"Yaay!","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"aad3154390a8517614fa79b6012c63dd4ea6f800","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":193,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":"        data \u003d {\u0027network_id\u0027: net[\u0027id\u0027], \u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":195,"context_line":"        port \u003d self.admin_client.create_port(**data)[\u0027port\u0027]"},{"line_number":196,"context_line":"        self.assertEqual(\"immediate\", port[\u0027ip_allocation\u0027])"},{"line_number":197,"context_line":"        self.assertNotEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5a8bc5a2_da9fbb63","line":195,"updated":"2016-09-28 03:19:32.000000000","message":"The problem with calling the client directly is that your port is not going to be deleted when the test finishes. As a consequence, even though all your test cases succeed, the script as a whole fails because cleanup fails when it tries to delete the network where this port lives, because it has still an active port. I suggest you use the create_port method you are calling in L211, after you modify it. Do something similar to what I did to create_network_keystone_v3 here: https://review.openstack.org/#/c/374413/2/neutron/tests/tempest/api/base.py. That will include creating a new list admin_ports in resource_setup and adding the deletion of ports in this list in resource_cleanup","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"da3955a334171518744e9ddee38bc2ea3883d43f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":193,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":194,"context_line":"        data \u003d {\u0027network_id\u0027: net[\u0027id\u0027], \u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":195,"context_line":"        port \u003d self.admin_client.create_port(**data)[\u0027port\u0027]"},{"line_number":196,"context_line":"        self.assertEqual(\"immediate\", port[\u0027ip_allocation\u0027])"},{"line_number":197,"context_line":"        self.assertNotEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":198,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"3a98d1f4_9e6239ac","line":195,"in_reply_to":"5a8bc5a2_da9fbb63","updated":"2016-09-29 20:21:29.000000000","message":"Done","commit_id":"1b4b28284423847c9bcea258a15fe2a51c829db3"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9f2008e7cd3f63c384b300a3089456978bf7a38c","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":183,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":184,"context_line":"    def test_ip_allocation_on_create(self):"},{"line_number":185,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":186,"context_line":"        segment_segmentation_id \u003d 2033"},{"line_number":187,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_ed9d515a","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":36},"updated":"2016-09-29 22:50:52.000000000","message":"Per comment to PS16, I think it is best to name this method test_ip_allocation_bind_port_on_create. It describes better what we are doing.","commit_id":"e15ce15b78c00373f226cc0ad9b0f9ebfc9b09b8"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"737a9436dfd57c2b3b4a4d1ba277419a27f22c76","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    @test.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":183,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":184,"context_line":"    def test_ip_allocation_on_create(self):"},{"line_number":185,"context_line":"        network_segmentation_id \u003d 2032"},{"line_number":186,"context_line":"        segment_segmentation_id \u003d 2033"},{"line_number":187,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_6d891375","line":184,"range":{"start_line":184,"start_character":8,"end_line":184,"end_character":36},"in_reply_to":"3a98d1f4_ed9d515a","updated":"2016-09-30 15:34:41.000000000","message":"Done","commit_id":"e15ce15b78c00373f226cc0ad9b0f9ebfc9b09b8"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"9f2008e7cd3f63c384b300a3089456978bf7a38c","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @test.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":200,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":201,"context_line":"    def test_ip_allocation_on_update(self):"},{"line_number":202,"context_line":"        network_segmentation_id \u003d 2034"},{"line_number":203,"context_line":"        segment_segmentation_id \u003d 2035"},{"line_number":204,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_4daf2581","line":201,"range":{"start_line":201,"start_character":9,"end_line":201,"end_character":36},"updated":"2016-09-29 22:50:52.000000000","message":"Per comment to PS16, I think it is best to name this method test_ip_allocation_bind_port_on_update. It describes better what we are doing.","commit_id":"e15ce15b78c00373f226cc0ad9b0f9ebfc9b09b8"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"737a9436dfd57c2b3b4a4d1ba277419a27f22c76","unresolved":false,"context_lines":[{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    @test.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":200,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":201,"context_line":"    def test_ip_allocation_on_update(self):"},{"line_number":202,"context_line":"        network_segmentation_id \u003d 2034"},{"line_number":203,"context_line":"        segment_segmentation_id \u003d 2035"},{"line_number":204,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_ed952387","line":201,"range":{"start_line":201,"start_character":9,"end_line":201,"end_character":36},"in_reply_to":"3a98d1f4_4daf2581","updated":"2016-09-30 15:34:41.000000000","message":"Done","commit_id":"e15ce15b78c00373f226cc0ad9b0f9ebfc9b09b8"},{"author":{"_account_id":8873,"name":"Assaf Muller","email":"amuller@redhat.com","username":"amuller"},"change_message_id":"1c776e9ac78a6737b03263890211d9a50e53242e","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class SegmentTest(base.BaseAdminNetworkTest):"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    def generate_physnet(self):"},{"line_number":28,"context_line":"        return \u0027physnet1\u0027"},{"line_number":29,"context_line":"        # The above is temporary until the randomly"},{"line_number":30,"context_line":"        # generated physical network below works"}],"source_content_type":"text/x-python","patch_set":19,"id":"3a98d1f4_d8d02322","line":27,"updated":"2016-09-30 15:56:19.000000000","message":"Keep in mind that we cannot merge this without finding a solution for this issue.\n\nThe status quo would be to auto-detect if the cloud has the capabilities to support this test and skip otherwise, or adding a flag in tempest.conf that would control if we run these tests or not, and we\u0027d make sure it\u0027s set to True at the upstream gate if possible. This will let downstream consumers of these tests conditionally skip if for example the CI is running with VXLAN and not VLAN networks.\n\nOne thought I had is to create a VLAN network without specifying the physical_network on test skip check. If it\u0027s successful, it means the cloud supports VLAN networks, then you grab the resulting physical_network and you use that throughout the tests. If the creation fails, you skip the tests.\n\nThe key take away is that you must remember that as opposed to unit tests, Tempest API tests are supposed to be able to run against any cloud, installed via any installer in whatever configuration. tempest.conf flags are supposed to indicate which tests to run according to the cloud capabilities.\n\nSince we cannot generate physical_network names we\u0027ll have to think of another segmentation solution - You cannot assume that specific VLAN tags (Like below, lines 43-44) are available. Other concurrent tests may be creating and deleting networks, momentarily grabbing random vlan IDs.","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d37563a469f583ca5f96f9df386aaa5721a4a69a","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # generated physical network below works"},{"line_number":31,"context_line":"        return \u0027\u0027.join(random.choice(string.ascii_letters) for i in range(16))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_provider_network(self, segmentation_id):"},{"line_number":34,"context_line":"        segments \u003d [{\"provider:segmentation_id\": segmentation_id,"},{"line_number":35,"context_line":"                     \"provider:physical_network\": self.generate_physnet(),"},{"line_number":36,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_acce3858","line":33,"updated":"2016-10-04 22:30:26.000000000","message":"@Assaf, @James,\n\nFollowing up on comment to L27 above, I modified this method to \u0027auto-detect\u0027 the availability of vlans in the environment under test. You can see the result here: https://gist.github.com/miguellavalle/5b1f663981dacb7e78fa78f3c013df2e","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"71cc19cb9cdc9643442bff2e5fc7c08e30936aae","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        # generated physical network below works"},{"line_number":31,"context_line":"        return \u0027\u0027.join(random.choice(string.ascii_letters) for i in range(16))"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    def _create_provider_network(self, segmentation_id):"},{"line_number":34,"context_line":"        segments \u003d [{\"provider:segmentation_id\": segmentation_id,"},{"line_number":35,"context_line":"                     \"provider:physical_network\": self.generate_physnet(),"},{"line_number":36,"context_line":"                     \"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_05eb4cb1","line":33,"in_reply_to":"1a95cdbc_acce3858","updated":"2016-10-05 21:49:05.000000000","message":"Done","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d37563a469f583ca5f96f9df386aaa5721a4a69a","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":42,"context_line":"    def test_segment_create_delete(self):"},{"line_number":43,"context_line":"        network_segmentation_id \u003d 2017"},{"line_number":44,"context_line":"        segment_segmentation_id \u003d 2018"},{"line_number":45,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_6c035074","line":42,"updated":"2016-10-04 22:30:26.000000000","message":"@Assaf, @James,\n\nI also modified this test case to not refer to any vlan tag number. Again, please see the result in https://gist.github.com/miguellavalle/5b1f663981dacb7e78fa78f3c013df2e","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"71cc19cb9cdc9643442bff2e5fc7c08e30936aae","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":42,"context_line":"    def test_segment_create_delete(self):"},{"line_number":43,"context_line":"        network_segmentation_id \u003d 2017"},{"line_number":44,"context_line":"        segment_segmentation_id \u003d 2018"},{"line_number":45,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_25d20801","line":42,"in_reply_to":"1a95cdbc_6c035074","updated":"2016-10-05 21:49:05.000000000","message":"Done","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d37563a469f583ca5f96f9df386aaa5721a4a69a","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":69,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":70,"context_line":"    def test_update_segment(self):"},{"line_number":71,"context_line":"        network_segmentation_id \u003d 2019"},{"line_number":72,"context_line":"        segment_segmentation_id \u003d 2022"},{"line_number":73,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_ecef60ae","line":70,"updated":"2016-10-04 22:30:26.000000000","message":"Same comment as for L42","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"71cc19cb9cdc9643442bff2e5fc7c08e30936aae","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":69,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":70,"context_line":"    def test_update_segment(self):"},{"line_number":71,"context_line":"        network_segmentation_id \u003d 2019"},{"line_number":72,"context_line":"        segment_segmentation_id \u003d 2022"},{"line_number":73,"context_line":"        net \u003d self._create_provider_network(network_segmentation_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_45cd545c","line":70,"in_reply_to":"1a95cdbc_ecef60ae","updated":"2016-10-05 21:49:05.000000000","message":"Done","commit_id":"6bcdaea980c26e6ac5084a26d6292a54d3d12913"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":37,"context_line":"    def test_segment_create_delete(self):"},{"line_number":38,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":39,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":40,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":41,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":42,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_64a2f24c","line":39,"updated":"2016-10-07 20:41:10.000000000","message":"Since we are repeating this check in several test cases, let\u0027s move it to _create_provider_network. First, the try block would look like this:\n\ntry:\n    net \u003d self.create_shared_network(network_name\u003dname,\n                                     segments\u003dsegments)\n\nAnd then, after L33, out of the try - except block:\n\n    self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":37,"context_line":"    def test_segment_create_delete(self):"},{"line_number":38,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":39,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":40,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":41,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":42,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_0a54d0fc","line":39,"in_reply_to":"1a95cdbc_64a2f24c","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":62,"context_line":"    def test_update_segment(self):"},{"line_number":63,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":64,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":65,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":66,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":67,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_e48e02cf","line":64,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":62,"context_line":"    def test_update_segment(self):"},{"line_number":63,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":64,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":65,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":66,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":67,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_2a550cf9","line":64,"in_reply_to":"1a95cdbc_e48e02cf","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":81,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":82,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":83,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":84,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":85,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":86,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_24c38aee","line":83,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":81,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":82,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":83,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":84,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":85,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":86,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_4a5a582b","line":83,"in_reply_to":"1a95cdbc_24c38aee","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":97,"context_line":"    def test_show_multi_segment_network(self):"},{"line_number":98,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":99,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":100,"context_line":"        self.assertEqual(\u0027vlan\u0027, net[\u0027provider:network_type\u0027])"},{"line_number":101,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":102,"context_line":"                net[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_64b91279","line":99,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":97,"context_line":"    def test_show_multi_segment_network(self):"},{"line_number":98,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":99,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":100,"context_line":"        self.assertEqual(\u0027vlan\u0027, net[\u0027provider:network_type\u0027])"},{"line_number":101,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":102,"context_line":"                net[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_8a40e035","line":99,"in_reply_to":"1a95cdbc_64b91279","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":99,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":100,"context_line":"        self.assertEqual(\u0027vlan\u0027, net[\u0027provider:network_type\u0027])"},{"line_number":101,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":102,"context_line":"                net[\u0027provider:physical_network\u0027])"},{"line_number":103,"context_line":"        self.assertNotEqual(0, net[\u0027provider:segmentation_id\u0027])"},{"line_number":104,"context_line":"        self.admin_client.create_segment("},{"line_number":105,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_764d403d","line":102,"range":{"start_line":101,"start_character":8,"end_line":102,"end_character":49},"updated":"2016-10-07 20:41:10.000000000","message":"What did you mean to check here? something \u003d\u003d something is always True","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":99,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":100,"context_line":"        self.assertEqual(\u0027vlan\u0027, net[\u0027provider:network_type\u0027])"},{"line_number":101,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":102,"context_line":"                net[\u0027provider:physical_network\u0027])"},{"line_number":103,"context_line":"        self.assertNotEqual(0, net[\u0027provider:segmentation_id\u0027])"},{"line_number":104,"context_line":"        self.admin_client.create_segment("},{"line_number":105,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_0af050fd","line":102,"range":{"start_line":101,"start_character":8,"end_line":102,"end_character":49},"in_reply_to":"1a95cdbc_764d403d","updated":"2016-10-07 21:11:00.000000000","message":"I honestly have no idea what I was trying to do here. Removed","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":117,"context_line":"    def test_create_segments_different_types(self):"},{"line_number":118,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":119,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":120,"context_line":"        self.admin_client.create_segment("},{"line_number":121,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"},{"line_number":122,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_a4af9a28","line":119,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":117,"context_line":"    def test_create_segments_different_types(self):"},{"line_number":118,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":119,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":120,"context_line":"        self.admin_client.create_segment("},{"line_number":121,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"},{"line_number":122,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_2af18c01","line":119,"in_reply_to":"1a95cdbc_a4af9a28","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":132,"context_line":"    def test_l2_adjacency(self):"},{"line_number":133,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":134,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":135,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":136,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":137,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_647032dd","line":134,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":131,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":132,"context_line":"    def test_l2_adjacency(self):"},{"line_number":133,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":134,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":135,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":136,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":137,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_4af6d8f9","line":134,"in_reply_to":"1a95cdbc_647032dd","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @test.idempotent_id(\u002748532981-8d6e-45f2-958f-3256354accc2\u0027)"},{"line_number":147,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":148,"context_line":"    def test_associate_subnet_to_routed_network(self):"},{"line_number":149,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":150,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":151,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_56e044fa","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":47},"updated":"2016-10-07 20:41:10.000000000","message":"Let\u0027s rename to test_associate_subnet_to_routed_network_fails. This way we convey we are expecting a negative result","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    @test.idempotent_id(\u002748532981-8d6e-45f2-958f-3256354accc2\u0027)"},{"line_number":147,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":148,"context_line":"    def test_associate_subnet_to_routed_network(self):"},{"line_number":149,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":150,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":151,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_6adf1469","line":148,"range":{"start_line":148,"start_character":8,"end_line":148,"end_character":47},"in_reply_to":"1a95cdbc_56e044fa","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":148,"context_line":"    def test_associate_subnet_to_routed_network(self):"},{"line_number":149,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":150,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":151,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":152,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":153,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_c47f46a9","line":150,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":147,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":148,"context_line":"    def test_associate_subnet_to_routed_network(self):"},{"line_number":149,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":150,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":151,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":152,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":153,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_8adc6074","line":150,"in_reply_to":"1a95cdbc_c47f46a9","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":158,"context_line":"        e \u003d self.assertRaises(exceptions.BadRequest, self.create_subnet, net,"},{"line_number":159,"context_line":"                              client\u003dself.admin_client)"},{"line_number":160,"context_line":"        expected_message \u003d (\"All of the subnets on network \u0027%s\u0027 must either \""},{"line_number":161,"context_line":"                            \"all be associated with segments or all not \""},{"line_number":162,"context_line":"                            \"associated with any segment.\") % net[\u0027id\u0027]"},{"line_number":163,"context_line":"        self.assertEqual(expected_message, e.resp_body[\u0027message\u0027])"},{"line_number":164,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":165,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_168f9c2a","line":163,"range":{"start_line":160,"start_character":8,"end_line":163,"end_character":66},"updated":"2016-10-07 20:41:10.000000000","message":"Checking the message in the execption was controversial in another patchset. The message might get translated and the test case will fail. Let\u0027s remove this check. My bad :-(","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":157,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":158,"context_line":"        e \u003d self.assertRaises(exceptions.BadRequest, self.create_subnet, net,"},{"line_number":159,"context_line":"                              client\u003dself.admin_client)"},{"line_number":160,"context_line":"        expected_message \u003d (\"All of the subnets on network \u0027%s\u0027 must either \""},{"line_number":161,"context_line":"                            \"all be associated with segments or all not \""},{"line_number":162,"context_line":"                            \"associated with any segment.\") % net[\u0027id\u0027]"},{"line_number":163,"context_line":"        self.assertEqual(expected_message, e.resp_body[\u0027message\u0027])"},{"line_number":164,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":165,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":166,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_aae59c38","line":163,"range":{"start_line":160,"start_character":8,"end_line":163,"end_character":66},"in_reply_to":"1a95cdbc_168f9c2a","updated":"2016-10-07 21:11:00.000000000","message":"Done, no worries :)","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":169,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":170,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":171,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":172,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":173,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":174,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_44425669","line":171,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":168,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":169,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":170,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":171,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":172,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":173,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":174,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_ead16458","line":171,"in_reply_to":"1a95cdbc_44425669","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1cd556d4586a4d7b4bb621844f7e39f7c7dba413","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":186,"context_line":"    def test_ip_allocationi_bind_port_on_update(self):"},{"line_number":187,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":188,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":189,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":190,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":191,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_64475277","line":188,"updated":"2016-10-07 20:41:10.000000000","message":"See comment to L39","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"df7ede64240c29c19edff65ea26909ab88fbcbf3","unresolved":false,"context_lines":[{"line_number":185,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":186,"context_line":"    def test_ip_allocationi_bind_port_on_update(self):"},{"line_number":187,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":188,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":189,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":190,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":191,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1a95cdbc_2ac8aca7","line":188,"in_reply_to":"1a95cdbc_64475277","updated":"2016-10-07 21:11:00.000000000","message":"Done","commit_id":"58f0f5f42e9d42450b8e04c77f9e7556b0fd3e9d"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"d26df4492485d584f2cae92411d3ddd9c2eb1149","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"},{"line_number":105,"context_line":"        for segment in net[\u0027segments\u0027]:"},{"line_number":106,"context_line":"            self.assertEqual(\u0027vlan\u0027, segment[\u0027provider:network_type\u0027])"},{"line_number":107,"context_line":"            self.assertEqual(net[\u0027provider:network_type\u0027],"},{"line_number":108,"context_line":"                    segment[\u0027provider:physical_network\u0027])"},{"line_number":109,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa6399be_1e92a69e","line":107,"range":{"start_line":107,"start_character":29,"end_line":107,"end_character":56},"updated":"2016-10-12 20:54:18.000000000","message":"This assert fails.\n\nYou got net from the show_network call in L104. At that point, net doesn\u0027t have a \u0027provider:network_type\u0027 attribute. This is what net looks like: http://paste.openstack.org/show/585509/.\n\nI suspect that what you wanted to do was to compare the \u0027provider:physical_network\u0027 you got in L98 with the \u0027provider:physical_network\u0027 in each segment of the network you got in L104. If that is the case, here\u0027s what I think you should do: https://gist.github.com/miguellavalle/16cf615854f62ece84ba650b06ead802","commit_id":"ad5b9fd50edd1e3691fb823cf312feec4bee84aa"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"2df63bc7413bc73ea2f6843de7ed7afafe6265fe","unresolved":false,"context_lines":[{"line_number":104,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"},{"line_number":105,"context_line":"        for segment in net[\u0027segments\u0027]:"},{"line_number":106,"context_line":"            self.assertEqual(\u0027vlan\u0027, segment[\u0027provider:network_type\u0027])"},{"line_number":107,"context_line":"            self.assertEqual(net[\u0027provider:network_type\u0027],"},{"line_number":108,"context_line":"                    segment[\u0027provider:physical_network\u0027])"},{"line_number":109,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":110,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"fa6399be_993090a0","line":107,"range":{"start_line":107,"start_character":29,"end_line":107,"end_character":56},"in_reply_to":"fa6399be_1e92a69e","updated":"2016-10-12 21:18:04.000000000","message":"Done","commit_id":"ad5b9fd50edd1e3691fb823cf312feec4bee84aa"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"672d04ef8330dd2f6cc03ab2cb96b0c7f976b657","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_a0985079","line":1,"updated":"2016-10-14 20:03:06.000000000","message":"If you get a chance to respin, take this out and either leave it out or add your company.","commit_id":"42a824a6cc3251bf260c3a790ddc628d3b23d198"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3d0a83217ff5e64839fb3613436c983761289969","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 OpenStack Foundation"},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":24,"id":"da6895a0_754bbf87","line":1,"in_reply_to":"fa6399be_a0985079","updated":"2016-10-25 16:17:11.000000000","message":"Done","commit_id":"42a824a6cc3251bf260c3a790ddc628d3b23d198"},{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"672d04ef8330dd2f6cc03ab2cb96b0c7f976b657","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(1, len(vlan_segment))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":126,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_l2_adjacency(self):"},{"line_number":128,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":129,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_c3c2ae84","line":126,"updated":"2016-10-14 20:03:06.000000000","message":"This actually requires the l2_adjacency extension.","commit_id":"42a824a6cc3251bf260c3a790ddc628d3b23d198"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3d0a83217ff5e64839fb3613436c983761289969","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self.assertEqual(1, len(vlan_segment))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"    @test.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":126,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_l2_adjacency(self):"},{"line_number":128,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":129,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":24,"id":"da6895a0_b5455771","line":126,"in_reply_to":"fa6399be_c3c2ae84","updated":"2016-10-25 16:17:11.000000000","message":"Done","commit_id":"42a824a6cc3251bf260c3a790ddc628d3b23d198"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"942ebc9f42f2330b199a591f5ac1e55a195a5ae0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests.tempest.api import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SegmentTest(base.BaseAdminNetworkTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _create_provider_network(self):"},{"line_number":26,"context_line":"        segments \u003d [{\"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_0b05ffba","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":18},"updated":"2016-10-25 19:09:28.000000000","message":"SegmentsTest according to file name, if you respin","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"ca6dae7cc321c41e23a57e41e884f6536b0dea4d","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.tests.tempest.api import base"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class SegmentTest(base.BaseAdminNetworkTest):"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"    def _create_provider_network(self):"},{"line_number":26,"context_line":"        segments \u003d [{\"provider:network_type\": \u0027vlan\u0027}]"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_4bbd3767","line":23,"range":{"start_line":23,"start_character":6,"end_line":23,"end_character":18},"in_reply_to":"da6895a0_0b05ffba","updated":"2016-10-25 19:42:09.000000000","message":"Done","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"942ebc9f42f2330b199a591f5ac1e55a195a5ae0","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            msg \u003d \"No support for vlans\""},{"line_number":33,"context_line":"            raise self.skipException(msg)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":36,"context_line":"        return net"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_ebca8b6d","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":65},"updated":"2016-10-25 19:09:28.000000000","message":"if body returned can be none as well, then here can we use\n\nself.assertIsNotNone(net[\u0027provider:physical_network\u0027],\n                     msg\u003d\"useful info for debug if fails\") ?\n\nignore this comment if it just returns \u0027\u0027","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a03c5a981334f5fe2f1b220db0febb9489b2d2d5","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            msg \u003d \"No support for vlans\""},{"line_number":33,"context_line":"            raise self.skipException(msg)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":36,"context_line":"        return net"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_ae398143","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":65},"in_reply_to":"da6895a0_4eeaa510","updated":"2016-10-25 20:09:30.000000000","message":"I suggested that to basically have a meaningful message during test failure  that will be beneficial during debug.\nif L29 does not return None in case network is empty then it is fine as it is now","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"ca6dae7cc321c41e23a57e41e884f6536b0dea4d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"            msg \u003d \"No support for vlans\""},{"line_number":33,"context_line":"            raise self.skipException(msg)"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":36,"context_line":"        return net"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_4eeaa510","line":35,"range":{"start_line":35,"start_character":8,"end_line":35,"end_character":65},"in_reply_to":"da6895a0_ebca8b6d","updated":"2016-10-25 19:42:09.000000000","message":"I\u0027m not quite sure what you mean here by \"if body returned can be none\". I believe the contents of the net variable should always be a valid network dictionary at this point, because if something goes wrong in the creation it should be caught by the exception handling, or it should cause a key error when checking net[\u0027provider:physical_network\u0027], in which case the test should rightly fail on error. Can you elaborate on the benefit of using assertIsNotNone please?","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"942ebc9f42f2330b199a591f5ac1e55a195a5ae0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":45,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":46,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":48,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":49,"context_line":"        self.assertNotEqual(0, retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":51,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_4b053778","line":48,"range":{"start_line":47,"start_character":26,"end_line":48,"end_character":50},"updated":"2016-10-25 19:09:28.000000000","message":"can\u0027t we match whole dictionary instead of just id ?","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"a03c5a981334f5fe2f1b220db0febb9489b2d2d5","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":45,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":46,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":48,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":49,"context_line":"        self.assertNotEqual(0, retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":51,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_ae10a1a9","line":48,"range":{"start_line":47,"start_character":26,"end_line":48,"end_character":50},"in_reply_to":"da6895a0_0b95ffdc","updated":"2016-10-25 20:09:30.000000000","message":"till this point no change is happening  unless something is getting changed implicitly that I am unaware of.","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"ca6dae7cc321c41e23a57e41e884f6536b0dea4d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":45,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":46,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":48,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":49,"context_line":"        self.assertNotEqual(0, retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":51,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_0b95ffdc","line":48,"range":{"start_line":47,"start_character":26,"end_line":48,"end_character":50},"in_reply_to":"da6895a0_4b053778","updated":"2016-10-25 19:42:09.000000000","message":"I\u0027m wary of doing this in case certain aspects of the segment change after creation time; I don\u0027t want erroneous failures. Checking the id should be sufficient to make sure it\u0027s the same segment, since id is quite literally the identifying factor.","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"da1db3be3b603bcc4a9625fb7be42d2ff20e434a","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":45,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":46,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":47,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":48,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":49,"context_line":"        self.assertNotEqual(0, retrieved_segment[\u0027segment\u0027][\u0027segmentation_id\u0027])"},{"line_number":50,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":51,"context_line":"                retrieved_segment[\u0027segment\u0027][\u0027physical_network\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_712aee7f","line":48,"range":{"start_line":47,"start_character":26,"end_line":48,"end_character":50},"in_reply_to":"da6895a0_ae10a1a9","updated":"2016-10-25 20:34:53.000000000","message":"At this point, no, nothing should be changing. My concern is if that ever changes (I.E. segments get updated with new attributes later). It\u0027s probably a fairly safe assumption that comparing the two dictionaries is fine, but I don\u0027t see it having much benefit over comparing just the id, and it\u0027s less likely to break on the off chance that segments get updated later.","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"942ebc9f42f2330b199a591f5ac1e55a195a5ae0","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         retrieved_segment[\u0027segment\u0027][\u0027network_id\u0027])"},{"line_number":54,"context_line":"        self.assertIsNone(retrieved_segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":55,"context_line":"        self.assertIsNone(retrieved_segment[\u0027segment\u0027][\u0027description\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(\u0027vlan\u0027, retrieved_segment[\u0027segment\u0027][\u0027network_type\u0027])"},{"line_number":57,"context_line":"        self.admin_client.delete_segment(created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":58,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":59,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_6b2f5bf6","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":77},"updated":"2016-10-25 19:09:28.000000000","message":"if you match created_segment and reterieved_segment as suggested in L48 this won\u0027t be required","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"ca6dae7cc321c41e23a57e41e884f6536b0dea4d","unresolved":false,"context_lines":[{"line_number":53,"context_line":"                         retrieved_segment[\u0027segment\u0027][\u0027network_id\u0027])"},{"line_number":54,"context_line":"        self.assertIsNone(retrieved_segment[\u0027segment\u0027][\u0027name\u0027])"},{"line_number":55,"context_line":"        self.assertIsNone(retrieved_segment[\u0027segment\u0027][\u0027description\u0027])"},{"line_number":56,"context_line":"        self.assertEqual(\u0027vlan\u0027, retrieved_segment[\u0027segment\u0027][\u0027network_type\u0027])"},{"line_number":57,"context_line":"        self.admin_client.delete_segment(created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":58,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":59,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_0b833f99","line":56,"range":{"start_line":56,"start_character":8,"end_line":56,"end_character":77},"in_reply_to":"da6895a0_6b2f5bf6","updated":"2016-10-25 19:42:09.000000000","message":"See my reply to L48","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"942ebc9f42f2330b199a591f5ac1e55a195a5ae0","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":70,"context_line":"                segment[\u0027segment\u0027][\u0027physical_network\u0027])"},{"line_number":71,"context_line":"        segment_name \u003d \u0027test_segment\u0027"},{"line_number":72,"context_line":"        segment_description \u003d \u0027test segment description\u0027"},{"line_number":73,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":74,"context_line":"                name\u003dsegment_name, description\u003dsegment_description)"},{"line_number":75,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_2b1d63bd","line":72,"range":{"start_line":71,"start_character":8,"end_line":72,"end_character":56},"updated":"2016-10-25 19:09:28.000000000","message":"Line 54 and 55 in this file would make more sense before line 71, as it would confirm name and description were none and you can assert right after update call","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"ca6dae7cc321c41e23a57e41e884f6536b0dea4d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":69,"context_line":"        self.assertEqual(net[\u0027provider:physical_network\u0027],"},{"line_number":70,"context_line":"                segment[\u0027segment\u0027][\u0027physical_network\u0027])"},{"line_number":71,"context_line":"        segment_name \u003d \u0027test_segment\u0027"},{"line_number":72,"context_line":"        segment_description \u003d \u0027test segment description\u0027"},{"line_number":73,"context_line":"        self.admin_client.update_segment(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":74,"context_line":"                name\u003dsegment_name, description\u003dsegment_description)"},{"line_number":75,"context_line":"        segment \u003d self.admin_client.show_segment(segment[\u0027segment\u0027][\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"da6895a0_eb5a8b4f","line":72,"range":{"start_line":71,"start_character":8,"end_line":72,"end_character":56},"in_reply_to":"da6895a0_2b1d63bd","updated":"2016-10-25 19:42:09.000000000","message":"Done","commit_id":"a2e788a07240ae04c0931c4358a5cd3289b82903"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.tests.tempest.api import base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_d634aa95","line":18,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"from tempest.lib.common.utils import data_utils"},{"line_number":17,"context_line":"from tempest.lib import exceptions"},{"line_number":18,"context_line":"from tempest import test"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron.tests.tempest.api import base"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_9a050e17","line":18,"in_reply_to":"5ff73747_d634aa95","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":36,"context_line":"        return net"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":39,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":40,"context_line":"    def test_segment_create_delete(self):"},{"line_number":41,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_36006eab","line":38,"updated":"2017-04-26 22:00:00.000000000","message":"Here https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/test_networks.py#L40 that this decorator is a different place. Now you have to import: \n\nfrom tempest.lib import decorators\n\nLook at https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/test_networks.py#L16","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":35,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":36,"context_line":"        return net"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    @test.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":39,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":40,"context_line":"    def test_segment_create_delete(self):"},{"line_number":41,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_fd240cb1","line":38,"in_reply_to":"5ff73747_36006eab","updated":"2017-04-27 14:24:59.000000000","message":"Done. Thanks for pointing me toward this!","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"},{"line_number":60,"context_line":"        self.assertNotIn(created_segment[\u0027segment\u0027][\u0027id\u0027], segment_ids)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":63,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":64,"context_line":"    def test_update_segment(self):"},{"line_number":65,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_962aa229","line":62,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        segment_ids \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027]]"},{"line_number":60,"context_line":"        self.assertNotIn(created_segment[\u0027segment\u0027][\u0027id\u0027], segment_ids)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    @test.idempotent_id(\u0027dedf0193-cd2a-4259-bc82-1d5149c85b78\u0027)"},{"line_number":63,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":64,"context_line":"    def test_update_segment(self):"},{"line_number":65,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_bd3a04c9","line":62,"in_reply_to":"5ff73747_962aa229","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual(segment_description,"},{"line_number":80,"context_line":"                         segment[\u0027segment\u0027][\u0027description\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":83,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":84,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":85,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_56209a48","line":82,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        self.assertEqual(segment_description,"},{"line_number":80,"context_line":"                         segment[\u0027segment\u0027][\u0027description\u0027])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @test.idempotent_id(\u0027014b5848-b552-49ef-8fe4-8a5e29f3df0f\u0027)"},{"line_number":83,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":84,"context_line":"    def test_subnet_with_segment(self):"},{"line_number":85,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_9d33c8f6","line":82,"in_reply_to":"5ff73747_56209a48","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.assertEqual(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":95,"context_line":"                subnet[\u0027subnet\u0027][\u0027segment_id\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @test.idempotent_id(\u0027648efc75-09b6-4e51-9943-1ad51cc34f17\u0027)"},{"line_number":98,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":99,"context_line":"    def test_show_multi_segment_network(self):"},{"line_number":100,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_161692f2","line":97,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":94,"context_line":"        self.assertEqual(segment[\u0027segment\u0027][\u0027id\u0027],"},{"line_number":95,"context_line":"                subnet[\u0027subnet\u0027][\u0027segment_id\u0027])"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    @test.idempotent_id(\u0027648efc75-09b6-4e51-9943-1ad51cc34f17\u0027)"},{"line_number":98,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":99,"context_line":"    def test_show_multi_segment_network(self):"},{"line_number":100,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_3d54b4fe","line":97,"in_reply_to":"5ff73747_161692f2","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    segment[\u0027provider:physical_network\u0027])"},{"line_number":111,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @test.idempotent_id(\u0027a76b03a3-0e45-4194-bc50-f77b932797b7\u0027)"},{"line_number":114,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":115,"context_line":"    def test_create_segments_different_types(self):"},{"line_number":116,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_f6d44622","line":113,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    segment[\u0027provider:physical_network\u0027])"},{"line_number":111,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    @test.idempotent_id(\u0027a76b03a3-0e45-4194-bc50-f77b932797b7\u0027)"},{"line_number":114,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":115,"context_line":"    def test_create_segments_different_types(self):"},{"line_number":116,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_fd59ac34","line":113,"in_reply_to":"5ff73747_f6d44622","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertEqual(1, len(vxlan_segment))"},{"line_number":125,"context_line":"        self.assertEqual(1, len(vlan_segment))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":128,"context_line":"    @test.requires_ext(extension\u003d\"segment,l2_adjacency\", service\u003d\"network\")"},{"line_number":129,"context_line":"    def test_l2_adjacency(self):"},{"line_number":130,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_d6d94a57","line":127,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":124,"context_line":"        self.assertEqual(1, len(vxlan_segment))"},{"line_number":125,"context_line":"        self.assertEqual(1, len(vlan_segment))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    @test.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":128,"context_line":"    @test.requires_ext(extension\u003d\"segment,l2_adjacency\", service\u003d\"network\")"},{"line_number":129,"context_line":"    def test_l2_adjacency(self):"},{"line_number":130,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_9d48685c","line":127,"in_reply_to":"5ff73747_d6d94a57","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"},{"line_number":140,"context_line":"        self.assertFalse(net[\u0027l2_adjacency\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @test.idempotent_id(\u002748532981-8d6e-45f2-958f-3256354accc2\u0027)"},{"line_number":143,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":144,"context_line":"    def test_associate_subnet_to_routed_network_fails(self):"},{"line_number":145,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_b6da3e48","line":142,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        net \u003d self.admin_client.show_network(net[\u0027id\u0027])[\u0027network\u0027]"},{"line_number":140,"context_line":"        self.assertFalse(net[\u0027l2_adjacency\u0027])"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    @test.idempotent_id(\u002748532981-8d6e-45f2-958f-3256354accc2\u0027)"},{"line_number":143,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":144,"context_line":"    def test_associate_subnet_to_routed_network_fails(self):"},{"line_number":145,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_fd72ccac","line":142,"in_reply_to":"5ff73747_b6da3e48","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":156,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @test.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":159,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":160,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":161,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_96df4239","line":158,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":156,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"    @test.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":159,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":160,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":161,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_dd6b90b4","line":158,"in_reply_to":"5ff73747_96df4239","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"292d54bb81d4f8df8eec2bdd4bb91dbec31d3191","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.assertEqual(\"immediate\", port[\u0027ip_allocation\u0027])"},{"line_number":172,"context_line":"        self.assertNotEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @test.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":175,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":176,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":177,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_56e53a08","line":174,"updated":"2017-04-26 22:00:00.000000000","message":"See my comment to L38","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"714e63830feadc44a4cf596eb7c796f080317600","unresolved":false,"context_lines":[{"line_number":171,"context_line":"        self.assertEqual(\"immediate\", port[\u0027ip_allocation\u0027])"},{"line_number":172,"context_line":"        self.assertNotEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"    @test.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":175,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":176,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":177,"context_line":"        net \u003d self._create_provider_network()"}],"source_content_type":"text/x-python","patch_set":28,"id":"5ff73747_7d5ebc12","line":174,"in_reply_to":"5ff73747_56e53a08","updated":"2017-04-27 14:24:59.000000000","message":"Done","commit_id":"d3995f9365ffc655273d32c3f4928d6f1ef140c9"},{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"3d4df80c1110fd3b1dbe4d1724eeafbdf36344c6","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _create_provider_network(self):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":28,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":29,"context_line":"        try:"},{"line_number":30,"context_line":"            net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":31,"context_line":"                                             segments\u003dsegments)"},{"line_number":32,"context_line":"        except exceptions.BadRequest:"},{"line_number":33,"context_line":"            msg \u003d \"No support for vlans\""},{"line_number":34,"context_line":"            raise self.skipException(msg)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":37,"context_line":"        return net"}],"source_content_type":"text/x-python","patch_set":33,"id":"5ff73747_5aca8fa0","line":34,"range":{"start_line":29,"start_character":8,"end_line":34,"end_character":41},"updated":"2017-05-01 22:59:26.000000000","message":"We can know VLAN support from the config[1] not post bad request.\n\n[1]: https://github.com/openstack/neutron/blob/master/neutron/tests/tempest/api/admin/test_networks.py#L76-L78","commit_id":"24ee37df6ed8f34c67f9db4566dd7b4bebe74736"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"29925bb010589aa0051d745615fb86652bafb6b8","unresolved":false,"context_lines":[{"line_number":26,"context_line":"    def _create_provider_network(self):"},{"line_number":27,"context_line":"        segments \u003d [{\"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":28,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":29,"context_line":"        try:"},{"line_number":30,"context_line":"            net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":31,"context_line":"                                             segments\u003dsegments)"},{"line_number":32,"context_line":"        except exceptions.BadRequest:"},{"line_number":33,"context_line":"            msg \u003d \"No support for vlans\""},{"line_number":34,"context_line":"            raise self.skipException(msg)"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":37,"context_line":"        return net"}],"source_content_type":"text/x-python","patch_set":33,"id":"5ff73747_660c7f94","line":34,"range":{"start_line":29,"start_character":8,"end_line":34,"end_character":41},"in_reply_to":"5ff73747_5aca8fa0","updated":"2017-05-02 15:03:32.000000000","message":"Done, thanks","commit_id":"24ee37df6ed8f34c67f9db4566dd7b4bebe74736"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"1acd4492b8f0a269772727254b03cf562cf6b216","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    @testtools.skipUnless(\"vxlan\" in config.CONF.neutron_plugin_options."},{"line_number":65,"context_line":"                          available_type_drivers,"},{"line_number":66,"context_line":"                          \u0027VXLAN type_driver is not enabled\u0027)"},{"line_number":67,"context_line":"    @test.requires_ext(extension\u003d\"segments\", service\u003d\"network\")"},{"line_number":68,"context_line":"    def test_update_segment(self):"},{"line_number":69,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":70,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":37,"id":"3f044301_f06f2890","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":42},"updated":"2017-05-03 21:47:25.000000000","message":"mhhhh, I don\u0027t think you had to change this. Look at the code for the test.requires_ext decorator: https://github.com/openstack/tempest/blob/master/tempest/test.py#L101. It calls is_extension_enabled, which in this line checks for the networking extensions: https://github.com/openstack/tempest/blob/master/tempest/test.py#L127. Please note that CONF.network_feature_enabled.api_extensions is a configuration parameter in Tempest.\n\nLooking at the tempest execution log in the previous patchset, this is what network_feature_enabled.api_extensions look like:\nhttp://logs.openstack.org/15/353115/36/check/gate-neutron-dsvm-api-ubuntu-xenial/ff8371a/logs/tempest.txt.gz#_2017-05-03_15_28_42_283. Note that \u0027segment\u0027 is in there. I think this comes from the name of the extension: https://github.com/openstack/neutron/blob/master/neutron/extensions/segment.py#L102, where as the when configuring the segments service plugin you point to the name of the entry point here: https://github.com/openstack/neutron/blob/master/setup.cfg#L79.\n\nDon\u0027t change just yet. Let\u0027s wait for the result of Jenkins. LOL","commit_id":"5353018577194d7c1e7694bda1cf51839319dc52"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"042d151f72e033388bf407220c81d61a40ba26e8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    @testtools.skipUnless(\"vxlan\" in config.CONF.neutron_plugin_options."},{"line_number":65,"context_line":"                          available_type_drivers,"},{"line_number":66,"context_line":"                          \u0027VXLAN type_driver is not enabled\u0027)"},{"line_number":67,"context_line":"    @test.requires_ext(extension\u003d\"segments\", service\u003d\"network\")"},{"line_number":68,"context_line":"    def test_update_segment(self):"},{"line_number":69,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":70,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":37,"id":"3f044301_69944045","line":67,"range":{"start_line":67,"start_character":34,"end_line":67,"end_character":42},"in_reply_to":"3f044301_f06f2890","updated":"2017-05-04 14:24:43.000000000","message":"So, the reason I think it needs to be plural here is because in previous patchsets, if this doesn\u0027t match exactly what I have in the other patch (i.e. the other patch enables \"segments,\" but this requires_ext \"segment\"), the tests are skipped because require_ext doesn\u0027t recognize that the segments plugin is enabled. The code for requires_ext seems to reinforce this, since it looks to be doing a simple string compare before skipping tests.\n\nNow however, requires_ext presumably returns true since the tests are at least running, but they\u0027re failing because the segments plugin doesn\u0027t actually seem to be enabled? So either requires_ext isn\u0027t doing what I assume it should, or something else is going on. My suspicion now is that maybe the plugin needs to be enabled in multiple areas, and requires_ext does not check all of them? Or maybe perhaps in the other patch, some areas look for the name of the plugin (singular), while others want the alias (plural)? But we\u0027ll see if any of that holds up as I look further into this.\n\nJust thinking aloud. At the very least, from the code and logs you pointed me toward (thanks, very helpful :) ), I think all the references here need to match references in neutron/tests/contrib/hooks/* in the other patchset.","commit_id":"5353018577194d7c1e7694bda1cf51839319dc52"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7536a26030406099c1ebc2b09ea1234237343f17","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class SegmentsTest(base.BaseAdminNetworkTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _create_provider_network(self):"},{"line_number":29,"context_line":"        segments \u003d [{\"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":30,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":31,"context_line":"        net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":32,"context_line":"                                         segments\u003dsegments)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_7de17d9a","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":52},"updated":"2017-05-30 17:05:15.000000000","message":"It seems that the VM\u0027s that run these tests have problem handling the VLAN type. In many cases the test case fails trying to create the segment. In other cases, even if you can create the network and the segments, when you try to do things with ports, it fails because the host is not connected to the segment: http://logs.openstack.org/15/353115/44/check/gate-neutron-dsvm-api-ubuntu-xenial/8911ef1/console.html.gz#_2017-05-23_19_12_01_057217.\n\nSo I propose to change everything to VXLAN. That will require some adjustments to the test cases. Please see below for more comments","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d464b4c158b430bd9842094ef5cb28e1976d7c81","unresolved":false,"context_lines":[{"line_number":26,"context_line":"class SegmentsTest(base.BaseAdminNetworkTest):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    def _create_provider_network(self):"},{"line_number":29,"context_line":"        segments \u003d [{\"provider:network_type\": \u0027vlan\u0027}]"},{"line_number":30,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":31,"context_line":"        net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":32,"context_line":"                                         segments\u003dsegments)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_bba27899","line":29,"range":{"start_line":29,"start_character":46,"end_line":29,"end_character":52},"in_reply_to":"df140735_7de17d9a","updated":"2017-05-30 20:53:57.000000000","message":"Done","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7536a26030406099c1ebc2b09ea1234237343f17","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return net"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":37,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":38,"context_line":"                          available_type_drivers,"},{"line_number":39,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":40,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_5d63591b","line":37,"updated":"2017-05-30 17:05:15.000000000","message":"This won\u0027t be needed anymore. Remove all the instances below","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d464b4c158b430bd9842094ef5cb28e1976d7c81","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return net"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":37,"context_line":"    @testtools.skipUnless(\"vlan\" in config.CONF.neutron_plugin_options."},{"line_number":38,"context_line":"                          available_type_drivers,"},{"line_number":39,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":40,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_9b9fb44f","line":37,"in_reply_to":"df140735_5d63591b","updated":"2017-05-30 20:53:57.000000000","message":"Done","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7536a26030406099c1ebc2b09ea1234237343f17","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":43,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":44,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":45,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":46,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":47,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_1d9f2104","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":66},"updated":"2017-05-30 17:05:15.000000000","message":"When creating segments, don\u0027t pass physical_network anymore. It doesn\u0027t apply to VXLAN. The same applies to all the segments creations below","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d464b4c158b430bd9842094ef5cb28e1976d7c81","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":43,"context_line":"        created_segment \u003d self.admin_client.create_segment("},{"line_number":44,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vlan\u0027,"},{"line_number":45,"context_line":"                physical_network\u003dnet[\u0027provider:physical_network\u0027])"},{"line_number":46,"context_line":"        retrieved_segment \u003d self.admin_client.show_segment("},{"line_number":47,"context_line":"                created_segment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":48,"context_line":"        self.assertEqual(created_segment[\u0027segment\u0027][\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_5ba91c79","line":45,"range":{"start_line":45,"start_character":16,"end_line":45,"end_character":66},"in_reply_to":"df140735_1d9f2104","updated":"2017-05-30 20:53:57.000000000","message":"Done","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"7536a26030406099c1ebc2b09ea1234237343f17","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                          available_type_drivers,"},{"line_number":126,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":127,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":128,"context_line":"    def test_create_segments_different_types(self):"},{"line_number":129,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":130,"context_line":"        self.admin_client.create_segment("},{"line_number":131,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_98357fdd","line":128,"updated":"2017-05-30 17:05:15.000000000","message":"This test case doesn\u0027t make sense anymore","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"d464b4c158b430bd9842094ef5cb28e1976d7c81","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                          available_type_drivers,"},{"line_number":126,"context_line":"                          \u0027VLAN type_driver is not enabled\u0027)"},{"line_number":127,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":128,"context_line":"    def test_create_segments_different_types(self):"},{"line_number":129,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":130,"context_line":"        self.admin_client.create_segment("},{"line_number":131,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":44,"id":"df140735_1bbde4b6","line":128,"in_reply_to":"df140735_98357fdd","updated":"2017-05-30 20:53:57.000000000","message":"Removed","commit_id":"67bc091c45a3d5905cc740a7f60b2531909b03ff"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f03dfbd4c34ab396e3e91f948c78401326cd8231","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":143,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":144,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":145,"context_line":"        port \u003d self.create_port(net, client\u003dself.admin_client, **data)"},{"line_number":146,"context_line":"        self.assertEqual(\"immediate\", port[\u0027ip_allocation\u0027])"},{"line_number":147,"context_line":"        self.assertNotEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"df140735_783ad898","line":145,"updated":"2017-06-06 22:26:05.000000000","message":"When you try to bind the port, this is the error you get from the API: http://logs.openstack.org/15/353115/45/check/gate-neutron-dsvm-api-ubuntu-xenial/23fc048/console.html.gz#_2017-05-30_21_30_17_701077.\n\nAs you can see, you are getting a HostNotConnectedToAnySegment, which is only raised here in the code: https://github.com/openstack/neutron/blob/master/neutron/db/ipam_backend_mixin.py#L686.\n\nThat piece of code looks for a row in the segment host mapping (https://github.com/openstack/neutron/blob/master/neutron/db/models/segment.py#L57) to see if there is a segment that belongs to one of the subnets in the network and that is accessible from the host you are trying to bind the port in. The problem is that we don\u0027t store VXLAN segments in the segment host mapping. Only segments that are associated to a physical network. See here: https://github.com/openstack/neutron/blob/master/neutron/services/segments/db.py#L251.\n\nSo we have two alternatives. Either we scrap this test case (and the one in L151), or we use, only for this test case (and the one in L151) a vlan network. It would work as follows:\n\n1) create vlan network\n2) get its segment id\n3) create a subnet specifying the segment id retrieved in 2\n4) create and bind the port\n\nI am not sure it will work with what we have in infra, but we can give it a try","commit_id":"70737c10d65e0cb0e44b78d23e025b61c55aa945"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"916b22f3bfb88bc4d5ad54e209f8c7288176b52f","unresolved":false,"context_lines":[{"line_number":142,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":143,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":144,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"},{"line_number":145,"context_line":"        port \u003d self.create_port(net, client\u003dself.admin_client, **data)"},{"line_number":146,"context_line":"        self.assertEqual(\"immediate\", port[\u0027ip_allocation\u0027])"},{"line_number":147,"context_line":"        self.assertNotEmpty(port[\u0027fixed_ips\u0027])"},{"line_number":148,"context_line":""}],"source_content_type":"text/x-python","patch_set":45,"id":"df140735_1bd996f3","line":145,"in_reply_to":"df140735_783ad898","updated":"2017-06-06 23:42:22.000000000","message":"Done","commit_id":"70737c10d65e0cb0e44b78d23e025b61c55aa945"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f03dfbd4c34ab396e3e91f948c78401326cd8231","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @decorators.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":150,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":151,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":152,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":153,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":154,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":45,"id":"df140735_d85204df","line":151,"updated":"2017-06-06 22:26:05.000000000","message":"Ditto","commit_id":"70737c10d65e0cb0e44b78d23e025b61c55aa945"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"916b22f3bfb88bc4d5ad54e209f8c7288176b52f","unresolved":false,"context_lines":[{"line_number":148,"context_line":""},{"line_number":149,"context_line":"    @decorators.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":150,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":151,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":152,"context_line":"        net \u003d self._create_provider_network()"},{"line_number":153,"context_line":"        segment \u003d self.admin_client.create_segment("},{"line_number":154,"context_line":"                network_id\u003dnet[\u0027id\u0027], network_type\u003d\u0027vxlan\u0027)"}],"source_content_type":"text/x-python","patch_set":45,"id":"df140735_bb450a46","line":151,"in_reply_to":"df140735_d85204df","updated":"2017-06-06 23:42:22.000000000","message":"Done","commit_id":"70737c10d65e0cb0e44b78d23e025b61c55aa945"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f29553bb3dc3678c5741e4eb48db1c49769f836d","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":112,"context_line":"    @test.requires_ext(extension\u003d\"segment,l2_adjacency\","},{"line_number":113,"context_line":"            service\u003d\"network\")"},{"line_number":114,"context_line":"    def test_l2_adjacency(self):"},{"line_number":115,"context_line":"        net \u003d self._create_vxlan_provider_network()"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_546581e0","line":112,"range":{"start_line":112,"start_character":42,"end_line":112,"end_character":54},"updated":"2017-06-07 16:10:49.000000000","message":"The other thing you will notice in this response http://logs.openstack.org/15/353115/47/check/gate-neutron-dsvm-api-ubuntu-xenial/1f39927/console.html#_2017-06-07_14_29_33_962879\n\nIs that the network dictionary returd by the API has the l2_adjacency attribute. That is because the l2 adjacency extension is required by the segments extension, so it is loaded automatically. So you can remove it from here","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"98bdfe142a1df2fcbdbbd5010112c4f0714e7c7b","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":112,"context_line":"    @test.requires_ext(extension\u003d\"segment,l2_adjacency\","},{"line_number":113,"context_line":"            service\u003d\"network\")"},{"line_number":114,"context_line":"    def test_l2_adjacency(self):"},{"line_number":115,"context_line":"        net \u003d self._create_vxlan_provider_network()"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_b4b4ddf3","line":112,"range":{"start_line":112,"start_character":42,"end_line":112,"end_character":54},"in_reply_to":"df140735_546581e0","updated":"2017-06-07 16:19:23.000000000","message":"See here in the segments plugin, which is what you configured in devstack: https://github.com/openstack/neutron/blob/master/neutron/services/segments/plugin.py#L58","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"12bab7e0ffdec8633cec4d232ad5b3fe56aea743","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            self.assertNotEqual(0, segment[\u0027provider:segmentation_id\u0027])"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    @decorators.idempotent_id(\u00270cbc6abd-afa8-44cd-88f8-23666c306215\u0027)"},{"line_number":112,"context_line":"    @test.requires_ext(extension\u003d\"segment,l2_adjacency\","},{"line_number":113,"context_line":"            service\u003d\"network\")"},{"line_number":114,"context_line":"    def test_l2_adjacency(self):"},{"line_number":115,"context_line":"        net \u003d self._create_vxlan_provider_network()"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_34d9ed21","line":112,"range":{"start_line":112,"start_character":42,"end_line":112,"end_character":54},"in_reply_to":"df140735_546581e0","updated":"2017-06-07 16:28:10.000000000","message":"Will include this in the next patchset, going to wait to push until the results come in for the port binding tests and we see if anything else needs to be changed","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f29553bb3dc3678c5741e4eb48db1c49769f836d","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":143,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":144,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":145,"context_line":"        net_segment_id \u003d net[\u0027segments\u0027][0][\u0027segment_id\u0027]"},{"line_number":146,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":147,"context_line":"                segment_id\u003dnet_segment_id)"},{"line_number":148,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_c1443177","line":145,"updated":"2017-06-07 16:10:49.000000000","message":"Since your network has only one segment, this is not going to work. The dictionary returned by the API doesn\u0027t have a segments attribute: http://logs.openstack.org/15/353115/47/check/gate-neutron-dsvm-api-ubuntu-xenial/1f39927/console.html#_2017-06-07_14_29_33_962879\n\nSo you are going to have to list segments specifying the network id of the network you just created to get the segment_id you are looking for","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"12bab7e0ffdec8633cec4d232ad5b3fe56aea743","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":143,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":144,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":145,"context_line":"        net_segment_id \u003d net[\u0027segments\u0027][0][\u0027segment_id\u0027]"},{"line_number":146,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":147,"context_line":"                segment_id\u003dnet_segment_id)"},{"line_number":148,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_1444a9b6","line":145,"in_reply_to":"df140735_c1443177","updated":"2017-06-07 16:28:10.000000000","message":"Heh, looks like I realized this just as you were commenting. Done in current patch","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3f612e760c1ca26d78ea8b7291244b9132190103","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":143,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":144,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":145,"context_line":"        net_segment_id \u003d net[\u0027segments\u0027][0][\u0027segment_id\u0027]"},{"line_number":146,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":147,"context_line":"                segment_id\u003dnet_segment_id)"},{"line_number":148,"context_line":"        data \u003d {\u0027binding:host_id\u0027: \u0027allinone\u0027}"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_0361093a","line":145,"in_reply_to":"df140735_c1443177","updated":"2017-06-07 18:41:29.000000000","message":"Oh, whoops, looks like I misinterpreted what you were saying here. This will actually be in PS49. Thanks!","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f29553bb3dc3678c5741e4eb48db1c49769f836d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":156,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":157,"context_line":"        net_segment_id \u003d net[\u0027segments\u0027][0][\u0027segment_id\u0027]"},{"line_number":158,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":159,"context_line":"                segment_id\u003dnet_segment_id)"},{"line_number":160,"context_line":"        port \u003d self.create_port(net)"},{"line_number":161,"context_line":"        self.assertEqual(\"deferred\", port[\u0027ip_allocation\u0027])"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_810cf942","line":158,"updated":"2017-06-07 16:10:49.000000000","message":"See comment to line 145","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"12bab7e0ffdec8633cec4d232ad5b3fe56aea743","unresolved":false,"context_lines":[{"line_number":155,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":156,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":157,"context_line":"        net_segment_id \u003d net[\u0027segments\u0027][0][\u0027segment_id\u0027]"},{"line_number":158,"context_line":"        self.create_subnet(net, client\u003dself.admin_client,"},{"line_number":159,"context_line":"                segment_id\u003dnet_segment_id)"},{"line_number":160,"context_line":"        port \u003d self.create_port(net)"},{"line_number":161,"context_line":"        self.assertEqual(\"deferred\", port[\u0027ip_allocation\u0027])"}],"source_content_type":"text/x-python","patch_set":47,"id":"df140735_f41255b4","line":158,"in_reply_to":"df140735_810cf942","updated":"2017-06-07 16:28:10.000000000","message":"Done","commit_id":"5411718134f63b3eeaa0d0765e26f376ffb6d59a"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e33e72b55e930515d30ea399ed1be2d539c0f750","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @decorators.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":141,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":142,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":143,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":144,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":145,"context_line":"        net_segment_id \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027] if"}],"source_content_type":"text/x-python","patch_set":49,"id":"bf091321_545c5d4a","line":142,"updated":"2017-06-08 19:59:09.000000000","message":"Clearly what we have in the gate doesn\u0027t allow us to properly handle this test case. I think you can go ahead and remove it","commit_id":"62336a62de52d23a9259d20262f1103fcd196ca7"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"abc7c6952858e692e83e42428d9f6e5210eeb37f","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @decorators.idempotent_id(\u00270dd6a458-4a58-483c-a10a-fcab0169f656\u0027)"},{"line_number":141,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":142,"context_line":"    def test_ip_allocation_bind_port_on_create(self):"},{"line_number":143,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":144,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":145,"context_line":"        net_segment_id \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027] if"}],"source_content_type":"text/x-python","patch_set":49,"id":"bf091321_8adc1075","line":142,"in_reply_to":"bf091321_545c5d4a","updated":"2017-06-08 20:32:16.000000000","message":"Unfortunate, but if it\u0027s going to work it\u0027s not going to work I suppose. Done","commit_id":"62336a62de52d23a9259d20262f1103fcd196ca7"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"e33e72b55e930515d30ea399ed1be2d539c0f750","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @decorators.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":155,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":156,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":157,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":158,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":159,"context_line":"        net_segment_id \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027] if"}],"source_content_type":"text/x-python","patch_set":49,"id":"bf091321_1456e52a","line":156,"updated":"2017-06-08 19:59:09.000000000","message":"Ditto","commit_id":"62336a62de52d23a9259d20262f1103fcd196ca7"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"abc7c6952858e692e83e42428d9f6e5210eeb37f","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    @decorators.idempotent_id(\u00279e1b14c9-30eb-45dd-bd47-9fb1f241ea43\u0027)"},{"line_number":155,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":156,"context_line":"    def test_ip_allocation_bind_port_on_update(self):"},{"line_number":157,"context_line":"        net \u003d self._create_vlan_provider_network()"},{"line_number":158,"context_line":"        body \u003d self.admin_client.list_segments()"},{"line_number":159,"context_line":"        net_segment_id \u003d [s[\u0027id\u0027] for s in body[\u0027segments\u0027] if"}],"source_content_type":"text/x-python","patch_set":49,"id":"bf091321_4ae6f846","line":156,"in_reply_to":"bf091321_1456e52a","updated":"2017-06-08 20:32:16.000000000","message":"Done","commit_id":"62336a62de52d23a9259d20262f1103fcd196ca7"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":27,"context_line":"        net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":28,"context_line":"                                         segments\u003dsegments)"},{"line_number":29,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":30,"context_line":"        return net"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_31837007","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":62},"updated":"2017-07-28 17:42:10.000000000","message":"instead of using a literal, you could instead import neutron_lib.api.definitions.provider_net.PHYSICAL_NETWORK","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":27,"context_line":"        net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":28,"context_line":"                                         segments\u003dsegments)"},{"line_number":29,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":30,"context_line":"        return net"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_91c57c5e","line":29,"updated":"2017-07-28 17:42:10.000000000","message":"it means the test also requires physnet api extension; please check it for the test cases using this helper (probably all of them, meaning you can use required_extensions)","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":27,"context_line":"        net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":28,"context_line":"                                         segments\u003dsegments)"},{"line_number":29,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":30,"context_line":"        return net"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_97032c10","line":29,"range":{"start_line":29,"start_character":37,"end_line":29,"end_character":62},"in_reply_to":"df3967d1_31837007","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        name \u003d data_utils.rand_name(\"test-segments\")"},{"line_number":27,"context_line":"        net \u003d self.create_shared_network(network_name\u003dname,"},{"line_number":28,"context_line":"                                         segments\u003dsegments)"},{"line_number":29,"context_line":"        self.assertNotEqual(\u0027\u0027, net[\u0027provider:physical_network\u0027])"},{"line_number":30,"context_line":"        return net"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_3a08e526","line":29,"in_reply_to":"df3967d1_91c57c5e","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"},{"line_number":33,"context_line":"        return self._create_provider_network("},{"line_number":34,"context_line":"                [{\"provider:network_type\": \u0027vlan\u0027}])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_11886c1d","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":40},"updated":"2017-07-28 17:42:10.000000000","message":"same, for NETWORK_TYPE","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"},{"line_number":33,"context_line":"        return self._create_provider_network("},{"line_number":34,"context_line":"                [{\"provider:network_type\": \u0027vlan\u0027}])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_d1c78445","line":34,"range":{"start_line":34,"start_character":44,"end_line":34,"end_character":48},"updated":"2017-07-28 17:42:10.000000000","message":"this assumes that vlan is supported by the cloud under test, which is not guaranteed (depends on enabled type drivers for ml2). But you can inspect available_type_drivers config option to determine if it\u0027s available.","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"},{"line_number":33,"context_line":"        return self._create_provider_network("},{"line_number":34,"context_line":"                [{\"provider:network_type\": \u0027vlan\u0027}])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_da0e7931","line":34,"range":{"start_line":34,"start_character":19,"end_line":34,"end_character":40},"in_reply_to":"df3967d1_11886c1d","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def _create_vlan_provider_network(self):"},{"line_number":33,"context_line":"        return self._create_provider_network("},{"line_number":34,"context_line":"                [{\"provider:network_type\": \u0027vlan\u0027}])"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_46e9907e","line":34,"range":{"start_line":34,"start_character":44,"end_line":34,"end_character":48},"in_reply_to":"df3967d1_d1c78445","updated":"2017-07-28 21:11:36.000000000","message":"I\u0027m not sure I have access to to ml2 and that attribute here, but maybe I\u0027m just not seeing it. Can you elaborate on where exactly that is and how I can access it?","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("},{"line_number":38,"context_line":"                [{\"provider:network_type\": \u0027vxlan\u0027}])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_d179c42f","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":40},"updated":"2017-07-28 17:42:10.000000000","message":"ditto","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("},{"line_number":38,"context_line":"                [{\"provider:network_type\": \u0027vxlan\u0027}])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_91c1fc31","line":38,"range":{"start_line":38,"start_character":43,"end_line":38,"end_character":50},"updated":"2017-07-28 17:42:10.000000000","message":"same as for VLAN assumption","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def _create_vxlan_provider_network(self):"},{"line_number":37,"context_line":"        return self._create_provider_network("},{"line_number":38,"context_line":"                [{\"provider:network_type\": \u0027vxlan\u0027}])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_1a2641b9","line":38,"range":{"start_line":38,"start_character":28,"end_line":38,"end_character":40},"in_reply_to":"df3967d1_d179c42f","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                [{\"provider:network_type\": \u0027vxlan\u0027}])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":42,"context_line":"    def test_segment_create_delete(self):"},{"line_number":43,"context_line":"        net \u003d self._create_vxlan_provider_network()"},{"line_number":44,"context_line":"        created_segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_31b5b0ef","line":41,"updated":"2017-07-28 17:42:10.000000000","message":"since all test cases require segment api, wouldn\u0027t it make more sense to move it on class level, using required_extensions \u003d [] class attribute?","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                [{\"provider:network_type\": \u0027vxlan\u0027}])"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    @decorators.idempotent_id(\u00278c23ce8e-8896-44cd-98bb-5112c42718d0\u0027)"},{"line_number":41,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":42,"context_line":"    def test_segment_create_delete(self):"},{"line_number":43,"context_line":"        net \u003d self._create_vxlan_provider_network()"},{"line_number":44,"context_line":"        created_segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_1a5be12e","line":41,"in_reply_to":"df3967d1_31b5b0ef","updated":"2017-07-28 21:11:36.000000000","message":"I did not know about that, thanks! Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":135,"context_line":"        e \u003d self.assertRaises(exceptions.BadRequest, self.create_subnet, net,"},{"line_number":136,"context_line":"                              client\u003dself.admin_client)"},{"line_number":137,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":138,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_512f14f6","line":137,"updated":"2017-07-28 17:42:10.000000000","message":"I don\u0027t think we should validate against a exception class name here. A mere return code is enough.","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":134,"context_line":"                segment_id\u003dsegment[\u0027segment\u0027][\u0027id\u0027])"},{"line_number":135,"context_line":"        e \u003d self.assertRaises(exceptions.BadRequest, self.create_subnet, net,"},{"line_number":136,"context_line":"                              client\u003dself.admin_client)"},{"line_number":137,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":138,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_8b05417d","line":137,"in_reply_to":"df3967d1_512f14f6","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":138,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":141,"context_line":"    def test_delete_network_cascade(self):"},{"line_number":142,"context_line":"        net \u003d self._create_vxlan_provider_network()"},{"line_number":143,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_f1e5e80b","line":140,"updated":"2017-07-28 17:42:10.000000000","message":"missing uuid","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        self.assertEqual(\u0027SubnetsNotAllAssociatedWithSegments\u0027,"},{"line_number":138,"context_line":"            e.resp_body[\u0027type\u0027])"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    @test.requires_ext(extension\u003d\"segment\", service\u003d\"network\")"},{"line_number":141,"context_line":"    def test_delete_network_cascade(self):"},{"line_number":142,"context_line":"        net \u003d self._create_vxlan_provider_network()"},{"line_number":143,"context_line":"        segment \u003d self.admin_client.create_segment("}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_da6559e3","line":140,"in_reply_to":"df3967d1_f1e5e80b","updated":"2017-07-28 21:11:36.000000000","message":"Whoops, fixed","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.admin_client.show_network(net[\u0027id\u0027])"},{"line_number":151,"context_line":"        e \u003d self.assertRaises(exceptions.NotFound, self.show_network, net,"},{"line_number":152,"context_line":"                              client\u003dself.admin_client)"},{"line_number":153,"context_line":"        self.assertEqual(\u0027NetworkNotFound\u0027, e.resp_body[\u0027type\u0027])"},{"line_number":154,"context_line":"        self.admin_client.show_subnet(subnet[\u0027id\u0027])"},{"line_number":155,"context_line":"        e \u003d self.assertRaises(exceptions.NotFound, self.show_subnet, subnet,"},{"line_number":156,"context_line":"                              client\u003dself.admin_client)"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_310db090","line":153,"updated":"2017-07-28 17:42:10.000000000","message":"ditto for exception class name","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":150,"context_line":"        self.admin_client.show_network(net[\u0027id\u0027])"},{"line_number":151,"context_line":"        e \u003d self.assertRaises(exceptions.NotFound, self.show_network, net,"},{"line_number":152,"context_line":"                              client\u003dself.admin_client)"},{"line_number":153,"context_line":"        self.assertEqual(\u0027NetworkNotFound\u0027, e.resp_body[\u0027type\u0027])"},{"line_number":154,"context_line":"        self.admin_client.show_subnet(subnet[\u0027id\u0027])"},{"line_number":155,"context_line":"        e \u003d self.assertRaises(exceptions.NotFound, self.show_subnet, subnet,"},{"line_number":156,"context_line":"                              client\u003dself.admin_client)"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_2bd535ba","line":153,"in_reply_to":"df3967d1_310db090","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"7870abf5f918533a4cdfa75751ca0f6b172b8578","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.admin_client.show_subnet(subnet[\u0027id\u0027])"},{"line_number":155,"context_line":"        e \u003d self.assertRaises(exceptions.NotFound, self.show_subnet, subnet,"},{"line_number":156,"context_line":"                              client\u003dself.admin_client)"},{"line_number":157,"context_line":"        self.assertEqual(\u0027SubnetNotFound\u0027, e.resp_body[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_711338ba","line":157,"updated":"2017-07-28 17:42:10.000000000","message":"ditto for exception class name","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"af6bebafa30aa8633cd34085b414b53d7fb9f437","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        self.admin_client.show_subnet(subnet[\u0027id\u0027])"},{"line_number":155,"context_line":"        e \u003d self.assertRaises(exceptions.NotFound, self.show_subnet, subnet,"},{"line_number":156,"context_line":"                              client\u003dself.admin_client)"},{"line_number":157,"context_line":"        self.assertEqual(\u0027SubnetNotFound\u0027, e.resp_body[\u0027type\u0027])"}],"source_content_type":"text/x-python","patch_set":52,"id":"df3967d1_0bda71e8","line":157,"in_reply_to":"df3967d1_711338ba","updated":"2017-07-28 21:11:36.000000000","message":"Done","commit_id":"dc798f84aa4da858b2e8676c6ff7f9f037bd789b"}],"neutron/tests/tempest/api/base.py":[{"author":{"_account_id":7448,"name":"Carl Baldwin","email":"carl@ecbaldwin.net","username":"carl-baldwin"},"change_message_id":"672d04ef8330dd2f6cc03ab2cb96b0c7f976b657","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        return subnet"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @classmethod"},{"line_number":286,"context_line":"    def create_port(cls, network, client\u003dNone, **kwargs):"},{"line_number":287,"context_line":"        \"\"\"Wrapper utility that returns a test port.\"\"\""},{"line_number":288,"context_line":"        client \u003d client or cls.client"},{"line_number":289,"context_line":"        body \u003d client.create_port(network_id\u003dnetwork[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"fa6399be_e6b8a02c","line":286,"range":{"start_line":286,"start_character":34,"end_line":286,"end_character":46},"updated":"2016-10-14 20:03:06.000000000","message":"I don\u0027t like the way this is written. You pass the client but then below it assumes that if you passed a client, you\u0027re creating an admin port and it will clean up the ports using the admin client.\n\nWhy not just have something like \"use_admin\u003dFalse\" here and pass that?","commit_id":"42a824a6cc3251bf260c3a790ddc628d3b23d198"},{"author":{"_account_id":20277,"name":"James Anziano","email":"janzian@us.ibm.com","username":"janzian"},"change_message_id":"3d0a83217ff5e64839fb3613436c983761289969","unresolved":false,"context_lines":[{"line_number":283,"context_line":"        return subnet"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    @classmethod"},{"line_number":286,"context_line":"    def create_port(cls, network, client\u003dNone, **kwargs):"},{"line_number":287,"context_line":"        \"\"\"Wrapper utility that returns a test port.\"\"\""},{"line_number":288,"context_line":"        client \u003d client or cls.client"},{"line_number":289,"context_line":"        body \u003d client.create_port(network_id\u003dnetwork[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":24,"id":"da6895a0_3583079a","line":286,"range":{"start_line":286,"start_character":34,"end_line":286,"end_character":46},"in_reply_to":"fa6399be_e6b8a02c","updated":"2016-10-25 16:17:11.000000000","message":"I see what you\u0027re saying, I agree using the admin client as the default assumption in the if/else clause is a bit odd. I still prefer passing the client explicitly rather than using a flag to denote which client, so I\u0027ve rewritten the if/else to use an else if and test explicitly for the admin client. I feel like that\u0027s keeping best of both worlds, let me know what you think.","commit_id":"42a824a6cc3251bf260c3a790ddc628d3b23d198"}]}
