)]}'
{"neutron/agent/l3/router_info.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"f2b2ff1eb8cbbca4b35259baeaba00349175e381","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import collections"},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron._i18n import _, _LE, _LW"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_eb4c7378","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":50},"updated":"2016-08-15 08:34:33.000000000","message":"Do we need to refer to neutron_lib.constants by \u0027lib_constants\u0027?\nin some modules we use \u0027constants\u0027 and in other modules we use lib_constatns. Any guideline?","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6e56e8e5827756462e27090b064c5e0dbc7fac81","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"import collections"},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":18,"context_line":"from oslo_log import log as logging"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from neutron._i18n import _, _LE, _LW"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_c2907198","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":50},"in_reply_to":"3ac371cc_eb4c7378","updated":"2016-08-15 11:48:03.000000000","message":"i think that we should be using lib_constants\nmaybe in an additional patch we can refcator the constants to lib_constants. I feel that that is more self explanatory","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"}],"neutron/agent/linux/dhcp.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97976d1bb8a4ed2924152ff598bbff9f0914d9d8","unresolved":false,"context_lines":[{"line_number":770,"context_line":"            addr_mode \u003d getattr(subnet, \u0027ipv6_address_mode\u0027, None)"},{"line_number":771,"context_line":"            if (not subnet.enable_dhcp or"},{"line_number":772,"context_line":"                (subnet.ip_version \u003d\u003d 6 and"},{"line_number":773,"context_line":"                 addr_mode \u003d\u003d lib_constants.IPV6_SLAAC)):"},{"line_number":774,"context_line":"                continue"},{"line_number":775,"context_line":"            if subnet.dns_nameservers:"},{"line_number":776,"context_line":"                options.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_b506d983","line":773,"updated":"2016-08-10 16:36:15.000000000","message":"s/lib_constants/constants","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"48436f5ad12d571c2aef369d61ac97565329c3de","unresolved":false,"context_lines":[{"line_number":770,"context_line":"            addr_mode \u003d getattr(subnet, \u0027ipv6_address_mode\u0027, None)"},{"line_number":771,"context_line":"            if (not subnet.enable_dhcp or"},{"line_number":772,"context_line":"                (subnet.ip_version \u003d\u003d 6 and"},{"line_number":773,"context_line":"                 addr_mode \u003d\u003d lib_constants.IPV6_SLAAC)):"},{"line_number":774,"context_line":"                continue"},{"line_number":775,"context_line":"            if subnet.dns_nameservers:"},{"line_number":776,"context_line":"                options.append("}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_dc7a9276","line":773,"in_reply_to":"9ad45d7e_b506d983","updated":"2016-08-10 18:23:09.000000000","message":"Done","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"}],"neutron/api/v2/router.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97976d1bb8a4ed2924152ff598bbff9f0914d9d8","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron import policy"},{"line_number":30,"context_line":"from neutron.quota import resource_registry"},{"line_number":31,"context_line":"from neutron import wsgi"},{"line_number":32,"context_line":"from neutron_lib import constants"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RESOURCES \u003d {\u0027network\u0027: \u0027networks\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_15ca454e","line":32,"updated":"2016-08-10 16:36:15.000000000","message":"Should move above L16","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"48436f5ad12d571c2aef369d61ac97565329c3de","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from neutron import policy"},{"line_number":30,"context_line":"from neutron.quota import resource_registry"},{"line_number":31,"context_line":"from neutron import wsgi"},{"line_number":32,"context_line":"from neutron_lib import constants"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"RESOURCES \u003d {\u0027network\u0027: \u0027networks\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_bcf6bef6","line":32,"in_reply_to":"9ad45d7e_15ca454e","updated":"2016-08-10 18:23:09.000000000","message":"Done","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"}],"neutron/common/constants.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3b76edd688b8622ceb008d7e96bfe942fb8e36c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9ad45d7e_ab7e6316","side":"PARENT","updated":"2016-08-11 04:15:56.000000000","message":"This should probably be done in a separate patch.","commit_id":"2a05b28c05c6509db9b5b3e543df33373f2f996b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"7ef36195e76c5e1aba31007fdf4c032fbee94c23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9ad45d7e_cbcc60bd","side":"PARENT","in_reply_to":"9ad45d7e_ab7e6316","updated":"2016-08-11 12:40:26.000000000","message":"I agree, how about we split out when you pull the -2?","commit_id":"2a05b28c05c6509db9b5b3e543df33373f2f996b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3fc1e1a6b47c75c836ec8c7252a96ae628031746","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9ad45d7e_497821f9","side":"PARENT","in_reply_to":"9ad45d7e_cbcc60bd","updated":"2016-08-12 17:46:19.000000000","message":"Addressed by https://review.openstack.org/354833","commit_id":"2a05b28c05c6509db9b5b3e543df33373f2f996b"}],"neutron/conf/agent/l3/config.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97976d1bb8a4ed2924152ff598bbff9f0914d9d8","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _"},{"line_number":20,"context_line":"from neutron.agent.common import config"},{"line_number":21,"context_line":"from neutron_lib import constants"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_75ac618c","line":21,"updated":"2016-08-10 16:36:15.000000000","message":"Should move above L17","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"48436f5ad12d571c2aef369d61ac97565329c3de","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from neutron._i18n import _"},{"line_number":20,"context_line":"from neutron.agent.common import config"},{"line_number":21,"context_line":"from neutron_lib import constants"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_fcc31687","line":21,"in_reply_to":"9ad45d7e_75ac618c","updated":"2016-08-10 18:23:09.000000000","message":"Done","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"}],"neutron/db/models_v2.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97976d1bb8a4ed2924152ff598bbff9f0914d9d8","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.db.network_dhcp_agent_binding import models as ndab_model"},{"line_number":24,"context_line":"from neutron.db import rbac_db_models"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# NOTE(kevinbenton): these are here for external projects that expect them"},{"line_number":29,"context_line":"# to be found in this module."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_55515dd7","line":26,"updated":"2016-08-10 16:36:15.000000000","message":"Should be up above L16\n\nnit: can you make it n_const to match most of the other similar ones","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"48436f5ad12d571c2aef369d61ac97565329c3de","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from neutron.db.network_dhcp_agent_binding import models as ndab_model"},{"line_number":24,"context_line":"from neutron.db import rbac_db_models"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"# NOTE(kevinbenton): these are here for external projects that expect them"},{"line_number":29,"context_line":"# to be found in this module."}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_dc3f3285","line":26,"in_reply_to":"9ad45d7e_55515dd7","updated":"2016-08-10 18:23:09.000000000","message":"Done and yeah, sure on the nit (I went l_const because it made more sense to me)","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c1ac1b1623748cdc96c0c68bfbe22afd30f5e718","unresolved":false,"context_lines":[{"line_number":219,"context_line":"                                          constants.DHCPV6_STATEFUL,"},{"line_number":220,"context_line":"                                          constants.DHCPV6_STATELESS,"},{"line_number":221,"context_line":"                                          name\u003d\u0027ipv6_address_modes\u0027),"},{"line_number":222,"context_line":"                                  nullable\u003dTrue)"},{"line_number":223,"context_line":"    # subnets don\u0027t have their own rbac_entries, they just inherit from"},{"line_number":224,"context_line":"    # the network rbac entries"},{"line_number":225,"context_line":"    rbac_entries \u003d orm.relationship("}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_eb875310","line":222,"updated":"2016-08-15 08:57:06.000000000","message":"looks unrelated, but I tend to say okay...","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"}],"neutron/objects/common_types.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97976d1bb8a4ed2924152ff598bbff9f0914d9d8","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.common import constants"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":23,"context_line":"from neutron_lib import exceptions"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class NeutronRangeConstrainedIntegerInvalidLimit(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d5126d08","line":23,"updated":"2016-08-10 16:36:15.000000000","message":"See L15 :)","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"48436f5ad12d571c2aef369d61ac97565329c3de","unresolved":false,"context_lines":[{"line_number":20,"context_line":"from neutron.common import constants"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from neutron_lib import constants as lib_constants"},{"line_number":23,"context_line":"from neutron_lib import exceptions"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"class NeutronRangeConstrainedIntegerInvalidLimit(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_9cd5ba1d","line":23,"in_reply_to":"9ad45d7e_d5126d08","updated":"2016-08-10 18:23:09.000000000","message":"Done","commit_id":"19ee36c200bfcb1c22310015739a6d921d36e174"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c1ac1b1623748cdc96c0c68bfbe22afd30f5e718","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import itertools"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from neutron_lib import exceptions"},{"line_number":19,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":20,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_2bb04bdd","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":44},"updated":"2016-08-15 08:57:06.000000000","message":"In most other places, we use constants or lib_constants to refer to neutron_lib.constants. I don\u0027t want to see more variation.. How about renaming existing n_const to constants?","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6e56e8e5827756462e27090b064c5e0dbc7fac81","unresolved":false,"context_lines":[{"line_number":14,"context_line":"import itertools"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"from neutron_lib import constants as n_const"},{"line_number":18,"context_line":"from neutron_lib import exceptions"},{"line_number":19,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":20,"context_line":"import six"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_a2bbb50d","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":44},"in_reply_to":"3ac371cc_2bb04bdd","updated":"2016-08-15 11:48:03.000000000","message":"Can we go with lib_constants. constants are used below in line 23","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"}],"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":7787,"name":"Kevin Benton","email":"kevin@benton.pub","username":"blak111"},"change_message_id":"43ba355dcdabee0e948c1a5406fcc82b7e3e2f44","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.functional.agent.l3 import framework"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DEVICE_OWNER_COMPUTE \u003d lib_cosnatnts.DEVICE_OWNER_COMPUTE_PREFIX + \u0027fake\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestDvrRouter(framework.L3AgentTestFramework):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_0b15cce3","line":39,"updated":"2016-08-18 08:56:53.000000000","message":"what is a cosnatnt ?","commit_id":"6d27acec261540ec9de2acc2e04c84ea602437d1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e4a14ee811f2ff6579552ffd7a910b1d030ba1e1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"from neutron.tests.functional.agent.l3 import framework"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"DEVICE_OWNER_COMPUTE \u003d lib_cosnatnts.DEVICE_OWNER_COMPUTE_PREFIX + \u0027fake\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"class TestDvrRouter(framework.L3AgentTestFramework):"}],"source_content_type":"text/x-python","patch_set":13,"id":"3ac371cc_e68fbe72","line":39,"in_reply_to":"3ac371cc_0b15cce3","updated":"2016-08-18 10:47:34.000000000","message":"Done","commit_id":"6d27acec261540ec9de2acc2e04c84ea602437d1"}],"neutron/tests/unit/db/test_api.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cc0fe20bd2b15ba47020e6691aa0f8405775a79e","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from sqlalchemy.orm import exc"},{"line_number":22,"context_line":"import testtools"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# from neutron.common import exceptions"},{"line_number":25,"context_line":"from neutron.db import api as db_api"},{"line_number":26,"context_line":"from neutron.tests import base"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"fa7ab95a_1cc55f8d","line":24,"updated":"2016-08-27 01:17:12.000000000","message":"oops","commit_id":"e5806b5b2dcec615d315d31e7dbd4c34d889eef9"}],"neutron/tests/unit/hacking/test_checks.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"c1ac1b1623748cdc96c0c68bfbe22afd30f5e718","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                1, len(list(checks.check_assertempty(fail_code % (ec, ec),"},{"line_number":250,"context_line":"                                            \"neutron/tests/test_assert.py\"))))"},{"line_number":251,"context_line":"            self.assertEqual("},{"line_number":252,"context_line":"                0, len(list(checks.check_asserttruefalse(pass_code1 % (ec, ec),"},{"line_number":253,"context_line":"                                            \"neutron/tests/test_assert.py\"))))"},{"line_number":254,"context_line":"            self.assertEqual("},{"line_number":255,"context_line":"                0, len(list(checks.check_asserttruefalse(pass_code2 % ec,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_4bf667d8","line":252,"updated":"2016-08-15 08:57:06.000000000","message":"Is this related to this change?","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"6e56e8e5827756462e27090b064c5e0dbc7fac81","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                1, len(list(checks.check_assertempty(fail_code % (ec, ec),"},{"line_number":250,"context_line":"                                            \"neutron/tests/test_assert.py\"))))"},{"line_number":251,"context_line":"            self.assertEqual("},{"line_number":252,"context_line":"                0, len(list(checks.check_asserttruefalse(pass_code1 % (ec, ec),"},{"line_number":253,"context_line":"                                            \"neutron/tests/test_assert.py\"))))"},{"line_number":254,"context_line":"            self.assertEqual("},{"line_number":255,"context_line":"                0, len(list(checks.check_asserttruefalse(pass_code2 % ec,"}],"source_content_type":"text/x-python","patch_set":10,"id":"3ac371cc_020569c1","line":252,"in_reply_to":"3ac371cc_4bf667d8","updated":"2016-08-15 11:48:03.000000000","message":"No, it is not. Not sure how that snuck in here","commit_id":"87e01b66dc8441bda8d215d8be3492b80f4faac2"}]}
