)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ea9740284fa8f6b386c10281116ca126aa598afc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"OVO Introduce Network Segment OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating Network Segment Object."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7708b7a50aa9c9c72bdd1eb5bf9dffd9a43e9285"},{"line_number":12,"context_line":"Co-Authored-By: Artur Korzeniewski\u003cartur.korzeniewski@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_1589a5c9","line":10,"updated":"2016-08-10 16:55:28.000000000","message":"Need to add the following line: \nPartially-Implements: blueprint adopt-oslo-versioned-objects-for-db\n\nPlease see: http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#commit-messages","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6047d48c1d942df220e6f3ff14b368719dee4852","unresolved":false,"context_lines":[{"line_number":7,"context_line":"OVO Introduce Network Segment OVO"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Creating Network Segment Object."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: I7708b7a50aa9c9c72bdd1eb5bf9dffd9a43e9285"},{"line_number":12,"context_line":"Co-Authored-By: Artur Korzeniewski\u003cartur.korzeniewski@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ad45d7e_94d0dc20","line":10,"in_reply_to":"9ad45d7e_1589a5c9","updated":"2016-08-11 06:46:31.000000000","message":"Done","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"}],"neutron/objects/network/network_segment.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ea9740284fa8f6b386c10281116ca126aa598afc","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import segments_db"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_c8ae5497","line":18,"updated":"2016-08-10 16:55:28.000000000","message":"There is another patchset in-flight (https://review.openstack.org/#/c/352226) that is moving this model to neutron/db/models/segment.py. I think you should make this patchset directly depend on the other one","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"c1d9233f266aaf893eabf745963278ced8e00855","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import segments_db"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_f637b24a","line":18,"in_reply_to":"9ad45d7e_c8ae5497","updated":"2016-08-10 19:49:41.000000000","message":"+1 lavalle, it would be good to make it dependent on one refactoring segment and given it is just a single object so object integration can be done in same patch.","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6047d48c1d942df220e6f3ff14b368719dee4852","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import segments_db"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_54a9448f","line":18,"in_reply_to":"9ad45d7e_f637b24a","updated":"2016-08-11 06:46:31.000000000","message":"Done in PS3.","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"ea9740284fa8f6b386c10281116ca126aa598afc","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # Version 1.0: Initial version"},{"line_number":25,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    db_model \u003d segments_db.NetworkSegment"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_489b8472","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":26},"updated":"2016-08-10 16:55:28.000000000","message":"Please see my comment to L18","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"6047d48c1d942df220e6f3ff14b368719dee4852","unresolved":false,"context_lines":[{"line_number":24,"context_line":"    # Version 1.0: Initial version"},{"line_number":25,"context_line":"    VERSION \u003d \u00271.0\u0027"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"    db_model \u003d segments_db.NetworkSegment"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    fields \u003d {"},{"line_number":30,"context_line":"        \u0027id\u0027: obj_fields.UUIDField(),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_b49a406c","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":26},"in_reply_to":"9ad45d7e_489b8472","updated":"2016-08-11 06:46:31.000000000","message":"Done in PS3.","commit_id":"dfc5838fbc210257dab95614bc9ce47c73ff5c58"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"4c3c83e9221ecd08f7e5ed1aae35baa39ccb0214","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import segments_db"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_7918d375","line":18,"updated":"2016-08-10 20:01:30.000000000","message":"I noticed that you decided not to implement my suggestion for this line in PS1. That is perfectly fine. You may have a very good reason not to follow a re-viewer\u0027s suggestion. However, it is recommended that you respond to each reviewer comment: http://docs.openstack.org/developer/neutron/devref/effective_neutron.html#reviewer-comments. The review process is supposed to be dialogue between the submitter and the reviewers, with the aim to produce quality software. Responding to comments helps to make this dialogue useful ;-)","commit_id":"c77ef81283fd508a0ae43d7fc99199b82c278d2b"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"18ddc24026403fc6df1b430ca2d840f0810bd8ec","unresolved":false,"context_lines":[{"line_number":15,"context_line":"from oslo_versionedobjects import base as obj_base"},{"line_number":16,"context_line":"from oslo_versionedobjects import fields as obj_fields"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"from neutron.db import segments_db"},{"line_number":19,"context_line":"from neutron.objects import base"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_54db044f","line":18,"in_reply_to":"9ad45d7e_7918d375","updated":"2016-08-11 06:45:39.000000000","message":"Done in PS3.","commit_id":"c77ef81283fd508a0ae43d7fc99199b82c278d2b"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"81cdfb4db49dc07a6512063cec13dcffd9e36981","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 OpenStack Foundation.  All rights reserved."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"},{"line_number":5,"context_line":"#    a copy of the License at"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_0a7778a0","line":2,"range":{"start_line":1,"start_character":44,"end_line":2,"end_character":1},"updated":"2016-08-18 12:29:54.000000000","message":"Should be on a separate line. But since you don\u0027t even work for the foundation, let\u0027s kill lines 1-2 completely.","commit_id":"50135488c7923ea948ca7d62e0a7b86a46d3481c"},{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"a950e1a3b18bcc3ed77277036d9869bdcb08feb0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3ac371cc_c8339612","line":38,"updated":"2016-08-18 16:24:42.000000000","message":"I was thinking if we need to sort the get_objects output by segment_index, like here [1], in order to have usable output while using the NetworkSegment in Network object fields. But it can be added later, in overriding the get_objects method. \n\n[1] https://github.com/openstack/neutron/blob/master/neutron/db/segments_db.py#L102","commit_id":"6c12a521bc1fa742db724207e6ced16ca247e05c"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"4a6745b3963b23d447e590d6999e23dee5543147","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1ac06dbe_0f0c8893","line":38,"in_reply_to":"3ac371cc_c8339612","updated":"2016-08-19 12:32:44.000000000","message":"Makes sense, but probably in network patch.","commit_id":"6c12a521bc1fa742db724207e6ced16ca247e05c"}],"neutron/tests/unit/objects/test_network_segment.py":[{"author":{"_account_id":15518,"name":"Artur Korzeniewski","email":"artur.korzen@wp.pl","username":"akorzeni"},"change_message_id":"18ddc24026403fc6df1b430ca2d840f0810bd8ec","unresolved":false,"context_lines":[{"line_number":22,"context_line":"    _test_class \u003d network_segment.NetworkSegment"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"class NetworkSegmentDbObjectTestCase(obj_test_base._BaseObjectTestCase,"},{"line_number":26,"context_line":"                                   testlib_api.SqlTestCase):"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"    _test_class \u003d network_segment.NetworkSegment"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_d9756dfa","line":25,"range":{"start_line":25,"start_character":6,"end_line":25,"end_character":36},"updated":"2016-08-11 06:45:39.000000000","message":"This class was not invoked in unit tests.","commit_id":"c77ef81283fd508a0ae43d7fc99199b82c278d2b"}]}