)]}'
{"neutron/tests/functional/agent/l3/test_dvr_router.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"db86d0118ee40ab6bfdf2a1a130ff7cf6c6875e1","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":103,"context_line":"            self.assertEqual(3, len(ip4_rules_list))"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            self._assert_snat_namespace_exists(router1)"},{"line_number":106,"context_line":"            self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":107,"context_line":"            ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":108,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":109,"context_line":"            self.assertEqual(5, len(ip4_rules_list))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_dvr_gateway_clear_removes_gateway_redirect_rules(self):"},{"line_number":112,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_25a1b794","line":109,"range":{"start_line":105,"start_character":12,"end_line":109,"end_character":52},"updated":"2016-08-12 07:37:55.000000000","message":"this block should check the case with \u0027gw_port_host\u0027 change and gw_port still existing.","commit_id":"e3991db18fe4b505834db3f1138f883dfea8a811"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9b523f48e7cff4b6c9ac007f4b58950a0cc01448","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":103,"context_line":"            self.assertEqual(3, len(ip4_rules_list))"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            self._assert_snat_namespace_exists(router1)"},{"line_number":106,"context_line":"            self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":107,"context_line":"            ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":108,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":109,"context_line":"            self.assertEqual(5, len(ip4_rules_list))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_dvr_gateway_clear_removes_gateway_redirect_rules(self):"},{"line_number":112,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_f8ca8619","line":109,"range":{"start_line":105,"start_character":12,"end_line":109,"end_character":52},"in_reply_to":"9ad45d7e_25a1b794","updated":"2016-08-12 15:41:47.000000000","message":"will add another test function to show the gw_port_host.","commit_id":"e3991db18fe4b505834db3f1138f883dfea8a811"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"db86d0118ee40ab6bfdf2a1a130ff7cf6c6875e1","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self._test_setup_dvr_gateway_redirect_rules_remove(gateway_port\u003dFalse)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_dvr_gateway_does_add_gateway_redirect_rules(self):"},{"line_number":116,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""},{"line_number":117,"context_line":"        self._test_setup_dvr_gateway_redirect_rules_remove()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_dvr_router_fips_stale_gw_port(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_65a72fa7","line":116,"range":{"start_line":116,"start_character":11,"end_line":116,"end_character":74},"updated":"2016-08-12 07:37:55.000000000","message":"to be updated","commit_id":"e3991db18fe4b505834db3f1138f883dfea8a811"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9b523f48e7cff4b6c9ac007f4b58950a0cc01448","unresolved":false,"context_lines":[{"line_number":113,"context_line":"        self._test_setup_dvr_gateway_redirect_rules_remove(gateway_port\u003dFalse)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_dvr_gateway_does_add_gateway_redirect_rules(self):"},{"line_number":116,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""},{"line_number":117,"context_line":"        self._test_setup_dvr_gateway_redirect_rules_remove()"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def test_dvr_router_fips_stale_gw_port(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_98da6ae8","line":116,"range":{"start_line":116,"start_character":11,"end_line":116,"end_character":74},"in_reply_to":"9ad45d7e_65a72fa7","updated":"2016-08-12 15:41:47.000000000","message":"fixed.","commit_id":"e3991db18fe4b505834db3f1138f883dfea8a811"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"213c6e1987e838272d10db7c26056e2e5888ef74","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":102,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":103,"context_line":"            self.assertEqual(3, len(ip4_rules_list))"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            self._assert_snat_namespace_exists(router1)"},{"line_number":106,"context_line":"            self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":107,"context_line":"            ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":108,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":109,"context_line":"            self.assertEqual(5, len(ip4_rules_list))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_dvr_gateway_clear_removes_gateway_redirect_rules(self):"},{"line_number":112,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"7ac969e8_bcd76e22","line":109,"range":{"start_line":104,"start_character":8,"end_line":109,"end_character":52},"updated":"2016-08-13 06:13:47.000000000","message":"this doesn\u0027t need to be in \u0027else\u0027, it can go right after #93 and hence \u0027gateway_port\u0027 doesn\u0027t make sense. That\u0027s why I suggested to handle gw_port_host change here","commit_id":"d7877121d004bc6cb644c810d805496a112b32c5"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"177294672e641016db599f87fa5c5cd88699f598","unresolved":false,"context_lines":[{"line_number":101,"context_line":"            ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":102,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":103,"context_line":"            self.assertEqual(3, len(ip4_rules_list))"},{"line_number":104,"context_line":"        else:"},{"line_number":105,"context_line":"            self._assert_snat_namespace_exists(router1)"},{"line_number":106,"context_line":"            self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":107,"context_line":"            ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":108,"context_line":"            ip4_rules_list \u003d ns_ipr.rule.list_rules(l3_constants.IP_VERSION_4)"},{"line_number":109,"context_line":"            self.assertEqual(5, len(ip4_rules_list))"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def test_dvr_gateway_clear_removes_gateway_redirect_rules(self):"},{"line_number":112,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_5e872e0f","line":109,"range":{"start_line":104,"start_character":8,"end_line":109,"end_character":52},"in_reply_to":"7ac969e8_bcd76e22","updated":"2016-08-15 15:35:03.000000000","message":"will fix it to remove from the else loop.","commit_id":"d7877121d004bc6cb644c810d805496a112b32c5"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"7f7a9d09c1daffcec3836f9c916c8f115f88a27b","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._assert_dvr_floating_ips(router)"},{"line_number":83,"context_line":"        self._assert_snat_namespace_does_not_exist(router)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _test_setup_dvr_gateway_redirect_rules_remove(self, gateway_port\u003dTrue):"},{"line_number":86,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_bd98ed1c","line":85,"range":{"start_line":85,"start_character":60,"end_line":85,"end_character":77},"updated":"2016-08-27 05:19:11.000000000","message":"seems this parameter and the test at #110 not needed","commit_id":"8efd4a827eaf8e947c9eb6206ac46ef378066c7b"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"880de5ede923cf958fc56956edb2c59916b6e53d","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._assert_dvr_floating_ips(router)"},{"line_number":83,"context_line":"        self._assert_snat_namespace_does_not_exist(router)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def _test_setup_dvr_gateway_redirect_rules_remove(self, gateway_port\u003dTrue):"},{"line_number":86,"context_line":"        \"\"\"Test to validate snat redirect rules cleared with gateway clear.\"\"\""},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"fa7ab95a_5725b206","line":85,"range":{"start_line":85,"start_character":60,"end_line":85,"end_character":77},"in_reply_to":"fa7ab95a_bd98ed1c","updated":"2016-08-29 18:20:33.000000000","message":"Done","commit_id":"8efd4a827eaf8e947c9eb6206ac46ef378066c7b"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"53a434db432e02ec8db4a0269d8866529ec36ac4","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":89,"context_line":"        router_info \u003d self.generate_dvr_router_info("},{"line_number":90,"context_line":"            enable_snat\u003dTrue, enable_gw\u003dTrue)"},{"line_number":91,"context_line":"        router_info[lib_constants.FLOATINGIP_KEY] \u003d []"},{"line_number":92,"context_line":"        router_info[n_const.FLOATINGIP_AGENT_INTF_KEY] \u003d []"},{"line_number":93,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_c559e18f","line":90,"range":{"start_line":90,"start_character":28,"end_line":90,"end_character":44},"updated":"2016-08-30 10:14:16.000000000","message":"nit: this is default True","commit_id":"fd856c1a63d03c59739810ee7f3aa4a789501c4f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"53a434db432e02ec8db4a0269d8866529ec36ac4","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertTrue(self._namespace_exists(router1.ns_name))"},{"line_number":96,"context_line":"        ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":97,"context_line":"        ip4_rules_list \u003d ns_ipr.rule.list_rules(lib_constants.IP_VERSION_4)"},{"line_number":98,"context_line":"        self.assertEqual(5, len(ip4_rules_list))"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_dvr_gateway_set_adds_gateway_redirect_rules(self):"},{"line_number":101,"context_line":"        \"\"\"Test to validate snat redirect rules applied with gateway set.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_a5693dfb","line":98,"range":{"start_line":98,"start_character":25,"end_line":98,"end_character":26},"updated":"2016-08-30 10:14:16.000000000","message":"Maybe better to explain why it is 5 here. Or just use one test case, and assert the number it not changed.","commit_id":"fd856c1a63d03c59739810ee7f3aa4a789501c4f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"66de861ce71354e7c100a073995982da00150cde","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_dvr_gateway_set_adds_gateway_redirect_rules(self):"},{"line_number":101,"context_line":"        \"\"\"Test to validate snat redirect rules applied with gateway set.\"\"\""},{"line_number":102,"context_line":"        self._test_setup_dvr_gateway_redirect_rules_remove()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_dvr_gateway_move_does_not_remove_redirect_rules(self):"},{"line_number":105,"context_line":"        \"\"\"Test to validate snat redirect rules not cleared with snat move.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_dede1ddc","line":102,"range":{"start_line":102,"start_character":13,"end_line":102,"end_character":58},"updated":"2016-08-30 08:14:10.000000000","message":"why need helper if used only once?","commit_id":"fd856c1a63d03c59739810ee7f3aa4a789501c4f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"53a434db432e02ec8db4a0269d8866529ec36ac4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        \"\"\"Test to validate snat redirect rules not cleared with snat move.\"\"\""},{"line_number":106,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":107,"context_line":"        router_info \u003d self.generate_dvr_router_info("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dFalse, enable_gw\u003dTrue)"},{"line_number":109,"context_line":"        router_info[lib_constants.FLOATINGIP_KEY] \u003d []"},{"line_number":110,"context_line":"        router_info[n_const.FLOATINGIP_AGENT_INTF_KEY] \u003d []"},{"line_number":111,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_454eb1c1","line":108,"range":{"start_line":108,"start_character":30,"end_line":108,"end_character":61},"updated":"2016-08-30 10:14:16.000000000","message":"nit: these are default values.","commit_id":"fd856c1a63d03c59739810ee7f3aa4a789501c4f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"66de861ce71354e7c100a073995982da00150cde","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_dvr_gateway_move_does_not_remove_redirect_rules(self):"},{"line_number":105,"context_line":"        \"\"\"Test to validate snat redirect rules not cleared with snat move.\"\"\""},{"line_number":106,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":107,"context_line":"        router_info \u003d self.generate_dvr_router_info("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dFalse, enable_gw\u003dTrue)"},{"line_number":109,"context_line":"        router_info[lib_constants.FLOATINGIP_KEY] \u003d []"},{"line_number":110,"context_line":"        router_info[n_const.FLOATINGIP_AGENT_INTF_KEY] \u003d []"},{"line_number":111,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"},{"line_number":112,"context_line":"        router1.router[\u0027gw_port_host\u0027] \u003d \"\""},{"line_number":113,"context_line":"        self.agent._process_updated_router(router1.router)"},{"line_number":114,"context_line":"        router_updated \u003d self.agent.router_info[router1.router[\u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_5e4dad98","line":111,"range":{"start_line":106,"start_character":8,"end_line":111,"end_character":61},"updated":"2016-08-30 08:14:10.000000000","message":"can helper be used here?","commit_id":"fd856c1a63d03c59739810ee7f3aa4a789501c4f"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"53a434db432e02ec8db4a0269d8866529ec36ac4","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def test_dvr_gateway_move_does_not_remove_redirect_rules(self):"},{"line_number":105,"context_line":"        \"\"\"Test to validate snat redirect rules not cleared with snat move.\"\"\""},{"line_number":106,"context_line":"        self.agent.conf.agent_mode \u003d \u0027dvr_snat\u0027"},{"line_number":107,"context_line":"        router_info \u003d self.generate_dvr_router_info("},{"line_number":108,"context_line":"            enable_snat\u003dTrue, enable_ha\u003dFalse, enable_gw\u003dTrue)"},{"line_number":109,"context_line":"        router_info[lib_constants.FLOATINGIP_KEY] \u003d []"},{"line_number":110,"context_line":"        router_info[n_const.FLOATINGIP_AGENT_INTF_KEY] \u003d []"},{"line_number":111,"context_line":"        router1 \u003d self.manage_router(self.agent, router_info)"},{"line_number":112,"context_line":"        router1.router[\u0027gw_port_host\u0027] \u003d \"\""},{"line_number":113,"context_line":"        self.agent._process_updated_router(router1.router)"},{"line_number":114,"context_line":"        router_updated \u003d self.agent.router_info[router1.router[\u0027id\u0027]]"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa7ab95a_e53d05de","line":111,"range":{"start_line":106,"start_character":8,"end_line":111,"end_character":61},"in_reply_to":"fa7ab95a_5e4dad98","updated":"2016-08-30 10:14:16.000000000","message":"+1","commit_id":"fd856c1a63d03c59739810ee7f3aa4a789501c4f"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"3ef8d088dfd7db503439013ede1b8aa48e048f26","unresolved":false,"context_lines":[{"line_number":95,"context_line":"        self.assertTrue(self._namespace_exists(router_updated.ns_name))"},{"line_number":96,"context_line":"        ns_ipr \u003d ip_lib.IPRule(namespace\u003drouter1.ns_name)"},{"line_number":97,"context_line":"        ip4_rules_list \u003d ns_ipr.rule.list_rules(lib_constants.IP_VERSION_4)"},{"line_number":98,"context_line":"        self.assertEqual(5, len(ip4_rules_list))"},{"line_number":99,"context_line":"        # IPRule list should have 5 entries."},{"line_number":100,"context_line":"        # Three entries from \u0027default\u0027, \u0027main\u0027 and \u0027local\u0027 table."},{"line_number":101,"context_line":"        # The remaining 2 is for the two router interfaces(csnat ports)."}],"source_content_type":"text/x-python","patch_set":8,"id":"fa7ab95a_2457a8cb","line":98,"range":{"start_line":98,"start_character":8,"end_line":98,"end_character":48},"updated":"2016-08-31 09:02:01.000000000","message":"nit: should be after the comment below","commit_id":"82c134d6e06fb47ffc923880ed597bddb7a06013"}],"neutron/tests/unit/agent/l3/test_agent.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"d2974d17eab8ae487af122338114624080d7daab","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                    namespace\u003dmock.ANY,"},{"line_number":563,"context_line":"                    prefix\u003dmock.ANY)"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                if ri.router.get(\u0027gw_port\u0027) is None:"},{"line_number":566,"context_line":"                    ri._snat_redirect_remove.assert_called_with("},{"line_number":567,"context_line":"                        sn_port, sn_port,"},{"line_number":568,"context_line":"                        ri.get_internal_device_name(sn_port[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_bd185c1f","line":565,"range":{"start_line":565,"start_character":16,"end_line":565,"end_character":52},"updated":"2016-08-11 09:23:07.000000000","message":"this passes without the fix, please add a test that catches the bug","commit_id":"ce189cef5c1a1e153b90e30bf4a4d4f32ded8726"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"acd64b755618d585a0a0d864485cb3e4d89d89de","unresolved":false,"context_lines":[{"line_number":562,"context_line":"                    namespace\u003dmock.ANY,"},{"line_number":563,"context_line":"                    prefix\u003dmock.ANY)"},{"line_number":564,"context_line":"            else:"},{"line_number":565,"context_line":"                if ri.router.get(\u0027gw_port\u0027) is None:"},{"line_number":566,"context_line":"                    ri._snat_redirect_remove.assert_called_with("},{"line_number":567,"context_line":"                        sn_port, sn_port,"},{"line_number":568,"context_line":"                        ri.get_internal_device_name(sn_port[\u0027id\u0027]))"}],"source_content_type":"text/x-python","patch_set":1,"id":"9ad45d7e_80087a29","line":565,"range":{"start_line":565,"start_character":16,"end_line":565,"end_character":52},"in_reply_to":"9ad45d7e_bd185c1f","updated":"2016-08-11 19:18:45.000000000","message":"will fix it.","commit_id":"ce189cef5c1a1e153b90e30bf4a4d4f32ded8726"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"db86d0118ee40ab6bfdf2a1a130ff7cf6c6875e1","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                             \u0027network_id\u0027: ex_net_id,"},{"line_number":520,"context_line":"                             \u0027mac_address\u0027: \u0027ca:fe:de:ad:be:ef\u0027}"},{"line_number":521,"context_line":"        interface_name \u003d ri.get_external_device_name(ex_gw_port[\u0027id\u0027])"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        if action \u003d\u003d \u0027add\u0027:"},{"line_number":524,"context_line":"            self._add_external_gateway(ri, router, ex_gw_port, interface_name,"},{"line_number":525,"context_line":"                                       use_fake_fip\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_25c89754","side":"PARENT","line":522,"updated":"2016-08-12 07:37:55.000000000","message":"unrelated","commit_id":"2a05b28c05c6509db9b5b3e543df33373f2f996b"},{"author":{"_account_id":7016,"name":"Swaminathan Vasudevan","email":"swvasude@cisco.com","username":"souminathan"},"change_message_id":"9b523f48e7cff4b6c9ac007f4b58950a0cc01448","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                             \u0027network_id\u0027: ex_net_id,"},{"line_number":520,"context_line":"                             \u0027mac_address\u0027: \u0027ca:fe:de:ad:be:ef\u0027}"},{"line_number":521,"context_line":"        interface_name \u003d ri.get_external_device_name(ex_gw_port[\u0027id\u0027])"},{"line_number":522,"context_line":""},{"line_number":523,"context_line":"        if action \u003d\u003d \u0027add\u0027:"},{"line_number":524,"context_line":"            self._add_external_gateway(ri, router, ex_gw_port, interface_name,"},{"line_number":525,"context_line":"                                       use_fake_fip\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ad45d7e_18edda8e","side":"PARENT","line":522,"in_reply_to":"9ad45d7e_25c89754","updated":"2016-08-12 15:41:47.000000000","message":"Done","commit_id":"2a05b28c05c6509db9b5b3e543df33373f2f996b"}]}
