)]}'
{"neutron/db/migration/alembic_migrations/versions/477a4488d3f4_db_migration_for_ml2.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"be70c15049b9cc87f7eeea5b570aa0fc7a136a17","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.plugins.openvswitch.ovs_neutron_plugin.OVSNeutronPluginV2\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2F22k%3D","line":33,"updated":"2013-07-10 10:19:33.000000000","message":"should migration be performed for OVS plugin, not for ml2?","commit_id":"997039f9bc76d59bbaf4c9aa25ec8c0fad7018c8"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":30,"context_line":"# Change to [\u0027*\u0027] if this migration applies to all plugins"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"migration_for_plugins \u003d ["},{"line_number":33,"context_line":"    \u0027neutron.plugins.openvswitch.ovs_neutron_plugin.OVSNeutronPluginV2\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"from alembic import op"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2F2WQ%3D","line":33,"in_reply_to":"AAAAP3%2F%2F22k%3D","updated":"2013-07-10 13:37:19.000000000","message":"Good catch, and in fact I had thought I had corrected this before pushing out, will do so in the next rebase.","commit_id":"997039f9bc76d59bbaf4c9aa25ec8c0fad7018c8"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\"DB Migration for ML2 VXLAN Type Driver"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 477a4488d3f4"},{"line_number":21,"context_line":"Revises: b7a8863760e"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2Fqqc%3D","line":18,"updated":"2013-07-14 22:27:51.000000000","message":"Remove \"DB Migration for\" from the description, or just rename this file to 477a4488d3f4_ml2_vxlan_type_driver.py","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":"#"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"\"\"\"DB Migration for ML2 VXLAN Type Driver"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 477a4488d3f4"},{"line_number":21,"context_line":"Revises: b7a8863760e"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqaQ%3D","line":18,"in_reply_to":"AAAAP3%2F%2Fqqc%3D","updated":"2013-07-15 02:05:04.000000000","message":"Done","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"}],"neutron/db/migration/alembic_migrations/versions/477a4488d3f4_ml2_vxlan_type_driver.py":[{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \u0027ml2_vxlan_allocations\u0027,"},{"line_number":49,"context_line":"        sa.Column(\u0027vxlan_vni\u0027, sa.Integer, nullable\u003dFalse,"},{"line_number":50,"context_line":"                  autoincrement\u003dFalse),"},{"line_number":51,"context_line":"        sa.Column(\u0027multicast_group\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":52,"context_line":"        sa.Column(\u0027allocated\u0027, sa.Boolean, nullable\u003dFalse),"},{"line_number":53,"context_line":"        sa.PrimaryKeyConstraint(\u0027vxlan_vni\u0027)"},{"line_number":54,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAP3%2F%2FqR0%3D","line":51,"updated":"2013-07-15 03:39:16.000000000","message":"Should this be removed?","commit_id":"19b001a1524488500c24102e854375910f4d2a90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":48,"context_line":"        \u0027ml2_vxlan_allocations\u0027,"},{"line_number":49,"context_line":"        sa.Column(\u0027vxlan_vni\u0027, sa.Integer, nullable\u003dFalse,"},{"line_number":50,"context_line":"                  autoincrement\u003dFalse),"},{"line_number":51,"context_line":"        sa.Column(\u0027multicast_group\u0027, sa.String(length\u003d64), nullable\u003dFalse),"},{"line_number":52,"context_line":"        sa.Column(\u0027allocated\u0027, sa.Boolean, nullable\u003dFalse),"},{"line_number":53,"context_line":"        sa.PrimaryKeyConstraint(\u0027vxlan_vni\u0027)"},{"line_number":54,"context_line":"    )"}],"source_content_type":"text/x-python","patch_set":25,"id":"AAAAP3%2F%2FqNE%3D","line":51,"in_reply_to":"AAAAP3%2F%2FqR0%3D","updated":"2013-07-15 04:21:36.000000000","message":"Good catch! Removing along with rebase which takes into account tunnel_types change.","commit_id":"19b001a1524488500c24102e854375910f4d2a90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"DB Migration for ML2 VXLAN Type Driver"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 477a4488d3f4"},{"line_number":21,"context_line":"Revises: b7a8863760e"},{"line_number":22,"context_line":"Create Date: 2013-07-09 14:14:33.158502"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAP3%2F%2FkWQ%3D","line":21,"updated":"2013-07-16 13:49:05.000000000","message":"the same issue as gre patch","commit_id":"ea8d411fc00a1035ef112ba8a3c5eab435c8a93a"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":18,"context_line":"\"\"\"DB Migration for ML2 VXLAN Type Driver"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Revision ID: 477a4488d3f4"},{"line_number":21,"context_line":"Revises: b7a8863760e"},{"line_number":22,"context_line":"Create Date: 2013-07-09 14:14:33.158502"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAP3%2F%2Fivo%3D","line":21,"in_reply_to":"AAAAP3%2F%2FkWQ%3D","updated":"2013-07-16 19:33:25.000000000","message":"Done","commit_id":"ea8d411fc00a1035ef112ba8a3c5eab435c8a93a"}],"neutron/plugins/ml2/common/tunnel.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def _parse_tunnel_ranges(tunnel_ranges, current_range, tunnel_type):"},{"line_number":24,"context_line":"    try:"},{"line_number":25,"context_line":"        current_range.extend("},{"line_number":26,"context_line":"            (int(e.strip())"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2Fmdc%3D","line":23,"updated":"2013-07-16 00:40:47.000000000","message":"Why not put this function in the TunnelTypeDriver base class inherited by both tunnel TypeDrivers, avoiding the need for this module?","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":20,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"def _parse_tunnel_ranges(tunnel_ranges, current_range, tunnel_type):"},{"line_number":24,"context_line":"    try:"},{"line_number":25,"context_line":"        current_range.extend("},{"line_number":26,"context_line":"            (int(e.strip())"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FkRo%3D","line":23,"in_reply_to":"AAAAP3%2F%2Fmdc%3D","updated":"2013-07-16 14:13:05.000000000","message":"Done","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"def _parse_tunnel_ranges(tunnel_ranges, current_range, tunnel_type):"},{"line_number":24,"context_line":"    try:"},{"line_number":25,"context_line":"        current_range.extend("},{"line_number":26,"context_line":"            (int(e.strip())"},{"line_number":27,"context_line":"             for e in (entry.split(\u0027:\u0027)[:2] for entry in tunnel_ranges))"},{"line_number":28,"context_line":"        )"},{"line_number":29,"context_line":"    except ValueError as ex:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FmeA%3D","line":26,"updated":"2013-07-16 00:40:47.000000000","message":"This looks like its going to have the same issue I reported in https://review.openstack.org/#/c/33297/23/neutron/plugins/ml2/drivers/type_gre.py.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"}],"neutron/plugins/ml2/drivers/type_gre.py":[{"author":{"_account_id":7170,"name":"Zang MingJie","email":"zealot0630@gmail.com","username":"zealot"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":"        common_tunnel._parse_tunnel_ranges("},{"line_number":69,"context_line":"            cfg.CONF.ml2_type_gre.tunnel_id_ranges,"},{"line_number":70,"context_line":"            self.gre_id_ranges,"},{"line_number":71,"context_line":"            \u0027gre\u0027"},{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":"        self._sync_gre_allocations()"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2Fp68%3D","line":71,"updated":"2013-07-15 07:26:09.000000000","message":"use type_tunnel.TYPE_GRE, but if this argument is only used for logging, can we pull out the logging statement, remove this argument.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":68,"context_line":"        common_tunnel._parse_tunnel_ranges("},{"line_number":69,"context_line":"            cfg.CONF.ml2_type_gre.tunnel_id_ranges,"},{"line_number":70,"context_line":"            self.gre_id_ranges,"},{"line_number":71,"context_line":"            \u0027gre\u0027"},{"line_number":72,"context_line":"        )"},{"line_number":73,"context_line":"        self._sync_gre_allocations()"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FkRE%3D","line":71,"in_reply_to":"AAAAP3%2F%2Fp68%3D","updated":"2013-07-16 14:13:05.000000000","message":"I prefer to keep the argument in for logging purposes, but I will update per your suggestion.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"}],"neutron/plugins/ml2/drivers/type_tunnel.py":[{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":23,"context_line":"TUNNEL \u003d \u0027tunnel\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"TYPE_GRE \u003d \u0027gre\u0027"},{"line_number":26,"context_line":"TYPE_VXLAN \u003d \u0027vxlan\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TunnelTypeDriver(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FmbY%3D","line":26,"updated":"2013-07-16 00:40:47.000000000","message":"These constants should be in the individual driver modules so that this module does not need to be edited to add a new tunnel type driver.\n\nI think they are only here for the default tunnel_type of TYPE_GRE in tunnel_sync(), but it seems to me that ml2 will only be used with versions of openvswitch-agent that send the tunnel_type, so no default should be needed.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":23,"context_line":"TUNNEL \u003d \u0027tunnel\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"TYPE_GRE \u003d \u0027gre\u0027"},{"line_number":26,"context_line":"TYPE_VXLAN \u003d \u0027vxlan\u0027"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"class TunnelTypeDriver(object):"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FkPo%3D","line":26,"in_reply_to":"AAAAP3%2F%2FmbY%3D","updated":"2013-07-16 14:13:05.000000000","message":"I\u0027ll move these out into the individual tunnel_type drivers.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"        Updates the database with the tunnel IP. All listening agents will also"},{"line_number":65,"context_line":"        be notified about the new tunnel IP."},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":68,"context_line":"        tunnel_type \u003d kwargs.get(\u0027tunnel_type\u0027) or TYPE_GRE"},{"line_number":69,"context_line":"        driver \u003d self.type_manager.drivers.get(tunnel_type)"},{"line_number":70,"context_line":"        if driver:"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2Fo9I%3D","line":67,"updated":"2013-07-15 14:34:06.000000000","message":"With a vxlan only config on ovs agent and ml2 plugin, this doesn\u0027t works since the argument (tunnel_type \u003d \u0027vxlan\u0027) is not sent by the ovs agent during tunnel_sync(). So the ML2 plugin try to load the gre drivers which is not in the configuration file.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        be notified about the new tunnel IP."},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":68,"context_line":"        tunnel_type \u003d kwargs.get(\u0027tunnel_type\u0027) or TYPE_GRE"},{"line_number":69,"context_line":"        driver \u003d self.type_manager.drivers.get(tunnel_type)"},{"line_number":70,"context_line":"        if driver:"},{"line_number":71,"context_line":"            tunnel \u003d driver.obj.add_endpoint(tunnel_ip)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2Fma4%3D","line":68,"updated":"2013-07-16 00:40:47.000000000","message":"I don\u0027t see how defaulting to TYPE_GRE makes any sense here. Either the agents send the tunnel_type, or they don\u0027t. Whether they send it doesn\u0027t depend on which tunnel_type is being used. It seems like the agents need to send tunnel_type.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":65,"context_line":"        be notified about the new tunnel IP."},{"line_number":66,"context_line":"        \"\"\""},{"line_number":67,"context_line":"        tunnel_ip \u003d kwargs.get(\u0027tunnel_ip\u0027)"},{"line_number":68,"context_line":"        tunnel_type \u003d kwargs.get(\u0027tunnel_type\u0027) or TYPE_GRE"},{"line_number":69,"context_line":"        driver \u003d self.type_manager.drivers.get(tunnel_type)"},{"line_number":70,"context_line":"        if driver:"},{"line_number":71,"context_line":"            tunnel \u003d driver.obj.add_endpoint(tunnel_ip)"}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FkPg%3D","line":68,"in_reply_to":"AAAAP3%2F%2Fma4%3D","updated":"2013-07-16 14:13:05.000000000","message":"I think matrohon removed this with a newer version of the TYPE_GRE patch.","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"}],"neutron/plugins/ml2/drivers/type_vxlan.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Represents tunnel endpoint in RPC mode.\"\"\""},{"line_number":65,"context_line":"    __tablename__ \u003d \u0027ml2_vxlan_endpoints\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    ip_address \u003d sa.Column(sa.String(64), primary_key\u003dTrue)"},{"line_number":68,"context_line":"    udp_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def __init__(self, ip_address):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F7c0%3D","line":67,"updated":"2013-07-09 00:41:54.000000000","message":"I\u0027m wondering if the ip_address + port should be the primary key? Is it possible to use the same ip and multiple different ports?","commit_id":"5f90f514a6be5fd4642720b7f3abb42569823e4b"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    \"\"\"Represents tunnel endpoint in RPC mode.\"\"\""},{"line_number":65,"context_line":"    __tablename__ \u003d \u0027ml2_vxlan_endpoints\u0027"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    ip_address \u003d sa.Column(sa.String(64), primary_key\u003dTrue)"},{"line_number":68,"context_line":"    udp_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def __init__(self, ip_address):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F7Xo%3D","line":67,"in_reply_to":"AAAAP3%2F%2F7c0%3D","updated":"2013-07-09 02:34:08.000000000","message":"I think this is valid, I\u0027ll add it here as well.","commit_id":"5f90f514a6be5fd4642720b7f3abb42569823e4b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.udp_port \u003d VXLAN_UDP_PORT"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __repr__(self):"},{"line_number":75,"context_line":"        return \"\u003cTunnelEndpoint(%s,%s)\u003e\" % (self.ip_address, self.id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class VXLANTypeDriver(api.TypeDriver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F7dE%3D","line":75,"updated":"2013-07-09 00:41:54.000000000","message":"there doesn\u0027t seem to be  self.id in this model.","commit_id":"5f90f514a6be5fd4642720b7f3abb42569823e4b"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.udp_port \u003d VXLAN_UDP_PORT"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"    def __repr__(self):"},{"line_number":75,"context_line":"        return \"\u003cTunnelEndpoint(%s,%s)\u003e\" % (self.ip_address, self.id)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"class VXLANTypeDriver(api.TypeDriver,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F7Xs%3D","line":75,"in_reply_to":"AAAAP3%2F%2F7dE%3D","updated":"2013-07-09 02:34:08.000000000","message":"Good catch! I had removed id as an identifier here, so I\u0027ll remove it here as well.","commit_id":"5f90f514a6be5fd4642720b7f3abb42569823e4b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"unresolved":false,"context_lines":[{"line_number":180,"context_line":"        vxlan_vnis \u003d set()"},{"line_number":181,"context_line":"        for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":182,"context_line":"            tun_min, tun_max \u003d vxlan_vni_range"},{"line_number":183,"context_line":"            if tun_max + 1 - tun_min \u003e 1000000:"},{"line_number":184,"context_line":"                LOG.error(_(\"Skipping unreasonable VXLAN VNI range \""},{"line_number":185,"context_line":"                            \"%(tun_min)s:%(tun_max)s\"),"},{"line_number":186,"context_line":"                          {\u0027tun_min\u0027: tun_min, \u0027tun_max\u0027: tun_max})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F7c4%3D","line":183,"updated":"2013-07-09 00:41:54.000000000","message":"probably a dumb question but what\u0027s the 1000000 for ?","commit_id":"5f90f514a6be5fd4642720b7f3abb42569823e4b"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        vxlan_vnis \u003d set()"},{"line_number":181,"context_line":"        for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":182,"context_line":"            tun_min, tun_max \u003d vxlan_vni_range"},{"line_number":183,"context_line":"            if tun_max + 1 - tun_min \u003e 1000000:"},{"line_number":184,"context_line":"                LOG.error(_(\"Skipping unreasonable VXLAN VNI range \""},{"line_number":185,"context_line":"                            \"%(tun_min)s:%(tun_max)s\"),"},{"line_number":186,"context_line":"                          {\u0027tun_min\u0027: tun_min, \u0027tun_max\u0027: tun_max})"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAP3%2F%2F7XM%3D","line":183,"in_reply_to":"AAAAP3%2F%2F7c4%3D","updated":"2013-07-09 02:34:08.000000000","message":"I believe it\u0027s an arbitrary maximum tunnel value. I\u0027ve changed this to the maximum supported VNI value for VXLAN (which is 24-bit): 0xffffff, or 16777215.","commit_id":"5f90f514a6be5fd4642720b7f3abb42569823e4b"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"867d1a3ec261a82d26a5478c02548e01a91dbf7d","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":229,"context_line":"            vxlan_endpoints \u003d session.query(VXLANEndpoints)"},{"line_number":230,"context_line":"            return [{\u0027id\u0027: vxlan_endpoint.id,"},{"line_number":231,"context_line":"                     \u0027ip_address\u0027: vxlan_endpoint.ip_address}"},{"line_number":232,"context_line":"                    for vxlan_endpoint in vxlan_endpoints]"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2F3Ng%3D","line":230,"updated":"2013-07-10 09:29:29.000000000","message":"vxlan_endpoint has no more id attribute","commit_id":"997039f9bc76d59bbaf4c9aa25ec8c0fad7018c8"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":227,"context_line":""},{"line_number":228,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":229,"context_line":"            vxlan_endpoints \u003d session.query(VXLANEndpoints)"},{"line_number":230,"context_line":"            return [{\u0027id\u0027: vxlan_endpoint.id,"},{"line_number":231,"context_line":"                     \u0027ip_address\u0027: vxlan_endpoint.ip_address}"},{"line_number":232,"context_line":"                    for vxlan_endpoint in vxlan_endpoints]"},{"line_number":233,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2F2WA%3D","line":230,"in_reply_to":"AAAAP3%2F%2F3Ng%3D","updated":"2013-07-10 13:37:19.000000000","message":"Done","commit_id":"997039f9bc76d59bbaf4c9aa25ec8c0fad7018c8"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"vxlan_opts \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027vni_ranges\u0027,"},{"line_number":36,"context_line":"                default\u003d[],"},{"line_number":37,"context_line":"                help\u003d_(\"Comma-separated list of \u003cvni_min\u003e:\u003cvni_max\u003e tuples \""},{"line_number":38,"context_line":"                       \"enumerating ranges of VXLAN VNI IDs that are \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAP3%2F%2F0%2Fo%3D","line":35,"updated":"2013-07-10 20:19:10.000000000","message":"Should be DictOpt","commit_id":"946748a3935e3871288d6a9b5c9c6f585ea99652"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":32,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"vxlan_opts \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027vni_ranges\u0027,"},{"line_number":36,"context_line":"                default\u003d[],"},{"line_number":37,"context_line":"                help\u003d_(\"Comma-separated list of \u003cvni_min\u003e:\u003cvni_max\u003e tuples \""},{"line_number":38,"context_line":"                       \"enumerating ranges of VXLAN VNI IDs that are \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAP3%2F%2F03w%3D","line":35,"in_reply_to":"AAAAP3%2F%2F0%2Fo%3D","updated":"2013-07-10 20:38:37.000000000","message":"Why? Even in the Open vSwitch plugin, the tunnel_range is a ListOpt.","commit_id":"946748a3935e3871288d6a9b5c9c6f585ea99652"},{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":32,"context_line":"VXLAN_UDP_PORT \u003d 4789"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"vxlan_opts \u003d ["},{"line_number":35,"context_line":"    cfg.ListOpt(\u0027vni_ranges\u0027,"},{"line_number":36,"context_line":"                default\u003d[],"},{"line_number":37,"context_line":"                help\u003d_(\"Comma-separated list of \u003cvni_min\u003e:\u003cvni_max\u003e tuples \""},{"line_number":38,"context_line":"                       \"enumerating ranges of VXLAN VNI IDs that are \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAP3%2F%2F01I%3D","line":35,"in_reply_to":"AAAAP3%2F%2F03w%3D","updated":"2013-07-10 20:47:36.000000000","message":"Ah sorry. This is just suggestion\nDictOpt is new function in the oslo.config.\nIt wasn\u0027t there.\n\nBut if we use DictOpt, we can remove some lines of codes :)","commit_id":"946748a3935e3871288d6a9b5c9c6f585ea99652"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":142,"context_line":"                alloc.allocated \u003d False"},{"line_number":143,"context_line":"                inside \u003d False"},{"line_number":144,"context_line":"                for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":145,"context_line":"                    if (vxlan_vni \u003e\u003d vxlan_vni_range[0]"},{"line_number":146,"context_line":"                        and vxlan_vni \u003c\u003d vxlan_vni_range[1]):"},{"line_number":147,"context_line":"                        inside \u003d True"},{"line_number":148,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0wk%3D","line":145,"updated":"2013-07-10 21:08:09.000000000","message":"nit: a \u003c\u003d x \u003c\u003db may be used here","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":142,"context_line":"                alloc.allocated \u003d False"},{"line_number":143,"context_line":"                inside \u003d False"},{"line_number":144,"context_line":"                for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":145,"context_line":"                    if (vxlan_vni \u003e\u003d vxlan_vni_range[0]"},{"line_number":146,"context_line":"                        and vxlan_vni \u003c\u003d vxlan_vni_range[1]):"},{"line_number":147,"context_line":"                        inside \u003d True"},{"line_number":148,"context_line":"                        break"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0Eg%3D","line":145,"in_reply_to":"AAAAP3%2F%2F0wk%3D","updated":"2013-07-11 02:22:53.000000000","message":"Done","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":165,"context_line":"                LOG.error(_(\"Invalid VXLAN tunnel ID range: \""},{"line_number":166,"context_line":"                            \"\u0027%(range)s\u0027 - %(e)s. Agent terminated!\"),"},{"line_number":167,"context_line":"                          {\u0027range\u0027: entry, \u0027e\u0027: ex})"},{"line_number":168,"context_line":"                sys.exit(1)"},{"line_number":169,"context_line":"        LOG.info(_(\"VXLAN ID ranges: %s\"), self.vxlan_vni_ranges)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _sync_vxlan_allocations(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0xA%3D","line":168,"updated":"2013-07-10 21:08:09.000000000","message":"I think it\u0027s better to raise here rather than explicitly stop the process.\nAlso, It\u0027s better to cover this block with UT, in which case sys.exit(1) will be harder to test.","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                LOG.error(_(\"Invalid VXLAN tunnel ID range: \""},{"line_number":166,"context_line":"                            \"\u0027%(range)s\u0027 - %(e)s. Agent terminated!\"),"},{"line_number":167,"context_line":"                          {\u0027range\u0027: entry, \u0027e\u0027: ex})"},{"line_number":168,"context_line":"                sys.exit(1)"},{"line_number":169,"context_line":"        LOG.info(_(\"VXLAN ID ranges: %s\"), self.vxlan_vni_ranges)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"    def _sync_vxlan_allocations(self):"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0EY%3D","line":168,"in_reply_to":"AAAAP3%2F%2F0xA%3D","updated":"2013-07-11 02:22:53.000000000","message":"This makes sense, and I agree.","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":188,"context_line":"        session \u003d db_api.get_session()"},{"line_number":189,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":190,"context_line":"            # remove from table unallocated tunnels not currently allocatable"},{"line_number":191,"context_line":"            allocs \u003d (session.query(VXLANAllocation).all())"},{"line_number":192,"context_line":"            for alloc in allocs:"},{"line_number":193,"context_line":"                try:"},{"line_number":194,"context_line":"                    # see if tunnel is allocatable"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F01w%3D","line":191,"updated":"2013-07-10 21:08:09.000000000","message":"nits: parens are not needed, .all() is not needed.\nquery itself is iterable","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":188,"context_line":"        session \u003d db_api.get_session()"},{"line_number":189,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":190,"context_line":"            # remove from table unallocated tunnels not currently allocatable"},{"line_number":191,"context_line":"            allocs \u003d (session.query(VXLANAllocation).all())"},{"line_number":192,"context_line":"            for alloc in allocs:"},{"line_number":193,"context_line":"                try:"},{"line_number":194,"context_line":"                    # see if tunnel is allocatable"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0EA%3D","line":191,"in_reply_to":"AAAAP3%2F%2F01w%3D","updated":"2013-07-11 02:22:53.000000000","message":"Done","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def get_vxlan_allocation(self, session, vxlan_vni):"},{"line_number":210,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":213,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni).one())"},{"line_number":214,"context_line":"                return alloc"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0xo%3D","line":211,"updated":"2013-07-10 21:08:09.000000000","message":"nit: whole try-except block may be rewritten to:\n\n return session.query(VXLANAllocation).filter_by(vxlan_vni\u003dvxlan_vni).first()","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":208,"context_line":""},{"line_number":209,"context_line":"    def get_vxlan_allocation(self, session, vxlan_vni):"},{"line_number":210,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":211,"context_line":"            try:"},{"line_number":212,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":213,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni).one())"},{"line_number":214,"context_line":"                return alloc"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0Ds%3D","line":211,"in_reply_to":"AAAAP3%2F%2F0xo%3D","updated":"2013-07-11 02:22:53.000000000","message":"Done","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"unresolved":false,"context_lines":[{"line_number":234,"context_line":"            try:"},{"line_number":235,"context_line":"                vxlan_endpoint \u003d (session.query(VXLANEndpoints)."},{"line_number":236,"context_line":"                                  filter_by(ip_address\u003dip)."},{"line_number":237,"context_line":"                                  with_lockmode(\u0027update\u0027).one())"},{"line_number":238,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":239,"context_line":"                vxlan_endpoint \u003d VXLANEndpoints(ip, udp_port)"},{"line_number":240,"context_line":"                session.add(vxlan_endpoint)"}],"source_content_type":"text/x-python","patch_set":12,"id":"AAAAP3%2F%2F0xc%3D","line":237,"updated":"2013-07-10 21:08:09.000000000","message":"Not sure you need with_lockmode(\u0027update\u0027) here","commit_id":"235008d3684c4e4d8c03030168c7648437273cbd"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":43,"context_line":"cfg.CONF.register_opts(vxlan_opts, \"ml2_type_vxlan\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class VXLANAllocation(model_base.BASEV2):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    __tablename__ \u003d \u0027ml2_vxlan_allocations\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fw2o%3D","line":46,"updated":"2013-07-11 19:55:16.000000000","message":"Can we use Vxlan* in the class names instead of VXLAN* to be consistent with the type_vlan and type_gre class naming?","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":43,"context_line":"cfg.CONF.register_opts(vxlan_opts, \"ml2_type_vxlan\")"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class VXLANAllocation(model_base.BASEV2):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    __tablename__ \u003d \u0027ml2_vxlan_allocations\u0027"},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fwx4%3D","line":46,"in_reply_to":"AAAAP3%2F%2Fw2o%3D","updated":"2013-07-11 20:09:58.000000000","message":"Done","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                return {api.NETWORK_TYPE: type_tunnel.TYPE_VXLAN,"},{"line_number":128,"context_line":"                        api.PHYSICAL_NETWORK: None,"},{"line_number":129,"context_line":"                        api.SEGMENTATION_ID: alloc.vxlan_vni}"},{"line_number":130,"context_line":"        raise exc.NoNetworkAvailable()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def release_segment(self, session, segment):"},{"line_number":133,"context_line":"        vxlan_vni \u003d segment[api.SEGMENTATION_ID]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2FxBw%3D","line":130,"updated":"2013-07-11 19:55:16.000000000","message":"This should fall off the end (return implicit None) rather than raise an exception so that the ml2 plugin will try the next TypeDriver in tenant_network_types. See VlanTypeDriver.","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":127,"context_line":"                return {api.NETWORK_TYPE: type_tunnel.TYPE_VXLAN,"},{"line_number":128,"context_line":"                        api.PHYSICAL_NETWORK: None,"},{"line_number":129,"context_line":"                        api.SEGMENTATION_ID: alloc.vxlan_vni}"},{"line_number":130,"context_line":"        raise exc.NoNetworkAvailable()"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def release_segment(self, session, segment):"},{"line_number":133,"context_line":"        vxlan_vni \u003d segment[api.SEGMENTATION_ID]"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fwxw%3D","line":130,"in_reply_to":"AAAAP3%2F%2FxBw%3D","updated":"2013-07-11 20:09:58.000000000","message":"Done","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        for entry in cfg.CONF.ml2_type_vxlan.vni_ranges:"},{"line_number":158,"context_line":"            entry \u003d entry.strip()"},{"line_number":159,"context_line":"            try:"},{"line_number":160,"context_line":"                tun_min, tun_max \u003d entry.split(\u0027:\u0027)"},{"line_number":161,"context_line":"                self.vxlan_vni_ranges.append((int(tun_min), int(tun_max)))"},{"line_number":162,"context_line":"            except ValueError as ex:"},{"line_number":163,"context_line":"                msg \u003d _(\"Invalid VXLAN tunnel ID range: \u0027%(range)s\u0027 - %(e)s. \""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2FxBA%3D","line":160,"updated":"2013-07-11 19:55:16.000000000","message":"The tun_min and tun_max should be stripped, as in GreTypeDriver.","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"        for entry in cfg.CONF.ml2_type_vxlan.vni_ranges:"},{"line_number":158,"context_line":"            entry \u003d entry.strip()"},{"line_number":159,"context_line":"            try:"},{"line_number":160,"context_line":"                tun_min, tun_max \u003d entry.split(\u0027:\u0027)"},{"line_number":161,"context_line":"                self.vxlan_vni_ranges.append((int(tun_min), int(tun_max)))"},{"line_number":162,"context_line":"            except ValueError as ex:"},{"line_number":163,"context_line":"                msg \u003d _(\"Invalid VXLAN tunnel ID range: \u0027%(range)s\u0027 - %(e)s. \""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAP3%2F%2Fwxo%3D","line":160,"in_reply_to":"AAAAP3%2F%2FxBA%3D","updated":"2013-07-11 20:09:58.000000000","message":"Done","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":"                         with_lockmode(\u0027update\u0027)."},{"line_number":138,"context_line":"                         one())"},{"line_number":139,"context_line":"                alloc.allocated \u003d False"},{"line_number":140,"context_line":"                inside \u003d False"},{"line_number":141,"context_line":"                for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":142,"context_line":"                    if (vxlan_vni_range[0] \u003c\u003d vxlan_vni"},{"line_number":143,"context_line":"                        \u003c\u003d vxlan_vni_range[1]):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2Frao%3D","line":140,"updated":"2013-07-13 17:50:13.000000000","message":"This should be refactored in a for:else loop.  Replace 140-151.\n\nfor low, high in self.vxlan_vni_ranges:\n    if low \u003c\u003d vxlan_vni \u003c\u003d high:\n        LOG.debug(_(\"Releasing vxln tunnel %s to pool\"), vxlan_vni)\n        break\nelse:\n    session.delete(alloc)\n    LOG.debug(_(\"Releasing vxlan tunnel %s outside pool\"), vxlan_vni)","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":"                         with_lockmode(\u0027update\u0027)."},{"line_number":138,"context_line":"                         one())"},{"line_number":139,"context_line":"                alloc.allocated \u003d False"},{"line_number":140,"context_line":"                inside \u003d False"},{"line_number":141,"context_line":"                for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":142,"context_line":"                    if (vxlan_vni_range[0] \u003c\u003d vxlan_vni"},{"line_number":143,"context_line":"                        \u003c\u003d vxlan_vni_range[1]):"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGQ%3D","line":140,"in_reply_to":"AAAAP3%2F%2Frao%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":152,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":153,"context_line":"                LOG.warning(_(\"vxlan_vni %s not found\"), vxlan_vni)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _parse_vxlan_vni_ranges(self):"},{"line_number":156,"context_line":"        for entry in cfg.CONF.ml2_type_vxlan.vni_ranges:"},{"line_number":157,"context_line":"            entry \u003d entry.strip()"},{"line_number":158,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FraU%3D","line":155,"updated":"2013-07-13 17:50:13.000000000","message":"This is used by another file.  Seems like a good candidate for common lib.","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":152,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":153,"context_line":"                LOG.warning(_(\"vxlan_vni %s not found\"), vxlan_vni)"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"    def _parse_vxlan_vni_ranges(self):"},{"line_number":156,"context_line":"        for entry in cfg.CONF.ml2_type_vxlan.vni_ranges:"},{"line_number":157,"context_line":"            entry \u003d entry.strip()"},{"line_number":158,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGY%3D","line":155,"in_reply_to":"AAAAP3%2F%2FraU%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # determine current configured allocatable vnis"},{"line_number":176,"context_line":"        vxlan_vnis \u003d set()"},{"line_number":177,"context_line":"        for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":178,"context_line":"            tun_min, tun_max \u003d vxlan_vni_range"},{"line_number":179,"context_line":"            # Use the theoretical max VNI here"},{"line_number":180,"context_line":"            if tun_max + 1 - tun_min \u003e 16777215:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FraY%3D","line":177,"updated":"2013-07-13 17:50:13.000000000","message":"for tun_min, tun_max in self.vxlan_vni_ranges:","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        # determine current configured allocatable vnis"},{"line_number":176,"context_line":"        vxlan_vnis \u003d set()"},{"line_number":177,"context_line":"        for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":178,"context_line":"            tun_min, tun_max \u003d vxlan_vni_range"},{"line_number":179,"context_line":"            # Use the theoretical max VNI here"},{"line_number":180,"context_line":"            if tun_max + 1 - tun_min \u003e 16777215:"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGc%3D","line":177,"in_reply_to":"AAAAP3%2F%2FraY%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":177,"context_line":"        for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":178,"context_line":"            tun_min, tun_max \u003d vxlan_vni_range"},{"line_number":179,"context_line":"            # Use the theoretical max VNI here"},{"line_number":180,"context_line":"            if tun_max + 1 - tun_min \u003e 16777215:"},{"line_number":181,"context_line":"                LOG.error(_(\"Skipping unreasonable VXLAN VNI range \""},{"line_number":182,"context_line":"                            \"%(tun_min)s:%(tun_max)s\"),"},{"line_number":183,"context_line":"                          {\u0027tun_min\u0027: tun_min, \u0027tun_max\u0027: tun_max})"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2Frac%3D","line":180,"updated":"2013-07-13 17:50:13.000000000","message":"16777215 should be a constant declared at top of file.","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":177,"context_line":"        for vxlan_vni_range in self.vxlan_vni_ranges:"},{"line_number":178,"context_line":"            tun_min, tun_max \u003d vxlan_vni_range"},{"line_number":179,"context_line":"            # Use the theoretical max VNI here"},{"line_number":180,"context_line":"            if tun_max + 1 - tun_min \u003e 16777215:"},{"line_number":181,"context_line":"                LOG.error(_(\"Skipping unreasonable VXLAN VNI range \""},{"line_number":182,"context_line":"                            \"%(tun_min)s:%(tun_max)s\"),"},{"line_number":183,"context_line":"                          {\u0027tun_min\u0027: tun_min, \u0027tun_max\u0027: tun_max})"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGg%3D","line":180,"in_reply_to":"AAAAP3%2F%2Frac%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    vxlan_vni \u003d sa.Column(sa.Integer, nullable\u003dFalse, primary_key\u003dTrue,"},{"line_number":53,"context_line":"                          autoincrement\u003dFalse)"},{"line_number":54,"context_line":"    allocated \u003d sa.Column(sa.Boolean, nullable\u003dFalse, default\u003dFalse)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class VxlanEndpoints(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqrQ%3D","line":54,"updated":"2013-07-14 22:27:51.000000000","message":"Missing column for multicast_group?","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    vxlan_vni \u003d sa.Column(sa.Integer, nullable\u003dFalse, primary_key\u003dTrue,"},{"line_number":53,"context_line":"                          autoincrement\u003dFalse)"},{"line_number":54,"context_line":"    allocated \u003d sa.Column(sa.Boolean, nullable\u003dFalse, default\u003dFalse)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"class VxlanEndpoints(model_base.BASEV2):"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqaE%3D","line":54,"in_reply_to":"AAAAP3%2F%2FqrQ%3D","updated":"2013-07-15 02:05:04.000000000","message":"We decided to leave the multicast group out of the DB for this first cut. For now, it\u0027s only configurable in the configuration file.","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"    udp_port \u003d sa.Column(sa.Integer, primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __repr__(self):"},{"line_number":65,"context_line":"        return \"\u003cTunnelEndpoint(%s)\u003e\" % (self.ip_address)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class VxlanTypeDriver(api.TypeDriver,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqqQ%3D","line":65,"updated":"2013-07-14 22:27:51.000000000","message":"Nit: parentheses not needed.\n\nMake this string \"\u003cVxlanTunnelEndpoint(%s)\u003e\". \n\n(Same goes for GreEndpoints.__repr__)","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":62,"context_line":"    udp_port \u003d sa.Column(sa.Integer, primary_key\u003dTrue, nullable\u003dFalse)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def __repr__(self):"},{"line_number":65,"context_line":"        return \"\u003cTunnelEndpoint(%s)\u003e\" % (self.ip_address)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"class VxlanTypeDriver(api.TypeDriver,"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqZ8%3D","line":65,"in_reply_to":"AAAAP3%2F%2FqqQ%3D","updated":"2013-07-15 02:05:04.000000000","message":"Done","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":"                alloc.allocated \u003d False"},{"line_number":138,"context_line":"                for low, high in self.vxlan_vni_ranges:"},{"line_number":139,"context_line":"                    if low \u003c\u003d vxlan_vni \u003c\u003d high:"},{"line_number":140,"context_line":"                        LOG.debug(_(\"Releasing vxln tunnel %s to pool\"),"},{"line_number":141,"context_line":"                                  vxlan_vni)"},{"line_number":142,"context_line":"                        break"},{"line_number":143,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqmU%3D","line":140,"updated":"2013-07-14 22:27:51.000000000","message":"Typo: vxln","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":137,"context_line":"                alloc.allocated \u003d False"},{"line_number":138,"context_line":"                for low, high in self.vxlan_vni_ranges:"},{"line_number":139,"context_line":"                    if low \u003c\u003d vxlan_vni \u003c\u003d high:"},{"line_number":140,"context_line":"                        LOG.debug(_(\"Releasing vxln tunnel %s to pool\"),"},{"line_number":141,"context_line":"                                  vxlan_vni)"},{"line_number":142,"context_line":"                        break"},{"line_number":143,"context_line":"                    else:"}],"source_content_type":"text/x-python","patch_set":24,"id":"AAAAP3%2F%2FqZ4%3D","line":140,"in_reply_to":"AAAAP3%2F%2FqmU%3D","updated":"2013-07-15 02:05:04.000000000","message":"Done","commit_id":"b509caf739135ffdc2e51b1d1a9e6cff3def15ca"},{"author":{"_account_id":7170,"name":"Zang MingJie","email":"zealot0630@gmail.com","username":"zealot"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"        common_tunnel._parse_tunnel_ranges("},{"line_number":77,"context_line":"            cfg.CONF.ml2_type_vxlan.vni_ranges,"},{"line_number":78,"context_line":"            self.vxlan_vni_ranges,"},{"line_number":79,"context_line":"            \u0027vxlan\u0027"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        self._sync_vxlan_allocations()"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2Fp6s%3D","line":79,"updated":"2013-07-15 07:26:09.000000000","message":"type_tunnel.TYPE_VXLAN","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":76,"context_line":"        common_tunnel._parse_tunnel_ranges("},{"line_number":77,"context_line":"            cfg.CONF.ml2_type_vxlan.vni_ranges,"},{"line_number":78,"context_line":"            self.vxlan_vni_ranges,"},{"line_number":79,"context_line":"            \u0027vxlan\u0027"},{"line_number":80,"context_line":"        )"},{"line_number":81,"context_line":"        self._sync_vxlan_allocations()"},{"line_number":82,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAP3%2F%2FkP0%3D","line":79,"in_reply_to":"AAAAP3%2F%2Fp6s%3D","updated":"2013-07-16 14:13:05.000000000","message":"Done","commit_id":"ed38bf8f114f410d9c813167e328a582b8f99c59"}],"neutron/tests/unit/ml2/test_type_vxlan.py":[{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"867d1a3ec261a82d26a5478c02548e01a91dbf7d","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Set second endpoint, verify it gets VXLAN VNI 2"},{"line_number":174,"context_line":"        vxlan2_endpoint \u003d self.driver.add_endpoint(TUNNEL_IP_TWO)"},{"line_number":175,"context_line":"        self.assertEqual(TUNNEL_IP_TWO, vxlan2_endpoint.ip_address)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2F2%2Fs%3D","line":175,"updated":"2013-07-10 09:29:29.000000000","message":"you should also have a test for get_endpoints","commit_id":"997039f9bc76d59bbaf4c9aa25ec8c0fad7018c8"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        # Set second endpoint, verify it gets VXLAN VNI 2"},{"line_number":174,"context_line":"        vxlan2_endpoint \u003d self.driver.add_endpoint(TUNNEL_IP_TWO)"},{"line_number":175,"context_line":"        self.assertEqual(TUNNEL_IP_TWO, vxlan2_endpoint.ip_address)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAP3%2F%2F2V8%3D","line":175,"in_reply_to":"AAAAP3%2F%2F2%2Fs%3D","updated":"2013-07-10 13:37:19.000000000","message":"Done","commit_id":"997039f9bc76d59bbaf4c9aa25ec8c0fad7018c8"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.driver.validate_provider_segment(segment)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_sync_tunnel_allocations(self):"},{"line_number":73,"context_line":"        self.assertIsNone(self.driver."},{"line_number":74,"context_line":"                          get_vxlan_allocation(self.session, (TUN_MIN - 1)))"},{"line_number":75,"context_line":"        self.assertFalse(self.driver."},{"line_number":76,"context_line":"                         get_vxlan_allocation(self.session, (TUN_MIN))."}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FraQ%3D","line":73,"updated":"2013-07-13 17:50:13.000000000","message":"Please reformat this and the others for easier reading:\nself.assertIsNone(\n    self.driver.get_vxlan_allocation(\n        self.session, (TUN_MIN - 1)\n    )\n)","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":70,"context_line":"            self.driver.validate_provider_segment(segment)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"    def test_sync_tunnel_allocations(self):"},{"line_number":73,"context_line":"        self.assertIsNone(self.driver."},{"line_number":74,"context_line":"                          get_vxlan_allocation(self.session, (TUN_MIN - 1)))"},{"line_number":75,"context_line":"        self.assertFalse(self.driver."},{"line_number":76,"context_line":"                         get_vxlan_allocation(self.session, (TUN_MIN))."}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrF8%3D","line":73,"in_reply_to":"AAAAP3%2F%2FraQ%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.driver.release_segment(self.session, segment)"},{"line_number":136,"context_line":"        alloc \u003d self.driver.get_vxlan_allocation(self.session,"},{"line_number":137,"context_line":"                                                 segment[api.SEGMENTATION_ID])"},{"line_number":138,"context_line":"        self.assertEqual(None, alloc)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_allocate_tenant_segment(self):"},{"line_number":141,"context_line":"        tunnel_ids \u003d set()"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FraE%3D","line":138,"updated":"2013-07-13 17:50:13.000000000","message":"self.assertIsNone(alloc)","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":135,"context_line":"        self.driver.release_segment(self.session, segment)"},{"line_number":136,"context_line":"        alloc \u003d self.driver.get_vxlan_allocation(self.session,"},{"line_number":137,"context_line":"                                                 segment[api.SEGMENTATION_ID])"},{"line_number":138,"context_line":"        self.assertEqual(None, alloc)"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"    def test_allocate_tenant_segment(self):"},{"line_number":141,"context_line":"        tunnel_ids \u003d set()"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGA%3D","line":138,"in_reply_to":"AAAAP3%2F%2FraE%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":141,"context_line":"        tunnel_ids \u003d set()"},{"line_number":142,"context_line":"        for x in xrange(TUN_MIN, TUN_MAX + 1):"},{"line_number":143,"context_line":"            segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":144,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":145,"context_line":"                            matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":146,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":147,"context_line":"                            matchers.LessThan(TUN_MAX + 1))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FraA%3D","line":144,"updated":"2013-07-13 17:50:13.000000000","message":"Please the standard library version\n\n.assertGreater(\n    segment[api.SEGMENTATION_ID],\n    TUN_MIN - 1\n)","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":143,"context_line":"            segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":144,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":145,"context_line":"                            matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":146,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":147,"context_line":"                            matchers.LessThan(TUN_MAX + 1))"},{"line_number":148,"context_line":"            tunnel_ids.add(segment[api.SEGMENTATION_ID])"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrZ8%3D","line":146,"updated":"2013-07-13 17:50:13.000000000","message":".assertLess()","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":143,"context_line":"            segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":144,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":145,"context_line":"                            matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":146,"context_line":"            self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":147,"context_line":"                            matchers.LessThan(TUN_MAX + 1))"},{"line_number":148,"context_line":"            tunnel_ids.add(segment[api.SEGMENTATION_ID])"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGM%3D","line":146,"in_reply_to":"AAAAP3%2F%2FrZ8%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":155,"context_line":"                   api.SEGMENTATION_ID: tunnel_ids.pop()}"},{"line_number":156,"context_line":"        self.driver.release_segment(self.session, segment)"},{"line_number":157,"context_line":"        segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":158,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":159,"context_line":"                        matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":160,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":161,"context_line":"                        matchers.LessThan(TUN_MAX + 1))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrZ4%3D","line":158,"updated":"2013-07-13 17:50:13.000000000","message":"same as above","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":155,"context_line":"                   api.SEGMENTATION_ID: tunnel_ids.pop()}"},{"line_number":156,"context_line":"        self.driver.release_segment(self.session, segment)"},{"line_number":157,"context_line":"        segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":158,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":159,"context_line":"                        matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":160,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":161,"context_line":"                        matchers.LessThan(TUN_MAX + 1))"}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGI%3D","line":158,"in_reply_to":"AAAAP3%2F%2FrZ4%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":2592,"name":"Mark McClain","email":"mark@mcclain.xyz","username":"markmcclain"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"        segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":158,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":159,"context_line":"                        matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":160,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":161,"context_line":"                        matchers.LessThan(TUN_MAX + 1))"},{"line_number":162,"context_line":"        tunnel_ids.add(segment[api.SEGMENTATION_ID])"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrZw%3D","line":160,"updated":"2013-07-13 17:50:13.000000000","message":"same as above","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":157,"context_line":"        segment \u003d self.driver.allocate_tenant_segment(self.session)"},{"line_number":158,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":159,"context_line":"                        matchers.GreaterThan(TUN_MIN - 1))"},{"line_number":160,"context_line":"        self.assertThat(segment[api.SEGMENTATION_ID],"},{"line_number":161,"context_line":"                        matchers.LessThan(TUN_MAX + 1))"},{"line_number":162,"context_line":"        tunnel_ids.add(segment[api.SEGMENTATION_ID])"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"AAAAP3%2F%2FrGE%3D","line":160,"in_reply_to":"AAAAP3%2F%2FrZw%3D","updated":"2013-07-14 04:04:42.000000000","message":"Done","commit_id":"6e7d37bab908db88a3ce86155b62686c25a1ce25"}],"quantum/plugins/ml2/drivers/type_vxlan.py":[{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    __tablename__ \u003d \u0027ml2_vxlan_endpoints\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    ip_address \u003d sa.Column(sa.String(64), primary_key\u003dTrue)"},{"line_number":67,"context_line":"    id \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":68,"context_line":"    udp_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":69,"context_line":"    multicast_group \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX14%3D","line":67,"updated":"2013-07-03 04:23:58.000000000","message":"question: Does it make sense to make this field unique?","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    __tablename__ \u003d \u0027ml2_vxlan_endpoints\u0027"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"    ip_address \u003d sa.Column(sa.String(64), primary_key\u003dTrue)"},{"line_number":67,"context_line":"    id \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":68,"context_line":"    udp_port \u003d sa.Column(sa.Integer, nullable\u003dFalse)"},{"line_number":69,"context_line":"    multicast_group \u003d sa.Column(sa.String(64), nullable\u003dFalse)"},{"line_number":70,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F8gY%3D","line":67,"in_reply_to":"AAAAPn%2F%2FX14%3D","updated":"2013-07-08 19:06:18.000000000","message":"Done","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f35eed847bb5b8d2623cf9899af562a43ae6795c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.ip_address \u003d ip_address"},{"line_number":73,"context_line":"        self.id \u003d id"},{"line_number":74,"context_line":"        self.udp_port \u003d VXLAN_UDP_PORT"},{"line_number":75,"context_line":"        self.multicast_group \u003d multicast_group"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __repr__(self):"},{"line_number":78,"context_line":"        return \"\u003cTunnelEndpoint(%s,%s)\u003e\" % (self.ip_address, self.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXUc%3D","line":75,"updated":"2013-07-03 09:08:50.000000000","message":"I think that VXLan multicast group should be stored in VXLanAllocation table, Since it could be different from one VNI to another, even if in a first implementation, only one multicast group would be configured in the plugin.ini. This is not an information related to the Endpoint.","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.ip_address \u003d ip_address"},{"line_number":73,"context_line":"        self.id \u003d id"},{"line_number":74,"context_line":"        self.udp_port \u003d VXLAN_UDP_PORT"},{"line_number":75,"context_line":"        self.multicast_group \u003d multicast_group"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def __repr__(self):"},{"line_number":78,"context_line":"        return \"\u003cTunnelEndpoint(%s,%s)\u003e\" % (self.ip_address, self.id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F8fg%3D","line":75,"in_reply_to":"AAAAPn%2F%2FXUc%3D","updated":"2013-07-08 19:06:18.000000000","message":"Done","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":126,"context_line":"            alloc \u003d (session.query(VXLANAllocation)."},{"line_number":127,"context_line":"                     filter_by(allocated\u003dFalse)."},{"line_number":128,"context_line":"                     with_lockmode(\u0027update\u0027)."},{"line_number":129,"context_line":"                     first())"},{"line_number":130,"context_line":"            if alloc:"},{"line_number":131,"context_line":"                LOG.debug(_(\"Allocating vxlan tunnel vni %(vxlan_vni)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX1g%3D","line":128,"updated":"2013-07-03 04:23:58.000000000","message":"Not sure with_lockmode() is needed here","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2583,"name":"Ante Karamatić","email":"ante.karamatic@canonical.com","username":"ivoks"},"unresolved":false,"context_lines":[{"line_number":125,"context_line":"        with session.begin(subtransactions\u003dTrue):"},{"line_number":126,"context_line":"            alloc \u003d (session.query(VXLANAllocation)."},{"line_number":127,"context_line":"                     filter_by(allocated\u003dFalse)."},{"line_number":128,"context_line":"                     with_lockmode(\u0027update\u0027)."},{"line_number":129,"context_line":"                     first())"},{"line_number":130,"context_line":"            if alloc:"},{"line_number":131,"context_line":"                LOG.debug(_(\"Allocating vxlan tunnel vni %(vxlan_vni)s\"),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXpE%3D","line":128,"in_reply_to":"AAAAPn%2F%2FX1g%3D","updated":"2013-07-03 06:32:14.000000000","message":"I would say - yes. Between \u0027session.query\u0027 and \u0027alloc.allocated\u003dTrue\u0027 you might get another query that allocates the same segment.","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":144,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":145,"context_line":"                         with_lockmode(\u0027update\u0027)."},{"line_number":146,"context_line":"                         one())"},{"line_number":147,"context_line":"                alloc.allocated \u003d False"},{"line_number":148,"context_line":"                inside \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX1c%3D","line":145,"updated":"2013-07-03 04:23:58.000000000","message":"ditto","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2583,"name":"Ante Karamatić","email":"ante.karamatic@canonical.com","username":"ivoks"},"unresolved":false,"context_lines":[{"line_number":142,"context_line":"            try:"},{"line_number":143,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":144,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":145,"context_line":"                         with_lockmode(\u0027update\u0027)."},{"line_number":146,"context_line":"                         one())"},{"line_number":147,"context_line":"                alloc.allocated \u003d False"},{"line_number":148,"context_line":"                inside \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXoo%3D","line":145,"in_reply_to":"AAAAPn%2F%2FX1c%3D","updated":"2013-07-03 06:32:14.000000000","message":"Even thou the window for race is much smaller, it still does exist. Alternatively, one might \u0027try alloc.allocated \u003d False\u0027 and work from there. Lockmode seems better and cleaner.","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f35eed847bb5b8d2623cf9899af562a43ae6795c","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            # add missing allocatable tunnels to table"},{"line_number":209,"context_line":"            for vxlan_vni in sorted(vxlan_vnis):"},{"line_number":210,"context_line":"                alloc \u003d VXLANAllocation(vxlan_vni)"},{"line_number":211,"context_line":"                session.add(alloc)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def get_vxlan_allocation(self, session, vxlan_vni):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXUQ%3D","line":210,"updated":"2013-07-03 09:08:50.000000000","message":"you could add the multicast info from cfg.CONF.ml2_type_vxlan.vxlan_group here","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":207,"context_line":""},{"line_number":208,"context_line":"            # add missing allocatable tunnels to table"},{"line_number":209,"context_line":"            for vxlan_vni in sorted(vxlan_vnis):"},{"line_number":210,"context_line":"                alloc \u003d VXLANAllocation(vxlan_vni)"},{"line_number":211,"context_line":"                session.add(alloc)"},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"    def get_vxlan_allocation(self, session, vxlan_vni):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F8fc%3D","line":210,"in_reply_to":"AAAAPn%2F%2FXUQ%3D","updated":"2013-07-08 19:06:18.000000000","message":"Done","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX1k%3D","line":218,"updated":"2013-07-03 04:23:58.000000000","message":"Not sure with_lockmode() is needed here","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F8fU%3D","line":218,"in_reply_to":"AAAAPn%2F%2FX1k%3D","updated":"2013-07-08 19:06:18.000000000","message":"Done","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2583,"name":"Ante Karamatić","email":"ante.karamatic@canonical.com","username":"ivoks"},"unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXng%3D","line":218,"in_reply_to":"AAAAPn%2F%2FX1k%3D","updated":"2013-07-03 06:32:14.000000000","message":"If it was me, I would put lockmode here too. In fact, on every allocation that can run in parallel, lockmode is, imho, needed. Otherwise you might hit a racing problem, particularly with PostgreSQL.","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2583,"name":"Ante Karamatić","email":"ante.karamatic@canonical.com","username":"ivoks"},"unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXjM%3D","line":218,"in_reply_to":"AAAAPn%2F%2FXkk%3D","updated":"2013-07-03 06:57:25.000000000","message":"Oh... You are right.","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXkk%3D","line":218,"in_reply_to":"AAAAPn%2F%2FXlU%3D","updated":"2013-07-03 06:43:22.000000000","message":"This is getter that returns db object by its vni. If two threads are querying allocation using the same vni, they should get the same segment, nothing wrong with this.","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2583,"name":"Ante Karamatić","email":"ante.karamatic@canonical.com","username":"ivoks"},"unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXlU%3D","line":218,"in_reply_to":"AAAAPn%2F%2FXmc%3D","updated":"2013-07-03 06:39:23.000000000","message":"get_vxlan_allocation() will say \u0027this is available segment\u0027. If you have two queries in parallel, they might both return the same segment. This problem happened before elsewhere in quantum - https://bugs.launchpad.net/neutron/+bug/1110807","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            try:"},{"line_number":216,"context_line":"                alloc \u003d (session.query(VXLANAllocation)."},{"line_number":217,"context_line":"                         filter_by(vxlan_vni\u003dvxlan_vni)."},{"line_number":218,"context_line":"                         with_lockmode(\u0027update\u0027).one())"},{"line_number":219,"context_line":"                return alloc"},{"line_number":220,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":221,"context_line":"                return"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXmc%3D","line":218,"in_reply_to":"AAAAPn%2F%2FXng%3D","updated":"2013-07-03 06:34:22.000000000","message":"but this is pure read-only access? what kind of race it could be?","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":6072,"name":"Eugene Nikanorov","email":"enikanorov@mirantis.com","username":"enikanorov"},"change_message_id":"d8366d8e564f383e588c4c004173310b2a85b8a1","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                  filter_by(ip_address\u003dip)."},{"line_number":247,"context_line":"                                  with_lockmode(\u0027update\u0027).one())"},{"line_number":248,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":249,"context_line":"                vxlan_endpoint_id \u003d self._generate_vxlan_endpoint_id(session)"},{"line_number":250,"context_line":"                vxlan_endpoint \u003d VXLANEndpoints(ip, vxlan_endpoint_id,"},{"line_number":251,"context_line":"                                                (cfg.CONF.ml2_type_vxlan."},{"line_number":252,"context_line":"                                                 vxlan_group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FX2A%3D","line":249,"updated":"2013-07-03 04:23:58.000000000","message":"I\u0027m a bit concerned about this code.\nCould you clarify why it does not allow a race producing 2 equal endpoint_ids?","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":2888,"name":"Mathieu Rohon","email":"mathieu.rohon@gmail.com","username":"mathieu-rohon"},"change_message_id":"f35eed847bb5b8d2623cf9899af562a43ae6795c","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                  filter_by(ip_address\u003dip)."},{"line_number":247,"context_line":"                                  with_lockmode(\u0027update\u0027).one())"},{"line_number":248,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":249,"context_line":"                vxlan_endpoint_id \u003d self._generate_vxlan_endpoint_id(session)"},{"line_number":250,"context_line":"                vxlan_endpoint \u003d VXLANEndpoints(ip, vxlan_endpoint_id,"},{"line_number":251,"context_line":"                                                (cfg.CONF.ml2_type_vxlan."},{"line_number":252,"context_line":"                                                 vxlan_group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAPn%2F%2FXV4%3D","line":249,"updated":"2013-07-03 09:08:50.000000000","message":"I\u0027ve already reported a bug where i get similar ID for two endpoints. This patch was proposed :\nhttps://review.openstack.org/#/c/27818/\n\nBut in this patch, garyk also proposed to use endpoint IP as the ID, which I did in the ml2-gre patch : \nhttps://review.openstack.org/#/c/33297/9/quantum/plugins/ml2/drivers/type_gre.py\n\nKyle, could you do the same to avoid endpoint ID duplication?","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                  filter_by(ip_address\u003dip)."},{"line_number":247,"context_line":"                                  with_lockmode(\u0027update\u0027).one())"},{"line_number":248,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":249,"context_line":"                vxlan_endpoint_id \u003d self._generate_vxlan_endpoint_id(session)"},{"line_number":250,"context_line":"                vxlan_endpoint \u003d VXLANEndpoints(ip, vxlan_endpoint_id,"},{"line_number":251,"context_line":"                                                (cfg.CONF.ml2_type_vxlan."},{"line_number":252,"context_line":"                                                 vxlan_group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F8eo%3D","line":249,"in_reply_to":"AAAAPn%2F%2FX2A%3D","updated":"2013-07-08 19:06:18.000000000","message":"Done","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"4707975516eb3a77045c6dc5bf384500a1d11ad8","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                                  filter_by(ip_address\u003dip)."},{"line_number":247,"context_line":"                                  with_lockmode(\u0027update\u0027).one())"},{"line_number":248,"context_line":"            except sa_exc.NoResultFound:"},{"line_number":249,"context_line":"                vxlan_endpoint_id \u003d self._generate_vxlan_endpoint_id(session)"},{"line_number":250,"context_line":"                vxlan_endpoint \u003d VXLANEndpoints(ip, vxlan_endpoint_id,"},{"line_number":251,"context_line":"                                                (cfg.CONF.ml2_type_vxlan."},{"line_number":252,"context_line":"                                                 vxlan_group))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAP3%2F%2F8ek%3D","line":249,"in_reply_to":"AAAAPn%2F%2FXV4%3D","updated":"2013-07-08 19:06:18.000000000","message":"Done","commit_id":"a4538664e59dbdc8fd7e4e95d0a3ef571246db90"}],"setup.cfg":[{"author":{"_account_id":2031,"name":"Nachi Ueno","email":"nati.ueno@gmail.com","username":"nati-ueno"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"},{"line_number":109,"context_line":"    vlan \u003d neutron.plugins.ml2.drivers.type_vlan:VlanTypeDriver"},{"line_number":110,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":111,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:GreTypeDriver"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"[build_sphinx]"},{"line_number":114,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"AAAAP3%2F%2F08k%3D","line":111,"updated":"2013-07-10 20:19:10.000000000","message":"VXLanTypeDriver?","commit_id":"946748a3935e3871288d6a9b5c9c6f585ea99652"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"c6058a178f98f97209ede6de17fa3820ed2145fc","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"},{"line_number":109,"context_line":"    vlan \u003d neutron.plugins.ml2.drivers.type_vlan:VlanTypeDriver"},{"line_number":110,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":111,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:GreTypeDriver"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"[build_sphinx]"},{"line_number":114,"context_line":"all_files \u003d 1"}],"source_content_type":"text/x-ttcn-cfg","patch_set":11,"id":"AAAAP3%2F%2F03U%3D","line":111,"in_reply_to":"AAAAP3%2F%2F08k%3D","updated":"2013-07-10 20:38:37.000000000","message":"Done","commit_id":"946748a3935e3871288d6a9b5c9c6f585ea99652"},{"author":{"_account_id":1689,"name":"Robert Kukura","email":"rk@theep.net","username":"rkukura"},"change_message_id":"28fb9be645a2dd0dbc7ccaf54db63e11c726a66f","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"},{"line_number":109,"context_line":"    vlan \u003d neutron.plugins.ml2.drivers.type_vlan:VlanTypeDriver"},{"line_number":110,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":111,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VXLANTypeDriver"},{"line_number":112,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":113,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":114,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"AAAAP3%2F%2Fw20%3D","line":111,"updated":"2013-07-11 19:55:16.000000000","message":"Can we name this VxlanTypeDriver to be consistent with VlanTypeDriver and GreTypeDriver?","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"unresolved":false,"context_lines":[{"line_number":108,"context_line":"    local \u003d neutron.plugins.ml2.drivers.type_local:LocalTypeDriver"},{"line_number":109,"context_line":"    vlan \u003d neutron.plugins.ml2.drivers.type_vlan:VlanTypeDriver"},{"line_number":110,"context_line":"    gre \u003d neutron.plugins.ml2.drivers.type_gre:GreTypeDriver"},{"line_number":111,"context_line":"    vxlan \u003d neutron.plugins.ml2.drivers.type_vxlan:VXLANTypeDriver"},{"line_number":112,"context_line":"neutron.ml2.mechanism_drivers \u003d"},{"line_number":113,"context_line":"    logger \u003d neutron.tests.unit.ml2.drivers.mechanism_logger:LoggerMechanismDriver"},{"line_number":114,"context_line":"    test \u003d neutron.tests.unit.ml2.drivers.mechanism_test:TestMechanismDriver"}],"source_content_type":"text/x-ttcn-cfg","patch_set":14,"id":"AAAAP3%2F%2FwyU%3D","line":111,"in_reply_to":"AAAAP3%2F%2Fw20%3D","updated":"2013-07-11 20:09:58.000000000","message":"Done","commit_id":"dfb87b48a4b275cc95770bcf9b136519016e1567"}]}
