)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b090913c6f80d83a8f124e6a7bc8fab5d4a7a09c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add api test for create update network and port with dns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will add test for creating and updating network"},{"line_number":10,"context_line":"and port with dns domain."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Miguel Lavalle \u003cmalavall@us.ibm.com\u003e"},{"line_number":13,"context_line":"Change-Id: I3a08cfd4a75215695ca967f7e9df2bfa10b2fef3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1a95cdbc_2b21f74d","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":25},"updated":"2016-10-05 22:43:39.000000000","message":"Nit: with dns_domain and dns_name","commit_id":"0127198e70d1ea2741b6d3a853ea99291d4e2908"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"7b35609d4da249bc66c11fe166313f332df510ad","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Add api test for create update network and port with dns"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch will add test for creating and updating network"},{"line_number":10,"context_line":"and port with dns domain."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Co-Authored-By: Miguel Lavalle \u003cmalavall@us.ibm.com\u003e"},{"line_number":13,"context_line":"Change-Id: I3a08cfd4a75215695ca967f7e9df2bfa10b2fef3"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"1a95cdbc_8b720b48","line":10,"range":{"start_line":10,"start_character":14,"end_line":10,"end_character":25},"in_reply_to":"1a95cdbc_2b21f74d","updated":"2016-10-05 22:52:34.000000000","message":"Done","commit_id":"0127198e70d1ea2741b6d3a853ea99291d4e2908"}],"neutron/tests/contrib/gate_hook.sh":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9a90d1e7dae92105551805fa7946915dabf181e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    ;;"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    source $NEUTRON_PATH/devstack/lib/ml2"},{"line_number":63,"context_line":"    load_rc_hook api_extensions"},{"line_number":64,"context_line":"    # NOTE(ihrachys): note the order of hook post-* sections is significant: [quotas] hook should"},{"line_number":65,"context_line":"    # go before other hooks modifying [DEFAULT]. See LP#1583214 for details."}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a89bdaa_fefb06bf","line":62,"updated":"2016-09-07 10:17:41.000000000","message":"This fails in gate because LIBDIR is not defined. It\u0027s currently defined in devstack/plugin.sh, I don\u0027t actually know what\u0027s better: moving it around, or defining it here in this gate hook script.","commit_id":"c5825e18c9452e8f209914bf8b3e7b025ec9c959"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e11cf104882e5e45c3074edf9c20dd4ac6f3444d","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    ;;"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    source $NEUTRON_PATH/devstack/lib/ml2"},{"line_number":63,"context_line":"    load_rc_hook api_extensions"},{"line_number":64,"context_line":"    # NOTE(ihrachys): note the order of hook post-* sections is significant: [quotas] hook should"},{"line_number":65,"context_line":"    # go before other hooks modifying [DEFAULT]. See LP#1583214 for details."}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a89bdaa_72b1d046","line":62,"in_reply_to":"9a89bdaa_97dc8674","updated":"2016-09-07 16:58:33.000000000","message":"Hm. How is keeping the gate_hook.sh script clean relevant to the number of tests we have for the feature? Moving the code under a separate hook will keep the file clean from dirty details like you have here.","commit_id":"c5825e18c9452e8f209914bf8b3e7b025ec9c959"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"124c2964871e7e31f62487719c2be5f8a9166bee","unresolved":false,"context_lines":[{"line_number":59,"context_line":"    ;;"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"\"api\"|\"api-pecan\"|\"full-pecan\"|\"dsvm-scenario\")"},{"line_number":62,"context_line":"    source $NEUTRON_PATH/devstack/lib/ml2"},{"line_number":63,"context_line":"    load_rc_hook api_extensions"},{"line_number":64,"context_line":"    # NOTE(ihrachys): note the order of hook post-* sections is significant: [quotas] hook should"},{"line_number":65,"context_line":"    # go before other hooks modifying [DEFAULT]. See LP#1583214 for details."}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a89bdaa_97dc8674","line":62,"in_reply_to":"9a89bdaa_fefb06bf","updated":"2016-09-07 16:40:20.000000000","message":"my opinion is to move it around and enable it, I am planning to write more tests to dns-integration, lets start from here will move it when we add more tests","commit_id":"c5825e18c9452e8f209914bf8b3e7b025ec9c959"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"e9a90d1e7dae92105551805fa7946915dabf181e","unresolved":false,"context_lines":[{"line_number":64,"context_line":"    # NOTE(ihrachys): note the order of hook post-* sections is significant: [quotas] hook should"},{"line_number":65,"context_line":"    # go before other hooks modifying [DEFAULT]. See LP#1583214 for details."},{"line_number":66,"context_line":"    load_conf_hook quotas"},{"line_number":67,"context_line":"    enable_ml2_extension_driver dns"},{"line_number":68,"context_line":"    load_rc_hook qos"},{"line_number":69,"context_line":"    load_rc_hook trunk"},{"line_number":70,"context_line":"    load_conf_hook osprofiler"}],"source_content_type":"text/x-sh","patch_set":7,"id":"9a89bdaa_1e3a6acc","line":67,"updated":"2016-09-07 10:17:41.000000000","message":"fine, but that should be part of a dns hook. as well as the line 62.","commit_id":"c5825e18c9452e8f209914bf8b3e7b025ec9c959"}],"neutron/tests/contrib/hooks/dns":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"20606b574409d2881257a15572286ec8290d0924","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_PLUGIN_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[ml2]"},{"line_number":4,"context_line":"extension_drivers\u003dport_security,dns,qos"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a89bdaa_2795d9e3","line":4,"updated":"2016-09-05 09:15:04.000000000","message":"We need some better way to avoid overriding the original value set by other hooks. Probably worth having some devstack lib code (re)used to extract the current value and append a new value, then write the result back.","commit_id":"ebe467e7e5630d4e8c0e0096b466e9a28c0b6bf8"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8b893c9dfc23ff7386d742aa33c38628867075d9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_PLUGIN_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[ml2]"},{"line_number":4,"context_line":"extension_drivers\u003dport_security,dns,qos"}],"source_content_type":"application/octet-stream","patch_set":6,"id":"9a89bdaa_5fedf523","line":4,"in_reply_to":"9a89bdaa_2795d9e3","updated":"2016-09-06 17:21:36.000000000","message":"removed and using code from devstack/lib","commit_id":"ebe467e7e5630d4e8c0e0096b466e9a28c0b6bf8"},{"author":{"_account_id":4656,"name":"Sean M. Collins","email":"sean@coreitpro.com","username":"scollins"},"change_message_id":"3bd542e5c4d174272061b6908a04dcf95c4e4e2d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"source $NEUTRON_PATH/devstack/plugin.sh"},{"line_number":2,"context_line":"source $NEUTRON_PATH/devstack/lib/ml2"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"enable_ml2_extension_driver dns"}],"source_content_type":"application/octet-stream","patch_set":8,"id":"9a89bdaa_4be972e5","line":1,"updated":"2016-09-07 20:04:51.000000000","message":"This one may or may not cause issues. My concern is re-sourcing plugin.sh again, it may reset some variables if you are not careful.","commit_id":"9c9efb9b827f340e9d6a35251d57894f0c97c632"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"19ee17a0e9a0626c245b4ae3ccd17d0d9e8a3411","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_PLUGIN_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[ml2]"},{"line_number":4,"context_line":"extension_drivers\u003dport_security,dns,qos"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9a89bdaa_00891626","line":4,"updated":"2016-09-13 10:12:40.000000000","message":"so you reverted to one of previous versions that depend on the order of hooks? Why?","commit_id":"acb44e000f6a121b62be30f1e8d4f2709946ad5d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f05bd574ea5afdab344d2b8e168f32911123004d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_PLUGIN_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[ml2]"},{"line_number":4,"context_line":"extension_drivers\u003dport_security,dns,qos"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a8ec9b2_985edfe7","line":4,"in_reply_to":"7a8ec9b2_677287e7","updated":"2016-09-14 21:52:29.000000000","message":"source devstack/plugin.sh will run the script again which can raise more issues. I\u0027ll first fix the tests adding more in next revisions once they pass then we can reckon the method to enable it.","commit_id":"acb44e000f6a121b62be30f1e8d4f2709946ad5d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"4ec676727a4f4a88472bcebd3b09a13e2dda9b33","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_PLUGIN_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[ml2]"},{"line_number":4,"context_line":"extension_drivers\u003dport_security,dns,qos"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"9a89bdaa_9a2bb481","line":4,"in_reply_to":"9a89bdaa_00891626","updated":"2016-09-13 16:30:05.000000000","message":"ihar, I wanted to test port with dns, when conf does not have dns_name set and you by default it gives openstacklocal, when i tried to update port with dns_name it was not working in this case. there are 2 reasons i went this way, enabling_ml2_extension_driver dns was not working, I was unable to see that Q_PLUGIN_DRIVER variable in the hook.","commit_id":"acb44e000f6a121b62be30f1e8d4f2709946ad5d"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"a0b5aef133a7bd1bf9744546f81475b4ec8a4f50","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[[post-config|$NEUTRON_PLUGIN_CONF]]"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"[ml2]"},{"line_number":4,"context_line":"extension_drivers\u003dport_security,dns,qos"}],"source_content_type":"application/octet-stream","patch_set":9,"id":"7a8ec9b2_677287e7","line":4,"in_reply_to":"9a89bdaa_9a2bb481","updated":"2016-09-14 07:52:49.000000000","message":"What was the problem with enabling_ml2_extension_driver apart from missing environment variable defined in devstack/plugin.sh?","commit_id":"acb44e000f6a121b62be30f1e8d4f2709946ad5d"}],"neutron/tests/tempest/api/test_networks.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fdff8d1adcb63bd098d387bd5c93292fb090fde8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        self.assertEqual(project_id, new_net[\u0027tenant_id\u0027])"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"    @test.idempotent_id(\u002794e2a44c-3367-4253-8c2a-22deaf59e96c\u0027)"},{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":126,"context_line":"                       service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_create_update_network_dns(self):"},{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_4eca0aa3","line":126,"range":{"start_line":125,"start_character":4,"end_line":126,"end_character":41},"updated":"2016-09-28 20:15:37.000000000","message":"Please see my comment to https://review.openstack.org/#/c/354447/16/neutron/tests/tempest/api/test_ports.py@44","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fdff8d1adcb63bd098d387bd5c93292fb090fde8","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(body[\u0027id\u0027],"},{"line_number":134,"context_line":"                                          dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":135,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"},{"line_number":136,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_ae1d4e11","line":133,"range":{"start_line":133,"start_character":42,"end_line":133,"end_character":52},"updated":"2016-09-28 20:15:37.000000000","message":"Nit: net_id","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"bdb080552913fda0955688b5d5a4fdddcc88928e","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(body[\u0027id\u0027],"},{"line_number":134,"context_line":"                                          dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":135,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"},{"line_number":136,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_3fe8867c","line":133,"range":{"start_line":133,"start_character":42,"end_line":133,"end_character":52},"in_reply_to":"3a98d1f4_ae1d4e11","updated":"2016-09-28 20:26:44.000000000","message":"Done","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ab3bbb9b8ea18d17fdabaa80a50e74dd76e55619","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":126,"context_line":"                       service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_create_update_network_dns(self):"},{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_52945936","line":128,"range":{"start_line":128,"start_character":46,"end_line":128,"end_character":57},"updated":"2016-10-05 12:31:30.000000000","message":"nit: perhaps define this as a variable to avoid the duplication","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f0f3168a1008bc0c71813b34a4f24f44114f02fa","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":126,"context_line":"                       service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_create_update_network_dns(self):"},{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_9c9fbc4f","line":128,"range":{"start_line":128,"start_character":46,"end_line":128,"end_character":57},"in_reply_to":"1a95cdbc_52945936","updated":"2016-10-05 17:58:27.000000000","message":"I\u0027ll do that in next revision, I was saving a line of code there.....lol","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ab3bbb9b8ea18d17fdabaa80a50e74dd76e55619","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(net_id, dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_1201f1ae","line":131,"updated":"2016-10-05 12:31:30.000000000","message":"Is there a reason to use list instead of show?","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f0f3168a1008bc0c71813b34a4f24f44114f02fa","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(net_id, dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_9cc6dc47","line":131,"in_reply_to":"1a95cdbc_1201f1ae","updated":"2016-10-05 17:58:27.000000000","message":"I followed other tests, I\u0027ll figure why is that so, if there is no reason I\u0027ll replace it with show.","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"0fa51be6b18d86886810bf64ea2256ab0e2201ee","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(net_id, dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_bfbaaa21","line":131,"in_reply_to":"1a95cdbc_9cc6dc47","updated":"2016-10-05 18:12:52.000000000","message":"IMO, the whole point of these tests is to exercise the API as widely as possible. How about doing a list here and a show in L135?","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"568e9dc7f5f7aabf9e27c2b1a3fae1cfa817a90d","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        body \u003d self.create_network(dns_domain\u003d\u0027test.org.\u0027)"},{"line_number":129,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(net_id, dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_9ff5eecc","line":131,"in_reply_to":"1a95cdbc_bfbaaa21","updated":"2016-10-05 18:16:25.000000000","message":"thanks Miguel, I\u0027ll do that","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":6635,"name":"John Davidge","email":"john.davidge@rackspace.com","username":"john-davidge"},"change_message_id":"ab3bbb9b8ea18d17fdabaa80a50e74dd76e55619","unresolved":false,"context_lines":[{"line_number":130,"context_line":"        net_id \u003d body[\u0027id\u0027]"},{"line_number":131,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":132,"context_line":"        self.assertEqual(\u0027test.org.\u0027, body[\u0027dns_domain\u0027])"},{"line_number":133,"context_line":"        body \u003d self.client.update_network(net_id, dns_domain\u003d\u0027d.org.\u0027)"},{"line_number":134,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027network\u0027][\u0027dns_domain\u0027])"},{"line_number":135,"context_line":"        body \u003d self.client.list_networks(id\u003dnet_id)[\u0027networks\u0027][0]"},{"line_number":136,"context_line":"        self.assertEqual(\u0027d.org.\u0027, body[\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_7299556e","line":133,"range":{"start_line":133,"start_character":61,"end_line":133,"end_character":69},"updated":"2016-10-05 12:31:30.000000000","message":"ditto L128","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b5cdcaafad13681891eebf99c6d9a712e173ef56","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    @test.idempotent_id(\u002794e2a44c-3367-4253-8c2a-22deaf59e96c\u0027)"},{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":126,"context_line":"                       service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_create_update_network_dns(self):"},{"line_number":128,"context_line":"        domain1 \u003d \u0027test.org.\u0027"},{"line_number":129,"context_line":"        body \u003d self.create_network(dns_domain\u003ddomain1)"},{"line_number":130,"context_line":"        self.assertEqual(domain1, body[\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a95cdbc_1bc6f299","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":38},"updated":"2016-10-07 15:00:17.000000000","message":"Since I am proposing you roll another patchset, how about renaming this test case test_create_update_network_with_dns_domain","commit_id":"1edca75e1830b5e562febc649e80c91c88427297"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3d043bc05c6c4618f84a7114a1db2cfd1b4a8251","unresolved":false,"context_lines":[{"line_number":124,"context_line":"    @test.idempotent_id(\u002794e2a44c-3367-4253-8c2a-22deaf59e96c\u0027)"},{"line_number":125,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":126,"context_line":"                       service\u003d\"network\")"},{"line_number":127,"context_line":"    def test_create_update_network_dns(self):"},{"line_number":128,"context_line":"        domain1 \u003d \u0027test.org.\u0027"},{"line_number":129,"context_line":"        body \u003d self.create_network(dns_domain\u003ddomain1)"},{"line_number":130,"context_line":"        self.assertEqual(domain1, body[\u0027dns_domain\u0027])"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a95cdbc_41a9688f","line":127,"range":{"start_line":127,"start_character":8,"end_line":127,"end_character":38},"in_reply_to":"1a95cdbc_1bc6f299","updated":"2016-10-07 17:21:24.000000000","message":"Done","commit_id":"1edca75e1830b5e562febc649e80c91c88427297"}],"neutron/tests/tempest/api/test_ports.py":[{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_internal_dns_name(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_651d350f","line":44,"updated":"2016-09-13 20:14:36.000000000","message":"With the dns integration extension enabled and the default dns_domain in neutron.conf (\u0027openstacklocal\u0027), the dns data in dnsmasq becomes visible in the API, in attribute dns_assignment. In this test case you can also verify the correctness of this attribute. This is an example of what you get for a port whose fixed ipv4 address is 10.0.0.2 and fixed ipv6 address is fdff:91f4:e046:0:f816:3eff:fe06:bbed: http://paste.openstack.org/show/574807/","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8168d2e38feb2e3bfea973d80356aeec2bcede10","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_internal_dns_name(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_ea0c6996","line":44,"in_reply_to":"7a8ec9b2_651d350f","updated":"2016-09-14 21:49:53.000000000","message":"will add a separate test to check dns_assignment is not none and visible after extension is enabled with internal dns\nand also fqdn is host.openstacklocal.","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_internal_dns_name(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_c57369b3","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":49},"updated":"2016-09-13 20:14:36.000000000","message":"I would rename this tests case to test_create_update_port_with_default_dns_domain and adjust comment in L47 accordingly","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8168d2e38feb2e3bfea973d80356aeec2bcede10","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_internal_dns_name(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_4a22bd02","line":46,"range":{"start_line":46,"start_character":8,"end_line":46,"end_character":49},"in_reply_to":"7a8ec9b2_c57369b3","updated":"2016-09-14 21:49:53.000000000","message":"done","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_internal_dns_name(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"},{"line_number":50,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_e503050c","line":47,"range":{"start_line":47,"start_character":47,"end_line":47,"end_character":52},"updated":"2016-09-13 20:14:36.000000000","message":"null string or \u0027\u0027","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8168d2e38feb2e3bfea973d80356aeec2bcede10","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_internal_dns_name(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"},{"line_number":50,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_8a1cc5c2","line":47,"range":{"start_line":47,"start_character":47,"end_line":47,"end_character":52},"in_reply_to":"7a8ec9b2_e503050c","updated":"2016-09-14 21:49:53.000000000","message":"done","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"},{"line_number":50,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":51,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":52,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":53,"context_line":"        body \u003d self.client.update_port(body[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_537486ce","line":50,"updated":"2016-09-13 20:14:36.000000000","message":"In this case, the port\u0027s dns_name value is going to be \u0027\u0027, not None","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"8168d2e38feb2e3bfea973d80356aeec2bcede10","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"},{"line_number":50,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":51,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":52,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":53,"context_line":"        body \u003d self.client.update_port(body[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_ea8389ca","line":50,"in_reply_to":"7a8ec9b2_537486ce","updated":"2016-09-14 21:49:53.000000000","message":"done","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"},{"line_number":50,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":51,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":52,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":53,"context_line":"        body \u003d self.client.update_port(body[\u0027id\u0027],"},{"line_number":54,"context_line":"                                       dns_name\u003d\u0027d2\u0027)"},{"line_number":55,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_f33af2e6","line":52,"updated":"2016-09-13 20:14:36.000000000","message":"Please see comment to L50","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":52,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":53,"context_line":"        body \u003d self.client.update_port(body[\u0027id\u0027],"},{"line_number":54,"context_line":"                                       dns_name\u003d\u0027d2\u0027)"},{"line_number":55,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":56,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027port\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":57,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_932c4ead","line":55,"updated":"2016-09-13 20:14:36.000000000","message":"Please see comment to L50","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"00a31d4944ff849d25eeaa1b89ec73e0ba606f86","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                                       dns_name\u003d\u0027d2\u0027)"},{"line_number":55,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":56,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027port\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":57,"context_line":"        self.assertIsNone(body[\u0027dns_name\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027c72c1c0c-2193-4aca-bbb4-b1442640c123\u0027)"},{"line_number":60,"context_line":"    def test_change_dhcp_flag_then_create_port(self):"}],"source_content_type":"text/x-python","patch_set":11,"id":"7a8ec9b2_b3178a53","line":57,"updated":"2016-09-13 20:14:36.000000000","message":"Please see comment to L50","commit_id":"98880f563c6120685e75714a2476a70ad74f4760"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"576bff15d44ba2784ceb17c709281c91223a5c0f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_with_default_dns_domain(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be empty"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"},{"line_number":50,"context_line":"        self.assertEqual(\u0027\u0027, body[\u0027dns_name\u0027])"}],"source_content_type":"text/x-python","patch_set":13,"id":"7a8ec9b2_cb26ccb9","line":47,"range":{"start_line":47,"start_character":47,"end_line":47,"end_character":52},"updated":"2016-09-14 23:50:02.000000000","message":"should\u0027ve fix this, will fix in next revision after reviews","commit_id":"6b8baa078ebb4ceb32095036a3a7e1c1e7ef87b0"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fdff8d1adcb63bd098d387bd5c93292fb090fde8","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_with_default_dns_domain(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be null or \u0027\u0027"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_cb936cf9","line":45,"range":{"start_line":44,"start_character":4,"end_line":45,"end_character":41},"updated":"2016-09-28 20:15:37.000000000","message":"Even though I have DNS integration enabled in my test environment, I couldn\u0027t get the test case to run because Tempest doesn\u0027t detect that the extension is enabled. I had to remove these 2 lines to run the test case. Please investigate why this is happening","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ba73aa006d360b85b3ee0acc73e802d5124a7455","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027description\u0027])"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_with_default_dns_domain(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be null or \u0027\u0027"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_3ffec66b","line":45,"range":{"start_line":44,"start_character":4,"end_line":45,"end_character":41},"in_reply_to":"3a98d1f4_cb936cf9","updated":"2016-09-28 20:23:25.000000000","message":"I doubt your tempest have stale conf, check in your tempest/etc/tempest.conf have dns-integration enabled in \n\n[network-feature-enabled]\napi_extensions \u003d append dns-integration here, I think if you may have your old venv but if you enable extension and create new venv then it will populate extension in tempest conf","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fdff8d1adcb63bd098d387bd5c93292fb090fde8","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_with_default_dns_domain(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be null or \u0027\u0027"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_4bb67c8b","line":46,"updated":"2016-09-28 20:15:37.000000000","message":"Tis test case run perfectly in my test environment","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ba73aa006d360b85b3ee0acc73e802d5124a7455","unresolved":false,"context_lines":[{"line_number":43,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":44,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":45,"context_line":"                       service\u003d\"network\")"},{"line_number":46,"context_line":"    def test_create_update_port_with_default_dns_domain(self):"},{"line_number":47,"context_line":"        # with internal dns dns_name should be null or \u0027\u0027"},{"line_number":48,"context_line":"        body \u003d self.create_port(self.network,"},{"line_number":49,"context_line":"                                dns_name\u003d\u0027d1\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_bff2d698","line":46,"in_reply_to":"3a98d1f4_4bb67c8b","updated":"2016-09-28 20:23:25.000000000","message":"yea it runs perfect if dns_domain in conf is openstacklocal \n\nbut somewhere in code its getting set to openstackgate.local to same test ps17 would work fine","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fdff8d1adcb63bd098d387bd5c93292fb090fde8","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        self.assertEqual(\u0027\u0027, body[\u0027dns_name\u0027])"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    @test.idempotent_id(\u0027435e89df-a8bb-4b41-801a-9f20d362d777\u0027)"},{"line_number":60,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":61,"context_line":"                       service\u003d\"network\")"},{"line_number":62,"context_line":"    def test_create_port_has_attribute_dns_assignment(self):"},{"line_number":63,"context_line":"        body \u003d self.create_port(self.network)"},{"line_number":64,"context_line":"        port_body \u003d self.client.show_port(body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_0b63941b","line":61,"range":{"start_line":60,"start_character":4,"end_line":61,"end_character":41},"updated":"2016-09-28 20:15:37.000000000","message":"See comment to L44-45","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"fdff8d1adcb63bd098d387bd5c93292fb090fde8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                       service\u003d\"network\")"},{"line_number":62,"context_line":"    def test_create_port_has_attribute_dns_assignment(self):"},{"line_number":63,"context_line":"        body \u003d self.create_port(self.network)"},{"line_number":64,"context_line":"        port_body \u003d self.client.show_port(body[\u0027id\u0027])"},{"line_number":65,"context_line":"        # Note(manjeets) port should get dns_assignment by default"},{"line_number":66,"context_line":"        self.assertIsNotNone(port_body[\u0027port\u0027][\u0027dns_assignment\u0027])"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_6b409857","line":64,"updated":"2016-09-28 20:15:37.000000000","message":"The response you get here is the following: http://paste.openstack.org/show/583360/. Note that dns_assignment is []. This is because, since the network where you are creating the port has no subnets, fixed_ips is []. If you added a subnet in this test case to the network before creating the port, you could implement a more complete test case, verifying the contents of the dns_assignment attribute. The port created would look like: http://paste.openstack.org/show/583364/. Please note that in this example, the port has ipv4 and ipv6 addresses. I recommend that you only add an ipv4 subnet to the network","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ba73aa006d360b85b3ee0acc73e802d5124a7455","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                       service\u003d\"network\")"},{"line_number":62,"context_line":"    def test_create_port_has_attribute_dns_assignment(self):"},{"line_number":63,"context_line":"        body \u003d self.create_port(self.network)"},{"line_number":64,"context_line":"        port_body \u003d self.client.show_port(body[\u0027id\u0027])"},{"line_number":65,"context_line":"        # Note(manjeets) port should get dns_assignment by default"},{"line_number":66,"context_line":"        self.assertIsNotNone(port_body[\u0027port\u0027][\u0027dns_assignment\u0027])"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3a98d1f4_ff11beb0","line":64,"in_reply_to":"3a98d1f4_6b409857","updated":"2016-09-28 20:23:25.000000000","message":"lets have this test +  a separate test with subnet as well ? how about that ?","commit_id":"5ef4642c3635a132951224dd945a9b501b66ffdc"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"26eff4a07d8e582eeef3b14bbba40492340889e1","unresolved":false,"context_lines":[{"line_number":61,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":62,"context_line":"                       service\u003d\"network\")"},{"line_number":63,"context_line":"    def test_create_port_has_attribute_dns_assignment(self):"},{"line_number":64,"context_line":"        s \u003d self.create_subnet(self.network, enable_dhcp\u003dFalse)"},{"line_number":65,"context_line":"        body \u003d self.create_port(self.network)"},{"line_number":66,"context_line":"        self.client.update_subnet(s[\u0027id\u0027], enable_dhcp\u003dTrue)"},{"line_number":67,"context_line":"        port_body \u003d self.client.show_port(body[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_7e9c8dc0","line":64,"range":{"start_line":64,"start_character":43,"end_line":64,"end_character":62},"updated":"2016-09-29 21:47:40.000000000","message":"This doesn\u0027t add any value to this test case. In fact, this line can be just:\n\nself.create_subnet(self.network)\n\nI ran the test without it successfully","commit_id":"8102aa3a4b0bf14e935ad7624742e1ae7fbc36c5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"26eff4a07d8e582eeef3b14bbba40492340889e1","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def test_create_port_has_attribute_dns_assignment(self):"},{"line_number":64,"context_line":"        s \u003d self.create_subnet(self.network, enable_dhcp\u003dFalse)"},{"line_number":65,"context_line":"        body \u003d self.create_port(self.network)"},{"line_number":66,"context_line":"        self.client.update_subnet(s[\u0027id\u0027], enable_dhcp\u003dTrue)"},{"line_number":67,"context_line":"        port_body \u003d self.client.show_port(body[\u0027id\u0027])"},{"line_number":68,"context_line":"        # Note(manjeets) port should get dns_assignment by default"},{"line_number":69,"context_line":"        # and if port is created with network having subnet then it"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_5eb6f13d","line":66,"updated":"2016-09-29 21:47:40.000000000","message":"This line doesn\u0027t add any value to this test. I think we should remove it. I ran the test case without it successfully","commit_id":"8102aa3a4b0bf14e935ad7624742e1ae7fbc36c5"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"f64cb77d4af1bc1d1380b107d7bd0d665acfb4cd","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                       dns_name\u003d\u0027d2\u0027)"},{"line_number":75,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027port\u0027][\u0027dns_name\u0027])"},{"line_number":76,"context_line":"        self._confirm_dns_assignment(body[\u0027port\u0027])"},{"line_number":77,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027port\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":78,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027dns_name\u0027])"},{"line_number":79,"context_line":"        self._confirm_dns_assignment(body)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_f2ff09ff","line":77,"updated":"2016-10-05 18:31:17.000000000","message":"So let\u0027s follow the same idea as in the networks test case. Let\u0027s do a show in this line to complement the list in L70","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"56cec5557c7d0e410da84a8ceaf574d938b33d31","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                                       dns_name\u003d\u0027d2\u0027)"},{"line_number":75,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027port\u0027][\u0027dns_name\u0027])"},{"line_number":76,"context_line":"        self._confirm_dns_assignment(body[\u0027port\u0027])"},{"line_number":77,"context_line":"        body \u003d self.client.list_ports(id\u003dbody[\u0027port\u0027][\u0027id\u0027])[\u0027ports\u0027][0]"},{"line_number":78,"context_line":"        self.assertEqual(\u0027d2\u0027, body[\u0027dns_name\u0027])"},{"line_number":79,"context_line":"        self._confirm_dns_assignment(body)"},{"line_number":80,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"1a95cdbc_b27821f4","line":77,"in_reply_to":"1a95cdbc_f2ff09ff","updated":"2016-10-05 18:47:59.000000000","message":"Done","commit_id":"0556daa3e34d11cc9c10bbaf2f677b61ad474185"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"b5cdcaafad13681891eebf99c6d9a712e173ef56","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":61,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":62,"context_line":"                       service\u003d\"network\")"},{"line_number":63,"context_line":"    def test_create_update_port_with_default_dns_name(self):"},{"line_number":64,"context_line":"        # NOTE(manjeets) dns_domain is set to openstackgate.local"},{"line_number":65,"context_line":"        # so dns_name for port can be set"},{"line_number":66,"context_line":"        self.create_subnet(self.network)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a95cdbc_db548aff","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":53},"updated":"2016-10-07 15:00:17.000000000","message":"When I proposed to re-structure these two test cases to increase coverage, I proposed to rename this one as test_create_update_port_with_dns_name: https://gist.github.com/miguellavalle/6a2fa8b6fda3c2414a189715507c2d99#file-gistfile1-txt-L4. The distinction is important, because the default dns_name is \u0027\u0027. This is not what we are doing in this test case. Sorry for not noting this before","commit_id":"1edca75e1830b5e562febc649e80c91c88427297"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"3d043bc05c6c4618f84a7114a1db2cfd1b4a8251","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @test.idempotent_id(\u0027539fbefe-fb36-48aa-9a53-8c5fbd44e492\u0027)"},{"line_number":61,"context_line":"    @test.requires_ext(extension\u003d\"dns-integration\","},{"line_number":62,"context_line":"                       service\u003d\"network\")"},{"line_number":63,"context_line":"    def test_create_update_port_with_default_dns_name(self):"},{"line_number":64,"context_line":"        # NOTE(manjeets) dns_domain is set to openstackgate.local"},{"line_number":65,"context_line":"        # so dns_name for port can be set"},{"line_number":66,"context_line":"        self.create_subnet(self.network)"}],"source_content_type":"text/x-python","patch_set":22,"id":"1a95cdbc_61ae6499","line":63,"range":{"start_line":63,"start_character":8,"end_line":63,"end_character":53},"in_reply_to":"1a95cdbc_db548aff","updated":"2016-10-07 17:21:24.000000000","message":"Done","commit_id":"1edca75e1830b5e562febc649e80c91c88427297"}]}
