)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1c508c9826c83fb9e527cb9413b47c7d7db1ab2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad45d7e_42b8f3e5","line":15,"updated":"2016-08-12 20:17:12.000000000","message":"Partial-Bug: #1597913","commit_id":"9cef60049d2a6623ac5b51b9f2cd9cc9237115f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"0f7118627769b7f31e1f40a904e58d03f001de38","unresolved":false,"context_lines":[{"line_number":10,"context_line":"objects for router route  which has db models definition and mixins"},{"line_number":11,"context_line":"in same file, this patch will refactor router route models."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I6b71ab19cc7184ecbcde8808b95ef838379f0a39"},{"line_number":14,"context_line":"Co-Authored-By: Victor Morales \u003cvictor.morales@intel.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"fa7ab95a_9bdd2073","line":13,"updated":"2016-08-26 12:21:05.000000000","message":"all those patches must mention the bug.\n\nCloses-Bug: #1597913","commit_id":"e5635cf1ebac9d04cb12a6a98c374ca0a70d053c"}],"neutron/db/extraroute_db.py":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"104164113cb3059504e595474fe46836bc02745f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad45d7e_8fd7b4be","updated":"2016-08-12 19:59:54.000000000","message":"we need to be bit careful on organizing models, we may want to categorize and have common models in same file, like consolidating all objects related to resource like Ihar did in https://review.openstack.org/#/c/351368/12/neutron/objects/ports.py@138 . for ports.","commit_id":"9cef60049d2a6623ac5b51b9f2cd9cc9237115f0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"14d2a625649a9ecc62992c6bdbd8f077238890d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"3ac371cc_74e6d4e8","in_reply_to":"7ac969e8_d794c3e9","updated":"2016-08-18 11:17:19.000000000","message":"I agree to have it in neutron/db/models/router.py.\n\nIf so, is it better to split models/l3.py in https://review.openstack.org/#/c/348562 to models/router.py and models/floatingip.py? All router related stuffs can be defined in router.py.","commit_id":"9cef60049d2a6623ac5b51b9f2cd9cc9237115f0"},{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"28f3420a306d097da927f810fd13f743d2bf0a72","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7ac969e8_d794c3e9","in_reply_to":"9ad45d7e_02d71b24","updated":"2016-08-13 08:52:03.000000000","message":"I would have it in neutron/db/models/router.py, the file that would include other router related models later.","commit_id":"9cef60049d2a6623ac5b51b9f2cd9cc9237115f0"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"1c508c9826c83fb9e527cb9413b47c7d7db1ab2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9ad45d7e_02d71b24","in_reply_to":"9ad45d7e_8fd7b4be","updated":"2016-08-12 20:17:12.000000000","message":"So, what\u0027s the suggestion on this?","commit_id":"9cef60049d2a6623ac5b51b9f2cd9cc9237115f0"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e79d8292b29047b9214911f96bb8260ac586437e","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_74a41407","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"updated":"2016-08-18 11:23:37.000000000","message":"sys is a standard module. You need to do:\n\n  import sys\n\n  import netaddr\n  import oslo_config import cfg\n  ...","commit_id":"6d3fce1605a43bcddccc97fef5fed2f283c3890b"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"3990a661b34fdf357083ddcc39e6bc1a3c53b6a6","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"import netaddr"},{"line_number":17,"context_line":"import sys"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"from oslo_config import cfg"},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"3ac371cc_e19796e9","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":10},"in_reply_to":"3ac371cc_74a41407","updated":"2016-08-18 15:36:29.000000000","message":"Done","commit_id":"6d3fce1605a43bcddccc97fef5fed2f283c3890b"},{"author":{"_account_id":6524,"name":"Henry Gessau","email":"HenryG@gessau.net","username":"gessau"},"change_message_id":"3b2012c22122a70aecc7fb3f88ff9d9f1db92401","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":171,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":172,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), l3_model)"},{"line_number":173,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":11,"id":"fa7ab95a_ed1cb515","line":172,"updated":"2016-08-31 12:46:57.000000000","message":"Needs updating now that https://review.openstack.org/352601 has merged. Please follow the deprecation examples from that patch.","commit_id":"3605dfed858aff72d4142eb43f9ab9299da39842"},{"author":{"_account_id":8726,"name":"Victor Morales","email":"chipahuac@hotmail.com","username":"electrocucaracha"},"change_message_id":"761e284cae52d259df36f98382fdadc799e8b465","unresolved":false,"context_lines":[{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":169,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":170,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), router_models)"},{"line_number":171,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":23,"id":"7a8ec9b2_a64d78c6","line":169,"updated":"2016-09-19 17:52:17.000000000","message":"F821 undefined name \u0027sys\u0027\n\nThis has to be changed to use the new way","commit_id":"b64c03b05ef32b3f8313dd7b56384f08d3be8c40"},{"author":{"_account_id":4694,"name":"Miguel Lavalle","email":"miguel@mlavalle.com","username":"minsel"},"change_message_id":"785e8c2235e4a04dc1bc8d510082c2811c9c4e95","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    pass"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":169,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":170,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), router_models)"},{"line_number":171,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_697350e8","line":171,"range":{"start_line":168,"start_character":0,"end_line":171,"end_character":58},"updated":"2016-09-27 21:12:28.000000000","message":"I think you are using the old way to do this. For an example on how to do this properly, please look at: https://review.openstack.org/#/c/348757/20/neutron/db/metering/metering_db.py\n\nPlease look at lines 28 - 29 and 253","commit_id":"e889f63e9f5b329f533569c71a5641f5780fed1c"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"df9bea6cd6e1d279849d7e29addfdf641ab44f9a","unresolved":false,"context_lines":[{"line_number":165,"context_line":"    pass"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"},{"line_number":169,"context_line":"_OLD_REF \u003d sys.modules[__name__]"},{"line_number":170,"context_line":"sys.modules[__name__] \u003d _deprecate._DeprecateSubset(globals(), router_models)"},{"line_number":171,"context_line":"# WARNING: THESE MUST BE THE LAST TWO LINES IN THIS MODULE"}],"source_content_type":"text/x-python","patch_set":31,"id":"5a8bc5a2_d086c515","line":171,"range":{"start_line":168,"start_character":0,"end_line":171,"end_character":58},"in_reply_to":"5a8bc5a2_697350e8","updated":"2016-09-27 23:19:48.000000000","message":"Hi Miguel, every time [1] uploads a patch, this patch gets reverted back to the old one. Have corrected it now.\n\n[1] https://review.openstack.org/#/c/353541/","commit_id":"e889f63e9f5b329f533569c71a5641f5780fed1c"}],"neutron/db/models/l3.py":[{"author":{"_account_id":7715,"name":"Hirofumi Ichihara","email":"ichihara.hirofumi@gmail.com","username":"Hirofumi-Ichihara"},"change_message_id":"f6547643a5eae4b3dcee5bab0318758b70dd4509","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013, Nachi Ueno, NTT MCL, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_07e43b39","line":1,"updated":"2016-08-25 07:17:30.000000000","message":"This file name conflicts with the other[1]. And also it may be better to integrate RouterRoute class into [1]. There was the discussion[2]. Could you consider it?\n\n[1]: https://review.openstack.org/#/c/348562/28/neutron/db/models/l3.py\n[2]: http://eavesdrop.openstack.org/irclogs/%23openstack-neutron/%23openstack-neutron.2016-08-18.log.html#t2016-08-18T15:53:00","commit_id":"e5635cf1ebac9d04cb12a6a98c374ca0a70d053c"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"6ae253dfa828c91dd380bb724447a8c539879bc2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2013, Nachi Ueno, NTT MCL, Inc."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":7,"id":"1ac06dbe_cc585afd","line":1,"in_reply_to":"1ac06dbe_07e43b39","updated":"2016-08-25 18:44:30.000000000","message":"Sure. I used the same filename \"l3.py\" as [1]. Won\u0027t I get a merge conflict once [1] gets merged? Pls correct me if I am wrong.","commit_id":"e5635cf1ebac9d04cb12a6a98c374ca0a70d053c"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"b83dafd1bf29b25f7484426b323f1e1a8247735d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"fa7ab95a_29f3dc9f","updated":"2016-08-26 15:46:51.000000000","message":"this patch need to add dependency on https://review.openstack.org/#/c/348562/28/neutron/db/models/l3.py , we can\u0027t accept same path, for this, RouterRoute should be accomodated in same file in above patch","commit_id":"6a6558285074fc5ffe09c04379bc61f48cc2666d"}],"neutron/db/models/router.py":[{"author":{"_account_id":9656,"name":"Ihar Hrachyshka","email":"ihrachys@redhat.com","username":"ihrachys","status":"Red Hat Networking Systems Engineer"},"change_message_id":"1a98597a0a3712dbd9b7b5188c1c35bc60c8119d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.db import models_v2"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RouterRoute(model_base.BASEV2, models_v2.Route):"},{"line_number":25,"context_line":"    router_id \u003d sa.Column(sa.String(36),"},{"line_number":26,"context_line":"                          sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":27,"context_line":"                                        ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a8bc5a2_aad60fc3","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":35},"updated":"2016-09-22 15:27:43.000000000","message":"that should come from neutron-lib.","commit_id":"759003c4d5f48246393fac570801c8f91e280942"},{"author":{"_account_id":22218,"name":"Sindhu Devale","email":"sindhu.devale@intel.com","username":"sindhudevale"},"change_message_id":"aa6c28872931c6e6abdbd262b7fcba99f811ee67","unresolved":false,"context_lines":[{"line_number":21,"context_line":"from neutron.db import models_v2"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"class RouterRoute(model_base.BASEV2, models_v2.Route):"},{"line_number":25,"context_line":"    router_id \u003d sa.Column(sa.String(36),"},{"line_number":26,"context_line":"                          sa.ForeignKey(\u0027routers.id\u0027,"},{"line_number":27,"context_line":"                                        ondelete\u003d\"CASCADE\"),"}],"source_content_type":"text/x-python","patch_set":24,"id":"5a8bc5a2_6dab3c8a","line":24,"range":{"start_line":24,"start_character":29,"end_line":24,"end_character":35},"in_reply_to":"5a8bc5a2_aad60fc3","updated":"2016-09-22 16:55:26.000000000","message":"Done","commit_id":"759003c4d5f48246393fac570801c8f91e280942"}]}